https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Pedro Amorim changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #48 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||23.11.00
release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Attachment #155724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Attachment #155723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Attachment #155722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Attachment #155721|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #155717|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #155716|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #155715|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #155714|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #39 from Phil Ringnalda ---
Test pass? Copy, move, and insert all have the same ordering behavior?
THAT'S THE PATCHSET I'VE BEEN LOOKING FOR!
Thanks, Nick!
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Assignee|arthur.suz...@biblibre.com |n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment #3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #37 from Nick Clemens ---
Created attachment 155717
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155717&action=edit
Bug 24480: (follow-up) Adjust tests
With the way the patchset alters to use insert_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #36 from Nick Clemens ---
Created attachment 155716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155716&action=edit
Bug 24480: (follow-up) Shift new fields into array and add after all are copied
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #35 from Nick Clemens ---
Created attachment 155715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155715&action=edit
Bug 24480: Unit test
This updates the SimpleMARC tests and MarcModificationTemplate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Attachment #150665|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #33 from Jonathan Druart ---
Arthur, can you provide feedback here please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #32 from Phil Ringnalda ---
Do things typically become not-FQA from reasons outside the bug?
The patches in this bug have always chosen to implement move with
insert_grouped_field, which puts a 600 after a 690, rather th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #28 from Phil Ringnalda ---
Comment on attachment 150666
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150666
Bug 24480: Unit test
>diff --git a/Koha/SimpleMARC.pm b/Koha/SimpleMARC.pm
>index 0c95ccf8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #27 from Phil Ringnalda ---
And that does work: $record->insert_fields_ordered( reverse( @new_fields ) );
will copy/move "First" "Second" to "First" "Second". Just requires a little
more test adjustment.
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #26 from Phil Ringnalda ---
Why use insert_grouped_field for move rather than insert_fields_ordered?
My vague memory of looking at it in 2020 says that it's because just using
$record->insert_fields_ordered( @new_fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #25 from Nick Clemens ---
Created attachment 150666
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150666&action=edit
Bug 24480: Unit test
This updates the SimpleMARC tests and MarcModificationTemplate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Attachment #98975|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Katrin Fischer changed:
What|Removed |Added
Summary|Fields added with Marc |Fields added with MARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Esther Melander changed:
What|Removed |Added
CC||esth...@sodaspringsid.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #23 from Arthur Suzuki ---
is this patch still failed QA?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #112312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #98976|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #112311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #21 from Phil Ringnalda ---
Well, that's fun: I put it in expected_record_1 where it belongs, and wound up
with a patch that actually says it's in new_record rather than one that says it
isn't but winds up putting it ther
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
Attachment #98976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #19 from Phil Ringnalda ---
There are two causes for the test failures.
The first is that git bz apply uses far too much fuzz, and happily applies the
first hunk of attachment 98976 to sub new_record rather than to sub
e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #18 from Katrin Fischer ---
Phil, let's give this another go. I wanted to set back to "Needs Signoff", but
the tests are failing. Can you please have a look at them first?
Test Summary Report
---
t/db_dep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #17 from Phil Ringnalda ---
I filed bug 26716 for more choices about where to insert fields, and bug 26717
for choices about where to insert subfields.
Leaving at Failed QA for the mix of insert_fields_ordered and
insert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #16 from Phil Ringnalda ---
Katrin: yes, please!
Given the code and the complexity of the problems, there are three separate
bugs:
* this one about changing field insertion from clearly wrong to the better of
two other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #15 from Katrin Fischer ---
Hi Phil,
sorry I misunderstand, but are you suggesting we handle fields and subfields on
separate bug reports?
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Phil Ringnalda changed:
What|Removed |Added
CC||p...@chetcolibrary.org
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Failed QA
--- Comment #13
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #12 from Michael Sutherland ---
I recently modified a few hundred thousand records and Koha put all the 582$b
tags after the 999 tags not in order. It should be easily understandable that
5xx tags do not come after 9xx ta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Michael Sutherland changed:
What|Removed |Added
CC||sudrl...@vt.edu
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #10 from Jonathan Druart
---
*** Bug 25908 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Kelly McElligott changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #8 from Arthur Suzuki ---
done, sry for the delay :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #7 from Arthur Suzuki ---
Created attachment 106621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106621&action=edit
Bug 24480: (QA follow-up)
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
Patch compl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Kelly McElligott changed:
What|Removed |Added
CC||ke...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
ByWater Sandboxes changed:
What|Removed |Added
Attachment #97944|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
ByWater Sandboxes changed:
What|Removed |Added
Attachment #97945|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Arthur Suzuki changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #3 from Arthur Suzuki ---
Created attachment 97945
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97945&action=edit
Bug 24480: Unit test
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Arthur Suzuki changed:
What|Removed |Added
Attachment #97695|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Arthur Suzuki changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
--- Comment #1 from Arthur Suzuki ---
Created attachment 97695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97695&action=edit
Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC
Test plan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
Arthur Suzuki changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com
67 matches
Mail list logo
