[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #13 from Joy Nelson --- Does not apply to 19.11.x branch. Please Rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #12 from Katrin Fischer --- If you are still interested in me testing again, please ping me when you are back from vacation - but I believe it's probably fine! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #10 from Jonathan Druart --- Created attachment 98823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98823&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Jonathan Druart changed: What|Removed |Added Attachment #98592|0 |1 is obsolete|| Attachment #98593|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 98822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98822&action=edit Bug 24611: Regression test Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #7) > Just what I thought - I think it's my environment. Katrina, it would be interesting to see the output of you add use Data::Printer colored => 1; p($t->tx->res); After the failed test. It might highlight something important (bad handling on error conditions). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #7 from Katrin Fischer --- Just what I thought - I think it's my environment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #6 from Tomás Cohen Arazi --- Katirna, I don't manage to reproduce: (base) ✔ ~/git/koha [qa_24611 ↑·2|⚑ 13] 11:52 $ git reset --hard origin/master HEAD is now at 99e2fbd083 Bug 13193: (RM follow-up) Remove Cache::Memcached::Fast from PerlDependencies (base) ✔ ~/git/koha [qa_24611|⚑ 13] 11:53 $ git bz apply 24611 Bug 24611 - Wrong budget_id query parameter in /acquisitions/orders 98592 - Bug 24611: Regression test 98593 - Bug 24611: Fix wrong budget_id query param in /acquisitions/orders Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24611: Regression test Applying: Bug 24611: Fix wrong budget_id query param in /acquisitions/orders (base) ✔ ~/git/koha [qa_24611 ↑·2|⚑ 13] 11:53 $ kshell root@d749cd762ad3:kohadevbox$ kshell kohadev-koha@d749cd762ad3:/kohadevbox/koha$ prove t/db_dependent/api/v1/acquisitions_orders.t t/db_dependent/api/v1/acquisitions_orders.t .. ok All tests successful. Files=1, Tests=5, 22 wallclock secs ( 0.05 usr 0.02 sys + 12.53 cusr 2.75 csys = 15.35 CPU) Result: PASS kohadev-koha@d749cd762ad3:/kohadevbox/koha$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #5 from Katrin Fischer --- Test is not happy on my system - leaving this Signed Off as I think they passed for David and Tomas: # Failed test 'SWAGGER3.2.2' # at t/db_dependent/api/v1/acquisitions_orders.t line 65. # got: '500' # expected: '200' # Failed test 'has value for JSON Pointer "/14/order_id"' # at t/db_dependent/api/v1/acquisitions_orders.t line 65. # Looks like you failed 2 tests of 8. t/db_dependent/api/v1/acquisitions_orders.t .. 1/5 # Failed test 'list() tests' # at t/db_dependent/api/v1/acquisitions_orders.t line 97. t/db_dependent/api/v1/acquisitions_orders.t .. 5/5 # Looks like you failed 1 test of 5. t/db_dependent/api/v1/acquisitions_orders.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report --- t/db_dependent/api/v1/acquisitions_orders.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=5, 16 wallclock secs ( 0.02 usr 0.02 sys + 11.47 cusr 1.89 csys = 13.40 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] Wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Katrin Fischer changed: What|Removed |Added Summary|wrong budget_id query |Wrong budget_id query |parameter in|parameter in |/acquisitions/orders|/acquisitions/orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What|Removed |Added Attachment #98563|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 98593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98593&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What|Removed |Added Attachment #98562|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 98592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98592&action=edit Bug 24611: Regression test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||ere.maij...@helsinki.fi, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 98563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98563&action=edit Bug 24611: Fix wrong budget_id query param in /acquisitions/orders This patch fixes the wrong query parameter that slipped on rewriting the patches for the voted RFC. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail because fund_id is not a valid query parameter 3. Apply this patch 4. Repeat (2) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 98562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98562&action=edit Bug 24611: Regression test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24611] wrong budget_id query parameter in /acquisitions/orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 Tomás Cohen Arazi changed: What|Removed |Added Depends on||18731 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/