[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26043 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I got another random failure, but not related to bug 22284. First time I see > it I think. > For the record: > t/db_dependent/Holds.t .. 1/61 > # Failed test 'Test ModReserveMinusPriority()' > # at t/db_dependent/Holds.t line 203. > # got: undef > # expected: '2304' > t/db_dependent/Holds.t .. 61/61 # Looks like you failed 1 test of 61. See bug 26043 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Katrin Fischer changed: What|Removed |Added Component|Hold requests |Test Suite -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #11 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Tests only and all look like sane and sensible changes to me. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
--- Comment #8 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #3)
> Comment on attachment 98884 [details] [review]
> Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
>
> Review of attachment 98884 [details] [review]:
> -
>
> ::: t/db_dependent/Koha/Item.t
> @@ +173,5 @@
> > +my $root2 = $builder->build_object( { class =>
> > 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode =>
> > undef } } );
> > +my $library1 = $builder->build_object( { class => 'Koha::Libraries',
> > value => { pickup_location => 1, branchcode => 'TEST1' } } );
> > +my $library2 = $builder->build_object( { class => 'Koha::Libraries',
> > value => { pickup_location => 1, branchcode => 'TEST2' } } );
> > +my $library3 = $builder->build_object( { class => 'Koha::Libraries',
> > value => { pickup_location => 0, branchcode => 'TEST3' } } );
> > +my $library4 = $builder->build_object( { class => 'Koha::Libraries',
> > value => { pickup_location => 1, branchcode => 'TEST4' } } );
>
> Do you really need to specify a branchcode here?
Ups, that slipped away.. I used it to verify which libraries where tested, and
when a library without one of those branchcodes appeared I realized that
somewhere they where created.
Thanks for the patch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #7 from Jonathan Druart --- Thanks Agustin, good catch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #6 from Jonathan Druart --- Created attachment 98918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98918=edit Bug 24657: Do not explicitely pass a branchcode Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
Jonathan Druart changed:
What|Removed |Added
Attachment #98884|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart
---
Created attachment 98917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98917=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this
my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this
my $library1 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
To test:
1. do not apply this patch
2. in bash:
for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 --- Comment #4 from Jonathan Druart --- I got another random failure, but not related to bug 22284. First time I see it I think. For the record: t/db_dependent/Holds.t .. 1/61 # Failed test 'Test ModReserveMinusPriority()' # at t/db_dependent/Holds.t line 203. # got: undef # expected: '2304' t/db_dependent/Holds.t .. 61/61 # Looks like you failed 1 test of 61. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
--- Comment #3 from Jonathan Druart
---
Comment on attachment 98884
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
Review of attachment 98884:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24657=98884)
-
::: t/db_dependent/Koha/Item.t
@@ +173,5 @@
> +my $root2 = $builder->build_object( { class => 'Koha::Library::Groups',
> value => { ft_local_hold_group => 1, branchcode => undef } } );
> +my $library1 = $builder->build_object( { class => 'Koha::Libraries',
> value => { pickup_location => 1, branchcode => 'TEST1' } } );
> +my $library2 = $builder->build_object( { class => 'Koha::Libraries',
> value => { pickup_location => 1, branchcode => 'TEST2' } } );
> +my $library3 = $builder->build_object( { class => 'Koha::Libraries',
> value => { pickup_location => 0, branchcode => 'TEST3' } } );
> +my $library4 = $builder->build_object( { class => 'Koha::Libraries',
> value => { pickup_location => 1, branchcode => 'TEST4' } } );
Do you really need to specify a branchcode here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
Agustín Moyano changed:
What|Removed |Added
Attachment #98883|0 |1
is obsolete||
--- Comment #2 from Agustín Moyano ---
Created attachment 98884
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98884=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this
my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this
my $library1 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
To test:
1. do not apply this patch
2. in bash:
for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657
--- Comment #1 from Agustín Moyano ---
Created attachment 98883
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98883=edit
Bug 24657: Fix t/db_dependent/Koha/Item.t and t/db_dependent/Holds.t
on t/db_dependent/Koha/Item.t on line 172 I created 2 Koha::Library::Groups
like this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1 } } );
I didn't realize this was creating 2 new libraries that sometimes messed up
with tests, so I changed it to this
my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value
=> { ft_local_hold_group => 1, branchcode => undef } } );
on t/db_dependent/Holds.t on line 1058 I created 3 libraries like this
my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
but they needed to be pickup_locations, and sometimes they wheren't set as
such, so I changed it to this
my $library1 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library2 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
my $library3 = $builder->build_object( { class => 'Koha::Libraries', value =>
{pickup_location => 1} } );
To test:
1. do not apply this patch
2. in bash:
for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t
t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done
3. Grab a cup of coffee (or tea if you are healthy) and wait for a while
4. Whithin 300 iterations there should be an error in any of both scripts and
for loop should exit
5. Apply this patch
6. repeat step 2 and 3 (decaff this time!)
7. All 300 loops should pass
8. Sign off
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24657] Fix tests of bug 22284 - Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24657 Agustín Moyano changed: What|Removed |Added Depends on||22284 Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
