[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Bug 25510 depends on bug 15253, which changed state. Bug 15253 Summary: Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #40 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #39 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #37) > Is 19.05 also affected? I don't think so. Since Bug 24905 wasn't pushed to 19.05, it should be safe. We skipped over 19.05 and are doing many upgrades to 19.11, so that's all I've been targeting at the moment for my work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #38 from David Cook --- (In reply to Joy Nelson from comment #36) > 19.11.x patches reviewed by Kyle and pushed by me for 19.11.06 > Thanks! Woo! You're welcome ^_^. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #37 from Victor Grousset/tuxayo --- Is 19.05 also affected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable --- Comment #36 from Joy Nelson --- 19.11.x patches reviewed by Kyle and pushed by me for 19.11.06 Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Attachment #105053|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall changed: What|Removed |Added Attachment #105153|Bug 25510: Put space|[19.11] Bug 25510: Put description|between negation operator |space between negation |and function name |operator and function name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall changed: What|Removed |Added Attachment #105152|Bug 25510: Fix syntax error |[19.11] Bug 25510: Fix description|in koha-common.postinst |syntax error in ||koha-common.postinst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall changed: What|Removed |Added Attachment #105053|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall --- Created attachment 105153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105153=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Kyle M Hall changed: What|Removed |Added Attachment #105134|0 |1 is obsolete|| Attachment #105135|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall --- Created attachment 105152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105152=edit Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #33 from David Cook --- Not sure what the process is for backporting, but someone in QA might want to look over those 19.11 patches. I haven't fully tested them. I just fixed the merge conflicts when applying the master patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #31 from David Cook --- Created attachment 105134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105134=edit [19.11] Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #32 from David Cook --- Created attachment 105135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105135=edit [19.11] Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #30 from David Cook --- (In reply to Joy Nelson from comment #29) > not sure how to push this to 19.11.x branch. Oh right, it'll need a different patch, as the koha-common.postinst in 19.11 is a fair bit different to master. I did my own local 19.11 patch but I meant to put one up here too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #29 from Joy Nelson --- not sure how to push this to 19.11.x branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #28 from Joy Nelson --- missing dependencies-not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #27 from Victor Grousset/tuxayo --- 19.11 mantainer: relaying here a message from bug 25524 comment 3 > 19.11 mantainer: this should be pushed at the same time we push 25510. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #25 from David Cook --- (In reply to Tomás Cohen Arazi from comment #24) > I know. But internet gets painfully slow here around 8 pm with all the > neighbours streamming Netflix et al, and I got pulled to the kitchen to make > dinner :-D > > I have everything set to properly QA all this packaging bugs (koha-dpkg, > vagrant+virtualbox) I just need more time as installing 19.11 (and deps) to > test upgrades takes a lot of time here. No worries. Very grateful for your work on these! I just didn't want to be responsible for adding bugs while fixing bugs heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #24 from Tomás Cohen Arazi --- (In reply to David Cook from comment #23) > Thanks Tomas :) > > We can't forget Bug 25524 either, as fixing Bug 25510 will cause Bug 25524 > to become an issue. I know. But internet gets painfully slow here around 8 pm with all the neighbours streamming Netflix et al, and I got pulled to the kitchen to make dinner :-D I have everything set to properly QA all this packaging bugs (koha-dpkg, vagrant+virtualbox) I just need more time as installing 19.11 (and deps) to test upgrades takes a lot of time here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #23 from David Cook --- Thanks Tomas :) We can't forget Bug 25524 either, as fixing Bug 25510 will cause Bug 25524 to become an issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 105053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105053=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 105052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105052=edit Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105008|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105007|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Blocks||25529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25529 [Bug 25529] [OMNIBUS] 20.05 debian packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #9) > (In reply to Victor Grousset/tuxayo from comment #6) > > - install the packages following > > https://wiki.koha-community.org/wiki/Koha_on_Debian > > That's mostly correct, although "install the packages" would need to use > either "apt install ./koha-common" or "dpkg -i > koha-common" `apt-get install koha-common` is indeed part of https://wiki.koha-community.org/wiki/Koha_on_Debian I feel I didn't get your meaning. Thanks a lot for the signing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Attachment #105005|0 |1 is obsolete|| --- Comment #19 from David Cook --- Created attachment 105008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105008=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Attachment #104921|0 |1 is obsolete|| --- Comment #18 from David Cook --- Created attachment 105007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105007=edit Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #17 from Jonathan Druart --- Indeed, I had the space in my test script but did not correctly applied the changes :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Depends on||25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Blocks||25524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25524 [Bug 25524] Debian packages always append to /etc/koha/sites/$site/log4perl.conf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #16 from David Cook --- Note this affects 19.11 and not just master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25524 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #15 from David Cook --- (In reply to David Cook from comment #14) > With this patch, there are no longer error messages... but > log4perl_component() doesn't look like it's working correctly because it > just keeps appending to /etc/koha/sites/$site/log4perl.conf And it's because the grep in log4perl_component() is bad... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #14 from David Cook --- (In reply to David Cook from comment #13) > Created attachment 105005 [details] [review] > Bug 25510: Put space between negation operator and function name > > This patch puts a space between the negation operator ! and > the function name (ie log4perl_component). With this patch, there are no longer error messages... but log4perl_component() doesn't look like it's working correctly because it just keeps appending to /etc/koha/sites/$site/log4perl.conf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #13 from David Cook --- Created attachment 105005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105005=edit Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #12 from David Cook --- (In reply to Jonathan Druart from comment #4) > Created attachment 104921 [details] [review] > Bug 25510: Fix syntax error in koha-common.postinst I'm getting the following errors: /var/lib/dpkg/info/koha-common.postinst: 155: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found /var/lib/dpkg/info/koha-common.postinst: 168: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found /var/lib/dpkg/info/koha-common.postinst: 184: /var/lib/dpkg/info/koha-common.postinst: !log4perl_component: not found I think we need that space between the ! and the function name. I'll add a patch for that and try again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Depends on|25068 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Depends on||25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #11 from David Cook --- (In reply to Tomás Cohen Arazi from comment #10) > That's interesting, David. Mine is not community per-se. I like yours, might > steal some of it for mine Cool ^_^. It's a work-in-progress, but I've been using it for a while and have it integrated in a CD pipeline, which is working pretty well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #10 from Tomás Cohen Arazi --- (In reply to David Cook from comment #9) > (In reply to Victor Grousset/tuxayo from comment #6) > > IIUC from various IRC discussions, the cleanest[1] way to test package > > install patches while being simple[1] enough to be less likely to messed > > things up is: > > > > - apply comment 4 > > - make packages with https://hub.docker.com/r/koha/koha-dpkg > > - spin a standard Debian (9?) however one wants (container, VM, VPS) > > - install the packages following > > https://wiki.koha-community.org/wiki/Koha_on_Debian > > > > [1] for someone without experience with building packages and installing > > Koha from them > > That's mostly correct, although "install the packages" would need to use > either "apt install ./koha-common" or "dpkg -i > koha-common" > > For making packages, I use my own Docker image > (https://gitlab.com/minusdavid/koha-deb-builder-docker), but I imagine > there's community support for https://hub.docker.com/r/koha/koha-dpkg, so > that's probably better for someone without experience. That's interesting, David. Mine is not community per-se. I like yours, might steal some of it for mine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #9 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #6) > IIUC from various IRC discussions, the cleanest[1] way to test package > install patches while being simple[1] enough to be less likely to messed > things up is: > > - apply comment 4 > - make packages with https://hub.docker.com/r/koha/koha-dpkg > - spin a standard Debian (9?) however one wants (container, VM, VPS) > - install the packages following > https://wiki.koha-community.org/wiki/Koha_on_Debian > > [1] for someone without experience with building packages and installing > Koha from them That's mostly correct, although "install the packages" would need to use either "apt install ./koha-common" or "dpkg -i koha-common" For making packages, I use my own Docker image (https://gitlab.com/minusdavid/koha-deb-builder-docker), but I imagine there's community support for https://hub.docker.com/r/koha/koha-dpkg, so that's probably better for someone without experience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #2) > So Koha install is broken using the Debian package? Arguably yes. The majority of the install works correctly, but it looks like it ditches out at the end of koha-common.postinst. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- IIUC from various IRC discussions, the cleanest[1] way to test package install patches while being simple[1] enough to be less likely to messed things up is: - apply comment 4 - make packages with https://hub.docker.com/r/koha/koha-dpkg - spin a standard Debian (9?) however one wants (container, VM, VPS) - install the packages following https://wiki.koha-community.org/wiki/Koha_on_Debian [1] for someone without experience with building packages and installing Koha from them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #7 from Victor Grousset/tuxayo --- Anything missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Assignee|dc...@prosentient.com.au|jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Attachment #104912|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Comment on attachment 104912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104912 Bug 25510: Fix shell syntax for updating log4perl.conf for instances This patch is not sufficient for master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Depends on||15253, 25032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 [Bug 15253] Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #4 from Jonathan Druart --- Created attachment 104921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104921=edit Bug 25510: Fix syntax error in koha-common.postinst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510
--- Comment #3 from Jonathan Druart
---
If I execute:
log4perl_component()
{
local config=$1
local component=$2
if [ grep -q -x "log4perl.logger.$component" $config ]; then
return 0
else
return 1
fi
}
for site in $(koha-list); do
log4perl_config="/etc/koha/sites/$site/log4perl.conf"
if ! log4perl_component $log4perl_config "sip"; then
echo $site
fi
done
I get
xxx.pl: line 67: [: too many arguments
Looks like we need another change
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added Depends on||24905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|enhancement |critical Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #2 from Jonathan Druart --- So Koha install is broken using the Debian package? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 --- Comment #1 from David Cook --- Created attachment 104912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104912=edit Bug 25510: Fix shell syntax for updating log4perl.conf for instances This patch fixes the shell syntax when updating log4perl.conf for instances. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24905 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
