[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Version(s)|20.05 |20.05.00 released in|| Status|Pushed to master|Pushed to stable --- Comment #32 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #31 from Jonathan Druart --- I confirm I can make it fail 100% of the time on U18, but only occasionally on D10 (hum?) On U18 it's failing on the tests we wrote for this specific problem ("Regression tests for bug 25513"), but on D10 it fails on another one: t/db_dependent/api/v1/acquisitions_orders.t .. 1/5 # Failed test 'SWAGGER3.3.2' # at t/db_dependent/api/v1/acquisitions_orders.t line 129. # Structures begin differing at: # $got->{ecost_tax_included} = '2.7621662673219e+21' # $expected->{ecost_tax_included} = '2762166267321895092224.00' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #30 from Victor Grousset/tuxayo --- Hm, bug still happened on Ubuntu 18.04 for last 3 builds. https://jenkins.koha-community.org/job/Koha_Master_U18/813/ https://jenkins.koha-community.org/job/Koha_Master_U18/812/ https://jenkins.koha-community.org/job/Koha_Master_U18/811/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Jonathan Druart changed: What|Removed |Added Blocks||25638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 [Bug 25638] API related tests failing on comparing floats -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25638 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_05_candidate | Version(s)||20.05 released in|| Status|Passed QA |Pushed to master --- Comment #29 from Jonathan Druart --- Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 105395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105395=edit Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON This patch removes a problematic integer casting happening in TO_JSON. The original need for this cast (a DBD::mysql bug) is now fixed. We remove the cast as it is causing random failures. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail with select high values (i.e. casting gives wrong results) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105394|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 105394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105394=edit Bug 25513: Fix random failure from acquisitions_orders.t No idea if this is correct, but the tests pass without that condition See bug 17932 Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 105393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105393=edit Bug 25513: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105177|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105317|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Tomás Cohen Arazi changed: What|Removed |Added Summary|acquisitions_orders.t is|Integer casting in |failing randomly|Koha::Object->TO_JSON ||causes random test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/