[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Caroline Cyr La Rose changed: What|Removed |Added Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Manual CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #34 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #33 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Fridolin Somers changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.03 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Pushed to stable --- Comment #32 from Fridolin Somers --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #31 from Daniel Gaghan --- (In reply to Martha Fuerst from comment #30) > Any chance of getting this backported? > > Thanks! > > Marti Fuerst > Huntsville-Madison County Public Library I second this, I thought it was coming in 20.05 and our circ staff were hoping for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #30 from Martha Fuerst --- Any chance of getting this backported? Thanks! Marti Fuerst Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||14697 CC||and...@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #29 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #28 from Jonathan Druart --- Created attachment 116173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116173=edit Bug 25552: Simplify tests using build_sample_item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Text to go in the||Marking an item as a return release notes||claim checks the system ||preference ||MarkLostItemsAsReturned to ||see if the claim should be ||removed from the patron ||record. However, the option ||for "when marking an item ||as a return claim" was ||never added to the system ||preference, so there was no ||way to remove a checkout ||from the patron record when ||marking the checkout as a ||return claim. This patch ||set adds that missing ||option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #27 from Jonathan Druart --- Please add release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #26 from Martin Renvoize --- This passes the QA scripts and works as expected for me.. I've added a bit of detail to the POD as there are unrelated things that came to mind whilst QAing this.. but I think those should be handled on their own bug which I'll open shortly. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #25 from Martin Renvoize --- Created attachment 115689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115689=edit Bug 25552: (QA follow-up) Fix spelling mistake Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #24 from Martin Renvoize --- Created attachment 115688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115688=edit Bug 25552: (QA follow-up) Improve claim_returned POD The POD for the Koha::Checkout->claim_returned method was somewhat lacking; This patch attempts to explain what the code appears to achieve. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martin Renvoize changed: What|Removed |Added Attachment #113898|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 115687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115687=edit Bug 25552: Unit tests Signed-off-by: Marti Fyerst Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martin Renvoize changed: What|Removed |Added Attachment #113892|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 115686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115686=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee Signed-off-by: Marti Fyerst Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martin Renvoize changed: What|Removed |Added Attachment #113889|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 115685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115685=edit Bug 25552: Add missing Claims Returned option to MarkLostItemsAsReturned Marking an item as a return claim checks MarkLostItemsAsReturned to see if claim_returned is a value in MarkLostItemsAsReturned. However, this option was never added to MarkLostItemsAsReturned so an a return claim can never be automatically removed from the patron record, even if they wanted such behavior. Test Plan: 1) Apply this patch 2) Restart all the things 3) Note the new return claims option on MarkLostItemsAsReturned in the system preferences Signed-off-by: Marti Fyerst Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martha Fuerst changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 ByWater Sandboxes changed: What|Removed |Added Attachment #113893|0 |1 is obsolete|| --- Comment #20 from ByWater Sandboxes --- Created attachment 113898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113898=edit Bug 25552: Unit tests Signed-off-by: Marti Fyerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #19 from Kyle M Hall --- Created attachment 113893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113893=edit Bug 25552: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #18 from Kyle M Hall --- Created attachment 113892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113892=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Attachment #105389|0 |1 is obsolete|| Attachment #105559|0 |1 is obsolete|| Attachment #105643|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 113889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113889=edit Bug 25552: Add missing Claims Returned option to MarkLostItemsAsReturned Marking an item as a return claim checks MarkLostItemsAsReturned to see if claim_returned is a value in MarkLostItemsAsReturned. However, this option was never added to MarkLostItemsAsReturned so an a return claim can never be automatically removed from the patron record, even if they wanted such behavior. Test Plan: 1) Apply this patch 2) Restart all the things 3) Note the new return claims option on MarkLostItemsAsReturned in the system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #16 from Martha Fuerst --- Just making noise on this bug so that it get attention and gets resolved. When we resolve a claim and a patron pays for the item, we currently have no way to remove the item from a patron's checkouts, as the lost status toggle in the bib "more details" items tab is grayed out, and even deleted the claim doesn't resolve that. Thanks! -Marti Fuerst Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #15 from Kelly McElligott --- I believe this is filed as a bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25734 Screenshare: https://drive.google.com/file/d/1xVUqmCKD9f4GfqnLU4heeHmNqgig6hR5/view Now the claim returned is not processing at all. I have the system preference MarkLostItemsasReturned set to be removed from patron's account and it is not working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #14 from Kelly McElligott --- I believe this is filed as a bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25734 But will send along a screen share! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #13 from Kyle M Hall --- (In reply to Kelly McElligott from comment #12) > Hi, > It would appear that the item does not remove until the page reloads? I > would encourage to reload during this transaction so the staff can see it > come off of the account. Kelly, can you make a quick screencast of this so I'm sure I know what to fix? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #12 from Kelly McElligott --- Hi, It would appear that the item does not remove until the page reloads? I would encourage to reload during this transaction so the staff can see it come off of the account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #11 from Katrin Fischer --- I tested it twice, maybe messed up on git. I will redo the tests... again :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #10 from Kyle M Hall --- Created attachment 105643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105643=edit Bug 25552: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Kyle M Hall --- (In reply to Katrin Fischer from comment #8) > I believe this is still not working right. The item is only returned when I > check the 'charge lost fee' check box. > > Please explain, when adding a new patch. I think we are also going to need > unit tests. My followup fixes exactly the issue you are describing. I just re-tested and it's still working for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- I believe this is still not working right. The item is only returned when I check the 'charge lost fee' check box. Please explain, when adding a new patch. I think we are also going to need unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Attachment #105558|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 105559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105559=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #6 from Kyle M Hall --- Created attachment 105558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105558=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- This includes the fixes I asked for, but is otherwise exactly the same as the patch that didn't work for me and it still doesn't :( I believe the test plan to be incomplete - adding a new option alone is not enough, it should work as well. What I've done: - checked the new option in the pref - Marked an item as claim returned - Lost status was set, but item remains on the account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Attachment #105146|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 105389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105389=edit Bug 25552: Add missing Claims Returned option to MarkLostItemsAsReturned Marking an item as a return claim checks MarkLostItemsAsReturned to see if claim_returned is a value in MarkLostItemsAsReturned. However, this option was never added to MarkLostItemsAsReturned so an a return claim can never be automatically removed from the patron record, even if they wanted such behavior. Test Plan: 1) Apply this patch 2) Restart all the things 3) Note the new return claims option on MarkLostItemsAsReturned in the system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com --- Comment #3 from Katrin Fischer --- *** Bug 25518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Kyle, I tested this, but it doesn't return the item for me :( There is no error in the logs - just some debug information: [Fri May 22 11:02:55 2020] [debug] 201 Created (0.0484s, 20.661/s) [Fri May 22 11:08:03 2020] [debug] POST "/api/v1/return_claims" [Fri May 22 11:08:03 2020] [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [Fri May 22 11:08:03 2020] [debug] Routing to controller "Koha::REST::V1::ReturnClaims" and action "claim_returned" I think we also need to update the options in sysprefs.sql and maybe have a database update as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #1 from Kyle M Hall --- Created attachment 105146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105146=edit Bug 25552: Add missing Claims Returned option to MarkLostItemsAsReturned Marking an item as a return claim checks MarkLostItemsAsReturned to see if claim_returned is a value in MarkLostItemsAsReturned. However, this option was never added to MarkLostItemsAsReturned so an a return claim can never be automatically removed from the patron record, even if they wanted such behavior. Test Plan: 1) Apply this patch 2) Restart all the things 3) Note the new return claims option on MarkLostItemsAsReturned in the system preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
