[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #0) > Certainly caused by bug 20443. It shouldn't be necessary (missing dependency) in 19.11.x and 19.05.x then. (In reply to Jonathan Druart from comment #3) > Created attachment 105195 [details] [review] > Bug 25567: Fix typo categorycode vs category_code > > Well, this is actually the real root of the error! Okay maybe it impacts them also. --- After a quick try of the test plan on 19.05.x: can't reproduce the issue Won't backport to 19.05.x As for 19.11.x - v19.11.06 : can't reproduce the issue - 19.11.x(78d930d438): no issue so the patch shouldn't be a problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Aleisha Amohia changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00|20.05.00, 19.11.07 released in|| --- Comment #11 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Aleisha Amohia changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Nick Clemens changed: What|Removed |Added Attachment #105209|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 105222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105222=edit Bug 25567: Fix typo categorycode vs category_code Well, this is actually the real root of the error! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Nick Clemens changed: What|Removed |Added Attachment #105208|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 105221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105221=edit Bug 25567: Prevent patron category type's categorycode to be created with "" It must be NULL/undef, the default from the DB. The method Koha::Patron::Attribute::Type->categorycode is not covered by tests! To recreate: Create a new patron attribute type, don't select a patron's category (and not repeatable or unique) Go to the batch patron modification tool, enter a cardnumber, next. => boom! Apply the patch, edit the patron attribute, save Go to the batch patron modification tool, enter a cardnumber, next. => success! Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105197|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 105209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105209=edit Bug 25567: Fix typo categorycode vs category_code Well, this is actually the real root of the error! Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- It works! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105194|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 105208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105208=edit Bug 25567: Prevent patron category type's categorycode to be created with "" It must be NULL/undef, the default from the DB. The method Koha::Patron::Attribute::Type->categorycode is not covered by tests! To recreate: Create a new patron attribute type, don't select a patron's category (and not repeatable or unique) Go to the batch patron modification tool, enter a cardnumber, next. => boom! Apply the patch, edit the patron attribute, save Go to the batch patron modification tool, enter a cardnumber, next. => success! Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Jonathan Druart changed: What|Removed |Added Attachment #105195|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 105197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105197=edit Bug 25567: Fix typo categorycode vs category_code Well, this is actually the real root of the error! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 --- Comment #3 from Jonathan Druart --- Created attachment 105195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105195=edit Bug 25567: Fix typo categorycode vs category_code Well, this is actually the real root of the error! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Jonathan Druart --- Wait, I overlooked something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 --- Comment #1 from Jonathan Druart --- Created attachment 105194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105194=edit Bug 25567: Prevent patron category type's categorycode to be created with "" It must be NULL/undef, the default from the DB. The method Koha::Patron::Attribute::Type->categorycode is not covered by tests! To recreate: Create a new patron attribute type, don't select a patron's category (and not repeatable or unique) Go to the batch patron modification tool, enter a cardnumber, next. => boom! Apply the patch, edit the patron attribute, save Go to the batch patron modification tool, enter a cardnumber, next. => success! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
