[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in||19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Aleisha Amohia changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.07 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #14 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Pushed to master|Pushed to stable Version(s)|20.05 |20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05 released in|| Keywords|rel_20_05_candidate | --- Comment #13 from Jonathan Druart --- Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Julian Maurice changed: What|Removed |Added Attachment #105423|0 |1 is obsolete|| --- Comment #12 from Julian Maurice --- Created attachment 105432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105432=edit Bug 25617: (QA follow-up) Add responses to tests Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Julian Maurice changed: What|Removed |Added Attachment #105422|0 |1 is obsolete|| --- Comment #11 from Julian Maurice --- Created attachment 105431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105431=edit Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 There was an error in the precedent code, in 12hr format, 12PM is actually 00:00 Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Nick Clemens changed: What|Removed |Added Attachment #105418|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 105422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105422=edit Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 There was an error in the precedent code, in 12hr format, 12PM is actually 00:00 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 --- Comment #10 from Nick Clemens --- Created attachment 105423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105423=edit Bug 25617: (QA follow-up) Add responses to tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Severity|major |critical --- Comment #8 from Jonathan Druart --- Upping severity, not sure how big this is for TimeFormat=12hr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Attachment #105417|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 105418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105418=edit Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 There was an error in the precedent code, in 12hr format, 12PM is actually 00:00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Attachment #105412|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 105417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105417=edit Bug 25617: (bug 25133 follow-up) 12 PM is not 24 but 0 There was an error in the precedent code, in 12hr format, 12PM is actually 00:00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added Depends on|18674 |25133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 [Bug 18674] Show timezone for Perl and MySQL on the About Koha page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25133 [Bug 25133] Specify Due date changes from PM to AM if library has their TimeFormat set to 12hr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 --- Comment #4 from Jonathan Druart --- Maybe something else actually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 --- Comment #5 from Jonathan Druart --- It's only happening when hour=12. I am working on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- What OS? I cannot reproduce on Stretch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617
--- Comment #2 from Jonathan Druart
---
Template process failed: undef error - Validation failed for type named Hour
declared in package DateTime::Types
(/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Types.pm) at line 101 in sub
named (eval) with valu
e 24
Trace begun at Specio::Exception->new line 57
Specio::Exception::throw('Specio::Exception', 'message', 'Validation failed for
type named Hour declared in package DateTime::Types
(/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Types.pm) at line 101 in sub nam
ed (eval) with value 24', 'type',
'Specio::Constraint::Simple=HASH(0x5602f411a6f8)', 'value', 24) called at (eval
217) line 126
DateTime::_check_new_params('month', 05, 'day', 28, 'second', 0, 'year', 2020,
'minute', 49, 'hour', 24, 'time_zone', 'floating') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime.pm line 165
DateTime::new('DateTime', 'month', 05, 'day', 28, 'second', 0, 'year', 2020,
'minute', 49, 'hour', 24, 'time_zone', 'floating') called at
/kohadevbox/koha/Koha/DateUtils.pm line 200
Koha::DateUtils::dt_from_string('2020-05-28 12:49 PM', 'iso') called at
/kohadevbox/koha/Koha/Template/Plugin/KohaDates.pm line 34
Koha::Template::Plugin::KohaDates::filter('Koha::Template::Plugin::KohaDates=HASH(0x560309b36c28)',
'2020-05-28 12:49 PM', 'ARRAY(0x5603099fe908)', 'HASH(0x5603098a3928)') called
at /usr/lib/x86_64-linux-gnu/per
l5/5.24/Template/Plugin/Filter.pm line 82
Template::Plugin::Filter::__ANON__('2020-05-28 12:49 PM') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt line 127
eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
line 18
Template::Provider::__ANON__('Template::Context=HASH(0x56030151f128)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x560309b36880)',
'Template::Context=HASH(0x56030151f128)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x56030151f128)',
'Template::Document=HASH(0x560309b36880)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 91
Template::Service::process('Template::Service=HASH(0x5602fe764610)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt',
'HASH(0x5603097ff4b0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.24/Te
mplate.pm line 66
Template::process('Template=HASH(0x560301521550)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt',
'HASH(0x5603097ff4b0)', 'SCALAR(0x5602f7c2a138)') called at
/kohadevbox/koha/C4/Templates.p
m line 122
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||18674 Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 [Bug 18674] Show timezone for Perl and MySQL on the About Koha page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25617] Error on about page when TimeFormat preference is set to 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25617 --- Comment #1 from Owen Leonard --- Created attachment 105412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105412=edit Bug 25617: Pass 24hr to output_pref This patch changes the date formatting function used to create the current_date_and_time variable by adding '24hr' as the timeformat parameter. This avoids an error when the TimeFormat preference is set to 12hr. To test, apply the patch and go to the "About" page in the staff interface. It should work correctly. The "Date and time" information under the "Server information" tab should be correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
