[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Bug 26132 depends on bug 21946, which changed state. Bug 21946 Summary: Group circulation by item type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 What|Removed |Added

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #26 from Jonathan Druart --- I am willing to continue and push follow-ups here. However, Martin, I think that with this approach we are going to join in all cases, which is only needed in 1 situation. I guess that's

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #25 from Jonathan Druart --- Created attachment 113034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113034=edit Bug 26132: continuing code golf -- You are receiving this mail because: You are

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #24 from Martin Renvoize --- Created attachment 113014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113014=edit Bug 26132: (GOLF EXAMPLE) -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #23 from Jonathan Druart --- Last two patches pushed to master for 20.11 Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #22 from Joonas Kylmälä --- Created attachment 113007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113007=edit Bug 26132: (follow-up) Fix broken code in TooMany function The $checkouts variable was

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #21 from Joonas Kylmälä --- Created attachment 113006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113006=edit Bug 26132: (follow-up) Add test to show errors in max issues amount calculation If you

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Jonathan Druart changed: What|Removed |Added Keywords|RM_priority | -- You are receiving

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #19 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 108152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108152=edit Bug 26132: (follow-up) Count all checkouts if no limits needed Signed-off-by: Nick

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 108153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108153=edit Bug 26132: (QA follow-up) Make tests more robust Tests fail is SearchEngine is set

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 108150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108150=edit Bug 26132: Don't prefetch if not needed We only need to prefetch items if

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107801|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 108151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108151=edit Bug 26132: Tidy _check_max_qty This is only a perltidy of _check_max_qty to remove

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 108149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108149=edit Bug 26132: Remove raw SQL query for patron_maxissueqty Same as before but for

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 108148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108148=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 108147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108147=edit Bug 26132: TooMany refactoring The different calls to _check_max_qty can be improved

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107797|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107800|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107799|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107798|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107796|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #10 from Nick Clemens --- Created attachment 107800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107800=edit Bug 26132: Tidy _check_max_qty This is only a perltidy of _check_max_qty to remove some

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #11 from Nick Clemens --- Created attachment 107801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107801=edit Bug 26132: (follow-up) Count all checkouts if no limits needed Signed-off-by: Nick

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #9 from Nick Clemens --- Created attachment 107799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107799=edit Bug 26132: Don't prefetch if not needed We only need to prefetch items if CircControl is

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #7 from Nick Clemens --- Created attachment 107797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107797=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much more

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Nick Clemens changed: What|Removed |Added Attachment #107734|0 |1 is obsolete|

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #8 from Nick Clemens --- Created attachment 107798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107798=edit Bug 26132: Remove raw SQL query for patron_maxissueqty Same as before but for

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #5 from Jonathan Druart --- Created attachment 107738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107738=edit Bug 26132: Tidy _check_max_qty This is only a perltidy of _check_max_qty to remove

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #4 from Jonathan Druart --- Created attachment 107737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107737=edit Bug 26132: Don't prefetch if not needed We only need to prefetch items if CircControl

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #3 from Jonathan Druart --- Created attachment 107736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107736=edit Bug 26132: Remove raw SQL query for patron_maxissueqty Same as before but for

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #2 from Jonathan Druart --- Created attachment 107735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107735=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much more

[Koha-bugs] [Bug 26132] Improve readability of TooMany

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #1 from Jonathan Druart --- Created attachment 107734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107734=edit Bug 26132: TooMany refactoring The different calls to _check_max_qty can be improved