[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #52 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #51 from Katrin Fischer --- Follow-up will be pushed to main. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #50 from Martin Renvoize --- Last patch attached needed on main Katrin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Martin Renvoize changed: What|Removed |Added Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #49 from Martin Renvoize --- Created attachment 165827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165827=edit Bug 26297: (RM follow-up) Fix specification file We had a duplicate 'description' key introduced in the patron category specification file here which causes errors on bundling the specs. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed --- Comment #48 from Martin Renvoize --- There's a merge error here leading to an invalid spec file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #47 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 [Bug 17505] Add routes for messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #46 from Tomás Cohen Arazi --- *** Bug 34007 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #165453|0 |1 is obsolete|| --- Comment #45 from Tomás Cohen Arazi --- Created attachment 165655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165655=edit Bug 26297: (QA follow-up): Update tests prove t/db_dependent/api/v1/patron_categories.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #44 from Pedro Amorim --- Created attachment 165453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165453=edit Bug 26297: (QA follow-up): Update tests prove t/db_dependent/api/v1/patron_categories.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What|Removed |Added Blocks||36453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #43 from Tomás Cohen Arazi --- Pedro, I think this is missing: * The tests shouldn't delete all data, this is bad. They should probably use `q=` to constraint the resultset instead. And if we are trying to test the `search_with_library_limits` nature of the implementation, then we need to properly build the tests by adding a couple libraries, several categories limited to one and the other, and then crafting a `q=` query that searches for them all, and we only get the right ones for the branch we are logged at. * I don't like it that it returns the categories limited by branch by default. That would work for rendering dropdowns, but not for a CRUD page for categories. And that use case is vital for implementing `GET /patron_categories`. * If we need a way to restrict the returned categories by branch, then we should add a switch for that. Regarding always using `search_with_library_limits`, I would be happy to stand corrected if you explain why it makes sense as-is. I added the missing parameters in a follow-up, and some minor squashed fixes, including the tests failing for permissions. The only missing bit would be redoing the tests. Happy to help if you want me to take on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161487|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161488|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 165393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165393=edit Bug 26297: (QA follow-up) Spec fixes This patch fixes some spec misses. To test: 1. Run: $ ktd --shell k$ prove xt/api.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161486|0 |1 is obsolete|| --- Comment #41 from Tomás Cohen Arazi --- Created attachment 165392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165392=edit Bug 26297: Add tests Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161485|0 |1 is obsolete|| --- Comment #40 from Tomás Cohen Arazi --- Created attachment 165391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165391=edit Bug 26297: API specs Test plan, k-t-d: 1) Access /api/v1/patron_categories 2) Verify the patron categories are correctly listed Signed-off-by: Lucas Gass Bug 26297: (QA follow-up) Move to REST::V1::Patrons::Categories Bug 26297: (QA follow-up) Use search_with_library_limits JD amended-patch: squashed + tidy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Attachment #161484|0 |1 is obsolete|| --- Comment #39 from Tomás Cohen Arazi --- Created attachment 165390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165390=edit Bug 26297: Add patron categories to_api_mapping Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #38 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #36) > * We should use Koha::V1::Patron::Categories, double plural sounds wrong > (i.e. Patrons). We did this all the time, nevermind :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #37 from Tomás Cohen Arazi --- * The change on the required permissions broke the tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #36 from Tomás Cohen Arazi --- I've reviewed this and have a few remarks. * I felt tempted to submit all this squashed (minor/tiny thing) * The tests shouldn't delete all data, this is bad. They should probably use `q=` to constraint the resultset instead. And if we are trying to test the `search_with_library_limits` nature of the implementation, then we need to properly build the tests by adding a couple libraries, several categories limited to one and the other, and then crafting a `q=` query that searches for them all, and we only get the right ones for the branch we are logged at. * I don't like it that it returns the categories limited by branch by default. That would work for rendering dropdowns, but not for a CRUD page for categories. And that use case is vital for implementing `GET /patron_categories`. * If we need a way to restrict the returned categories by branch, then we should add a switch for that. * The standard parameters we add to all `list()` endpoints are missing on the spec (i.e. no pagination, no q=, etc). * No `use Koha::Patron::Categories;` * We should use Koha::V1::Patron::Categories, double plural sounds wrong (i.e. Patrons). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26297] Add a route to list patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Tomás Cohen Arazi changed: What|Removed |Added Summary|Rest API: add a route to|Add a route to list patron |list patron categories |categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
