[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/693
 Status|Needs documenting   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-05-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
  Text to go in the||This enhancement adds a new
  release notes||tab in the patron details
   ||page to show guarantees'
   ||unpaid charges.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #151499|0   |1
is obsolete||

--- Comment #21 from Victor Grousset/tuxayo  ---
Comment on attachment 151499
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151499
Bug 33774: Loading club table in every tab in patron details

oops, wrong ticket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #20 from Victor Grousset/tuxayo  ---
Created attachment 151499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151499&action=edit
Bug 33774: Loading club table in every tab in patron details

This patch corrects a minor regression in template markup caused by Bug
33774. The Bootstrap tab attributes were lost (presumably in a merge)
causing the whole tab structure to break.

To test, you should have at least one club defined.

Apply the patch and view the patron details page. Each tab should load
its contents correctly.

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-05-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Owen Leonard  changed:

   What|Removed |Added

 Blocks||33774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774
[Bug 33774] Loading club table in every tab in patron details
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Jacob O'Mara  changed:

   What|Removed |Added

 CC||[email protected]
 Status|Pushed to master|Needs documenting

--- Comment #19 from Jacob O'Mara  ---
Enhancement - not backporting to 22.11.x

Nice work everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #18 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2023-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|[email protected] |[email protected]
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #17 from Kyle M Hall  ---
Created attachment 144697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144697&action=edit
Bug 26598: (QA follow-up) Fix up tab for guarantees' charges

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #144110|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall  ---
Created attachment 144696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144696&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

+ resolve a git merge conflict

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Hammat Wele 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Kyle M Hall  changed:

   What|Removed |Added

 CC||[email protected]
 Status|Signed Off  |Failed QA

--- Comment #15 from Kyle M Hall  ---
The new guarantee's charges table is showing up on every tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Hammat wele  changed:

   What|Removed |Added

 Attachment #142655|0   |1
is obsolete||

--- Comment #14 from Hammat wele  ---
Created attachment 144110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144110&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

+ resolve a git merge conflict

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Hammat Wele 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Hammat wele  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

[email protected] changed:

   What|Removed |Added

 Attachment #140376|0   |1
is obsolete||

--- Comment #13 from [email protected] ---
Created attachment 142655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142655&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

+ resolve a git merge conflict

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Lisette Scheer  changed:

   What|Removed |Added

 CC||[email protected]
   ||om

--- Comment #12 from Lisette Scheer  ---
(In reply to Shi Yao Wang from comment #11)
> (In reply to Owen Leonard from comment #9)
> > This change must be made to both the patron detail page (moremember) and the
> > checkout page (circulation).
> > 
> > Since the guarantees' checkouts tab is labeled "Relatives' checkouts" I
> > think the new tab should be labeled "Relatives' charges".
> > 
> > I would also like to see the format of the patron name under the new tab
> > look the same as under the relatives' checkouts tab, i.e. "surname,
> > firstname (cardnumber)". The patron-title.inc include file might be
> > appropriate to use here.
> 
> The patron checkout page does not have fines tab so it would be weird to add
> guarantees' fines tab there.
> 
> "Relatives' checkouts" tab can be accessed by both the guarantee and the
> guarantor to view each others checkouts. "Guarantees' charges" tab can only
> be viewed by the guarantor so it would be more accurate to keep the name as
> it is.
> 
> Changed the format to make it the same as relatives' checkouts tab.

Maybe instead of as a tab it could be an alert under messages like it is when
the patron has fines? Additionally Surname, Firstname (cardnumber) is more
consisent, especially since there is a system preferences that asks if name
should be shown or only patron barcode, which I believe looks at he
patron-title.inc include file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Shi Yao Wang  ---
(In reply to Owen Leonard from comment #9)
> This change must be made to both the patron detail page (moremember) and the
> checkout page (circulation).
> 
> Since the guarantees' checkouts tab is labeled "Relatives' checkouts" I
> think the new tab should be labeled "Relatives' charges".
> 
> I would also like to see the format of the patron name under the new tab
> look the same as under the relatives' checkouts tab, i.e. "surname,
> firstname (cardnumber)". The patron-title.inc include file might be
> appropriate to use here.

The patron checkout page does not have fines tab so it would be weird to add
guarantees' fines tab there.

"Relatives' checkouts" tab can be accessed by both the guarantee and the
guarantor to view each others checkouts. "Guarantees' charges" tab can only be
viewed by the guarantor so it would be more accurate to keep the name as it is.

Changed the format to make it the same as relatives' checkouts tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #139712|0   |1
is obsolete||

--- Comment #10 from Shi Yao Wang  ---
Created attachment 140376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140376&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Owen Leonard  ---
This change must be made to both the patron detail page (moremember) and the
checkout page (circulation).

Since the guarantees' checkouts tab is labeled "Relatives' checkouts" I think
the new tab should be labeled "Relatives' charges".

I would also like to see the format of the patron name under the new tab look
the same as under the relatives' checkouts tab, i.e. "surname, firstname
(cardnumber)". The patron-title.inc include file might be appropriate to use
here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Shi Yao Wang  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||[email protected]
   Assignee|[email protected]   |[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #112110|0   |1
is obsolete||

--- Comment #8 from Shi Yao Wang  ---
Created attachment 139712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139712&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2022-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #7 from Caroline Cyr La Rose  ---
(In reply to Jonathan Druart from comment #6)

> 2. Why did you put the new tab between "checkouts" and "holds"? I don't
> think it's the more appropriate. Maybe just before "Restrictions"?

Not that I want to get in the middle of the fire here, but I noticed the new
tab is right next to the patron's own charge tab. I don't think it would be
appropriate to separate the charges tab and the guarantee's charges tab, just
like we didn't separate the patron's own checkout tab and the relative's
checkout tab and put the latter before the patron's own holds tab.

Anyway, just my grain of salt, I don't think the placement of the tab is a
problem that should stall this bug. (I don't comment on the other thing about
Koha::something bc I don't know what it means.)

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Jonathan Druart  changed:

   What|Removed |Added

 CC||[email protected]
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
1. I think you should call Koha::Patron->relationships_debt to get the
guarantees' fines

2. Why did you put the new tab between "checkouts" and "holds"? I don't think
it's the more appropriate. Maybe just before "Restrictions"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #5 from Martin Renvoize  ---
Nice enhancement, works as expected and code is clear.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #111320|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 112110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112110&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #3 from Katrin Fischer  ---
We might want to rethink the display a little later as we are getting a lot of
tabs, but I like this a lot better than the table at the top that was proposed
first. Thank you Maryse for all your patience!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

David Nind  changed:

   What|Removed |Added

 Attachment #111055|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 111320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111320&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Owen Leonard  changed:

   What|Removed |Added

   Assignee|[email protected] |[email protected]
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Maryse Simard  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

--- Comment #1 from Maryse Simard  ---
Created attachment 111055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111055&action=edit
Bug 26598: Display guarantee's fines on guarantor's details page

A new tab is added to the details page of a patron to show, in a table, the
fines of the patron's guarantees. A warning appears in the "Guarantees" section
of the patron to make it obvious that fines exists.

To test:
1) Apply patch
2) Choose a patron that has guarantees and navigate to the patron's details
page
3) If the guarantees don't have any fines, the display should be unchanged
4) Add fines to the guarantee
5) Go back to the guarantor's details page
=> A warning should appear in the "Guarantees" section with the total due
6) Clicking on the link accompanying the warning focuses on the new
"Guarantees' fines" tab containing a table of all guarantee's and their
fines.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page

2020-10-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598

Maryse Simard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/