[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #23 from Victor Grousset/tuxayo --- Can't backport to 19.11.x: can't solve the many conflicts. 💥💥💥 If there is an interest in having this backported, please submit a patch for 19.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.09 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #22 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #21 from Nick Clemens --- Created attachment 116519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116519&action=edit Bug 26634: [20.05.x] Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Niamh Walker-Headon changed: What|Removed |Added CC||niamh.walkerhea...@hse.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #20 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05.x, please rebase for backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.01 released in|| --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com --- Comment #17 from Josef Moravec --- QA script passed tests passed code is readable and does have test Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Josef Moravec changed: What|Removed |Added Attachment #114260|0 |1 is obsolete|| --- Comment #16 from Josef Moravec --- Created attachment 114439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114439&action=edit Bug 26634: Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- As a step towards QA, here is another signoff. And QA script ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114017|0 |1 is obsolete|| --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 114260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114260&action=edit Bug 26634: Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #13 from Martin Renvoize --- Re-tested and it's working well and provides a more comprehensive cleanup. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #12 from Martin Renvoize --- Re-tested and it's working well and provides a more comprehensive cleanup. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added Attachment #113966|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 114017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114017&action=edit Bug 26634: Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #10 from Martin Renvoize --- Working through testing this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Nick Clemens changed: What|Removed |Added Assignee|and...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Nick Clemens changed: What|Removed |Added Attachment #111398|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 113966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113966&action=edit Bug 26634: Remove GetHoldRule subroutine in C4::Reserves This routine is only used internally and incorrectly overrides the precedence of holds rules - it should be removed This patch removes the routine, adjusts tests, and adds test to confirm correct precedence is followed To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- I think I had sometimes similar happen recently with loan period... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #7 from Jonathan Druart --- (In reply to Martin Renvoize from comment #3) > Hmmm, so the ordering came from bug 14695 in the first place.. I'm wondering > if it was a deliberate diversion from the norm or a mistake in the first > place. Nope, it existed prior to 14695: commit 3c741d2376e939dea0554a05eddd4f9e9b2d9449 Date: Mon Aug 24 22:10:21 2009 +0200 Smart Rules enhancements +$rightsquery .= " ORDER BY categorycode DESC, itemtype DESC, branchcode DESC"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #6 from Andrew Fuerste-Henry --- Kyle, Nick, and I couldn't find or remember any reason for this grouping from that original bug. If anyone can identify a reason for it, I'm open to keeping it, but then we need to change a bunch of documentation to reflect it. I very much don't know how to write new tests, but I'll bug Kyle about it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Martin Renvoize --- So.. it appears the original unit tests don't test for this scenario.. any chance of adding such a test to db_dependent/Reserves/MultiplePerRecord.t Andrew? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added Attachment #111383|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 111398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111398&action=edit Bug 26634: Do not reorder effective rules To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Lisette Scheer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #3 from Martin Renvoize --- Hmmm, so the ordering came from bug 14695 in the first place.. I'm wondering if it was a deliberate diversion from the norm or a mistake in the first place. It does make sense to make it consistent with the rest of the system however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 ByWater Sandboxes changed: What|Removed |Added Attachment #111379|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 111383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111383&action=edit Bug 26634: Do not reorder effective rules To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||julian.maur...@biblibre.com ||, katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||ke...@bywatersolutions.com, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 111379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111379&action=edit Bug 26634: Do not reorder effective rules To test: 1 - At the All Libraries level, create a circ rule for a specific patron category and a specific item type that only allows 1 hold 2 - At the branch-specific level for Branch A, create an All/All rule that allows 2 holds 3 - confirm ReservesControll is set to patron's library 4 - find a patron from Branch A of the category for which you made your rule 5 - find two bibs with items of the itype got which you made your rule 6 - place a hold on one bib. success! 7 - try to place a hold on the second bib. you're told you cannot because the patron is only allowed 1 hold 8 - apply patch, restart services 9 - try to place your second hold again, success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
