[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #181 from Hammat wele --- Created attachment 178833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178833&action=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177657|0 |1 is obsolete|| --- Comment #180 from Hammat wele --- Created attachment 178832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178832&action=edit Bug 27113: Fix autocomplete list position This patch set the z-index of form-content When you are on the search results page on the intranet, and you do another search that opens the autocomplete dropdown, the results page number is above it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177546|0 |1 is obsolete|| --- Comment #179 from Hammat wele --- Created attachment 178831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178831&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177545|0 |1 is obsolete|| --- Comment #178 from Hammat wele --- Created attachment 178830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178830&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar This patch addresses the sizing issue with the catalog search bar, ensuring that the input zone now covers the entire white bar area. TEST PLAN: 1) Apply the patches that precede this one. 2) Activate IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch in the system preferences. 2) Click "Catalog search" in the navigation bar. 3) Click on the right side of the white area of the search bar. 4) Confirm that it does not allow you to start typing unless you click on the left side of the search bar. 5) Apply this patch. 6) Repeat steps 2 and 3. 7) Verify that this time it allows you to type in the search bar even if you click on the right side of the searc h bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177544|0 |1 is obsolete|| --- Comment #177 from Hammat wele --- Created attachment 178829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178829&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177543|0 |1 is obsolete|| --- Comment #176 from Hammat wele --- Created attachment 178828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178828&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177542|0 |1 is obsolete|| --- Comment #175 from Hammat wele --- Created attachment 178827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178827&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177541|0 |1 is obsolete|| --- Comment #174 from Hammat wele --- Created attachment 178826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178826&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177540|0 |1 is obsolete|| --- Comment #173 from Hammat wele --- Created attachment 178825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178825&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177539|0 |1 is obsolete|| --- Comment #172 from Hammat wele --- Created attachment 178824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178824&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177538|0 |1 is obsolete|| --- Comment #171 from Hammat wele --- Created attachment 178823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178823&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177537|0 |1 is obsolete|| --- Comment #170 from Hammat wele --- Created attachment 178822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178822&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177547|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #177548|0 |1 is obsolete|| --- Comment #169 from Hammat wele --- Created attachment 177657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177657&action=edit Bug 27113: Fix autocomplete list position This patch set the z-index of form-content When you are on the search results page on the intranet, and you do another search that opens the autocomplete dropdown, the results page number is above it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #168 from David Cook --- I think you're getting really close here, and I think dropping bug 25870 as a dependency makes a lot of sense. I'm sure some people might argue with me there... but I think it's a reasonable step, especially in the short-term. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #167 from David Cook --- I think Hammat has fixed some of my concerns, but not all of them... -- 1) I'm still noticing that the input for "Search catalog" is wrong when I'm taken to the detail page. For instance: 1. Search "test" in ktd using "Search catalog" (don't worry about autocomplete) 2. Now type in "e" into the "Search catalog" 3. Choose "Early jazz" 4. You should be taken to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=291&found1=1 5. Note that the input for "Search catalog" says "test" and not "Early jazz" -- 2) The autocomplete suggestions menu looks funny. It starts a bit too far right on the left side, and on the right-side its square edge creates a weird gap with the rounded end of the input for "Search catalog" It's not terrible, but it's... uncomfortable? It just doesn't feel right yet. But close. -- 3) It's still using the SVC API. Switching over to the REST API shouldn't be hard here. Actually, I also notice a api/elasticsearch/elasticsearch.pl which breaks all existing patterns as well. These need to go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #166 from David Cook --- My quick little setup for testing this change: 0. Apply the patch 1. Set SearchEngine to Elasticsearch 2. sudo koha-upgrade-schema kohadev 3. sudo koha-elasticsearch -d -b -r --rebuild -v kohadev 4. perl build-resources.PL 5. Enable IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch sysprefs 6. sudo koha-plack --restart kohadev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #165 from Hammat wele --- Created attachment 177548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177548&action=edit Bug 27113: Fix autocomplete list position This patch set the z-index of form-content When you are on the search results page on the intranet, and you do another search that opens the autocomplete dropdown, the results page number is above it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165901|0 |1 is obsolete|| --- Comment #160 from Hammat wele --- Created attachment 177543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177543&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165922|0 |1 is obsolete|| --- Comment #164 from Hammat wele --- Created attachment 177547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177547&action=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165904|0 |1 is obsolete|| --- Comment #163 from Hammat wele --- Created attachment 177546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177546&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165902|0 |1 is obsolete|| --- Comment #161 from Hammat wele --- Created attachment 177544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177544&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165903|0 |1 is obsolete|| --- Comment #162 from Hammat wele --- Created attachment 177545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177545&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar This patch addresses the sizing issue with the catalog search bar, ensuring that the input zone now covers the entire white bar area. TEST PLAN: 1) Apply the patches that precede this one. 2) Activate IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch in the system preferences. 2) Click "Catalog search" in the navigation bar. 3) Click on the right side of the white area of the search bar. 4) Confirm that it does not allow you to start typing unless you click on the left side of the search bar. 5) Apply this patch. 6) Repeat steps 2 and 3. 7) Verify that this time it allows you to type in the search bar even if you click on the right side of the searc h bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165900|0 |1 is obsolete|| --- Comment #159 from Hammat wele --- Created attachment 177542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177542&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165899|0 |1 is obsolete|| --- Comment #158 from Hammat wele --- Created attachment 177541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177541&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165897|0 |1 is obsolete|| --- Comment #156 from Hammat wele --- Created attachment 177539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177539&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165898|0 |1 is obsolete|| --- Comment #157 from Hammat wele --- Created attachment 177540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177540&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165896|0 |1 is obsolete|| --- Comment #155 from Hammat wele --- Created attachment 177538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177538&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #165895|0 |1 is obsolete|| --- Comment #154 from Hammat wele --- Created attachment 177537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177537&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #153 from Katrin Fischer --- (In reply to David Cook from comment #152) > Overall, I have to say that this is a pretty cool feature. > > We're almost exclusively using Elasticsearch now over Zebra, so I can > probably help move this along. (I'm no good with dev meetings due to > timezones, but let's try to hash out this bug 25870 issue.) I'd be really happy to have this feature in 25.05 and team work is the best work :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #152 from David Cook --- Overall, I have to say that this is a pretty cool feature. We're almost exclusively using Elasticsearch now over Zebra, so I can probably help move this along. (I'm no good with dev meetings due to timezones, but let's try to hash out this bug 25870 issue.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #151 from David Cook --- Btw, it would be interesting to explore changing "_build_query_autocomplete" to include "OpacSuppression" with say a Boolean query, as it would be ideal to include the OpacSuppression search at the search engine level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #150 from David Cook --- Note: The autocomplete appears even when writing advanced queries in the "Search catalog" box. I don't know if that's a good thing or a bad thing. Just an observation. I just wanted to see what it was like for an advanced query vs a simple query. I like that it stops trying to autocomplete on the 5th character. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #149 from David Cook --- Realising now that I needed to rebuild the CSS. It would be good to provide an up-to-date test plan, especially one geared towards koha-testing-docker, which is what most testers will be using. -- With the re-built CSS, the staff interface auto complete is looking much better, but it still looks a little weird. It's a rectangular white text box that overlaps with the masthead. Ah it has the text highlighting now and the separation of suggestions. Excellent. NOTE: If you have a long autocomplete list, it clashes with the search toolbar on the search result page. It displays UNDER the "Select all | Clear all | Unhighlight | Add to cart... etc" when it should be displaying OVER. Additionally, it might make more sense to show 3-5 options instead of 10 and have a scroll so that you can look through the options. 10 options takes up a lot of the page... -- NOTE: It would be interesting to test this against a very large ES database. It's very fast on koha-testing-docker, but it only has ~400 bib records. Note: I notice that there's no loading icon for the autocomplete. Even on a small database, there's a slight lag until the autocomplete results show. It might be good to have a small loading icon in the search bar. (Just a nice to have. Not the end of the world if there isn't one, although on a large database, it might be a problem.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #148 from David Cook --- (Failure) Note: When using koha-testing-docker and the staff interface, if I type in "test" the autocomplete will expand the search bar vertically downwards and show "Testing" underneath "test". It doesn't look good[1], but I continue onwards... I click "Testing". It shows me a "*" instead of "Testing". I try a few more times... and now instead of "*" it shows "test", but it still doesn't show "Testing" which is the actual text I clicked on to search... [1] The UI display gets much worse if I type in "e". It makes the whole masthead expand which looks bad. Also, the autocomplete just looks like a mass of text. Adding some striping on the lines would probably be useful, and text highlight so you know which option you're choosing... -- Interestingly when I type in "e" and choose an option, it will show the autocomplete option in the search bar IF it goes to the search results. If it goes directly to the record, it shows a search query from a long time ago (for example "test" even though I've been searching for "e" for a while now). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #147 from David Cook --- Note: I think we want to use "suggestable" rather than "suggestible" here. The first one, in a technical context, meant to be able to be suggest. "Suggestible" means being easily persuaded by a suggestion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
David Cook changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #146 from David Cook ---
FYI tiny merge conflict when applying this at the moment:
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
@@@ -91,8 -91,8 +91,14 @@@
});
[% END %]
++<<< HEAD
+
+[% IF Koha.Preference( 'CookieConsent' ) %]
+[% Asset.js("js/cookieconsent.js") | $raw %]
++===
+
+ [% IF ( Koha.Preference('IntranetAutocompleteElasticSearch') ) %]
+ [% Asset.js("js/elasticsearch/autocomplete.js") | $raw %]
++>>> Bug 27113: ElasticSearch: Autocomplete in input search
[% END %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #145 from David Cook --- Correct me if I'm wrong but wouldn't the most logical way to move forward with bug 27113 would be to temporarily drop the dependency on bug 27428? That feature, which would depend on bug 25870, could then be added later? Heck, it could even be trialled in prod using a Koha plugin, since it would primarily be an added API endpoint and some Javascript, no? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #144 from David Cook --- (In reply to David Cook from comment #143) > Perhaps I'm misunderstanding the intent on bug 27113. I'd be worried about > searches being done during an autocomplete. I have a lot of big systems that > are slow to search (work in progress making search faster), and that > wouldn't work at all for them... Then I look at bug 27428 and I see how search might get involved... although honestly I'd do that as a follow-up later... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #143 from David Cook --- (In reply to Katrin Fischer from comment #124) > I believe we had a plan here involving solving bug 25870 first as a better > base for the work here. It's already linked as a dependency, but needs some > more work right now. > > I know a lot of people would love to see this functionality and I hope we > can figure out the implementation bits this cycle. I haven't reviewed the patches or comments in depth (I've only skimmed so far), but why would an autocomplete need a q_ccl query parameter on /biblios? It seems to me that bug 25870 is about adding a search endpoint, while this enhancement would be scanning indexes rather than searching them? Perhaps I'm misunderstanding the intent on bug 27113. I'd be worried about searches being done during an autocomplete. I have a lot of big systems that are slow to search (work in progress making search faster), and that wouldn't work at all for them... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 David Cook changed: What|Removed |Added Blocks||27428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #165913|0 |1 is obsolete|| --- Comment #142 from Shi Yao Wang --- Created attachment 165922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165922&action=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #141 from Shi Yao Wang --- Created attachment 165913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165913&action=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #140 from Shi Yao Wang --- rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #163826|0 |1 is obsolete|| --- Comment #139 from Shi Yao Wang --- Created attachment 165904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165904&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #161077|0 |1 is obsolete|| --- Comment #138 from Shi Yao Wang --- Created attachment 165903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165903&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar This patch addresses the sizing issue with the catalog search bar, ensuring that the input zone now covers the entire white bar area. TEST PLAN: 1) Apply the patches that precede this one. 2) Activate IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch in the system preferences. 2) Click "Catalog search" in the navigation bar. 3) Click on the right side of the white area of the search bar. 4) Confirm that it does not allow you to start typing unless you click on the left side of the search bar. 5) Apply this patch. 6) Repeat steps 2 and 3. 7) Verify that this time it allows you to type in the search bar even if you click on the right side of the searc h bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160141|0 |1 is obsolete|| --- Comment #137 from Shi Yao Wang --- Created attachment 165902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165902&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160140|0 |1 is obsolete|| --- Comment #136 from Shi Yao Wang --- Created attachment 165901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165901&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160139|0 |1 is obsolete|| --- Comment #135 from Shi Yao Wang --- Created attachment 165900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165900&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160138|0 |1 is obsolete|| --- Comment #134 from Shi Yao Wang --- Created attachment 165899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165899&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160137|0 |1 is obsolete|| --- Comment #133 from Shi Yao Wang --- Created attachment 165898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165898&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160136|0 |1 is obsolete|| --- Comment #132 from Shi Yao Wang --- Created attachment 165897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165897&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160135|0 |1 is obsolete|| --- Comment #131 from Shi Yao Wang --- Created attachment 165896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165896&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #160134|0 |1 is obsolete|| --- Comment #130 from Shi Yao Wang --- Created attachment 165895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165895&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose changed: What|Removed |Added Status|In Discussion |BLOCKED --- Comment #129 from Caroline Cyr La Rose --- Blocked by bug 25870 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #128 from Matthias Le Gac --- Created attachment 163826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163826&action=edit Bug 27113: Fix the issue of the cursor not displaying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #127 from Katrin Fischer --- (In reply to Katrin Fischer from comment #124) > I believe we had a plan here involving solving bug 25870 first as a better > base for the work here. It's already linked as a dependency, but needs some > more work right now. > > I know a lot of people would love to see this functionality and I hope we > can figure out the implementation bits this cycle. Can you have a look at bug 25870 maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #126 from Hammat wele --- Created attachment 161077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161077&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar This patch addresses the sizing issue with the catalog search bar, ensuring that the input zone now covers the entire white bar area. TEST PLAN: 1) Apply the patches that precede this one. 2) Activate IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch in the system preferences. 2) Click "Catalog search" in the navigation bar. 3) Click on the right side of the white area of the search bar. 4) Confirm that it does not allow you to start typing unless you click on the left side of the search bar. 5) Apply this patch. 6) Repeat steps 2 and 3. 7) Verify that this time it allows you to type in the search bar even if you click on the right side of the searc h bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #161076|0 |1 is obsolete|| Attachment #161076|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #125 from Hammat wele --- Created attachment 161076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161076&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added Attachment #160142|0 |1 is obsolete|| Attachment #160142|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #124 from Katrin Fischer --- I believe we had a plan here involving solving bug 25870 first as a better base for the work here. It's already linked as a dependency, but needs some more work right now. I know a lot of people would love to see this functionality and I hope we can figure out the implementation bits this cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #123 from Magnus Enger --- (In reply to Katrin Fischer from comment #93) > The last big question, I'll refer to the RM: > This adds to /svc which is the outdated way of doing things as others have > pointed out before. I think in order to move on here and before more time is > spend, we should come to a decision of what is required for this patch to > make it in and if it needs to be rewritten to use REST API or if this could > be an exception. As far as I can see, the patches are still adding to svc, not the REST API? So I guess we need to resolve this question for the bug to move forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #122 from Salah Ghedda --- Created attachment 160142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160142&action=edit Bug 27113: Fix the Input Size of the Catalog Search Bar This patch addresses the sizing issue with the catalog search bar, ensuring that the input zone now covers the entire white bar area. TEST PLAN: 1) Apply the patches that precede this one. 2) Activate IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch in the system preferences. 2) Click "Catalog search" in the navigation bar. 3) Click on the right side of the white area of the search bar. 4) Confirm that it does not allow you to start typing unless you click on the left side of the search bar. 5) Apply this patch. 6) Repeat steps 2 and 3. 7) Verify that this time it allows you to type in the search bar even if you click on the right side of the searc h bar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159775|0 |1 is obsolete|| --- Comment #121 from Salah Ghedda --- Created attachment 160141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160141&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159774|0 |1 is obsolete|| --- Comment #120 from Salah Ghedda --- Created attachment 160140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160140&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159773|0 |1 is obsolete|| --- Comment #119 from Salah Ghedda --- Created attachment 160139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160139&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159772|0 |1 is obsolete|| --- Comment #118 from Salah Ghedda --- Created attachment 160138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160138&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159771|0 |1 is obsolete|| --- Comment #117 from Salah Ghedda --- Created attachment 160137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160137&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159770|0 |1 is obsolete|| --- Comment #116 from Salah Ghedda --- Created attachment 160136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160136&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #159769|0 |1 is obsolete|| --- Comment #115 from Salah Ghedda --- Created attachment 160135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160135&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #137780|0 |1 is obsolete|| --- Comment #114 from Salah Ghedda --- Created attachment 160134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160134&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added CC||salah.ghe...@inlibro.com --- Comment #113 from Salah Ghedda --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #146015|0 |1 is obsolete|| --- Comment #112 from Salah Ghedda --- Created attachment 159775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159775&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #145167|0 |1 is obsolete|| --- Comment #111 from Salah Ghedda --- Created attachment 159774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159774&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #141466|0 |1 is obsolete|| --- Comment #110 from Salah Ghedda --- Created attachment 159773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159773&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #139624|0 |1 is obsolete|| --- Comment #109 from Salah Ghedda --- Created attachment 159772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159772&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #137783|0 |1 is obsolete|| --- Comment #108 from Salah Ghedda --- Created attachment 159771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159771&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #137782|0 |1 is obsolete|| --- Comment #107 from Salah Ghedda --- Created attachment 159770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159770&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Salah Ghedda changed: What|Removed |Added Attachment #137781|0 |1 is obsolete|| --- Comment #106 from Salah Ghedda --- Created attachment 159769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159769&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #133042|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #133042|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Bug 27113 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose changed: What|Removed |Added Depends on||32734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 [Bug 32734] REST API: Add a list endpoint for Biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Eric Bégin changed: What|Removed |Added CC|ivan.dzi...@inlibro.com,| |the-minh.lu...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Tomás Cohen Arazi changed: What|Removed |Added Depends on|30790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Bug 27113 depends on bug 30790, which changed state. Bug 30790 Summary: Add REST API route to list biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Caroline Cyr La Rose changed: What|Removed |Added Assignee|ivan.dzi...@inlibro.com |hammat.w...@inlibro.com Depends on||30790, 25870 CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #105 from Caroline Cyr La Rose --- Waiting for some work on bug 25870 and bug 30790 to continue this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 [Bug 25870] Add a q_ccl query parameter to /biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 [Bug 30790] Add REST API route to list biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Hammat wele changed: What|Removed |Added CC||hammat.w...@inlibro.com --- Comment #104 from Hammat wele --- sub filterAutocomplete moved to a new module and now the filtering is done at the search time. (In reply to Katrin Fischer from comment #93) > 6) Updating installations: I believe you also need to reset mappings to make > this work? How can we ensure this works out of the box for people updating > without them having to "redo" their index configuration? (database update?) It's been wrote in the test plan by precaution but there is no need reset mappings to make this work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #103 from Hammat wele --- Created attachment 146015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146015&action=edit Bug 27113: Move filterAutocomplete to a new module and filter the result at search time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #102 from Blou --- Created attachment 145167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145167&action=edit Bug 27113: (follow-up) diacritics/acccents in sought word would make autocomplete return nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #101 from Blou --- Comments from Kate/RM would be appreciated so that Shi Yao (or others) can move ahead with this patch. ShiYao has fixed and commented on the bullet points and this is now in Limbo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #100 from Blou --- Created attachment 141466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141466&action=edit Bug 27113: Allow for ending special characters in titles Modifies the cleanup regex that removed )}' and " endings from the suggested titles or authors. When selected without those, the record was not found. Ex: "MyTitle (1234)" became "MyTitle (123" in the list. It returned no results, where the full title or "MyTitle 123" would. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #99 from Shi Yao Wang --- Created attachment 139624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139624&action=edit Bug 27113: (follow-up) replace removed GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #98 from Shi Yao Wang --- (In reply to Katrin Fischer from comment #93) > First of all: I quite like the functionality and how this looks. It also > appears to be pretty fast and accurate as far as I can tell. I especially > like that it's not only available for the keyword index, but also on other > search options like author search and limits the results down accordingly. > > That said: There are a couple things here that would require fixing and a > big question we need to resolve for moving this forward. > > > The small stuff: > 1) In the database update, there should still be a description for the > system preference. > 2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the > prefs into the correct places. > 3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2 > in coding guidelines) > 4) In the database update elasticsearch should be Elasticsearch. > > > Somewhat bigger: > > 5) I have problems making this work with the "library catalog" and "title" > search options in simple search in OPAC. title doesn't give me any results > and library catalog looks like author (but it's a keyword search). Something > might not be 'wired' correctly there. > 6) Updating installations: I believe you also need to reset mappings to make > this work? How can we ensure this works out of the box for people updating > without them having to "redo" their index configuration? (database update?) > 7) sub filterAutocomplete looks complex and I wonder if it should be in the > .pl and not in a module where it can be tested. 942 is hardcoded as field > for OpacSuppression, which is a little risky. I wonder if it could be more > elegant to filter this at search time instead of after? Small stuff fixed. 5) Searching with "title" works for me. Maybe an index issue? or is it just me? "library catalog" search displays suggestions for each search options in this order: title-cover, author, subject, title-series, publisher. What I think probably happened is, since "title" search doesn't work for you, it showed "author" suggestions where you had more match than the maximum number of rows displayed. 6) I don't know :/ 7) I can move it to a module, but which one? Maybe in a new module? if so, where? I reused the code in opac/opac-detail.pl where 942 is hardcoded too. I do think it would be better to filter at search time but I don't know how... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #137439|0 |1 is obsolete|| --- Comment #97 from Shi Yao Wang --- Created attachment 137783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137783&action=edit Bug 27113: (follow-up) fix adv. searches - more options display issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #137438|0 |1 is obsolete|| --- Comment #96 from Shi Yao Wang --- Created attachment 137782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137782&action=edit Bug 27113: (follow-up) Update descriptions for system preferences Update the descriptions for the new system preferences - IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch. Test plan: 1. Review the descriptions for the IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch system preferences. 2. Make sure they are readable and make sense. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
