[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Victor Grousset/tuxayo changed: What|Removed |Added CC||[email protected] Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.02,20.05.09 |21.05.00,20.11.02,20.05.09, released in||19.11.15 --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||[email protected] Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.09 released in|| --- Comment #10 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||[email protected] ||m Version(s)|21.05.00|21.05.00,20.11.02 released in|| --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Jonathan Druart changed: What|Removed |Added CC||[email protected] ||ommunity.org --- Comment #7 from Jonathan Druart --- Patches squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Jonathan Druart changed: What|Removed |Added Attachment #115074|0 |1 is obsolete|| Attachment #115075|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 115093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115093&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize Bug 27308: (QA follow-up) Remove commented line I don't think we need to keep the original line as a comment.. this patch simply cleans it up. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Works well.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 --- Comment #4 from Martin Renvoize --- Created attachment 115075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115075&action=edit Bug 27308: (QA follow-up) Remove commented line I don't think we need to keep the original line as a comment.. this patch simply cleans it up. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Martin Renvoize changed: What|Removed |Added Attachment #114762|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 115074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115074&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Heather changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #114698|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 114762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114762&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What|Removed |Added CC||[email protected] ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 --- Comment #1 from Nick Clemens --- Created attachment 114698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114698&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
