[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED
 CC||[email protected]

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||[email protected]
 Version(s)|21.05.00,20.11.04   |21.05.00,20.11.04,20.05.10
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #10 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Fridolin Somers  changed:

   What|Removed |Added

 CC||[email protected]
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|21.05.00|21.05.00,20.11.04
released in||

--- Comment #9 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #117858|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 117882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117882&action=edit
Bug 27650: Fix variable passed to the template in opac-main

$template->param(
+koha_news   => @all_koha_news,

We must not pass an array, the number of elements of the hash passed to the
template may be inconsistent.

It's working because of an error earlier in the script:
+@all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);

GetNewsToDisplay returns an arrayref

Test plan:
Define at least 2 news to display on the OPAC main page
Hit opac-main.pl
=> All news are displayed
Click one
=> You see the single news you selected

Signed-off-by: Fridolin Somers 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #116629|0   |1
is obsolete||

--- Comment #6 from Fridolin Somers  ---
Created attachment 117858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117858&action=edit
Bug 27650: Fix variable passed to the template in opac-main

$template->param(
+koha_news   => @all_koha_news,

We must not pass an array, the number of elements of the hash passed to the
template may be inconsistent.

It's working because of an error earlier in the script:
+@all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);

GetNewsToDisplay returns an arrayref

Test plan:
Define at least 2 news to display on the OPAC main page
Hit opac-main.pl
=> All news are displayed
Click one
=> You see the single news you selected

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Fridolin Somers  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

David Cook  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

--- Comment #5 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #2)
> Patch doesn't apply:
> 
> Applying: Bug 27650: Fix variable passed to the template in opac-main
> fatal: empty ident name (for <>) not allowed

For the record: it didn't like the 'From: ' in the commit body. The 'Author: '
part of the patch was replaced by this 'From: '. Weird git bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #116628|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 116629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116629&action=edit
Bug 27650: Fix variable passed to the template in opac-main

$template->param(
+koha_news   => @all_koha_news,

We must not pass an array, the number of elements of the hash passed to the
template may be inconsistent.

It's working because of an error earlier in the script:
+@all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);

GetNewsToDisplay returns an arrayref

Test plan:
Define at least 2 news to display on the OPAC main page
Hit opac-main.pl
=> All news are displayed
Click one
=> You see the single news you selected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #116490|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 116628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116628&action=edit
Bug 27650: Fix variable passed to the template in opac-main

From:
  commit acb455f151ac737613857c58e64a600d760a59e0
  Bug 14272: Show single news item [alternative patch]

$template->param(
+koha_news   => @all_koha_news,

We must not pass an array, the number of elements of the hash passed to the
template may be inconsistent.

It's working because of an error earlier in the script:
+@all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);

GetNewsToDisplay returns an arrayref

Test plan:
Define at least 2 news to display on the OPAC main page
Hit opac-main.pl
=> All news are displayed
Click one
=> You see the single news you selected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Owen Leonard  ---
Patch doesn't apply:

Applying: Bug 27650: Fix variable passed to the template in opac-main
fatal: empty ident name (for <>) not allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27634


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634
[Bug 27634] Turn off patron self-registration if no default category is set
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

--- Comment #1 from Jonathan Druart  
---
Created attachment 116490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116490&action=edit
Bug 27650: Fix variable passed to the template in opac-main

From:
  commit acb455f151ac737613857c58e64a600d760a59e0
  Bug 14272: Show single news item [alternative patch]

$template->param(
+koha_news   => @all_koha_news,

We must not pass an array, the number of elements of the hash passed to the
template may be inconsistent.

It's working because of an error earlier in the script:
+@all_koha_news   = &GetNewsToDisplay($news_lang,$homebranch);

GetNewsToDisplay returns an arrayref

Test plan:
Define at least 2 news to display on the OPAC main page
Hit opac-main.pl
=> All news are displayed
Click one
=> You see the single news you selected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27650] Wrong variable passed to the template in opac-main

2021-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/