[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #38 from Victor Grousset/tuxayo --- I guess this should go in the technical release notes? Here is a first try: ### Perl modules A new lib directory has been added for Perl modules. This might requires some changes in your webserver configuration if you don't install Koha via the Debian packages. Here are more info about these changes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519#c2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519#c15 This ticket says: «Pushed to 21.05.x for 21.05.01» Shouldn't it be also in the 21.05 tech release notes? I guess they are published and immutable? https://annuel.framapad.org/p/koha_21.11_tech_release_notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #37 from David Cook --- (In reply to Jonathan Druart from comment #34) > But it needs to be top priority for you. Fair enough. I have very little to give to Koha at the moment... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #36 from David Cook --- (In reply to Julian Maurice from comment #33) > But using Plack::Middleware::Session would prevent using koha with > mojolicious servers like morbo or hypnotoad, right ? Probably -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28617 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #35 from Jonathan Druart --- (discussion should continue on bug 17427) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #34 from Jonathan Druart --- * Mason already packaged Data::Session (on bug 17427) * CGI::Session is no longer maintained and has a bad bug (see bug 17427 comment 0) * Patch is there on bug 17427 (not fully working but close), when we are talking about an hypothetical rewrite * Less dependency but more code to maintain on our side. * Getting such feedback after the 3+ years 17427 has been written is a bit frustrating... That being said I would support you if you are volunteering for an alternative (writing Koha::Session or using Plack::Middleware::Session), I will test, provide feedback and make it ready for 21.11. But it needs to be top priority for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519
--- Comment #33 from Julian Maurice ---
I think I agree with David here: writing our own Koha::Session should be
relatively easy, and it would remove the need of a separate
{CGI|Data}::Session::Serialize::yamlxs. And having less dependencies is a good
thing IMO.
But using Plack::Middleware::Session would prevent using koha with mojolicious
servers like morbo or hypnotoad, right ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #32 from David Cook --- (In reply to Jonathan Druart from comment #31) > Not directly related to the discussion, but see also bug 17427 comment 29. > When we will move (finally) to Data::Session we will hit a problem with the > package not in /usr/share/perl5/CGI/Session/Serialize/ (not along with > Serialize.pm at least). That's a good point (although wouldn't it be "/usr/share/perl5/Data/Session/Serialize"?). That said, I feel like this is an argument against moving to Data::Session. That get_my_serializers function is a dreadful bit of code. I'm not seeing any packages for Data::Session in Debian or Ubuntu and it seems like it has a lot of dependencies. Also, Ron Savage took over CGI::Session and self-declared that his Data::Session was the successor to CGI::Session. Do we have any evidence that anyone actually uses it? I'd be tempted to either use Plack::Middleware::Session and finally put the nail in CGI, or write our own Koha::Session module. It doesn't need to be very complicated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #31 from Jonathan Druart --- Not directly related to the discussion, but see also bug 17427 comment 29. When we will move (finally) to Data::Session we will hit a problem with the package not in /usr/share/perl5/CGI/Session/Serialize/ (not along with Serialize.pm at least). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #30 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #29) > I think he means having our own debian package for > CGI::Session::Serialize::yamlxs that would be installed to > /usr/share/perl5/CGI/Session/Serialize/yamlxs.pm > > This seems like a bad thing to do though, as it would possibly break other > Perl applications, right? Hi Kyle, Right. Not that hard. This should not break other Perl apps as it should not break Koha :) We put it in our PERL5LIB path! Note that if you do not set the serializer parameter to this new one, you probably wont ever notice it is there. And when it is only in a specific Koha container, even more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #29 from Kyle M Hall --- (In reply to David Cook from comment #28) > (In reply to Marcel de Rooy from comment #26) > > Hi David, > > I understand 'We do not have a lib folder' point. > > But still wondering (especially since this report just creates a > > CGI::Session variant in lib): > > > > > We could have fooled Koha too by making our own package and install it in > > > a > > > regular perllib ? > > I still don't know what you mean by "we could have fooled Koha", or "our own > package", or "regular perllib". Do you mean a Perl package or a Debian > package? What do you mean by "perllib"? Do you mean PERL5LIB, site Perl, > vendor Perl, Koha's top-level directory where we store C4 and Koha dirs, or > something else? How would it be fooling Koha? I think he means having our own debian package for CGI::Session::Serialize::yamlxs that would be installed to /usr/share/perl5/CGI/Session/Serialize/yamlxs.pm This seems like a bad thing to do though, as it would possibly break other Perl applications, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #28 from David Cook --- (In reply to Marcel de Rooy from comment #26) > Hi David, > I understand 'We do not have a lib folder' point. > But still wondering (especially since this report just creates a > CGI::Session variant in lib): > > > We could have fooled Koha too by making our own package and install it in a > > regular perllib ? I still don't know what you mean by "we could have fooled Koha", or "our own package", or "regular perllib". Do you mean a Perl package or a Debian package? What do you mean by "perllib"? Do you mean PERL5LIB, site Perl, vendor Perl, Koha's top-level directory where we store C4 and Koha dirs, or something else? How would it be fooling Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #27 from Fridolin Somers --- Depends on Bug 28489 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Bug 28519 depends on bug 28489, which changed state. Bug 28489 Summary: CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #26 from Marcel de Rooy --- Hi David, I understand 'We do not have a lib folder' point. But still wondering (especially since this report just creates a CGI::Session variant in lib): > We could have fooled Koha too by making our own package and install it in a > regular perllib ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #25 from David Cook --- (In reply to Marcel de Rooy from comment #23) > (In reply to David Cook from comment #0) > > Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to > > hack it into C4::Auth. > > > > I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib > > only exists in a deployed Koha. There is no "lib" directory in the source > > tree. But we can fix that. > > Not opposing this change, but isnt this a hack too? We could have fooled > Koha too by making our own package and install it in a regular perllib ? > Just curious why we exactly need lib. It's the opposite of a hack. C4 and Koha should never have been top-level directories in the source tree. We should always have had a "lib" top-level directory in which to place modules. This change is about creating a better standard and using it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.01 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #24 from Kyle M Hall --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #23 from Marcel de Rooy --- (In reply to David Cook from comment #0) > Bug 28489 looks to add CGI::Session::Serializer::yamlxs, but it wants to > hack it into C4::Auth. > > I rather we put it in a Perl "lib" directory. However, /usr/share/koha/lib > only exists in a deployed Koha. There is no "lib" directory in the source > tree. But we can fix that. Not opposing this change, but isnt this a hack too? We could have fooled Koha too by making our own package and install it in a regular perllib ? Just curious why we exactly need lib. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Blocks||28589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 [Bug 28589] Move C4 and Koha to lib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #22 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What|Removed |Added Attachment #122077|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 122079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122079&action=edit Bug 28519: Add lib to koha-shell Test plan: % koha-shell kohadev -c 'echo $PERL5LIB' => /kohadevbox/koha:/kohadevbox/koha/lib % koha-shell kohadev echo $PERL5LIB => /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools Note that this is not consistent but at least we have lib now in both situations Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #20 from Jonathan Druart --- Created attachment 122077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122077&action=edit Bug 28519: Add lib to koha-shell Test plan: % koha-shell kohadev -c 'echo $PERL5LIB' => /kohadevbox/koha:/kohadevbox/koha/lib % koha-shell kohadev echo $PERL5LIB => /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools Note that this is not consistent but at least we have lib now in both situations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #19 from Jonathan Druart --- There is change missing in koha-shell root@kohadevbox:koha$ echo $PERL5LIB /kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/qa-test-tools root@kohadevbox:koha$ koha-shell kohadev kohadev-koha@kohadevbox:/kohadevbox/koha$ echo $PERL5LIB /kohadevbox/koha:/kohadevbox/qa-test-tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart --- Skipping QA as we need to move forward (needed for 21.05.01). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #16 from Victor Grousset/tuxayo --- Thanks for the explanations :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #15 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #14) > (In reply to David Cook from comment #9) > > (In reply to Jonathan Druart from comment #6) > > > The main question to me is: is it safe enough for backport into 21.05.01? > > > > I would say yes especially for Debian package installations. > > > > Dev environments are the ones that will experience the most changes, but we > > can deal with any pain there. > > > > Once this change is in place, Koha will be much more powerful. > > There are more than 200 production instances based on git, which changes > will they experience? It depends on how they do their deployments. If they use symlinks for things like their Apache configuration, then it should be automagical after a "make upgrade". But if they don't, then they'll need to manually update their Apache configuration. (Changes to koha-worker.service and koha-index-daemon-ctl.sh would matter less in the short-term but they would need updates too.) People not using Debian packages are always going to be vulnerable to Apache configuration changes though. I'll note that my PR for koha-gitify needs to be merged in too for users of koha-gitify (like koha-testing-docker): https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #9) > (In reply to Jonathan Druart from comment #6) > > The main question to me is: is it safe enough for backport into 21.05.01? > > I would say yes especially for Debian package installations. > > Dev environments are the ones that will experience the most changes, but we > can deal with any pain there. > > Once this change is in place, Koha will be much more powerful. There are more than 200 production instances based on git, which changes will they experience? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #13 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > I would love to move all libs to a libs/ dir, but lets do it on a separate > bug, and discuss the tradeoffs there (my butt has been kicked a couple times > when I proposed it, because of all bugzilla patches not applying if we did > that). Quick remark: this is not true. Git handles that (ie. if a file has been "git mv", a "git am" will follow the move). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
--- Comment #12 from Julian Maurice ---
You can replace
foreach my $code (@dir_codes){
my $path = $target_dirs->{ $code };
if ($path){
$unique_map{$path} = 1 unless $unique_map{$path};
}
}
my @paths = sort keys %unique_map;
by
my @paths = sort uniq map { $target_dirs->{$_} || () } @dir_codes;
and if you don't like List::MoreUtils or non-core dependencies, List::Util also
has a uniq subroutine.
But that was only a suggestion.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #11 from David Cook --- (In reply to Julian Maurice from comment #10) > Just a little suggestion: you can use uniq from List::MoreUtils to make the > code smaller and easier to read I don't see how using uniq would make it smaller or easier to read. I also don't like the idea of adding a non-core dependency to Makefile.PL for such a simple task. Further, I don't like List::MoreUtils. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519
--- Comment #10 from Julian Maurice ---
Comment on attachment 121836
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121836
Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory
Review of attachment 121836:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28519&attachment=121836)
-
::: Makefile.PL
@@ +1804,5 @@
> +if ($path){
> +$unique_map{$path} = 1 unless $unique_map{$path};
> +}
> +}
> +my @paths = sort keys %unique_map;
Just a little suggestion: you can use uniq from List::MoreUtils to make the
code smaller and easier to read
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #6) > The main question to me is: is it safe enough for backport into 21.05.01? I would say yes especially for Debian package installations. Dev environments are the ones that will experience the most changes, but we can deal with any pain there. Once this change is in place, Koha will be much more powerful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #8 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #7) > (In reply to Jonathan Druart from comment #6) > > The main question to me is: is it safe enough for backport into 21.05.01? > > I think it is. I would still skip the lib/ dir for now. But have no problem > other than that with the patch. My question was about the lib dir :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > The main question to me is: is it safe enough for backport into 21.05.01? I think it is. I would still skip the lib/ dir for now. But have no problem other than that with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #6 from Jonathan Druart --- The main question to me is: is it safe enough for backport into 21.05.01? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > I agree, generally. but: > 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please > add a test for that behavior. This die is obvious (I added it when I wrote a patch for bug 17427 more than 4y ago - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56504). Writing a test for it is not trivial and I would not block the whole change for that. > 2. I think you should simplify your patch by just putting the CGI/ dir in > the top level. In that case, you would just do what we do for C4, Koha and > the OpenILS library directories in Makefile.PL (& friends). No complex hacks. I think it makes sense to have it in lib. > I would love to move all libs to a libs/ dir, but lets do it on a separate > bug, and discuss the tradeoffs there (my butt has been kicked a couple times > when I proposed it, because of all bugzilla patches not applying if we did > that). Like having intranet controller scripts in their own directory (bug 9949). Could be part of a roadmap topic, but definitely not something for 21.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Tomás Cohen Arazi --- I agree, generally. but: 1. You are adding an unadvertised die in C4::Auth (I agree with it!). Please add a test for that behavior. 2. I think you should simplify your patch by just putting the CGI/ dir in the top level. In that case, you would just do what we do for C4, Koha and the OpenILS library directories in Makefile.PL (& friends). No complex hacks. I would love to move all libs to a libs/ dir, but lets do it on a separate bug, and discuss the tradeoffs there (my butt has been kicked a couple times when I proposed it, because of all bugzilla patches not applying if we did that). If you need me to write a follow-up to address my comments, let me know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords||rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Nick Clemens changed: What|Removed |Added Attachment #121649|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 121836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121836&action=edit Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Jonathan Druart changed: What|Removed |Added Blocks||17427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427 [Bug 17427] Replace CGI::Session with Data::Session -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #2 from David Cook --- Dev test plan: 1. vi /etc/apache2/sites-enabled/kohadev.conf 2. Change "SetEnv PERL5LIB "/kohadevbox/koha" to SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 2b. service apache2 reload 3. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/koha-functions.sh 4. koha-plack --restart kohadev 5. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl 6. Go to CGI script http://localhost:8081/cgi-bin/koha/tools/export.pl (Note that this is still run in CGI even when using Plack) NOTE: We'll need to update koha-gitify (https://gitlab.com/koha-community/koha-gitify) to get that Apache configuration. There's no harm in updating it, since this is a backwards compatible change. See https://gitlab.com/koha-community/koha-gitify/-/merge_requests/2. -- Deploy test plan: Dev: 1. perl Makefile.PL 1a. Installation mode: dev 1b. Configuration directory: /opt/koha-dev 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha-dev/etc/koha-conf.xml export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 6a. vi /opt/koha-dev/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/kohadevbox/koha:/kohadevbox/koha/lib" 7a. vi /opt/koha-dev/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib 8a. vi /opt/koha-dev/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/kohadevbox/koha:/kohadevbox/koha/lib" 9a. vi /opt/koha-dev/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/kohadevbox/koha/lib PERL5LIB_DIRS=/kohadevbox/koha:/kohadevbox/koha/lib 6. rm -rf /opt/koha-dev 7. make clean Single: 1. perl Makefile.PL 1a. Installation mode: single 1b. Please specify the directory in which to install Koha: /opt/koha 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note the output says the following: In order to use Koha's command-line batch jobs, you should set the following environment variables: export KOHA_CONF=/opt/koha/etc/koha-conf.xml export PERL5LIB=/opt/koha/lib 6a. vi /opt/koha/etc/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/opt/koha/lib" 7a. vi /opt/koha/etc/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/opt/koha/lib 8a. vi /opt/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/opt/koha/lib" 9a. vi /opt/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/opt/koha/lib PERL5LIB_DIRS=/opt/koha/lib 10. ls /opt/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. rm -rf /opt/koha 13. make clean Standard: 1. perl Makefile.PL 1a. accept all the defaults 2. make 3. ls blib/PERL_MODULE_LIB_DIR/ 4. Note the following: CGI 5. make install 5b. Note there is a set_koha_ownership failure because of a missing "koha" user, but that's OK since this is an overly intensive process within koha-testing-docker anyway, and the install has already succeeded at this point. 6a. vi /etc/koha/koha-httpd.conf 6b. Note the following: SetEnv PERL5LIB "/usr/share/koha/lib" 7a. vi /etc/koha/koha-worker.service 7b. Note the following: Environment=PERL5LIB=/usr/share/koha/lib 8a. vi /usr/share/koha/bin/koha-index-daemon-ctl.sh 8b. Note the following: PERL5LIB="/usr/share/koha/lib" 9a. vi /usr/share/koha/misc/koha-install-log 9b. Note the following: PERL_MODULE_LIB_DIR=/usr/share/koha/lib PERL5LIB_DIRS=/usr/share/koha/lib 10. ls /usr/share/koha/lib 11. Note the following: C4 CGI cpanfile Koha Koha.pm 12. make clean -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #1 from David Cook --- Created attachment 121649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121649&action=edit Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory This patch adds a "lib" directory to the source tree which gets mapped to the same directory as "C4" and "Koha" for single and standard installations. CGI::Session::Serialize::yamlxs is put into this "lib" directory. This patch also includes some changes so that dev/git installations work as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 David Cook changed: What|Removed |Added Depends on||28489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28489 [Bug 28489] CGI::Session is incorrectly serialized to DB in production env / when strict_sql_modes = 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
