[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What|Removed |Added Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #17 from Nick Clemens --- The performance increase was lessened as the removal of the biblio fetch was lost during a rebase Bug 3142 added a use of the biblio_object for checking holdability Closing this one out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #16 from David Cook --- (In reply to Jonathan Druart from comment #8) > Are you sure we don't only need to pass/cache the MARC record? > Did you benchmark this patch? Maybe it's worth looking again at this one with Devel::NYTProf to see where speed gains could be made... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #15 from Owen Leonard --- I'm getting an average improvement of .03 seconds, and I'm not sure what to say about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #14 from Nick Clemens --- (In reply to David Cook from comment #13) > (In reply to Nick Clemens from comment #12) > > > Did you benchmark this patch? > > with numSearchResults at 50 - standard sample data, search for 'a' > > Before patch ~2 second > > After patch ~1.85 seconds > > Is that averaged or based on 1 test each? I repeated the tests 10 times each, that was the average -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #13 from David Cook --- (In reply to Nick Clemens from comment #12) > > Did you benchmark this patch? > with numSearchResults at 50 - standard sample data, search for 'a' > Before patch ~2 second > After patch ~1.85 seconds Is that averaged or based on 1 test each? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #12 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Are you sure we don't only need to pass/cache the MARC record? I suppose we could, but we have already called TransformMarcToKoha, why would we not pass the values we calculated? > Did you benchmark this patch? with numSearchResults at 50 - standard sample data, search for 'a' Before patch ~2 second After patch ~1.85 seconds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Nick Clemens changed:
What|Removed |Added
Attachment #127657|0 |1
is obsolete||
--- Comment #11 from Nick Clemens ---
Created attachment 127688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127688&action=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #10 from Jonathan Druart --- Patch rebased (and tidied searchResults changes). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Jonathan Druart changed:
What|Removed |Added
Attachment #122962|0 |1
is obsolete||
--- Comment #9 from Jonathan Druart ---
Created attachment 127657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127657&action=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #8 from Jonathan Druart --- Are you sure we don't only need to pass/cache the MARC record? Did you benchmark this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||joonas.kylm...@iki.fi --- Comment #7 from Joonas Kylmälä --- Doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Nick Clemens changed:
What|Removed |Added
Attachment #122835|0 |1
is obsolete||
--- Comment #6 from Nick Clemens ---
Created attachment 122962
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122962&action=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Jonathan Druart --- (In reply to David Cook from comment #3) > I like the motivation for the change, but I'm not sure about the style. What > if we moved most of the logic out of "custom_cover_image_url" and into a > separate class method. Then "custom_cover_image_url" could call that class > method, and that class method could be used in the search results. I think > that would make the code easier to read and maintain in the longer term. After I read the patches I was coming here to write that. Missing occurrence: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% SET custom_cover_image_url = SEARCH_RESULT.biblio_object.custom_cover_image_url %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Owen Leonard changed:
What|Removed |Added
Attachment #122833|0 |1
is obsolete||
--- Comment #4 from Owen Leonard ---
Created attachment 122835
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122835&action=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 David Cook changed: What|Removed |Added Summary|Fetching biblio objects for |Fetching biblio objects for |custom covers is|custom covers is |innefficient|inefficient -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
