[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Kristi Krueger changed: What|Removed |Added CC||[email protected] ||g -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 [email protected] changed: What|Removed |Added CC||catherine.micklethwaite@nhs ||.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=42950 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to main |Needs documenting CC||[email protected] --- Comment #73 from Lucas Gass (lukeg) --- Enhancement will not be backported to 26.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #72 from Pedro Amorim (ammopt) --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Pedro Amorim (ammopt) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||26.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #71 from Pedro Amorim (ammopt) --- Created attachment 200454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200454&action=edit Bug 28915: (RM follow-up): Remove dead code + typo fix Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #70 from Andrew Fuerste-Henry --- Created attachment 198645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198645&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #69 from Andrew Fuerste-Henry --- Created attachment 198644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198644&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #68 from Andrew Fuerste-Henry --- Created attachment 198643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198643&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #67 from Andrew Fuerste-Henry --- Created attachment 198642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198642&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #66 from Andrew Fuerste-Henry --- Created attachment 198641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198641&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #65 from Andrew Fuerste-Henry --- Created attachment 198640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198640&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #64 from Andrew Fuerste-Henry --- Created attachment 198639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198639&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #63 from Andrew Fuerste-Henry --- Created attachment 198638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198638&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #62 from Andrew Fuerste-Henry --- Created attachment 198637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198637&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915
--- Comment #61 from Andrew Fuerste-Henry ---
Created attachment 198636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198636&action=edit
Bug 28915: Add control field support to Koha::SimpleMARC::update_field()
Before this patch, control fields were not modifiable using this subroutine.
Control fields use character positions instead of subfields. When modifying
control fields, this patch makes the subroutine's parameter "subfield" to
indicate
a character position. An example
Koha::SimpleMARC::update_field({
record => $record,
field => '008',
subfield => '2',
values => [09],
});
changes field 008 starting from character position 2 to contain values "09".
This replaces char pos 2 with "0", and char pos 3 with "9".
To test:
1. prove t/SimpleMARC.t
Signed-off-by: David Nind
Signed-off-by: Andrew Fuerste Henry
Signed-off-by: Anneli Österman
Signed-off-by: Andrew Fuerste Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198631|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198593|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198592|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198591|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198590|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198589|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198587|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198586|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198585|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #60 from Lari Taskula --- (In reply to Andrew Fuerste-Henry from comment #58) > This is giving me several merge errors. Can I please get a rebase? Done. Please try again :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198583|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #59 from Lari Taskula --- Created attachment 198631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198631&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198584|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #58 from Andrew Fuerste-Henry --- This is giving me several merge errors. Can I please get a rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Eric Phetteplace changed: What|Removed |Added CC|[email protected]| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Anneli Österman changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #57 from OpenFifth Sandboxes --- Created attachment 198593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198593&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #56 from OpenFifth Sandboxes --- Created attachment 198592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198592&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #55 from OpenFifth Sandboxes --- Created attachment 198591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198591&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #54 from OpenFifth Sandboxes --- Created attachment 198590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198590&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #53 from OpenFifth Sandboxes --- Created attachment 198589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198589&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #52 from OpenFifth Sandboxes --- Created attachment 198588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198588&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #51 from OpenFifth Sandboxes --- Created attachment 198587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198587&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #50 from OpenFifth Sandboxes --- Created attachment 198586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198586&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915
--- Comment #49 from OpenFifth Sandboxes ---
Created attachment 198585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198585&action=edit
Bug 28915: Add control field support to Koha::SimpleMARC::update_field()
Before this patch, control fields were not modifiable using this subroutine.
Control fields use character positions instead of subfields. When modifying
control fields, this patch makes the subroutine's parameter "subfield" to
indicate
a character position. An example
Koha::SimpleMARC::update_field({
record => $record,
field => '008',
subfield => '2',
values => [09],
});
changes field 008 starting from character position 2 to contain values "09".
This replaces char pos 2 with "0", and char pos 3 with "9".
To test:
1. prove t/SimpleMARC.t
Signed-off-by: David Nind
Signed-off-by: Andrew Fuerste Henry
Signed-off-by: Anneli Österman
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #48 from OpenFifth Sandboxes --- Created attachment 198584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198584&action=edit Bug 41343: Further improvements Remove unused patron attribute values sent to the template Send preferred name Use SQL to do date comparison to see if an item is overdue Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198582|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198581|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198580|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198579|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198578|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198577|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198576|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198541|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 OpenFifth Sandboxes changed: What|Removed |Added Attachment #198540|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #47 from Lari Taskula --- (In reply to Lari Taskula from comment #38) > Good catch with the 2-digit length issue Anneli and Andrew, and thanks for > providing a fix. I wrote a test that caught regression in > C4::MarcModificationTemplates, and provided a patch to fix it. I also added > a small patch for adjusting maxlength of the subfield whenever subfield (1 > char)/charpos (2 chars) is toggled. Because of these new patches I've reset > this Bug back to "Needs Signoff". Not a biggie but I think we should choose one of the following two patches, but not both: "Bug 28915: Adjust input maxlength when subfield is used as charpos" "Bug 28915: (follow-up) Increase field size and maxlength in template" Maybe a bit far fetched but a static 2 character maxlength rule increases the potential to misuse the input field when used as a subfield. On the other hand my patch might introduce new bugs with its dynamic attribute modifications. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198573|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198572|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198571|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198546|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198545|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198544|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198543|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Attachment #198542|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #46 from Lari Taskula --- Created attachment 198583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198583&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #45 from Lari Taskula --- Created attachment 198582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198582&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #44 from Lari Taskula --- Created attachment 198581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198581&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #43 from Lari Taskula --- Created attachment 198580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198580&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #42 from Lari Taskula --- Created attachment 198579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198579&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #41 from Lari Taskula --- Created attachment 198578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198578&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #40 from Lari Taskula --- Created attachment 198577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198577&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #39 from Lari Taskula --- Created attachment 198576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198576&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lari Taskula -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Lari Taskula changed: What|Removed |Added Status|Passed QA |Needs Signoff --- Comment #38 from Lari Taskula --- Good catch with the 2-digit length issue Anneli and Andrew, and thanks for providing a fix. I wrote a test that caught regression in C4::MarcModificationTemplates, and provided a patch to fix it. I also added a small patch for adjusting maxlength of the subfield whenever subfield (1 char)/charpos (2 chars) is toggled. Because of these new patches I've reset this Bug back to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #37 from Lari Taskula --- Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #36 from Lari Taskula --- Created attachment 198573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198573&action=edit Bug 28915: Adjust input maxlength when subfield is used as charpos To test MARC modification with the new feature: 1. Add a new record and make sure it has the following fields 1.1 Field 008 character position 35-37 contains "|||" 1.2 Field 041$a contains "eng" 2. Navigate to Cataloging > MARC modification templates > + New template (name "Change 008 lang") 3. Click + New action 4. Add "008" after "field(s)" 5. From dropdown "Delete", select "Update existing or add new" 6. To the input field on the right of "starting from character position", enter value 35 7. To the input field on the right of "with value", enter eng 8. From the empty dropdown below, select "if" 9. To the input field on the right of "field", enter 041, and to the right, enter a 10. From the dropdown on the right, select "matches" 11. Check "RegEx" 12. To the empty input field on the right, enter ^eng$ (the line should now say: [if] field [041] [a] [matches] m/[^eng$]/ RegEx [X]) 13. Give any description you want (ex. Change 008 35-37 to eng) 14. Navigate to the record details you added in step 1 15. Click Edit > Modify record using template 16. Click "Show MARC" 17. Double check field 008 character position 35-37 is currently ||| 18. Click "Close" 19. From dropdown "Select a template", select your new modification template from step 2 20. Click "Show MARC" 21. Observe field 008 character position 35-37 is now eng 22. Click "Modify selected records" 23. After job is completed, observe field 008 character positions 35-37 is now eng Also test MARC modification templates for non-control fields in case of regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #35 from Lari Taskula --- Created attachment 198572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198572&action=edit Bug 28915: Fix field_exists call in C4::MarcModificationTemplates Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 460. To test: 1. prove t/db_dependent/MarcModificationTemplates.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #34 from Lari Taskula --- Created attachment 198571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198571&action=edit Bug 28915: Add test for AddModificationTemplateAction To test: 1. prove t/db_dependent/MarcModificationTemplates.t Observe test failing with the following error t/db_dependent/MarcModificationTemplates.t .. 1/135 Control fields (generally, just tags below 010) do not have subfields, use data() at /home/koha/Koha/Koha/SimpleMARC.pm line 490. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #33 from Andrew Fuerste-Henry --- Created attachment 198546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198546&action=edit Bug 28915: (follow-up) Update kohatructure.sql Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #32 from Andrew Fuerste-Henry --- Created attachment 198545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198545&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 198544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198544&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #30 from Andrew Fuerste-Henry --- Created attachment 198543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198543&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #29 from Andrew Fuerste-Henry --- Created attachment 198542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198542&action=edit Bug 28915: (follow-up) Add POD Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 198541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198541&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915
--- Comment #27 from Andrew Fuerste-Henry ---
Created attachment 198540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198540&action=edit
Bug 28915: Add control field support to Koha::SimpleMARC::update_field()
Before this patch, control fields were not modifiable using this subroutine.
Control fields use character positions instead of subfields. When modifying
control fields, this patch makes the subroutine's parameter "subfield" to
indicate
a character position. An example
Koha::SimpleMARC::update_field({
record => $record,
field => '008',
subfield => '2',
values => [09],
});
changes field 008 starting from character position 2 to contain values "09".
This replaces char pos 2 with "0", and char pos 3 with "9".
To test:
1. prove t/SimpleMARC.t
Signed-off-by: David Nind
Signed-off-by: Andrew Fuerste Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198539|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198534|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198533|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198532|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198531|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198530|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #198529|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 Andrew Fuerste-Henry changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #26 from Lucas Gass (lukeg) --- Created attachment 198539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198539&action=edit Bug 28915: (follow-up) Update kohatructure.sql Patch from commit 6fb4553 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 198534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198534&action=edit Bug 28915: (follow-up) DBIC schema - DO NOT PUSH Patch from commit 4669370 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #24 from Andrew Fuerste-Henry --- Created attachment 198533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198533&action=edit Bug 28915: (follow-up) Increase field size and maxlength in template Patch from commit 346eb63 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #23 from Andrew Fuerste-Henry --- Created attachment 198532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198532&action=edit Bug 28915: (follow-up) atomicupdate to increase from_subfield size Patch from commit c7e8f5a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #22 from Andrew Fuerste-Henry --- Created attachment 198531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198531&action=edit Bug 28915: (follow-up) Add POD Patch from commit abcbc9b -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915 --- Comment #21 from Andrew Fuerste-Henry --- Created attachment 198530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198530&action=edit Bug 28915: Add character position to MARC modification templates view To test new form events: 1. Navigate to Cataloging > MARC modification templates > + New template (and provide any name) 2. Click + New action 3. Add "008" after "field(s)" and click tabulator or your mouse anywhere on the screen 4. Observe the second (sub)field input field disappearing 5. From dropdown "Delete", select "Update existing or add new" 6. Observe new text "starting from character position" 7. Select any other action from the dropdown from step 5 8. Observe the text "starting from character position" disappearing (unless action is to update or add new field) 9. Observe subfield input field missing (unless action is to update or add new field) To test MARC modification with the new feature: 1. Add a new record 2. Modify record's 008 field character position 2-3 to "06" (indicating month June) 3. Navigate to Cataloging > MARC modification templates > + New template (name "Change June to September") 4. Click + New action 5. Add "008" after "field(s)" 6. From dropdown "Delete", select "Update existing or add new" 7. To the input field on the right of "starting from character position", enter value 2 8. To the input field on the right of "with value", enter 09 9. From the empty dropdown below, select "if" 10. To the input field on the right of "field", enter 008 11. From the dropdown on the right, select "matches" 12. Check "RegEx" 13. To the empty input field on the right, enter ^[0-9][0-9]06 14. Give any description you want (ex. Change 008 June to September) 15. Navigate to the record details you added in step 1 16. Click Edit > Modify record using template 17. Click "Show MARC" 18. Double check field 008 character position 2-3 is currently 06 19. Click "Close" 20. From dropdown "Select a template", select your new modification template from step 3 21. Click "Show MARC" 22. Observe field 008 character position 2-3 is now 09 23. Click "Modify selected records" 24. After job is completed, observe field 008 character positions 2-3 are now 09 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28915] MARC modification templates should allow specification of a position or range within a control field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915
--- Comment #20 from Andrew Fuerste-Henry ---
Created attachment 198529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198529&action=edit
Bug 28915: Add control field support to Koha::SimpleMARC::update_field()
Before this patch, control fields were not modifiable using this subroutine.
Control fields use character positions instead of subfields. When modifying
control fields, this patch makes the subroutine's parameter "subfield" to
indicate
a character position. An example
Koha::SimpleMARC::update_field({
record => $record,
field => '008',
subfield => '2',
values => [09],
});
changes field 008 starting from character position 2 to contain values "09".
This replaces char pos 2 with "0", and char pos 3 with "9".
To test:
1. prove t/SimpleMARC.t
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
