[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Nick Clemens (kidclamp) changed: What|Removed |Added Blocks||38607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38607 [Bug 38607] Default CART notice is removing spaces from subtitles -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Koha collecto changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m --- Comment #200 from Fridolin Somers --- *** Bug 36980 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Fridolin Somers changed: What|Removed |Added Blocks||36980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36980 [Bug 36980] Show location description in basket/sendbasket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #199 from Martin Renvoize --- I'm fixing it in whilst rebasing bug 31224.. but it's a bit upsetting that we opened up that leak. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #198 from Martin Renvoize --- This exposed intranet-facing data in opac baskets :(. We dropped the filters from the metadata record fetching :S -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Blocks||31224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added CC||[email protected] --- Comment #197 from Katrin Fischer --- *** Bug 11443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/685 Documentation||Caroline Cyr La Rose contact|| Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Blocks||33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #196 from Matt Blenkinsop --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #195 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #194 from Katrin Fischer --- Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #193 from Kyle M Hall --- Created attachment 148185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148185&action=edit Bug 3150: (QA follow-up) Tidy scripts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #192 from Kyle M Hall --- Created attachment 148184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148184&action=edit Bug 3150: (QA follow-up) Don't load unused and deleted tt files Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #191 from Kyle M Hall --- Created attachment 148183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148183&action=edit Bug 3150: (QA follow-up) Remove unused variables Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #190 from Kyle M Hall --- Created attachment 148182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148182&action=edit Bug 3150: (follow-up) Make sure host information displays for unlinked records When the 773 entry is not linked to a record using $w or Easyanalytics we still want to display the information about the source/host item in the emails. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Add a few other records to the cart. 9. Host item information (In: ) should display for all entries with 773 in the record. This also makes use of the biblio-title include to display the different parts of the title (245$abnp), if the record is linked. Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #189 from Kyle M Hall --- Created attachment 148181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148181&action=edit Bug 3150: (follow-up) Make subs to get host/related parts for notices Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #188 from Kyle M Hall --- Created attachment 148180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148180&action=edit Bug 3150: Include host item entries in LIST and CART notices Incorporating fixes from Bug 16522 Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #187 from Kyle M Hall --- Created attachment 148179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148179&action=edit Bug 3150: (follow-up) Improve and fix new notice templates This fixes several issues found and improves formatting: * Add missing line breaks where required as we are now using HTML * Add missing USE statements to show * library * location * Link to the OPAC (Preference was not resolved) * Make sure there is a comma between library and location * Make sure Author(s): only displays when there is content after * The comment field allows multi-line comments, formatting is now preserved Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #186 from Kyle M Hall --- Created attachment 148178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148178&action=edit Bug 3150: (follow-up) Send list and cart emails immediately again With this patch set the cart and list emails are sent via the message_queue instead of bypassing it and being sent immediately. This patch keeps them in message_queue, but also sends them immediately, restoring the previous behavior. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #185 from Kyle M Hall --- Created attachment 148177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148177&action=edit Bug 3150: Fix file permission on database update file Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #184 from Kyle M Hall --- Created attachment 148176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148176&action=edit Bug 3150: (follow-up) Use get_marc_contributors Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #183 from Kyle M Hall --- Created attachment 148175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148175&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #182 from Kyle M Hall --- Created attachment 148174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148174&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #181 from Kyle M Hall --- Created attachment 148173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148173&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #180 from Kyle M Hall --- Created attachment 148172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148172&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #179 from Kyle M Hall --- Created attachment 148171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148171&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Kyle M Hall changed: What|Removed |Added Attachment #147868|0 |1 is obsolete|| Attachment #147869|0 |1 is obsolete|| Attachment #147870|0 |1 is obsolete|| Attachment #147871|0 |1 is obsolete|| Attachment #147872|0 |1 is obsolete|| Attachment #147873|0 |1 is obsolete|| Attachment #147874|0 |1 is obsolete|| Attachment #147875|0 |1 is obsolete|| Attachment #147876|0 |1 is obsolete|| Attachment #147877|0 |1 is obsolete|| Attachment #147878|0 |1 is obsolete|| Attachment #147879|0 |1 is obsolete|| Attachment #148045|0 |1 is obsolete|| --- Comment #178 from Kyle M Hall --- Created attachment 148170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148170&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #177 from Aleisha Amohia --- Katrin's follow-up looks great so have done an additional sign-off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #147880|0 |1 is obsolete|| --- Comment #176 from Aleisha Amohia --- Created attachment 148045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148045&action=edit Bug 3150: (follow-up) Make sure host information displays for unlinked records When the 773 entry is not linked to a record using $w or Easyanalytics we still want to display the information about the source/host item in the emails. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Add a few other records to the cart. 9. Host item information (In: ) should display for all entries with 773 in the record. This also makes use of the biblio-title include to display the different parts of the title (245$abnp), if the record is linked. Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #175 from Katrin Fischer --- Created attachment 147880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147880&action=edit Bug 3150: (follow-up) Make sure host information displays for unlinked records When the 773 entry is not linked to a record using $w or Easyanalytics we still want to display the information about the source/host item in the emails. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Add a few other records to the cart. 9. Host item information (In: ) should display for all entries with 773 in the record. This also makes use of the biblio-title include to display the different parts of the title (245$abnp), if the record is linked. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #147423|0 |1 is obsolete|| --- Comment #174 from Katrin Fischer --- Created attachment 147879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147879&action=edit Bug 3150: (follow-up) Make subs to get host/related parts for notices Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146987|0 |1 is obsolete|| --- Comment #173 from Katrin Fischer --- Created attachment 147878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147878&action=edit Bug 3150: Include host item entries in LIST and CART notices Incorporating fixes from Bug 16522 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146867|0 |1 is obsolete|| --- Comment #172 from Katrin Fischer --- Created attachment 147877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147877&action=edit Bug 3150: (follow-up) Improve and fix new notice templates This fixes several issues found and improves formatting: * Add missing line breaks where required as we are now using HTML * Add missing USE statements to show * library * location * Link to the OPAC (Preference was not resolved) * Make sure there is a comma between library and location * Make sure Author(s): only displays when there is content after * The comment field allows multi-line comments, formatting is now preserved Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146866|0 |1 is obsolete|| --- Comment #171 from Katrin Fischer --- Created attachment 147876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147876&action=edit Bug 3150: (follow-up) Send list and cart emails immediately again With this patch set the cart and list emails are sent via the message_queue instead of bypassing it and being sent immediately. This patch keeps them in message_queue, but also sends them immediately, restoring the previous behavior. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146865|0 |1 is obsolete|| --- Comment #170 from Katrin Fischer --- Created attachment 147875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147875&action=edit Bug 3150: Fix file permission on database update file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146864|0 |1 is obsolete|| --- Comment #169 from Katrin Fischer --- Created attachment 147874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147874&action=edit Bug 3150: (follow-up) Use get_marc_contributors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146863|0 |1 is obsolete|| --- Comment #168 from Katrin Fischer --- Created attachment 147873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147873&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146862|0 |1 is obsolete|| --- Comment #167 from Katrin Fischer --- Created attachment 147872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147872&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146861|0 |1 is obsolete|| --- Comment #166 from Katrin Fischer --- Created attachment 147871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147871&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146860|0 |1 is obsolete|| --- Comment #165 from Katrin Fischer --- Created attachment 147870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147870&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146859|0 |1 is obsolete|| --- Comment #164 from Katrin Fischer --- Created attachment 147869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147869&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146858|0 |1 is obsolete|| --- Comment #163 from Katrin Fischer --- Created attachment 147868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147868&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #162 from Aleisha Amohia --- Created attachment 147423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147423&action=edit Bug 3150: (follow-up) Make subs to get host/related parts for notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #161 from Katrin Fischer --- With the last patch I get an error in the send form: ERROR PROCESSING TEMPLATE: undef error - ... at input text line 21. at /kohadevbox/koha/virtualshelves/sendshelf.pl line 100. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #160 from Aleisha Amohia --- Created attachment 146987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146987&action=edit Bug 3150: Include host item entries in LIST and CART notices Incorporating fixes from Bug 16522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #159 from Katrin Fischer --- I have to say, I am not sad to see a lot of this old code go away,especially the old template files. This appears as quite a code clean-up. 10 files changed, 306 insertions(+), 1083 deletions(-) 1) The database update and the sample files are both marked as "is_html", but were missing some line breaks and such. I ended up also fixing some issues with missing USE statements causing the OPAC link to not display. --> Follow-up provided, see commit message for more details 2) Currently the mails are sent immediately, this should be kept moving forward. --> Follow-up provided 3) The notices need to be amended to include the changes from bug 16522 to avoid a regression: Bug 16522 - Add 773 (Host item entry) to the cart and list displays and e-mails --> I got stuck on this one, could you please take a look, Aleisha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #158 from Katrin Fischer --- Created attachment 146867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146867&action=edit Bug 3150: (follow-up) Improve and fix new notice templates This fixes several issues found and improves formatting: * Add missing line breaks where required as we are now using HTML * Add missing USE statements to show * library * location * Link to the OPAC (Preference was not resolved) * Make sure there is a comma between library and location * Make sure Author(s): only displays when there is content after * The comment field allows multi-line comments, formatting is now preserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #157 from Katrin Fischer --- Created attachment 146866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146866&action=edit Bug 3150: (follow-up) Send list and cart emails immediately again With this patch set the cart and list emails are sent via the message_queue instead of bypassing it and being sent immediately. This patch keeps them in message_queue, but also sends them immediately, restoring the previous behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #156 from Katrin Fischer --- Created attachment 146865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146865&action=edit Bug 3150: Fix file permission on database update file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146566|0 |1 is obsolete|| --- Comment #155 from Katrin Fischer --- Created attachment 146864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146864&action=edit Bug 3150: (follow-up) Use get_marc_contributors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146565|0 |1 is obsolete|| --- Comment #154 from Katrin Fischer --- Created attachment 146863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146863&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146564|0 |1 is obsolete|| --- Comment #153 from Katrin Fischer --- Created attachment 146862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146862&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146563|0 |1 is obsolete|| --- Comment #152 from Katrin Fischer --- Created attachment 146861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146861&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146562|0 |1 is obsolete|| --- Comment #151 from Katrin Fischer --- Created attachment 146860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146860&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146561|0 |1 is obsolete|| --- Comment #150 from Katrin Fischer --- Created attachment 146859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146859&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Attachment #146560|0 |1 is obsolete|| --- Comment #149 from Katrin Fischer --- Created attachment 146858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146858&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #148 from Aleisha Amohia --- Created attachment 146566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146566&action=edit Bug 3150: (follow-up) Use get_marc_contributors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145681|0 |1 is obsolete|| --- Comment #147 from Aleisha Amohia --- Created attachment 146565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146565&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145680|0 |1 is obsolete|| --- Comment #146 from Aleisha Amohia --- Created attachment 146564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146564&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145679|0 |1 is obsolete|| --- Comment #145 from Aleisha Amohia --- Created attachment 146563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146563&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145678|0 |1 is obsolete|| --- Comment #144 from Aleisha Amohia --- Created attachment 146562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146562&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145677|0 |1 is obsolete|| --- Comment #143 from Aleisha Amohia --- Created attachment 146561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146561&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #145676|0 |1 is obsolete|| --- Comment #142 from Aleisha Amohia --- Created attachment 146560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146560&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #141 from Katrin Fischer --- Hi Aleisha, with bug 16522 now pushed, this no longer applies. Could you pleas rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 3150: Move emails for sending cart and list contents to notices Using index info to reconstruct a base tree... M basket/sendbasket.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents to notices hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-3150-Move-emails-for-sending-cart-and-list-con-7TAJ75.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #140 from David Nind --- (In reply to Aleisha Amohia from comment #133) > That patch should've been made obsolete, fixed Thanks Aleisha! Testing notes -- unchanged: see comment #103 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145234|0 |1 is obsolete|| --- Comment #139 from David Nind --- Created attachment 145681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145681&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145233|0 |1 is obsolete|| --- Comment #138 from David Nind --- Created attachment 145680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145680&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145232|0 |1 is obsolete|| --- Comment #137 from David Nind --- Created attachment 145679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145679&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145231|0 |1 is obsolete|| --- Comment #136 from David Nind --- Created attachment 145678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145678&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145230|0 |1 is obsolete|| --- Comment #135 from David Nind --- Created attachment 145677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145677&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Attachment #145229|0 |1 is obsolete|| --- Comment #134 from David Nind --- Created attachment 145676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145676&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #133 from Aleisha Amohia --- That patch should've been made obsolete, fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140258|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #132 from David Nind --- I'm getting an sha1 error when trying to apply the patch: git bz apply 3150 Bug 3150 - Move emails for sending cart and list contents into notices tool 140258 - Bug 3150: (follow-up) Fix .yml formatting 145229 - Bug 3150: Move emails for sending cart and list contents to notices 145230 - Bug 3150: (follow-up) HTML filtering TT notices and removing old files 145231 - Bug 3150: (follow-up) Reformat notices, don't send if no sender email 145232 - Bug 3150: (follow-up) Add missing bracket 145233 - Bug 3150: (follow-up) Fixing errors and notices 145234 - Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 3150: (follow-up) Fix .yml formatting error: sha1 information is lacking or useless (installer/data/mysql/en/mandatory/sample_notices.yml). error: could not build fake ancestor Patch failed at 0001 Bug 3150: (follow-up) Fix .yml formatting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140259|0 |1 is obsolete|| --- Comment #131 from Aleisha Amohia --- Created attachment 145234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145234&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140257|0 |1 is obsolete|| --- Comment #130 from Aleisha Amohia --- Created attachment 145233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145233&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140256|0 |1 is obsolete|| --- Comment #129 from Aleisha Amohia --- Created attachment 145232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145232&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140255|0 |1 is obsolete|| --- Comment #128 from Aleisha Amohia --- Created attachment 145231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145231&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140254|0 |1 is obsolete|| --- Comment #127 from Aleisha Amohia --- Created attachment 145230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145230&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #140253|0 |1 is obsolete|| --- Comment #126 from Aleisha Amohia --- Created attachment 145229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145229&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Cook changed: What|Removed |Added CC||[email protected] --- Comment #125 from David Cook --- Looking forward to this one... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #124 from Aleisha Amohia --- Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #123 from Martin Renvoize --- The rebase wasn't too terrible actually.. back to you Katrin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Attachment #140252|0 |1 is obsolete|| --- Comment #122 from Martin Renvoize --- Created attachment 140259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140259&action=edit Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Attachment #140251|0 |1 is obsolete|| --- Comment #121 from Martin Renvoize --- Created attachment 140258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140258&action=edit Bug 3150: (follow-up) Fix .yml formatting FAIL yaml_valid YAML::XS::Load Error: The problem: did not find expected key was found at document: 1, line: 1748, column: 1 while parsing a block mapping at line: 23, column: 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Attachment #140250|0 |1 is obsolete|| --- Comment #120 from Martin Renvoize --- Created attachment 140257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140257&action=edit Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Attachment #140249|0 |1 is obsolete|| --- Comment #119 from Martin Renvoize --- Created attachment 140256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140256&action=edit Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize changed: What|Removed |Added Attachment #140248|0 |1 is obsolete|| --- Comment #118 from Martin Renvoize --- Created attachment 140255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140255&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
