[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Bug 33736 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #74 from Katrin Fischer --- Picked last patch "(follow-up) Cleanup and consistency" for main. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #73 from Martin Renvoize (ashimema) --- Created attachment 174582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174582&action=edit Bug 33736: (follow-up) Cleanup and consistency Given Jonathans comments, this patch performs the requested cleanups. * We use the new select option for kohaTables for the pickup library search. * We add pickup library to the aside filters. * We remove the empty placeholder 'actions' column. * We drop the filtering on 'waiting' which will be reintroduced by the next but in the tree. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #72 from Katrin Fischer --- (In reply to Jonathan Druart from comment #71) > Comments 61, 63, 64? Martin and Paul, can you please review and split into new bugs were needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #71 from Jonathan Druart --- Comments 61, 63, 64? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #70 from Paul Derscheid --- Sorry, what I mean is, I think there's no additional work needed anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #69 from Paul Derscheid --- I'd say so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #68 from Martin Renvoize (ashimema) --- Is there actually any 'addition_work_needed' here still.. I can't spot any so can we remove the keyword? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Text to go in the||The enhancement adds a new release notes||'Bookings to collect' ||report into the Circulation ||module. It parallels the ||'Holds to pull' report ||allowing staff to easily ||report against upcoming ||bookings and collect them ||from the shelves ready for ||collection by the patron ||who has the item booked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736
--- Comment #59 from Jonathan Druart ---
Just looking at the code, with the other work related to the REST API and
timezone, I don't think what you are doing with the date filters is correct.
You should do what is done on the background job page ("filter by last hour").
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #67 from Martin Renvoize (ashimema) --- Agreed, I don't think this should be backported, it's certainly an enhancement to the new feature of bookings. The datatables work is next on my list for today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #63 from Jonathan Druart --- Do we have an "Action" column that is always empty? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #65 from Jonathan Druart --- (In reply to Jonathan Druart from comment #62) > commit 025ed2d09aadc229490c94c5c82234e6942dbcf9 > Bug 33736: Ensure datatable filter row takes visible into account > > I am really concerned about this commit. > On bug 33484 AND bug 36640 I am adjusting this code to fix problems with the > column visibility. I made sure that we didn't have conflict with the state, > the column visibility, the hidden column (forced in the config), and the > different tables. > > This patch should really be on its own bug and the different tables tested, > not only this one. > > I am going to drop the changes made here for the other 2 bugs, but if we > have 4 different codes (pre 33736, post 33736, 33736+33484, post > 33736+33484+36640) to maintain in main and stable, it will be a nightmare to > fix. I have rebased bug 33484 on top of main and dropped the changes from this commit. Everything is ok on this table (as expected). If we plan to have 33484 in 24.11 and not bug 33736 backported then we can just ignore this situation. Otherwise we should maybe consider moving this specific patch on its own bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature --- Comment #66 from Katrin Fischer --- I feel like this is too much of a new feature for backport. There might also be some hidden dependencies on other new code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #62 from Jonathan Druart --- commit 025ed2d09aadc229490c94c5c82234e6942dbcf9 Bug 33736: Ensure datatable filter row takes visible into account I am really concerned about this commit. On bug 33484 AND bug 36640 I am adjusting this code to fix problems with the column visibility. I made sure that we didn't have conflict with the state, the column visibility, the hidden column (forced in the config), and the different tables. This patch should really be on its own bug and the different tables tested, not only this one. I am going to drop the changes made here for the other 2 bugs, but if we have 4 different codes (pre 33736, post 33736, 33736+33484, post 33736+33484+36640) to maintain in main and stable, it will be a nightmare to fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #64 from Jonathan Druart --- The "Pickup library" column filter should be a dropdown list with the list of libraries (see patron search, item list on bib detail, etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736
--- Comment #61 from Jonathan Druart ---
137 status: { '!=': 'waiting' },
waiting?
DB does not list it.
| status | enum('new','cancelled','completed') | NO | | new
| |
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736
--- Comment #60 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #59)
> Just looking at the code, with the other work related to the REST API and
> timezone, I don't think what you are doing with the date filters is correct.
>
> You should do what is done on the background job page ("filter by last
> hour").
Confirmed:
q={"start_date":{">=":"2024-10-27T23:00:00.000Z","<=":"2024-11-04T22:59:59.999Z"}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #58 from Jonathan Druart --- (In reply to Katrin Fischer from comment #55) > I know that Joubu will not be too happy, but I feel that this is a very > important workflow improvement for the bookings that should be in this > release. I hope we can work together to get the datatables work in as well > and this won't cause too big a hassle. Yes, touching column visibility with the other work in the queue is not a good idea. Wondering why we didn't push without the columns settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172839|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize (ashimema) --- Created attachment 173294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173294&action=edit Bug 33736: Add item location and filter by library to bookings to collect report This patch adds a new 'Location' field to the bookings to collect report. We display with the current item location or an onloan status with the due date. We also add filtering for status != 'waiting' to the base query to rule out items marked as ready for collection already (however, we don't yet have a way of marking such a status so this won't have any effect yet). Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #57 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #56 from Paul Derscheid --- Yes to all of that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_11_candidate | --- Comment #55 from Katrin Fischer --- I know that Joubu will not be too happy, but I feel that this is a very important workflow improvement for the bookings that should be in this release. I hope we can work together to get the datatables work in as well and this won't cause too big a hassle. Thanks Martin for the quick follow-ups. I updated some more strings to make them also translatable in another follow-up. Wondering if the "Booking dates" column sorting doesn't need some more thought, but I am OK to handle that separately. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #52 from Martin Renvoize (ashimema) --- Created attachment 173301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173301&action=edit Bug 33736: (QA follow-up) Holds & Bookings > Holds and bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172836|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize (ashimema) --- Created attachment 173291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173291&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172842|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize (ashimema) --- Created attachment 173297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173297&action=edit Bug 33736: Ensure datatable filter row takes visible into account We clone the header row, and then iterate it assuming the iterator index lines up with the column definition index of the datatables settings. However, if a column is hidden, this is not the case. Said column will not appear in the header row that's cloned and as such your iterator will no longer line up with the column settings index number of the settings array. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172844|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize (ashimema) --- Created attachment 173299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173299&action=edit Bug 33736: Add column settings definition for bookings report Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172840|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize (ashimema) --- Created attachment 173295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173295&action=edit Bug 33736: Bootstrap 5 update Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 rachel.schlach...@mtangel.edu changed: What|Removed |Added CC||rachel.schlachter@mtangel.e ||du -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #54 from Martin Renvoize (ashimema) --- Created attachment 173303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173303&action=edit Bug 33736: (follow-up) Rebase fix for changed api date handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172841|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize (ashimema) --- Created attachment 173296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173296&action=edit Bug 33736: (follow-up) Remove top-level embed in bookings.yaml For reference, see: bug 30536. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #53 from Martin Renvoize (ashimema) --- Created attachment 173302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173302&action=edit Bug 33736: (QA follow-up) Wrap title strings for translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172845|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize (ashimema) --- Created attachment 173300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173300&action=edit Bug 33736: Don't allow sorting on Location We need some special handling to sort on Location as it's got both a custom renderer and relies on _strings so the ordering and search won't return expected results without some custom function building. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172843|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize (ashimema) --- Created attachment 173298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173298&action=edit Bug 33736: Don't search on start_date if no date filter is defined Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172838|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize (ashimema) --- Created attachment 173293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173293&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172837|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize (ashimema) --- Created attachment 173292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173292&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. Sponsored-by: PTFS Europe Ltd Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||jonathan.dru...@gmail.com
--- Comment #41 from Katrin Fischer ---
Joubu has asked not to push changes to table configuration settings while the
datatables bugs are progressing. Will check with him before pushing.
I'll use the time to ask for a few small follow-ups:
1) Capitalization
Holds & Bookings > Holds and bookings
I am pretty sure we have removed all the & in the past, I think to ease
translations.
2) Translatability
a) These won't be translatable:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
+"title": "Pickup library",
Please check all "title":
b) This won't be tranlatable as well: tt file = single underscore
+return __("On loan, due: ") .
$date(row.item.checked_out_date);
3) Internal server error
[2024/10/24 15:35:27] [ERROR] GET /api/v1/bookings: unhandled exception
(Koha::Exceptions::BadParameter)< start_date>>
MariaDB [koha_kohadev]> select * from bookings;
++---+---+-+---+-+-+-+-++
| booking_id | patron_id | biblio_id | item_id | pickup_library_id | start_date
| end_date| creation_date | modification_date |
status |
++---+---+-+---+-+-+-+-++
| 11 |19 | 184 | 393 | CPL | 2024-10-24
22:00:00 | 2024-10-30 22:59:59 | 2024-10-24 15:32:11 | 2024-10-24 15:32:11 |
new|
++---+---+-+---+-+-+-+-++
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Katrin Fischer changed: What|Removed |Added Keywords||rel_24_11_candidate, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords||roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |paul.dersch...@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172823|0 |1 is obsolete|| --- Comment #40 from Paul Derscheid --- Created attachment 172845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172845&action=edit Bug 33736: Don't allow sorting on Location We need some special handling to sort on Location as it's got both a custom renderer and relies on _strings so the ordering and search won't return expected results without some custom function building. Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172810|0 |1 is obsolete|| --- Comment #39 from Paul Derscheid --- Created attachment 172844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172844&action=edit Bug 33736: Add column settings definition for bookings report Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172808|0 |1 is obsolete|| --- Comment #38 from Paul Derscheid --- Created attachment 172843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172843&action=edit Bug 33736: Don't search on start_date if no date filter is defined Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172807|0 |1 is obsolete|| --- Comment #37 from Paul Derscheid --- Created attachment 172842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172842&action=edit Bug 33736: Ensure datatable filter row takes visible into account We clone the header row, and then iterate it assuming the iterator index lines up with the column definition index of the datatables settings. However, if a column is hidden, this is not the case. Said column will not appear in the header row that's cloned and as such your iterator will no longer line up with the column settings index number of the settings array. Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172765|0 |1 is obsolete|| --- Comment #36 from Paul Derscheid --- Created attachment 172841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172841&action=edit Bug 33736: (follow-up) Remove top-level embed in bookings.yaml For reference, see: bug 30536. Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172721|0 |1 is obsolete|| --- Comment #35 from Paul Derscheid --- Created attachment 172840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172840&action=edit Bug 33736: Bootstrap 5 update Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172720|0 |1 is obsolete|| --- Comment #34 from Paul Derscheid --- Created attachment 172839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172839&action=edit Bug 33736: Add item location and filter by library to bookings to collect report This patch adds a new 'Location' field to the bookings to collect report. We display with the current item location or an onloan status with the due date. We also add filtering for status != 'waiting' to the base query to rule out items marked as ready for collection already (however, we don't yet have a way of marking such a status so this won't have any effect yet). Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172719|0 |1 is obsolete|| --- Comment #33 from Paul Derscheid --- Created attachment 172838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172838&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172718|0 |1 is obsolete|| --- Comment #32 from Paul Derscheid --- Created attachment 172837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172837&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Attachment #172717|0 |1 is obsolete|| --- Comment #31 from Paul Derscheid --- Created attachment 172836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172836&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #30 from Martin Renvoize (ashimema) --- Created attachment 172823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172823&action=edit Bug 33736: Don't allow sorting on Location We need some special handling to sort on Location as it's got both a custom renderer and relies on _strings so the ordering and search won't return expected results without some custom function building. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Depends on||29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #29 from Martin Renvoize (ashimema) --- Created attachment 172810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172810&action=edit Bug 33736: Add column settings definition for bookings report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #28 from Martin Renvoize (ashimema) --- Created attachment 172808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172808&action=edit Bug 33736: Don't search on start_date if no date filter is defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #27 from Martin Renvoize (ashimema) --- Created attachment 172807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172807&action=edit Bug 33736: Ensure datatable filter row takes visible into account We clone the header row, and then iterate it assuming the iterator index lines up with the column definition index of the datatables settings. However, if a column is hidden, this is not the case. Said column will not appear in the header row that's cloned and as such your iterator will no longer line up with the column settings index number of the settings array. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de Status|Signed Off |Failed QA --- Comment #26 from Paul Derscheid --- Unfortunately I found some issues: - There's a link to the configure tables view even though there's no associated table config. - The patron column has no search input even though it IS marked as searchable in the column object. - This one is mainly a question on UX, if I leave an input empty in the filter component it appears to filter w/ the last value it had. No deal-breaker in any way, just something that I noticed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #25 from Paul Derscheid --- Created attachment 172765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172765&action=edit Bug 33736: (follow-up) Remove top-level embed in bookings.yaml For reference, see: bug 30536. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||37652 Depends on|37652 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37652 [Bug 37652] Add alert for upcoming bookings at checkin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #24 from Martin Renvoize (ashimema) --- Created attachment 172721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172721&action=edit Bug 33736: Bootstrap 5 update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #23 from Martin Renvoize (ashimema) --- Created attachment 172720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172720&action=edit Bug 33736: Add item location and filter by library to bookings to collect report This patch adds a new 'Location' field to the bookings to collect report. We display with the current item location or an onloan status with the due date. We also add filtering for status != 'waiting' to the base query to rule out items marked as ready for collection already (however, we don't yet have a way of marking such a status so this won't have any effect yet). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #170400|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize (ashimema) --- Created attachment 172719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172719&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #170399|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize (ashimema) --- Created attachment 172718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172718&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172716|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize (ashimema) --- Created attachment 172717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172717&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #170398|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize (ashimema) --- Created attachment 172716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172716&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Paul Derscheid changed: What|Removed |Added Blocks||38165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38165 [Bug 38165] Add a view to the staff interface to manage bookings of a library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||38119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38119 [Bug 38119] Add a combined 'Items to pull' report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Circulation||bookings function|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Depends on|37601 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37601 [Bug 37601] Add status field to bookings table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Depends on||37652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37652 [Bug 37652] Add alert for upcoming bookings at checkin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #18 from Martin Renvoize --- Library location now taken into account.. status is next -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #17 from Martin Renvoize --- Created attachment 170400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170400&action=edit Bug 33736: Add filter for holding library This patch adds the option to filter the pending bookings to collect report by items current holding library and defaults to the users logged in library. We also add the 'Pickup library' column to the report output so staff know whether the item needs collecting for sending to another library or for their own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #165280|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 170399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170399&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #165279|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 170398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170398&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Depends on|29002 |37601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37601 [Bug 37601] Add status field to bookings table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Aude Charillon changed: What|Removed |Added CC||aude.charillon@ptfs-europe. ||com --- Comment #14 from Aude Charillon --- A library team we work with has been experimenting with this. They made the following comments: 1) If a booking has been issued, it stays on the list. This is not useful to the library team: they would prefer to see only those bookings still to be collected. 2) This report needs to filter by library. It is not useful to see bookings for all libraries; the team needs to see bookings for their own library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Marie changed: What|Removed |Added CC||marie.hed...@musikverket.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #13 from Martin Renvoize --- Thanks for the signoff and feedback Esther :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #165278|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 165280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165280&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #165277|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 165279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165279&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther Melander -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #10 from Martin Renvoize --- Created attachment 165278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165278&action=edit Bug 33736: Set default window to 1 week This update the default display from today + 1 to today + 7 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #165144|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 165277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165277&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com Status|Needs Signoff |Signed Off --- Comment #8 from Esther Melander --- My test plan: 1. Search the catalog and make several items bookable. 2. Schedule bookings for those items. Try to do a variety of bookings, such as multiple patrons for the same item, overlap dates, specific item, any item, different titles. 3. Navigate to circulation, click on bookings. 4. The date range displayed may need adjustment to display the table. Adjust if needed and see the table. The table defaults to only showing bookings to be collected for "today". In order to see the pending bookings coming up, the dates selected needed to be adjusted in order to display all the ones I had created for the next month. I would prefer to have the pending bookings display for the next week by default. I suppose larger consortia may need it to be daily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 ByWater Sandboxes changed: What|Removed |Added Attachment #165014|0 |1 is obsolete|| --- Comment #7 from ByWater Sandboxes --- Created attachment 165144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165144&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. NOTE: Refinements still required Signed-off-by: Esther -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #6 from Martin Renvoize --- Rebased ready for testing. The page is very basic as it stands, with the idea that we'll iterate and add actions into it once they become apparent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Attachment #161044|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 165014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165014&action=edit Bug 33736: Add pendingbookings report This patch adds a 'Bookings to collect' page to circulation that allows for a workflow similar to 'Holds to pull', but for bookings. NOTE: Refinements still required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Laurence Rault changed: What|Removed |Added CC||laurence.ra...@biblibre.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Laurence Rault --- Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 33736: Add pendingbookings report Using index info to reconstruct a base tree... M api/v1/swagger/paths/bookings.yaml M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt Auto-merging api/v1/swagger/paths/bookings.yaml error: Failed to merge in the changes. Patch failed at 0001 Bug 33736: Add pendingbookings report [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33736-Add-pendingbookings-report-66f05im8.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 Martin Renvoize changed: What|Removed |Added Blocks||36119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36119 [Bug 36119] Bookings to collect needs a print option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33736] Add bookings to collect circulation report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33736 --- Comment #3 from Martin Renvoize --- This is the basic report, but I need feedback on what actions people would like to take from it.. it's a work in progress. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
