subject:"\[Koha\-bugs\] \[Bug 34440\] Add warm\-up and cool\-down periods to bookings"

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

karie.stra...@yavapaiaz.gov changed:

   What|Removed |Added

 CC||karie.stra...@yavapaiaz.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2025-01-31 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440
Bug 34440 depends on bug 36120, which changed state.

Bug 36120 Summary: Add pickup locations to bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-11-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Pushed to main  |Needs documenting
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-11-14 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-11-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Lisette Scheer  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||38308


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38308
[Bug 38308] Add validation to 'booking pre/post-processing' in circulation
rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-10-29 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||38287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38287
[Bug 38287] Saving Default checkout, hold and return policy with empty bookings
values causes error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-10-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

  Text to go in the||This enhancement to the
  release notes||recently added bookings
   ||functionality allows
   ||libraries to define a
   ||lead-in and trail-out
   ||period to be prepended and
   ||appended to bookings.
   ||
   ||These periods prevent
   ||checkouts or bookings from
   ||taking place too close to
   ||each other and allow for
   ||things like transfers and
   ||maintenance to be carried
   ||out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Ed Veal  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||38016


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38016
[Bug 38016] Relabel booking precaution column heading in circulation rules
tables
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

davedaghita  changed:

   What|Removed |Added

 CC||ddagh...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #96 from Jonathan Druart  ---
Reading the code:

koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js

 149 leadDays = rules.bookings_lead_period;
 150 trailDays = rules.n;

 819 const leadStart = startDate
 820 ? startDate.subtract(leadDays, "day")
 821 : hoverDate.subtract(leadDays, "day");
 822 const leadEnd = startDate ? startDate :
hoverDate;

I think we should test if startDate is defined.

Then also if bookings_lead_period and bookings_trail_period are defined.

I see, at least, "Uncaught TypeError: startDate is null" when no start date is
selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #95 from Jonathan Druart  ---
Thanks Pedro, nice one. It drove me crazy!

I didn't noticed the error in the logs!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #94 from Martin Renvoize  ---
Follow-up pushed.. lets see how Jenkins does now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #93 from Martin Renvoize  ---
Thanks Pedro, great work.

I honestly have no idea how those lines got added in the first place to
onboarding.. I don't remember adding them and certainly didn't test that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #92 from Pedro Amorim  ---
Created attachment 170951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170951&action=edit
Bug 34440: bookings_lead_period and bookings_trail_period cant be set at
categorycode level

Follow Joubu's test plan. It should no longer fail.

Error from eval Koha::CirculationRules->set_rules($params) at onboarding.pl
was:
set_rule cannot set 'bookings_trail_period' for a 'categorycode'! at
/kohadevbox/koha/installer/onboarding.pl line 301.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||RM_priority

--- Comment #91 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #90)
> If I comment, in t/db_dependent/selenium/opac_holds.t:
> 
> reset_data() that is after
>   detail_page_hold_button_absent('Authenticated - onshelfholds If all
> unavailable');
> 
> Then cleanup_data();, I can see the problem on the UI
> 
> It seems that opac/opac-detail.pl
>  701 $can_holds_be_placed =
>  702 $can_holds_be_placed || $patron &&
> IsAvailableForItemLevelRequest( $item, $patron, undef );
> 
> This is 1 when it should be 0.
> 
> IF I go to admin/smart-rules.pl, edit and save (ie. set default to circ
> rules), the test will pass!

I believe Martin is back at work this week, so hope he can help to shed some
light on this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #90 from Jonathan Druart  ---
If I comment, in t/db_dependent/selenium/opac_holds.t:

reset_data() that is after
  detail_page_hold_button_absent('Authenticated - onshelfholds If all
unavailable');

Then cleanup_data();, I can see the problem on the UI

It seems that opac/opac-detail.pl
 701 $can_holds_be_placed =
 702 $can_holds_be_placed || $patron &&
IsAvailableForItemLevelRequest( $item, $patron, undef );

This is 1 when it should be 0.

IF I go to admin/smart-rules.pl, edit and save (ie. set default to circ rules),
the test will pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-09-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com
   Keywords||additional_work_needed

--- Comment #89 from Jonathan Druart  ---
It took me a long time to notice that this patchset was the culprit!

https://jenkins.koha-community.org/job/Koha_Main/3019/consoleFull

t/db_dependent/selenium/opac_holds.t is failing with
17:36:02 koha_1   | #   Failed test 'Detail page - Place hold
button should be absent. Authenticated - onshelfholds If all unavailable'
17:36:02 koha_1   | #   at t/db_dependent/selenium/opac_holds.t
line 402.
17:36:02 koha_1   | #  got: 'Place hold'
17:36:02 koha_1   | # expected: 'Print'
17:36:02 koha_1   | # Looks like you failed 1 test of 7.
17:36:02 koha_1   | 
17:36:02 koha_1   | #   Failed test 'detail page'
17:36:02 koha_1   | #   at t/db_dependent/selenium/opac_holds.t line
308.
17:36:02 koha_1   | # Looks like you failed 1 test of 5.
17:36:02 koha_1   | 
17:36:02 koha_1   | #   Failed test 'authenticated'
17:36:02 koha_1   | #   at t/db_dependent/selenium/opac_holds.t line 310.

Then lot of other tests, but I think we should focus on the first failure.

You can recreate using:

root@kohadevbox:koha$ perl ../misc4dev/run_tests.pl --run-all-tests

Easier if you replace this line:
-@prove_files = map { chomp ; $_ } qx{ ( find t/db_dependent/selenium -name
'*.t' -not -name '00-onboarding.t' | sort ) ; ( find t xt -name '*.t' -not
-path "t/db_dependent/selenium/*" | shuf ) };

+@prove_files = qw( t/db_dependent/selenium/01-installation.t
t/db_dependent/selenium/opac_holds.t );

I have no idea what's going on, neither why it fails, but it fails :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #88 from Katrin Fischer  ---
Pushed for 24.11!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||24.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #87 from Katrin Fischer  ---
Notes from RM testing :)

1) Terminology

The code uses trail and lead, the GUI uses preparation and precaution, the bug
description uses warm-up and cool-down periods. I have to admit all were new to
me :) Can we standardize a little at least between GUI and bug? 

2) Item type or Itemtype?

The label on the bookings form used Itemtype, but then we also have:

+placeholder: __("Item type"),

We actually don't have that resolved in the terminology list either. Asking on
Mattermost, something more to standardize!

2) GUI

I have been wondering if adding "days" behind the input fields might help
usability a bit or not.

3) Release notes please!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #86 from Katrin Fischer  ---
Something went wrong here when attaching the patches. I will try to fix, but
please double check.

Please don't forget to obsolete patches manually where you updated the commit
message.


Bug 34440 - Add warm-up and cool-down periods to bookings

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 34440: Add lead and trail time to circulation rules
Applying: Bug 34440: Add lead and trail time to circulation rulesa
Using index info to reconstruct a base tree...
M   Koha/CirculationRules.pm
M   admin/smart-rules.pl
M   installer/onboarding.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
**No changes -- Patch already applied.
Applying: Bug 34440: Take preparation period into account at checkout
Applying: Bug 34440: Add itemtype selection to bookings modal
Applying: Bug 34440: Add handling for lead/trail display
Applying: Bug 34440: Add isSameOrBefore dayjs plugin
Applying: Bug 34440: Simplify modal code using isSameOr* functions
Applying: Bug 34440: Use circulation_rules for buffer timing
Applying: Bug 34440: Update for change to /circulation_rules
Applying: Bug 34440: (follow-up) Enable flatpickr only once rules are populated
Applying: Bug 34440: Highlight overlaping lead and trail periods
Applying: Bug 34440: Enforce lead/trail restrictions
Applying: Bug 34440: Unit test for change to Koha::Item
Applying: Bug 34440: (QA follow-up) Tidy changes to t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #170589|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |paul.dersch...@lmscloud.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #85 from Paul Derscheid  ---
Created attachment 170610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170610&action=edit
Bug 34440: (QA follow-up) Tidy changes to t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170600|0   |1
is obsolete||

--- Comment #84 from Paul Derscheid  ---
Created attachment 170603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170603&action=edit
Bug 34440: Unit test for change to Koha::Item

This adds a unit test for the new preparation_period handling introduced
into the find_booking method of Koha::Item.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

Circulation||bookings
   function||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #83 from Martin Renvoize  ---
Created attachment 170600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170600&action=edit
Bug 34440: Unit test for change to Koha::Item

This adds a unit test for the new preparation_period handling introduced
into the find_booking method of Koha::Item.

Sponsored-by: Cuyahoga County Public Library 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170056|0   |1
is obsolete||

--- Comment #82 from Martin Renvoize  ---
Created attachment 170599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170599&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170055|0   |1
is obsolete||

--- Comment #81 from Martin Renvoize  ---
Created attachment 170598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170598&action=edit
Bug 34440: Highlight overlaping lead and trail periods

This adds a further distinction between a lead/trail period and whether
it would conflict with an existing booking or not.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170054|0   |1
is obsolete||

--- Comment #80 from Martin Renvoize  ---
Created attachment 170597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170597&action=edit
Bug 34440: (follow-up) Enable flatpickr only once rules are populated

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170053|0   |1
is obsolete||

--- Comment #79 from Martin Renvoize  ---
Created attachment 170596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170596&action=edit
Bug 34440: Update for change to /circulation_rules

We updated the preceeding bug that introducing the /circulation_rules
endpoint such that it always returns an array.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Martin Renvoize 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170052|0   |1
is obsolete||

--- Comment #78 from Martin Renvoize  ---
Created attachment 170595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170595&action=edit
Bug 34440: Use circulation_rules for buffer timing

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170051|0   |1
is obsolete||

--- Comment #77 from Martin Renvoize  ---
Created attachment 170594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170594&action=edit
Bug 34440: Simplify modal code using isSameOr* functions

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170050|0   |1
is obsolete||

--- Comment #76 from Martin Renvoize  ---
Created attachment 170593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170593&action=edit
Bug 34440: Add isSameOrBefore dayjs plugin

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170049|0   |1
is obsolete||

--- Comment #75 from Martin Renvoize  ---
Created attachment 170592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170592&action=edit
Bug 34440: Add handling for lead/trail display

This patch adds code to insert classes into the flatpickr for lead and
trail time on bookings and includes some scss additions to highlight
said periods in display.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170048|0   |1
is obsolete||

--- Comment #74 from Martin Renvoize  ---
Created attachment 170591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170591&action=edit
Bug 34440: Add itemtype selection to bookings modal

Whilst we still don't need to know the specific item we will need to
know the itemtype to be able to fetch the correct circulation rules for
adjusting the datepicker with lead and trail times.

This patch adds such a picker option. You should be able to select the
item or itemtype in either order.. selecting itemtype first will limit
the items list to options available (and 'Any item').. upon selecting a
specific item the itemtype selector should become disabled and reflect
the itemtype of the item selected.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #170047|0   |1
is obsolete||

--- Comment #73 from Martin Renvoize  ---
Created attachment 170590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170590&action=edit
Bug 34440: Take preparation period into account at checkout

This patch ensures we catch checkouts that would interfer with the
preparation period set for an existing booking by adding said period to
the bookings search.

We also reduce the proposed due date for the checkout to be confirmed by
the preparation period for the item.

Test plan
1) Set a booking preparation period for an itemtype
2) Add a booking for an item with that itemtype to fall beyond the due
   date that the item would be assigned if you were to check it out now
   to your test user, but within the number of days you've set for your
   preparation period.
3) Attempt to check the item out to your test user.
4) Note that we catch the booking and warn and that the latest return
   date suggested take the preparation period into account.

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #72 from Martin Renvoize  ---
Created attachment 170589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170589&action=edit
Bug 34440: Add lead and trail time to circulation rulesa

Sponsored-by: Cuyahoga County Public Library 
Signed-off-by: Kristi Krueger 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-22 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37707


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707
[Bug 37707] Lead/Trail times should work in combination
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #71 from Martin Renvoize  ---
(In reply to Martin Renvoize from comment #45)
> Thanks for the feedback Kristi.
> 
> I've now added the code to block bookings that would infringe the lead/trail
> period.
> 
> Currently, it only takes into account the additional periods for the item
> you are booking and not the surrounding bookings, however.. I think I may
> need to update it to take more into account.
> 
> i.e it currently acts like:
> 
> booking 1 --||-- lead | booking 2 | trail -- ||-- booking 3
> 
> Should it be the following in your opinion:
> 
> booking 1 --| trail --||-- lead | booking 2 | trail -- ||-- lead | booking 3

I discussed this with Kristi and she agree's that it should be the combination
of periods as proposed in the example above.


A- | TA >|< LB | -B- | TB >|< LC | -C

I'll look at adding a following to deal with that ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 CC||paul.dersch...@lmscloud.de
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170042|0   |1
is obsolete||

--- Comment #70 from Paul Derscheid  ---
Created attachment 170056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170056&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170041|0   |1
is obsolete||

--- Comment #69 from Paul Derscheid  ---
Created attachment 170055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170055&action=edit
Bug 34440: Highlight overlaping lead and trail periods

This adds a further distinction between a lead/trail period and whether
it would conflict with an existing booking or not.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170040|0   |1
is obsolete||

--- Comment #68 from Paul Derscheid  ---
Created attachment 170054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170054&action=edit
Bug 34440: (follow-up) Enable flatpickr only once rules are populated

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170039|0   |1
is obsolete||

--- Comment #67 from Paul Derscheid  ---
Created attachment 170053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170053&action=edit
Bug 34440: Update for change to /circulation_rules

We updated the preceeding bug that introducing the /circulation_rules
endpoint such that it always returns an array.

Signed-off-by: Martin Renvoize 
Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170038|0   |1
is obsolete||

--- Comment #66 from Paul Derscheid  ---
Created attachment 170052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170052&action=edit
Bug 34440: Use circulation_rules for buffer timing

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170037|0   |1
is obsolete||

--- Comment #65 from Paul Derscheid  ---
Created attachment 170051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170051&action=edit
Bug 34440: Simplify modal code using isSameOr* functions

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170036|0   |1
is obsolete||

--- Comment #64 from Paul Derscheid  ---
Created attachment 170050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170050&action=edit
Bug 34440: Add isSameOrBefore dayjs plugin

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170035|0   |1
is obsolete||

--- Comment #63 from Paul Derscheid  ---
Created attachment 170049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170049&action=edit
Bug 34440: Add handling for lead/trail display

This patch adds code to insert classes into the flatpickr for lead and
trail time on bookings and includes some scss additions to highlight
said periods in display.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170034|0   |1
is obsolete||

--- Comment #62 from Paul Derscheid  ---
Created attachment 170048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170048&action=edit
Bug 34440: Add itemtype selection to bookings modal

Whilst we still don't need to know the specific item we will need to
know the itemtype to be able to fetch the correct circulation rules for
adjusting the datepicker with lead and trail times.

This patch adds such a picker option. You should be able to select the
item or itemtype in either order.. selecting itemtype first will limit
the items list to options available (and 'Any item').. upon selecting a
specific item the itemtype selector should become disabled and reflect
the itemtype of the item selected.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170033|0   |1
is obsolete||

--- Comment #61 from Paul Derscheid  ---
Created attachment 170047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170047&action=edit
Bug 34440: Take preparation period into account at checkout

This patch ensures we catch checkouts that would interfer with the
preparation period set for an existing booking by adding said period to
the bookings search.

We also reduce the proposed due date for the checkout to be confirmed by
the preparation period for the item.

Test plan
1) Set a booking preparation period for an itemtype
2) Add a booking for an item with that itemtype to fall beyond the due
   date that the item would be assigned if you were to check it out now
   to your test user, but within the number of days you've set for your
   preparation period.
3) Attempt to check the item out to your test user.
4) Note that we catch the booking and warn and that the latest return
   date suggested take the preparation period into account.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Paul Derscheid  changed:

   What|Removed |Added

 Attachment #170032|0   |1
is obsolete||

--- Comment #60 from Paul Derscheid  ---
Created attachment 170046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170046&action=edit
Bug 34440: Add lead and trail time to circulation rules

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169588|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 170042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170042&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169580|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize  ---
Created attachment 170041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170041&action=edit
Bug 34440: Highlight overlaping lead and trail periods

This adds a further distinction between a lead/trail period and whether
it would conflict with an existing booking or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169579|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize  ---
Created attachment 170040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170040&action=edit
Bug 34440: (follow-up) Enable flatpickr only once rules are populated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169578|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize  ---
Created attachment 170039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170039&action=edit
Bug 34440: Update for change to /circulation_rules

We updated the preceeding bug that introducing the /circulation_rules
endpoint such that it always returns an array.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169577|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize  ---
Created attachment 170038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170038&action=edit
Bug 34440: Use circulation_rules for buffer timing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169576|0   |1
is obsolete||

--- Comment #54 from Martin Renvoize  ---
Created attachment 170037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170037&action=edit
Bug 34440: Simplify modal code using isSameOr* functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169575|0   |1
is obsolete||

--- Comment #53 from Martin Renvoize  ---
Created attachment 170036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170036&action=edit
Bug 34440: Add isSameOrBefore dayjs plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169574|0   |1
is obsolete||

--- Comment #52 from Martin Renvoize  ---
Created attachment 170035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170035&action=edit
Bug 34440: Add handling for lead/trail display

This patch adds code to insert classes into the flatpickr for lead and
trail time on bookings and includes some scss additions to highlight
said periods in display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169573|0   |1
is obsolete||

--- Comment #51 from Martin Renvoize  ---
Created attachment 170034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170034&action=edit
Bug 34440: Add itemtype selection to bookings modal

Whilst we still don't need to know the specific item we will need to
know the itemtype to be able to fetch the correct circulation rules for
adjusting the datepicker with lead and trail times.

This patch adds such a picker option. You should be able to select the
item or itemtype in either order.. selecting itemtype first will limit
the items list to options available (and 'Any item').. upon selecting a
specific item the itemtype selector should become disabled and reflect
the itemtype of the item selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169572|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 170033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170033&action=edit
Bug 34440: Take preparation period into account at checkout

This patch ensures we catch checkouts that would interfer with the
preparation period set for an existing booking by adding said period to
the bookings search.

We also reduce the proposed due date for the checkout to be confirmed by
the preparation period for the item.

Test plan
1) Set a booking preparation period for an itemtype
2) Add a booking for an item with that itemtype to fall beyond the due
   date that the item would be assigned if you were to check it out now
   to your test user, but within the number of days you've set for your
   preparation period.
3) Attempt to check the item out to your test user.
4) Note that we catch the booking and warn and that the latest return
   date suggested take the preparation period into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-08-02 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169571|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 170032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170032&action=edit
Bug 34440: Add lead and trail time to circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|36383   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36383
[Bug 36383] Add option to set open booking days
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169587|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize  ---
Created attachment 169588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169588&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169581|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 169587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169587&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #46 from Martin Renvoize  ---
(In reply to Kristi from comment #33)
> Could I ask for more parameters on step 2 of the test plan? 
> 
> Add a booking for an item with that itemtype to fall beyond the due date
> that the item would be assigned if you were to check it out now to your test
> user, but within the number of days you've set for your preparation period.
> 
> Am I correct in thinking that could be: 
> I set an item type with 2 days of prep time on either end.
> I set up a booking where the prep time starts Monday, 7/22, the actual
> booking begins Wednesday, 7/24, and ends Monday, 7/29. The prep time at the
> end goes until Wednesday, 7/31.  
> 
> Try to check out the item with the booking to a patron on 7/22, and see if
> the warning describes pops up?

I'd be more than happy to have a call.. this is all rather involved so maybe a
little video chat would help?  It sounds like you've understood it correctly
though.

I envisage 'prep time = lead time' and it's about what you may need to do to
prepare the item for the next user and 'trail time' to be a buffer for 'late
returns' in the way I've written it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #45 from Martin Renvoize  ---
Thanks for the feedback Kristi.

I've now added the code to block bookings that would infringe the lead/trail
period.

Currently, it only takes into account the additional periods for the item you
are booking and not the surrounding bookings, however.. I think I may need to
update it to take more into account.

i.e it currently acts like:

booking 1 --||-- lead | booking 2 | trail -- ||-- booking 3

Should it be the following in your opinion:

booking 1 --| trail --||-- lead | booking 2 | trail -- ||-- lead | booking 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37477


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37477
[Bug 37477] Add option to override warm-up/cool-down periods on bookings at
booking time
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #44 from Martin Renvoize  ---
Created attachment 169581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169581&action=edit
Bug 34440: Enforce lead/trail restrictions

This patch adds rule enforcement into the user interface. When
attempting to make a booking now, instead of just visually displaying
the lead and trail period and highlighting when an overlap appears, we
now block the ability to select a date when such an overlap case is
found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169007|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 169580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169580&action=edit
Bug 34440: Highlight overlaping lead and trail periods

This adds a further distinction between a lead/trail period and whether
it would conflict with an existing booking or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169006|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 169579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169579&action=edit
Bug 34440: (follow-up) Enable flatpickr only once rules are populated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169005|0   |1
is obsolete||

--- Comment #41 from Martin Renvoize  ---
Created attachment 169578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169578&action=edit
Bug 34440: Update for change to /circulation_rules

We updated the preceeding bug that introducing the /circulation_rules
endpoint such that it always returns an array.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169004|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 169577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169577&action=edit
Bug 34440: Use circulation_rules for buffer timing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169003|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 169576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169576&action=edit
Bug 34440: Simplify modal code using isSameOr* functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169002|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 169575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169575&action=edit
Bug 34440: Add isSameOrBefore dayjs plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169001|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 169574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169574&action=edit
Bug 34440: Add handling for lead/trail display

This patch adds code to insert classes into the flatpickr for lead and
trail time on bookings and includes some scss additions to highlight
said periods in display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #169000|0   |1
is obsolete||

--- Comment #36 from Martin Renvoize  ---
Created attachment 169573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169573&action=edit
Bug 34440: Add itemtype selection to bookings modal

Whilst we still don't need to know the specific item we will need to
know the itemtype to be able to fetch the correct circulation rules for
adjusting the datepicker with lead and trail times.

This patch adds such a picker option. You should be able to select the
item or itemtype in either order.. selecting itemtype first will limit
the items list to options available (and 'Any item').. upon selecting a
specific item the itemtype selector should become disabled and reflect
the itemtype of the item selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168999|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 169572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169572&action=edit
Bug 34440: Take preparation period into account at checkout

This patch ensures we catch checkouts that would interfer with the
preparation period set for an existing booking by adding said period to
the bookings search.

We also reduce the proposed due date for the checkout to be confirmed by
the preparation period for the item.

Test plan
1) Set a booking preparation period for an itemtype
2) Add a booking for an item with that itemtype to fall beyond the due
   date that the item would be assigned if you were to check it out now
   to your test user, but within the number of days you've set for your
   preparation period.
3) Attempt to check the item out to your test user.
4) Note that we catch the booking and warn and that the latest return
   date suggested take the preparation period into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168998|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 169571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169571&action=edit
Bug 34440: Add lead and trail time to circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37363


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363
[Bug 37363] Booking dates should respect closed days
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #33 from Kristi  ---
Could I ask for more parameters on step 2 of the test plan? 

Add a booking for an item with that itemtype to fall beyond the due date that
the item would be assigned if you were to check it out now to your test user,
but within the number of days you've set for your preparation period.

Am I correct in thinking that could be: 
I set an item type with 2 days of prep time on either end.
I set up a booking where the prep time starts Monday, 7/22, the actual booking
begins Wednesday, 7/24, and ends Monday, 7/29. The prep time at the end goes
until Wednesday, 7/31.  

Try to check out the item with the booking to a patron on 7/22, and see if the
warning describes pops up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Kristi  changed:

   What|Removed |Added

 CC||kkrue...@cuyahogalibrary.or
   ||g

--- Comment #32 from Kristi  ---
I am moving through the test plan in a sandbox and will follow up tomorrow
there. 

Re: 
"I need some testing and feedback on this one at this point.

At booking time, this is mostly visual.. i.e. we allow bookings to take place
even though the lead or trail times may be conflicting.  We highlight that an
overlap is taking place by darkening the hinted area's for lead and trail
times.

I considered making this require an override but haven't added that code at
this time.

I've also not prevented these lead/trail overlaps at the server level."

Our use case for prep time/warm up and cool down is that the bookable item may
need to travel from one branch to another for pickup, or it may need to be
cleaned or otherwise re-set before another patron can use it.

The prep time functions to ensure that the patron who booked the item cannot
have it out these days, but no one else can reserve it at this time either. 

We have over 100 staff that may place bookings, so if we do not prevent
bookings conflicting with warm up/cool down days there is a high chance of
confusion/bookings not ready for pickup on the start date.

Hope that helps!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #31 from Martin Renvoize  ---
I need some testing and feedback on this one at this point.

At booking time, this is mostly visual.. i.e. we allow bookings to take place
even though the lead or trail times may be conflicting.  We highlight that an
overlap is taking place by darkening the hinted area's for lead and trail
times.

I considered making this require an override but haven't added that code at
this time.

I've also not prevented these lead/trail overlaps at the server level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168948|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #30 from Martin Renvoize  ---
Created attachment 169007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169007&action=edit
Bug 34440: Highlight overlaping lead and trail periods

This adds a further distinction between a lead/trail period and whether
it would conflict with an existing booking or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

--- Comment #29 from Martin Renvoize  ---
Created attachment 169006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169006&action=edit
Bug 34440: (follow-up) Enable flatpickr only once rules are populated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168949|0   |1
is obsolete||

--- Comment #28 from Martin Renvoize  ---
Created attachment 169005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169005&action=edit
Bug 34440: Update for change to /circulation_rules

We updated the preceeding bug that introducing the /circulation_rules
endpoint such that it always returns an array.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168947|0   |1
is obsolete||

--- Comment #27 from Martin Renvoize  ---
Created attachment 169004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169004&action=edit
Bug 34440: Use circulation_rules for buffer timing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168946|0   |1
is obsolete||

--- Comment #26 from Martin Renvoize  ---
Created attachment 169003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169003&action=edit
Bug 34440: Simplify modal code using isSameOr* functions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168945|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 169002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169002&action=edit
Bug 34440: Add isSameOrBefore dayjs plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168944|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 169001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169001&action=edit
Bug 34440: Add handling for lead/trail display

This patch adds code to insert classes into the flatpickr for lead and
trail time on bookings and includes some scss additions to highlight
said periods in display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168943|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 169000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169000&action=edit
Bug 34440: Add itemtype selection to bookings modal

Whilst we still don't need to know the specific item we will need to
know the itemtype to be able to fetch the correct circulation rules for
adjusting the datepicker with lead and trail times.

This patch adds such a picker option. You should be able to select the
item or itemtype in either order.. selecting itemtype first will limit
the items list to options available (and 'Any item').. upon selecting a
specific item the itemtype selector should become disabled and reflect
the itemtype of the item selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168942|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 168999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168999&action=edit
Bug 34440: Take preparation period into account at checkout

This patch ensures we catch checkouts that would interfer with the
preparation period set for an existing booking by adding said period to
the bookings search.

We also reduce the proposed due date for the checkout to be confirmed by
the preparation period for the item.

Test plan
1) Set a booking preparation period for an itemtype
2) Add a booking for an item with that itemtype to fall beyond the due
   date that the item would be assigned if you were to check it out now
   to your test user, but within the number of days you've set for your
   preparation period.
3) Attempt to check the item out to your test user.
4) Note that we catch the booking and warn and that the latest return
   date suggested take the preparation period into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #168941|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 168998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168998&action=edit
Bug 34440: Add lead and trail time to circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 34440] Add warm-up and cool-down periods to bookings

2024-07-13 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||37354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354
[Bug 37354] Bookings should respect circulation rules for max loan periods
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 137 matches

Mail list logo