[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Clemens Tubach changed: What|Removed |Added CC||clemens.tub...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165451|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 165647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165647=edit Bug 35287: Rebase after follow-up to 35197 Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159643|0 |1 is obsolete|| --- Comment #35 from Pedro Amorim --- Created attachment 165646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165646=edit Bug 35287: perltidy for green QA script Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159642|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 165645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165645=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159641|0 |1 is obsolete|| --- Comment #33 from Pedro Amorim --- Created attachment 165644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165644=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159640|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 165643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165643=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159639|0 |1 is obsolete|| --- Comment #31 from Pedro Amorim --- Created attachment 165642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165642=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159638|0 |1 is obsolete|| --- Comment #30 from Pedro Amorim --- Created attachment 165641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165641=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159637|0 |1 is obsolete|| --- Comment #29 from Pedro Amorim --- Created attachment 165640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165640=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159636|0 |1 is obsolete|| --- Comment #28 from Pedro Amorim --- Created attachment 165639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165639=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159635|0 |1 is obsolete|| --- Comment #27 from Pedro Amorim --- Created attachment 165638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165638=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159634|0 |1 is obsolete|| --- Comment #26 from Pedro Amorim --- Created attachment 165637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165637=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu --- Comment #25 from Michaela Sieber --- (In reply to Pedro Amorim from comment #24) > Created attachment 165451 [details] [review] > Bug 35287: Rebase after follow-up to 35197 Thanks Pedro! We tested the additional fields for licenses and we wanted to sign off but have some problems with ktd and also with public sandboxes. Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #24 from Pedro Amorim --- Created attachment 165451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165451=edit Bug 35287: Rebase after follow-up to 35197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added CC||vic...@tuxayo.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35747 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #23 from Pedro Amorim ---
(In reply to Martin Renvoize from comment #22)
> Comment on attachment 159639 [details] [review]
> Bug 35287: REST API - Add additional fields support to ERM Licenses
>
> Review of attachment 159639 [details] [review]:
> -
>
> ::: Koha/REST/V1/ERM/Licenses.pm
> @@ +183,5 @@
> > $license->user_roles($user_roles);
> > $license->documents($documents);
> >
> > +my @extended_attributes = map { {'id' => $_->{field_id},
> > 'value' => $_->{value}} } @{$extended_attributes};
> > +$license->extended_attributes( \@extended_attributes );
>
> Won't you need to check here that @extended_attributes is indeed populated..
> else you may wipe them away without meaning to?
Good point. It's working like that by design. The scenario of wiping additional
attributes without meaning to should not be possible through the Koha form, as
existing data is always pre-populated on the form when editing.
Having said that, it is still possible with a third-party request to the REST
API but I believe that to be a wider topic. I've opened bug 35747 where I
provide a test plan to discuss it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |pedro.amo...@ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Martin Renvoize changed: What|Removed |Added Blocks||34324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34324 [Bug 34324] Merge OPACProblemReport and CatalogConcern functions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #22 from Martin Renvoize ---
Comment on attachment 159639
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159639
Bug 35287: REST API - Add additional fields support to ERM Licenses
Review of attachment 159639:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=35287=159639)
-
::: Koha/REST/V1/ERM/Licenses.pm
@@ +183,5 @@
> $license->user_roles($user_roles);
> $license->documents($documents);
>
> +my @extended_attributes = map { {'id' => $_->{field_id},
> 'value' => $_->{value}} } @{$extended_attributes};
> +$license->extended_attributes( \@extended_attributes );
Won't you need to check here that @extended_attributes is indeed populated..
else you may wipe them away without meaning to?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Martin Renvoize changed: What|Removed |Added Blocks||32751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Edith Speller changed: What|Removed |Added CC||edith.spel...@ukhsa.gov.uk Status|Needs Signoff |Signed Off --- Comment #21 from Edith Speller --- Great work, thanks very much Pedro! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158734|0 |1 is obsolete|| --- Comment #20 from PTFS Europe Sandboxes --- Created attachment 159643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159643=edit Bug 35287: perltidy for green QA script Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158733|0 |1 is obsolete|| --- Comment #19 from PTFS Europe Sandboxes --- Created attachment 159642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159642=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158732|0 |1 is obsolete|| --- Comment #18 from PTFS Europe Sandboxes --- Created attachment 159641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159641=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158731|0 |1 is obsolete|| --- Comment #17 from PTFS Europe Sandboxes --- Created attachment 159640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159640=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158730|0 |1 is obsolete|| --- Comment #16 from PTFS Europe Sandboxes --- Created attachment 159639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159639=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158729|0 |1 is obsolete|| --- Comment #15 from PTFS Europe Sandboxes --- Created attachment 159638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159638=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158728|0 |1 is obsolete|| --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 159637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159637=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158727|0 |1 is obsolete|| --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 159636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159636=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158726|0 |1 is obsolete|| --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 159635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159635=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #158725|0 |1 is obsolete|| --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 159634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159634=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Martin Renvoize changed: What|Removed |Added Depends on||30645 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #10 from Pedro Amorim --- Created attachment 158734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158734=edit Bug 35287: perltidy for green QA script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #9 from Pedro Amorim --- Created attachment 158733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158733=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #8 from Pedro Amorim --- Created attachment 158732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158732=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #7 from Pedro Amorim --- Created attachment 158731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158731=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #6 from Pedro Amorim --- Created attachment 158730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158730=edit Bug 35287: REST API - Add additional fields support to ERM Licenses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #5 from Pedro Amorim --- Created attachment 158729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158729=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #4 from Pedro Amorim --- Created attachment 158728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158728=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #3 from Pedro Amorim --- Created attachment 158727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158727=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #2 from Pedro Amorim --- Created attachment 158726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158726=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #1 from Pedro Amorim --- Created attachment 158725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158725=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
