[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jonathan Druart changed: What|Removed |Added Blocks||39346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39346 [Bug 39346] Only 20 additional fields can be added to an agreement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Bug 35287 depends on bug 37389, which changed state. Bug 37389 Summary: REST API queries joining on extended_attributes may cause severe performance issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37389 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Bug 35287 depends on bug 30645, which changed state. Bug 30645 Summary: Generated DBIC query incorrect for API searches across joined extended attributes when several terms are passed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to main |Needs documenting CC||lu...@bywatersolutions.com --- Comment #97 from Lucas Gass (lukeg) --- New feature, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Michaela Sieber changed: What|Removed |Added Blocks||38446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38446 [Bug 38446] Permission error for additional fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #96 from Katrin Fischer --- (In reply to Pedro Amorim from comment #95) > I've removed the additional_work_needed keyword here as I believe it > referred to the cypress fix submitted on 2024-10-24 and has already been > pushed. Correct, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Keywords|additional_work_needed, | |release-notes-needed| Text to go in the||This enhancement adds release notes||"Additional fields" support ||to ERM licenses. --- Comment #95 from Pedro Amorim --- I've removed the additional_work_needed keyword here as I believe it referred to the cypress fix submitted on 2024-10-24 and has already been pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Blocks||38272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38272 [Bug 38272] Add permission check for erm permission to additional-fields.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #94 from Pedro Amorim --- Created attachment 173290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173290&action=edit Bug 35287: Fix tests Have a single point go get_license to be used by both Licenses_spec.ts and AdditionalFields_spec.ts Test plan, apply patch: $ yarn js:build $ cypress run --spec t/cypress/integration/AdditionalFields_spec.ts $ cypress run --spec t/cypress/integration/Licenses_spec.ts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Matt Blenkinsop changed: What|Removed |Added Blocks||38262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 [Bug 38262] Add additional fields to Vendors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed Summary|Add additional fields |Add additional fields |support to ERM Licenses |support to ERM licenses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed --- Comment #92 from Katrin Fischer --- Unfortunately this broke the existing cypress tests for licenses. Please fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Matt Blenkinsop changed: What|Removed |Added Blocks|38010 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #93 from Jonathan Druart --- (In reply to Katrin Fischer from comment #92) > Unfortunately this broke the existing cypress tests for licenses. > Please fix in a follow-up. The error is 15:26:19 koha_1 | > Cannot read properties of undefined (reading 'additional_field_values') On Koha_Main/3069 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #91 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #90 from Victor Grousset/tuxayo --- Thanks, that was it :D Documented here (assuming there isn't a better place) for anyone needing to find the info again in the future. https://wiki.koha-community.org/wiki/Rest_Api_HowTo#Testing_API_patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Matt Blenkinsop changed: What|Removed |Added Blocks||38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #89 from Pedro Amorim --- (In reply to Victor Grousset/tuxayo from comment #88) > What was missing? Something with that redocly thing? You were possibly missing: $ yarn api:bundle The above is part of "reset_all" and that is usually what I go for instead of "restart_all". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172860|0 |1 is obsolete|| --- Comment #85 from Victor Grousset/tuxayo --- Created attachment 173111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173111&action=edit Bug 35287: Follow-up 37389: ExtendedAttributes Apply ExtendedAttributes Mixin to AdditionalFields To test the ExtendedAttributes mixin search is working: 1) Create 2 or more searchable licenses additional fields 2) Create a new license and enter values in these searchable fields 3) Go to the licenses list, use the column filters to search on more than one column, verify that the search work as intended (AND operator) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172856|0 |1 is obsolete|| --- Comment #82 from Victor Grousset/tuxayo --- Created attachment 173108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173108&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #88 from Victor Grousset/tuxayo --- Thanks again Pedro :) Here is another signoff about not seeing any issue following the test plan. Plus not seeing any issue either relating to the coding guidelines. 👍 And well done, the UI was nice to use :) API testing question: After applying the patches what should be done besides this: rspack build restart_all I had 400 errors on /api/v1/extended_attribute_types?resource_type=license Until doing reset_all. What was missing? Something with that redocly thing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #173022|0 |1 is obsolete|| --- Comment #87 from Victor Grousset/tuxayo --- Created attachment 173113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173113&action=edit Bug 35287: (QA follow-up): Add v-bind:key Remove more unused imports Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172861|0 |1 is obsolete|| --- Comment #86 from Victor Grousset/tuxayo --- Created attachment 173112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173112&action=edit Bug 35287: (QA follow-up): Squash Remove leftover unused code Add missing pod Tidy Removed redundant commented in AdditionalFields_spec.ts Run: qa -c 11 -v 2 Verify everything is green Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172857|0 |1 is obsolete|| --- Comment #83 from Victor Grousset/tuxayo --- Created attachment 173109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173109&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172858|0 |1 is obsolete|| --- Comment #84 from Victor Grousset/tuxayo --- Created attachment 173110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173110&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172855|0 |1 is obsolete|| --- Comment #81 from Victor Grousset/tuxayo --- Created attachment 173107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173107&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172852|0 |1 is obsolete|| --- Comment #78 from Victor Grousset/tuxayo --- Created attachment 173104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173104&action=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172854|0 |1 is obsolete|| --- Comment #80 from Victor Grousset/tuxayo --- Created attachment 173106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173106&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172853|0 |1 is obsolete|| --- Comment #79 from Victor Grousset/tuxayo --- Created attachment 173105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173105&action=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172850|0 |1 is obsolete|| --- Comment #76 from Victor Grousset/tuxayo --- Created attachment 173102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173102&action=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172851|0 |1 is obsolete|| --- Comment #77 from Victor Grousset/tuxayo --- Created attachment 173103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173103&action=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #75 from Pedro Amorim --- Thank you Paul and thank you Victor. @Victor I've submitted an additional patch that should address the v-bind:key warning. I suppose for the 'require' warning in AdditionalFields_spec.ts we could instead use: import * as dayjs from 'dayjs'; But probably a conversation for a different bug as other spec.ts files would have to be updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #74 from Pedro Amorim --- Created attachment 173022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173022&action=edit Bug 35287: (QA follow-up): Add v-bind:key Remove more unused imports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #73 from Victor Grousset/tuxayo --- Thanks Paul for the rest of the QA :D From my code review in august, everything looked compliant with the coding guidelines ☑️ Except for JS8 (ESLint compliance) for which the tooling isn't working to effectively look at it. ¯\_ (ツ)_/¯ - Still, reliably catching stuff like unused variables, unreachable code and other things hard to manually look for would be nice. After fighting tooth and nail with node packaging and ESLint config, I got something running to experiment here and help with the almost 1000 lines of .vue .ts. And the result is that the changes look pretty good 👍 Config needs for tuning to our practices so there is a lot of noise that I'm filtering plus now I don't bother with minor stuff like using const on every not reassigned variable and order of attributes in Vue markup. Here are some quick suspicious things that remain: t/cypress/integration/AdditionalFields_spec.ts 2:15 error A `require()` style import is forbidden @typescript-eslint/no-require-imports Is that really bad? (For this ticket at least. Knowing if this rule should be disabled is for another day ^^, unless it's obvious if it's relevant for the future or not) koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue 16:21 errorElements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 50:21 errorElements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 65:29 warning Attribute "v-model" should go before ":multiple" vue/attributes-order 83:21 errorElements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 83:21 errorElements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key Is that really bad? - I think that's all, so good news :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact||paul.dersch...@lmscloud.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.dersch...@lmscloud.de --- Comment #72 from Paul Derscheid --- Awesome work Pedro. I just rushed through the test plan and almost set this to FQA, but all of it is working nicely and the additional fields mixin is 🔥 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #170753|0 |1 is obsolete|| --- Comment #71 from Paul Derscheid --- Created attachment 172861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172861&action=edit Bug 35287: (QA follow-up): Squash Remove leftover unused code Add missing pod Tidy Removed redundant commented in AdditionalFields_spec.ts Run: qa -c 11 -v 2 Verify everything is green Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169737|0 |1 is obsolete|| --- Comment #70 from Paul Derscheid --- Created attachment 172860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172860&action=edit Bug 35287: Follow-up 37389: ExtendedAttributes Apply ExtendedAttributes Mixin to AdditionalFields To test the ExtendedAttributes mixin search is working: 1) Create 2 or more searchable licenses additional fields 2) Create a new license and enter values in these searchable fields 3) Go to the licenses list, use the column filters to search on more than one column, verify that the search work as intended (AND operator) Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169736|0 |1 is obsolete|| --- Comment #69 from Paul Derscheid --- Created attachment 172858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172858&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169735|0 |1 is obsolete|| --- Comment #68 from Paul Derscheid --- Created attachment 172857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172857&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169734|0 |1 is obsolete|| --- Comment #67 from Paul Derscheid --- Created attachment 172856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172856&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169733|0 |1 is obsolete|| --- Comment #66 from Paul Derscheid --- Created attachment 172855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172855&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169732|0 |1 is obsolete|| --- Comment #65 from Paul Derscheid --- Created attachment 172854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172854&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169731|0 |1 is obsolete|| --- Comment #64 from Paul Derscheid --- Created attachment 172853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172853&action=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169730|0 |1 is obsolete|| --- Comment #63 from Paul Derscheid --- Created attachment 172852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172852&action=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169729|0 |1 is obsolete|| --- Comment #62 from Paul Derscheid --- Created attachment 172851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172851&action=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Paul Derscheid changed: What|Removed |Added Attachment #169728|0 |1 is obsolete|| --- Comment #61 from Paul Derscheid --- Created attachment 172850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172850&action=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Jake Deery changed: What|Removed |Added Blocks||37576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37576 [Bug 37576] Add additional fields support to ERM Agreements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #60 from Victor Grousset/tuxayo --- Thanks Jonathan for the info, I updated the coding guidelines to list the places that are checked without needing the flag. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS14%3A_Prettier_JavaScript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #59 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #58) > (In reply to Pedro Amorim from comment #57) > > (In reply to Victor Grousset/tuxayo from comment #55) > > > This new file needs a /* keep tidy */ comment on top: > > > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js > > > > > > It's also a good opportunity to add a /* keep tidy */ comment on top of > > > this > > > file: > > > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js > > > To avoid having to manually check it with prettier. > > > > No api.js files under js/vue/fetch have this. > > JS14 guideline is more recent (march) than these. So it's case of dealing > with legacy JS/TS/vue files. «Older JS files should also strive to become > tidier and eventually all end up with the keep tidy header line too.» > It's just that in the meantime they haven't been touched or this guideline > was forgotten. > > > If this is reason to FQA it > > should at least be flagged by the QA script first then. > > The point of /* keep tidy */ is to opt in the QA script enforcement of JS14. > That's how to deal with the old files that are totally not compliant. (so > not checked by default) > So until they are pretty and /* keep tidy */ is added, they will never show > up in the QA script. At least not for this check. Not sure to follow the discussion, just want to confirm that .js files under koha-tmpl/intranet-tmpl/prog/js/vue do not need the 'keep tidy' flag, but are checked by both the QA script and unit test (xt/vue_tidy.t) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #58 from Victor Grousset/tuxayo ---
(In reply to Pedro Amorim from comment #57)
> I've squashed the removal of commented cy.wait("@avcategories"); to the
> squash qa follow-up patch.
> I've also added sponsored-by lines.
Thanks :)
> (In reply to Victor Grousset/tuxayo from comment #55)
> > This new file needs a /* keep tidy */ comment on top:
> > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
> >
> > It's also a good opportunity to add a /* keep tidy */ comment on top of this
> > file:
> > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
> > To avoid having to manually check it with prettier.
>
> No api.js files under js/vue/fetch have this.
JS14 guideline is more recent (march) than these. So it's case of dealing with
legacy JS/TS/vue files. «Older JS files should also strive to become tidier and
eventually all end up with the keep tidy header line too.»
It's just that in the meantime they haven't been touched or this guideline was
forgotten.
> If this is reason to FQA it
> should at least be flagged by the QA script first then.
The point of /* keep tidy */ is to opt in the QA script enforcement of JS14.
That's how to deal with the old files that are totally not compliant. (so not
checked by default)
So until they are pretty and /* keep tidy */ is added, they will never show up
in the QA script. At least not for this check.
> > there are two
> > cy.get("#licenses_list table tbody tr:first td:first a").click();
> >
> > IMHO either they should get a comment to easily know what's clicked when in
> > the future there will be some change to the structure of the table and the
> > test will break.
> > Or to prevent breakage and documenting at the same time, an id or a class
> > could be added to what's being clicked (or it's parent) so the selector
> > speaks for itself and would be much less likely to break with future
> > changes.
>
> This is an established pattern utilized in all cypress spec files to click
> on the first element of a table (to navigate to it).
Oops, sorry, the current selector is actually fine. I guess after reading too
much in a row from these large patches my brain got fried 😵💫
> I'm on board for filing a new bug
> titled "Add id to table rows to be more easily selected by cypress tests"
> but I don't see how this should be in the scope of this patchset.
Even if not a relevant case here, about the general idea:
No need to fill a separate bug. It can totally be part of adding a test. I know
it can feel wrong to even change minimally the markup to accommodate a test.
But I think it's only because tests can still feel like second class citizens.
We can think of it like when extracting a method to be able to unit test it.
There it's okay to do so at the same time as adding tests for changes; make the
code more easily testable.
So it should be ok (when the change is easy to make at least) to make the
markup more testable. Both to get more reliable tests for if the page structure
change. And have more readable tests and the markup itself.
As a fallback, having a comment to not have an undocumented "magic selector"
(cf. magic number)
(again not at all needed for this case, it's fine)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #57 from Pedro Amorim ---
Thank you, Victor.
I've squashed the removal of commented cy.wait("@avcategories"); to the squash
qa follow-up patch.
I've also added sponsored-by lines.
(In reply to Victor Grousset/tuxayo from comment #55)
> This new file needs a /* keep tidy */ comment on top:
> koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
>
> It's also a good opportunity to add a /* keep tidy */ comment on top of this
> file:
> koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
> To avoid having to manually check it with prettier.
No api.js files under js/vue/fetch have this. If this is reason to FQA it
should at least be flagged by the QA script first then.
> there are two
> cy.get("#licenses_list table tbody tr:first td:first a").click();
>
> IMHO either they should get a comment to easily know what's clicked when in
> the future there will be some change to the structure of the table and the
> test will break.
> Or to prevent breakage and documenting at the same time, an id or a class
> could be added to what's being clicked (or it's parent) so the selector
> speaks for itself and would be much less likely to break with future changes.
This is an established pattern utilized in all cypress spec files to click on
the first element of a table (to navigate to it). I can see your point but
table rows don't usually have an id. I'm on board for filing a new bug titled
"Add id to table rows to be more easily selected by cypress tests" but I don't
see how this should be in the scope of this patchset.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #170448|0 |1 is obsolete|| --- Comment #56 from Pedro Amorim --- Created attachment 170753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170753&action=edit Bug 35287: (QA follow-up): Squash Remove leftover unused code Add missing pod Tidy Removed redundant commented in AdditionalFields_spec.ts Run: qa -c 11 -v 2 Verify everything is green Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #55 from Victor Grousset/tuxayo ---
Thanks for the follow-up :D
Any sponsor of this quite long enhancement?
---
QA notes:
prettier ok (JS14) on all vue, js and ts files touched.
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsDisplay.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue
- koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
- t/cypress/integration/AdditionalFields_spec.ts
This new file needs a /* keep tidy */ comment on top:
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/additional-fields-api-client.js
It's also a good opportunity to add a /* keep tidy */ comment on top of this
file:
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
To avoid having to manually check it with prettier.
there are two
cy.get("#licenses_list table tbody tr:first td:first a").click();
IMHO either they should get a comment to easily know what's clicked when in the
future there will be some change to the structure of the table and the test
will break.
Or to prevent breakage and documenting at the same time, an id or a class could
be added to what's being clicked (or it's parent) so the selector speaks for
itself and would be much less likely to break with future changes.
---
found two instances of forgotten
// cy.wait("@avcategories");
---
tip: (not a QA worry to be addressed)
I think it's okay to add a class or id from time to time facilitate selection
to make the tests more concise by avoiding the need for sibling circumvention,
such as .parent().children("input")
And also be able to handle cases without an easily selectable sibling. Like in
the previous case of "#licenses_list table tbody tr:first td:first a"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #54 from Pedro Amorim --- Created attachment 170448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170448&action=edit Bug 35287: (QA follow-up): Squash Remove leftover unused code Add missing pod Tidy Run: qa -c 11 -v 2 Verify everything is green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #53 from Victor Grousset/tuxayo ---
Looks like there is an unused variable:
+sub extended_attributes_config {
+my ($self) = @_;
+
+my $tablename_query = $self->extended_attributes_tablename_query;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #52 from Victor Grousset/tuxayo --- > I had some QA tool failings, but it looks like I hadn't properly applied the > dependencies. There is at least this: WARN Koha/Object/Mixin/AdditionalFields.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 17, now: 19) FAIL Koha/Objects/Mixin/AdditionalFields.pm FAIL pod coverage POD is missing for 'extended_attributes_tablename_query' WARN tidiness The file is less tidy than before (bad/messy lines before: 3, now: 6) WARN Koha/REST/V1/ERM/Licenses.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 46, now: 50) WARN t/db_dependent/Koha/Object/Mixin/AdditionalFields.t WARN tidiness The file is less tidy than before (bad/messy lines before: 20, now: 35) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #51 from David Cook --- I had some QA tool failings, but it looks like I hadn't properly applied the dependencies. I'll try to run again soon, but have some urgent things at the moment to deal with. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #50 from Victor Grousset/tuxayo --- (In reply to Pedro Amorim from comment #48) > I'm keeping the sign-off status as all the functionality is the same, even > though the code has changed quite a bit. Happy either way. Please let me > know. It's a case where retesting is needed. Because signing off isn't about vetting the functional change. (function approval or issues found are welcome) But rather to confirm that there is indeed a functional change, whatever it might be. It's like automated tests but manual, so (non trivial) code changes warrant rerunning them. Thanks Michaela for retesting :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37576 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37577 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #49 from Michaela Sieber --- Thanks Pedro, I've tested once again and everything worked fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #48 from Pedro Amorim --- This is now fully rebased on the pushed version of bug 35197. This is now also adding a light follow-up to bug 37389 to make use of the search performance and consistency improvements made there. I'm keeping the sign-off status as all the functionality is the same, even though the code has changed quite a bit. Happy either way. Please let me know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #47 from Pedro Amorim --- Created attachment 169737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169737&action=edit Bug 35287: Follow-up 37389: ExtendedAttributes Apply ExtendedAttributes Mixin to AdditionalFields To test the ExtendedAttributes mixin search is working: 1) Create 2 or more searchable licenses additional fields 2) Create a new license and enter values in these searchable fields 3) Go to the licenses list, use the column filters to search on more than one column, verify that the search work as intended (AND operator) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #46 from Pedro Amorim --- Created attachment 169736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169736&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #45 from Pedro Amorim --- Created attachment 169735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169735&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #44 from Pedro Amorim --- Created attachment 169734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169734&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #43 from Pedro Amorim --- Created attachment 169733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169733&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #42 from Pedro Amorim --- Created attachment 169732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169732&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #41 from Pedro Amorim --- Created attachment 169731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169731&action=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #40 from Pedro Amorim --- Created attachment 169730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169730&action=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #39 from Pedro Amorim --- Created attachment 169729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169729&action=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #38 from Pedro Amorim --- Created attachment 169728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169728&action=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #167681|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165647|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165646|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165645|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165644|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165643|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165642|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165641|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165640|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165639|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165638|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165637|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Depends on||37389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37389 [Bug 37389] ILL requests table hangs when searching -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 --- Comment #37 from Pedro Amorim --- Created attachment 167681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167681&action=edit Bug 35287: Another follow-up to 35197 fix Leaving this here for review. This is following up the changes submitted to 35197 on 2024-04-29. Squash later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added CC||s.grah...@herts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Clemens Tubach changed: What|Removed |Added CC||clemens.tub...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165451|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 165647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165647&action=edit Bug 35287: Rebase after follow-up to 35197 Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159643|0 |1 is obsolete|| --- Comment #35 from Pedro Amorim --- Created attachment 165646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165646&action=edit Bug 35287: perltidy for green QA script Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159642|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 165645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165645&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159641|0 |1 is obsolete|| --- Comment #33 from Pedro Amorim --- Created attachment 165644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165644&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159640|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 165643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165643&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159639|0 |1 is obsolete|| --- Comment #31 from Pedro Amorim --- Created attachment 165642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165642&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159638|0 |1 is obsolete|| --- Comment #30 from Pedro Amorim --- Created attachment 165641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165641&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
