[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to main  |Needs documenting

--- Comment #81 from Fridolin Somers  ---
Not backported to 23.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds to|This enhancement adds to
  release notes|the ability to assign   |the ability to assign
   |tickets to librarians in|tickets to librarians in
   |the catalog concerns|the catalog concerns
   |feature.|feature.
   ||
   ||**Sponsored by**
   ||*PTFS Europe*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds to
  release notes||the ability to assign
   ||tickets to librarians in
   ||the catalog concerns
   ||feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

  Component|Staff interface |Cataloging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36801


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36801
[Bug 36801] Allow un-resolving of a catalog concern
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_24_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36760


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36760
[Bug 36760] Make '|Current assignee' stand out more in ticket details view
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36759
[Bug 36759] We should add a shortcut for assigning a ticket to yourself
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||36758


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758
[Bug 36758] We should notify an assignee when they are assigned a ticket
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|36756   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36756
[Bug 36756] Fix default action on split update button when editing
tickets/catalog concerns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #80 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36757
[Bug 36757] Add assignee to catalog concern/ticket detail view when opened from
catalog detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36756


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36756
[Bug 36756] Fix default action on split update button when editing
tickets/catalog concerns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36754
[Bug 36754] Limit patron search for assignee on tickets to staff users
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #79 from Martin Renvoize  ---
Created attachment 166067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166067=edit
Bug 35657: (follow-up) Placeholders should be translatable

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-05-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36753
[Bug 36753] When there are no catalog concerns, don't show datatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #78 from Martin Renvoize  ---
I'd be more than happy with experimental and I will refine as bugfixes during
the first month of the next cycle if that works for people?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #77 from Katrin Fischer  ---
I can't do more for today, but I will still review this for 24.05 end of the
week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #76 from Marcel de Rooy  ---
 WARN   t/db_dependent/api/v1/ticket_updates.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 58,
now: 80)

 WARN   t/db_dependent/api/v1/tickets.t
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 65,
now: 70)

Status is updated on cataloguing/concerns.pl, but not on detail page ?
I cannot add an assignee without changing the status ?
I resolved a concern and wanted to revert its status again. Ending up in ticket
status RESO02 but update has ST01 again. See tables below.

I wont block this patch set as part of this tree. But still feel that the
functionality is not clear and the forms are not completely bug free.
Add experimental status?

MariaDB [koha_myclone]> select * from tickets;
++-+-+-++-++-+-+-+---+
| id | source  | reporter_id | reported_date   | title  | body 
  | status | assignee_id | resolver_id | resolved_date   | biblio_id |
++-+-+-++-++-+-+-+---+
| 34 | catalog |  51 | 2024-04-26 06:51:06 | test   | This is my
concern. | ST01   |  30 |  51 | 2024-04-30 13:29:57 | 1
|
| 35 | catalog |  51 | 2024-04-26 06:52:50 | Second | Test 
  | RESO2  |NULL |  51 | 2024-04-26 07:14:14 | 1 |
++-+-+-++-++-+-+-+---+
MariaDB [koha_myclone]> select * from ticket_updates;
++---+-+-++-+--++
| id | ticket_id | user_id | assignee_id | public | date|
message  | status |
++---+-+-++-+--++
| 13 |34 |  51 |NULL |  0 | 2024-04-26 06:53:04 |
Update 1 | NULL   |
| 14 |34 |  51 |NULL |  0 | 2024-04-26 06:54:36 |  
   | ST01   |
| 22 |35 |  51 |NULL |  0 | 2024-04-26 07:14:14 |  
   | RESO2  |
| 32 |34 |  51 |  19 |  0 | 2024-04-30 13:24:34 |  
   | ST01   |
| 33 |34 |  51 |  30 |  0 | 2024-04-30 13:29:27 |  
   | ST01   |
| 34 |34 |  51 |NULL |  0 | 2024-04-30 13:29:57 |  
   | RESO2  |
| 35 |34 |  51 |  30 |  0 | 2024-04-30 13:30:09 |  
   | ST01   |
++---+-+-++-+--++

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165878|0   |1
is obsolete||

--- Comment #75 from Marcel de Rooy  ---
Created attachment 165886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165886=edit
Bug 35657: (follow-up) Add missing DB update

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165792|0   |1
is obsolete||

--- Comment #74 from Marcel de Rooy  ---
Created attachment 165885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165885=edit
Bug 35657: Unit test for addition to tickets endpoint

This patch adds a unit test for the additional option of now setting the
assignee from the tickets update endpoint.

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165791|0   |1
is obsolete||

--- Comment #73 from Marcel de Rooy  ---
Created attachment 165884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165884=edit
Bug 35657: Unit tests for ticket_update api addition

This patch adds unit tests for the addition of assignee handling in the
ticket update endpoint

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165790|0   |1
is obsolete||

--- Comment #72 from Marcel de Rooy  ---
Created attachment 165883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165883=edit
Bug 35657: Unit tests for relation accessor additions

This patch adds the unit tests for the new 'assignee' relation accessors
added to Koha::Ticket and Koha::Ticket::Update classes.

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165789|0   |1
is obsolete||

--- Comment #71 from Marcel de Rooy  ---
Created attachment 165882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165882=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165788|0   |1
is obsolete||

--- Comment #70 from Marcel de Rooy  ---
Created attachment 165881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165881=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165787|0   |1
is obsolete||

--- Comment #69 from Marcel de Rooy  ---
Created attachment 165880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165880=edit
Bug 35657: Schema update

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #165786|0   |1
is obsolete||

--- Comment #68 from Marcel de Rooy  ---
Created attachment 165879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165879=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

Signed-off-by: Paul Derscheid 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #67 from Paul Derscheid  ---
Marcel: just followed the initial test plan (the one marked as important).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #66 from Martin Renvoize  ---
Can't believe I somehow missed attaching the DB update in the first commit!..
It's there now in the follow-up.. we can squash that of course.. just didn't
fancy uploading all the patches again for the rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #65 from Martin Renvoize  ---
Created attachment 165878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165878=edit
Bug 35657: (follow-up) Add missing DB update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #64 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #54)
> Unit tests added.. pretty sure you had just missed running updatedatebase as
> I can't replicate the 500 error.
> 
> :)

Please explain that to me. There is no dbrev in this patch set !
LOL

Paul: How did you test it ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #63 from Marcel de Rooy  ---
Having another look here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #62 from Martin Renvoize  ---
Just another rebase since the prettier stuff got in... would really love to see
this make release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_24_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165679|0   |1
is obsolete||

--- Comment #61 from Martin Renvoize  ---
Created attachment 165792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165792=edit
Bug 35657: Unit test for addition to tickets endpoint

This patch adds a unit test for the additional option of now setting the
assignee from the tickets update endpoint.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165678|0   |1
is obsolete||

--- Comment #60 from Martin Renvoize  ---
Created attachment 165791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165791=edit
Bug 35657: Unit tests for ticket_update api addition

This patch adds unit tests for the addition of assignee handling in the
ticket update endpoint

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165677|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 165790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165790=edit
Bug 35657: Unit tests for relation accessor additions

This patch adds the unit tests for the new 'assignee' relation accessors
added to Koha::Ticket and Koha::Ticket::Update classes.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165676|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize  ---
Created attachment 165789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165789=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165675|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize  ---
Created attachment 165788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165788=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165674|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize  ---
Created attachment 165787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165787=edit
Bug 35657: Schema update

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165673|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize  ---
Created attachment 165786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165786=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #54 from Martin Renvoize  ---
Unit tests added.. pretty sure you had just missed running updatedatebase as I
can't replicate the 500 error.

:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165672|0   |1
is obsolete||

--- Comment #53 from Martin Renvoize  ---
Created attachment 165679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165679=edit
Bug 35657: Unit test for addition to tickets endpoint

This patch adds a unit test for the additional option of now setting the
assignee from the tickets update endpoint.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165671|0   |1
is obsolete||

--- Comment #52 from Martin Renvoize  ---
Created attachment 165678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165678=edit
Bug 35657: Unit tests for ticket_update api addition

This patch adds unit tests for the addition of assignee handling in the
ticket update endpoint

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165670|0   |1
is obsolete||

--- Comment #51 from Martin Renvoize  ---
Created attachment 165677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165677=edit
Bug 35657: Unit tests for relation accessor additions

This patch adds the unit tests for the new 'assignee' relation accessors
added to Koha::Ticket and Koha::Ticket::Update classes.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165669|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 165676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165676=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165668|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 165675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165675=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165667|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize  ---
Created attachment 165674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165674=edit
Bug 35657: Schema update

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #165666|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 165673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165673=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #46 from Martin Renvoize  ---
Created attachment 165672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165672=edit
Bug 35657: Unit test for addition to tickets endpoint

This patch adds a unit test for the additional option of now setting the
assignee from the tickets update endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #45 from Martin Renvoize  ---
Created attachment 165671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165671=edit
Bug 35657: Unit tests for ticket_update api addition

This patch adds unit tests for the addition of assignee handling in the
ticket update endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #44 from Martin Renvoize  ---
Created attachment 165670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165670=edit
Bug 35657: Unit tests for relation accessor additions

This patch adds the unit tests for the new 'assignee' relation accessors
added to Koha::Ticket and Koha::Ticket::Update classes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164977|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 165669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165669=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164976|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 165668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165668=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164975|0   |1
is obsolete||

--- Comment #41 from Martin Renvoize  ---
Created attachment 165667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165667=edit
Bug 35657: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164974|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 165666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165666=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #39 from Martin Renvoize  ---
Definitely needs Unit tests.. I clearly forgot to attach those.. I'll go dig
out the branch and get them submitted.

As for your 500 Error.. I think that's a missing DB update..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #38 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #36)
> [2024/04/26 07:34:03] [ERROR] GET /api/v1/tickets: unhandled exception
> (DBIx::Class::Exception)< Exception: DBD::mysql::st execute failed: Unknown column 'me.assignee_id' in
> 'field list' at /usr/share/koha/Koha/Objects.pm line 399>>

A 500 when loading the staff detail page for a biblio with concerns.
Hmm, this concerns me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Marcel de Rooy  ---
No unit tests here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #36 from Marcel de Rooy  ---
[2024/04/26 07:34:03] [ERROR] GET /api/v1/tickets: unhandled exception
(DBIx::Class::Exception)<>

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||32436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436
[Bug 32436] Add 'quick replies' to catalog concerns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 Attachment #164935|0   |1
is obsolete||

--- Comment #35 from 0xfun  ---
Created attachment 164977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164977=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 Attachment #164934|0   |1
is obsolete||

--- Comment #34 from 0xfun  ---
Created attachment 164976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164976=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 Attachment #164933|0   |1
is obsolete||

--- Comment #33 from 0xfun  ---
Created attachment 164975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164975=edit
Bug 35657: Schema update

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 Attachment #164932|0   |1
is obsolete||

--- Comment #32 from 0xfun  ---
Created attachment 164974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164974=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

Signed-off-by: Paul Derscheid 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #31 from 0xfun  ---
Will do a sign-off tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #30 from Martin Renvoize  ---
The warn in C4::Letters appears to be deliberate.. though it's rather noisy.. I
reckon that should also go on it's own bug some time to clean up the warns..
the details are now reported in the UI anyway so the warns are a bit
superflous.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #29 from Martin Renvoize  ---
OK.. I added it as it's own bug as it's unrelated to this one and should
certainly be backported as a bugfix.  Please see bug 36612

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33612

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|36612   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36612
[Bug 36612] The public tickets endpoint needs public fields list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||36612


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36612
[Bug 36612] The public tickets endpoint needs public fields list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Paul Derscheid  changed:

   What|Removed |Added

 CC||paul.dersch...@lmscloud.de

--- Comment #28 from Paul Derscheid  ---
If you decide to move that bug outside of the scope of this one and make it
dependent on the new one, we could certainly move this one forward, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #27 from Martin Renvoize  ---
Interesting bug you've found there.. thanks.  I'm contemplating whether that's
important enough to warrant fixing on it's own bug of just dealing with it
inline here think I'll cmull it over on the school run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

0xfun  changed:

   What|Removed |Added

 CC||m...@paulderscheid.xyz

--- Comment #26 from 0xfun  ---
Sorry, there's one problem:

When creating a concern from the OPAC w/ an account that doesn't have an email
address associated, we get:
[2024/04/16 14:24:29] [WARN] FAIL: No 'to_address', email address or guarantors
email address for borrowernumber (51) at /kohadevbox/koha/C4/Letters.pm line
1366.

Also there's a stack trace in ktd when you set an email address for the `koha`
user, but I wrote that off as related to ktd.

That's fine and there's also an error message displayed to the user:
> There was an error when submitting your concern, please contact a librarian.

The problem is that that concern still goes through and is visible in the
associated concerns for that biblio.

Of course the feature works but could you still fix that before the sign-off.
Maybe either
- block the concern from going through
- use a more descriptive error message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164928|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164927|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164924|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164926|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 164935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164935=edit
Bug 35657: Add option to set assignee during update

This patch exposes the UI to allow setting assignee from the ticket
update modal.

Test plan
1) Apply the patches and run the database updates
2) Enable catalog concerns - `CatalogConcerns` or `OPACCatalogConcerns`
3) Submit a catalog concern via the OPAC or Staff client biblio page
4) Navigate to the concerns management page 'Cataloging > Catalog
   concerns'
5) Note there is no assignee displayed in the status field for your new
   concern.
6) Click the concern to view it's details
7) Note that in the modal there is now a new 'Change assignee' option
8) Use this new option to search for and assign a librarian to the
   concern.
9) Submit the update
10) Your assignee should now appear in the 'status' data field in the
table
11) Clicking through to details again, you should see when the assignee
was set and should also be able to re-assign it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164925|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 164934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164934=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch adds support for cross-synced ticket.assignee_id updates.

The API allows you to set assignee directly on a ticket or via a
ticket_update. In both cases we store a ticket_update with the fine
details of when and who set the assigee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #23 from Martin Renvoize  ---
Created attachment 164933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164933=edit
Bug 35657: Schema update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164923|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 164932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164932=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #21 from Martin Renvoize  ---
Branch fully rebased so this should be simple enough to test now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160377|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 164928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164928=edit
Bug 35657: Display assignee under updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160376|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 164927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164927=edit
Bug 35657: Display assignee under 'Status' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160375|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 164926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164926=edit
Bug 35657: Add option to set assignee during update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160374|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 164925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164925=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch starts to add support for cross-synced ticket.assignee_id
updates.  You should be able to either set assignee at the time of
adding a ticket_update or directly on the ticket.. but in both cases end
up with a ticket_update with the fine details of when and who set the
assigee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160373|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 164924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164924=edit
Bug 35657: Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160372|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 164923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164923=edit
Bug 35657: Add assignee_id to tickets and ticket_updates

This patch updates the tickets and ticket_updates tables to include a
assignee_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #14 from cgent...@ju.edu ---
I am eagerly hoping this feature is added to Cataloging Concerns! Thanks for
working on this. - Chelsea

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2024-04-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

cgent...@ju.edu changed:

   What|Removed |Added

 CC||cgent...@ju.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2023-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

--- Comment #13 from Martin Renvoize  ---
Created attachment 160377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160377=edit
Bug 35657: Display assignee under updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2023-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160369|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 160376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160376=edit
Bug 35657: Display assignee under 'Status' column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2023-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160368|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 160375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160375=edit
Bug 35657: Add option to set assignee during update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns

2023-12-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160367|0   |1
is obsolete||

--- Comment #10 from Martin Renvoize  ---
Created attachment 160374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160374=edit
Bug 35657: Add support for assignee_id to ticket_updates endpoint

This patch starts to add support for cross-synced ticket.assignee_id
updates.  You should be able to either set assignee at the time of
adding a ticket_update or directly on the ticket.. but in both cases end
up with a ticket_update with the fine details of when and who set the
assigee.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >