[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Bug 35783 depends on bug 35782, which changed state. Bug 35782 Summary: Remove Koha::Template::Plugin::Biblio::HoldsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose --- Architecture change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to main |Needs documenting --- Comment #10 from Fridolin Somers --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 --- Comment #9 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 --- Comment #8 from Jonathan Druart --- (In reply to Kyle M Hall from comment #7) > We should probably have a follow-up bug to remove the subroutine in 24.11 Yes! Done. Bug 35791. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 --- Comment #7 from Kyle M Hall --- We should probably have a follow-up bug to remove the subroutine in 24.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Kyle M Hall changed: What|Removed |Added Attachment #160934|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 160963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160963&action=edit Bug 35783: Replace TT plugin's method Biblio::RecallsCount We can use biblio.recalls.search( completed => 0 ).count instead. Test plan: 1. Go to the biblio detail view, click on the different entries in the menu on the left. Confirm that the "Recalls" tab always has the correct number of current recalls display in the parenthesis. 2. Run a search and confirm that the number of current recalls are still displayed for each result. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 David Nind changed: What|Removed |Added Attachment #160931|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 160934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160934&action=edit Bug 35783: Replace TT plugin's method Biblio::RecallsCount We can use biblio.recalls.search( completed => 0 ).count instead. Test plan: 1. Go to the biblio detail view, click on the different entries in the menu on the left. Confirm that the "Recalls" tab always has the correct number of current recalls display in the parenthesis. 2. Run a search and confirm that the number of current recalls are still displayed for each result. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 --- Comment #4 from Jonathan Druart --- Oops sorry, inverted one flag. Should work now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Jonathan Druart changed: What|Removed |Added Attachment #160899|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 160931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160931&action=edit Bug 35783: Replace TT plugin's method Biblio::RecallsCount We can use biblio.recalls.search( completed => 0 ).count instead. Test plan: 1. Go to the biblio detail view, click on the different entries in the menu on the left. Confirm that the "Recalls" tab always has the correct number of current recalls display in the parenthesis. 2. Run a search and confirm that the number of current recalls are still displayed for each result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- I have had a go at testing. For me, there were no changes on record page - things worked as expected. However, it didn't show in the search results (it just showed Recalls (0)). It did work before the patches were applied. Testing notes (using KTD): 1. Apply the patch, run updatedatabase, restart_all 2. Enable the UseRecalls system preference 3. Set the circulation rules. For ALL ALL: - Recalls allowed (total): 5 - Recalls per record (count): 5 - On shelf recalls allowed: If any available - Recall due date interval (day): 5 - Recall overdue fine amount: 1 - Recall pickup period (day): 2 4. Checkout two different records to different patrons - Programming Perl (262): Mary Burton - Perl template toolkit (255): Bobbie Middleton 5. Use the Koha user to place recall for the two records in the OPAC. 6. Look at the record in the staff interface - the tab for recalls should show the correct number of recalls (Recalls (1)). 7. Do a search that should return the record - it should show Recalls (1) as well. 8. Repeat steps 5-6 with a different patron (I used Henry). The number should change to match the number of recalls (Recalls (2)) in the record and search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 --- Comment #1 from Jonathan Druart --- Created attachment 160899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160899&action=edit Bug 35783: Replace TT plugin's method Biblio::RecallsCount We can use biblio.recalls.search( completed => 0 ).count instead. Test plan: 1. Go to the biblio detail view, click on the different entries in the menu on the left. Confirm that the "Recalls" tab always has the correct number of current recalls display in the parenthesis. 2. Run a search and confirm that the number of current recalls are still displayed for each result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35783] Remove Koha::Template::Plugin::Biblio::RecallsCount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35783 Jonathan Druart changed: What|Removed |Added Depends on||35782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35782 [Bug 35782] Remove Koha::Template::Plugin::Biblio::HoldsCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
