https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Katrin Fischer changed:
What|Removed |Added
Keywords||additional_work_needed,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #15 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Katrin Fischer changed:
What|Removed |Added
Version(s)||24.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #14 from Jonathan Druart ---
Created attachment 164249
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164249=edit
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js
- The option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Attachment #163799|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Brendan Lawlor changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #12 from Brendan Lawlor ---
Before patch:
npx prettier -w ./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
git diff --compact-summary ./koha-tmpl/
intranet-tmpl/prog/js/vue/components/KohaTable.vue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Brendan Lawlor changed:
What|Removed |Added
Attachment #163818|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #10 from Paul Derscheid ---
Yes, it's exactly the same.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #9 from Brendan Lawlor ---
Is the test plan for the follow up the same as it was for the first patch?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #8 from Paul Derscheid ---
Created attachment 163818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163818=edit
Bug 36400 (follow-up): remove option editorconfig from .prettierrc.js
- The option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Paul Derscheid changed:
What|Removed |Added
Patch complexity|Small patch |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Attachment #163710|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Attachment #163695|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #6 from Paul Derscheid ---
Yes, using eslint and prettier together can cause performance problems because
if not mitigated they both apply their formatting rules which can cause very
sluggish formatting and even
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #4 from Brendan Lawlor ---
Tested using vscode:
Before the patch:
npx prettier ./koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue
git diff --compact-summary ./koha-tmpl/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #3 from Brendan Lawlor ---
Created attachment 163710
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163710=edit
Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js
Let's centralize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Brendan Lawlor changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Brendan Lawlor changed:
What|Removed |Added
CC||blaw...@clamsnet.org
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #2 from Paul Derscheid ---
Created attachment 163695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163695=edit
Attachment to Bug 36400 - Centralize {js,ts,vue} formatting config in
.prettierrc.js
Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
Paul Derscheid changed:
What|Removed |Added
Status|NEW |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36400
--- Comment #1 from Paul Derscheid ---
Using the cli .editorconfig should be ignored by default, see
https://github.com/prettier/prettier/issues/15401
--
You are receiving this mail because:
You are watching all bug changes.
You
28 matches
Mail list logo