[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #33 from Tomás Cohen Arazi  ---
(In reply to Fridolin Somers from comment #31)
> Does not apply easy on 23.11.x.
> Please provide patches if possible.

I'll submit a 23.11 version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #32 from Fridolin Somers  ---
Ah with more backports it applies if I skip "bug 30070 follow-up" patch (since
not in 23.11.x).

But I get error in unit test :

kohadev-koha@kohadevbox:koha(23.11.x)$ prove xt/api.t 
xt/api.t .. 1/4 
#   Failed test 'Validation exit code is 0'
#   at xt/api.t line 100.
#  got: '256'
# expected: '0'
# Validation failed. /paths/libraries/{library_id}/cash_registers/get is
missing path parameter(s) for {library_id}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-05-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #31 from Fridolin Somers  ---
Does not apply easy on 23.11.x.
Please provide patches if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05
released in||
 Status|Passed QA   |Pushed to main

--- Comment #30 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #29 from Katrin Fischer  ---
Thanks for the quick rebase :)

Could we have a test plan to see the changes in action? (not blocker) I managed
in the past, but it might be good to have it available somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 165703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165703=edit
Bug 36565: EDI files API docs fixes (bug 30070 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 165702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165702=edit
Bug 36565: Preservation module API docs fixes (bug 30708 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 165701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165701=edit
Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 165700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165700=edit
Bug 36565: ILL requests API docs fixes (bug 22440 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 165699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165699=edit
Bug 36565: Bookings API docs fixes (bug 29002 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #164648|0   |1
is obsolete||
 Attachment #164649|0   |1
is obsolete||
 Attachment #164650|0   |1
is obsolete||
 Attachment #164651|0   |1
is obsolete||
 Attachment #164652|0   |1
is obsolete||
 Attachment #164653|0   |1
is obsolete||

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 165698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165698=edit
Bug 36565: Unit tests

This patch introduces tests on the OpenAPI spec so that all tags used in
path definitions have their corresponding entry at the top level 'tags'
section.

This it important for correctly rendering the API documentation.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #22 from Katrin Fischer  ---
I fixed the first conflict, but got stuck on the second - can you please
rebase?

Applying: Bug 36565: Bookings API docs fixes (bug 29002 follow-up)
Applying: Bug 36565: ILL requests API docs fixes (bug 22440 follow-up)
Using index info to reconstruct a base tree...
M   api/v1/swagger/paths/ill_requests.yaml
Falling back to patching base and 3-way merge...
Auto-merging api/v1/swagger/paths/ill_requests.yaml
Applying: Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up)
Applying: Bug 36565: Preservation module API docs fixes (bug 30708 follow-up)
Applying: Bug 36565: EDI files API docs fixes (bug 30070 follow-up)
error: sha1 information is lacking or useless (api/v1/swagger/swagger.yaml).
error: could not build fake ancestor
Patch failed at 0001 Bug 36565: EDI files API docs fixes (bug 30070 follow-up)
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-36565-EDI-files-API-docs-fixes-bug-30070-follo-dncuei9u.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #21 from Martin Renvoize  ---
Thanks for the cleanup work here Tomas, and apologies it seems I was guilty of
introducing a few of the issues.

Great to see a unit test to help prevent these in the future.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164647|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 164653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164653=edit
Bug 36565: EDI files API docs fixes (bug 30070 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164646|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 164652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164652=edit
Bug 36565: Preservation module API docs fixes (bug 30708 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164645|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 164651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164651=edit
Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164644|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 164650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164650=edit
Bug 36565: ILL requests API docs fixes (bug 22440 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164643|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 164649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164649=edit
Bug 36565: Bookings API docs fixes (bug 29002 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #164642|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 164648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164648=edit
Bug 36565: Unit tests

This patch introduces tests on the OpenAPI spec so that all tags used in
path definitions have their corresponding entry at the top level 'tags'
section.

This it important for correctly rendering the API documentation.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164617|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 164647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164647=edit
Bug 36565: EDI files API docs fixes (bug 30070 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164616|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 164646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164646=edit
Bug 36565: Preservation module API docs fixes (bug 30708 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164615|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 164645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164645=edit
Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164614|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 164644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164644=edit
Bug 36565: ILL requests API docs fixes (bug 22440 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164613|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 164643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164643=edit
Bug 36565: Bookings API docs fixes (bug 29002 follow-up)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Attachment #164612|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 164642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164642=edit
Bug 36565: Unit tests

This patch introduces tests on the OpenAPI spec so that all tags used in
path definitions have their corresponding entry at the top level 'tags'
section.

This it important for correctly rendering the API documentation.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Tomás Cohen Arazi  ---
I submitted a patch for each dependency bug, because I don't want to track
where each was released, and this way it can be backported where appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #7 from Tomás Cohen Arazi  ---
To test:
1. Apply the tests patch
2. Run:
   $ ktd --shell
  k$ prove xt/api.t
=> FAIL: Tests fail! We have spec issues!
3. Apply the rest of the patches
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 164617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164617=edit
Bug 36565: EDI files API docs fixes (bug 30070 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 164616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164616=edit
Bug 36565: Preservation module API docs fixes (bug 30708 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 164615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164615=edit
Bug 36565: Biblio merge API docs fixes (bug 33036 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 164614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164614=edit
Bug 36565: ILL requests API docs fixes (bug 22440 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 164613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164613=edit
Bug 36565: Bookings API docs fixes (bug 29002 follow-up)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 164612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164612=edit
Bug 36565: Unit tests

This patch introduces tests on the OpenAPI spec so that all tags used in
path definitions have their corresponding entry at the top level 'tags'
section.

This it important for correctly rendering the API documentation.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||33036, 30708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708
[Bug 30708] Creation of a new 'Preservation' module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036
[Bug 33036] REST API: Merge biblio records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
[Bug 22440] Improve ILL page performance by moving to server side filtering
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36565] Fix API docs inconsistencies

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36565

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED
 Depends on||29002


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002
[Bug 29002] Add ability to book items ahead of time
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/