[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

--- Comment #5 from Jonathan Druart  ---
We could have that instead:

container.find(".dt-info").remove();
container.find(".table_entries").remove();
container.find(".dataTables_filter").remove();
container.find(".dt_button_clear_filter").remove();
container.find(".bottom.pager").remove();

But then there is a CSS adjustment to provide, the "Columns" button is not on
the right with the other 2 buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Jonathan Druart  ---
The purpose of those lines are to hide the pagination if the number of items to
display is <= than the number of the number of total items (ie. all the items
are displayed on the screen).

The idea was to reduce the size of the table when it's not necessary to show
the pagination.

It was a requirement from testers from bug 33568 so I think we should keep it.

However I agree that we could display the buttons however.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

David Nind  changed:

   What|Removed |Added

 Attachment #165262|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 165266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165266=edit
Bug 36663: Don't hide table elements if StaffDetailItemSelection is enabled

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Pedro Amorim  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||lu...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com, oleon...@myacpl.org

--- Comment #2 from Pedro Amorim  ---
@Joubu would love input here. I'm not 100% sure about my patch or what the code
I'm removing is originally supposed to fix/prevent, but the patch solves the
issue I described in the first comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

--- Comment #1 from Pedro Amorim  ---
Created attachment 165262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165262=edit
Bug 36663: Don't hide table elements if StaffDetailItemSelection is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/