subject:"\[Koha\-bugs\] \[Bug 37305\] Remove C4\:\:Biblio\:\:prepare_marc_host and use Koha\:\:Biblio\->generate_marc_host

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||[email protected]
   ||m
 Version(s)|25.11.00,25.05.02   |25.11.00,25.05.02,24.11.08
released in||

--- Comment #21 from Fridolin Somers  ---
Pushed to 24.11.x for 24.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)|25.05.02|25.11.00,25.05.02
released in||
  Text to go in the|25.11.00|
  release notes||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #20 from Paul Derscheid  ---
Nice work everyone!

Pushed to 25.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Paul Derscheid  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 Version(s)||25.05.02
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
  Text to go in the||25.11.00
  release notes||

--- Comment #19 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to main for 25.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks|22439   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439
[Bug 22439] Duplicated code in PrepHostMarcField and prepare_host_field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #18 from Martin Renvoize (ashimema) 
 ---
Created attachment 183757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183757&action=edit
Bug 37305: (follow-up) Only add control number subfield when defined

The previous commit introduced a bug where the control number subfield 'w'
was being added to the MARC field even when undefined, causing test failures.

This patch adds a condition to only push the control number subfield when
the value is actually defined, matching the pattern used for other subfields
in the method.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183599|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize (ashimema) 
 ---
Created attachment 183756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183756&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

Sponsored-by: Open Fifth 
Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-07-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183598|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize (ashimema) 
 ---
Created attachment 183755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183755&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

Sponsored-by: Open Fifth 
Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #15 from Lucas Gass (lukeg)  ---
I believe that t/db_dependent/Koha/Biblio.t tests are failing with this
applied. Please check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183546|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize (ashimema) 
 ---
Created attachment 183599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183599&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

Sponsored-by: Open Fifth 
Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #14 from Martin Renvoize (ashimema) 
 ---
I've fixed my commit hook now.. appologies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183545|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize (ashimema) 
 ---
Created attachment 183598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183598&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

Sponsored-by: Open Fifth 
Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 CC||[email protected]
 Status|Passed QA   |Failed QA

--- Comment #11 from Lucas Gass (lukeg)  ---
The QA tool tells me this is not tidy:

Processing files
[RUNNING] C4/Biblio.pm
[RUNNING] Koha/Biblio.pm
[RUNNING] cataloguing/addbiblio.pl
[PASS] cataloguing/addbiblio.pl
[FAIL] Koha/Biblio.pm
[PASS] C4/Biblio.pm
Result:
[PASS] C4/Biblio.pm
[FAIL] Koha/Biblio.pm
   FAIL   tidiness
File is not tidy, please run `perl misc/devel/tidy.pl
Koha/Biblio.pm`
[PASS] cataloguing/addbiblio.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 QA Contact|[email protected] |[email protected]
   |y.org   |o.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #10 from Martin Renvoize (ashimema) 
 ---
Tested and moved along as part of bug 39545.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183540|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize (ashimema) 
 ---
Created attachment 183545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183545&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #183541|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize (ashimema) 
 ---
Created attachment 183546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183546&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

Signed-off-by: Heather Hernandez 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181982|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize (ashimema) 
 ---
Created attachment 183541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183541&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #181981|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize (ashimema) 
 ---
Created attachment 183540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183540&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-14 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #5 from Martin Renvoize (ashimema) 
 ---
Just a quick rebase to confirm this all still applies after the tidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #169079|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize (ashimema) 
 ---
Created attachment 181982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181982&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #169078|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize (ashimema) 
 ---
Created attachment 181981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181981&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks|34482   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482
[Bug 34482] Improve MARC21 7xx linking fields in bibliographic records
[Omnibus]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks||39545
 Depends on|39545   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545
[Bug 39545] Construct more complete 773 content when creating a child record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks||34482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482
[Bug 34482] Improve MARC21 7xx linking fields in bibliographic records
[Omnibus]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2025-05-06 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Depends on||39545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39545
[Bug 39545] Construct more complete 773 content when creating a child record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22439


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439
[Bug 22439] Duplicated code in PrepHostMarcField and prepare_host_field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 CC||[email protected],
   ||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|29560   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560
[Bug 29560] Add option to create MARC links when adding items to bundles
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #2 from Martin Renvoize  ---
Created attachment 169079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169079&action=edit
Bug 37305: Remove C4::Biblio::prepare_host_field

This patch updates the only use of prepare_host_field to use the well
tested Koha::Biblio->generate_marc_host_field method instead and then
removes the aforementioned prepare_host_field method from C4::Biblio.

Test plan
1) Ensure the "enhanced workflow" for creating analytics still functions
   as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

--- Comment #1 from Martin Renvoize  ---
Created attachment 169078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169078&action=edit
Bug 37305: Subfield order matters

This patch updates the use of a hash to store and then pass subfields to
the MARC::Field new method to an array with key/value pairs using fat comma's.

This allows us to maintain the integrity check that we're passing string
as the first arguament in each pair whilst also allowing us to ensure
fields are passed in the order they are found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||37364


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364
[Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21
245 and 264
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||29560


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560
[Bug 29560] Add option to create MARC links when adding items to bundles
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference

2024-07-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|[email protected] |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

41 matches

Mail list logo