[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Attachment #176658|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 176706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176706&action=edit Bug 37650: Add lookahead days in CheckReserves call in returns.pl Test plan: Enable future holds. Put a positive value in ConfirmFutureHolds. Add a hold for tomorrow and pickup at B. Check item in at A. Confirm hold. Without this patch you should see a warn on L186: [WARN] Use of uninitialized value in string ne at /usr/share/koha/circ/returns.pl line 186. With this patch, you should not see it anymore. NOTE: Before bug 34972 no transfer was created for future holds. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #20 from Marcel de Rooy --- Created attachment 176707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176707&action=edit Bug 37650: (follow-up) Remove FIXME around CheckReserves call The FIXME correctly stated that the CheckReserves call and follow-up only should be executed within the cancel hold scope. NOTE: Actually, I do not see how to trigger it in current code. Since checking in a waiting hold triggers the NotIssued error. And the cancel hold button is not available for holds in queue. Test plan: Place a hold on an item. Checkin at pickup location. Confirm. Hold waiting now? Try again but checkin at another branch. Transfer triggered? The hard part (see my note). Try to get at the form where you can cancel the hold (waiting or first in queue). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #18 from Marcel de Rooy --- Blocking this one. Needs another title now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Severity|major |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #17 from Marcel de Rooy --- This was written in August, so line numbers might vary in the meantime.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Attachment #176657|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 176658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176658&action=edit Bug 37650: Add lookahead days in CheckReserves call in returns.pl Test plan: Enable future holds. Put a positive value in ConfirmFutureHolds. Add a hold for tomorrow and pickup at B. Check item in at A. Confirm hold. Without this patch you should see a warn on L182 and L253. With this patch, they should be gone. NOTE: Before bug 34972 no transfer was created for future holds. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Attachment #170466|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 176657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176657&action=edit Bug 37650: Add lookahead days in CheckReserves call in returns.pl Test plan: Enable future holds. Put a positive value in ConfirmFutureHolds. Add a hold for tomorrow and pickup at B. Check item in at A. Confirm hold. Without this patch you should see a warn on L182 and L253. With this patch, they should be gone. NOTE: Before bug 34972 no transfer was created for future holds. See also the 22.11 patch on Bugzilla. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Attachment #170384|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #14 from Marcel de Rooy --- (In reply to Lisette Scheer from comment #13) > This needs to be rebased. > Applying: Bug 37650: Add lookahead in calling GetOtherReserves in returns.pl > Using index info to reconstruct a base tree... > M C4/Reserves.pm > M circ/returns.pl > Falling back to patching base and 3-way merge... > Auto-merging circ/returns.pl > CONFLICT (content): Merge conflict in circ/returns.pl > Auto-merging C4/Reserves.pm > CONFLICT (content): Merge conflict in C4/Reserves.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 37650: Add lookahead in calling GetOtherReserves in > returns.pl Thx for trying that one. I will remove the 22.11 variant now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||[email protected] ||m --- Comment #13 from Lisette Scheer --- This needs to be rebased. Applying: Bug 37650: Add lookahead in calling GetOtherReserves in returns.pl Using index info to reconstruct a base tree... M C4/Reserves.pm M circ/returns.pl Falling back to patching base and 3-way merge... Auto-merging circ/returns.pl CONFLICT (content): Merge conflict in circ/returns.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 37650: Add lookahead in calling GetOtherReserves in returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650
--- Comment #12 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #11)
> The line numbers may not be exact anymore. They were on uninitialized $op
> iirc, so not that important. L253 includes an $op. 182 does not now?
L253 for me would be
if ( $op eq 'cud-dotransfer'){
which is likely the same for you.
182 that I get is
if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) {
And it's relevant with the changes line 180 from the patch.
> First thing coming up, is test with an item level hold.
Right, I though of it last time an forgot. But same result here :(
Only war at line 182.
I held 312118 to patron with borrowernumber=5, pickup liberty.
I'm in centerville and check in and confirmed the hold & transfer.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #11 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #10) > I don't get a warn at L253, on L182, yes. The line numbers may not be exact anymore. They were on uninitialized $op iirc, so not that important. L253 includes an $op. 182 does not now? > Hold starts on date: tomorrow > ConfirmFutureHolds: 3 > record level hold > I'm checking it in another library than the pick up one. > > Anything I could be missing? I didn't know about the feature and struggled > to find AllowHoldDateInFuture so I'm likely missing something obvious. First thing coming up, is test with an item level hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Victor Grousset/tuxayo changed: What|Removed |Added CC||[email protected] --- Comment #10 from Victor Grousset/tuxayo --- I don't get a warn at L253, on L182, yes. Hold starts on date: tomorrow ConfirmFutureHolds: 3 record level hold I'm checking it in another library than the pick up one. Anything I could be missing? I didn't know about the feature and struggled to find AllowHoldDateInFuture so I'm likely missing something obvious. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > A related problem in transferstoreceive btw: > > # we check if we have a reserv for this transfer > my $holds = $item->current_holds; > > This wont find a future hold (e.g. for tomorrow) either. See bug 37651 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #8 from Marcel de Rooy --- Created attachment 170466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170466&action=edit Bug 37650: Add lookahead days in CheckReserves call in returns.pl Test plan: Enable future holds. Put a positive value in ConfirmFutureHolds. Add a hold for tomorrow and pickup at B. Check item in at A. Confirm hold. Without this patch you should see a warn on L182 and L253. With this patch, they should be gone. NOTE: Before bug 34972 no transfer was created for future holds. See also the 22.11 patch on Bugzilla. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #7 from Marcel de Rooy --- The 22.11 bug is ONLY necessary in case 34972 is not backported ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650
--- Comment #6 from Marcel de Rooy ---
Testing on master shows that the bug does not occur anymore after bug 34972.
The call to CheckReserves seems to be wrong but this part of code does not seem
to make any difference:
if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) {
my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'}
);
$template->param(
itemtitle => $biblio->title,
itembiblionumber => $biblio->biblionumber,
iteminfo => $biblio->author,
patron => $patron,
diffbranch => 1,
);
}
If you confirmed a future hold, returns moves the hold to transit and creates a
transfer now. The following call to CheckReserves will not find this hold,
normally nothing. So $nextreserveinfo is expected to be undef.
There is no additional display after the modal is gone. Just a checkin box.
Warnings in the log confirm the uninitialized value:
[2024/08/19 12:02:34] [WARN] Use of uninitialized value in string ne at
/usr/share/koha/circ/returns.pl line 182.
The master patch should resolve that warning now. And remove an additional one
too on L253:
[2024/08/19 12:04:01] [WARN] Use of uninitialized value $op in string eq at
/usr/share/koha/circ/returns.pl line 253.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #5 from Marcel de Rooy --- Created attachment 170384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170384&action=edit Bug 37650: [22.11] Add lookahead in calling GetOtherReserves in returns.pl Test plan: Add a future hold for an item on another branch. Check that item in at the home branch. Without this patch, you can confirm the hold but a transfer will not be made. With this patch, the transfer should be created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #4 from Emily Lamancusa --- (In reply to Marcel de Rooy from comment #1) > FOR MASTER: > my ( undef, $nextreservinfo, undef ) = CheckReserves($item); > > @Emily: Inrelation to bug 34972, we should pass lookahead_days here as well. > Or default in the sub to the pref ConfirmFutureHolds? Ooh, good catch. I think we need to pass it. C4::Circulation::transferbook calls CheckReserves with no lookahead on purpose, so we need to preserve the behavior for that case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37651 --- Comment #3 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > A related problem in transferstoreceive btw: > > # we check if we have a reserv for this transfer > my $holds = $item->current_holds; > > This wont find a future hold (e.g. for tomorrow) either. Moving this to a new report. The whole idea behind current_holds is a bit rigorous.. Most calls might need some adjustment? Bug 37651 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 --- Comment #2 from Marcel de Rooy --- A related problem in transferstoreceive btw: # we check if we have a reserv for this transfer my $holds = $item->current_holds; This wont find a future hold (e.g. for tomorrow) either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36762 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34972 CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #1 from Marcel de Rooy --- FOR MASTER: my ( undef, $nextreservinfo, undef ) = CheckReserves($item); @Emily: Inrelation to bug 34972, we should pass lookahead_days here as well. Or default in the sub to the pref ConfirmFutureHolds? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37650] Checkin does not create transfers for future holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650 Marcel de Rooy changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
