[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Blocks||43259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 [Bug 43259] Add to group does not add to group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Andrew Auld changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC||[email protected] --- Comment #109 from Andrew Auld --- Architectural change - doesn't need to be documented. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Pedro Amorim changed: What|Removed |Added Blocks||40865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40865 [Bug 40865] Single patron result does not redirect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 David Cook changed: What|Removed |Added Blocks||40522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Status|Pushed to main |Needs documenting --- Comment #108 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Blocks||40161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40161 [Bug 40161] New translation not displayed when translating an item type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=39933
--- Comment #107 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #106)
> (In reply to Katrin Fischer from comment #104)
> > What about this FIXME?
> >
> > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
> > [% IF !(Koha.Preference('EDIFACT') && ediaccount) %]
> > // FIXME This cannot work correctly without
> > bKohaColumnsUseNames
> > table_settings['columns'].splice(18, 1);
> > [% END %]
>
> *ping*
It's a FIXME. The problem is not introduced by this patch, ideally we should
have a bug report I guess...
Opened bug 39933.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255
--- Comment #106 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #104)
> What about this FIXME?
>
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
> [% IF !(Koha.Preference('EDIFACT') && ediaccount) %]
> // FIXME This cannot work correctly without
> bKohaColumnsUseNames
> table_settings['columns'].splice(18, 1);
> [% END %]
*ping*
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||39779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39779 [Bug 39779] Table.row.add error in Point of Sale table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Bug 38255 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #105 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Katrin Fischer changed: What|Removed |Added Version(s)||25.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255
Katrin Fischer changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #104 from Katrin Fischer ---
What about this FIXME?
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
[% IF !(Koha.Preference('EDIFACT') && ediaccount) %]
// FIXME This cannot work correctly without
bKohaColumnsUseNames
table_settings['columns'].splice(18, 1);
[% END %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177885|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize (ashimema) --- Created attachment 178465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178465&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177875|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize (ashimema) --- Created attachment 178455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178455&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177884|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize (ashimema) --- Created attachment 178464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178464&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #103 from Martin Renvoize (ashimema) --- Finally come back here.. all working in my testing, QA scripts happy and code is cleaner. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177886|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize (ashimema) --- Created attachment 178466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178466&action=edit Bug 38255: Fix additional-contents Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177883|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize (ashimema) --- Created attachment 178463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178463&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177882|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize (ashimema) --- Created attachment 178462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178462&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177881|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize (ashimema) --- Created attachment 178461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178461&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177880|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize (ashimema) --- Created attachment 178460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178460&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177879|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize (ashimema) --- Created attachment 178459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178459&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177878|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize (ashimema) --- Created attachment 178458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178458&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177877|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize (ashimema) --- Created attachment 178457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178457&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #177876|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize (ashimema) --- Created attachment 178456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178456&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #90 from Marcel de Rooy --- Applying: Bug 38255: Allow instantiation without parameters error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/datatables.js). error: could not build fake ancestor Patch failed at 0001 Bug 38255: Allow instantiation without parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #83 from Jonathan Druart --- Created attachment 177880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177880&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #88 from Jonathan Druart --- Created attachment 177885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177885&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #89 from Jonathan Druart --- Created attachment 177886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177886&action=edit Bug 38255: Fix additional-contents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #87 from Jonathan Druart --- Created attachment 177884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177884&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #85 from Jonathan Druart --- Created attachment 177882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177882&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #86 from Jonathan Druart --- Created attachment 177883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177883&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #84 from Jonathan Druart --- Created attachment 177881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177881&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #81 from Jonathan Druart --- Created attachment 177878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177878&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #82 from Jonathan Druart --- Created attachment 177879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177879&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #79 from Jonathan Druart --- Created attachment 177876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177876&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #80 from Jonathan Druart --- Created attachment 177877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177877&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #177214|0 |1 is obsolete|| Attachment #177215|0 |1 is obsolete|| Attachment #177216|0 |1 is obsolete|| Attachment #177217|0 |1 is obsolete|| Attachment #177218|0 |1 is obsolete|| Attachment #177219|0 |1 is obsolete|| Attachment #177220|0 |1 is obsolete|| Attachment #177221|0 |1 is obsolete|| Attachment #177222|0 |1 is obsolete|| Attachment #177223|0 |1 is obsolete|| Attachment #177224|0 |1 is obsolete|| Attachment #177262|0 |1 is obsolete|| --- Comment #78 from Jonathan Druart --- Created attachment 177875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177875&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Blocks||38440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38440 [Bug 38440] dt_button_clear_filter handling outside of datatables.js not needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #77 from Jonathan Druart --- Created attachment 177262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177262&action=edit Bug 38255: Fix additional-contents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #74 from Jonathan Druart --- Created attachment 177223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177223&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #70 from Jonathan Druart --- Created attachment 177219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177219&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #177076|0 |1 is obsolete|| Attachment #177077|0 |1 is obsolete|| Attachment #177078|0 |1 is obsolete|| Attachment #177079|0 |1 is obsolete|| Attachment #177080|0 |1 is obsolete|| Attachment #177081|0 |1 is obsolete|| Attachment #177082|0 |1 is obsolete|| Attachment #177083|0 |1 is obsolete|| Attachment #177084|0 |1 is obsolete|| Attachment #177085|0 |1 is obsolete|| Attachment #177086|0 |1 is obsolete|| --- Comment #65 from Jonathan Druart --- Created attachment 177214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177214&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #76 from Jonathan Druart --- Yet another rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #75 from Jonathan Druart --- Created attachment 177224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177224&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #73 from Jonathan Druart --- Created attachment 177222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177222&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #72 from Jonathan Druart --- Created attachment 177221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177221&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #71 from Jonathan Druart --- Created attachment 177220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177220&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #69 from Jonathan Druart --- Created attachment 177218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177218&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #68 from Jonathan Druart --- Created attachment 177217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177217&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #67 from Jonathan Druart --- Created attachment 177216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177216&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #66 from Jonathan Druart --- Created attachment 177215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177215&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #61 from Jonathan Druart --- Created attachment 177084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177084&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #64 from Jonathan Druart --- just a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #62 from Jonathan Druart --- Created attachment 177085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177085&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #63 from Jonathan Druart --- Created attachment 177086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177086&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #60 from Jonathan Druart --- Created attachment 177083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177083&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #58 from Jonathan Druart --- Created attachment 177081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177081&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #59 from Jonathan Druart --- Created attachment 177082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177082&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #56 from Jonathan Druart --- Created attachment 177079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177079&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #57 from Jonathan Druart --- Created attachment 177080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177080&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #54 from Jonathan Druart --- Created attachment 177077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177077&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #55 from Jonathan Druart --- Created attachment 177078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177078&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #176550|0 |1 is obsolete|| Attachment #176551|0 |1 is obsolete|| Attachment #176552|0 |1 is obsolete|| Attachment #176553|0 |1 is obsolete|| Attachment #176554|0 |1 is obsolete|| Attachment #176555|0 |1 is obsolete|| Attachment #176556|0 |1 is obsolete|| Attachment #176557|0 |1 is obsolete|| Attachment #176558|0 |1 is obsolete|| Attachment #176559|0 |1 is obsolete|| Attachment #176560|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 177076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177076&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #52 from Jonathan Druart --- Created attachment 176560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176560&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #51 from Jonathan Druart --- Created attachment 176559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176559&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #50 from Jonathan Druart --- Created attachment 176558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176558&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #49 from Jonathan Druart --- Created attachment 176557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176557&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #48 from Jonathan Druart --- Created attachment 176556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176556&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #47 from Jonathan Druart --- Created attachment 176555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176555&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #46 from Jonathan Druart --- Created attachment 176554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176554&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #45 from Jonathan Druart --- Created attachment 176553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176553&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #44 from Jonathan Druart --- Created attachment 176552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176552&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #43 from Jonathan Druart --- Created attachment 176551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176551&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #176348|0 |1 is obsolete|| Attachment #176349|0 |1 is obsolete|| Attachment #176350|0 |1 is obsolete|| Attachment #176351|0 |1 is obsolete|| Attachment #176352|0 |1 is obsolete|| Attachment #176353|0 |1 is obsolete|| Attachment #176354|0 |1 is obsolete|| Attachment #176355|0 |1 is obsolete|| Attachment #176356|0 |1 is obsolete|| Attachment #176357|0 |1 is obsolete|| Attachment #176358|0 |1 is obsolete|| --- Comment #42 from Jonathan Druart --- Created attachment 176550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176550&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176146|0 |1 is obsolete|| --- Comment #41 from Lucas Gass (lukeg) --- Created attachment 176358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176358&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176071|0 |1 is obsolete|| --- Comment #40 from Lucas Gass (lukeg) --- Created attachment 176357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176357&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176070|0 |1 is obsolete|| --- Comment #39 from Lucas Gass (lukeg) --- Created attachment 176356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176356&action=edit Bug 38255: Exception - Item search Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176069|0 |1 is obsolete|| --- Comment #38 from Lucas Gass (lukeg) --- Created attachment 176355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176355&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176068|0 |1 is obsolete|| --- Comment #37 from Lucas Gass (lukeg) --- Created attachment 176354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176354&action=edit Bug 38255: Exception - Manage staged MARC records Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176067|0 |1 is obsolete|| --- Comment #36 from Lucas Gass (lukeg) --- Created attachment 176353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176353&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176066|0 |1 is obsolete|| --- Comment #35 from Lucas Gass (lukeg) --- Created attachment 176352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176352&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176064|0 |1 is obsolete|| --- Comment #33 from Lucas Gass (lukeg) --- Created attachment 176350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176350&action=edit Bug 38255: Add kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176065|0 |1 is obsolete|| --- Comment #34 from Lucas Gass (lukeg) --- Created attachment 176351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176351&action=edit Bug 38255: Early return if the node does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176063|0 |1 is obsolete|| --- Comment #32 from Lucas Gass (lukeg) --- Created attachment 176349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176349&action=edit Bug 38255: Replace dataTable constructor with kohaTable - OPAC Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176062|0 |1 is obsolete|| --- Comment #31 from Lucas Gass (lukeg) --- Created attachment 176348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176348&action=edit Bug 38255: Replace dataTable constructor with kohaTable - Staff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #30 from Jonathan Druart --- Created attachment 176146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176146&action=edit Bug 38255: Fix Cash registers This patch fixes the following error: Uncaught TypeError: table.column is not a function We needed to pass table.DataTable() to filterDataTable I've decided to clean the code as it does not make sense to me: filterDataTable is called from a single place, and clearFilter is not needed (we should not interfer with the 'Clear filter' button here) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #29 from Lucas Gass (lukeg) --- Going through the OPAC tables, everything seems good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Lucas Gass (lukeg) changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #28 from Lucas Gass (lukeg) --- I've tested almost all staff interface tables. Only one problem stood out to me 1 .admin/cash_registers.pl -Change Filter by Library -Uncaught TypeError: table.column is not a function I have yet to test any OPAC tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 --- Comment #27 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175873|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 176071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176071&action=edit Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175872|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 176070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176070&action=edit Bug 38255: Exception - Item search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175599|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 176069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176069&action=edit Bug 38255: Allow instantiation without parameters `$(node).kohaTable()` should work. Without this patch we got `Uncaught TypeError: settings is null` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175598|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 176068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176068&action=edit Bug 38255: Exception - Manage staged MARC records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175352|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 176067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176067&action=edit Bug 38255: Fix JS error Uncaught SyntaxError: redeclaration of let -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38255] Do not use dataTable constructor directly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 Jonathan Druart changed: What|Removed |Added Attachment #175185|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 176066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176066&action=edit Bug 38255: Exceptions Those tables are using a svc script, not the REST API. It is not compatible with kohaTable's default 'ajax' options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
