[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #26 from Wainui Witika-Park --- Not backporting to 22.11 as this step of the test plan doesn't happen: 8. Poof, your whole list is gone The list does not get deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Version(s)|25.05.00,24.11.02 |25.05.00,24.11.02,23.11.14 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #25 from Fridolin Somers --- Pushed to 23.11.x for 23.11.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|Passed QA |Pushed to oldstable --- Comment #24 from Wainui Witika-Park --- Sorry about all the updates, my mistake. Changed my mind. Applied to 24.05.x for 24.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #22 from Alex Buckley --- (In reply to Phil Ringnalda from comment #21) > I applied both patches on 24.05.x, and the test plan worked for me, only two > items were deleted from the list. Thanks Phil. That's strange we are seeing different behaviour. We have made a note to revisit this bug report next month, when we have more time to see if we can get it backported to 24.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Wainui Witika-Park changed: What|Removed |Added CC||[email protected] ||et.nz --- Comment #23 from Wainui Witika-Park --- Actually, going to skip this for 24.05.x, please let us know if it is needed. > Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #21 from Phil Ringnalda --- I applied both patches on 24.05.x, and the test plan worked for me, only two items were deleted from the list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Alex Buckley changed: What|Removed |Added CC||[email protected] --- Comment #20 from Alex Buckley --- Hi all, I have been testing these two patches for 24.05.x backport. When I have the first patch applied on 24.05.x all of the patch 1 test plan steps work exactly as noted. However, when I apply the second patch and run through the patch 1 test plan steps again I have found that step 10 fails. If I only remove two items from my list (which has more than 2 items in it) the whole list is deleted. Could someone else please apply both patches on 24.05.x and confirm if this happens for you as well? Thanks in advance, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #19 from Paul Derscheid --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Paul Derscheid changed: What|Removed |Added Version(s)|25.05.00|25.05.00,24.11.02 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 David Nind changed: What|Removed |Added Text to go in the||This fixes confirm dialog release notes||boxes in the OPAC to ||prevent unintended actions ||being taken, such as ||accidentally deleting a ||list. This specifically ||fixes lists, and makes a ||technical change to prevent ||this happening in the ||future for other areas of ||the OPAC (such as ||suggestions, tags, and ||self-checkout). || ||Example of ||issue fixed for lists: ||1. ||Create a list with several ||items. ||2. From the new ||list, select a couple of ||the items. ||3. Click "Delete ||list" and then select "No, ||do not delete". ||4. Then ||select "Remove from list", ||and confirm by clicking ||"Yes, remove from list". ||5. ||Result: Instead of removing ||the items selected, the ||whole list was incorrectly ||deleted! CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #18 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #17 from Martin Renvoize (ashimema) --- Nice cleanup and good golfing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175326|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize (ashimema) --- Created attachment 175566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175566&action=edit Bug 38268: (Follow-up) Prevent callbacks from being duplicated This patch moves the logic up one level into the confirmModal function to prevent future regressions Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
Martin Renvoize (ashimema) changed:
What|Removed |Added
Attachment #175325|0 |1
is obsolete||
--- Comment #15 from Martin Renvoize (ashimema)
---
Created attachment 175565
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175565&action=edit
Bug 38268: Callers of confirmModal need to remove the modal as the first step
in their callback function
Templates that use confirmModal to show a pretty confirm() need to
remove the modal in their callback function, or they are at risk of
having the first callback called for subsequent calls that think they
will get their own callback called. opac-user.tt is already fixed,
opac-shelves.tt is currently affected, and opace-suggestions.tt,
opac-tags.tt, and sco/sco-main.tt are at risk of being affected if
anyone adds another confirmModal caller.
Test plan:
1. Without the patch, open the OPAC, log in, search for something that
will return several results
2. Select all - Add to list - New list
3. Lists - {your list name}
4. Click the checkboxes for the first two items
5. Instead of clicking Remove from list, accidentally click Delete list
6. In the confirmation popup, realize it was a mistake and click No, do
not delete
7. Click Remove from list
8. Poof, your whole list is gone
9. Apply patch
10. Repeat steps 1-7, but instead of the whole list being deleted, see
that only the selected two items were removed
11. Now intentionally click Delete list and click Yes, delete, you'll
see that it is deleted rather than getting a message about nothing
being removed like you would have gotten without the patch if you
started by removing an item
12. On any bib detail page, click Add tag(s) and add one
13. Your account - Tags, check the checkbox for the tag, Remove selected
tags, Yes, delete tag and verify that it was deleted
14. Purchase suggestions - New purchase suggestion, fill in a title and
submit your suggestion, click the checkbox for your suggestion,
Delete selected, Yes, delete suggestion and verify it was deleted
15. In the staff interface, find and copy the barcode for any item that can
be checked out, then go to /cgi-bin/koha/sco/sco-main.pl with the
OPAC hostname and port, not the staff, and log in
16. Paste the barcode in the input, click Submit, then click Finish, and
in the confirmation popup click Print recept and end session, and
verify that it tries to print
Sponsored-by: Chetco Community Public Library
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Owen Leonard
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
Owen Leonard changed:
What|Removed |Added
Attachment #174995|0 |1
is obsolete||
Attachment #175311|0 |1
is obsolete||
--- Comment #13 from Owen Leonard ---
Created attachment 175325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175325&action=edit
Bug 38268: Callers of confirmModal need to remove the modal as the first step
in their callback function
Templates that use confirmModal to show a pretty confirm() need to
remove the modal in their callback function, or they are at risk of
having the first callback called for subsequent calls that think they
will get their own callback called. opac-user.tt is already fixed,
opac-shelves.tt is currently affected, and opace-suggestions.tt,
opac-tags.tt, and sco/sco-main.tt are at risk of being affected if
anyone adds another confirmModal caller.
Test plan:
1. Without the patch, open the OPAC, log in, search for something that
will return several results
2. Select all - Add to list - New list
3. Lists - {your list name}
4. Click the checkboxes for the first two items
5. Instead of clicking Remove from list, accidentally click Delete list
6. In the confirmation popup, realize it was a mistake and click No, do
not delete
7. Click Remove from list
8. Poof, your whole list is gone
9. Apply patch
10. Repeat steps 1-7, but instead of the whole list being deleted, see
that only the selected two items were removed
11. Now intentionally click Delete list and click Yes, delete, you'll
see that it is deleted rather than getting a message about nothing
being removed like you would have gotten without the patch if you
started by removing an item
12. On any bib detail page, click Add tag(s) and add one
13. Your account - Tags, check the checkbox for the tag, Remove selected
tags, Yes, delete tag and verify that it was deleted
14. Purchase suggestions - New purchase suggestion, fill in a title and
submit your suggestion, click the checkbox for your suggestion,
Delete selected, Yes, delete suggestion and verify it was deleted
15. In the staff interface, find and copy the barcode for any item that can
be checked out, then go to /cgi-bin/koha/sco/sco-main.pl with the
OPAC hostname and port, not the staff, and log in
16. Paste the barcode in the input, click Submit, then click Finish, and
in the confirmation popup click Print recept and end session, and
verify that it tries to print
Sponsored-by: Chetco Community Public Library
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #14 from Owen Leonard --- Created attachment 175326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175326&action=edit Bug 38268: (Follow-up) Prevent callbacks from being duplicated This patch moves the logic up one level into the confirmModal function to prevent future regressions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #12 from Matt Blenkinsop --- Added the patch as a follow-up and set it back to NSO, Owen would you mind doing the SO? I've removed myself from QA as I've authored one of the patches, I'll pass it back into the QA pool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added QA Contact|matt.blenkinsop@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added Attachment #175310|0 |1 is obsolete|| --- Comment #11 from Matt Blenkinsop --- Created attachment 175311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175311&action=edit Bug 38268: (Follow-up) Prevent callbacks from being duplicated This patch moves the logic up one level into the confirmModal function to prevent future regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added Attachment #175294|0 |1 is obsolete|| --- Comment #10 from Matt Blenkinsop --- Created attachment 175310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175310&action=edit Bug 38268: (Follow-ups) Prevent callbacks from being duplicated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #9 from Owen Leonard --- (In reply to Matt Blenkinsop from comment #7) > I'm adding an alternate patch for testing that does this - let me know your > thoughts and if the behaviour works as expected The alternate makes sense to me, and thanks to both of you for cleaning up my mess. Matt could you either replace your patch with one which doesn't depend on the first one, or update your patch so that it says it's a follow-up? To me "Alternate" means the other patch isn't needed. But I like the option that gives Phil credit for providing a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 --- Comment #8 from Matt Blenkinsop --- Created attachment 175294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175294&action=edit Bug 38268: (Alternate patch) Prevent callbacks from being duplicated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added QA Contact|[email protected] |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #7 from Matt Blenkinsop --- Started having a look at this for QA and everything works as advertised but I'm hesitant to pass QA. This fixes the existing cases but I worry about what happens the next time someone who isn't aware of this bug adds a call to confirmModal - does it not make more sense to move the removal of the existing modal up a level into the confirmModal function itself so that it is handled each time without the need to implicitly handle it in each individual callback? I'm adding an alternate patch for testing that does this - let me know your thoughts and if the behaviour works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Victor Grousset/tuxayo changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Signed Off --- Comment #6 from Victor Grousset/tuxayo --- It works! :) > 7. Click Remove from list > 8. Poof, your whole list is gone OMG that's vicious, thanks for finding it out and the fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #173410|0 |1
is obsolete||
--- Comment #5 from Victor Grousset/tuxayo ---
Created attachment 174995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174995&action=edit
Bug 38268: Callers of confirmModal need to remove the modal as the first step
in their callback function
Templates that use confirmModal to show a pretty confirm() need to remove the
modal in their callback function, or they are at risk of having the first
callback called for subsequent calls that think they will get their own
callback called. opac-user.tt is already fixed, opac-shelves.tt is currently
affected, and opace-suggestions.tt, opac-tags.tt, and sco/sco-main.tt are at
risk of being affected if anyone adds another confirmModal caller.
Test plan:
1. Without the patch, open the OPAC, log in, search for something that will
return several results
2. Select all - Add to list - New list
3. Lists - {your list name}
4. Click the checkboxes for the first two items
5. Instead of clicking Remove from list, accidentally click Delete list
6. In the confirmation popup, realize it was a mistake and click No, do not
delete
7. Click Remove from list
8. Poof, your whole list is gone
9. Apply patch
10. Repeat steps 1-7, but instead of the whole list being deleted, see that
only the selected two items were removed
11. Now intentionally click Delete list and click Yes, delete, you'll see that
it is deleted rather than getting a message about nothing being removed
like you would have gotten without the patch if you started by removing
an item
12. On any bib detail page, click Add tag(s) and add one
13. Your account - Tags, check the checkbox for the tag, Remove selected tags,
Yes, delete tag and verify that it was deleted
14. Purchase suggestions - New purchase suggestion, fill in a title and submit
your suggestion, click the checkbox for your suggestion, Delete selected,
Yes, delete suggestion and verify it was deleted
15. In the staff interface, find and copy the barcode for any item that can
be checked out, then go to /cgi-bin/koha/sco/sco-main.pl with the OPAC
hostname and port, not the staff, and log in
16. Paste the barcode in the input, click Submit, then click Finish, and in
the confirmation popup click Print recept and end session, and verify that
it tries to print
Sponsored-by: Chetco Community Public Library
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Phil Ringnalda changed: What|Removed |Added Priority|P5 - low|P2 Severity|normal |major --- Comment #4 from Phil Ringnalda --- Huh, I called it "normal" that if you cancel one operation and perform another, the first (destructive enough to require confirmation) operation will be done without any warning. My standards for severity are slipping. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268
--- Comment #3 from Phil Ringnalda ---
Created attachment 173410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173410&action=edit
Bug 38268: Callers of confirmModal need to remove the modal as the first step
in their callback function
Templates that use confirmModal to show a pretty confirm() need to remove the
modal in their callback function, or they are at risk of having the first
callback called for subsequent calls that think they will get their own
callback called. opac-user.tt is already fixed, opac-shelves.tt is currently
affected, and opace-suggestions.tt, opac-tags.tt, and sco/sco-main.tt are at
risk of being affected if anyone adds another confirmModal caller.
Test plan:
1. Without the patch, open the OPAC, log in, search for something that will
return several results
2. Select all - Add to list - New list
3. Lists - {your list name}
4. Click the checkboxes for the first two items
5. Instead of clicking Remove from list, accidentally click Delete list
6. In the confirmation popup, realize it was a mistake and click No, do not
delete
7. Click Remove from list
8. Poof, your whole list is gone
9. Apply patch
10. Repeat steps 1-7, but instead of the whole list being deleted, see that
only the selected two items were removed
11. Now intentionally click Delete list and click Yes, delete, you'll see that
it is deleted rather than getting a message about nothing being removed
like you would have gotten without the patch if you started by removing
an item
12. On any bib detail page, click Add tag(s) and add one
13. Your account - Tags, check the checkbox for the tag, Remove selected tags,
Yes, delete tag and verify that it was deleted
14. Purchase suggestions - New purchase suggestion, fill in a title and submit
your suggestion, click the checkbox for your suggestion, Delete selected,
Yes, delete suggestion and verify it was deleted
15. In the staff interface, find and copy the barcode for any item that can
be checked out, then go to /cgi-bin/koha/sco/sco-main.pl with the OPAC
hostname and port, not the staff, and log in
16. Paste the barcode in the input, click Submit, then click Finish, and in
the confirmation popup click Print recept and end session, and verify that
it tries to print
Sponsored-by: Chetco Community Public Library
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Phil Ringnalda changed: What|Removed |Added Component|Lists |Templates Summary|Cancelling 'Delete list'|Callers of confirmModal |then using 'Delete selected |need to remove the modal as |items' deletes list |the first step in their ||callback function Assignee|[email protected] |[email protected] |ity.org | --- Comment #2 from Phil Ringnalda --- Le sigh. I was starting to suspect that just hiding the modal was the problem, though why is beyond my pay-grade. Then I went looking for other places that should be affected (by having more than one caller of confirmModal), and saw that opac_user.tt should confuse cancel and suspend holds and cancel article requests. But it doesn't, because in bug 27947 three years ago AgustÃn apparently realized this was a problem and how to fix it, silently fixed it in opac_user.tt by making the first step in every callback be '$("#bootstrap-confirm-box-modal").remove()', and nobody reviewing the fix noticed it and considered other places that might need the same fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38268] Callers of confirmModal need to remove the modal as the first step in their callback function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38268 Phil Ringnalda changed: What|Removed |Added Assignee|[email protected] |[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
