[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-07-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

David Nind  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED

--- Comment #11 from David Nind  ---
No changes to the manual required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-06-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes a regression
  release notes||when creating a patron
   ||using the API. No error was
   ||returned if mandatory
   ||patron attributes were not
   ||provided, when it should
   ||be.
 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-06-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting

--- Comment #10 from Fridolin Somers  ---
Depends on Bug 39334 not in 24.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-06-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 Version(s)|25.11.00|25.11.00,25.05.01
released in||
 CC||[email protected]
   ||m

--- Comment #9 from Fridolin Somers  ---
I see in 25.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

--- Comment #8 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to main for 25.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-06-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Version(s)||25.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 QA Contact|[email protected] |[email protected]
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #182803|0   |1
is obsolete||

--- Comment #7 from Nick Clemens (kidclamp)  ---
Created attachment 182820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182820&action=edit
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #182736|0   |1
is obsolete||

--- Comment #6 from Nick Clemens (kidclamp)  ---
Created attachment 182819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182819&action=edit
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 CC||[email protected]
 Attachment #182736|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #182736|0   |1
is obsolete||
 Attachment #182737|0   |1
is obsolete||

--- Comment #5 from Nick Clemens (kidclamp)  ---
Created attachment 182803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182803&action=edit
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

David Nind  changed:

   What|Removed |Added

 Attachment #182731|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 182737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182737&action=edit
Bug 39970: Remove changed_attributes_codes check

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

David Nind  changed:

   What|Removed |Added

 Attachment #182732|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 182736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182736&action=edit
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Pedro Amorim  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Patch complexity|--- |Trivial patch
   Keywords||regression

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

--- Comment #2 from Pedro Amorim  ---
Created attachment 182732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182732&action=edit
Bug 39970: Add tests

Test plan:
1) Apply this test patch. Run. Verify it fails
2) Apply other patch. Run. Verify it passes.

prove t/db_dependent/api/v1/patrons.t

Verify no other regressions are introduced, run:
prove t/db_dependent/Koha/Patron/Attribute.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

--- Comment #1 from Pedro Amorim  ---
Created attachment 182731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182731&action=edit
Bug 39970: Remove changed_attributes_codes check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39970] REST API - Creating a patron without mandatory attribute types does not error (it should)

2025-05-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39970

Pedro Amorim  changed:

   What|Removed |Added

 CC||[email protected],
   ||[email protected],
   ||[email protected],
   ||[email protected]
   ||o.uk,
   ||[email protected]
   ||k

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/