[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #25 from Fridolin Somers --- OK thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4
--- Comment #24 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #22)
> Ah but is it not a boolean pref.
>
> And needs HTML filter no ?
>
> addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') | html %]})
Yes, have a look at `git grep addPrefs`, we already have occurrences pushed to
main, or have a look at the remote branch bug_41324 in my Koha gitlab repo for
more examples.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added CC||[email protected] --- Comment #23 from Katrin Fischer --- (In reply to Fridolin Somers from comment #22) > Ah but is it not a boolean pref. > > And needs HTML filter no ? > > addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') | html %]}) @Joubu? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4
--- Comment #22 from Fridolin Somers ---
Ah but is it not a boolean pref.
And needs HTML filter no ?
addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') | html %]})
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Jan Kissig changed: What|Removed |Added CC||[email protected] --- Comment #21 from Jan Kissig --- (In reply to Fridolin Somers from comment #20) > > see "addPrefs" > Sorry I cant find it I was just curious on the discussion on mattermost. I guess that's what it should look like f.e.: addPrefs({'anonPatronId': [% Koha.Preference('AnonymousPatron') ? 1 : 0 %]}) then later compare it via prefs.anonPatronId -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #20 from Fridolin Somers --- > see "addPrefs" Sorry I cant find it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #19 from Katrin Fischer --- Sorry, back to FQA as a question in the Development channel led to some more information: https://chat.koha-community.org/koha-community/pl/wkyk1gcffbfgxysfshhb8khn3w TT vars must now be moved to a separate script tag for serialization see the tree under Bug 41324 There is also a "store" for syspref it's still not in the coding guideline, not everything is pushed yet, but this is the correct way to fix it see "addPrefs" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added Attachment #183258|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 193045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193045&action=edit Bug 4: (follow-up) Use badge to highlight anonymous patron I think a "warning" class is appropriate because we're warning the user that this patron should be treated differently. I trimmed to label to "Anonymous patron" because I don't think the "This is the..." is necessary for a label. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added Attachment #183256|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 193044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193044&action=edit Bug 4: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4
--- Comment #16 from Katrin Fischer ---
I've looked at the code and it seems we never use Koha.Preference with an |
html filter. There are also other occurrence in the code close to this one,
where it doesn't seem to have complained.
[% IF ! open_on_row_click %]
r += ""
+ $patron_to_html(row, {
invert_name: 1, showDiffFirstname: [%
Koha.Preference('ShowPatronFirstnameIfDifferentThanPreferredname') ? 1 : 0 |
html %] }) + "";
[% ELSE %]
r += $patron_to_html(row, {
invert_name: 1, showDiffFirstname: [%
Koha.Preference('ShowPatronFirstnameIfDifferentThanPreferredname') ? 1 : 0 |
html %] });
Patch works, nice little addition- sending this one a level higher up.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Katrin Fischer changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4
--- Comment #15 from Fridolin Somers ---
QA :
Ah maybe "[% Koha.Preference('AnonymousPatron') %]" needs html filter ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Fridolin Somers changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #14 from Fridolin Somers --- (In reply to Lucas Gass (lukeg) from comment #13) > (In reply to Fridolin Somers from comment #12) > > Maybe I should change to use "Patron->is_anonymous" from Bug 40401 > > Do you want to make this change? Or do you like this as is? Ahhh in fact this is not valid, in this JS code we dont have the Koha::Patron object, only the patron id. So lets go with those patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |In Discussion CC||[email protected] --- Comment #13 from Lucas Gass (lukeg) --- (In reply to Fridolin Somers from comment #12) > Maybe I should change to use "Patron->is_anonymous" from Bug 40401 Do you want to make this change? Or do you like this as is? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #12 from Fridolin Somers --- Maybe I should change to use "Patron->is_anonymous" from Bug 40401 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #10 from Fridolin Somers --- Ohhh very nice with badge This feature is new to me : https://getbootstrap.com/docs/4.0/components/badge/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #11 from Owen Leonard --- (In reply to Fridolin Somers from comment #10) > https://getbootstrap.com/docs/4.0/components/badge/ Not that version! This one: https://getbootstrap.com/docs/5.3/components/badge/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 David Nind changed: What|Removed |Added Text to go in the||This enhancement highlights release notes||the anonymous patron using ||a yellow badge in patron ||search results (set using ||the AnonymousPatron system ||preference). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #9 from David Nind --- Created attachment 183263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183263&action=edit Screenshot - using a badge Screenshot showing Owen's alternative patch that uses a yellow badge to highlight the anonymous patron (for the AnonymousPatron system preference). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #8 from David Nind --- (In reply to Owen Leonard from comment #7) > (In reply to David Nind from comment #5) > > So maybe 'Anonymous patron' as a green badge. > > I have attached an opinionated suggestion! Looks great to me Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #7 from Owen Leonard --- (In reply to David Nind from comment #5) > So maybe 'Anonymous patron' as a green badge. I have attached an opinionated suggestion! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #6 from Owen Leonard --- Created attachment 183258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183258&action=edit Bug 4: (follow-up) Use badge to highlight anonymous patron I think a "warning" class is appropriate because we're warning the user that this patron should be treated differently. I trimmed to label to "Anonymous patron" because I don't think the "This is the..." is necessary for a label. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 David Nind changed: What|Removed |Added Attachment #183063|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 183256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183256&action=edit Bug 4: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #5 from David Nind --- (In reply to Fridolin Somers from comment #3) > > Display uses class 'circ-hlt' to show bold red text. > Maybe there is a better way for that. > Its is open to discussion ;) Maybe an option is a green badge like the one used to show the default SMTP server (Koha administration > Additional parameters > SMTP servers: add a new server and set as default, in the 'Is default' column there is a green badge with 'Default'). This was added in Bug 37311. So maybe 'Anonymous patron' as a green badge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #3 from Fridolin Somers --- > Display uses class 'circ-hlt' to show bold red text. Maybe there is a better way for that. Its is open to discussion ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #2 from Fridolin Somers --- Created attachment 183064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183064&action=edit Screenshot with patch Screenshot with patch on koha-testing-docker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 --- Comment #1 from Fridolin Somers --- Created attachment 183063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183063&action=edit Bug 4: Show that a patron is the anonymous in patrons search Show patron is the anonymous in patrons search. Display uses class 'circ-hlt' to show bold red text. Can be hidden using class 'patron_is_anonymous'. Test plan : 1) Create a new user "John Doe" 2) Add its borrowernumber in system preference 'AnonymousPatron' 3) Perform a search on letter 'd' 4) Check you see in table a text 'This is the anonymous patron' only on this patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40000] Show that a patron is the anonymous in patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4 Fridolin Somers changed: What|Removed |Added Summary|Show patron is the |Show that a patron is the |anonymous in patrons search |anonymous in patrons search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
