[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-07-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||[email protected]
   ||m
 Version(s)|25.11.00,25.05.01   |25.11.00,25.05.01,24.11.08
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 24.11.x for 24.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-07-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks||40444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444
[Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-07-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks|25515   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515
[Bug 25515] [OMNIBUS] Remove warnings and errors from tests output
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Paul Derscheid  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 Version(s)|25.11.00|25.11.00,25.05.01
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

--- Comment #7 from Paul Derscheid  ---
Nice work everyone!

Pushed to 25.05.x for 25.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

--- Comment #6 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to main for 25.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||25.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Marcel de Rooy  changed:

   What|Removed |Added

 CC||[email protected]
 QA Contact|[email protected] |[email protected]
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-06-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #182868|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 183047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183047&action=edit
Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t

Because we still use CGI::Session (bug 17427), we need to mock
CGI::Session to remove those 2 warnings
rollback ineffective with AutoCommit enabled

Test plan:
Run the tests after this patch, it should be green

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

David Nind  changed:

   What|Removed |Added

 Attachment #182823|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 182868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182868&action=edit
Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t

Because we still use CGI::Session (bug 17427), we need to mock
CGI::Session to remove those 2 warnings
rollback ineffective with AutoCommit enabled

Test plan:
Run the tests after this patch, it should be green

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

David Nind  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #4 from David Nind  ---
Testing notes (using KTD):

1. Tests pass before and after the patch: prove
t/db_dependent/Koha/Template/Plugin/Koha.t 

2. Before the patch, there are warnings:

prove t/db_dependent/Koha/Template/Plugin/Koha.t 
t/db_dependent/Koha/Template/Plugin/Koha.t .. rollback ineffective with
AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773.
t/db_dependent/Koha/Template/Plugin/Koha.t .. 1/2 rollback ineffective with
AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773.
t/db_dependent/Koha/Template/Plugin/Koha.t .. ok   
All tests successful.
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.97 cusr  0.16
csys =  1.16 CPU)
Result: PASS

3. After the patch, there are no warnings:

rove t/db_dependent/Koha/Template/Plugin/Koha.t 
t/db_dependent/Koha/Template/Plugin/Koha.t .. rollback ineffective with
AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773.
t/db_dependent/Koha/Template/Plugin/Koha.t .. 1/2 rollback ineffective with
AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1773.
t/db_dependent/Koha/Template/Plugin/Koha.t .. ok   
All tests successful.
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.97 cusr  0.16
csys =  1.16 CPU)
Result: PASS

4. I tested on the latest main.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #182822|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  ---
Created attachment 182823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182823&action=edit
Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t

Because we still use CGI::Session (bug 17427), we need to mock
CGI::Session to remove those 2 warnings
rollback ineffective with AutoCommit enabled

Test plan:
Run the tests after this patch, it should be green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

--- Comment #1 from Jonathan Druart  ---
Created attachment 182822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182822&action=edit
Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t

Because we still use CGI::Session (bug 17427), we need to mock
CGI::Session to remove those 2 warnings
rollback ineffective with AutoCommit enabled

Test plan:
Run the tests after this patch, it should be green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 40018] Remove warning from Koha/Template/Plugin/Koha.t

2025-05-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40018

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/