[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #50 from Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/css/edifact_interchange-rtl.css koha-tmpl/intranet-tmpl/prog/css/edifact_interchange.css must be added to .gitignore -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #49 from Martin Renvoize (ashimema) --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Version(s)||26.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #48 from Martin Renvoize (ashimema) --- Created attachment 196040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196040&action=edit Bug 40383: (follow-up) Add nonce attribute to inline script in basket.tt Patch from commit e48bfc1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #196039|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #47 from Martin Renvoize (ashimema) --- Created attachment 196039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196039&action=edit Bug 40383: (follow-up) Add nonce attribute to inline script in basket.tt Patch from commit b3b71ba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #46 from Martin Renvoize (ashimema) --- Created attachment 196038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196038&action=edit Bug 40383: (follow-up) Address code review concerns - Move TT interface/theme variables into a separate
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #45 from Martin Renvoize (ashimema)
---
Created attachment 196037
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196037&action=edit
Bug 40383: (QA follow-up) Update Cypress tests to follow current best practices
Remove before()/after() DB hooks — all assertions already use cy.intercept
mocks so no real database messages are needed. Extract repeated button
injection into an openEDIModal() helper. Replace all cy.wait(N) fixed-time
waits with assertion-based waits and cy.wait('@alias') for network sync.
Fix a Bootstrap 5 race condition in the modal-close cleanup test where
hidden.bs.modal fired after the backdrop animation, causing the re-opened
modal's focus class to be removed mid-test.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #44 from Martin Renvoize (ashimema) --- Created attachment 196036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196036&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #43 from Martin Renvoize (ashimema) --- Created attachment 196035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196035&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #42 from Martin Renvoize (ashimema)
---
Created attachment 196034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196034&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #41 from Martin Renvoize (ashimema) --- Created attachment 196033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196033&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #193060|0 |1 is obsolete|| Attachment #194327|0 |1 is obsolete|| Attachment #194328|0 |1 is obsolete|| Attachment #194329|0 |1 is obsolete|| Attachment #194330|0 |1 is obsolete|| Attachment #194331|0 |1 is obsolete|| Attachment #194963|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Text to go in the||The EDIFACT message viewer release notes||has been significantly ||improved with a new ||interactive modal interface ||replacing the previous ||basic display. || ||New features: || || - Tree view — ||Collapsible, hierarchical ||display of EDIFACT ||interchange structure with ||segment tagging || - Raw view — Plain-text ||fallback for direct ||inspection of message ||content || - Search — Real-time ||search with regex support, ||result count, and ||previous/next navigation || - Focus mode — Highlights ||segments relevant to the ||current context (basket or ||invoice) when opened from ||those pages || - JSON download — New ||?format=json endpoint on ||edimsg.pl and download ||button for programmatic ||access and debugging; ||backed by a new to_json() ||method on Koha::Edifact -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #40 from Martin Renvoize (ashimema) --- Good catches, thanks for the review Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #39 from Martin Renvoize (ashimema) --- Created attachment 194963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194963&action=edit Bug 40383: (follow-up) Address code review concerns - Move TT interface/theme variables into a separate
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|42001 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42001 [Bug 42001] Add duplicate purchase order number detection on EDI quote import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||42001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42001 [Bug 42001] Add duplicate purchase order number detection on EDI quote import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #38 from Jonathan Druart ---
+const escapeHtml = str => {
We already have String.prototype.escapeHtml in staff-global.js
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #37 from Jonathan Druart --- There are actually used in other .js files. I would suggest to move them into a separate script tag: const interface = "[% interface | html %]"; const theme = "[% theme | html %]"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #36 from Jonathan Druart --- (In reply to Martin Renvoize (ashimema) from comment #33) > Created attachment 194329 [details] [review] > Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch adds TT tags within script tags. +var interface = "[% interface | html %]"; +var theme = "[% theme | html %]"; It seems that those 2 variables are not used anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Depends on||38689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 [Bug 38689] EDIFACT errors should log to a staff accessible location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #35 from Martin Renvoize (ashimema)
---
Created attachment 194331
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194331&action=edit
Bug 40383: (QA follow-up) Update Cypress tests to follow current best practices
Remove before()/after() DB hooks — all assertions already use cy.intercept
mocks so no real database messages are needed. Extract repeated button
injection into an openEDIModal() helper. Replace all cy.wait(N) fixed-time
waits with assertion-based waits and cy.wait('@alias') for network sync.
Fix a Bootstrap 5 race condition in the modal-close cleanup test where
hidden.bs.modal fired after the backdrop animation, causing the re-opened
modal's focus class to be removed mid-test.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #34 from Martin Renvoize (ashimema) --- Created attachment 194330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194330&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #33 from Martin Renvoize (ashimema) --- Created attachment 194329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194329&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #32 from Martin Renvoize (ashimema)
---
Created attachment 194328
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194328&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #31 from Martin Renvoize (ashimema) --- Created attachment 194327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194327&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #193059|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #193058|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #193057|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #30 from Martin Renvoize (ashimema) --- Ah yes.. these were probably some of the first Cypress tests I wrote.. I'll have a little dig -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #29 from Lucas Gass (lukeg) --- The cypress tests don't pass for me. Also, I see quite a bit of cy.wait(1000). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected], ||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #28 from Kyle M Hall (khall) --- Created attachment 193060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193060&action=edit Bug 40383: Tidy t/Edifact.t for QA script Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #27 from Kyle M Hall (khall) --- Created attachment 193059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193059&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #26 from Kyle M Hall (khall) --- Created attachment 193058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193058&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #25 from Kyle M Hall (khall) ---
Created attachment 193057
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193057&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Attachment #192530|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Attachment #192529|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Attachment #192528|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Attachment #192527|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #24 from Martin Renvoize (ashimema) --- Just another rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #23 from Martin Renvoize (ashimema) --- Created attachment 192530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192530&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #22 from Martin Renvoize (ashimema) --- Created attachment 192529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192529&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #21 from Martin Renvoize (ashimema)
---
Created attachment 192528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192528&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #20 from Martin Renvoize (ashimema) --- Created attachment 192527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192527&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #189578|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #189577|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #189576|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #189575|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off Comma delimited||Martin Renvoize list of Sponsors|| Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||41297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41297 [Bug 41297] Add duplicate invoice number detection on EDI invoice import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188580|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize (ashimema) --- Created attachment 189578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189578&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188579|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize (ashimema) --- Created attachment 189577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189577&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
Martin Renvoize (ashimema) changed:
What|Removed |Added
Attachment #188578|0 |1
is obsolete||
--- Comment #17 from Martin Renvoize (ashimema)
---
Created attachment 189576
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189576&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188577|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize (ashimema) --- Created attachment 189575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189575&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #15 from Martin Renvoize (ashimema) --- Test plan fun.. thanks for looking Kyle. Should all apply again now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #187561|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize (ashimema) --- Created attachment 188580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188580&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #187560|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize (ashimema) --- Created attachment 188579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188579&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
Martin Renvoize (ashimema) changed:
What|Removed |Added
Attachment #187559|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize (ashimema)
---
Created attachment 188578
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188578&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #187558|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 188577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188577&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Bug 40383 depends on bug 40174, which changed state. Bug 40174 Summary: Add a way to cleanly insert data in DB from Cypress tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40174 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Kyle M Hall (khall) changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #184489|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize (ashimema) --- Created attachment 187560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187560&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
Martin Renvoize (ashimema) changed:
What|Removed |Added
Attachment #184488|0 |1
is obsolete||
--- Comment #7 from Martin Renvoize (ashimema)
---
Created attachment 187559
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187559&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
Signed-off-by: Hannah Dunne-Howrie
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #184487|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize (ashimema) --- Created attachment 187558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187558&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize (ashimema) --- Hannah and I have been using this for debugging messages on their live system. It's gone a long way to making EDI message more understandable and accessible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #184490|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 187561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187561&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run Signed-off-by: Hannah Dunne-Howrie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||32938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32938 [Bug 32938] Acquisitions EDI - ORDRSP messages are loaded as invoices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #5 from Martin Renvoize (ashimema) --- Created attachment 184490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184490&action=edit Bug 40383: Add Cypress test coverage for EDIFACT modal This patch adds end-to-end testing for the EDIFACT modal interface, providing coverage of all user interactions and functionality. **Test Coverage:** - Modal display and initialization with proper Bootstrap navbar structure - View toggle functionality between tree and raw display modes - Search functionality including navigation, result counting, and highlighting - Focus functionality for basket and invoice contexts - Error handling for invalid message IDs and network failures - Accessibility features including keyboard navigation - Responsive behavior and modal interaction patterns **Test Plan:** 1. Apply patch 2. Ensure KTD environment is running with test data 3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"` 4. **Verify Test Results:** 5. **Manual Verification:** - All test scenarios reflect real user workflows - Test data requirements are clearly documented in spec file - Test data is cleaned up after the tests are run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #4 from Martin Renvoize (ashimema) --- Created attachment 184489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184489&action=edit Bug 40383: Enhanced EDIFACT message modal with search and focus functionality This patch completely rebuilds the EDIFACT message modal interface, featuring: **Core Features:** - Modern Bootstrap 5 navbar with integrated search functionality - Tree view and raw view display modes for message structure - Real-time search with regex support and result navigation - Smart focus functionality that highlights relevant segments based on context (basket, invoice) **User Interface:** - Bootstrap navbar between modal header and body - Search form with previous/next navigation and live result counts - Clean separation between always-visible controls and view-specific toolbars - Accessibility conscious with proper ARIA labels and semantic markup - Streamlined DOM structure with direct modal-body scrolling **Test Plan:** 1. Apply patch and run: yarn css:build to compile SCSS 2. Navigate to Acquisitions > EDIFACT messages 3. Click "View message" on any EDIFACT message 4. **Modal Display Testing:** - Verify modal opens with Bootstrap navbar between header and body - Confirm tree view is active by default with segment structure visible - Click raw view button to verify plain text display - Test modal responsiveness by resizing window 5. **Search Functionality Testing:** - Enter "UNH" in search field, verify navbar shows result count - Use previous/next buttons to navigate between results - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found - Verify native browser clear button appears and works - Test case-insensitive search behavior 6. **Focus Functionality Testing:** - From basket page, click enhanced view link - should highlight relevant segments - From invoice page, click enhanced view - should focus on invoice-related segments - Verify focus highlighting persists during search operations 7. **Error Handling Testing:** - Test with invalid message ID, verify error display - Test network errors, confirm loading states work properly 8. **Accessibility Testing:** - Verify keyboard navigation works with search controls - Test screen reader compatibility with ARIA labels - Confirm modal can be closed with Escape key -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383
--- Comment #3 from Martin Renvoize (ashimema)
---
Created attachment 184488
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184488&action=edit
Bug 40383: Add JSON representation to Koha::Edifact and JSON download to
edimsg.pl
This patch implements a JSON representation of EDIFACT interchanges for
enhanced
programmatic access and debugging capabilities.
Backend Changes:
- Add to_json() method to Koha::Edifact module
- Structured JSON output with header, messages array, and trailer
- Segment parsing with raw data, elements arrays, and line_id tracking
- Line item grouping using LIN segment identifiers
Frontend Changes:
- Add JSON download button to edimsg.pl page
- Support for ?format=json parameter and Accept: application/json header
- Proper HTTP content-type handling for JSON responses
- Error handling for missing messages in JSON format
JSON Structure:
{
"header": "UNB+UNOC:3+...",
"messages": [
{
"header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
"segments": [
{
"tag": "LIN",
"raw": "LIN+1+1+9780552150040:EN'",
"elements": ["1", "1", "9780552150040:EN"],
"line_id": "1"
}
],
"trailer": "UNT+25+1'"
}
],
"trailer": "UNZ+1+1'"
}
Test plan:
1. Apply this patch
2. Ensure you have EDIFACT messages in your system
3. Go to Acquisitions > EDIFACT messages
4. Click "View message" for any message
5. Click the new "JSON" button
6. Verify JSON downloads with proper structure
7. Verify direct URL access with ?format=json parameter works
8. Test with Accept: application/json header
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #2 from Martin Renvoize (ashimema) --- Created attachment 184487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184487&action=edit Bug 40383: Add unit tests for Koha::Edifact to_json method This patch adds unit tests for the new to_json method being introduced in Koha::Edifact module in the next patch. The tests verify: - JSON output generation and validity - Proper structure with header, messages, and trailer fields - Message array structure with correct number of messages - Individual message structure (header, segments, trailer) - Segment data integrity including raw data and elements arrays - Line ID functionality for related segments (LIN, QTY, PRI, PIA) Test plan: 1. Apply this patch and the next one 2. Run: prove t/Edifact.t 3. Verify all 63 tests pass 4. Confirm the new JSON-related tests (22 tests) execute successfully Sponsored-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Depends on||40174 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40174 [Bug 40174] Add a way to cleanly insert data in DB from Cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Depends on||20253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20253 [Bug 20253] Optionally use buyer's purchase order number from EDIFACT quote in basket name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 --- Comment #1 from Martin Renvoize (ashimema) --- Created attachment 184185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184185&action=edit Preview -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 40383] Modernise the EDIFACT Message display modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 Martin Renvoize (ashimema) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
