https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #84 from Marcel de Rooy ---
As referred to on IRC by Jonathan:
===
Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does
exactly the same thing. So maybe "is_cancelable" is too specific?
What could
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--- Comment #83 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #82 from Jonathan Druart
---
WARNING: I have rebased bug 19301 on top of this one to avoid a rebase, but if
this is not unblocked quickly I am going to rebase bug 19301 against master
instead!
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Maksim changed:
What|Removed |Added
CC||maksim@inlibro.com
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |BLOCKED
--- Comment #81 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #80 from Alex Arnaud ---
(In reply to Jonathan Druart from comment #77)
>
> I am pretty sure something is wrong.
As already asked by Marcel, can you give me more explanation about what is
wrong?
Otherwise, i renamed has
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #79 from Alex Arnaud ---
Created attachment 70457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70457&action=edit
Bug 4319 - [QA follow-up] Rename hasItemswaitingOrInTransit to
has_items_waiting_or_intr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #78 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #77)
> Also, when I see:
> @@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest {
>
> }
>
> return $any_availa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #77 from Jonathan Druart
---
Also, when I see:
@@ -1141,18 +1141,9 @@ sub IsAvailableForItemLevelRequest {
}
return $any_available ? 0 : 1;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #75 from Jonathan Druart
---
Comment on attachment 69815
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815
Bug 4319: [OPAC] Allow holds on waiting/transit items
Review of attachment 69815:
-->
(ht
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jonathan Druart changed:
What|Removed |Added
Blocks||19301
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #74 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #73)
> QA Comment:
> The POD statement is adjusted. Imo the POD should get some more attention.
> No blocker.
This is about the POD of IsAvailableForIte
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #72 from Marcel de Rooy ---
Created attachment 69817
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69817&action=edit
Bug 4319: (QA follow-up) Use ReservableItems in all scripts
[1] Call CountItemsIssue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #71 from Marcel de Rooy ---
Created attachment 69816
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69816&action=edit
Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest
[1] For consi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #73 from Marcel de Rooy ---
QA Comment:
Thanks Alex for your perseverance. I am addressing your question from comment60
here too.
Putting this on top of sec report 19319 which does some changes to
Koha::Biblios->find in de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Marcel de Rooy changed:
What|Removed |Added
Attachment #69724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
Sta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Marcel de Rooy changed:
What|Removed |Added
Depends on||19319
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #69 from Marcel de Rooy ---
QA: Looking here again
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #68 from Alex Arnaud ---
@Marcel: did you read my question on Comment 60 ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #67 from Marcel de Rooy ---
(In reply to Jon Knight from comment #66)
> Ah, sorry it was a sign off from applying the bugs using git bz as normal,
> so I'd not noticed it only included one. Should be a complete sign off.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #66 from Jon Knight ---
Ah, sorry it was a sign off from applying the bugs using git bz as normal, so
I'd not noticed it only included one. Should be a complete sign off.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jon Knight changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #65 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #64 from Marcel de Rooy ---
(In reply to Jon Knight from comment #63)
> Created attachment 69728 [details] [review]
> Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit
>
> Signed-off-by: Jon Knight
Jon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Jon Knight changed:
What|Removed |Added
Attachment #69725|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Alex Arnaud changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Alex Arnaud changed:
What|Removed |Added
Attachment #68786|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #62 from Alex Arnaud ---
Created attachment 69725
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69725&action=edit
Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
--- Comment #60 from Alex Arnaud ---
(In reply to Marcel de Rooy from comment #56)
> It would be more consistent if we should use IsItemOnHoldAndFound in
> IsAvailableForItemLevelRequest instead of a Koha::Holds->search. We actually
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
Alex Arnaud changed:
What|Removed |Added
Summary|waiting items cannot be |waiting and in transit
34 matches
Mail list logo
