[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Joy Nelson changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||j...@bywatersolutions.com --- Comment #24 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #23 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #22 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #18) > I am not in favor of relying on JavaScript here - so I am proposing a > follow-up that uses checks on TT level instead. Could you have a look > Aleisha or David? Looks good Katrin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #20 from Owen Leonard --- Created attachment 99005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99005&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #21 from Owen Leonard --- Created attachment 99006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99006&action=edit Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Owen Leonard changed: What|Removed |Added Attachment #98972|0 |1 is obsolete|| Attachment #98973|0 |1 is obsolete|| Attachment #98974|0 |1 is obsolete|| --- Comment #19 from Owen Leonard --- Created attachment 99004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99004&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #18 from Katrin Fischer --- I am not in favor of relying on JavaScript here - so I am proposing a follow-up that uses checks on TT level instead. Could you have a look Aleisha or David? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #17 from Katrin Fischer --- Created attachment 98974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98974&action=edit Bug 6508: (follow-up) Remove dependency on jquery for check in templates Should work as before with the test plan from the second patch. But removes the added jQuery display control code in favor of checking if fines is set on template level. For several patrons with and without fines and with credits: - Check the Fines & Charges only display when there is something to see -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Attachment #98810|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 98973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98973&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Attachment #98809|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 98972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98972&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What|Removed |Added Attachment #98786|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 98809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98809&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What|Removed |Added Attachment #98787|0 |1 is obsolete|| --- Comment #14 from David Nind --- Created attachment 98810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98810&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #12 from Aleisha Amohia --- Created attachment 98787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98787&action=edit Bug 6508: (follow-up) Change layout of price and hide tab if no fines With this patch, the tab will not show if there are no fines. I've also changed how the fines look in the tab header to look more like the OPAC fines tab. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Aleisha Amohia changed: What|Removed |Added Attachment #94601|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 98786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98786&action=edit Bug 6508: Add balance to `Fines & Charges` tab Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #10 from Martin Renvoize --- +1 to just getting rid of it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #9 from Séverine Queune --- (In reply to Katrin Fischer from comment #8) > I agree with Martin that this doesn't add any additional information. > Does this tab really needs to be kept ? As Katrin said, it the only page where it's display, and we have and alert at the top of the page showing the total amount of charges, with 2 useful action buttons. Isn't that enough ? > I have another suggestion: We could only show the tab when there are any > fines and charges. > This way, for libraries not using fines it will be a nicer display and the > tab appearing will have a meaning. > +1 if the tab is kept ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #8 from Katrin Fischer --- I agree with Martin that this doesn't add any additional information. I have another suggestion: We could only show the tab when there are any fines and charges. This way, for libraries not using fines it will be a nicer display and the tab appearing will have a meaning. I've also noticed that we only show the tab on details, but not on the checkouts tab. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #7 from Martin Renvoize --- Well.. this patch adds the detail into the tab as requested.. however I'm really not sure what the point of that tab is at all now.. all it displays when clicked is this exact information.. did it show a table of charges in there at some point perhaps? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #6 from Martin Renvoize --- Created attachment 94601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94601&action=edit Bug 6508: Add balance to `Fines & Charges` tab -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us --- Comment #5 from Brian --- Any Updates on bug 6508 Carnegie team -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer changed: What|Removed |Added Summary|Enhancement: Additional |Show indication of existing |Information on the Fines & |'Fines & Charges' on tab of |Charges Tab in the Patron |the same name |Details of Staff Client | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
