[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #56 from Andrew Fuerste-Henry  ---


*** This bug has been marked as a duplicate of bug 27058 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27058

--- Comment #55 from Joonas Kylmälä  ---
Hi,

could you please see bug 27058. I had worked on the same issue before and
didn't notice this bug report until now. I have a unit test there too but the
bug report is only about on shelf holds = 2 / If all unavailable. There is no
syspref for it because the syspref is needed only for the "If any unavailable"
case which is more complex. For If all unavailable case the current behaviour
is *definitely buggy* because it breaks holds when there is a ordered item,
leading to a situation where there is no item available for the patron to
checkout and no way for the library staff or patron themselves to place a hold
to the book. This leads to a situation where all Koha libraries using If all
unavailable need to keep a separate list of holds in "paper notes" or just say
to the patron "sorry, come back later" which could be years for popular books.
If you don't have any items available for checkout it is clear that a hold must
be able to be placed if it it normally would be the case without ordered items
(because you can't checkout ordered items because they don't exists yet).

I have spend multiple hours thinking the scenarios carefully through,
understanding the incorrectly grouped and named functions in C4/Reserves.pm,
discussed this problem with 5 different libraries so I ask you also to read the
code carefully when reviewing bug 27058. One important thing is that
ItemsAnyAvailableAndNotRestricted() is actually two different functions: 1) Do
basic checkout availability checks that are not specific to the patron 2) Do
basic reservability checks to accomodate hold groups or rules regarding from
which branch patron can reserve book (CanItemBeReserved()). So please don't let
the incorrectly named function names to stop fixing this bug.

There are a lot of other issues around IsAvailableForItemLevelRequest and
CanItemBeReserved functions but please let's keep the scope on this particular
issue, and on If all unavailable case only in bug 27058. In Bug 27032 I start
to refactor these hard-to-understand pieces of code (and yes CanBookBeRenewed
has ties to ItemsAnyAvailableAndNotRestricted...).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Failed QA

--- Comment #54 from Martin Renvoize  ---
Sorry.. but I'm not seeing any Unit Tests... so failing QA for that.

As a side note.. I think I would have preferred to see a new method
'CountItemsOrdered' as opposed to adding logic into 'CountItemsIssued' as it
makes the methods purpose less well defined/clear.  It could, of course, be
entirely differently named or in the Koha::Object world perhaps be a chainable
filter on an Koha::Items's set?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #105390|0   |1
is obsolete||

--- Comment #53 from Andrew Fuerste-Henry  ---
Created attachment 105474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105474=edit
Bug 6918: Add syspref

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #51 from Andrew Fuerste-Henry  ---
Test plan:

1: Apply patch, updatedatabase, restart all
2: Set AllowOnOrderOnShelfHolds to Allow
3: Set relevant circ rule to allow onshelf holds If Any Unavailable
4: Find a bib with 2 items, one available and one on-order
5: Confirm that you can place hold on bib or on-order item
5: set circ rule to On Shelf Holds = If All Unavailable
6: confirm no holds can be placed
7: set circ rule to On Shelf Holds = Yes
8: confirm you can place hold on bib or either item
9 Set AllowOnOrderOnShelfHolds to Don't Allow
10: confirm circ rule still set to On Shelf Holds = Yes
11: confirm you can place hold on bib or either item
12: Set relevant circ rule to allow onshelf holds If Any Unavailable
13: Confirm no holds can be placed
14: set circ rule to On Shelf Holds = If All Unavailable
15: confirm no holds can be placed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103179|0   |1
is obsolete||

--- Comment #52 from Andrew Fuerste-Henry  ---
Created attachment 105473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105473=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #50 from Kyle M Hall  ---
Created attachment 105390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105390=edit
Bug 6918: Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #49 from Katrin Fischer  ---
Personally I think this is a bug that hasn't been fixed in an awfully long time
- maybe because use of "AllowOnShelfHolds = yes" is the more common choice.

But I'd be ok with a preference if this means we can move this forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #48 from Marcel de Rooy  ---
Not sure this is a In discussion or a Failed QA.
But the report dates from 2011 and the patch from 2013, so there must be a
reason why this took so long.
The first comments says "This may require a pref" too.
Since we are used now to the current behavior since 2011/2013, I think we
cannot revert behavior without a pref.

Changing status

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Keywords|Academy |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103175|0   |1
is obsolete||

--- Comment #47 from Andrew Fuerste-Henry  ---
Created attachment 103179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103179=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #46 from Andrew Fuerste-Henry  ---
Test plan:
1 find a record with two items
2 set one item to On Order (or any other negative Not For Loan value)
3 set circ rule to On Shelf Holds = Yes
4 confirm bib and either item can be held
5 set circ rule to On Shelf Holds = In Any Unavailable
6 confirm bib and on order item can be held, available item cannot be held
7 set circ rule to On Shelf Holds = If All Unavailable
8 confirm bib and both items cannot be held
9 check out the item with notforloan=0
10 confirm bib and all items now able to be held

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #103021|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall  ---
Created attachment 103175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103175=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #44 from Andrew Fuerste-Henry  ---
If All Unavailable still isn't quite right. Backing up:
If On Shelf Holds is set to Yes, you should be able to place holds on all
items, regardless of whehter or not they're on order.

If On Shelf Holds is set to If Any Unavailable, you should be able to place
holds on items marked On Order, but not on items where notforloan=0.

If On Shelf Holds is set to If All Unavailable, you should be able to place
holds on items marked On Order only if *all* items on the bib have
notforloan!=0, are checked out, or are otherwise not available for checkout. So
if I have 1 item that's currently checked out and one that marked On Order, I
should be able to place a hold on either.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #103020|0   |1
is obsolete||

--- Comment #43 from Kyle M Hall  ---
Created attachment 103021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103021=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #103016|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall  ---
Created attachment 103020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103020=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #41 from Kyle M Hall  ---
(In reply to Andrew Fuerste-Henry from comment #40)
> With On Shelf Holds set to If Any Unavailable, I'm seeing the correct
> behavior. I can place holds on items with a negative NotForLoan value but
> not on items with positive or zero NotForLoan values. Yay!
> 
> However, if I change my rule to If All Unavailable and set all of the items
> on my bib to NotForLoan=-1, I am not allowed to place a hold. I should be
> allowed to do so.

I wasn't sure about that scenario. Thanks for the clarity!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #40 from Andrew Fuerste-Henry  ---
With On Shelf Holds set to If Any Unavailable, I'm seeing the correct behavior.
I can place holds on items with a negative NotForLoan value but not on items
with positive or zero NotForLoan values. Yay!

However, if I change my rule to If All Unavailable and set all of the items on
my bib to NotForLoan=-1, I am not allowed to place a hold. I should be allowed
to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #102998|0   |1
is obsolete||

--- Comment #39 from Kyle M Hall  ---
Created attachment 103016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103016=edit
Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #38 from Andrew Fuerste-Henry  ---
Just gave this a try and the hold was still blocked. Elaborating a bit on the
test plan:
- apply patch
- set On Shelf Holds to If Any Unavailable
- verify you have a NotForLoan authorised value with a negative number for
Ordered. The default data set uses -1
- grab a bib with two items, neither checked out, one set to NotForLoan=0 the
other Notforloan=-1
- attempt to place hold
- should be blocked from holding item 1, allowed to hold item 2

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70232|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall  ---
Created attachment 102998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102998=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

jmbroust  changed:

   What|Removed |Added

 CC||jean-manuel.broust@univ-lyo
   ||n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Katrin Fischer  changed:

   What|Removed |Added

Summary|can't place holds on 'on|Can't place holds on 'on
   |order' items with   |order' items with
   |AllowOnShelfHolds off   |AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #36 from Katrin Fischer  ---
Ordered should be -1 if the sample data was used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #35 from Kyle M Hall  ---
(In reply to Zoe Bennett from comment #34)
> I tested the patch by setting On Shelf Holds to "If all unavailable" and
> then "If any unavailable". I set 7-Not for Loan to 'ordered' and was still
> unable to place a hold on the order.

What is the value of your "On order" status? It needs to be a negative number.
In Koha this indicates that the item will be available for loan in the future.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Zoe Bennett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||zoebennett1...@gmail.com

--- Comment #34 from Zoe Bennett  ---
I tested the patch by setting On Shelf Holds to "If all unavailable" and then
"If any unavailable". I set 7-Not for Loan to 'ordered' and was still unable to
place a hold on the order.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
   Keywords||Academy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68934|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 70232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70232=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #32 from Alex Buckley  ---
There's a unnecessary bracket in line 677 of opac-search.pl:

syntax error at /home/vagrant/kohaclone/opac/opac-search.pl line 677, near ")
)"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68898|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 68934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68934=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #30 from Dominic Pichette  ---
I did a reset --hard on origin/master and still have the same error than
Simon..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #29 from Jonathan Druart  
---
Simon, make sure your branch is up-to-date with origin/master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #28 from Simon Pouchol  ---
Hey Jonathan,
It seems to me the patch isn't applying :
Applying: Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #27 from Jonathan Druart  
---
Patch rebased and rewritten, please test.

Srdjan's concern is not valid IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19087|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 68898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68898=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #25 from Katrin Fischer  ---
I seem to remember that I had tested it at some point and the system had
allowed holds on the negative notforloan values. Wondering now if it something
changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #24 from Jessie Zairo  ---
If a library sets their On Shelf Holds to "If all unavailable" or "If any
unavailable" patrons cannot place holds on items that are marked 'on order'
(not for loan=-1). 

Libraries would like to have the option to make the system allow holds on items
with -1 for notforloan so patrons can place holds on "ordered" items.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #23 from Katrin Fischer  ---
This is still a desirable feature, but the existing patch is quite old and
possibly needs a more or less complete rewrite:

Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
Auto-merging opac/opac-detail.pl
CONFLICT (content): Merge conflict in opac/opac-detail.pl
Auto-merging opac/opac-MARCdetail.pl
CONFLICT (content): Merge conflict in opac/opac-MARCdetail.pl
Auto-merging opac/opac-ISBDdetail.pl
CONFLICT (content): Merge conflict in opac/opac-ISBDdetail.pl
CONFLICT (modify/delete): C4/VirtualShelves/Page.pm deleted in HEAD and
modified in Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off. Version Bug 6918 - can't place holds on 'on order' items
with AllowOnShelfHolds off of C4/VirtualShelves/Page.pm left in tree.
Auto-merging C4/Reserves.pm
CONFLICT (content): Merge conflict in C4/Reserves.pm
Auto-merging C4/Biblio.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off
...

Can we move this back to NEW?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #22 from Christopher Brannon cbran...@cdalibrary.org ---
(In reply to Katrin Fischer from comment #21)
 Hi Kyle, could you take a look at Srdjan's comment?

I'm moving this to discussion until Srdjan's comment is addressed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle, could you take a look at Srdjan's comment?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #20 from Christopher Brannon cbran...@cdalibrary.org ---
Kyle,
This patch seems to fix more than just the ability to place a hold on an On
Order item.  It appears that prior to the patch, one could not place a hold any
any available item if at least the first item was setup as On Order and
theAllowOnShelfHolds is set to Don't Allow.  So, it seems you fixed more than
you stated.  Good work.

Christopher

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot|2013-09-29 00:00:00 |2013-10-25
last check this||

--- Comment #19 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-09-29
last check this||

--- Comment #18 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #17 from Srdjan Jankovic srd...@catalyst.net.nz ---
I don't think adding a flag warrants changing CountItemsIssued() interface that
much, ie I believe in this case CountItemsIssued($biblionumbe,
$include_on_order) is a better solution.
A test would be nice to have too, but not that fussed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #15077|0   |1
is obsolete||

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19087
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19087action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Owen Leonard oleon...@myacpl.org ---
Needs a test plan.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14451|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 15077
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15077action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #13 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #12)
 4) Attempt to place a hold on the item, you should now be able to do so

I see that this patch affects several scripts. Should one test placing a hold
from multiple pages or in multiple ways?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
I changed the prototype for CountItemsIssued, so I had to update all calls to
it. Still, it wouldn't hurt to test in multiple ways.

Kyle

(In reply to comment #13)
 (In reply to comment #12)
  4) Attempt to place a hold on the item, you should now be able to do so
 
 I see that this patch affects several scripts. Should one test placing a
 hold from multiple pages or in multiple ways?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14390|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14451
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14451action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Jonathan, here is a variation that keeps the code from being repeated multiple
times. It also takes care of your issues in comment 8.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com ---
The revised patch needs to be QAed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14158|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14390
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14390action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Koha documenation suggests that NOT_LOAN values less than 0 should be
hold-able. This patch enables that.

From the manual:
Negative number values will still allow holds (use for on order statuses for
example)
where as positive numbers will not allow holds or checkouts

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Works as expected

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
That was my first instinct as well, but the way the scripts work, it didn't
'fit' in that function. In fact, that function doesn't deal with items statuses
at all! IsAvailableForItemLevelRequest actually deals with the status so that
was where the changes needed to be made.

I have implemented your optimization for the return value.

Kyle

(In reply to comment #4)
 QA Comments:
 
 I am not sure at all but the check on the notforloan value should not be
 made in the CanItemBeReserved routine ? Is not it more relevant ?
 
 If not, your patch has to be resubmitted for a little modification.
 
 The test in IsAvailableForItemLevelRequest is:
 
   return ($available_per_item and ($item-{onloan} or
 GetReserveStatus($itemnumber) eq W or $item-{notforloan}  0));
 
 it will be optimized if you change the order, as:
 
   return ($available_per_item and ($item-{onloan} or $item-{notforloan} 
 0 or GetReserveStatus($itemnumber) eq W ));
 
 Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comments:

I am not sure at all but the check on the notforloan value should not be made
in the CanItemBeReserved routine ? Is not it more relevant ?

If not, your patch has to be resubmitted for a little modification.

The test in IsAvailableForItemLevelRequest is:

  return ($available_per_item and ($item-{onloan} or
GetReserveStatus($itemnumber) eq W or $item-{notforloan}  0));

it will be optimized if you change the order, as:

  return ($available_per_item and ($item-{onloan} or $item-{notforloan}  0
or GetReserveStatus($itemnumber) eq W ));

Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #14152|0   |1
is obsolete||

--- Comment #3 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 14158
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14158action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Koha documenation suggests that NOT_LOAN values less than 0 should be
hold-able. This patch enables that.

From the manual:
Negative number values will still allow holds (use for on order statuses for
example)
where as positive numbers will not allow holds or checkouts

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Works as expected

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14004|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14152
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14152action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Koha documenation suggests that NOT_LOAN values less than 0 should be
hold-able. This patch enables that.

From the manual:
Negative number values will still allow holds (use for on order statuses for
example)
where as positive numbers will not allow holds or checkouts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Severity|major   |normal

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14004
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14004action=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Koha documenation suggests that NOT_LOAN values less than 0 should be
hold-able. This patch enables that.

From the manual:
Negative number values will still allow holds (use for on order statuses for
example)
where as positive numbers will not allow holds or checkouts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||k...@bywatersolutions.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/