[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Jonathan Druart changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #34 from Jonathan Druart --- (In reply to Nick Clemens from comment #33) > (In reply to Nick Clemens from comment #32) > > (In reply to Nick Clemens from comment #31) > > > (In reply to Jonathan Druart from comment #30) > > > > Still valid. > > > > > > I cannot recreate. > > > > > > Set an All/All/All rule for limit 2 holds, do a search, select all, place > > > hold - user gets two holds > > > > > > Cancel those > > > > > > Set maxreserves to 1 > > > Search - select all - place hold - warning that I can only select one - > > > error if I try to place all holds > > > > NVM, set ReservesControlBranch to 'Items home library' > > This may be fixed in 19.05+, I cannot recreate, can someone confirm? I cannot either. Closing. New bug report must be opened with steps to recreate if the bug pops up again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #33 from Nick Clemens --- (In reply to Nick Clemens from comment #32) > (In reply to Nick Clemens from comment #31) > > (In reply to Jonathan Druart from comment #30) > > > Still valid. > > > > I cannot recreate. > > > > Set an All/All/All rule for limit 2 holds, do a search, select all, place > > hold - user gets two holds > > > > Cancel those > > > > Set maxreserves to 1 > > Search - select all - place hold - warning that I can only select one - > > error if I try to place all holds > > NVM, set ReservesControlBranch to 'Items home library' This may be fixed in 19.05+, I cannot recreate, can someone confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Eric Bégin changed: What|Removed |Added CC|francois.charbonnier@inlibr |eric.be...@inlibro.com |o.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Katrin Fischer changed: What|Removed |Added Component|Circulation |Hold requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 sonu kumar changed: What|Removed |Added OS|All |Windows CC||sonu8292946...@gmail.com Hardware|All |PC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #32 from Nick Clemens --- (In reply to Nick Clemens from comment #31) > (In reply to Jonathan Druart from comment #30) > > Still valid. > > I cannot recreate. > > Set an All/All/All rule for limit 2 holds, do a search, select all, place > hold - user gets two holds > > Cancel those > > Set maxreserves to 1 > Search - select all - place hold - warning that I can only select one - > error if I try to place all holds NVM, set ReservesControlBranch to 'Items home library' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #31 from Nick Clemens --- (In reply to Jonathan Druart from comment #30) > Still valid. I cannot recreate. Set an All/All/All rule for limit 2 holds, do a search, select all, place hold - user gets two holds Cancel those Set maxreserves to 1 Search - select all - place hold - warning that I can only select one - error if I try to place all holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 George Williams (NEKLS) changed: What|Removed |Added CC|gwilli...@nekls.org |geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17978 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Jason Robb changed: What|Removed |Added CC||jr...@sekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Jonathan Druart changed: What|Removed |Added Version|3.8 |unspecified CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #30 from Jonathan Druart --- Still valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8238 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Owen Leonard changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #29 from Owen Leonard --- This doesn't appear to be fixed to me. Here's how I tested: - I have a rule set up to limit holds on the DVD item type to 5. - Log in to the OPAC as a user with no holds. - Search by item type for DVDs. - Select all results from the first page of search results - Click 'Place hold' - Click 'Place hold' on the hold confirmation page. Result: The patron has a hold on 20 different DVDs even though the limit should be 5. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #28 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #27 from Paul Poulain --- Patch pushed to master I had some trouble reproducing the behaviour (defining issuingrules correctly is sometimes tricky ;-) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact|koha-b...@lists.koha-commun |m...@kohaaloha.com |ity.org | --- Comment #26 from Mason James --- > Signed-off-by: Chris Cormack patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 3ebd669 Bug 6976 Close loophole allowing borrowers extra holds via opac opac/opac-reserve.pl * opac/opac-reserve.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #25 from Chris Cormack --- I have signed off on this, as it fixes one big loophole. There is no reason not to get this QAed and into master and the other loophole can be closed on bug 4045 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What|Removed |Added Attachment #7832|0 |1 is obsolete|| Attachment #11874|0 |1 is obsolete|| --- Comment #24 from Chris Cormack --- Created attachment 11876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11876&action=edit Bug 6976 Close loophole allowing borrowers extra holds via opac The check that the max number of reserves has not been reached needs to take account of the fact that we may have added enouch reserves to reach the limit while this script is running. Add a check against the incrementing count The variable canreserve was only used when looping through multiple holds but was not being reinitialized on every iteration make variable local to loop it is used in and initialize to zero Have used perltidy to correct the indention of the while loop as it was misleading to the reader Some numeric comparisons were using a string operator fix them before strange bugs manifest themselves The loophole manifests thus: borrowers are only allowed Y holds. If holds are done individually, it is obeying that law i.e. X has held Y separate books – when I tried to do a 6th book it told me that I could not place a hold. However, if a borrower checks the catalogue, gets the intial list up and clicks items on the “results” box and then clicks “place hold” they can hold more than Y items Please enter the commit message for your changes. Lines starting Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Colin Campbell changed: What|Removed |Added Attachment #11872|0 |1 is obsolete|| --- Comment #23 from Colin Campbell --- Created attachment 11874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11874&action=edit Correct updated patch uploaded wrong patch this is the one on current master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Colin Campbell changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #22 from Colin Campbell --- Have updated original patch against current master. Tested by staff at Staffordshire University Incidentally in testing found that if the patch is not in place it only took a couple of days for students to start using the loophole to abuse the system placing greater than the maxholds value -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Colin Campbell changed: What|Removed |Added Attachment #6371|0 |1 is obsolete|| --- Comment #21 from Colin Campbell --- Created attachment 11872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11872&action=edit Updated patch Updated patch against current master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Joy Nelson changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||j...@bywatersolutions.com --- Comment #20 from Joy Nelson --- Marking as Does Not Apply Auto-merging opac/opac-reserve.pl CONFLICT (content): Merge conflict in opac/opac-reserve.pl Failed to merge in the changes. Patch failed at 0001 Bug 6976 Close loophole allowing borrowers extra holds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What|Removed |Added Priority|PATCH-Sent (DO NOT USE) |P1 - high Version|rel_3_4 |master --- Comment #19 from Chris Cormack --- Liz, did you get a chance to look? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #18 from Liz Rea --- Lol dangit. I want to see these patches get another look - this is no trivial issue for libraries - we can't have patrons requesting and getting items over the limits libraries have set in policy. At this point, I am convinced that it is better to look at a partial fix to get SOME limit, SOMEWHERE working. I will look at both fixes by Monday, june 18 2012. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Liz Rea changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from Liz Rea --- I want to see both patches get anot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Liz Rea changed: What|Removed |Added Attachment #6371|1 |0 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Francois Charbonnier changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||francois.charbonnier@biblib ||re.com --- Comment #16 from Francois Charbonnier --- I'm not sure I have been able to reproduce this bug. I didn't know the set up so, here are the set ups I used to test this : The count of "Holds allowed" within the circulation matrix (Library / Category code / Item type) is : All / All / All = 3 All / Librarian / Book = 3 Library A / All / All = 3 Library A / Librarian / Book = 3 I worked with 4 system preferences : * maxreserves * item-level_itypes * OPACItemHolds * ReservesControlBranch The maxreserves syspref is set up to : maxreserves = 4 Then I tried every set up possible with the three other sysprefs. I worked with 4 differents items that have : biblioitems.itemtype = Book items.itype = Book The patron I used to place hold is a Librarian from Library A. When I tested the set ups with OPACItemHolds = yes, every holds placed were on the item level. If OPACItemHolds was set up to "no", every holds placed were on the biblio level. What I noticed is that : * if koha knows the patron category code, the patron or the item library and the itemtype, the limit used is the one from the circulation matrix _BUT_ I have the wrong message : "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." * if koha doesn't know the item's library ou the item's item type, I can't place more than 4 holds. So the limit comes from the maxreserves syspref. It's logical but I think, we should use the "default" rule from the circulation matrix instead to be more flexible. The maxreserves syspref should be used only when nothing else apply. Or maybe, we could get rid of the maxreserves syspref, saying that the default rule (Library =all / Category code = all / Item type = all) is the one koha should use when nothing apply. Since, the documentation says this rule is required, I think it would logical to give it a use. Set ups and test results : 1/ item-level_itypes = biblio OPACItemHolds = no ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 2/ item-level_itypes = item OPACItemHolds = no ReservesControlBranch = patron's branch -> The control looks like it comes from "maxreserves". 3/ item-level_itypes = item OPACItemHolds = yes ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 4/ item-level_itypes = biblio OPACItemHolds = no ReservesControlBranch = item's branch -> The control looks like it comes from "maxreserves". 5/ item-level_itypes = biblio OPACItemHolds = yes ReservesControlBranch = item's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 6/ item-level_itypes = item OPACItemHolds = yes ReservesControlBranch = item's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 7/ item-level_itypes = biblio OPACItemHolds = yes ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 8/ item-level_itypes = item OPACItemHolds = no ReservesControlBranch = item's branch -> The control looks like it comes from "maxreserves". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #15 from Kyle M Hall --- (In reply to comment #14) I cannot really comment on the previous patch, but in my opinion, adding the max holds to the circulation rules has broken the max holds system. Circ rules are a combination of Library, Patron Type and Item Type. When using item level Item Types, we cannot know if placing the hold will violate these rules in advance, as a given record could have items with different item types. The holds rules should really be pulled out of the circ rules and given a separate table where the are set only by Library and Patron Category. This patch does not address this problem. Since we cannot know if the Holds Allowed rules will be violated in advance, we must simply rely on maxreserves. If I am mistaken, or you have an idea that would rectify this situation, please let me know! > Kyle, > > As far as I can tell, your patch just a reimplementation of the patch that > Melia marked as failed QA for only addressing maxreserves. Am I missing > something? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #14 from Jared Camins-Esakov --- Kyle, As far as I can tell, your patch just a reimplementation of the patch that Melia marked as failed QA for only addressing maxreserves. Am I missing something? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Kyle M Hall changed: What|Removed |Added Attachment #6371|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall 2012-02-23 14:36:11 UTC --- Created attachment 7832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7832 Bug 6976 - User hold limit can be avoided by users in OPAC Adds a check to see if a multi-hold request would possibly exceed the maximum number of allowed holds. If it is possible, then we display an error message if the borrower has more checkboxes checked than new holds that can be placed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Kyle M Hall changed: What|Removed |Added CC||kyle.m.h...@gmail.com See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=4045 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #12 from Colin Campbell 2011-12-11 14:03:54 UTC --- Katrin's comment above is valid as this script has always checked the circ matrix limits via the C4::reserves routines but this does not restrict the user from placing the hold. The patch only addresses the users ability to circumvent the maxreserves setting -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #11 from Liz Rea 2011-12-09 01:47:23 UTC --- I think failed QA is ok - except this *is* a partial fix to the problem - neither setting works to limit holds, and both should. So, the question for me becomes - accept this as a partial fix and address the circ rules later (as we i'm sure intended) or forego this patch for a potential future, better patch. I'm not sure what's best. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Melia Meggs changed: What|Removed |Added CC||me...@bywatersolutions.com Patch Status|Needs Signoff |Failed QA --- Comment #10 from Melia Meggs 2011-12-08 23:56:35 UTC --- With maxreserves sys pref set to allow 100 holds and circ rules set to allow 5 holds (as in Liz's example), I was also able to place 6 holds. So I have changed the status to "Failed QA." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack 2011-12-01 18:48:24 UTC --- Liz, should this be failed qa then? Judging by your comments -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Katrin Fischer changed: What|Removed |Added Depends on||4045 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer 2011-11-22 08:24:43 UTC --- Do the circulation matrix holds allowed work at all? (Bug 4045) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #7 from Liz Rea 2011-11-21 18:49:00 UTC --- that should read, I was able to circumvent the limits. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #6 from Liz Rea 2011-11-21 18:48:17 UTC --- It looks like this uses MaxReserves syspref, but not the per itemtype/patron category rules that are defined in the circ matrix. I was able to circumvent the issue with a maxreserves set to 100, but the circ rules set to 5 - I wonder if a check needs to be added to verify the limit specified in the circ rules as well? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Colin Campbell changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #5 from Colin Campbell 2011-11-21 17:48:13 UTC --- Patch as deployed and tested on site. Reopening this bug as 4045 covers some other issues as well -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Colin Campbell changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE | AssignedTo|kyle.m.h...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #4 from Colin Campbell 2011-11-21 17:46:07 UTC --- Created attachment 6371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6371 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #3 from Colin Campbell 2011-10-13 15:51:53 UTC --- The person who was going to confirm the fix works in production was away. They are now back and I'll submit the patch on confirmation -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Ian Walls changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com --- Comment #2 from Ian Walls 2011-10-13 14:24:34 UTC --- Colin, Any word on the fix for this? I don't mean to be a nag, just curious if it was still on your radar after this was marked as a duplicate. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Nicole C. Engard changed: What|Removed |Added Status|NEW |RESOLVED CC||neng...@gmail.com Resolution||DUPLICATE --- Comment #1 from Nicole C. Engard 2011-10-05 16:43:44 UTC --- *** This bug has been marked as a duplicate of bug 4045 *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
