[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #38 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Text to go in the||This enhancement changes release notes||the form for the serials ||renewal period for a ||subscription into a drop ||down list - this is ||consistent with the create ||subscription form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #37 from Martin Renvoize --- Created attachment 102564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102564&action=edit Bug 7046: (RM follow-up) Add Filters Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #36 from Alex Buckley --- Many thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #35 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #34 from Alex Buckley --- Hi Jonathan, Ah OK yes that makes sense. Many thanks for rebasing my patches and adding that follow up to pre-fill the renew form! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #33 from Jonathan Druart --- Hello Alex, I squashed your patches for readability (sub renamed, etc.). Also the follow-up restores a previous behaviour, we need to pre-fill the renew form with info from the previous renew. (In reply to Jonathan Druart from comment #30) > I am working on this, I do not think it works correctly. It did, apart from the pre-fill, it was my follow-up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #32 from Jonathan Druart --- Created attachment 102538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102538&action=edit Bug 7046: Preselect dropdown option and prefill input With previous renew values Bug 7046: Simplify dropdown list construction Bug 7046: Remove "earlier declaration in same scope" "my" variable $numberpattern masks earlier declaration in same scope at /kohadevbox/koha/serials/subscription-add.pl line 437. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart changed: What|Removed |Added Attachment #102427|0 |1 is obsolete|| Attachment #102428|0 |1 is obsolete|| Attachment #102429|0 |1 is obsolete|| Attachment #102430|0 |1 is obsolete|| Attachment #102535|0 |1 is obsolete|| Attachment #102536|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 102537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102537&action=edit Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé Signed-off-by: David Nind Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT Signed-off-by: David Nind Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart changed: What|Removed |Added QA Contact|josef.mora...@gmail.com | Status|Signed Off |BLOCKED --- Comment #30 from Jonathan Druart --- I am working on this, I do not think it works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #29 from Jonathan Druart --- Created attachment 102536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102536&action=edit Bug 7046: Remove "earlier declaration in same scope" "my" variable $numberpattern masks earlier declaration in same scope at /kohadevbox/koha/serials/subscription-add.pl line 437. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #28 from Jonathan Druart --- Created attachment 102535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102535&action=edit Bug 7046: Simplify dropdown list construction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046
--- Comment #27 from Jonathan Druart
---
I think this is not correct:
+my $numberpattern = $query->param('numbering_pattern');
And it displays a warning in the log
"my" variable $numberpattern masks earlier declaration in same scope at
/kohadevbox/koha/serials/subscription-add.pl line 437.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #26 from Alex Buckley --- Thank you very much David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Attachment #102425|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 102430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102430&action=edit Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Attachment #102276|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 102428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102428&action=edit Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Attachment #102278|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 102429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102429&action=edit Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Attachment #102275|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 102427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102427&action=edit Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #21 from Alex Buckley --- Hi David, That should now be fixed up. I also removed the border around the subscription length in subscription-renew.tt so that it is centered on the page along with the other labels and inputs. Can you please re-test? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #20 from Alex Buckley --- Created attachment 102425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102425&action=edit Bug 7046: (follow-up) Update function call in subscription-add.pl Also removed border around Subscription length in subscription-renew.tt Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #19 from Alex Buckley --- Hi David, Thanks so much for testing, and reporting that problem. I am fixing that now. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Comment #18 from David Nind ---
Hi Alex.
When I go to add a ne subscription (step 9) I get an error when trying to save
the subscription:
Can't locate object method "getsublength" via package "C4::Serials" at
/kohadevbox/koha/serials/subscription-add.pl line 322
in
CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dadd_2epl::redirect_add_subscription
at /kohadevbox/koha/serials/subscription-add.pl line 322
319:
320: my $subtype = $query->param('subtype');
321: my $sublength = $query->param('sublength');
322: my ( $numberlength, $weeklength, $monthlength )
323: = C4::Serials->getsublength( $subtype, $sublength );
324: my $add1 = $query->param('add1');
325: my $lastvalue1= $query->param('lastvalue1');
in (eval) at /kohadevbox/koha/serials/subscription-add.pl line 184
181: }
182:
183: if ($op eq 'addsubscription') {
184: redirect_add_subscription();
185: } elsif ($op eq 'modsubscription') {
186: redirect_mod_subscription();
187: } else {
in
CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dadd_2epl::__ANON__
at /kohadevbox/koha/serials/subscription-add.pl line 519
516: return;
517: }
Show function arguments
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #17 from Alex Buckley --- Hi all, I've rebased the first two commits against master and done a followup patch to address Josef's points in comment #12 and #13. Please let me know if I should remove the sign off line in the first commit, and if there are further changes to these commits you feel would be useful. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #16 from Alex Buckley --- Created attachment 102278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102278&action=edit Bug 7046: (follow-up) Changed subroutine name and added unit tests * Fixed uninitialised value in $subtype in C4/Serials.pm line 1468 * Fixed sub routine name to 'GetSubscriptionLength' * Removed sublength param from being in value of sublength HTML input field * Added more unit tests to include bad params: undef, letters and special characters Test plan: Please follow test plan in first patch Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #15 from Alex Buckley --- Created attachment 102276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102276&action=edit Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #14 from Alex Buckley --- Created attachment 102275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102275&action=edit Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Attachment #81641|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Attachment #81642|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046
--- Comment #13 from Josef Moravec ---
Comment on attachment 81642
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81642
Bug 7046: (follow-up) Tidy up to address test feedback
Review of attachment 81642:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7046&attachment=81642)
-
::: C4/Serials.pm
@@ +1453,4 @@
> return $subscriptionid;
> }
>
> +=head2 getsublength
in C4 namespace it should be spelled "GetSubLength" or "GetSubscriptionLength"
::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
@@ +65,5 @@
> [% END %]
>
> [% END %]
>
> +(enter amount in numerals)
The "sublength" param is not passed from perl script, so this input is always
empty
::: t/db_dependent/Serials/ReNewSubscription.t
@@ +85,5 @@
> # Actual testing starts here!
>
> +# Calculate the subscription length for the renewal for issues, days and
> months
> +my ($numberlength, $weeklength, $monthlength) = getsublength('issues', 7);
> +is ( $numberlength, 7, "Sub length is 7 issues");
You should test other variables too.
Also, you should test bad params too - undef, other string, ...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #12 from Josef Moravec --- When you click on the button "Renew subscription", there is warning: Use of uninitialized value $subtype in string eq at /home/vagrant/kohaclone/C4/Serials.pm line 1468 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #10 from Alex Buckley --- Created attachment 81641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81641&action=edit Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #11 from Alex Buckley --- Created attachment 81642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81642&action=edit Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Attachment #69408|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Josef Moravec changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #9 from Josef Moravec --- Comment on attachment 69408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408 Bug 7046 - Implemented dropdown sub length element Review of attachment 69408: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7046&attachment=69408) - ::: C4/Serials.pm @@ +1509,5 @@ > + $subtype eq 'issues' ? $length : 0, > + $subtype eq 'weeks' ? $length : 0, > + $subtype eq 'months' ? $length : 0, > +); > +} Now it is not internal subroutine so the name should not start with underscores. Tests are needed for new subroutines in modules. Some refactoring using objects would be nice, but it is out of the scope of this bug report IMO, so no blocker. ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt @@ +32,4 @@ > > > Subscription length: > + Here are tabs at beginning, need to be removed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #8 from Josef Moravec --- (In reply to Dilan Johnpullé from comment #7) > Created attachment 69408 [details] [review] > Bug 7046 - Implemented dropdown sub length element > > Patch applies and functions as expected in line with test plan. > Signed-off-by: Dilan Johnpullé Dilan, please do not remove the original commit message when you are sign-offing. We need it in git for better understanding of commit content/funcionality. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Assignee|colin.campbell@ptfs-europe. |alexbuck...@catalyst.net.nz |com | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Dilan Johnpullé changed: What|Removed |Added Attachment #69356|0 |1 is obsolete|| --- Comment #7 from Dilan Johnpullé --- Created attachment 69408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408&action=edit Bug 7046 - Implemented dropdown sub length element Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Dilan Johnpullé changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #6 from Alex Buckley --- Created attachment 69356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69356&action=edit Bug 7046 - Implemented dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz Attachment #69355|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #5 from Alex Buckley --- Created attachment 69355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69355&action=edit Bug 7046 - Added subscription length dropdown box -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #4 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m, ||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Still valid in current master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Sam Sanders changed: What|Removed |Added CC||sam-sand...@live.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #2 from Nicole C. Engard 2011-10-17 17:57:05 UTC --- Also, "Number of num:" should be "Number of issues:" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #1 from Nicole C. Engard 2011-10-17 17:46:42 UTC --- Created attachment 5939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5939 subscription length when adding -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
