[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-07-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #158 from Kyle M Hall k...@bywatersolutions.com ---
RFC: http://wiki.koha-community.org/wiki/Online_Borrower_Registration_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-05-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10293

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-03-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Blocks||9930

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC||gr...@catalyst.net.nz

--- Comment #156 from Jared Camins-Esakov jcam...@cpbibliography.com ---
*** Bug 4848 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9393

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14282|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14283|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #157 from Kyle M Hall k...@bywatersolutions.com ---
Patches moved to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

(In reply to comment #155)
 If these two patches are intended for inclusion in 3.12, a new bug needs to
 reported for them, to which they need to be attached with their subject
 lines changed to reflect their new bug number. If the follow-ups are
 unrelated, two separate bugs would make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9384

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2013-01-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #155 from Jared Camins-Esakov jcam...@cpbibliography.com ---
If these two patches are intended for inclusion in 3.12, a new bug needs to
reported for them, to which they need to be attached with their subject lines
changed to reflect their new bug number. If the follow-ups are unrelated, two
separate bugs would make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14191|0   |1
is obsolete||

--- Comment #153 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14282
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14282action=edit
Bug 7067 - Followup - Change 'mobile phone' to 'other phone', run typed in
captcha through uc before comparing.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Label changed and captcha is not case sensitive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #14194|0   |1
is obsolete||

--- Comment #154 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 14283
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14283action=edit
Bug 7067 - Followup - Add note to circulation.pl if borrower has pending
modifications

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
New link patron modifications (if there are) on the checkout page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #143 from Nicole C. Engard neng...@gmail.com ---
One problem with this. opac-memberentry.pl  says 'mobile phone' for the third
phone - it should be 'other phone' like in the staff client cause the primary
phone might be your mobile phone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #145 from Nicole C. Engard neng...@gmail.com ---
Created attachment 14190
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14190action=edit
no username

Sorry for all the updates to this - I was about to document it and when I
registered via the OPAC I got the attached. It shows me a password but no
username ... the username wasn't generated.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14085|0   |1
is obsolete||
  Attachment #14086|0   |1
is obsolete||
  Attachment #14087|0   |1
is obsolete||
  Attachment #14088|0   |1
is obsolete||
  Attachment #14089|0   |1
is obsolete||
  Attachment #14090|0   |1
is obsolete||
  Attachment #14092|0   |1
is obsolete||
  Attachment #14093|0   |1
is obsolete||
  Attachment #14119|0   |1
is obsolete||

--- Comment #146 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14191action=edit
Bug 7067 - Followup - Change 'mobile phone' to 'other phone', run typed in
captcha through uc before comparing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #147 from Kyle M Hall k...@bywatersolutions.com ---
Nicole, I cannot recreate this issue. AFAIK, there are no system preferences
related to the automatic generation of user names, are there?

(In reply to comment #145)
 Created attachment 14190 [details]
 no username
 
 Sorry for all the updates to this - I was about to document it and when I
 registered via the OPAC I got the attached. It shows me a password but no
 username ... the username wasn't generated.
 
 Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #148 from Nicole C. Engard neng...@gmail.com ---
Hmm,

There is no preference and when I create a patron in the staff client the
username is generated fine: http://screencast.com/t/OPRjsR80EAi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #149 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hi Nicole,
Did you fill the syspref PatronSelfRegistrationDefaultCategory with an existing
patron category?
There are errors in your log file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #150 from Nicole C. Engard neng...@gmail.com ---
(In reply to comment #149)
 Hi Nicole,
 Did you fill the syspref PatronSelfRegistrationDefaultCategory with an
 existing patron category?
 There are errors in your log file?

BINGO! I had an invalid default category :)

Thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #151 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14193
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14193action=edit
Bug 7067 - Followup - Add note to circulation.pl if borrower has pending
modifications

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14190|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14193|0   |1
is obsolete||

--- Comment #152 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14194
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14194action=edit
Bug 7067 - Followup - Add note to circulation.pl if borrower has pending
modifications

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Michal smichae...@tlen.pl changed:

   What|Removed |Added

 Status|Pushed to Master|In Discussion
 CC||smichae...@tlen.pl

--- Comment #139 from Michal smichae...@tlen.pl ---
Gets this error

Not enough arguments for C4::Members::fixup_cardnumber at
/usr/share/koha/lib/C4/Members.pm line 2361, near ()
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 149.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #140 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #139)
 Gets this error
 
 Not enough arguments for C4::Members::fixup_cardnumber at
 /usr/share/koha/lib/C4/Members.pm line 2361, near ()
 Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 149.

What does?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #141 from Michal smichae...@tlen.pl ---
(In reply to comment #140)
 (In reply to comment #139)
  Gets this error
  
  Not enough arguments for C4::Members::fixup_cardnumber at
  /usr/share/koha/lib/C4/Members.pm line 2361, near ()
  Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 149.
 
 What does?

Trying to make this in version 3.8.07 but gets this message on opac and
intranet. In log is
[Sat Dec 15 21:34:41 2012] [error] [client 127.0.0.1] (2)No such file or
directory: exec of '/usr/share/koha/intranet/cgi-bin/mainpage.pl' failed
[Sat Dec 15 21:34:41 2012] [error] [client 127.0.0.1] Premature end of script
headers: mainpage.pl
[Sat Dec 15 21:34:42 2012] [error] [client 127.0.0.1] [Sat Dec 15 21:34:42
2012] 500.pl: Not enough arguments for C4::Members::fixup_cardnumber at
/usr/share/koha/lib/C4/Members.pm line 2361, near ()
[Sat Dec 15 21:34:42 2012] [error] [client 127.0.0.1] [Sat Dec 15 21:34:42
2012] 500.pl: Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm
line 149.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

--- Comment #142 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #141)
 Trying to make this in version 3.8.07 but gets this message on opac and
 intranet. In log is

These patches are for 3.12+ only. They were not intended for backporting to 3.8
(and, as you can see, rebasing causes syntax errors).

Resetting the status to Pushed to Master. If you have further questions about
backporting, I suggest you take them to the koha-devel mailing list, as
bugzilla is not really the place for that sort of discussion and many people
who might be able to offer advice would not read your messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #138 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14119
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14119action=edit
Bug 7067 - QA Followup - Fix error when confirming via email

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #128 from Jared Camins-Esakov jcam...@cpbibliography.com ---
We are getting very close, I think.

There are four remaining problems:
1) Two of the unit tests fail:
[...]
not ok 7
#   Failed test at t/db_dependent/Koha_borrower_modifications.t line 55.
not ok 8
#   Failed test at t/db_dependent/Koha_borrower_modifications.t line 56.
[...]

2) The unit tests do not have labels that would indicate what they are testing.

3) The breadcrumb on /cgi-bin/koha/members/members-update.pl has an incorrect
link for the Patrons section (/cgi-bin/koha/members-home.pl instead of
/cgi-bin/koha/members/members-home.pl).

4) When I try to confirm a patron via e-mail, I get the following in my logs
and the patron is not created:
 INSERT INTO borrowers SET   borrowers.dateenrolled = ? ,  borrowers.userid = ?
,  borrowers.categorycode = ? ,  borrowers.dateexpiry = ? ,  borrowers.password
= ? ,  borrowers.cardnumber = ?
2012-12-13,,PT,2021-03-13,4eTMRTxoZ2tV15HgDg4fXw,23529001223641 at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 182.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY
(`branchcode`) REFERENCES `branches` (`branchcode`)) at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 184.DBD::mysql::st execute failed:
Cannot add or update a child row: a foreign key constraint fails
(`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`)
REFERENCES `branches` (`branchcode`)) at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 184.


Not blocking this patch, but just a comment:
I am slightly dubious about the wisdom of allowing the public to register users
on the OPAC without giving staff the ability to review those registrations.
However, if this meets the needs of the library that requested the feature, I
have no objection to including it in Koha as-is. Those libraries concerned with
security can simply disable the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13765|0   |1
is obsolete||

--- Comment #129 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14085
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14085action=edit
Bug 7067 - OPAC Borrower Self Registration

This development will add the ability for a new patron to register
himself or herself. The self-registration will attempt to match this
newly inputted data to any existing patrons and if any possible matches
are found, ask if the patron is sure he or she doesn't already have an
account at the library. A system preference may be set to prevent patron
self-registration if the system detects the possibility that the person
may already have an account.

Once the patron has registered, passing a captcha (or similar
bot-stopper), the patron will then be optionally verified a second time
via email. At this point, the patron will be able to print a temporary
library card (optional by system preference), and will be provided any
details necessary to access electronic resources (this body of text
would be a template in the slips and notices system). At the library's
choice, this new patron would either be set to a temporary patron status
(patron type set via system preference), or a fully-fledged patron
(allow patron type to be determined by age and/or other attributes).
Assuming the library uses temporary patron types for OPAC registrations,
this patron will next enter a queue and would need to physically enter
the library to verify himself and become a fully-fledged patron (most
likely by bringing in physical proof of address, etc.). The librarian
would look up the patron record and modify the patron type. If a
temporary patron has not been verified within a certain time frame
(defined by a system preference), the patron record will be deleted
from the system via a cron job.

For registered patrons, the system will allow each person to also
update his or her personal data via the OPAC. When a patron updates his
or her information, the changes will be entered into a queue to be
verified by a librarian (preventing a patron from inputting obviously
bogus data). The staff client home page will display the number of
patron records with changes awaiting approval. A librarian would then be
able to click through a list of modification requests, and approve or
deny each (with approval and denial alerts being sent to the patron via
the standard messaging system).

NEW SYSTEM PREFERENCES
* PatronSelfRegistration
* PatronSelfRegistrationDetectDuplicates
* PatronSelfRegistrationVerifyByEmail
* PatronSelfRegistrationPrintTemporaryCard
* PatronSelfRegistrationUseTemporaryStatus
* PatronSelfRegistrationExpireTemporaryAccountsDelay

NEW NOTICE
* Verify by email notice

NEW SLIP
* Temporary card slip

NEW CRON JOB
* delete_expired_opac_registrations.pl
  - Deletes patrons that have not been upgraded from the temporary
status within the specified delay
* delete_unverified_opac_registrations.pl
  - Deletes the unverified patrons based on the length of time specified
in the PatronSelfRegistrationExpireTemporaryAccountsDelay

The patron will register from self_registration.pl, linked off opac-main.pl if
enabled. The registration page will be translatable to other languages in the
same way that existing templates are.

Test Plan:
1) Enable PatronSelfRegistration
2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number
   of days
3) Create a self-registered borrower category
4) Set PatronSelfRegistrationUseTemporaryStatus
5) Set PatronSelfRegistrationVerifyByEmail to Don't require
6) Go to OPAC, log out if logged in.
7) You should see the Register here link below the login box
8) Attempt to register yourself
9) Verify you can log in with your temporary password.
10) Set PatronSelfRegistrationVerifyByEmail to Require
11) Attempt another self-registration
12) Check the messages table, you should see a new message with a
verification link.
13) Copy and paste the link into a web browser to verify the registration
14) Log in with the given credentials to verify the account was created.

Test Plan - Part 2 - Borrower Modifications

1) Log in to OPAC, go to my personal details tab.
2) Make some modifications to your details.
3) Repeat steps 1 and 2 for two more borrowers.
4) Log in to Koha intranet with a user that can modify borrowers.
5) At the bottom of mainpage.pl, you should see:
  Patrons requesting modifications: 3
6) Click the link
7) Approve one change, deny a different one, and ignore the third, then
   submit.
8) Check the records, you should see the changes take affect on the
   approved one, and no changes to the other two. You should also 

[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13766|0   |1
is obsolete||
  Attachment #13767|0   |1
is obsolete||

--- Comment #130 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14086action=edit
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13768|0   |1
is obsolete||

--- Comment #131 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14087
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14087action=edit
Bug 7067: Followup FIX QA fails

Signed-off-by: Owen Leonard oleon...@myacpl.org

Fixed minor conflict in C4/Installer/PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13769|0   |1
is obsolete||

--- Comment #132 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14088
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14088action=edit
Bug 7067 Followup: FIX merge updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13984|0   |1
is obsolete||
  Attachment #14001|0   |1
is obsolete||

--- Comment #133 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 14089
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14089action=edit
Bug 7067 QA Followup

Adjusts calling conventions to use hashrefs and eliminate redundant
procedural/OO mixed code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #134 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14090
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14090action=edit
Bug 7067 QA Followup - Add descriptions to tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #135 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14092
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14092action=edit
Bug 7067 - QA Followup - Fix failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #136 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14093
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14093action=edit
Bug 7067 - Fix bad url in breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #137 from Jared Camins-Esakov jcam...@cpbibliography.com ---
At this point the only thing blocking this patch is:

4) When I try to confirm a patron via e-mail, I get the following in my logs
and the patron is not created (when I click on the link in the e-mail):
 INSERT INTO borrowers SET   borrowers.dateenrolled = ? ,  borrowers.userid = ?
,  borrowers.categorycode = ? ,  borrowers.dateexpiry = ? ,  borrowers.password
= ? ,  borrowers.cardnumber = ?
2012-12-13,,PT,2021-03-13,4eTMRTxoZ2tV15HgDg4fXw,23529001223641 at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 182.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY
(`branchcode`) REFERENCES `branches` (`branchcode`)) at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 184.DBD::mysql::st execute failed:
Cannot add or update a child row: a foreign key constraint fails
(`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`)
REFERENCES `branches` (`branchcode`)) at
/home/jcamins/kohaclone/C4/SQLHelper.pm line 184.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #127 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 14001
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14001action=edit
Bug 7067 [7] - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #124 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 13984
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13984action=edit
Bug 7067 [6] - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #125 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #123)
 There are no unit tests for Koha::Borrower::Modifications, nor for the
 AddMember_Opac routine (any other routines added should also have unit
 tests, of course). Starting with the 3.12 release cycle, unit tests are
 required for code added to the Koha:: and C4:: namespaces.

Add a Unit Test.

 Also, please use hashrefs rather than hashes as arguments in the Koha::
 namespace. I could have sworn you did a follow-up changing all the hash
 arguments to hashrefs but I don't see it anywhere, even among the obsolete
 patches.

Fixed

 Other notes:
 * Do not access the database in BEGIN {} blocks, especially not in the
 Koha:: namespace.

Fixed

 * Use of C4::SQLHelper from the Koha:: namespace. Calling into the C4::
 namespace from Koha:: is not supposed to be done. If that was the only
 objection, I would probably push it anyway, at least this time, but arguably
 I probably shouldn't.

This is the only one I haven't changed. Once we have DBIx::Class support, I
pledge to switch this module from C4::SQLHelper to that.

 * Package-level my variables are verboten, since they break persistence, and
 replacing my with our should be done only under extreme duress, and
 never in new code (note: you can use our when it's called for by the code,
 just not as a workaround for my not working under Plack).

Fixed

 * Object-oriented classes do not export routines and therefore should not
 use Exporter. Even procedural classes that do not export any routines should
 not use Exporter.

Fixed

 * When creating -new() subroutines, the following idiom may be useful:
 return bless( { 'verification_token' = $args{'verification_token'}, ...
 }, $class );
 
 Or even:
 return bless( $args, $class );

Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-12-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #126 from Kyle M Hall k...@bywatersolutions.com ---
Setting back to 'Signed Off' as this is a QA Followup only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #117 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #116)
 Owen, do you think you could push your branch to gitorious (or somewhere)? I
 still can't seem to apply this, so I'll just cherry-pick directly off your
 branch.

Hi Jared,
It's my fault, I proposed a dirty followup to avoid to resubmit an already
signed-off patch. So the last patch just moves the new database entry to the
end of the file.

I pushed the branch with a new last patch in our git repository:
http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/ft/Bug7067

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #13744|0   |1
is obsolete||
  Attachment #13745|0   |1
is obsolete||
  Attachment #13746|0   |1
is obsolete||
  Attachment #13747|0   |1
is obsolete||
  Attachment #13748|0   |1
is obsolete||

--- Comment #118 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 13765
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13765action=edit
Bug 7067 - OPAC Borrower Self Registration

This development will add the ability for a new patron to register
himself or herself. The self-registration will attempt to match this
newly inputted data to any existing patrons and if any possible matches
are found, ask if the patron is sure he or she doesn't already have an
account at the library. A system preference may be set to prevent patron
self-registration if the system detects the possibility that the person
may already have an account.

Once the patron has registered, passing a captcha (or similar
bot-stopper), the patron will then be optionally verified a second time
via email. At this point, the patron will be able to print a temporary
library card (optional by system preference), and will be provided any
details necessary to access electronic resources (this body of text
would be a template in the slips and notices system). At the library's
choice, this new patron would either be set to a temporary patron status
(patron type set via system preference), or a fully-fledged patron
(allow patron type to be determined by age and/or other attributes).
Assuming the library uses temporary patron types for OPAC registrations,
this patron will next enter a queue and would need to physically enter
the library to verify himself and become a fully-fledged patron (most
likely by bringing in physical proof of address, etc.). The librarian
would look up the patron record and modify the patron type. If a
temporary patron has not been verified within a certain time frame
(defined by a system preference), the patron record will be deleted
from the system via a cron job.

For registered patrons, the system will allow each person to also
update his or her personal data via the OPAC. When a patron updates his
or her information, the changes will be entered into a queue to be
verified by a librarian (preventing a patron from inputting obviously
bogus data). The staff client home page will display the number of
patron records with changes awaiting approval. A librarian would then be
able to click through a list of modification requests, and approve or
deny each (with approval and denial alerts being sent to the patron via
the standard messaging system).

NEW SYSTEM PREFERENCES
* PatronSelfRegistration
* PatronSelfRegistrationDetectDuplicates
* PatronSelfRegistrationVerifyByEmail
* PatronSelfRegistrationPrintTemporaryCard
* PatronSelfRegistrationUseTemporaryStatus
* PatronSelfRegistrationExpireTemporaryAccountsDelay

NEW NOTICE
* Verify by email notice

NEW SLIP
* Temporary card slip

NEW CRON JOB
* delete_expired_opac_registrations.pl
  - Deletes patrons that have not been upgraded from the temporary
status within the specified delay
* delete_unverified_opac_registrations.pl
  - Deletes the unverified patrons based on the length of time specified
in the PatronSelfRegistrationExpireTemporaryAccountsDelay

The patron will register from self_registration.pl, linked off opac-main.pl if
enabled. The registration page will be translatable to other languages in the
same way that existing templates are.

Test Plan:
1) Enable PatronSelfRegistration
2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number
   of days
3) Create a self-registered borrower category
4) Set PatronSelfRegistrationUseTemporaryStatus
5) Set PatronSelfRegistrationVerifyByEmail to Don't require
6) Go to OPAC, log out if logged in.
7) You should see the Register here link below the login box
8) Attempt to register yourself
9) Verify you can log in with your temporary password.
10) Set PatronSelfRegistrationVerifyByEmail to Require
11) Attempt another self-registration
12) Check the messages table, you should see a new message with a
verification link.
13) Copy and paste the link into a web browser to verify the registration
14) Log in with the given credentials to verify the account was created.

Test Plan - Part 2 - Borrower Modifications

1) Log in to OPAC, go to my personal details tab.
2) Make some modifications to your details.
3) Repeat steps 1 and 2 for two 

[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #119 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 13766
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13766action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #120 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 13767
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13767action=edit
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Passed-QA-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #121 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 13768
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13768action=edit
Bug 7067: Followup FIX QA fails

Signed-off-by: Owen Leonard oleon...@myacpl.org

Fixed minor conflict in C4/Installer/PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #122 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 13769
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13769action=edit
Bug 7067 [5] Followup FIX merge updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #123 from Jared Camins-Esakov jcam...@cpbibliography.com ---
There are no unit tests for Koha::Borrower::Modifications, nor for the
AddMember_Opac routine (any other routines added should also have unit tests,
of course). Starting with the 3.12 release cycle, unit tests are required for
code added to the Koha:: and C4:: namespaces.

Also, please use hashrefs rather than hashes as arguments in the Koha::
namespace. I could have sworn you did a follow-up changing all the hash
arguments to hashrefs but I don't see it anywhere, even among the obsolete
patches.

Other notes:
* Do not access the database in BEGIN {} blocks, especially not in the Koha::
namespace.
* Use of C4::SQLHelper from the Koha:: namespace. Calling into the C4::
namespace from Koha:: is not supposed to be done. If that was the only
objection, I would probably push it anyway, at least this time, but arguably I
probably shouldn't.
* Package-level my variables are verboten, since they break persistence, and
replacing my with our should be done only under extreme duress, and never
in new code (note: you can use our when it's called for by the code, just not
as a workaround for my not working under Plack).

Thank you for including a test plan on the bug. I copied it (and the original
RFC) into the commit message for the first patch. I did not review it for
accuracy yet, since I discovered the lack of unit tests before I got that far,
so you may want to do that.

Also, I noticed a few other issues that would not prevent me pushing this but
you might want to keep in mind for the future:
* The standard for help in command-line scripts is to use pod2usage.
* Object-oriented classes do not export routines and therefore should not use
Exporter. Even procedural classes that do not export any routines should not
use Exporter.
* When creating -new() subroutines, the following idiom may be useful:
return bless( { 'verification_token' = $args{'verification_token'}, ... },
$class );

Or even:
return bless( $args, $class );

I find those two idioms make code easier to read, and certainly save typing,
but they are by no means required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13038|0   |1
is obsolete||

--- Comment #110 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13744
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13744action=edit
Bug 7067 [1] OPAC Borrower Self Registration

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13039|0   |1
is obsolete||

--- Comment #111 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13745
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13745action=edit
Bug 7067 [2] OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13040|0   |1
is obsolete||

--- Comment #112 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13746
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13746action=edit
Bug 7067 [3] [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13259|0   |1
is obsolete||

--- Comment #113 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13747
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13747action=edit
Bug 7067 [4] Followup FIX QA fails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13260|0   |1
is obsolete||

--- Comment #114 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13748
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13748action=edit
Bug 7067 [5] Followup FIX merge updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA
   Patch complexity|--- |Large patch
   Severity|enhancement |new feature

--- Comment #115 from Owen Leonard oleon...@myacpl.org ---
All patches rebased on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #116 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Owen, do you think you could push your branch to gitorious (or somewhere)? I
still can't seem to apply this, so I'll just cherry-pick directly off your
branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #109 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Due to a conflict on the first patch, the third patch refuses to apply at all
(sha1 information lacking or useless). Owen, since you have a branch with these
patches could you please rebase the branch on latest master and re-upload?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #107 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #104)
 Could someone please sign off on the last two patches? Once they've been
 signed off, this can be set back to Passed QA and I will review it.

Jared,
Sorry about that. I thought I could pass QA directly without requesting a
signed off for my patch, given that it was simple modifications (merge marker,
pod adjustement and tabulations characters). It was in order to avoid another
SO and QA (by someone else looking at it my own patch).
I will be more respecful toward the procedure next time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #108 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #107)
 (In reply to comment #104)
  Could someone please sign off on the last two patches? Once they've been
  signed off, this can be set back to Passed QA and I will review it.
 
 Jared,
 Sorry about that. I thought I could pass QA directly without requesting a
 signed off for my patch, given that it was simple modifications (merge
 marker, pod adjustement and tabulations characters). It was in order to
 avoid another SO and QA (by someone else looking at it my own patch).
 I will be more respecful toward the procedure next time.

No problem. Since the patches meet the requirements set out by QA, I am marking
this passed QA now and will review the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #104 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Could someone please sign off on the last two patches? Once they've been signed
off, this can be set back to Passed QA and I will review it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13048|0   |1
is obsolete||

--- Comment #105 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13259
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13259action=edit
[SIGNED-OFF] Bug 7067: Followup FIX QA fails

Signed-off-by: Owen Leonard oleon...@myacpl.org

Fixed minor conflict in C4/Installer/PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #13053|0   |1
is obsolete||

--- Comment #106 from Owen Leonard oleon...@myacpl.org ---
Created attachment 13260
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13260action=edit
[SIGNED-OFF] Bug 7067: Followup FIX merge updatedatabase

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-11-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #12243|0   |1
is obsolete||
  Attachment #12245|0   |1
is obsolete||
  Attachment #12278|0   |1
is obsolete||

--- Comment #97 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13038
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13038action=edit
Bug 7067 - OPAC Borrower Self Registration

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #98 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13039
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13039action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #99 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13040
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13040action=edit
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #100 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13048
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13048action=edit
Bug 7067: Followup FIX QA fails

This patch fixes:
* Koha/Borrower/Modifications.pm   FAIL
  pod FAIL
*** ERROR: Unknown command 'head'  in file Koha/Borrower/Modifications.pm
*** WARNING: Verbatim paragraph in NAME section  in file
Koha/Borrower/Modifications.pm
* C4/Auth.pm   FAIL
  forbidden patterns  FAIL
The patch introduces a forbidden pattern: tabulation character (983)
The patch introduces a forbidden pattern: tabulation character (982)
* misc/cronjobs/delete_expired_opac_registrations.pl   FAIL
  critic  FAIL
require statement with library name as string at line 28, column 12. Use
a bareword instead.
* misc/cronjobs/delete_unverified_opac_registrations.plFAIL
  critic  FAIL
require statement with library name as string at line 28, column 12. Use
a bareword instead.

QA tools raise too:
* C4/Members.pmFAIL
  valid   FAIL
Subroutine AddMember_Opac redefined
It is 'normal' (Circular dependencies and new routine).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #101 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13053
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13053action=edit
Bug 7067: Followup FIX merge updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #102 from Jonathan Druart jonathan.dru...@biblibre.com ---
Well done :) Works as expected so it passes QA !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #103 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #102)
 Well done :) Works as expected so it passes QA !

Excellent! Thanks for the followups Janathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 CC||dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-10-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

Version|master  |rel_3_12

--- Comment #96 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Changing target version so this bug report will show up in the list of
3.12-targeted features and doesn't get lost in the shuffle during feature
freeze.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #94 from Owen Leonard oleon...@myacpl.org ---
Created attachment 12277
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12277action=edit
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12277|0   |1
is obsolete||

--- Comment #95 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12278
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12278action=edit
[SIGNED-OFF] Bug 7067 [Follow-up: templates] allow patron self registration via
the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12197|0   |1
is obsolete||

--- Comment #90 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12242
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12242action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #12242|0   |1
is obsolete||

--- Comment #92 from Owen Leonard oleon...@myacpl.org ---
Created attachment 12244
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12244action=edit
[SIGNED-OFF] Bug 7067 - OPAC Borrower Self Registration

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #12244|0   |1
is obsolete||
  Attachment #12244|[SIGNED-OFF] Bug 7067 - |Whoops, duplicate
description|OPAC Borrower Self  |attachment.
   |Registration|

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12013|0   |1
is obsolete||

--- Comment #83 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12190
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12190action=edit
Bug 7067 - OPAC Borrower Self Registration

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12171|0   |1
is obsolete||

--- Comment #84 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12191action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #85 from Owen Leonard oleon...@myacpl.org ---
Sorry:

Applying: Bug 7067 - OPAC Borrower Self Registration
error: patch failed: installer/data/mysql/sysprefs.sql:372
error: installer/data/mysql/sysprefs.sql: patch does not apply
Patch failed at 0001 Bug 7067 - OPAC Borrower Self Registration

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12190|0   |1
is obsolete||

--- Comment #86 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12196
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12196action=edit
Bug 7067 - OPAC Borrower Self Registration

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #12191|0   |1
is obsolete||

--- Comment #87 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 12197
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12197action=edit
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to
PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #88 from Owen Leonard oleon...@myacpl.org ---
I'm ready to sign off on this, but I'm wondering if this issue is something
which can be left to a follow-up or if it will fail QA without it:

(In reply to comment #60)
 There's no reason not to have the cronjob run once a minute, but if we start
 recommending that configuration, it will need to be patched to use a
 lockfile so that it doesn't allow simultaneous jobs to run if it takes
 longer than a minute to clear the message queue.

I have some template-related fixups but I'd like to get these patches signed
off first.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #89 from Owen Leonard oleon...@myacpl.org ---
Oops, new small glitch: If PatronSelfRegistrationVerifyByEmail is set to
require, the Primary email field in the patron record update form in the OPAC
becomes mandatory even if it's not listed in
PatronSelfRegistrationBorrowerMandatoryField. If it's not listed in
PatronSelfRegistrationBorrowerMandatoryField and the patron is doing an update,
not a new registration, the field should not be required.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #75 from Owen Leonard oleon...@myacpl.org ---
(In reply to comment #74)
  * Add invalid token page

This works great, thanks,

As for the potential duplicate patrons when not requiring email notification, I
guess the upside is that delete_unverified_opac_registrations.pl job will deal
with them. However, that assumes that the patron is coming in to the library to
confirm their identity (or whatever procedure changes them from a temp category
to a permanent one), and that the library is running that cron job. It remains
a potential problem for libraries which allow patrons to register for
full-fledged accounts without confirmation (however unlikely that scenario
seems to me).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #76 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to comment #75)
 (In reply to comment #74)
   * Add invalid token page
 
 This works great, thanks,
 
 As for the potential duplicate patrons when not requiring email
 notification, I guess the upside is that
 delete_unverified_opac_registrations.pl job will deal with them. However,
 that assumes that the patron is coming in to the library to confirm their
 identity (or whatever procedure changes them from a temp category to a
 permanent one), and that the library is running that cron job. It remains a
 potential problem for libraries which allow patrons to register for
 full-fledged accounts without confirmation (however unlikely that scenario
 seems to me).

Agreed. Perhaps just adding a caveat in the manual should suffice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #77 from Owen Leonard oleon...@myacpl.org ---
Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It
deletes from borrower_modifications. But that's just for pending updates to
existing patrons isn't it? Is that how it's supposed to work?

Either way, that script needs help added to it, and should not run without
setting an explicit flag to proceed with deletions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7067] allow patron self registration via the opac

2012-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >