[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||24630


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630
[Bug 24630] UNIMARC XSLT Update for bug 7611
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #60 from Marcel de Rooy  ---
Thx for your additional explanation, Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #59 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #58)
> Sorry for posting on this old report, but it looks like (at least imo) that
> this availability block still needs further attention:
> 
> Availability line looks like: Block 1 (Alternate holdings) Block 2 (For loan
> with callno) Block 3 (Reference block with callno) Block 4 (if with colon)
> Block 5 (reallynotforloan with callno) Block 6 (list of other statuses)
> 
> On order status is no longer set in C4/XSLT; the term reallynotforloan is
> used now and is quite confusing to me?
> Block 4 with the colon and the  in block 5 are dubious.
> No big difference between block reference and block reallynotforloan.
> 
> On the already opened bug 21260 I hope to provide some follow up work..

Clarifications:
Before these patches all positive not for loan values were listed as 'Available
for reference' and all negative not for loan were 'On order'

After we separate 'Not for loan' items into:

reallynotforloan - negative not for loan values
reference - positive not for loan values

Block 1:
If no items available for loan and none for reference then we check the
AlternateHoldingsField in the sysprefs to see if we should display items from
there. Other we show 'No items available'

Block 2:
Available items - they don't have pending holds or waiting holds, they aren't
in transit, damaged, lost, withdrawn, marked notforloan or checked out. 

This block includes the 'reference' items (you call these 2 blocks) they go
into the  because we assume that these are still in the
library and can be accessed

Block 3:
This if with colon is wrong - it should be part of block 1 or just removed- if
there are no items available we say 'No items available' then add the colon,
then list the unavailable items on a new line

Block 4:
Unavailable notforloan items (reallynotforloan) on a new line - the br has
always been there to separate 'available' and 'unavailable' spans

Block 5:
List of other status, all under the 'unavailable' umbrella and same line as
above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #58 from Marcel de Rooy  ---
Sorry for posting on this old report, but it looks like (at least imo) that
this availability block still needs further attention:

Availability line looks like: Block 1 (Alternate holdings) Block 2 (For loan
with callno) Block 3 (Reference block with callno) Block 4 (if with colon)
Block 5 (reallynotforloan with callno) Block 6 (list of other statuses)

On order status is no longer set in C4/XSLT; the term reallynotforloan is used
now and is quite confusing to me?
Block 4 with the colon and the  in block 5 are dubious.
No big difference between block reference and block reallynotforloan.

On the already opened bug 21260 I hope to provide some follow up work..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21260

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #57 from Jonathan Druart  
---
Hi Pablo, yes it's the authorised value's description, which is not
translatable (yet).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #56 from Pablo AB  ---
On 20.05 this seems to add an untranslatable "Not for loan" near
span.notforloan, on MARC21slim2OPACResults.xsl. I reproduce it on Michael
Kuhn's Koha demo:

1. On a biblio, add an item to an item type flagged with "not for loan"=Yes
2. Search for it on the OPAC

- German: "Verfügbarkeit: Ausleihbare Exemplare: (1). Verfügbarer
Präsenzbestand: Not for loan (1).".
  http://koha.adminkuhn.ch/cgi-bin/koha/opac-search.pl?q=Dictionary
- Spanish: "Disponibilidad: Not for loanSignatura topográfica: 520 A552 (1).
:".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.05
released in||

--- Comment #55 from Joy Nelson  ---
Backported to 19.11.x for 19.11.05 per request

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||j...@bywatersolutions.com
 Status|Pushed to master|RESOLVED

--- Comment #54 from Joy Nelson  ---
enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #53 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|koha.sek...@gmail.com   |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #52 from Jonathan Druart  
---
Created attachment 99163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99163=edit
Bug 7611: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #51 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #50 from Jonathan Druart  
---
Created attachment 99078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99078=edit
Bug 7611: (follow-up) separate positive and negative statuses as in the past

This patch preserves someting closer to previous functionality.

Negative not for loan are in the 'unavailable' section in red, positive ones
are in the 'reference' section in green. Itemtype level will also be in green
in reference

Item specific status will override an itemtype level.

The line break between 'reference' and 'unavailable' existed before and is
preserved - negative not for loan and checked out items appear here

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #49 from Jonathan Druart  
---
Created attachment 99077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99077=edit
Bug 7611: (follow-up) Fix display of undefined statuses and add a class

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #48 from Jonathan Druart  
---
Created attachment 99076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99076=edit
Bug 7611: (follow-up) Add missing space

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #47 from Jonathan Druart  
---
Created attachment 99075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99075=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

Signed-off-by: Jessica Zairo 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97804|0   |1
is obsolete||
  Attachment #97805|0   |1
is obsolete||
  Attachment #97806|0   |1
is obsolete||
  Attachment #97807|0   |1
is obsolete||
  Attachment #97808|0   |1
is obsolete||

--- Comment #46 from Jonathan Druart  
---
Created attachment 99074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99074=edit
Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #45 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #44)
> Nick, could you confirm it will not break the display for UNIMARC and
> NORMARC?

NORMARC is no longer maintained according to Magnuse, so we cna ignore that

UNIMARC is not affected by these changes - the status for notforloan items
remains the same, only substatus is added. The CSS changes rely on classes that
don't exist in the UNIMARC xslt

I did file bug 24630 and attempt UNIMARC changes, but that should not block
this patchset

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #44 from Jonathan Druart  
---
Nick, could you confirm it will not break the display for UNIMARC and NORMARC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #43 from Nick Clemens  ---
Created attachment 97808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97808=edit
Bug 7611: (follow-up) separate positive and negative statuses as in the past

This patch preserves someting closer to previous functionality.

Negative not for loan are in the 'unavailable' section in red, positive ones
are in the 'reference' section in green. Itemtype level will also be in green
in reference

Item specific status will override an itemtype level.

The line break between 'reference' and 'unavailable' existed before and is
preserved - negative not for loan and checked out items appear here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #41 from Nick Clemens  ---
Created attachment 97806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97806=edit
Bug 7611: (follow-up) Add missing space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #40 from Nick Clemens  ---
Created attachment 97805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97805=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

Signed-off-by: Jessica Zairo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #42 from Nick Clemens  ---
Created attachment 97807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97807=edit
Bug 7611: (follow-up) Fix display of undefined statuses and add a class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

  Attachment #95236|0   |1
is obsolete||
  Attachment #95237|0   |1
is obsolete||
  Attachment #95238|0   |1
is obsolete||
  Attachment #95239|0   |1
is obsolete||
  Attachment #95240|0   |1
is obsolete||

--- Comment #39 from Nick Clemens  ---
Created attachment 97804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97804=edit
Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #38 from Jonathan Druart  
---
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #37 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #30)
> (In reply to Nick Clemens from comment #27)
> 
> 1) We have built on the fact that the not-for-loan works the same on item
> type as on individual level and I think this change might be controversial.

Good point, last patch restores postive statuses to the 'green' section.
Itemtype notforloan get 'Not for loan' as description and will lump with any
others with same description

> 2) The display with the extra break looks like we are missing a label (I
> think it's intended, but that's the impression I get)

The line break was always there for Checked Out or On Order items, so I opted
to preserve it. Negative not for loan are on this line as they were all 'On
order' before - the negative seeming to imply 'holdable' but not 'available'

> Just notes (no blockers at all): 
> 
> I see that you use individual CSS classes on the items, I like that. Just
> wondering: currently we use the description, so a description change will
> mean the CSS needs to change as well. On the other side: not for loan values
> are numeric and we are grouping the onces with the same name and I like that
> - so that's probably the best way.

Excellent, I think you agree with me here that grouping by description is good.
It allows for staff to have two separate values with differing descriptions
that show the same on the opac, which I think could have value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #36 from Nick Clemens  ---
Created attachment 95240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95240=edit
Bug 7611: (follow-up) separate positive and negative statuses as in the past

This patch preserves someting closer to previous functionality.

Negative not for loan are in the 'unavailable' section in red, positive ones
are in the 'reference' section in green. Itemtype level will also be in green
in reference

Item specific status will override an itemtype level.

The line break between 'reference' and 'unavailable' existed before and is
preserved - negative not for loan and checked out items appear here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #34 from Nick Clemens  ---
Created attachment 95238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95238=edit
Bug 7611: (follow-up) Add missing space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #35 from Nick Clemens  ---
Created attachment 95239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95239=edit
Bug 7611: (follow-up) Fix display of undefined statuses and add a class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #33 from Nick Clemens  ---
Created attachment 95237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95237=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

Signed-off-by: Jessica Zairo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

  Attachment #95235|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 95236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95236=edit
Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

  Attachment #92495|0   |1
is obsolete||
  Attachment #94026|0   |1
is obsolete||
  Attachment #94212|0   |1
is obsolete||
  Attachment #95060|0   |1
is obsolete||

--- Comment #31 from Nick Clemens  ---
Created attachment 95235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95235=edit
Bug 23986: Pass strings to Catmandu for deletion

The deletion subroutine expects to get a string, this is fine in most places,
but when
we sort our records for batch deletion they are cast to numbers and the delete
is not processed.

This patch quotes the biblionumbers as strings before passing them to Catmandu

To aid in detecting orphaned records you can use the patches on bug 22831

To test:
 1 - Have or create a bib
 2 - Go to Tools->Batch record deletion
 3 - Click 'Enter a list of record numbers'
 4 - Enter the biblionumber'
 5 - Confirm deletion
 6 - Search for the record, it still appears
 7 - Apply patch, restart all the things
 8 - Repeat 1-6
 9 - This time the record is deleted
10 - Test other methods of record deletion to confirm the record is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #30 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #27)
> Okay, I reviewed this, what it does is that:
> Available doesn't change
> Items marked 'not for loan' at itemtype level go into 'Available for
> reference'
> Items marked 'not for loan' individually, whether negative or positive, are
> displayed in the 'unavailable' section with the description of the 'not for
> loan' status showing.
> 
> If you have several not for loan statuses with the same description, e.g.
> 'Available for reference' then they will be displayed together in the
> unavailable section
> 
> It also adds some classes and styling to allow for the end user to adjust
> using css/jquery
> 
> I am attaching a smaple record as described in the test plan which you can
> import if using the default database. You will need to add a 'NOT_LOAN'
> value of 4 with opac description 'Ordered' to see it in operation

Hi Nick, 

first: thank you for the summary! Second: I am sorry, it just doesn't feel
quite right yet to me :( I am trying to put into words, but please feel free to
get others opinions as well.

>Items marked 'not for loan' at itemtype level go into 'Available for reference'
>Items marked 'not for loan' individually, whether negative or positive, are 
>displayed in the 'unavailable' section with the >description of the 'not for 
>loan' status showing

1) We have built on the fact that the not-for-loan works the same on item type
as on individual level and I think this change might be controversial. With the
patch, itype level 'not for loan' is green, but individual show red = different
messages. Koha defines available as 'on the shelf' not as 'loanable' in my
understanding - so green seems the better default choice.

2) The display with the extra break looks like we are missing a label (I think
it's intended, but that's the impression I get):

Availability: Items available for loan: Midway (1).
Centerville Staff Collection (1).

Or with some more items:

Availability: Items available for loan: Centerville (1). Items available for
reference: Centerville (1).
Centerville Staff Collection (1). Damaged (1). 

I think I'd opt for removing the line break and always displaying the "Itmes
available for reference:" when there is at least one item with a not for loan
value. That would mean the first example would look like this:

Availability: Items available for loan: Midway (1). Items available for
reference: Centerville Staff Collection (1).

And the second could be like this, using a comma between different values:

Availability: Items available for loan: Centerville (1). Items available for
reference: Centerville (1),
Centerville Staff Collection (1). Damaged (1). 



Just notes (no lockers at all): 

I see that you use individual CSS classes on the items, I like that. Just
wondering: currently we use the description, so a description change will mean
the CSS needs to change as well. On the other side: not for loan values are
numeric and we are grouping the onces with the same name and I like that - so
that's probably the best way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #29 from Nick Clemens  ---
Created attachment 95061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95061=edit
Sample marc record to illustrate display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #28 from Nick Clemens  ---
Created attachment 95060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95060=edit
Bug 7611: (follow-up) Fix display of undefined statuses and add a class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #27 from Nick Clemens  ---
Okay, I reviewed this, what it does is that:
Available doesn't change
Items marked 'not for loan' at itemtype level go into 'Available for reference'
Items marked 'not for loan' individually, whether negative or positive, are
displayed in the 'unavailable' section with the description of the 'not for
loan' status showing.

If you have several not for loan statuses with the same description, e.g.
'Available for reference' then they will be displayed together in the
unavailable section

It also adds some classes and styling to allow for the end user to adjust using
css/jquery

I am attaching a smaple record as described in the test plan which you can
import if using the default database. You will need to add a 'NOT_LOAN' value
of 4 with opac description 'Ordered' to see it in operation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #26 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #25)
> > > Manually edited:
> > > Items available for loan: Centerville[Call number: 005.13/3] (1).
> > > Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
> > > Ordered[Call number: 005.13/3] (1). Damaged (1).
> 
> > 
> > What do you mean about missing 'for reference'? From my perspective that is
> > a goal of the patch here - to remove that label and use the notforloan
> > descriptions - if a library wants items to appear that way then they can
> > make that the description of the authorized value for the opac. This way
> > those who want it can put it in place, and those who don't can provide their
> > own description
> 
> But then we should also remove the "Items available for loan".
> Because that is clearly giving a wrong idea?
> 
> Just: Items: ?
> 
> Or we can still assume that items that are marked with any 'not for loan'
> value are for reference and list them with their individual status
> descriptions behind the "Items available for reference" label.

NVM, I got confused, yes, the conditional for 'reference' needs a fix, checking
this one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Katrin Fischer  ---

> > Manually edited:
> > Items available for loan: Centerville[Call number: 005.13/3] (1).
> > Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
> > Ordered[Call number: 005.13/3] (1). Damaged (1).

> 
> What do you mean about missing 'for reference'? From my perspective that is
> a goal of the patch here - to remove that label and use the notforloan
> descriptions - if a library wants items to appear that way then they can
> make that the description of the authorized value for the opac. This way
> those who want it can put it in place, and those who don't can provide their
> own description

But then we should also remove the "Items available for loan".
Because that is clearly giving a wrong idea?

Just: Items: ?

Or we can still assume that items that are marked with any 'not for loan' value
are for reference and list them with their individual status descriptions
behind the "Items available for reference" label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #24 from Nick Clemens  ---
Created attachment 94212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94212=edit
Bug 7611: (follow-up) Add missing space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #23 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #22)
> Forgot to run yarn build --view opac
> 
> It's better now, but problems still remain with spaces and 'for reference'
> label. [] show... but I can't copy and paste them from the OPAC to here? 
> 
> With C:
> Items available for loan: CentervilleCall number: 005.13/3 (1).
> Centerville Staff CollectionCall number: 005.13/3 (2), Centerville
> OrderedCall number: 005.13/3 (1). Damaged (1). 
> 
> Manually edited:
> Items available for loan: Centerville[Call number: 005.13/3] (1).
> Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
> Ordered[Call number: 005.13/3] (1). Damaged (1).

I can add a space to the callnumber brackets - I moved them from the template
to the css as some libraries don't want them and it seemed an easier fix than
adding yet another span to the template - the CSS is I supposed what makes them
not copy/paste

What do you mean about missing 'for reference'? From my perspective that is a
goal of the patch here - to remove that label and use the notforloan
descriptions - if a library wants items to appear that way then they can make
that the description of the authorized value for the opac. This way those who
want it can put it in place, and those who don't can provide their own
description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #22 from Katrin Fischer  ---
Forgot to run yarn build --view opac

It's better now, but problems still remain with spaces and 'for reference'
label. [] show... but I can't copy and paste them from the OPAC to here? 

With C:
Items available for loan: CentervilleCall number: 005.13/3 (1).
Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall
number: 005.13/3 (1). Damaged (1). 

Manually edited:
Items available for loan: Centerville[Call number: 005.13/3] (1).
Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
Ordered[Call number: 005.13/3] (1). Damaged (1).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #21 from Katrin Fischer  ---
My example: Record with 4 items:
- 1 damaged + Staff collecton
- 1 ordered
- 1 Staff collection
- 1 'without' status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Katrin Fischer  ---
Sorry, but something is not working quite right here still. I get quite
unreadable output in the OPAC :(

With this patch:
Availability: Items available for loan: CentervilleCall number: 005.13/3 (1).
Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall
number: 005.13/3 (1). Damaged (1). 

Before:
Availability: Items available for loan: Centerville [Call number: 005.13/3]
(1). Items available for reference: Centerville [Call number: 005.13/3] (1).
Damaged (1). On order (1). 

- Can we please bring back the [] for now? 
- Totally missing the: 'Available for reference' label?
- I am also tempted to say 'kill Call number', but we should concentrate on one
change at a time here. We should focus on the 'not for loan' descriptions here
first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

Summary|Show the NOT_LOAN   |Show the NOT_LOAN
   |authorised values for item  |authorised values for item
   |status in XSLT OPAC search  |status in XSLT OPAC search
   |results.|results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #92496|0   |1
is obsolete||

--- Comment #19 from ByWater Sandboxes  ---
Created attachment 94026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94026=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

Signed-off-by: Jessica Zairo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Owen Leonard  changed:

   What|Removed |Added

  Attachment #85115|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #18 from Nick Clemens  ---
Created attachment 92496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92496=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #17 from Nick Clemens  ---
Created attachment 92495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92495=edit
Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #16 from Caroline Cyr La Rose  ---
I find that this is still a problem. Is the only thing left to determine/dicuss
is what we want for items that are "available" but "not for loan" (e.g.
available for reference or in-library use)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #15 from Owen Leonard  ---
This works for notforloatn values > 0. A value of -1 still shows a default "On
order" instead of the text I have defined in authorized values.

I think it is a big change that items are now shown as unavailable instead of
"available for reference." I think neither is ideal, but sticking with the old
label is probably better if we're not going to come up with a more
comprehensive solution in this bug (i.e. have a way to define what is "for
reference" and what is wholly unavailable).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
I'm not seeing the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60816|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 85115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85115=edit
Bug 7611 - Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Joy Nelson  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

--- Comment #12 from Joy Nelson  ---
*** Bug 19572 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #11 from Katrin Fischer  ---
Created attachment 62931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62931=edit
Screenshot of current display

Current display for comparison (note: my items didn't have callnumbers)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Created attachment 62930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62930=edit
Screenshot

Tested with a record with 5 items:
- no status set, normal itemtype
- no status set, itemtype is marked as not for loan
- damaged: damaged
- not for loan: staff collection
- not for loan: on order

- As soon as I added the item with the not for loan itemtype an additional
blank line appeared between the available and unavailable items
- Before the patch the items were counted as 'available' in green, after the
patch the not for loan items are counted as 'unavailable' in red. I think this
is a somewhat unexpected change. As I see it we define availability as
'accessible', but not necessarily as 'for loan'. I think this change needs to
be discussed. 
- Showing the authorised value description means that this will no longer be
translatable. For libraries offering the OPAC in multiple languages this might
be a problem (we really need to make authorised values multi-lang as the
itemtypes).

Marking failed for the additional blank line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Mehdi Hamidi  changed:

   What|Removed |Added

   Attachment #7907|0   |1
is obsolete||

--- Comment #9 from Mehdi Hamidi  ---
Created attachment 60816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60816=edit
Bug 7611 - Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #8 from Barton Chittenden  ---
We've had other libraries report this issue as well.

Would it be possible to get some movement on this?

Thanks,

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13854
 CC||bar...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Owen Leonard  changed:

   What|Removed |Added

Version|3.6 |master

--- Comment #7 from Owen Leonard  ---
I think this is still valid on master. It looks to me like the only special
handling we have for "not for loan" is for on-order items. Otherwise it's
"Items available for reference."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Marijana Glavica mglav...@ffzg.hr changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||mglav...@ffzg.hr

--- Comment #6 from Marijana Glavica mglav...@ffzg.hr ---
Except not showing call numbers, as Owen noted, there are few more things I
noticed until now, so here are my examples:

Before:
Availability: Copies available for loan: Gimnazija Požega [456] (1), Knjižnica
FFZG [678] (1).
Copies available for reference: Knjižnica FFZG [R-123] (2). Damaged (1). 

After:
Availability: Copies available for loan: Gimnazija Požega [456] (1), Knjižnica
FFZG [678] (1). Damaged (1). Not for loan (1). Staff Collection (1). 

So, everything is now in one line. I don't agree that this is nicer, because
now we have not for loan items under Copies available for loan label. The
solution would be to change label only to Available or Available for use or
something.

This is tiny change to make, but there is another problem. In my second example
I have situation like this:

Before:
Availability: Copies available for reference: Knjižnica FFZG [not for loan]
(1). 

After:
Availability: No copies available Not for loan (1).

So, in my first example i have not for loan items under Copies available for
loan, but in my second example with just one item for biblio, this label
disappears.


In our library, items marked with not for loan status are available, but they
can be used only in library, so the label copies available for reference was
telling our users exactly that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
I like this change because it better accommodates use of not for loan in
cases where the item is available. I'm comparing the before and after:

Before:

Copies available for loan: Nelsonville [E Minarik] (1). 
Copies available for reference: Athens [E Minarik] (2). Lost (1). Damaged (1).

After:

Copies available for loan: Nelsonville [E Minarik] (1). Staff collection (1).
Not for loan (1). Damaged (1). Lost (1). 

What the new version lacks, I think, is output of the call number for not for
loan items. If we consider these items available in some sense of the term (in
library-use, reference, etc), shouldn't we show the call number as in the
before view?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||mag...@enger.priv.no

--- Comment #4 from Magnus Enger mag...@enger.priv.no 2012-02-28 10:22:16 UTC 
---
I have made a note to look at this for NORMARC some time, but not sure when i
can get around to doing it. 

Setting status to Needs Signoff, since there is a patch.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Frédérick Capovilla fcapovi...@live.ca changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Change sponsored?|--- |Sponsored
 AssignedTo|oleon...@myacpl.org |fcapovi...@live.ca

--- Comment #1 from Frédérick Capovilla fcapovi...@live.ca 2012-02-27 
16:55:07 UTC ---
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Frédérick Capovilla fcapovi...@live.ca changed:

   What|Removed |Added

   Attachment #7905|0   |1
is obsolete||

--- Comment #2 from Frédérick Capovilla fcapovi...@live.ca 2012-02-27 
16:59:46 UTC ---
Created attachment 7906
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7906
XSLT Results template improvement : Use the NOT_LOAN authorised values
(Corrected patch)

I noticed I forgot to check $hidelostitems in my new code.

New patch attached

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Frédérick Capovilla fcapovi...@live.ca changed:

   What|Removed |Added

   Attachment #7906|0   |1
is obsolete||

--- Comment #3 from Frédérick Capovilla fcapovi...@live.ca 2012-02-27 
18:19:30 UTC ---
Created attachment 7907
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7907
New version of the initial patch

New version of the patch. Sorry for the inconvenience.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/