[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Blocks||15814 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814 [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains ' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Blocks||16295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 [Bug 16295] marc_modification_templates permission doesn't allow access to modify template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14098 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 M. de Rooy changed: What|Removed |Added Blocks|11413 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 M. de Rooy changed: What|Removed |Added Blocks|11319 | See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Blocks||11413 --- Comment #192 from Jonathan Druart --- /!\ This feature is buggy if the condition and source fields are defined on the same field. See bug 11413. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11395 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Blocks||11383 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Blocks||11319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 marjorie barry-vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #191 from Galen Charlton --- Pushed to master after discussion with Katrin. Thanks, Kyle! That said, this still needs a lot of work, enough that this may end up getting an "experimental" label added to this feature prior to release. Things I've found: - As previously noted, there's no way to move an entire field with all of its subfields. - But if you try -- by specifying a tag but not a subfield -- you can *crash* it: data() is only for con trol fields (generally, just tags below 010) , use subfield() at /home/gmc/koha/Koha/SimpleMARC.pm - When moving/copying fields, it makes no attempt to put them in order. - I can't say I particularly care for the fact that the modification takes places during _staging_. It would be better if it could take place during committing (or at least have an option to do so, or to have a preview mode), to enable the user to adjust their modification rules without having the repeatedly stage the same file. - We need to be more consistent about where new stuff gets configured. There's no particularly good reason why the matching rules should be configured under admin and the modification templates under tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22186|0 |1 is obsolete|| --- Comment #182 from Kyle M Hall --- Created attachment 22393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22393&action=edit Bug 8015: Followup: FIX cp and mv if subfields don't exist. Signed-off-by: Kyle M Hall Signed-off-by: Leila Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22290|0 |1 is obsolete|| --- Comment #189 from Kyle M Hall --- Created attachment 22400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22400&action=edit Bug 8015: QA Followup * Add bug number to database update * Fix capitalization errors * Fix JavaScript string translation errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22293|0 |1 is obsolete|| --- Comment #190 from Kyle M Hall --- Created attachment 22401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22401&action=edit Bug 8015: QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22284|0 |1 is obsolete|| --- Comment #187 from Kyle M Hall --- Created attachment 22398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22398&action=edit Bug 8015: Add user permissions to all languages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22285|0 |1 is obsolete|| --- Comment #188 from Kyle M Hall --- Created attachment 22399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22399&action=edit Bug 8015: Remove references to C4::Koha::Log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22190|0 |1 is obsolete|| --- Comment #186 from Kyle M Hall --- Created attachment 22397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22397&action=edit Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines Signed-off-by: Kyle M Hall Bug 8015: Fix complains from qa tools Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: FIX ui issue Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: The template name is a required field Test plan: Try to add a template with an empty string as name. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22189|0 |1 is obsolete|| --- Comment #185 from Kyle M Hall --- Created attachment 22396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22396&action=edit Bug 8015: Fix template capitalization amd other template issues Signed-off-by: Leila Bug 8015: Fix error where field object is returned instead of field value for fields without subfields Signed-off-by: Leila Bug 8015: Fix bad ordering on function parameters Signed-off-by: Leila Bug 8015: Escape escape characters for strings Signed-off-by: Leila Bug 8015: Fix bad parameter list for direct external call to update_field Signed-off-by: Leila Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield Signed-off-by: Leila Bug 8015: FIX QA issues This patch fixes some stuffs failing qa tests: POD, indentation (tabs), perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22188|0 |1 is obsolete|| --- Comment #184 from Kyle M Hall --- Created attachment 22395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22395&action=edit Bug 8015: Followup Add MARC Modifications Templates Signed-off-by: Kyle M Hall Signed-off-by: Leila Bug 8015: Catch error in the SetUTF8Flag routine The eval avoids the interface to run endlessly if an error occurred. Signed-off-by: Kyle M Hall Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22187|0 |1 is obsolete|| --- Comment #183 from Kyle M Hall --- Created attachment 22394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22394&action=edit Bug 8015 - Add MARC Modifications Templates - Followup Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #22185|0 |1 is obsolete|| --- Comment #181 from Kyle M Hall --- Created attachment 22392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22392&action=edit Bug 8015 - Add MARC Modifications Templates The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import. This tool is useful for altering MARC records from various venders work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields. Each action can also have an optional condition to check the value or existance of another field. The Copy & Move actions also support Regular Expressions, which can be used to automatically modify field values during the copy/move. An example would be to strip out the '$' character in field 020$c. Furthermore, the value for an update can include variables that change each time the template is used. Currently, the system supports two variables, __BRANCHCODE__ which is replaced with the branchcode of the library currently using the template, and __CURRENTDATE__ which is replaced with the current date in ISO format ( -MM-DD ). At its simplist, it can perform functions such as: Copy field 092$a to 952$c At its most complex it can run actions like: Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/ Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #180 from Katrin Fischer --- Test report 1)OK Staging, importing, reverting and cleaning using - stage_file.pl and commit_file.pl - Stage and Staged MARC record management tools 2) (normal) Saving an empty action - fil 3) (minor) Feedback about mandatory fields not quite standard 4) (major) Rule: Copy 650 to 689 - no subfields entered [Wed Oct 23 00:07:58 2013] [error...] [client 127.0.0.1] [Wed Oct 23 00:07:58 2013] stage-marc-import.pl: data() is only for control fields (generally, just tags below 010) , use subfield() at /home/katrin/koha/Koha/SimpleMARC.pm line 188, referer: http://staff.master/cgi-bin/koha/tools/stage-marc-import.pl No feedback in the interface, we should make sure people know that whole fields can't be copied. Maybe subfield should be required to, if it's not a controlfield (Note: controlfields are different for MARC21 and UNIMARC) 5) (?) Rule: Copy 650 a to 689 a Works, but 689 does not exist in my framework - should this be possible? 6) OK Rule: Add/Update 952 $a CPL Add/Update 952 $b CPL Add/Update 952 $y BK Adds items, works nicely 7) OK Rule: Copy 245 $a to 500 $a Regex: s/e/foo Intfoormfoodiatfoo Pfoorl - Works nicely. 8) (normal) Also: Lots of messages in the logs [Wed Oct 23 00:09:46 2013] [error] [client 127.0.0.1] [Wed Oct 23 00:09:46 2013] marc_modification_templates.pl: Use of uninitialized value in string eq at /home/katrin/koha/tools/marc_modification_templates.pl line 70., referer: http://staff.master/cgi-bin/koha/tools/marc_modification_templates.pl [Wed Oct 23 00:10:06 2013] [error] [client 127.0.0.1] [Wed Oct 23 00:10:06 2013] stage-marc-import.pl: Use of uninitialized value $template_id in string eq at /home/katrin/koha/C4/MarcModificationTemplates.pm line 84., referer: http://staff.master/cgi-bin/koha/tools/stage-marc-import.pl X) Possible enhancements: - Allow applying of modification templates on staged and maybe also imported records - Warn people from deleting mandatory fields and subfields - The Add/Update option should have a regex - Ex. set serial flag on LDR Other problems found: - Staging MARC records uploads without selecting a file first Note to myself: File a bug about translation issues coursed logic in templates (building sentences) Kyle, can you please take a look? *hides* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #179 from Kyle M Hall --- Created attachment 22293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22293&action=edit Bug 8015: QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #178 from Kyle M Hall --- Created attachment 22290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22290&action=edit Bug 8015: QA Followup * Add bug number to database update * Fix capitalization errors * Fix JavaScript string translation errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #177 from Kyle M Hall --- Created attachment 22285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22285&action=edit Bug 8015: Remove references to C4::Koha::Log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #176 from Kyle M Hall --- Created attachment 22284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22284&action=edit Bug 8015: Add user permissions to all languages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #175 from Kyle M Hall --- To help manage the large number of patches for this bug, I've squashed into groups, those patches by the same author that were submitted sequentially. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #173 from Kyle M Hall --- Created attachment 22189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22189&action=edit Bug 8015: Fix template capitalization amd other template issues Signed-off-by: Leila Bug 8015: Fix error where field object is returned instead of field value for fields without subfields Signed-off-by: Leila Bug 8015: Fix bad ordering on function parameters Signed-off-by: Leila Bug 8015: Escape escape characters for strings Signed-off-by: Leila Bug 8015: Fix bad parameter list for direct external call to update_field Signed-off-by: Leila Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield Signed-off-by: Leila Bug 8015: FIX QA issues This patch fixes some stuffs failing qa tests: POD, indentation (tabs), perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #174 from Kyle M Hall --- Created attachment 22190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22190&action=edit Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines Signed-off-by: Kyle M Hall Bug 8015: Fix complains from qa tools Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: FIX ui issue Signed-off-by: Bernardo Gonzalez Kriegel Bug 8015: The template name is a required field Test plan: Try to add a template with an empty string as name. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #172 from Kyle M Hall --- Created attachment 22188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22188&action=edit Bug 8015: Followup Add MARC Modifications Templates Signed-off-by: Kyle M Hall Signed-off-by: Leila Bug 8015: Catch error in the SetUTF8Flag routine The eval avoids the interface to run endlessly if an error occurred. Signed-off-by: Kyle M Hall Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #171 from Kyle M Hall --- Created attachment 22187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22187&action=edit Bug 8015 - Add MARC Modifications Templates - Followup Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #170 from Kyle M Hall --- Created attachment 22186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22186&action=edit Bug 8015: Followup: FIX cp and mv if subfields don't exist. Signed-off-by: Kyle M Hall Signed-off-by: Leila Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What|Removed |Added Attachment #21901|0 |1 is obsolete|| Attachment #21902|0 |1 is obsolete|| Attachment #21903|0 |1 is obsolete|| Attachment #21904|0 |1 is obsolete|| Attachment #21905|0 |1 is obsolete|| Attachment #21906|0 |1 is obsolete|| Attachment #21907|0 |1 is obsolete|| Attachment #21908|0 |1 is obsolete|| Attachment #21909|0 |1 is obsolete|| Attachment #21910|0 |1 is obsolete|| Attachment #21911|0 |1 is obsolete|| Attachment #21912|0 |1 is obsolete|| Attachment #21913|0 |1 is obsolete|| Attachment #21914|0 |1 is obsolete|| Attachment #21915|0 |1 is obsolete|| Attachment #21916|0 |1 is obsolete|| Attachment #21917|0 |1 is obsolete|| Attachment #21918|0 |1 is obsolete|| Attachment #21919|0 |1 is obsolete|| Attachment #21920|0 |1 is obsolete|| --- Comment #169 from Kyle M Hall --- Created attachment 22185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22185&action=edit Bug 8015 - Add MARC Modifications Templates The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import. This tool is useful for altering MARC records from various venders work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields. Each action can also have an optional condition to check the value or existance of another field. The Copy & Move actions also support Regular Expressions, which can be used to automatically modify field values during the copy/move. An example would be to strip out the '$' character in field 020$c. Furthermore, the value for an update can include variables that change each time the template is used. Currently, the system supports two variables, __BRANCHCODE__ which is replaced with the branchcode of the library currently using the template, and __CURRENTDATE__ which is replaced with the current date in ISO format ( -MM-DD ). At its simplist, it can perform functions such as: Copy field 092$a to 952$c At its most complex it can run actions like: Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/ Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21808|0 |1 is obsolete|| --- Comment #165 from Bernardo Gonzalez Kriegel --- Created attachment 21918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21918&action=edit Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #168 from Bernardo Gonzalez Kriegel --- Signed! 1) Could you consider squashing this into one... or two patches. This is insane :) 2) Needed follow-up: Help 3) Needed follow-up: Update copyright headers as current usage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21876|0 |1 is obsolete|| --- Comment #167 from Bernardo Gonzalez Kriegel --- Created attachment 21920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21920&action=edit Bug 8015: The template name is a required field Test plan: Try to add a template with an empty string as name. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21809|0 |1 is obsolete|| --- Comment #166 from Bernardo Gonzalez Kriegel --- Created attachment 21919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21919&action=edit Bug 8015: FIX ui issue Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21485|0 |1 is obsolete|| --- Comment #164 from Bernardo Gonzalez Kriegel --- Created attachment 21917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21917&action=edit Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21484|0 |1 is obsolete|| --- Comment #163 from Bernardo Gonzalez Kriegel --- Created attachment 21916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21916&action=edit Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21038|0 |1 is obsolete|| --- Comment #162 from Bernardo Gonzalez Kriegel --- Created attachment 21915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21915&action=edit Bug 8015: Fix complains from qa tools Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21037|0 |1 is obsolete|| --- Comment #161 from Bernardo Gonzalez Kriegel --- Created attachment 21914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21914&action=edit Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines Signed-off-by: Kyle M Hall Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21036|0 |1 is obsolete|| --- Comment #160 from Bernardo Gonzalez Kriegel --- Created attachment 21913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21913&action=edit Bug 8015: FIX QA issues This patch fixes some stuffs failing qa tests: POD, indentation (tabs), perlcritic Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21035|0 |1 is obsolete|| --- Comment #159 from Bernardo Gonzalez Kriegel --- Created attachment 21912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21912&action=edit Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21034|0 |1 is obsolete|| --- Comment #158 from Bernardo Gonzalez Kriegel --- Created attachment 21911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21911&action=edit Bug 8015: Fix bad parameter list for direct external call to update_field Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21033|0 |1 is obsolete|| --- Comment #157 from Bernardo Gonzalez Kriegel --- Created attachment 21910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21910&action=edit Bug 8015: Escape escape characters for strings Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21032|0 |1 is obsolete|| --- Comment #156 from Bernardo Gonzalez Kriegel --- Created attachment 21909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21909&action=edit Bug 8015: Fix bad ordering on function parameters Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21031|0 |1 is obsolete|| --- Comment #155 from Bernardo Gonzalez Kriegel --- Created attachment 21908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21908&action=edit Bug 8015: Fix error where field object is returned instead of field value for fields without subfields Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21030|0 |1 is obsolete|| --- Comment #154 from Bernardo Gonzalez Kriegel --- Created attachment 21907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21907&action=edit Bug 8015: Fix template capitalization amd other template issues Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21029|0 |1 is obsolete|| --- Comment #153 from Bernardo Gonzalez Kriegel --- Created attachment 21906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21906&action=edit Bug 8015: Catch error in the SetUTF8Flag routine The eval avoids the interface to run endlessly if an error occurred. Signed-off-by: Kyle M Hall Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21028|0 |1 is obsolete|| --- Comment #152 from Bernardo Gonzalez Kriegel --- Created attachment 21905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21905&action=edit Bug 8015: Followup Add MARC Modifications Templates Signed-off-by: Kyle M Hall Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21027|0 |1 is obsolete|| --- Comment #151 from Bernardo Gonzalez Kriegel --- Created attachment 21904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21904&action=edit Bug 8015 - Add MARC Modifications Templates - Followup Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21026|0 |1 is obsolete|| --- Comment #150 from Bernardo Gonzalez Kriegel --- Created attachment 21903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21903&action=edit Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21025|0 |1 is obsolete|| --- Comment #149 from Bernardo Gonzalez Kriegel --- Created attachment 21902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21902&action=edit Bug 8015: Followup: FIX cp and mv if subfields don't exist. Signed-off-by: Kyle M Hall Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #21024|0 |1 is obsolete|| --- Comment #148 from Bernardo Gonzalez Kriegel --- Created attachment 21901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21901&action=edit Bug 8015 - Add MARC Modifications Templates The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import. This tool is useful for altering MARC records from various venders work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields. Each action can also have an optional condition to check the value or existance of another field. The Copy & Move actions also support Regular Expressions, which can be used to automatically modify field values during the copy/move. An example would be to strip out the '$' character in field 020$c. Furthermore, the value for an update can include variables that change each time the template is used. Currently, the system supports two variables, __BRANCHCODE__ which is replaced with the branchcode of the library currently using the template, and __CURRENTDATE__ which is replaced with the current date in ISO format ( -MM-DD ). At its simplist, it can perform functions such as: Copy field 092$a to 952$c At its most complex it can run actions like: Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/ Signed-off-by: Leila Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No koha-qa errors One comment to rule them all (please squash this patchset!) I think I tested all possible cases: add, copy, delete, move, regex find and replace (text and also changing branch in 952ab using __BRANCHNAME__) Unit test run fine. No help file yet but not a functional requirement. Think is a good adition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #147 from Paul Poulain --- (In reply to Jonathan Druart from comment #146) > > 2) Help File. This is important for prospective users and DocManager job. > > At last a minimal one could help testing > > I don't have the time to do that. Maybe Kyle? well... I would also add that your english is, how to say... a little bit french :D :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #146 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #144) > What's missing: > > 1) Check that template name is non empty. If you press "Create template" > can create as many "no name" templates as you wish. Avoiding duplicates > could be cool. Done in the last patch. > 2) Help File. This is important for prospective users and DocManager job. > At last a minimal one could help testing I don't have the time to do that. Maybe Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #145 from Jonathan Druart --- Created attachment 21876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21876&action=edit Bug 8015: The template name is a required field Test plan: Try to add a template with an empty string as name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #144 from Bernardo Gonzalez Kriegel --- Testing this! Tests now run without problems :) For me this works, I've tried add, copy, delete, move, regex find and replace (text and also changing branch in 952ab using __BRANCHNAME__) What's missing: 1) Check that template name is non empty. If you press "Create template" can create as many "no name" templates as you wish. Avoiding duplicates could be cool. 2) Help File. This is important for prospective users and DocManager job. At last a minimal one could help testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #143 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #139) I didn't change the unit test file after changing the table structure. Now it is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #21486|0 |1 is obsolete|| Attachment #21487|0 |1 is obsolete|| --- Comment #141 from Jonathan Druart --- Created attachment 21808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21808&action=edit Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #142 from Jonathan Druart --- Created attachment 21809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21809&action=edit Bug 8015: FIX ui issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #140 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #139) > Is there anything to do before running tests? No! I will fix that asap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #139 from Bernardo Gonzalez Kriegel --- Is there anything to do before running tests? - prove t/SimpleMarc.t All tests successful. Files=1, Tests=37, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.04 cusr 0.00 csys = 0.06 CPU) Result: PASS - prove t/db_dependent/MarcModificationTemplates.t ... Test Summary Report --- t/db_dependent/MarcModificationTemplates.t (Wstat: 3584 Tests: 74 Failed: 14) Failed tests: 25-28, 35-39, 48-51, 65 Non-zero exit status: 14 Files=1, Tests=74, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.22 cusr 0.02 csys = 0.28 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What|Removed |Added Keywords||rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community. ||org When did the bot||2013-09-29 last check this|| --- Comment #138 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #137 from Jonathan Druart --- These 4 last patches remove the eval. All 19 patches pass qa tools. Test plan: - Retest *all* the feature with complex actions. - prove t/SimpleMarc.t - prove t/db_dependent/MarcModificationTemplates.t Have fun and good luck! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #136 from Jonathan Druart --- Created attachment 21487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21487&action=edit Bug 8015: FIX ui issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #134 from Jonathan Druart --- Created attachment 21485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21485&action=edit Bug 8015: Get rid of eval for evaluating =~ m// Koha::SimpleMarc::field_equals uses eval in order to check if a string matches a pattern. Now this eval is removed and the "regex" variable does not contain the regex separated character (/ or |). Regression: Before this patch, the user was able to user a modifier. Now it is not possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #135 from Jonathan Druart --- Created attachment 21486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21486&action=edit Bug 8015: Get rid of the eval for substitution Before this patch, the regex substitution was contain into only one variable (e.g. my $regex = "/foo/bar/i"). Now each member of the regex is stored into a field in the marc_modification_template_actions sql table. In order to avoid a complex code, only modifiers i and g are take into account. Note: If you already add the mmta table, you have to drop it. This patch also adds a foreign key from mmta to mmt tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #21371|0 |1 is obsolete|| --- Comment #133 from Jonathan Druart --- Created attachment 21484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21484&action=edit Bug 8015: Get rid of the eval in ModifyRecordWithTemplate This patch removes the use of eval in the C4::MarcModificationTemplates::ModifyRecordWithTemplate routine. Now this routine call the wanted modification routine with the list of parameters. This call is done only if the condition is respected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #132 from Jonathan Druart --- (In reply to Galen Charlton from comment #131) > I think it would be better to drop the notion of using a string eval at all > and just rewrite ModifyRecordWithTemplate to become a dispatcher that calls > the modification subroutines directly. I say "just rewrite" because, for > once, I think the work can be confined to a single routine. > > Also, the patchset currently includes no tests that run > ModifyRecordWithTemplate directly -- rather a lack, IMO. Resolving that can > go hand-in-hand with removing the eval. I will try to do something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #131 from Galen Charlton --- (In reply to Paul Poulain from comment #129) > I hadn't checked what the eval was related to, I assumed it was safe. > I agree with your point : failed QA, this could probably be exploited. > > Jared, would you be pleased if the parameters where sanitized, even if the > eval is still here ? I think it would be better to drop the notion of using a string eval at all and just rewrite ModifyRecordWithTemplate to become a dispatcher that calls the modification subroutines directly. I say "just rewrite" because, for once, I think the work can be confined to a single routine. Also, the patchset currently includes no tests that run ModifyRecordWithTemplate directly -- rather a lack, IMO. Resolving that can go hand-in-hand with removing the eval. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #130 from Jared Camins-Esakov --- (In reply to Paul Poulain from comment #129) > I hadn't checked what the eval was related to, I assumed it was safe. > I agree with your point : failed QA, this could probably be exploited. > > Jared, would you be pleased if the parameters where sanitized, even if the > eval is still here ? I see no way to sanitize the input while using the eval. The entire point of the eval is to allow arbitrary code to be run through the regex. Maybe it would be better to have two boxes, one for the match and one for the replacement? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #129 from Paul Poulain --- (In reply to Jared Camins-Esakov from comment #128) > This is not a minor violation. As far as I can tell, there is unsanitized > user input being run directly. Consider the following code: > I was unable to test this example, since I couldn't get MARC modification > templates to work during a cursory test, but I'm sure you see my point. I hadn't checked what the eval was related to, I assumed it was safe. I agree with your point : failed QA, this could probably be exploited. Jared, would you be pleased if the parameters where sanitized, even if the eval is still here ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015
--- Comment #128 from Jared Camins-Esakov ---
(In reply to Paul Poulain from comment #127)
> Katrin, please reconsider your position = this improvement is very important
> for libraries, much more than a technical perlcritic violation.
> My opinion here is that we must decide that the user interest is more
> important than this single violation.
> (the law must serve us, we must not serve the law)
This is not a minor violation. As far as I can tell, there is unsanitized user
input being run directly. Consider the following code:
eval { $eval }; != eval $eval;
my $r = q|/foo/fee/; print "hi";|;
my @values = ("foo", "bar", "foobar");
for my $v ( @values ) {
eval {"\$v =~ s$r"};
say $v;
eval "\$v =~ s$r";
say $v;
}
Result: "hi" is printed by each eval. This example is fairly benign, but what
if the regex were as follows: my $r = q|/whatever/something/; require
C4::Context; $dbh = C4::Context->dbh; $dbh->do("DELETE FROM issues;")|;
I was unable to test this example, since I couldn't get MARC modification
templates to work during a cursory test, but I'm sure you see my point.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Paul Poulain changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #127 from Paul Poulain --- Katrin, please reconsider your position = this improvement is very important for libraries, much more than a technical perlcritic violation. My opinion here is that we must decide that the user interest is more important than this single violation. (the law must serve us, we must not serve the law) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015
--- Comment #126 from Jonathan Druart ---
Created attachment 21371
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21371&action=edit
Bug 8015: Followup QA issues
eval { $eval }; != eval $eval;
my $r = q|/foo/fee/|;
my @values = ("foo", "bar", "foobar");
for my $v ( @values ) {
eval {"\$v =~ s$r"};
say $v;
eval "\$v =~ s$r";
say $v;
}
will display:
foo
fee
bar
bar
foobar
feebar
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #125 from Paul Poulain --- (In reply to Katrin Fischer from comment #124) > We have 12 people on the CC list for this bug, which makes me think it's > kinda important :) Agreed, bulk modification of biblio IS important to libraries... > Can someone weigh in about the perlcritic issues please? ... much more than this perlcritic problem. PBP, page 161 says many things that are unclear to me. >From the user point of view, though, I think this patch should go in ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16473|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16480|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #18441|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16476|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16475|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16478|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16472|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16479|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16471|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16470|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #16468|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #124 from Katrin Fischer --- We have 12 people on the CC list for this bug, which makes me think it's kinda important :) Can someone weigh in about the perlcritic issues please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #123 from Jonathan Druart --- (In reply to Katrin Fischer from comment #122) > Hm, can someone help us out here fixing the perl critic violations? To me, there are only 2 ways to remove theses warnings: 1/ adds a rule to the perlcriticrc file. 2/ write an unreadable code. (i.e. eval "\$value =~ s$regex"; could be written splitting the $regex var on the first character (/ or |, etc.). In both case it is not a good thing to do. Perl::Critic provides recommendations, sometimes I think we are not obliged to follow them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #122 from Katrin Fischer --- Hm, can someone help us out here fixing the perl critic violations? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #17037|0 |1 is obsolete|| --- Comment #118 from Jonathan Druart --- Created attachment 21036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21036&action=edit Bug 8015: FIX QA issues This patch fixes some stuffs failing qa tests: POD, indentation (tabs), perlcritic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #119 from Jonathan Druart --- Created attachment 21037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21037&action=edit Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #121 from Jonathan Druart --- Rebased patches. I have no idea how to remove 2 others warnings. It's a Perl Critic recommendation not to eval a literal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #120 from Jonathan Druart --- Created attachment 21038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21038&action=edit Bug 8015: Fix complains from qa tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #116 from Jonathan Druart --- Created attachment 21034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21034&action=edit Bug 8015: Fix bad parameter list for direct external call to update_field Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What|Removed |Added Attachment #17036|0 |1 is obsolete|| --- Comment #117 from Jonathan Druart --- Created attachment 21035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21035&action=edit Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
