[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz ---

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #52 from Lucas Gass --- Thanks Jonathan, I have backported the last patch: "(QA follow-up) Fix test for backdated return" -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #51 from Jonathan Druart --- (In reply to Lucas Gass from comment #50) > backported to 20.05.x for 20.05.03 Lucas, you missed the last patch "(QA follow-up) Fix test for backdated return", it's not in 20.05.x -- You ar

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 relea

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #49 from Jonathan Druart --- Follow-up pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bug

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #48 from Martin Renvoize --- Created attachment 107140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107140&action=edit Bug 8338: (QA follow-up) Fix test for backdated return A test for CalculateFinesO

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #47 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released i

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Attachment #106209|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Attachment #106154|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Attachment #106153|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Attachment #106155|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Sta

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Attachment #106152|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #41 from Martin Renvoize --- Created attachment 106209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106209&action=edit Bug 8338: (QA follow-up) Clean up warning This patch moves the accountline->store

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #40 from Martin Renvoize --- Hmm... not it's not.. we already check for defined in the relevant line.. bit confused -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #39 from Martin Renvoize --- Aha.. it's because with this patch the return of _FixAccountOnReturn is '0' as opposed to a result object.. but as the note says in the routine that doesn't signify an error. I'll add a little

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #38 from Martin Renvoize --- The nasty looking warn is actually introduced with Bug 21206: Replace C4::Items::GetItem where `->{itemnumber}` is replaced with `->itemnumber`. You say the warning doesn't appear at all prior

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 f

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #36 from Martin Renvoize --- Created attachment 106155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106155&action=edit Bug 8338: (QA follow-up) Fix perlcritic error -- You are receiving this mail bec

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Attachment #105496|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Attachment #105497|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Attachment #105498|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #32 from Katrin Fischer --- I've filed a new bug for the translation issue noted in comment#25: Bug 25833 - "Overpayment refund" in charge descriptions is not translatable -- You are receiving this mail because: You are

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #31 f

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receivin

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Depends on|22539 | Referenced Bugs: https:

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| CC|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #30

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #29 from Martin Renvoize --- Created attachment 105498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105498&action=edit Bug 8338: (follow-up) Fix test This patch moves the previous test introduced with

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Attachment #104900|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Attachment #104901|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are recei

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #26 from Katrin Fischer --- I was ready to pass QA, but tests fail (pass with master): kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 29/48 _FixOverdues

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #25 from Katrin Fischer --- I wonder if you have seen bug 13044 - we discussed how to merge the book drop with the specify return date feature. Test case 1 makes perfect sense to me: | 3 | NULL |2 | OVERDU

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Keywords|RM_priority |rel_20_11_target -- You a

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #24 from Andrew Fuerste-Henry --- Oh, I should mention that in the course of your test plan I ran into an unrelated error. Confirmed it happens without your patch, filed bug 25508 for it. At step 5 of test 2, when you pay

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #104842|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #104841|0 |1 is obsolete|

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You ar

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #21 from Andrew Fuerste-Henry --- This looks good except for one extremely minor quibble -- the acount_offsets entry for the credit created in test 2 shows type "Manual credit," which is misleading on a credit generated au

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are re

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #20 from Martin Renvoize --- Bonus points.. check that the offsets (account details) make sense from each perspective.. looking at them from the payment, refund credit and overdue fine perspectives. -- You are receiving

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #19 from Martin Renvoize --- Test Plan.. play with accounts and backdated returns.. report any oddities. More seriously. Test One 1 - Checkout an item to a patron and make it overdue (can backdate the checkout) 2 - Make s

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolution

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #17 from Martin Renvoize --- Created attachment 104841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104841&action=edit Bug 8338: Unit Tests -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #18 from Martin Renvoize --- Created attachment 104842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104842&action=edit Bug 8338: Remove zero amount overdues on backdated returns where appropriate This

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: h

[Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Summary|fines not cleared with |Fines not cleared with

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Bug 8338 depends on bug 22512, which changed state. Bug 22512 Summary: accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 What|Removed |A

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Depends on||22512 Referenced Bugs: h

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #15 from Kyle M Hall --- (In reply to Martin Renvoize from comment #13) > I think at this point this comes down to the question I asked in comment 11 > bug 22359 > > > Question: This patch uses the existing UpdateFine (a

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #14 from Martin Renvoize --- bug 22539 even.. oops. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-co

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #13 from Martin Renvoize --- I think at this point this comes down to the question I asked in comment 11 bug 22359 > Question: This patch uses the existing UpdateFine (and as such > Koha::Account->adjust) functionality.

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@col

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving th

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #12 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > It looks like bug 10694 will fix this: > > "Sometimes libraries need to backdate returns further back in time than > Koha's dropbox mode will allow.

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC|

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #9 from Aaron Sakovich --- (In reply to Chris Cormack from comment #8) > One thing you learn with working with libraries, is that assuming that the > way your library does it is the same way others do it is the single bigge

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #8 from Chris Cormack --- (In reply to Aaron Sakovich from comment #7) > As an end-user, I've got to agree with Melia, Nicole, and Kyle. This is > totally unexpected behavior, and I can't quite wrap my head around the > bus

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Aaron Sakovich changed: What|Removed |Added CC||asakov...@hmcpl.org --- Comm

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #6 from Chris Cormack --- Probably doesn't matter whether it's an enhancement or bug unless a patch to change it actually exists. But it is working as designed, adding the ability for it to wipe fines is therefore an enhanc

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe.

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- C

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #3 from Nicole C. Engard --- What's the point of changing the day ... except to get rid of the fines? That at least is the point here in the US. -- You are receiving this mail because: You are the assignee for the bug. Y

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com

[Koha-bugs] [Bug 8338] fines not cleared with dropbox mode

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Melia Meggs changed: What|Removed |Added Depends on||5644 -- You are receiving this