[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Blocks||21991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21991 [Bug 21991] Displaying more rows on report results does not work for reports with parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Blocks||21984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21984 [Bug 21984] Unable to load second page of results for reports with reused parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Jonathan Druart changed: What|Removed |Added Blocks||21906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21906 [Bug 21906] WHERE clause doesn't like % in CONCAT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #22 from Nick Clemens --- Enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer changed: What|Removed |Added Attachment #73802|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 73807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73807&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected. i.e. 5 different values that are those of the URL. Signed-off-by: Victor Grousset Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer changed: What|Removed |Added QA Contact|julian.maur...@biblibre.com |katrin.fisc...@bsz-bw.de --- Comment #19 from Katrin Fischer --- Stole this one from you Julian, hope it's ok! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer changed: What|Removed |Added Text to go in the|This new feature allows |This new feature allows release notes|parameters to be re-used in |parameters to be re-used in |reports. When a report asks |reports. When a report asks |for two variables using the |for two variables using the |same name and |same name and |type/authorised value they |type/authorised value they |will be combined into a |will be combined into a |single rquest. i.e. |single input field on the | |form. i.e. |SELECT | |* |SELECT * |FROM items |FROM |WHERE |items |homebranch=<> AND |homebranch=<> AND |branches>> AND itype=<> |branches>> AND itype=<> |Will ask| |for only 2 parameters when |Will ask |run, Branchcode and Item|for only 2 parameters when |type|run, Branchcode and Item ||type. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Charles Farmer changed: What|Removed |Added Attachment #73691|0 |1 is obsolete|| --- Comment #18 from Charles Farmer --- Created attachment 73802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73802&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected. i.e. 5 different values that are those of the URL. Signed-off-by: Victor Grousset Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #73549|0 |1 is obsolete|| --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 73691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73691&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected. i.e. 5 different values that are those of the URL. Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Text to go in the||This new feature allows release notes||parameters to be re-used in ||reports. When a report asks ||for two variables using the ||same name and ||type/authorised value they ||will be combined into a ||single rquest. i.e. || ||SELECT ||* ||FROM items ||WHERE ||homebranch=<> AND ||holdingbranch=<> AND itype=<> || ||Will ask ||for only 2 parameters when ||run, Branchcode and Item ||type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Attachment #73548|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 73549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73549&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #15 from Nick Clemens --- (In reply to Nick Clemens from comment #14) > Needs to be rebased on bug 20052 - adding get_prepped_report method to > Koha/Report.pm and covering with tests Nvm, I didn't add this method - will be a future enh, but out of scope here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #14 from Nick Clemens --- Needs to be rebased on bug 20052 - adding get_prepped_report method to Koha/Report.pm and covering with tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Attachment #70735|0 |1 is obsolete|| Attachment #70736|0 |1 is obsolete|| --- Comment #13 from Nick Clemens --- Created attachment 73548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73548&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #12 from Katrin Fischer --- What I think is: Don't make the option, because the chance of messing up existing reports is very very slim. They will remain working as they work now if parameters are named differently. If there exist parameters who already are named the exactly same, the patch will take effect, but then we can also assume that this is indeed the wanted behaviour. Of course we should add a nice note to the release notes to highlight the new feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Julian Maurice changed: What|Removed |Added QA Contact||julian.maur...@biblibre.com Status|Signed Off |ASSIGNED --- Comment #11 from Julian Maurice --- (In reply to Nick Clemens from comment #10) > That works for me, Jonathan or Katrin, any input? If it sounds good I will > try to work on that or you can feel free Julian Changing status to ASSIGNED. Feel free to change it back directly to Signed off once the patch is ready. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Nick Clemens --- That works for me, Jonathan or Katrin, any input? If it sounds good I will try to work on that or you can feel free Julian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #9 from Julian Maurice --- (In reply to Nick Clemens from comment #8) > I added it only for old reports, if a library has been using a report with > duplicated inputs this will be a change in behavior and may be > unexpected/unwanted. > > Am happy to reconsider or explore alternate options, this seemed the > simplest at the time I hadn't thought about old reports. It makes sense... but what do you think about renaming all parameters (appending a number for instance) of existing reports in an updatedatabase script ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #8 from Nick Clemens --- I added it only for old reports, if a library has been using a report with duplicated inputs this will be a change in behavior and may be unexpected/unwanted. Am happy to reconsider or explore alternate options, this seemed the simplest at the time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #7 from Julian Maurice --- Is the new option really necessary ? I can't imagine a use case where someone would like to not use this feature. And if users really want to repeat themselves they can just rename one of the parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett changed: What|Removed |Added Attachment #70592|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 70735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70735&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch set adds a new colum to saved_sql 'combine_params' If set, parameters that have the same name and data type will only be asked for once from the user To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are still asked for five parameters 6 - Edit report, note the 'Combine params' options, say YES! 7 - Re-run the report, you shoudl be asked for three parameters 8 - Verify the results reflect the supplied parameters 9 - Create a new report (perhaps something more substantive) 10 - Save with 'combine params' checke 11 - View in saved reports and see the new 'combine params' column 12 - Verify it is correctly set 13 - Run the report and verify correct results 14 - prove -v t/db_dependent/Reports/Guided.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett changed: What|Removed |Added Attachment #70685|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 70736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70736&action=edit Bug 9634 [QA Followup] - Add new column to kohastructure.sql Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #4 from Kyle M Hall --- Created attachment 70685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70685&action=edit Bug 9634 [QA Followup] - Add new column to kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from M. Tompsett --- Failed to include update for fresh install, only upgrade alter table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Katrin Fischer changed: What|Removed |Added CC||claire_grav...@hotmail.com, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added CC||jza...@bywatersolutions.com ||, k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Assignee|tomasco...@gmail.com|n...@bywatersolutions.com Keywords||Academy CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #2 from Nick Clemens --- Created attachment 70592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70592&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch set adds a new colum to saved_sql 'combine_params' If set, parameters that have the same name and data type will only be asked for once from the user To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are still asked for five parameters 6 - Edit report, note the 'Combine params' options, say YES! 7 - Re-run the report, you shoudl be asked for three parameters 8 - Verify the results reflect the supplied parameters 9 - Create a new report (perhaps something more substantive) 10 - Save with 'combine params' checke 11 - View in saved reports and see the new 'combine params' column 12 - Verify it is correctly set 13 - Run the report and verify correct results 14 - prove -v t/db_dependent/Reports/Guided.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #1 from Tomás Cohen Arazi --- Parameters are passed through CGI in a way they are processed in order. A way of mapping parameter value to the pair (name,authval) (kind of using it as an ID) is needed for the task. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/