[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||21749


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21749
[Bug 21749] Importing MARC frameworks from pre-9701 fails
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #50 from Nick Clemens  ---
Enhancement, not backported for 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This report adds default|This adds default
  release notes|indicators to biblio|indicators to bibliographic
   |frameworks. Table   |frameworks. The table
   |marc_tag_structure is   |marc_tag_structure is
   |adjusted. In order to make  |adjusted. In order to make
   |effective use of this   |effective use of this
   |enhancement, you may want   |enhancement, you may want
   |to add values in MARC   |to add values in your MARC
   |frameworks administration.  |frameworks administration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #49 from Jonathan Druart  
---
Patches pushed to master for 18.05.

Congratulations Joachim for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

  Text to go in the||This report adds default
  release notes||indicators to biblio
   ||frameworks. Table
   ||marc_tag_structure is
   ||adjusted. In order to make
   ||effective use of this
   ||enhancement, you may want
   ||to add values in MARC
   ||frameworks administration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20547

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #48 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #47)
> (In reply to Marcel de Rooy from comment #42)
> > Comment on attachment 73781 [details] [review] [review]
> > Bug 9701: (QA follow-up) Fix indentation and some strings
> > 
> > This patch continually generates malloc errors and other git problems with
> > me. It seems that we do not need it too. I have no qa warnings about tabs.
> 
> Strange, but I am not attached to it.

Comment24 for instance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14769

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|14769   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||14769


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks|14769   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #47 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #42)
> Comment on attachment 73781 [details] [review]
> Bug 9701: (QA follow-up) Fix indentation and some strings
> 
> This patch continually generates malloc errors and other git problems with
> me. It seems that we do not need it too. I have no qa warnings about tabs.

Strange, but I am not attached to it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #46 from Marcel de Rooy  ---
Created attachment 73845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73845=edit
Bug 9701: (QA follow-up) DBIx schema changes

Changes in MarcTagStructure.pm

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #73780|0   |1
is obsolete||
  Attachment #73782|0   |1
is obsolete||
  Attachment #73783|0   |1
is obsolete||

--- Comment #44 from Marcel de Rooy  ---
Created attachment 73843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73843=edit
Bug 9701: Configure default indicator

This patch adds the possibility to define default indicators in
the MARC frameworks. It adds 2 columns in the marc_tag_structure table in
the database in order to accomplish this. All files that reference this
table have also been updated to reflect these added fields.

Test: Add or edit a MARC framework. In the Field list should be 2 extra
columns. It should be possible to add default indicators (1 character)
in these fields. Nothing else should have changed in the meantime.
The default indicator values are not yet visible in the cataloguing module.

The default values are also loaded in the cataloguing form.

Test: Define default values in some MARC framework. Go to cataloguing
and create a new record using this framework. Verify that the defined
defaults are visible when set. Verify the default is empty (as before)
if no default was set. Verify that if the default is changed, the
record is saved with the manually changed value. Verify that upon
changing such a new record, the manually set indicator value is used
and not the default one from the framework.

Don't forget to run database and database schema update

Signed-off-by: Eugene Jose Espinoza 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #45 from Marcel de Rooy  ---
Created attachment 73844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73844=edit
Bug 9701: (follow-up) Adjust tests

Test plan:

prove t/db_dependent/Biblio.t
should be green

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #43 from Marcel de Rooy  ---
(In reply to M. Tompsett from comment #34)
> t/db_dependent/Biblio.t is failing... there is a difference between unsafe
> and empty call to GetMarcStructure for some reason. Haven't traced it back
> enough. This is a side issue that is failing this bug.

I'm having the impression that the third patch changing forlibrarian to 1 is
not needed. We only need to flush the cache once ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #73781|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Comment on attachment 73781
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73781
Bug 9701: (QA follow-up) Fix indentation and some strings

This patch continually generates malloc errors and other git problems with me.
It seems that we do not need it too. I have no qa warnings about tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #41 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #40)
> Hi Marcel, can you please take care of QA here as your patch builds on it?

Yes I will. They are related but do not really depend on each other.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #40 from Katrin Fischer  ---
Hi Marcel, can you please take care of QA here as your patch builds on it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #37 from Nick Clemens  ---
Created attachment 73781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73781=edit
Bug 9701: (QA follow-up) Fix indentation and some strings

- Fixes tabs pointed out by the QA script.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Nick Clemens  changed:

   What|Removed |Added

  Attachment #72010|0   |1
is obsolete||
  Attachment #72011|0   |1
is obsolete||
  Attachment #72012|0   |1
is obsolete||
  Attachment #72986|0   |1
is obsolete||

--- Comment #36 from Nick Clemens  ---
Created attachment 73780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73780=edit
Bug 9701: Configure default indicator

This patch adds the possibility to define default indicators in
the MARC frameworks. It adds 2 columns in the marc_tag_structure table in
the database in order to accomplish this. All files that reference this
table have also been updated to reflect these added fields.

Test: Add or edit a MARC framework. In the Field list should be 2 extra
columns. It should be possible to add default indicators (1 character)
in these fields. Nothing else should have changed in the meantime.
The default indicator values are not yet visible in the cataloguing module.

The default values are also loaded in the cataloguing form.

Test: Define default values in some MARC framework. Go to cataloguing
and create a new record using this framework. Verify that the defined
defaults are visible when set. Verify the default is empty (as before)
if no default was set. Verify that if the default is changed, the
record is saved with the manually changed value. Verify that upon
changing such a new record, the manually set indicator value is used
and not the default one from the framework.

Don't forget to run database and database schema update

Signed-off-by: Eugene Jose Espinoza 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #39 from Nick Clemens  ---
Created attachment 73783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73783=edit
Bug 9701: Followup to make test pass

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #38 from Nick Clemens  ---
Created attachment 73782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73782=edit
Bug 9701: (follow-up) Adjust tests

Test plan:

prove t/db_dependent/Biblio.t
should be green

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #35 from M. Tompsett  ---
Created attachment 72986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72986=edit
Bug 9701: Followup to make test pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #34 from M. Tompsett  ---
t/db_dependent/Biblio.t is failing... there is a difference between unsafe and
empty call to GetMarcStructure for some reason. Haven't traced it back enough.
This is a side issue that is failing this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #33 from Josef Moravec  ---
(In reply to Maksim Sen from comment #32)
> 
> After applying the patches I had this:
> prove t/db_dependent/Biblio.t 
> t/db_dependent/Biblio.t .. 7/9 DBD::mysql::st execute failed: Unknown column
> 'ind1_defaultvalue' in 'field list' 

did you perform database update?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Maksim Sen  changed:

   What|Removed |Added

 CC||maksim@inlibro.com

--- Comment #32 from Maksim Sen  ---
Hey Josef,

I tried doing this test:
prove t/db_dependent/Biblio.t
should be green


Before applying the patches I had this:
prove t/db_dependent/Biblio.t 
t/db_dependent/Biblio.t .. ok   
All tests successful.
Files=1, Tests=9,  2 wallclock secs ( 0.05 usr  0.01 sys +  1.91 cusr  0.09
csys =  2.06 CPU)
Result: PASS


After applying the patches I had this:
prove t/db_dependent/Biblio.t 
t/db_dependent/Biblio.t .. 7/9 DBD::mysql::st execute failed: Unknown column
'ind1_defaultvalue' in 'field list' [for Statement "SELECT
tagfield,liblibrarian,libopac,mandatory,repeatable,ind1_defaultvalue,ind2_defaultvalue
FROM marc_tag_structure 
WHERE frameworkcode=? 
ORDER BY tagfield" with ParamValues: 0=''] at
/inlibro/git/koha-master-dev-inlibro/C4/Biblio.pm line 990.
DBD::mysql::st fetchrow failed: fetch() without execute() [for Statement
"SELECT
tagfield,liblibrarian,libopac,mandatory,repeatable,ind1_defaultvalue,ind2_defaultvalue
FROM marc_tag_structure 
WHERE frameworkcode=? 
ORDER BY tagfield" with ParamValues: 0=''] at
/inlibro/git/koha-master-dev-inlibro/C4/Biblio.pm line 993.

#   Failed test 'expect 6 internals'
#   at t/db_dependent/Biblio.t line 436.
#  got: '0'
# expected: '6'

#   Failed test 'check lib'
#   at t/db_dependent/Biblio.t line 437.
#  got: '0'
# expected: '1'

#   Failed test 'check tab'
#   at t/db_dependent/Biblio.t line 438.
#  got: '0'
# expected: '1'

#   Failed test 'check mandatory'
#   at t/db_dependent/Biblio.t line 439.
#  got: '0'
# expected: '1'

#   Failed test 'check repeatable'
#   at t/db_dependent/Biblio.t line 440.
#  got: '0'
# expected: '1'

#   Failed test 'check indicator 1 default value'
#   at t/db_dependent/Biblio.t line 442.
#  got: '0'
# expected: '1'

#   Failed test 'check indicator 2 default value'
#   at t/db_dependent/Biblio.t line 443.
#  got: '0'
# expected: '1'
# Looks like you failed 7 tests of 8.

#   Failed test 'IsMarcStructureInternal'
#   at t/db_dependent/Biblio.t line 444.
# Looks like you failed 1 test of 9.
t/db_dependent/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests 

Test Summary Report
---
t/db_dependent/Biblio.t (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  8
  Non-zero exit status: 1
Files=1, Tests=9,  3 wallclock secs ( 0.05 usr  0.00 sys +  2.01 cusr  0.10
csys =  2.16 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #31 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #30)
> Applying: Bug 9701: (QA follow-up) Fix indentation and some strings
> *** Error in `git': malloc(): memory corruption: 0x00bfc340 ***
> fatal: sha1 information is lacking or useless (C4/Biblio.pm).

I am not understand what is going here - I tried now, and it applied cleanly on
current master...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #30 from Marcel de Rooy  ---
Applying: Bug 9701: (QA follow-up) Fix indentation and some strings
*** Error in `git': malloc(): memory corruption: 0x00bfc340 ***
fatal: sha1 information is lacking or useless (C4/Biblio.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #29 from Josef Moravec  ---
Marcel, try it now, it applies cleanly on current master for me now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Josef Moravec  changed:

   What|Removed |Added

  Attachment #71929|0   |1
is obsolete||
  Attachment #71930|0   |1
is obsolete||
  Attachment #71931|0   |1
is obsolete||

--- Comment #26 from Josef Moravec  ---
Created attachment 72010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72010=edit
Bug 9701: Configure default indicator

This patch adds the possibility to define default indicators in
the MARC frameworks. It adds 2 columns in the marc_tag_structure table in
the database in order to accomplish this. All files that reference this
table have also been updated to reflect these added fields.

Test: Add or edit a MARC framework. In the Field list should be 2 extra
columns. It should be possible to add default indicators (1 character)
in these fields. Nothing else should have changed in the meantime.
The default indicator values are not yet visible in the cataloguing module.

The default values are also loaded in the cataloguing form.

Test: Define default values in some MARC framework. Go to cataloguing
and create a new record using this framework. Verify that the defined
defaults are visible when set. Verify the default is empty (as before)
if no default was set. Verify that if the default is changed, the
record is saved with the manually changed value. Verify that upon
changing such a new record, the manually set indicator value is used
and not the default one from the framework.

Don't forget to run database and database schema update

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #28 from Josef Moravec  ---
Created attachment 72012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72012=edit
Bug 9701: (follow-up) Adjust tests

Test plan:

prove t/db_dependent/Biblio.t
should be green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #27 from Josef Moravec  ---
Created attachment 72011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72011=edit
Bug 9701: (QA follow-up) Fix indentation and some strings

- Fixes tabs pointed out by the QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #25 from Josef Moravec  ---
Probably my bad, I will try to rebase and re-upload patches, but probably not
today, and tomorow I am out, so please be patient...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from Marcel de Rooy  ---
My git does not like that second patch..

Applying: Bug 9701: (QA follow-up) Fix indentation and some strings
*** Error in `git': malloc(): memory corruption: 0x02837340 ***
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
Repository lacks necessary blobs to fall back on 3-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #23 from Josef Moravec  ---
Created attachment 71931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71931=edit
Bug 9701: (follow-up) Adjust tests

Test plan:

prove t/db_dependent/Biblio.t
should be green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Josef Moravec  changed:

   What|Removed |Added

  Attachment #53403|0   |1
is obsolete||
  Attachment #53404|0   |1
is obsolete||

--- Comment #21 from Josef Moravec  ---
Created attachment 71929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71929=edit
Bug 9701: Configure default indicator

This patch adds the possibility to define default indicators in
the MARC frameworks. It adds 2 columns in the marc_tag_structure table in
the database in order to accomplish this. All files that reference this
table have also been updated to reflect these added fields.

Test: Add or edit a MARC framework. In the Field list should be 2 extra
columns. It should be possible to add default indicators (1 character)
in these fields. Nothing else should have changed in the meantime.
The default indicator values are not yet visible in the cataloguing module.

The default values are also loaded in the cataloguing form.

Test: Define default values in some MARC framework. Go to cataloguing
and create a new record using this framework. Verify that the defined
defaults are visible when set. Verify the default is empty (as before)
if no default was set. Verify that if the default is changed, the
record is saved with the manually changed value. Verify that upon
changing such a new record, the manually set indicator value is used
and not the default one from the framework.

Don't forget to run database and database schema update

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #22 from Josef Moravec  ---
Created attachment 71930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71930=edit
Bug 9701: (QA follow-up) Fix indentation and some strings

- Fixes tabs pointed out by the QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||14769


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

--- Comment #20 from Marcel de Rooy  ---
We need a default indicator in the framework too when we merge authorities
across the authtype border. See bug 14769.
Can you get this to work again, Joachim ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9701] Configure default indicators

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Configure default indicator |Configure default
   ||indicators

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/