[koha-commits] main Koha release repository branch master updated. v19.05.00-389-gb5e03a8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5e03a8e2bef33a405d3bcaf88c4abd3a019c3c9 (commit) via 68f128939b940f167fc14c3060a52da16b13a253 (commit) via be4c4f8040ba9485f1cc72937ae77027568c0779 (commit) via 95b6f56026c0381ffdd49a25bba9b5c170e141dc (commit) via f79da166ae7f910648266b98d89f19f4307d10ea (commit) from b5588958981a24c25536afff0b2091506bf7f92b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b5e03a8e2bef33a405d3bcaf88c4abd3a019c3c9 Author: Owen Leonard Date: Tue Jun 25 16:47:42 2019 + Bug 23206: Batch patron modification from reports which return cardnumber This patch adds an option to submit patron card numbers from report results to the batch patron modification tool. As with a report which returns biblionumbers or itemnumbers, a button appears at the top of report results which triggers a menu of batch operation options. To test, apply the patch and create a report which includes patron card number in the results. - Run the report and confirm that under the "Batch operations" button a batch patron modification menu item appears. - Confirm that selecting this option sends the correct patrons to the batch patron modification tool. - Test also with a report which returns both patron cardnumber and biblionumber or itemnumber. Signed-off-by: Maryse Simard Signed-off-by: George Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 68f128939b940f167fc14c3060a52da16b13a253 Author: Josef Moravec Date: Thu Jul 25 17:50:57 2019 + Bug 23363: (QA follow-up) Fix indentation Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit be4c4f8040ba9485f1cc72937ae77027568c0779 Author: Liz Rea Date: Tue Jul 23 10:22:20 2019 -0500 Bug 23363: Fix Internal Server Error when clicking on shipment cost invoice link To test: On the fund detail page, have some shipment costs associated with a fund an example would be cgi-bin/koha/acqui/spent.pl?fund=&fund_code= Click the link for the fund, without this patch it will give an internal server error. With this patch, the shipment invoice will be loaded. Signed-off-by: Jason DeShaw Signed-off-by: Laurel Moran Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 95b6f56026c0381ffdd49a25bba9b5c170e141dc Author: Kyle M Hall Date: Fri Jun 28 11:04:21 2019 -0400 Bug 23229: (QA follow-up) Fix indentation Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit f79da166ae7f910648266b98d89f19f4307d10ea Author: Andrew Isherwood Date: Fri Jun 28 10:24:32 2019 +0100 Bug 23229: Only load ILL table JS when needed This patch prevents the JS associated with the ILL table from loading unless we're actually displaying the table. This has the knock on effect of not causing the "get all ILL requests" API request to fire when loading any ILL page. Test plan: - Go to "ILL requests" page - TEST: Observe that the table loads all ILL requests - Go to the "New ILL request" page for any installed backend - TEST: Check the browser dev tools "Network" panel, observe that the /api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias,comments,requested_partners request is not made. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize --- Summary of changes: acqui/spent.pl |3 ++- .../intranet-tmpl/prog/en/modules/acqui/spent.tt |2 +- .../prog/en/modules/ill/ill-requests.tt |6 -- .../prog/en/modules/reports/guided_reports_start.tt | 18 +- 4 files changed, 24 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-49-g0995e70
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 0995e70bb6bcbd02821c9113353d7ce20e3d93ba (commit) from b239e36563a85572b26ed172002e9cb97533a32a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 0995e70bb6bcbd02821c9113353d7ce20e3d93ba Author: Owen Leonard Date: Fri Jun 21 14:07:49 2019 + Bug 23183: Reindent cataloging.js This patch makes some very minor corrections to indentation in cataloging.js, a JavaScript file used by the bibliographic and item records editors. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Nadine Pierre Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit f50afc1fc0b9044c21564b45f44687993ebc07e3) Signed-off-by: Fridolin Somers (cherry picked from commit 25caca7d5308b0650c6df7672b210552c342af24) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-50-g8b3e001
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 8b3e00174b2ef5643e559873fb4215b9e3fec29a (commit) from 0995e70bb6bcbd02821c9113353d7ce20e3d93ba (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 8b3e00174b2ef5643e559873fb4215b9e3fec29a Author: Nick Clemens Date: Tue Jun 4 14:25:53 2019 + Bug 23045: TextMarc errors on blank lines Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when processing blank lines. We should just pass on these rather then erroring To test: 1 - Define a new macro that delete more fields than it adds delete 245 2 - Run it 3 - Note an error in JS console, and helpers will not load 4 - Apply patch 5 - Reload, try again 6 - No error Signed-off-by: Claire Gravely Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize (cherry picked from commit 545f38d13c210e4cb173e67d2578d825a9ffeb47) Signed-off-by: Fridolin Somers (cherry picked from commit 2340df6f7c85c48a2ae68292204e9f16d485e7b9) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js |3 +-- .../intranet-tmpl/prog/en/includes/cateditor-widgets-marc21.inc |1 + 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-51-gb78fc79
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via b78fc7961d3228df8b93af21cc9fcc2ad386fbd4 (commit) from 8b3e00174b2ef5643e559873fb4215b9e3fec29a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b78fc7961d3228df8b93af21cc9fcc2ad386fbd4 Author: Nick Clemens Date: Fri Jun 7 10:14:36 2019 + Bug 23045: Return record along with errors We don't seem to directly handle the errors in most cases, let's always return the record To test: 1 - Add some blank lines to editor, previous patch is okay with this 2 - Add a line with just 'e' or some other incomplete field 3 - Try to save 4 - Note JS leader error 5 - Apply this patch 6 - No errors Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize (cherry picked from commit f927d801121f9d7b291516649cf3b55be49b8e3d) Signed-off-by: Fridolin Somers (cherry picked from commit 1e2dc2340105b35355d29ad5eda1d74a83375a4e) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/lib/koha/cateditor/text-marc.js |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v19.05.00-406-g0c4112a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0c4112a200bfdcdbdba4ce7870aeced1f960cfd9 (commit) via fea1d135be0f7e9ee55ae27f510861fe4c159307 (commit) via b52a17dade474530103f1b05a2efd39de9879c31 (commit) via f292b4ff29a0aa1a109c3f1af9c2f5412dd1a5e8 (commit) via 5d27fb71cbd91fdf196b6568a590f2eef54d7cd1 (commit) via 2293e6597c69d55ce5916b7a31029f13d65d4fea (commit) via 0b2a9b5872c72ee6b0f17d32e20c8e59231f03f3 (commit) via fbeb22802f41f8daf99498303146d1916c851507 (commit) via c1fe033a116c23192a8ed5ba31924f1f4e032812 (commit) via 41fa881ba07bb3ad1f8cccef253ed5c9d439f387 (commit) via 70d7226f9efbbb8633cb054fbc02e0a055aaf917 (commit) via 81137a17f22bb5352b9f73364ba17369fa7afd58 (commit) via e75758b18a6dd71cf5298533351f602db0d4ec48 (commit) via 21d6cd9ef02b21126d43eb7cc9c34e5efb47c730 (commit) via 859217c1f5c8513bc0bdb8d31b7421e86ad3b355 (commit) via a72d8dbb0ff3aa6f56aafcca2c3a0c820b5325f6 (commit) via b43602ee7d2cf5407b987224be8554251a9f80f6 (commit) from b5e03a8e2bef33a405d3bcaf88c4abd3a019c3c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 0c4112a200bfdcdbdba4ce7870aeced1f960cfd9 Author: Colin Campbell Date: Tue Jul 2 10:58:41 2019 +0100 Bug 23251: Correct formatting of IMD data ending in apostrophe IMD text data may end in an apostrophe (e.g. dreamin' ) This was causing the segment to be incorrectly formatted as only the last character was checked, not the preceding character to check whether it was quoted add a test for this specific occurence Signed-off-by: Hayley Mapley Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit fea1d135be0f7e9ee55ae27f510861fe4c159307 Author: Marcel de Rooy Date: Fri Jul 19 09:55:41 2019 + Bug 23345: Rename include-indexes to exclude-indexes in koha-dump Trivial edit. The usage statement is wrong. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit b52a17dade474530103f1b05a2efd39de9879c31 Author: Owen Leonard Date: Thu Jun 27 13:24:36 2019 + Bug 23226: Remove type attribute from script tags: Cataloging This patch removes the "type" attribute from
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-54-g7665edd
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 7665edd38f143bc0dfcd9b59d4281bf76096aa9b (commit) via bf8f38ebce943e15ed2a11c97d8405f1011bf6f0 (commit) via bd2e6c6734fcefc84a88c484b4cbae741c423ed2 (commit) from b78fc7961d3228df8b93af21cc9fcc2ad386fbd4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7665edd38f143bc0dfcd9b59d4281bf76096aa9b Author: Mark Tompsett Date: Wed Jul 3 02:35:16 2019 + Bug 23230: (follow-up) Fix broken tests Before patch, the new tests don't run. After patch, they do. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 288cc505557fdcb167737f1894cee581526b4741) Signed-off-by: Fridolin Somers (cherry picked from commit af7c25d2493bb3ef4f3f198c1181b98e8f1025f6) Signed-off-by: Lucas Gass commit bf8f38ebce943e15ed2a11c97d8405f1011bf6f0 Author: Tomas Cohen Arazi Date: Mon Jul 1 11:42:51 2019 -0300 Bug 23230: Make _version_compare OO context aware On using _version_compare in plugins development, it would be nice if it was able to be called as an object method. This way we don't need to fully qualify it like this: Koha::Plugins::Base::_version_compare and we can do $self->_version_compare instead. This patch implements this behavior change. It is backwards compatible so plugins using the 'old way' don't break. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 90acef7a9b860e70631ff243c21b435a7d081a16) Signed-off-by: Fridolin Somers (cherry picked from commit 6c208a09619d2326bfa608cd3afee343cd4f4c33) Signed-off-by: Lucas Gass commit bd2e6c6734fcefc84a88c484b4cbae741c423ed2 Author: Tomas Cohen Arazi Date: Mon Jul 1 11:33:41 2019 -0300 Bug 23230: Unit tests Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 2ff5f9fb633e6f3786b093d2a2f202a66db7b3d0) Signed-off-by: Fridolin Somers (cherry picked from commit 5232a6263932556eaa3220f4b771c16c7a735b3c) Signed-off-by: Lucas Gass --- Summary of changes: Koha/Plugins/Base.pm | 10 -- t/db_dependent/Plugins.t | 27 +++ 2 files changed, 27 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-55-ge81a0b3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via e81a0b32d989577bf0d19eb681f910ed6be91ded (commit) from 7665edd38f143bc0dfcd9b59d4281bf76096aa9b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e81a0b32d989577bf0d19eb681f910ed6be91ded Author: Nick Clemens Date: Tue Jul 2 16:10:10 2019 + Bug 23255: Correct HomeOrHoldingBranch descriptions To test: 1 - Apply patch 2 - View 'HomeOrHoldingBranch' system preference 3 - Confirm the options make sense Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit cbf605539ad90e18a0325b1d06e43b8b71b655e9) Signed-off-by: Fridolin Somers (cherry picked from commit 646072e1cf3759aa9ffc676cdb153aaf0758292d) Signed-off-by: Lucas Gass --- Summary of changes: .../prog/en/modules/admin/preferences/circulation.pref |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-57-g23e62d6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 23e62d6aa8a054ce0447a057994c2583592f0da7 (commit) via 2d7529e953e6bdcc05bead14af684b48512d8bac (commit) from e81a0b32d989577bf0d19eb681f910ed6be91ded (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 23e62d6aa8a054ce0447a057994c2583592f0da7 Author: Jonathan Druart Date: Wed Jun 19 20:08:04 2019 -0500 Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED Test plan: 0: Do not apply the patches 1: Create an item with itype, ccode, location, and holding branch set 2: Create a course 3: Add item to course, changing the values for itype, ccode, and location 4: Click Edit for that item on course-details.pl 5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED 6: Hit Save 7: Back on course-details.pl, observe that the item is still showing the values set in step 3 8: Apply this patch 9: Repeat 4 to 6 10: Back on course-details.pl, observe that the item is now showing the correct values 11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently 12: hit save 13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9 Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit e4ee3636304d06a0492fee6a1fcd9e4c65a17be6) Signed-off-by: Fridolin Somers (cherry picked from commit 75e886e31e61646e7e1ee34a93d065528f560382) Signed-off-by: Lucas Gass commit 2d7529e953e6bdcc05bead14af684b48512d8bac Author: Jonathan Druart Date: Wed Jun 19 20:12:14 2019 -0500 Bug 23083: Add tests Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 44469cf4c3e9fa690b2247324b1922fdde207f9f) Signed-off-by: Fridolin Somers (cherry picked from commit dd850bdd07f7adc52abdf330c334c4c31b3a1176) Signed-off-by: Lucas Gass --- Summary of changes: C4/CourseReserves.pm| 11 ++- t/db_dependent/CourseReserves/CourseItems.t | 14 -- 2 files changed, 18 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-58-g60b4ab8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 60b4ab8a922d2ac946c81787dc5399668587a0e4 (commit) from 23e62d6aa8a054ce0447a057994c2583592f0da7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 60b4ab8a922d2ac946c81787dc5399668587a0e4 Author: Fridolin Somers Date: Wed May 29 15:20:41 2019 +0200 Bug 21534: Always compute wildcards You get no results when searching with an hyphen + with * in query string (or with preference QueryAutoTruncate) : ie /cgi-bin/koha/opac-search.pl?q=saints-anges* Looks like query-string by default does not compute wildcards, see analyze_wildcard in : https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html Test plan : 1) Use Elasticsearch 2) Create a record with "saints-anges" 3) Search for "saints-anges" => you get results 4) Search for "saints-anges*" => you get results 5) Search for "saints-ang*" => you get results Signed-off-by: Michal Denar Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 001d433b427731a6efd55208ac3169107c830730) Signed-off-by: Fridolin Somers (cherry picked from commit a8cc9d5f49f36a5bf69265f3062f1a7a8ee0fdf4) --- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm |1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
