[koha-commits] main Koha release repository branch master updated. v18.05.00-646-gf04cd87

2018-08-31 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  f04cd87e671bdcacacb5c98c3f18e0c5da3aa82a (commit)
   via  1ab7d74a15c038446e294452c7889090404f02c6 (commit)
  from  d19d8ec049271afb5840af15bc9fee9da7ab4e19 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f04cd87e671bdcacacb5c98c3f18e0c5da3aa82a
Author: Nick Clemens 
Date:   Thu Aug 30 19:43:48 2018 +

Bug 21295: Update selenium tests for admin bootstrap changes

To test:
1 - Setup and run selenium server as outlined here:
https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha
2 - sudo koha-shell kohadev
3 - prove -v t/db_dependent/selenium/administration_tasks.t
4 - All should be green

Signed-off-by: Tomas Cohen Arazi 
All good!

Signed-off-by: Nick Clemens 

commit 1ab7d74a15c038446e294452c7889090404f02c6
Author: Tomas Cohen Arazi 
Date:   Fri Aug 31 11:27:13 2018 -0300

Bug 20944: Fix perlcritic issues

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 Koha/REST/V1/Patrons/Account.pm|3 ++-
 t/db_dependent/selenium/administration_tasks.t |   18 +-
 2 files changed, 11 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-1-g36abd06

2018-09-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  36abd064648cd88fa853e0f69726c1a68dc14fe5 (commit)
  from  20c85f636572aab559ff10839cef9ec09b0e914a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 36abd064648cd88fa853e0f69726c1a68dc14fe5
Author: Martin Renvoize 
Date:   Wed Sep 5 09:05:03 2018 +0100

Bug 21068: Remove NorwegianPatronDB related code

Bug 11401 introduced code to support Norwegian national library card.
This code is too specific to be part of Koha as it, it should be a
plugin instead.
Moreover nobody uses it, but a modified version (see comment 3).

RMaint: Rather than backporting the removal as is, I have created a
deprecation warning to highlight the codes upcoming removal.

Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Members.pm |3 +++
 1 file changed, 3 insertions(+)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-5-gf9f8c6b

2018-09-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  f9f8c6bbd0afeafa09554cf98f551228a6607952 (commit)
   via  a87364d0ffbf906a4888f5d6d66e1a74cf280f58 (commit)
   via  3af501884e136454bca1c5a78c1a6b56e876f6be (commit)
   via  1bb7e7c0167be0feffc86b574620c5fc65120993 (commit)
  from  36abd064648cd88fa853e0f69726c1a68dc14fe5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f9f8c6bbd0afeafa09554cf98f551228a6607952
Author: Jonathan Druart 
Date:   Wed Jul 25 12:25:58 2018 -0300

Bug 21096: Do not display loggedinusername in template

This patch is a little fix for a much bigger hidden issues.

The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")

What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''

The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?

Test plan:
Make sure the original issue is fixed

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit be691d86e35acebace0f1576ea9380f405dd55ce)
Signed-off-by: Martin Renvoize 

commit a87364d0ffbf906a4888f5d6d66e1a74cf280f58
Author: Jonathan Druart 
Date:   Fri Aug 10 17:02:38 2018 -0300

Bug 21168: Handle deleted checked-in items on checking in

circ/returns.pl generates a server error when attempting to checkin an item 
while
the list of previously-returned items contains an item that has been 
deleted.
Error text: Can't call method "biblio" on an undefined value at 
/usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606.

Test plan:
- checkout two items
- checkin item1
- on a separate tab, delete item1
- on the original tab (which still shows item1 in the list of Checked-In 
Items), attempt to check in item2
=> No error appears

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 823c76cdc58b7b80b365a4f313fed3462f0df720)
Signed-off-by: Martin Renvoize 

commit 3af501884e136454bca1c5a78c1a6b56e876f6be
Author: Kyle M Hall 
Date:   Thu Aug 16 07:11:17 2018 -0400

Bug 21231: BlockReturnofLostItems does not prevent lost items being found

When the syspref BlockReturnOfLostItems is set to Block, the item is 
blocked from being returned, but is still considered found -- it's set to 
lost=0 and a refund is applied to the patron (if circ rules allow). The item 
can then be checked in a second time and returned as it is no longer lost.

Test Plan:
1) Set an item to lost
2) Set BlockReturnOfLostItems to Block
3) Check the lost item in
4) Checkin  message should say item is lost and cannot be returned
5) Check lost status of item, it should remain unchanged

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit ca2430480eaa4338b3e4aed766589b1406565d69)
Signed-off-by: Martin Renvoize 

commit 1bb7e7c0167be0feffc86b574620c5fc65120993
Author: Kyle M Hall 
Date:   Thu Aug 16 07:10:43 2018 -0400

Bug 21231: Add Unit Test

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 44d7063209137696d0c844ff82880a973029e534)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Auth.pm   |2 +-
 C4/Circulation.pm|4 +++-
 C4/Items.pm  |   14 ++
 circ/returns.pl  |2 ++
 koha-tmpl/intranet-tmpl/prog/en/includes/header.inc  |4 ++--

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-11-g3516f11

2018-09-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46 (commit)
   via  e9f859c0e433d3cf3c0123432787a5801fa5a7d7 (commit)
   via  acba1272764455af6164daa8e9246561b7b41bd3 (commit)
   via  514939a8046cb82a66cfb3966a14020e846face3 (commit)
   via  727e2df2b889cdfedaabad77172c640f79c3687b (commit)
   via  6ec1ca154cbcad9b2db7cacabe806936fce02465 (commit)
  from  f9f8c6bbd0afeafa09554cf98f551228a6607952 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46
Author: Martin Renvoize 
Date:   Wed Sep 5 13:52:41 2018 +0100

Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls

http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html

Prior to this patch, GetRecords returned timestampX, cardX and borrowerX
for
the last 3 patrons who checked out the items.

I have no idea if it is a desired effects but, as this code has been
there for a very long time (2005), I suspect it's not.
The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say
anything about the checkouts info.

Test plan:
hit /ilsdi.pl?service=GetRecords&id=1
and confirm the info about items are displayed correctly
Signed-off-by: Josef Moravec's avatarJosef Moravec

Signed-off-by: 's avatarMarcel de Rooy 
Signed-off-by: Wm. Nick Clemens's avatarNick Clemens


RMaint: Converted to deprecation warning
Signed-off-by: Martin Renvoize 

commit e9f859c0e433d3cf3c0123432787a5801fa5a7d7
Author: Jonathan Druart 
Date:   Mon Aug 6 19:42:20 2018 -0300

Bug 21207: Remove unused RM C4::Overdues::GetItems sub

Test plan:
  git grep GetItems
  | grep -v GetItemsInCollection
  | grep -v GetItemsForInventory
  | grep -v GetItemsInfo
  | grep -v GetItemsLocationInfo
  | grep -v GetItemsAvailable
  | grep -v GetItemsByBiblioitemnumber

should not return any occurrences of code in perl scripts

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 3795141f54991e0a4c95629754ac2759330ed2e6)
Signed-off-by: Martin Renvoize 

commit acba1272764455af6164daa8e9246561b7b41bd3
Author: Katrin Fischer 
Date:   Wed Aug 8 20:28:29 2018 +

Bug 20994: Fix capitaization "Save to Lists"

On the OPAC result list, below each result, there is a link:
"Save to Lists".

Patch changes this to "Save to lists" following our
capitalization rules.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit d5296743a4b4e6e6004bdb68926a3584e55435e4)
Signed-off-by: Martin Renvoize 

commit 514939a8046cb82a66cfb3966a14020e846face3
Author: Jonathan Druart 
Date:   Wed Aug 15 14:21:47 2018 -0300

Bug 21139: (follow-up) Floating toolbars - Remove unecessary height

Found where QAing bug 20935, we actually want the hidden toolbar to be
the exact same height as the visible one.

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b)
Signed-off-by: Martin Renvoize 

commit 727e2df2b889cdfedaabad77172c640f79c3687b
Author: Jonathan Druart 
Date:   Wed Aug 15 15:17:57 2018 -0300

Bug 19991: Remove warning from opac-user

Use of uninitialized value in split at
/home/vagrant/kohaclone/opac/opac-user.pl line 78.

Use of uninitialized value $search_query in string ne at
/home/vagrant/kohaclone/opac/opac-user.pl line 367.

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 38428fd71e76fdd7c9a452bc831affa03918994c)
Signed-off-by: Martin Renvoize 

commit 6ec1ca154cbcad9b2db7cacabe806936fce02465
Author: Charlotte Cordwell 
Date:   Wed Jan 17 20:46:59 2018 +

Bug 19991: use Modern::Perl in OPAC perl scripts

Test Case:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

errors/400.pl
errors/401.pl
errors/402.pl
errors/403.pl
errors/404.pl
errors/500.pl
opac-account-pay-paypal-return.pl
opac-alert-subscribe.pl
opac-authorities-home.pl
opac-authoritiesdetail.pl
opac-browser.pl
opac-ics.pl
opac-image.pl
opac-imageviewer.pl
opac-messaging.pl
opac-modrequest-suspend.pl
opac-modrequest.pl
opac-mymessages.

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-12-gee1eec9

2018-09-06 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ee1eec9d255e3a9341c9e17558d6d1f835add5ce (commit)
  from  3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ee1eec9d255e3a9341c9e17558d6d1f835add5ce
Author: Tomas Cohen Arazi 
Date:   Fri Aug 24 10:45:52 2018 -0300

Bug 21267: Set X-FORWARDED-PROTO https if required

This patch makes the apache configuration for the reverse proxy
(required for Plack) so it sets the X-FORWARDED-PROTO header correctly
for Plack::Middleware::ReverseProxy to use it.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Ulrich Kleiber 

Signed-off-by: Marcel de Rooy 
Since we actually resolve 19799 now (Changing language on OPAC redirects
back to homepage), I will move that code to a new enh report.

Signed-off-by: Nick Clemens 
(cherry picked from commit 302dd7bf8233ebf640bfde82fc050f8b08b2757c)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 debian/templates/apache-shared-intranet-plack.conf |2 +-
 debian/templates/apache-shared-opac-plack.conf |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-680-g5616e22

2018-09-06 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  5616e22236e8c263da0629a25b3aa7146e19c866 (commit)
   via  87c2755c04c962dab69ac846ecdff0893d35b9df (commit)
   via  6739346e1b8f542f38852f49277ccfb150a5095c (commit)
   via  bfbc6cc941632269582891d63c58cea8b4fe668f (commit)
   via  ac07a5074f3a77f1af691af40ce67facdcd43685 (commit)
   via  5496dc7eeaf6ddbe5503dade970e95ed0f283b55 (commit)
   via  3bede9a9d79f2999a7176afad38f75ae283b4a5c (commit)
   via  d9a8ac0489d22fe174ea28af7f90f00a7ca15676 (commit)
   via  206ba82a46eff0d3b29ae6ed65bd3f3b0ef8bbde (commit)
   via  2e641b698e2c329f36e06cc8969e749bd13dff1a (commit)
   via  f190ef3f2e7b7a03c3ca10086ed3a923b7c11bdb (commit)
   via  de629e2a28f14cb3d64fd8a767b1bfe30d3d82de (commit)
   via  b40070f4ad58f921f6994b304618bb560d471586 (commit)
   via  3afbe3cf5d544572aa2febc1d745fb77c7f305e3 (commit)
   via  c556ad49b8a3e0d6112ebcc899a09723709e11de (commit)
   via  69316c7b8b937972477ec0a19475f41baf08f6b6 (commit)
   via  ce411c186dd2a4e35a3b1855b86283522cc7bfd3 (commit)
   via  24fc43b9780260069c7aa1a328209f373d57e1bf (commit)
   via  8d404ec2ccbff96f638baf2746010648de3ed007 (commit)
   via  d9ceb30a4d72cbaf387bba2fc550b7bad1609e8f (commit)
   via  d2db67fbcbb77629e79d0eafd5c6ad241b5aa8e0 (commit)
   via  9a53a7384a60dbd52de7894ac685648a8108c830 (commit)
   via  bf8834a1e65235c6e174866a25d76bdcd88be988 (commit)
   via  4577ca53c87d047d25182f88ebefed9583f515df (commit)
   via  e0f58070f2634c3a5bf4ffb08c7d29e9183f2919 (commit)
   via  60a2589d3cb44bca3ec65cfe4d551a2d4563e020 (commit)
   via  2c59ef4def47b120ddadfeae37f6a50bfa3a (commit)
   via  9900181cd3943e962901df662f71b1dbba33e22b (commit)
   via  662e64f76652cc4b3708fba8a16fa86a28d248ba (commit)
   via  00606e13002f6253c9bb5329a0876d53ac4638b6 (commit)
   via  135bf128a3f93da8161362ff174cbde32eed214d (commit)
   via  b8c1198a79fbfbbda367accd23ddec27e0e6399d (commit)
   via  a344710aed6b9d6b42301b0382e653380935a73f (commit)
   via  1ce0930ed11792c5af55b43b3ff5fe6aef4cf42f (commit)
  from  f04cd87e671bdcacacb5c98c3f18e0c5da3aa82a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 5616e22236e8c263da0629a25b3aa7146e19c866
Author: Katrin Fischer 
Date:   Mon Aug 13 02:04:29 2018 +

Bug 19817: (QA follow-up) Add German manual and fix system preference help 
files

- German language manuals were added since this patch was started
- The structure of the manual was changed slightly, system
  preferences were moved into their own chapter

To test:
- Test help files display correctly for system preferences display correctly
  Note: Local use uses a different page than the other tabs
- Test German shows up as option in KohaManualLanguage and links
  correctly

Signed-off-by: Nick Clemens 

commit 87c2755c04c962dab69ac846ecdff0893d35b9df
Author: Jonathan Druart 
Date:   Thu Aug 16 11:59:36 2018 -0300

Bug 19817: Remove numbering from chapter file names

See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8
Remove numbering from chapter file names
from koha-manual

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 6739346e1b8f542f38852f49277ccfb150a5095c
Author: Jonathan Druart 
Date:   Tue Apr 10 11:07:03 2018 -0300

Bug 19817: use https instead of http

the https version was not working when I wrote the first patches

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit bfbc6cc941632269582891d63c58cea8b4fe668f
Author: Jonathan Druart 
Date:   Mon Apr 9 11:30:01 2018 -0300

Bug 19817: Use the language from the interface if valid

Use the UI language for the manual, if exists. Use the pref as a
fallback.

With the call to get_template_and_user the value of preferred_language
switched from 'es' (spanish) to 'en' from one click to another (??)

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit ac07a5074f3a77f1af691af40ce67facdcd43685
Author: Jonathan Druart 
Date:   Wed Apr 4 13:35:35 2018 -0300

Bug 19817: Open the manual in a new window, not a popup

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 5496dc7eeaf6ddbe5503dade970e95ed0f283b55
Author: Jonathan Druart 
Date:   Wed Apr 4 13:30:04 2018 -0300

Bug 19817: Add pref KohaManualLa

[koha-commits] main Koha release repository branch master updated. v18.05.00-700-ga9e8599

2018-09-07 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a (commit)
   via  ec463e80aadbf30144d417e123e884726fff77f2 (commit)
   via  d96e2e71b8ac77e09194d02e72d67ec5c03187ec (commit)
   via  c66a2894e1857b403a52d8392d46c343be7d0ed8 (commit)
   via  96a095f4e1d14721ace2198fb369670ce848c9ef (commit)
   via  6a2a80988dd121215284c4458438fdb0fe41b86c (commit)
   via  289e96848a2320e5c8c93f46327143a4b73c267f (commit)
   via  418c65d2e28eb6a2c9e3bb56505918434cf5f04c (commit)
   via  80e8c857e31cf14bb760731715a2f854d7c72441 (commit)
   via  dfadaa45aa8ce226d9ba111ebad6e44271e39e41 (commit)
   via  d6424c1999d3563c5243185503dd5a9b5b928f8f (commit)
   via  e85d6e12ea4dccd8fa08ec600864c2f985dcf886 (commit)
   via  8d53a1508d3fb8c6336839995f61036809ffedd2 (commit)
   via  70c6266081a566149c7b3b49c95958a31417d435 (commit)
   via  b6813142ddedebf96bb6dfa50d5544d42c30e5e1 (commit)
   via  2b0e73b9e1b7f19a55510521a990fa00411157c5 (commit)
   via  c1d2363063d1c3eb2d37e45c9a3074cea9c783b4 (commit)
   via  86bcc81122f20a096f46ac66de3d95ec21dcbd96 (commit)
   via  9dbcbe587db1f50594f17f91ab6643acb7bcc3df (commit)
   via  4cd57521c43f4e8c5e37ec61e1112ff2b74453ad (commit)
  from  5616e22236e8c263da0629a25b3aa7146e19c866 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a
Author: Julian Maurice 
Date:   Fri Sep 7 17:06:38 2018 +0200

Bug 19550: (QA follow-up) Add missing [% USE %]

Signed-off-by: Nick Clemens 

commit ec463e80aadbf30144d417e123e884726fff77f2
Author: Nick Clemens 
Date:   Thu Sep 6 14:34:03 2018 +

Bug 19550: (RM follow-up) Add filters

Signed-off-by: Nick Clemens 

commit d96e2e71b8ac77e09194d02e72d67ec5c03187ec
Author: Julian Maurice 
Date:   Tue Oct 31 12:25:17 2017 +

Bug 19550: Add links to related authorities for UNIMARC

Links exist in search results for MARC21 but not for UNIMARC.
This patch fixes that.

Test plan:
1. Create an authority with a field 550 that links to another authority
   e.g. 550 $a Foo $9 42
2. Reindex this authority
3. Search for this authority
4. See that you now have a link "Foo" to authorities/detail.pl?authid=42
   in the summary

Signed-off-by: delaye 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit c66a2894e1857b403a52d8392d46c343be7d0ed8
Author: Nick Clemens 
Date:   Fri Sep 7 15:53:24 2018 +

Bug 21235: DBRev 18.06.00.027

Signed-off-by: Nick Clemens 

commit 96a095f4e1d14721ace2198fb369670ce848c9ef
Author: Martin Renvoize 
Date:   Fri Sep 7 16:28:22 2018 +0100

Bug 21235: (QA follow-up) Remove table services_throttle

Add the missing db update to nuke the services throttle from high orbit

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 6a2a80988dd121215284c4458438fdb0fe41b86c
Author: Jonathan Druart 
Date:   Wed Aug 15 12:01:56 2018 -0300

Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall 

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 289e96848a2320e5c8c93f46327143a4b73c267f
Author: Owen Leonard 
Date:   Thu Sep 6 11:56:41 2018 +

Bug 21319: Remove highlight and tooltip on Koha Team version

This patch modifies the about page to remove a  on the Koha
version number which explained the version numbering change.

To test, apply the patch and view the "Koha team" tab on the about page.
The "Koha 18.05 release team" header should not have the number
highlighted.

Signed-off-by: pierre-marc 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 418c65d2e28eb6a2c9e3bb56505918434cf5f04c
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:33:32 2018 -0300

Bug 20776: Add Selenium::Remote::Driver to the dependency list

This dependency is missing from the PerlDependencies.pm file.
This patch adds it.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit 80e8c857e31cf14bb760731715a2f854d7c72441
Author: Nick Clemens 
Date:   Fri Sep 7 13:32:31 2018 +

Bug 17530: DBRev 18.06.00.025

Signed-off-by: Nick Clemens 

commit dfadaa45aa

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-16-g3017d59

2018-09-11 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  3017d592a10da23fc12e6a94ba70d7ff9e7d7d94 (commit)
   via  f7e65044f98c56c6e4f4ad0159a0032b02e9b500 (commit)
   via  028c23fecf77a6b71dd040e85d1d58d9acf4fe05 (commit)
   via  1c58af16bedfe8502c0afb83912b2e4661871b93 (commit)
  from  ee1eec9d255e3a9341c9e17558d6d1f835add5ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3017d592a10da23fc12e6a94ba70d7ff9e7d7d94
Author: Nick Clemens 
Date:   Fri Sep 7 15:53:24 2018 +

Bug 21235: DBRev 18.05.04.001

Signed-off-by: Nick Clemens 
(cherry picked from commit c66a2894e1857b403a52d8392d46c343be7d0ed8)
Signed-off-by: Martin Renvoize 

commit f7e65044f98c56c6e4f4ad0159a0032b02e9b500
Author: Martin Renvoize 
Date:   Fri Sep 7 16:28:22 2018 +0100

Bug 21235: (QA follow-up) Remove table services_throttle

Add the missing db update to nuke the services throttle from high orbit

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 96a095f4e1d14721ace2198fb369670ce848c9ef)
Signed-off-by: Martin Renvoize 

commit 028c23fecf77a6b71dd040e85d1d58d9acf4fe05
Author: Jonathan Druart 
Date:   Wed Aug 15 12:01:56 2018 -0300

Bug 21235: Remove table services_throttle

This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)

Signed-off-by: Kyle M Hall 

https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6a2a80988dd121215284c4458438fdb0fe41b86c)
Signed-off-by: Martin Renvoize 

commit 1c58af16bedfe8502c0afb83912b2e4661871b93
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:33:32 2018 -0300

Bug 20776: Add Selenium::Remote::Driver to the dependency list

This dependency is missing from the PerlDependencies.pm file.
This patch adds it.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 418c65d2e28eb6a2c9e3bb56505918434cf5f04c)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Installer/PerlDependencies.pm   |5 +++
 C4/XISBN.pm|   28 --
 Koha.pm|2 +-
 Koha/Schema/Result/ServicesThrottle.pm |   66 
 debian/koha-common.cron.daily  |1 -
 installer/data/mysql/kohastructure.sql |   11 --
 installer/data/mysql/updatedatabase.pl |7 
 misc/cronjobs/crontab.example  |3 --
 misc/cronjobs/services_throttle.pl |   21 --
 9 files changed, 13 insertions(+), 131 deletions(-)
 delete mode 100644 Koha/Schema/Result/ServicesThrottle.pm
 delete mode 100755 misc/cronjobs/services_throttle.pl


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-7-g2d3aca1

2018-09-11 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  2d3aca1b6dec7948d463a827b3a786ea736ac89f (commit)
   via  492af5173bb1aca4652f882c1c725b9c7d789a43 (commit)
   via  82c5cef3cef3b2d794e0e88b7c11ba23c908a848 (commit)
  from  cdcfce4c6c1c6ad9018e620f6e8f6450c93d1900 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2d3aca1b6dec7948d463a827b3a786ea736ac89f
Author: Mirko Tietgen 
Date:   Tue May 22 12:32:19 2018 +0200

Bug 20800: Keep Koha on Stretch from using broken libhttp-oai-perl

libhttp-oai-perl in Stretch is 4.03 and broken. Koha depends on
libhttp-oai-perl << 4 for that reason. To make the installation of Koha
on Stretch as easy as possible, this patch adds the alternative
libhttp-oai-3.27-perl which we provide in the Koha repository.

Signed-off-by: Mark Tompsett 

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 
(cherry picked from commit 56813f5c90827df0fd89262917e7f9920f7d9175)
Signed-off-by: Fridolin Somers 

commit 492af5173bb1aca4652f882c1c725b9c7d789a43
Author: Mirko Tietgen 
Date:   Tue May 15 19:23:25 2018 +0200

Bug 20437: Update debian/control

Signed-off-by: Mirko Tietgen 

Signed-off-by: Jonathan Druart 
(cherry picked from commit 9b31bc2d27c6e045a6e7ea079778c47674c135db)
Signed-off-by: Fridolin Somers 

commit 82c5cef3cef3b2d794e0e88b7c11ba23c908a848
Author: Tomas Cohen Arazi 
Date:   Fri Mar 16 15:22:47 2018 -0300

Bug 20437: Force the dependency on HTTP::OAI < 4.0

Until HTTP::OAI is patched so it actually works, and bug 17704 fixes the 
API change Koha-side, we need to explicitly pull the right version. Otherwise 
people using Debian 9+ derived distros (Ubuntu 16.04+) are seeing production 
issues.

This implies packaging our custom libhttp-oai-perl distribution in the 
meantime.

This patch makes Koha require a version lower than 4.0.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Marcel de Rooy 
Signed-off-by: Mirko Tietgen 

Signed-off-by: Jonathan Druart 
(cherry picked from commit 05ebfaf0c04cce35933f81e48de95b307da1c325)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 debian/control   |4 ++--
 debian/list-deps |1 +
 2 files changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-724-g293e84d

2018-09-14 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  293e84d38dd25ae5bd08c2cdd5ce064f4201a79c (commit)
   via  c427952783776bd9e6f79ee3860f968bea5b82a9 (commit)
   via  cf3dbedae75b19ffd649725dddce212b63738582 (commit)
   via  4e8d22a51bf707d3e160a87a125bd8d8f9eb04e6 (commit)
   via  5d2ef635627fd35f721c086e7b6491a7e82b958a (commit)
   via  0c4460c2fbb6fb678381921911d9030419cc9700 (commit)
   via  5acdbb1d2dcb0bd2719f88aa6905c2cf91fab1db (commit)
   via  59b78fd095ecf7db88f339cc2f03d923b095130d (commit)
   via  b8104d8882790b45c1d3b65386bd37ed1cc671d7 (commit)
   via  5ef7f04f58dd470b85988b866a2e608256904da8 (commit)
   via  765c28c8e3a7e11afac1a061ebd296f18f3ef8a5 (commit)
   via  fac3944aa1c6c0c43e5ceac77fe1d163b22bf3e2 (commit)
   via  51a769bb59efe1b4511805734d2ef73b8fbbac81 (commit)
   via  42c94d185ab44c075073dd08762c4bb71df77b16 (commit)
   via  18d85cc8d72b55880e88c5364a3819965c8a2831 (commit)
   via  83e515820abb6e2fa8ddf30f61b3f4972a48ed10 (commit)
   via  030047da428521c248868e3ee5d655afd3bed05b (commit)
   via  bf7082f854a1db9eb5b7eb77e5f450d018d8e07b (commit)
   via  331af8521b5fba4b5553c182888a4017b2ce9c3a (commit)
   via  68138b225807a857ddbddef7680c43f2b10de87e (commit)
   via  235654a3cfa5b6e323489408ddc7875281bb1f50 (commit)
   via  3fedae85f25ef5f587d567b51b86aab776d87311 (commit)
   via  46c992948ea28ae2bebc7f9042df6434319b80bf (commit)
   via  be0a897648e4ae1ebb429d0829c22a8534a81606 (commit)
  from  a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 293e84d38dd25ae5bd08c2cdd5ce064f4201a79c
Author: Jonathan Druart 
Date:   Fri Aug 31 13:51:18 2018 -0300

Bug 21293: Remove another misplaced html filter on housebound.tt

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit c427952783776bd9e6f79ee3860f968bea5b82a9
Author: Owen Leonard 
Date:   Thu Aug 30 16:43:09 2018 +

Bug 21293: Display of housebound delivery information broken by Bug 13618

This patch corrects the patron housebound details template. A stray
"html" filter broke display of delivery information.

To test, apply the patch and enable the HouseboundModule system
preference.

 - Open a patron record and select the "Housebound" tab in the left-hand
   navigation menu.
 - Click "Add a new deliver" and save some delivery details.
 - Upon saving you should be directed back to the housebound details
   page. All the details of the delivery you saved should appear
   correctly.

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit cf3dbedae75b19ffd649725dddce212b63738582
Author: Tomas Cohen Arazi 
Date:   Fri Sep 14 12:27:36 2018 -0700

Bug 21233: (QA follow-up) It is not only trailing whitespace characters

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

commit 4e8d22a51bf707d3e160a87a125bd8d8f9eb04e6
Author: Marcel de Rooy 
Date:   Fri Aug 24 11:06:14 2018 +0200

Bug 21233: (QA follow-up) We do not like the plural form of whitespace

The word "whitespace" is usually uncountable.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit 5d2ef635627fd35f721c086e7b6491a7e82b958a
Author: Tomas Cohen Arazi 
Date:   Thu Aug 16 06:54:53 2018 -0300

Bug 21233: Unit tests

This patch adds tests for the required password-related exceptions. The
tests verify the stringified version of the exceptions.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> FAIL: Exceptions not implemented, tests fail!

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit 0c4460c2fbb6fb678381921911d9030419cc9700
Author: Tomas Cohen Arazi 
Date:   Thu Aug 16 06:56:30 2018 -0300

Bug 21233: Add Koha::Exceptions::Password

This patch adds some exceptions that we need. To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off! :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit 5acdbb1d2dcb0bd2719f88aa6905c2cf91fab1db
Author: Nick Clemens 
Date:   Fri Sep 14 17:46:58 2018 +

Bug

[koha-commits] main Koha release repository branch master updated. v18.05.00-729-gb29c4e2

2018-09-14 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  b29c4e2bf9562c47b525b2b0644fb48db7853df2 (commit)
   via  b612ec7a0de5c77ca29a07728664fbd1d8cb7812 (commit)
   via  1442499a0b6d6c22c87b7ef9eea4c7cc540e3fce (commit)
   via  b0ef7174fe601bbf39408e455365ea563949b4bb (commit)
   via  2d6cf8bd7a0e290c8bb947ed1880f1e906d0e74c (commit)
  from  293e84d38dd25ae5bd08c2cdd5ce064f4201a79c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b29c4e2bf9562c47b525b2b0644fb48db7853df2
Author: Tomas Cohen Arazi 
Date:   Fri Sep 14 16:23:58 2018 -0700

Bug 21233: (follow-up) POD fix

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

commit b612ec7a0de5c77ca29a07728664fbd1d8cb7812
Author: Tomas Cohen Arazi 
Date:   Tue Sep 11 10:48:15 2018 -0700

Bug 21334: Add bibliographic content type definitions

This patch adds the following content type definitions, to be used by
endpoint authors implementing MARC-related endpoints:

--
| Content-type | Alias   |
|--|-|
| application/marcxml+xml  | marcxml |
| application/marc-in-json | mij |
| application/marc | marc|
--

Code using this aliases will use them like this:
- Suppose you want to output data in MARCXML format:

my $record = cool_method_that_returns_MARC_RECORD();
return $c->render( status => 200, format => 'marcxml', text => 
$record->as_xml_record );

Note: 'text' by defaults encodes output as UTF-8. If the encoding is not
UTF-8 you should encode the data on your own.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/V1.t
=> SUCCESS: Test pass!
- Sign off :-D

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 1442499a0b6d6c22c87b7ef9eea4c7cc540e3fce
Author: Tomas Cohen Arazi 
Date:   Tue Sep 11 10:43:32 2018 -0700

Bug 21334: Unit tests

This patch adds unit tests for the new content types being added.
It also adds tests for the 'json' overloading that already takes place
in V1.pm.

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit b0ef7174fe601bbf39408e455365ea563949b4bb
Author: Marcel de Rooy 
Date:   Fri Sep 14 11:53:37 2018 +0200

Bug 19179: (QA follow-up) Replace second E-mail

Better write here exactly what we need to type in the pref text box.
Since E-mail will not work and Email will :)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit 2d6cf8bd7a0e290c8bb947ed1880f1e906d0e74c
Author: Charlotte Cordwell 
Date:   Fri Sep 7 03:35:36 2018 +

Bug 19179: Email option for SMSSendDriver is not documented

'Email' is not documented as a valid setting.

1) Apply patch.
2) Go to Administration --> search SMSSendDriver
3) Check if SMSSendDriver has this message is at the end of the box:
   "If you would prefer to receive SMS via E-mail set SMSSendDriver to 
Email"

Signed-off-by:  Michal Denar 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 Koha/Exceptions/Password.pm|4 +-
 Koha/REST/V1.pm|7 ++-
 .../prog/en/modules/admin/preferences/patrons.pref |2 +
 .../{Template/Plugin/To.t => Koha/REST/V1.t}   |   47 +---
 4 files changed, 32 insertions(+), 28 deletions(-)
 copy t/db_dependent/{Template/Plugin/To.t => Koha/REST/V1.t} (50%)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-737-g2847ac4

2018-09-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  2847ac4b4de239a430e6e9d20f6e895435c56d7b (commit)
   via  2d94834807851c3325f26572c7a228903034741c (commit)
   via  b64f1808f1682c5e132e0ddbc19ae5869a55bd99 (commit)
   via  f9359675e2f6a8b89ce471ac5f090eef33be3305 (commit)
   via  11e513f83f0c5fdd0d47de14b7c09635faf58ae4 (commit)
   via  cb406f72b0266c97ac904754cc9637035000f5ca (commit)
   via  a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2 (commit)
   via  ca887754ead4d6207811d751229c4a4dbcf4af80 (commit)
  from  b29c4e2bf9562c47b525b2b0644fb48db7853df2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2847ac4b4de239a430e6e9d20f6e895435c56d7b
Author: Nick Clemens 
Date:   Sat Sep 15 21:52:47 2018 +

Bug 20777: DBRev 18.06.00.030

Signed-off-by: Nick Clemens 

commit 2d94834807851c3325f26572c7a228903034741c
Author: Tomas Cohen Arazi 
Date:   Fri Sep 14 09:10:50 2018 -0700

Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit b64f1808f1682c5e132e0ddbc19ae5869a55bd99
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:55:26 2018 -0300

Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit f9359675e2f6a8b89ce471ac5f090eef33be3305
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:53:55 2018 -0300

Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 11e513f83f0c5fdd0d47de14b7c09635faf58ae4
Author: Nick Clemens 
Date:   Sat Sep 15 21:44:05 2018 +

Bug 21288: DBRev 18.06.00.029

Signed-off-by: Nick Clemens 

commit cb406f72b0266c97ac904754cc9637035000f5ca
Author: Pasi Kallinen 
Date:   Thu Aug 30 11:29:54 2018 +0300

Bug 21288: Slowness in acquisition caused by GetInvoices

The SQL query done by GetInvoices is quite slow on our production server,
taking about a minute.

In the query, there's this join:

  LEFT JOIN subscription ON biblio.biblionumber = subscription.biblionumber

but there's no index on subscription.biblionumber. Adding the index speeds
up the query so it only takes up about 3 seconds.

Signed-off-by: Pasi Kallinen 

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 

commit a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2
Author: Fridolin Somers 
Date:   Mon May 14 16:18:29 2018 +0200

Bug 20765: Fix search for items by acqdate in label batch

In Tools >  Label creator, when creating a batch you can add items using a 
search.

This search has filters on acquisition date.
Actually those filters does not work.
The create a search using CCL syntaxe to query Zebra search engine.

The cause is that operator "ge" or "le" must be before "st-date-normalized" 
in CCL query.
Looks like it is because of "st-date-normalized" uses "r=o" in 
ccl.properties.

Test plan :
1) Check in advance search you have indexed acquisition date
2) Go to Tools > Label creator
3) Click on New > Label batch
4) Click on Add item(s)
5) Enter a relevent date in "Added on or after date" and in "Added on or 
before date"
6) Click on "Search"
=> SUCCESS: You get results
7) Apply the patch
8) Retry the 'Add item(s)' step
=> SUCCESS: Patch doesn't change behaviour for old Zebra
9) Get rid of the patch on your working branch
10) Use the latest Zebra:
- /etc/apt/sources.list.d/indexdata.list:
deb http://ftp.indexdata.dk/debian jessie main
- Add the repo key:
  $ wget http://ftp.indexdata.dk/debian/indexdata.asc -O- | sudo apt-key 
add -
- Upgrade:
  $ sudo apt update; sudo apt dist-upgrade
  $ sudo koha-rebuild-zebra -f -a -b -v kohadev
  $ restart_all
11) Retry the 'Add item(s)' step
=> FAIL: No results!
9) Apply the patch, retry
=> SUCCESS: Search results!
- Sign off :-D

Signed-off-by: Maryse Simard 
Followed the test plan and it works.
Signed-off-by: Tomas Cohen Arazi 
It doesn't break with 2.0.59-1 (stretch/jessie), and fixes the problem
for 2.1.X.

Signed-off-by: Nick Clemens 

commit ca887754ead4d6207811d751229c4a4dbcf4af80
Auth

[koha-commits] main Koha release repository branch master updated. v18.05.00-747-gcf5a924

2018-09-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  cf5a92461835725fe44bb726c98bcfbf909dfdc8 (commit)
   via  01ea94979681ab89fc17beac2751be1ef4b394e1 (commit)
   via  7fa7e34967aa5fd6c48d4733c9ce5768c14cb735 (commit)
   via  8671ea1195c5bc65217017adcedefaf67b774a4e (commit)
   via  f0863d814da48d4eb3d511f888359eae4a6c4906 (commit)
   via  cabc16495e4f88dd5611987392818bc808ae42d0 (commit)
   via  3ddacb0defa459f7c1b4214ff43c2d2333a78879 (commit)
   via  d56c19138c36b79ba7d46c0a65c92469bf6fd12c (commit)
   via  7a84297ac4b29f4bdaf1bc4d01def71eb924d4fa (commit)
   via  60788555b3d79902ccef9f20cf76d4c764efcba0 (commit)
  from  2847ac4b4de239a430e6e9d20f6e895435c56d7b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit cf5a92461835725fe44bb726c98bcfbf909dfdc8
Author: Owen Leonard 
Date:   Fri Aug 3 15:13:57 2018 +

Bug 13692: series link is taking you to just 800a instead of whole 800

This patch modifies the OPAC and staff client's XSL template for the
detail page so that series links based on a traced 490 tag use both
author and series title from the 800 tag.

To test you should have multiple titles in the same series with matching
490 and 800 tags in each record. Apply the patch and restart Plack if
necessary.

View the detail page for one of the series' titles. The "Series:" link
should link to a search which uses both series title and author.
Clicking the link should return the correct results.

Test both the OPAC and staff client.

Signed-off-by: John Sterbenz 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 

commit 01ea94979681ab89fc17beac2751be1ef4b394e1
Author: Chris Cormack 
Date:   Fri Sep 14 22:48:23 2018 +

Bug 21347: Escaped fields that should be in addorderiso2709

Test plan
1/ Stage a MARC file (if you have none staged)
2/ Create a basket in aquisitions
3/ Add an order via staged file
4/ Look at the item information tab, notice there is escaped html
5/ Apply patch
6/ Refresh page, notice it is fixed

Signed-off-by: Sonia 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 7fa7e34967aa5fd6c48d4733c9ce5768c14cb735
Author: Nick Clemens 
Date:   Sun Sep 16 00:28:30 2018 +

Bug 20217: Compiled CSS

Signed-off-by: Nick Clemens 

commit 8671ea1195c5bc65217017adcedefaf67b774a4e
Author: Owen Leonard 
Date:   Fri Aug 10 13:37:49 2018 +

Bug 20217: Make header's catalog search menu into a split button

This patch modifies the markup for the staff client header's catalog
search menu so that it mimics the behavior of a Bootstrap split button
(As seen on the cataloging home page's 'New from Z39.50' button).

To test, apply the patch, run 'yarn build' to regenerate the staff
client's CSS, and clear your browser cache.

- View any page in the staff client.
- Hover your mouse over the "Search" link in the header. It should
  trigger a hover affect on the adjacent menu link.
- Clicking the "Search" link should take you directly to the advanced
  search page.
- Clicking the adjacent menu link should display a menu containing links
  to advanced search and item search.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit f0863d814da48d4eb3d511f888359eae4a6c4906
Author: Jonathan Druart 
Date:   Sun Sep 16 10:25:37 2018 -0700

Bug 19817: (follow-up) Remove local help files + edit help feature

I have no idea what happened but RM did not rebase that one correctly
before pushing it ;)

Signed-off-by: Nick Clemens 

commit cabc16495e4f88dd5611987392818bc808ae42d0
Author: Owen Leonard 
Date:   Wed May 2 16:08:29 2018 +

Bug 21305: Update two-column templates with Bootstrap grid: Patron clubs

This patch modifies patron clubs templates to use the Bootstrap grid
instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[koha-commits] main Koha release repository branch master updated. v18.05.00-750-g89d140c

2018-09-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  89d140c6a188a8672b2498481da6cb83802a9699 (commit)
   via  52a44a5cabe5d526c4a721828dd4f9cb9a1f2458 (commit)
   via  8f84ef2483cba072373b80c1941de6244f810f2b (commit)
  from  cf5a92461835725fe44bb726c98bcfbf909dfdc8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 89d140c6a188a8672b2498481da6cb83802a9699
Author: Jonathan Druart 
Date:   Fri Aug 24 16:22:20 2018 -0300

Bug 21257: (bug 13618 follow-up) Handle undef values in JS before 
escapeHtml call

To test:
1 - Find an item with no collection or location defined
2 - Check it out to a patron
3 - Note you cannot view the checkouts table
4 - Check the console: TypeError: oObj.collection is null
5 - Apply patch
6 - Restart all the things
7 - Checkouts table should load

Signed-off-by: Katrin Fischer 

Signed-off-by: Christopher Brannon 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 

commit 52a44a5cabe5d526c4a721828dd4f9cb9a1f2458
Author: Nick Clemens 
Date:   Sun Sep 16 04:20:40 2018 +

Bug 21317: Compiled CSS

Signed-off-by: Nick Clemens 

commit 8f84ef2483cba072373b80c1941de6244f810f2b
Author: Owen Leonard 
Date:   Wed Sep 5 14:13:25 2018 +

Bug 21317: Format long lists under Koha Team tab as columns

This patch adds a couple of new CSS classes for formatting content in
columns: .columns-3 and .columns-4. The four-column class is applied to
the dev team and contributing companies lists on the about page.

The patch also modifies the style of H3 on this page to improve
readability.

Unrelated: "Nelsonville Public Library" corrected to "Athens County
Public Libraries."

To test, apply the patch and regenerate staff client CSS

(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View the various tabs on the about page and confirm that everything
looks good. Confirm that the dev team and contributing companies lists
are formatted as columns.

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss |   16 
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |8 
 koha-tmpl/intranet-tmpl/prog/js/checkouts.js   |   12 ++--
 4 files changed, 27 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-27-g44ce16d

2018-09-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  44ce16d0069fdff7b487753277c11d368a083ccb (commit)
   via  40536fedd39a0a22c3e93a00721b573d66392e09 (commit)
   via  06f0209840d290bb1a7340f4b1af8d55e932f7c1 (commit)
   via  b8b006fd73381b0be9aac2432aebae07cfffca7d (commit)
  from  31db0813d36f21a0c898b75841a3e34364619a84 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 44ce16d0069fdff7b487753277c11d368a083ccb
Author: Nick Clemens 
Date:   Sat Sep 15 21:44:05 2018 +

Bug 21288: DBRev 18.05.03.002

Signed-off-by: Nick Clemens 
(cherry picked from commit 11e513f83f0c5fdd0d47de14b7c09635faf58ae4)
Signed-off-by: Martin Renvoize 

commit 40536fedd39a0a22c3e93a00721b573d66392e09
Author: Pasi Kallinen 
Date:   Thu Aug 30 11:29:54 2018 +0300

Bug 21288: Slowness in acquisition caused by GetInvoices

The SQL query done by GetInvoices is quite slow on our production server,
taking about a minute.

In the query, there's this join:

  LEFT JOIN subscription ON biblio.biblionumber = subscription.biblionumber

but there's no index on subscription.biblionumber. Adding the index speeds
up the query so it only takes up about 3 seconds.

Signed-off-by: Pasi Kallinen 

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit cb406f72b0266c97ac904754cc9637035000f5ca)
Signed-off-by: Martin Renvoize 

commit 06f0209840d290bb1a7340f4b1af8d55e932f7c1
Author: Fridolin Somers 
Date:   Mon May 14 16:18:29 2018 +0200

Bug 20765: Fix search for items by acqdate in label batch

In Tools >  Label creator, when creating a batch you can add items using a 
search.

This search has filters on acquisition date.
Actually those filters does not work.
The create a search using CCL syntaxe to query Zebra search engine.

The cause is that operator "ge" or "le" must be before "st-date-normalized" 
in CCL query.
Looks like it is because of "st-date-normalized" uses "r=o" in 
ccl.properties.

Test plan :
1) Check in advance search you have indexed acquisition date
2) Go to Tools > Label creator
3) Click on New > Label batch
4) Click on Add item(s)
5) Enter a relevent date in "Added on or after date" and in "Added on or 
before date"
6) Click on "Search"
=> SUCCESS: You get results
7) Apply the patch
8) Retry the 'Add item(s)' step
=> SUCCESS: Patch doesn't change behaviour for old Zebra
9) Get rid of the patch on your working branch
10) Use the latest Zebra:
- /etc/apt/sources.list.d/indexdata.list:
deb http://ftp.indexdata.dk/debian jessie main
- Add the repo key:
  $ wget http://ftp.indexdata.dk/debian/indexdata.asc -O- | sudo apt-key 
add -
- Upgrade:
  $ sudo apt update; sudo apt dist-upgrade
  $ sudo koha-rebuild-zebra -f -a -b -v kohadev
  $ restart_all
11) Retry the 'Add item(s)' step
=> FAIL: No results!
9) Apply the patch, retry
=> SUCCESS: Search results!
- Sign off :-D

Signed-off-by: Maryse Simard 
Followed the test plan and it works.
Signed-off-by: Tomas Cohen Arazi 
It doesn't break with 2.0.59-1 (stretch/jessie), and fixes the problem
for 2.1.X.

Signed-off-by: Nick Clemens 
(cherry picked from commit a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2)
Signed-off-by: Martin Renvoize 

commit b8b006fd73381b0be9aac2432aebae07cfffca7d
Author: Jonathan Druart 
Date:   Sat Sep 15 11:24:32 2018 -0700

Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00

Tests will fail (Jenkins run #554) if run after 23:00

 #   Failed test 'Id is correct'
 #   at t/db_dependent/Koha/GetDailyQuote.t line 72.
 #  got: 6
 # expected: 8

 #   Failed test 'Timestamp 2018-09-15 00:44:46 is correct'
 #   at t/db_dependent/Koha/GetDailyQuote.t line 74.
 #  got: '2018-09-14 23:44:46'
 # expected: '2018-09-15 00:44:46'
 # Looks like you failed 2 tests of 12.
 [23:44:46] t/db_dependent/Koha/GetDailyQuote.t
 Dubious, test returned 2 (wstat 512, 0x200)

Adding only 1 second will hugely reduce the risk of failure here.

It also updates a useless test (column 'quote' does not exist)

Signed-off-by: Tomas Cohen Arazi 

Tested:
- Run:
  $ sudo date -s 2018-09-15T23:10:00
  $ kshell
 k$ prove t/db_dependent/Koha/GetDailyQuote.t
=> FAIL: Tests fail as patch author mentions
- Apply the patch
   

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-23-g31db081

2018-09-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  31db0813d36f21a0c898b75841a3e34364619a84 (commit)
   via  9f221f9ae8b16846bd3b9b35b19d4b5434050f95 (commit)
   via  903b880f330026d476d761901a2099972159a94c (commit)
   via  7fe692bf0ec4dd6744c81c068c400927ccc0c54d (commit)
   via  ee2d5ae04dc4c5fed9f09c9067c3de0037cdba8e (commit)
   via  89f6aacecc787affd07856d6c092f21bacab7993 (commit)
   via  637469974c3290a43ac259642df0fefdfe2d369f (commit)
  from  3017d592a10da23fc12e6a94ba70d7ff9e7d7d94 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 31db0813d36f21a0c898b75841a3e34364619a84
Author: Marcel de Rooy 
Date:   Fri Sep 14 11:53:37 2018 +0200

Bug 19179: (QA follow-up) Replace second E-mail

Better write here exactly what we need to type in the pref text box.
Since E-mail will not work and Email will :)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit b0ef7174fe601bbf39408e455365ea563949b4bb)
Signed-off-by: Martin Renvoize 

commit 9f221f9ae8b16846bd3b9b35b19d4b5434050f95
Author: Charlotte Cordwell 
Date:   Fri Sep 7 03:35:36 2018 +

Bug 19179: Email option for SMSSendDriver is not documented

'Email' is not documented as a valid setting.

1) Apply patch.
2) Go to Administration --> search SMSSendDriver
3) Check if SMSSendDriver has this message is at the end of the box:
   "If you would prefer to receive SMS via E-mail set SMSSendDriver to 
Email"

Signed-off-by:  Michal Denar 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 2d6cf8bd7a0e290c8bb947ed1880f1e906d0e74c)
Signed-off-by: Martin Renvoize 

commit 903b880f330026d476d761901a2099972159a94c
Author: Owen Leonard 
Date:   Fri Jul 27 12:43:50 2018 +

Bug 21127: Remove jqTransform jQuery plugin from the OPAC

This patch removes the jqTransform jQuery plugin from the OPAC. It was
added for the CCSR theme, which no longer exists.


http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c7c2e9efbde273f2b77786316b7502a8847072bd

There will be no visible changes to the OPAC after applying the patch.
Search the Koha codebase for references to jqTransform and confirm that
none exist.

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 83e515820abb6e2fa8ddf30f61b3f4972a48ed10)
Signed-off-by: Martin Renvoize 

commit 7fe692bf0ec4dd6744c81c068c400927ccc0c54d
Author: Pasi Kallinen 
Date:   Mon Aug 20 07:30:45 2018 +0300

Bug 21248: Fix COinS carp in MARC details page on unknown record

Looking up a nonexistent record in the MARC details -page causes
the COinS to carp. The fix is trivial, just move the COinS call
couple lines, after the record existence check.

TEST PLAN
-
1) reset_all for kohadevbox
2) log in to staff client - admin/admin
3) search catalogue for green
4) tweak the top URL to have a bad biblionumber (eg. )
5) cat /var/log/koha/kohadev/plack-err.log
   -- floody! with errors.
6) echo | sudo tee /var/log/koha/kohadev/plack-err.log
7) restart_all
8) repeat steps 2 through 5.
   -- just nice starting messages, not floody.
9) run koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

(cherry picked from commit 030047da428521c248868e3ee5d655afd3bed05b)

Signed-off-by: Martin Renvoize 

commit ee2d5ae04dc4c5fed9f09c9067c3de0037cdba8e
Author: Marcel de Rooy 
Date:   Fri Sep 7 09:50:40 2018 +0200

Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl

Script offline_circ/download.pl does not use the return values of
checkauth. So should not assign them to bad chosen variables that do
not correspond with checkauth but with get_template_and_user.

Test plan:
Look for $template, $loggedinuser, $cookie, $flags in the code.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit bf7082f854a1db9eb5b7eb77e5f450d018d8e07b)
Signed-off-by: Martin Renvoize 

commit 89f6aacecc787affd07856d6c092f21bacab7993
Author: David Cook 
Date:   Thu Jul 19 16:57:22 2018 +1000

Bug 13779: sessionID declared twice in C4::Auth::checkauth()

The bug is that $sessionID is declared twice in C4::Auth::checkauth().
At the moment, this doesn't act

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-31-g9659b2f

2018-09-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  9659b2f447ef21a71b3d3698fba126be526a8849 (commit)
   via  6fe2ebd1e465b5458a26aa736a02c944ba9b8f9d (commit)
   via  b2bfea26a72a13ea6b5bb33eebd604d8f015 (commit)
   via  d3d43360b04864f13e7a2d6fdf37e3bcf4cf1e83 (commit)
  from  44ce16d0069fdff7b487753277c11d368a083ccb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 9659b2f447ef21a71b3d3698fba126be526a8849
Author: Nick Clemens 
Date:   Sat Sep 15 21:52:47 2018 +

Bug 20777: DBRev 18.05.03.003

Signed-off-by: Nick Clemens 
(cherry picked from commit 2847ac4b4de239a430e6e9d20f6e895435c56d7b)
Signed-off-by: Martin Renvoize 

commit 6fe2ebd1e465b5458a26aa736a02c944ba9b8f9d
Author: Tomas Cohen Arazi 
Date:   Fri Sep 14 09:10:50 2018 -0700

Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 2d94834807851c3325f26572c7a228903034741c)
Signed-off-by: Martin Renvoize 

commit b2bfea26a72a13ea6b5bb33eebd604d8f015
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:55:26 2018 -0300

Bug 20777: DBIC update

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit b64f1808f1682c5e132e0ddbc19ae5869a55bd99)
Signed-off-by: Martin Renvoize 

commit d3d43360b04864f13e7a2d6fdf37e3bcf4cf1e83
Author: Tomas Cohen Arazi 
Date:   Thu May 17 10:53:55 2018 -0300

Bug 20777: Remove unused accountlines.dispute field

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit f9359675e2f6a8b89ce471ac5f090eef33be3305)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha.pm|2 +-
 Koha/REST/V1/Patrons/Account.pm|1 -
 Koha/Schema/Result/Accountline.pm  |   11 ++-
 installer/data/mysql/kohastructure.sql |1 -
 installer/data/mysql/updatedatabase.pl |   12 
 5 files changed, 15 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-35-g145eef6

2018-09-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  145eef6a9037b93cd8902f0a77582fcadbf517bc (commit)
   via  c82595a4fa5c93ba5220ab0c95bc296f70fa5a78 (commit)
   via  ad16c9f5b20525303eb631107883cb37e36de8cd (commit)
   via  c28d8f0600806f9930d115b2fdbccc21f5e86436 (commit)
  from  9659b2f447ef21a71b3d3698fba126be526a8849 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 145eef6a9037b93cd8902f0a77582fcadbf517bc
Author: Owen Leonard 
Date:   Fri Aug 3 15:13:57 2018 +

Bug 13692: series link is taking you to just 800a instead of whole 800

This patch modifies the OPAC and staff client's XSL template for the
detail page so that series links based on a traced 490 tag use both
author and series title from the 800 tag.

To test you should have multiple titles in the same series with matching
490 and 800 tags in each record. Apply the patch and restart Plack if
necessary.

View the detail page for one of the series' titles. The "Series:" link
should link to a search which uses both series title and author.
Clicking the link should return the correct results.

Test both the OPAC and staff client.

Signed-off-by: John Sterbenz 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit cf5a92461835725fe44bb726c98bcfbf909dfdc8)
Signed-off-by: Martin Renvoize 

commit c82595a4fa5c93ba5220ab0c95bc296f70fa5a78
Author: Caroline Cyr La Rose 
Date:   Sat Sep 15 16:10:22 2018 -0400

Bug 21356: Add Missing space in parcel.tt

This patch adds a space between the user's name and 'On:'
in parcel.tt.

To test:

1) Go to Acquisitions
2) Search for a vendor
3) Create a new basket
4) Add an order to the basket
5) Close the basket
6) Receive the order
7) In the page title 'Receipt summary' notice there is no space
between the 'Received by' user name and 'On:'
8) Apply the patch
9) Refresh the page, there should now be a space

Signed-off-by: Fridolin Somers 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit d56c19138c36b79ba7d46c0a65c92469bf6fd12c)
Signed-off-by: Martin Renvoize 

commit ad16c9f5b20525303eb631107883cb37e36de8cd
Author: Nick Clemens 
Date:   Thu Aug 23 14:44:31 2018 +

Bug 21262: Do not format numbers for editing if too big

This patch copies the code from bug 15770 to the format_for_editing
sub.

It also corrects schema issue, listing the purpose for two acq columns
instead of claing unused

To test:
1 - Edit a fund
2 - Set warning at amount to: 100
3 - Save budget
4 - Try to edit - internal server error
5 - Apply patch
6 - Should be able to edit budget
7 - Number should appear unformatted

Signed-off-by: Christopher Brannon 

Signed-off-by: Jonathan Druart 
2 quick notes:
1. Code must be moved to a subroutine if reused later
2. It would have prefered to have the comment of the 2 DB columns on a 
separate patch
(even separate bug report). As it's minor and that the patch will certainly 
backported
I will not block it.

Signed-off-by: Nick Clemens 
(cherry picked from commit 7a84297ac4b29f4bdaf1bc4d01def71eb924d4fa)
Signed-off-by: Martin Renvoize 

commit c28d8f0600806f9930d115b2fdbccc21f5e86436
Author: Jonathan Druart 
Date:   Sun Sep 16 09:49:46 2018 -0700

Bug 21360: Prevent IssueSlip.t to fail when run at 23:59

Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if
launched after 23:00) but we should have tested with 23:59, not 23:50...

koha_1   | # Looks like you planned 3 tests but ran 2.
koha_1   |
koha_1   | #   Failed test 'Issue slip'
koha_1   | #   at t/db_dependent/Members/IssueSlip.t line 294.
koha_1   | Label not found for "last SKIP" at 
/usr/share/perl5/Test/More.pm line 1370.
koha_1   | # Looks like your test exited with 255 just after 1.
koha_1   | [23:59:10] t/db_dependent/Members/IssueSlip.t
koha_1   | Dubious, test returned 255 (wstat 65280, 0xff00)
koha_1   | Failed 3/3 subtests

Test plan:
0/ Don't apply this patch
1/ sudo date -s "2018-09-15 23:59:00";prove 
t/db_dependent/Members/IssueSlip.t
=> You should get the error
2/ Apply this patch and repeat 1.
=> Tests should pass now!

Signed-off-by: Nick Clemens 
(cherry picked from commit 60788555b3d79902ccef9f20cf7

[koha-commits] main Koha release repository branch master updated. v18.05.00-764-ga299ae3

2018-09-19 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  a299ae3a84795431eaea96152c5347eb5091ba23 (commit)
   via  361dd4f499468f5cdbd381dfd9f23484f1c71f7a (commit)
   via  4681e01884f10ab1a6febfa6e888d9ff79939ae5 (commit)
   via  b9bbc4b32aa01dcac353faf8f6dcea8aad987bc4 (commit)
   via  d5925f34b0028f563e10494dc2280b6c51a74745 (commit)
   via  a225cd1e0444014731abe974a686ff7b1ce50b12 (commit)
   via  6b8218ee2f6012975be5974a0b2c8e24a39f1a11 (commit)
   via  5cf279aea0d2a2037adb26857119ee209825ef70 (commit)
   via  f35d22ab60b9020f2a4363e0a9afa4e92d065416 (commit)
   via  8b806227c130e86712e3e5bda61520447c60671d (commit)
   via  a389c751cb5bd764bf486200a581f731b6d28cc7 (commit)
   via  a302fc8d787b970d89fd1a31c36f9f3d881117ab (commit)
   via  65cbeae78c2ec7449efdaf6841826b7a70dac3c9 (commit)
   via  05e51e9574884f03034633dfef95e7e95ac0224e (commit)
  from  89d140c6a188a8672b2498481da6cb83802a9699 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit a299ae3a84795431eaea96152c5347eb5091ba23
Author: Nick Clemens 
Date:   Wed Sep 19 14:35:41 2018 +

Bug 13406: (RM follow-up) Add missing filter

Signed-off-by: Nick Clemens 

commit 361dd4f499468f5cdbd381dfd9f23484f1c71f7a
Author: Jonathan Druart 
Date:   Sun Sep 16 10:15:10 2018 -0700

Bug 19833: Bibliographic Record => Bibliographic record

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 4681e01884f10ab1a6febfa6e888d9ff79939ae5
Author: Owen Leonard 
Date:   Fri Mar 16 14:24:56 2018 +

Bug 19833: (follow-up) Minor corrections

This patch makes minor corrections to lines modified in the previous
ones.

On the biblio framework page, I have deleted this line because it didn't
make much sense before or after the change:

"Framework name, then go to MARC biblio to set MARC editor parameters"

In the web services preferences file, I reverted a change to
"deletedbiblio" because it refers to a table name.

I've also made corrections to instances of "biblio" in the following
pages, including changing "biblio number" to "biblionumber," since it
refers to a specific Koha column name.

- MARC detail page
- Help files:
  - Record matching rule;s
  - Batch item modification
  - MARC modification templates
- Export data
- Staged MARC record management

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit b9bbc4b32aa01dcac353faf8f6dcea8aad987bc4
Author: Zoe Bennett 
Date:   Wed Jan 17 02:57:27 2018 +

Bug 19833: Changing the "biblios"

To Test:
Check the following files that all the "biblio" or "biblio record" are
now written in rull as "bibliographic record".

modules/about.tt

Corrected a single capitalization error during signoff

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit d5925f34b0028f563e10494dc2280b6c51a74745
Author: Grace Smyth 
Date:   Wed Jan 17 02:38:38 2018 +

Bug 19833: Changing the "biblios" acqui

To test:
Check the following files that all all "biblio" or "biblo record" are
now writen in full as "bibliographic record".

modules/acqui/addorderiso2709.tt:44
modules/acqui/booksellers.tt:3
modules/acqui/invoices.tt:3

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit a225cd1e0444014731abe974a686ff7b1ce50b12
Author: Zoe Bennett 
Date:   Wed Jan 17 02:27:57 2018 +

Bug 19833: Changing the "biblios" - most of reports

To Test:
Check the following files that all the "biblio" or "biblio record" are
now written in full as "bibliographic record".

modules/reports/acquisitions_stats.tt
modules/reports/cash_register_status.tt
modules/reports/catalogue_stats.tt
modules/reports/issues_stats.tt
modules/reports/reserves_stats.tt

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 6b8218ee2f6012975be5974a0b2c8e24a39f1a11
Author: Zoe Bennett 
Date:   Wed Jan 17 01:55:34 2018 +

Bug 19833: Changing the "biblios" - most of admin

To Test:
Check the following files that all all "biblio" or "biblo record" are
now writen in full as "bibliographic record".

  

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-38-gead5617

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ead5617f927e397b968acf81b9d86e16de4d60c9 (commit)
   via  cd786a9c4ddeded20e574b128d0bac43a2eb52d0 (commit)
   via  4881ecece5d8fcdac867d7b6936923d451a3d48a (commit)
  from  145eef6a9037b93cd8902f0a77582fcadbf517bc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ead5617f927e397b968acf81b9d86e16de4d60c9
Author: Nick Clemens 
Date:   Wed Sep 19 14:35:41 2018 +

Bug 13406: (RM follow-up) Add missing filter

Signed-off-by: Nick Clemens 
(cherry picked from commit a299ae3a84795431eaea96152c5347eb5091ba23)
Signed-off-by: Martin Renvoize 

commit cd786a9c4ddeded20e574b128d0bac43a2eb52d0
Author: Jane Sandberg 
Date:   Sun Sep 16 22:38:29 2018 +

Bug 13406: (follow-up) Add styling classes to authority MARC detail display

Signed-off-by: Jane Sandberg 
Amended patch: replace tab characters with spaces

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 65cbeae78c2ec7449efdaf6841826b7a70dac3c9)
Signed-off-by: Martin Renvoize 

commit 4881ecece5d8fcdac867d7b6936923d451a3d48a
Author: Jane Sandberg 
Date:   Sun Sep 16 11:59:40 2018 -0700

Bug 13406: Add styling classes to authority MARC detail display

When viewing authority MARC records in the staff client (detail view), the
MARC tags were not displaying with the tag_num, tag_desc, tag_ind1,
tag_ind2, and desc classes, which made it impossible to add styles
to these specific parts of a MARC tag.  This commit adds these
styles (which are the same as the classes in the bibliographic
MARC detail display).

To test:
1) Open the staff client, then click Authorities.
2) Search for an authority record.
3) Click on Details.
4) Examine some MARC fields.  Note that the entire tag title line
is in a single .
5) Apply this commit.
6) Repeat steps 1-3.
7) Notice that the tag title line is now separated into several
spans, each with their own classes.

Signed-off-by: Jane Sandberg 

Signed-off-by: Brendan Gallagher 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 05e51e9574884f03034633dfef95e7e95ac0224e)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 authorities/detail.pl|   12 
 .../intranet-tmpl/prog/en/modules/authorities/detail.tt  |   14 +-
 2 files changed, 17 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-40-g2e8f370

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  2e8f370f26836a257d27ad0be4adb4e6db3f9653 (commit)
   via  a532ce2d13fe2aecd11518e18ac3ff0756b530af (commit)
  from  ead5617f927e397b968acf81b9d86e16de4d60c9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2e8f370f26836a257d27ad0be4adb4e6db3f9653
Author: Nick Clemens 
Date:   Wed Sep 19 13:40:59 2018 +

Bug 7143: Update about page for new dev - Jane Sandberg

Signed-off-by: Nick Clemens 
(cherry picked from commit a389c751cb5bd764bf486200a581f731b6d28cc7)
Signed-off-by: Martin Renvoize 

commit a532ce2d13fe2aecd11518e18ac3ff0756b530af
Author: Martin Renvoize 
Date:   Thu Sep 6 13:58:19 2018 +0100

Bug 7143: Update history to reflect recent point releases

Signed-off-by: Nick Clemens 
(cherry picked from commit a302fc8d787b970d89fd1a31c36f9f3d881117ab)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 docs/history.txt |   13 +
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt |1 +
 2 files changed, 14 insertions(+)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-43-gab79f3f

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ab79f3fc67a06ea7383270ae7f00f97605c3a4d0 (commit)
   via  f243f8f0123a29752f37df0cc8ad25a49ba066e6 (commit)
   via  0f45f3afdf67193ec849f72955b6de4fbeb17db0 (commit)
  from  2e8f370f26836a257d27ad0be4adb4e6db3f9653 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ab79f3fc67a06ea7383270ae7f00f97605c3a4d0
Author: Tomas Cohen Arazi 
Date:   Mon Jul 23 11:14:47 2018 -0300

Bug 21116: Add API routes through plugins

This patch adds plugins the capability of injecting new routes on the
API.

The plugins should provide the following methods to be considered valid 
API-generating plugins:

- 'api_routes': returning the 'path' component of the OpenAPI specification 
corresponding to the routes served by the plugin
- 'api_namespace': it should return a namespace to be used for grouping the 
endpoints provided by the plugin

otherwise, they will be just skipped.

All plugin-generated routes will be added the 'contrib' namespace, and
will end up placed inside /contrib/, where  is what 
the 'api_namespace' returns.

A sample endpoint will be added to the Kitchen Sink plugin, and tests
are being written.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> SUCCESS: Tests pass!
- Install the (latest) KitchenSink plugin
- Point your browser to the API like this:
  http://koha-intra.myDNSname.org:8081/api/v1/.html
=> SUCCESS: The /contrib/kitchensink/patrons/:patron_id/bother endpoint
implemented by the plugin has been merged!
- Sign off! :-D

Signed-off-by: Benjamin Rokseth 
Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Alex Arnaud 

Signed-off-by: Nick Clemens 
(cherry picked from commit 3fedae85f25ef5f587d567b51b86aab776d87311)
Signed-off-by: Martin Renvoize 

commit f243f8f0123a29752f37df0cc8ad25a49ba066e6
Author: Tomas Cohen Arazi 
Date:   Mon Aug 27 16:24:09 2018 -0300

Bug 21116: Unit tests

This path implements unit tests for the route-from-plugin development.
It adds the required methods to the Koha::Plugin::Test plugin
distributed along with the tests. A second plugin implementing invalid
OpenAPI specs is added (Koha::Plugin::BadAPIRoute).

Edit: I made terminology changes to make it less rude.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Alex Arnaud 

Signed-off-by: Nick Clemens 
(cherry picked from commit 46c992948ea28ae2bebc7f9042df6434319b80bf)
Signed-off-by: Martin Renvoize 

commit 0f45f3afdf67193ec849f72955b6de4fbeb17db0
Author: Nick Clemens 
Date:   Tue Jul 10 13:48:07 2018 +

Bug 20564: Don't use system to unzip files

To test:
1 - Setup a zip file for patron images and cover images
2 - Test each tool
3 - Get a '500 error' after upload (note images do upload and attach)
4 - Apply patch
5 - Restart all the things
6 - Test agtain, uploads should complete and results display

Signed-off-by: George Williams 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8b806227c130e86712e3e5bda61520447c60671d)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha/Exceptions/Plugin.pm  |   84 ++
 Koha/REST/Plugin/PluginRoutes.pm   |  140 
 Koha/REST/V1.pm|   37 +--
 t/db_dependent/Koha/REST/Plugin/PluginRoutes.t |   83 ++
 t/lib/Koha/Plugin/BadAPIRoute.pm   |   92 
 t/lib/Koha/Plugin/Test.pm  |   65 +++
 tools/picture-upload.pl|4 +-
 tools/upload-cover-image.pl|4 +-
 8 files changed, 500 insertions(+), 9 deletions(-)
 create mode 100644 Koha/Exceptions/Plugin.pm
 create mode 100644 Koha/REST/Plugin/PluginRoutes.pm
 create mode 100644 t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
 create mode 100644 t/lib/Koha/Plugin/BadAPIRoute.pm


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-776-g87dc160

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  87dc160555ed106fb09e15d5a0eaf1e7313ff77d (commit)
   via  cdfc1c08c96a06d5fe709777374aded10ff4a7ed (commit)
   via  4df6a3ef796c6e8dd002c0cc1cd4d4b2d501be34 (commit)
   via  0fd329724b58c34d850a5b5f162ad0c0f2428eb4 (commit)
   via  401f19d56fdfa7133ed60661bb2492ddcbcedc30 (commit)
   via  3dda7d6c7fa683f910aeacdf89658af8ee9755cd (commit)
   via  f6eb46151626aba7da3490aac726f17d6a19d866 (commit)
   via  6f2a0acc2d614e630deabba872a136de6e6aa349 (commit)
   via  dac230963dd69fe7a07b13ab69512728fce9f9fd (commit)
   via  429ab60a0916ddda87f18f177361011d7cc2705a (commit)
   via  177deef3b0ff5ece0f1ad074b9b9adc078048245 (commit)
   via  6b77697c31e9a23c85dd430d764d92143f850d76 (commit)
  from  a299ae3a84795431eaea96152c5347eb5091ba23 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 87dc160555ed106fb09e15d5a0eaf1e7313ff77d
Author: Nick Clemens 
Date:   Thu Sep 20 13:35:29 2018 +

Bug 20656: (RM follow-up) Add missing filter

Signed-off-by: Nick Clemens 

commit cdfc1c08c96a06d5fe709777374aded10ff4a7ed
Author: Nick Clemens 
Date:   Sun Sep 16 03:50:13 2018 +

Bug 20656: (follow-up) Don't display title for F or FU fines (it is in 
description)

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 4df6a3ef796c6e8dd002c0cc1cd4d4b2d501be34
Author: Nick Clemens 
Date:   Tue Apr 24 20:58:50 2018 +

Bug 20656: Better formatting for print summary

This patch is a slightly edited c&p from boraccount.tt

1 - Manually add a credit with no notes to patron
2 - Print summary
3 - Inspect the line
4 - Note that td has extra newlines and no words
5 - Apply patch
6 - Print summary again
7 - Note better formatting

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 0fd329724b58c34d850a5b5f162ad0c0f2428eb4
Author: Nick Clemens 
Date:   Tue Apr 24 20:57:17 2018 +

Bug 20656: Don't print lines that have no balance on print summary

To test:
1 - Add at least two fines to a patron
2 - Pay off one of them
3 - Print summary - all 3 lines show
4 - Apply patch
5 - Print summary - only line with balance shows

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 401f19d56fdfa7133ed60661bb2492ddcbcedc30
Author: Nick Clemens 
Date:   Thu Sep 20 13:34:49 2018 +

Bug 20819: (RM follow-up) Add missing filters

Signed-off-by: Nick Clemens 

commit 3dda7d6c7fa683f910aeacdf89658af8ee9755cd
Author: Nick Clemens 
Date:   Thu Sep 20 13:02:20 2018 +

Bug 20819: DBRev 18.06.00.031

Signed-off-by: Nick Clemens 

commit f6eb46151626aba7da3490aac726f17d6a19d866
Author: Marcel de Rooy 
Date:   Thu May 31 12:29:59 2018 +0200

Bug 20819: Add consent to self-registration process

We add a section for the GDPR consent in opac-memberentry (only for the
self-registration). Not when editing personal details.

Test plan:
[1] Enable selfregistration (with confirm) and GDPR policy.
[2] Register a new account in OPAC. Verify that the GDPR checkbox is
required.
[3] After you submit, you should see a date in borrower_modifications
field gdpr_proc_consent.
[4] When you confirm, verify that the consent is visible on your consents.
[5] Enable selfregistration without confirmation mail. Register again.
[6] Check your consents tab again.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 6f2a0acc2d614e630deabba872a136de6e6aa349
Author: Marcel de Rooy 
Date:   Mon May 28 14:59:31 2018 +0200

Bug 20819: Add check in get_template_and_user to enforce GDPR

If you choose to enforce GDPR policy, a user needs to give consent for
data processing before he does something else in the OPAC while being
logged in.

Test plan:
[1] Set GDPR_Policy to Disabled or Permissive. Usual behavior.
[2] Set to Enforced. Save a refusal on your consents. Notice that
you are logged out when saving. When you login again, all OPAC
requests are redirected to your consents tab.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit dac230963dd69fe7a07b13ab69512728fce9f9fd
Author: Marcel de Ro

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-45-g2cec621

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  2cec62128c8521618c95fbf5e1b542fab395aa32 (commit)
   via  bbd86576ff80126203c7a957aad6885435eb5aaa (commit)
  from  ab79f3fc67a06ea7383270ae7f00f97605c3a4d0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2cec62128c8521618c95fbf5e1b542fab395aa32
Author: Tomas Cohen Arazi 
Date:   Tue Sep 11 10:48:15 2018 -0700

Bug 21334: Add bibliographic content type definitions

This patch adds the following content type definitions, to be used by
endpoint authors implementing MARC-related endpoints:

--
| Content-type | Alias   |
|--|-|
| application/marcxml+xml  | marcxml |
| application/marc-in-json | mij |
| application/marc | marc|
--

Code using this aliases will use them like this:
- Suppose you want to output data in MARCXML format:

my $record = cool_method_that_returns_MARC_RECORD();
return $c->render( status => 200, format => 'marcxml', text => 
$record->as_xml_record );

Note: 'text' by defaults encodes output as UTF-8. If the encoding is not
UTF-8 you should encode the data on your own.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/V1.t
=> SUCCESS: Test pass!
- Sign off :-D

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

(cherry picked from commit b612ec7a0de5c77ca29a07728664fbd1d8cb7812)

Signed-off-by: Martin Renvoize 

commit bbd86576ff80126203c7a957aad6885435eb5aaa
Author: Tomas Cohen Arazi 
Date:   Tue Sep 11 10:43:32 2018 -0700

Bug 21334: Unit tests

This patch adds unit tests for the new content types being added.
It also adds tests for the 'json' overloading that already takes place
in V1.pm.

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 1442499a0b6d6c22c87b7ef9eea4c7cc540e3fce)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha/REST/V1.pm|7 ++-
 .../{Template/Plugin/To.t => Koha/REST/V1.t}   |   47 +---
 2 files changed, 28 insertions(+), 26 deletions(-)
 copy t/db_dependent/{Template/Plugin/To.t => Koha/REST/V1.t} (50%)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-9-g1293b0a

2018-09-20 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  1293b0a05b1991f80ac547106a861c253c81aa35 (commit)
   via  452d61c3e174e0a638fca3bec7ec76d7551cb86f (commit)
  from  2d3aca1b6dec7948d463a827b3a786ea736ac89f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 1293b0a05b1991f80ac547106a861c253c81aa35
Author: Nick Clemens 
Date:   Tue Jul 10 13:48:07 2018 +

Bug 20564: Don't use system to unzip files

To test:
1 - Setup a zip file for patron images and cover images
2 - Test each tool
3 - Get a '500 error' after upload (note images do upload and attach)
4 - Apply patch
5 - Restart all the things
6 - Test agtain, uploads should complete and results display

Signed-off-by: George Williams 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8b806227c130e86712e3e5bda61520447c60671d)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 0f45f3afdf67193ec849f72955b6de4fbeb17db0)
Signed-off-by: Fridolin Somers 

commit 452d61c3e174e0a638fca3bec7ec76d7551cb86f
Author: Tomas Cohen Arazi 
Date:   Wed Aug 29 13:46:39 2018 -0300

Bug 21285: Add missing select2x2.png file

This file is part of the Select2 jquery plugin, but wasn't added when
the use of the plugin was introduced in Koha.

To test:
- On a high DPI screen (retina mac?) on Chrome or Safari
- Edit an item
=> FAIL: dropdowns using Select2 (like 'Shelving location') don't display 
the icons (down arrow and cross) and a default value is wrongly selected
=> FAIL: the inspector says the requested select2x2.png file returned a 400 
error.
- Apply this patch
- Reload the edit page
=> SUCCESS: Things display correctly! Dropdowns without selected values
by default!
=> SUCCESS: No errors fetching select2x2.png
- Sign off :-D

Signed-off-by: Jesse Maseto 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 235654a3cfa5b6e323489408ddc7875281bb1f50)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 637469974c3290a43ac259642df0fefdfe2d369f)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/lib/select2/css/select2x2.png |  Bin 0 -> 845 bytes
 tools/picture-upload.pl   |4 +++-
 tools/upload-cover-image.pl   |4 +++-
 3 files changed, 6 insertions(+), 2 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/lib/select2/css/select2x2.png


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-15-gc110912

2018-09-21 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  c110912af3f4ff5f41eea4668d38863a951d82c0 (commit)
   via  d802bf6722f9ac79b9460edc307c656cd3358763 (commit)
   via  711f65a6894f8979734f2738ec3500dee4756826 (commit)
   via  3725ca1be905bfa02ccac12e5256e6f33ff0e164 (commit)
   via  7a75e0b963c6fa7e087d5cd41dc9a777c1ebfa31 (commit)
   via  990b133fa7f44c22de2bfcac6a6f8055481b8203 (commit)
  from  1293b0a05b1991f80ac547106a861c253c81aa35 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit c110912af3f4ff5f41eea4668d38863a951d82c0
Author: Jonathan Druart 
Date:   Tue Jul 31 12:43:54 2018 -0300

Bug 21134: Correctly throw the exception in 
Koha::Patron::Modification->approve

koha_1   | # Looks like you planned 20 tests but ran 9.
koha_1   |
koha_1   | #   Failed test 'approve tests'
koha_1   | #   at t/db_dependent/Koha/Patron/Modifications.t line
259.
koha_1   | [Something went wrong]# Looks like your test exited with
255 just after 5.
koha_1   | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t
.

"Something went wrong" should never been thrown,
Koha::Patron::Modification->approve raises $@, but it's not defined, it
should raise $_ instead

Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit 6e99cfbca7e904b7664163838a334c487c94e462)
Signed-off-by: Martin Renvoize 
(cherry picked from commit c6133753ed661902a9ec3cce14190c7d3d683ef0)
Signed-off-by: Fridolin Somers 

commit d802bf6722f9ac79b9460edc307c656cd3358763
Author: David Cook 
Date:   Fri Jul 20 18:13:49 2018 +1000

Bug 21097: Missing optgroup closing tag in orderreceive.tt

There is a missing optgroup closing tag in orderreceive.tt. It doesn't
actually cause any display issues (at least in modern browsers), but
it's invalid markup, so this patch fixes it.

_TEST PLAN_
0. Add a budget and add a fund
1. Add a vendor
2. Add a basket
3. Add an order to a basket
4. Close the basket
5. Receive the order
6. Make sure the budget and fund both display when selecting the fund

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 12e18f91be2a26501fba502d5f1106d66b06caee)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 881781240cf0c1a487da1d05732dab300d6e1be7)
Signed-off-by: Fridolin Somers 

commit 711f65a6894f8979734f2738ec3500dee4756826
Author: Owen Leonard 
Date:   Thu Jun 21 13:37:35 2018 +

Bug 20974: Remove files left behind after removing Solr

Some files were left behind when Bug 12538 removed support for Solr.
This patch removes them.

To test, apply the patch and fail to observe the existence of these
files:

koha-tmpl/opac-tmpl/bootstrap/en/includes/search/facets.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/search/page-numbers.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/search/resort_form.inc

Perform a search in the OPAC to confirm that nothing broke.

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit ad34ef74cdee0f204c03cdf88b1db775768a44fe)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 517827fb9c2e69d58d8e9345ba2d259de08efded)
Signed-off-by: Fridolin Somers 

commit 3725ca1be905bfa02ccac12e5256e6f33ff0e164
Author: Nick Clemens 
Date:   Thu Jul 12 10:18:10 2018 +

Bug 21064: Use undefined instead of undef

To test:
1 - Load the advanced cataloging editor
2 - Refresh the page several times
3 - Check the JS console, you shoudl see an error:
'undef is not defined'
4 - Apply patch
5 - Try again, should be no error

Signed-off-by: Pierre-Luc Lapointe 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 367f47c416fa9164ccb8d9e5f50772e5a516d6b7)
Signed-off-by: Martin Renvoize 
(cherry picked from commit f60c611972fe0442ee66f6ebf3a40f00bd11efcc)
Signed-off-by: Fridolin Somers 

commit 7a75e0b963c6fa7e087d5cd41dc9a777c1ebfa31
Author: Jonathan Druart 
Date:   Wed Jul 11 18:55:06 2018 -0300

Bug 21053: Encode URI characters in plugin 008

A # (or &) at any position in 008 field of a bib record causes
all subsequent data in field to be overwritten with default values when
record is saved.

These characters need to be correctly encoded before being passed as
param

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-32-ga981f63

2018-09-21 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  a981f630dd1c1a4e9a0ef80291556f89fdb1b1a0 (commit)
   via  b7ca04b769939fce9ace24c456963f456f0fcbae (commit)
   via  4a0708dd3703d2b605b52438adaac72180e830be (commit)
   via  fe4d3d500622e81d5c7ad384b898b4c677bd096c (commit)
   via  3908248f58f105c15eba34b4018d00ccfe78b6aa (commit)
   via  ac56eda00a0dee49d90c0fb7f41d48d96f126b78 (commit)
   via  06a44d405dc939a051cda83a4a0106261af82ef7 (commit)
   via  80a38c96ea11643172b71d816317a2b9c762971c (commit)
   via  08213ef3e3f564d1fe5bedbb08c528c6dd6c21c7 (commit)
   via  60355e225330a902a979883cba9e989ce74f2259 (commit)
   via  6842bc0c47f27150b3cba7f27942d6d061c38935 (commit)
   via  bc0cfb7d58bac2f954767e798fd3ee0432328806 (commit)
   via  6af5e209a0af68883af1dfe7d36365097d1466d8 (commit)
   via  45cca9d1f2b137b5c597bacaf8ef19eb8b1ad5c0 (commit)
   via  0df11d446c284a26ef09b5719794bc0bbf542c16 (commit)
   via  d38fbd4c87a6f9c654f4ecebaa52ae41fedb706a (commit)
   via  34f65071857cbb7027b7b1bbfc7769ca64cf7a07 (commit)
  from  c110912af3f4ff5f41eea4668d38863a951d82c0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit a981f630dd1c1a4e9a0ef80291556f89fdb1b1a0
Author: Jonathan Druart 
Date:   Tue Jul 31 12:14:54 2018 -0300

Bug 21056: Add another flush later

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 5abcd3312adc02a14465a0781f735b8494d60f42)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 88a2c8886c4cf37e6dff00cffd26674d6ac548e2)
Signed-off-by: Fridolin Somers 

commit b7ca04b769939fce9ace24c456963f456f0fcbae
Author: Kyle M Hall 
Date:   Mon Jul 9 14:05:29 2018 -0400

Bug 21056: Changing the logged in library can fail sporadically

We are getting reports that sometimes changing the logged in library via 
selectbranchprinter.pl sometimes appears to fail. Flushing the session after 
updating the branch appears to fix this.

Test Plan:
1) Change your logged in library repeatedly. Hopefully ( sort of ) it will 
fail to change.
   You may want to try various browsers.
2) Apply this patch
3) Note the change no longer fails

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 76a06a7050643add32f4cbccbdc2fb00f66f5485)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 0a5dabc27174d5b77783f81c59248f5da8b37c79)
Signed-off-by: Fridolin Somers 

commit 4a0708dd3703d2b605b52438adaac72180e830be
Author: Owen Leonard 
Date:   Thu Aug 2 13:46:31 2018 +

Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing 
required fields

This patch adds some CSS to target mandatory fields on the add item
screen which are styled by the Select2 plugin.

To test you must have at least one item field marked mandatory and
linked to an authorized value.

Open the add item form for an existing record. Try to submit the form
without making a selection in the mandatory dropdown. You should get an
alert warning you that you have empty mandatory fields, and the field
should be highlighted in yellow.

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 62aacb5865719e27224bf8f1963de1888d2ca05d)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 9bb74effa31053c685902df48714a61c18d3c6d9)
Signed-off-by: Fridolin Somers 

commit fe4d3d500622e81d5c7ad384b898b4c677bd096c
Author: Nick Clemens 
Date:   Fri Jul 13 15:13:31 2018 +

Bug 21075: Unit tests

prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t

Signed-off-by: Pierre-Luc Lapointe 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6e5865ee4feaca3ca5575ce45d11fc88d88dc43d)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 77f2da8fb26e68fa87d2858fc1dfc9f223e24821)
Signed-off-by: Fridolin Somers 

commit 3908248f58f105c15eba34b4018d00ccfe78b6aa
Author: Nick Clemens 
Date:   Fri Jul 13 14:45:55 2018 +

Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today

To recreate:
 1 - Place a hold in your system
 2 - Set that hold (or all holds) to expire today
update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00");
 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p
 4 - Note the hold is sitll suspended
 5 - Visit /cgi-bin/

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-43-g2aeacaa

2018-09-21 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  2aeacaa96ee71cbd77fdfd372206ead7bce0c589 (commit)
   via  70284a33e41c1b9c86b5454e49c44e276c2d2e7d (commit)
   via  f45a8fa715db375b2c0e547bfda79c3e751caa92 (commit)
   via  055127e9e8d5beecefa9025aaa8a4d37d1fddf86 (commit)
   via  a28cc6108b2a83a8d1dbdaf4f5ee2a4fbddfe931 (commit)
   via  5c34ec56648ea66c4047a078405bf04695d0945a (commit)
   via  784b7d7af2be71e7feae2cea5b754ab4f3abf646 (commit)
   via  3f24a07a7ee83859aed10a0d874438a6c6fad2a2 (commit)
   via  fc0841f55432464c6e73eb485b2babd0f7598133 (commit)
   via  68828e1a5351a2f2f9cbf8e9d98544b2647af447 (commit)
   via  0afb31f6190edfa55c55acfb38cd89a17acc1ee7 (commit)
  from  a981f630dd1c1a4e9a0ef80291556f89fdb1b1a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2aeacaa96ee71cbd77fdfd372206ead7bce0c589
Author: Jonathan Druart 
Date:   Wed Aug 15 12:21:38 2018 -0300

Bug 21230: Prevent Reserves.t to fail randomly

The following test can fail if the hold has been generated with found => 
'W':
 #   Failed test 'No tests run for subtest "_koha_notify_reserve() tests"'
 #   at t/db_dependent/Reserves.t line 675.
Can't call method "to_address" on an undefined value at
t/db_dependent/Reserves.t line 661.
 # Looks like your test exited with 255 just after 56.

We should call AddReserve instead.

Test plan:
0. Do not apply this patch
1. Do the following change:
my $hold = $builder->build({
source => 'Reserve',
value => {
   borrowernumber=>$hold_borrower,
   found => 'W', # This line is added, do not forget the comma 
above
}
});
2. Prove it makes the test fail
3. stash the changes and apply this patch
4. Make sure the tests pass

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit c957b52ef8bba734043157445470bedc36feae5e)
Signed-off-by: Martin Renvoize 
(cherry picked from commit c359d56f25a0b346b71a3fd8700b07e4713640d7)
Signed-off-by: Fridolin Somers 

commit 70284a33e41c1b9c86b5454e49c44e276c2d2e7d
Author: Jonathan Druart 
Date:   Wed Aug 1 11:22:14 2018 -0300

Bug 20795: Inform the user about this change, add to pod

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit e97f6ab9be6108cbe4d61ea8dd4b876527bd67ba)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 40bfb7913da164f03ff44956218a8e314f87aeba)
Signed-off-by: Fridolin Somers 

commit f45a8fa715db375b2c0e547bfda79c3e751caa92
Author: Nick Clemens 
Date:   Sun May 20 14:44:45 2018 +

Bug 20795: Pass incrreased verbosity to zebra rebuild script

To test:
1 - Run koha-rebuild-zebra with multiple '-v'
2 - Note no increased verbosity
3 - Apply patch
4 - Run the updated koha-rebuild-zebra script with multiple '-v'
5 - Note increased verbosity

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 1dfb177d3fff713185bcb0aa86517ef40629fedc)
Signed-off-by: Martin Renvoize 
(cherry picked from commit dbdd2b56303be0fab287d861dbd9007bf554f9d8)
Signed-off-by: Fridolin Somers 

commit 055127e9e8d5beecefa9025aaa8a4d37d1fddf86
Author: Owen Leonard 
Date:   Mon Aug 6 18:15:10 2018 +

Bug 21164: Fix alignment on new basket form in acquisitions

This patch removes some unnecessary " "'s from the template for
creating a new basket in acquisitions. This fixes the alignment on the
form fields.

To test, apply the patch and go to Acquisitions -> Vendor -> New basket.
All the form fields should be correctly left-aligned with each other.

Signed-off-by: Pierre-Luc Lapointe 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 2280877fdd9685aecff0b144319ca3bffc39b78a)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 5fe28bf39877440025e2a7ee1b2db1054be47852)
Signed-off-by: Fridolin Somers 

commit a28cc6108b2a83a8d1dbdaf4f5ee2a4fbddfe931
Author: Owen Leonard 
Date:   Wed Aug 8 16:45:28 2018 +

Bug 21185: Incorrect title tag on tags review page

This patch corrects the title tag on the tags review page.

To test, apply the patch and go to Tools -> Tags. The page title
(probably shown in the browser tab) should start with "Koha ->"

[koha-commits] main Koha release repository branch master updated. v18.05.00-778-g8fa1bd7

2018-09-21 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  8fa1bd72debea6e23020a93d5c30dd99d7ed1822 (commit)
   via  d5063603f213d843d1848b44b6479ad5c1f2c63b (commit)
  from  87dc160555ed106fb09e15d5a0eaf1e7313ff77d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 8fa1bd72debea6e23020a93d5c30dd99d7ed1822
Author: Marcel de Rooy 
Date:   Fri Sep 21 08:00:20 2018 +0200

Bug 20819: (Follow-up) Show more clearly that a user gave no consent

See comment60 on Bugzilla.
Although I intentionally did not want to show date and time of refusal,
we can obviously add one line saying that we already have a no.

Test plan:
Login without consent and see no additional line.
Agree and verify that you see the registered on xxx line.
Disagree and verify that you now see "You indicated recently...".

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

commit d5063603f213d843d1848b44b6479ad5c1f2c63b
Author: Nick Clemens 
Date:   Fri Sep 21 11:39:30 2018 +

Bug 20743: Remove duplicated line 'See your public page'

Signed-off-by: Nick Clemens 

---

Summary of changes:
 .../intranet-tmpl/prog/en/modules/admin/usage_statistics.tt   |9 -
 .../opac-tmpl/bootstrap/en/modules/opac-patron-consent.tt |2 ++
 2 files changed, 2 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-60-gac7fa5b

2018-09-21 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  ac7fa5b07a8ee552840ccf76dd868e33c1eb0378 (commit)
   via  c710786c775e24b887e8365d7b5badad8ab376e8 (commit)
   via  6d7fc073d883275e25efe5a5f0c531b766aceeb9 (commit)
   via  56833de0380c04ed72b8f692535660361fee0cbd (commit)
   via  d13124a2e28f505a8e894ec92f0826296dbadb23 (commit)
   via  a3c88ab41e78023831b54a18d1b82d48c3c53ef4 (commit)
   via  34e1d76152a085378c9a98ffd849abebd586da76 (commit)
   via  f0db075dde813eae5b46df6f39decd7fc896d4a4 (commit)
   via  2a7f362d2030c242559146bf2f4d583031f81d0d (commit)
   via  a4573184230ce89257b17533fafae05bfbd490d9 (commit)
   via  85b488a9ead98970f0a4e7bbe6ea3668e18365d0 (commit)
   via  3c78199927465ab98c8e51b64b6f50ae8377c4a9 (commit)
   via  2fdf6e23223a712689170aa1eab2d96e9b8198ce (commit)
   via  463e7de027716aaf909e49a930a9e962fe458014 (commit)
   via  9fee5ac6fde75ad9ed0252e0b870d6800756f66e (commit)
   via  859eb738f4a1b86243a265e11ec2029eabfe623e (commit)
   via  659d4cc0d41f9e9d87c591d96b66c3a369720e38 (commit)
  from  2aeacaa96ee71cbd77fdfd372206ead7bce0c589 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ac7fa5b07a8ee552840ccf76dd868e33c1eb0378
Author: Joy Nelson 
Date:   Fri Jun 22 13:48:25 2018 -0700

Bug 20984: Add 300$f to display

Adding Type of Unit (300$f) to the Opac details and staff side searches 
results and details display

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit a122a5333445299da8a01e47a65b25f733e6ce7c)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 516d156bb2aec724e429414f7053e3a2f8fffda1)
Signed-off-by: Fridolin Somers 

commit c710786c775e24b887e8365d7b5badad8ab376e8
Author: Joy Nelson 
Date:   Fri Jun 22 11:56:11 2018 -0700

Bug 17625: adding subfields f and g to XSLT display

Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff 
side

Signed-off-by: Joy Nelson 

Signed-off-by: Cab Vinton 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit fe9c6450979b5b7fd05821dd22c523ea6d10d3cd)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 7a53a3defe45099f02c0bbb4d077e01303feca38)
Signed-off-by: Fridolin Somers 

commit 6d7fc073d883275e25efe5a5f0c531b766aceeb9
Author: Jonathan Druart 
Date:   Tue Aug 7 11:14:54 2018 -0300

Bug 21150: add the biblionumber to the output

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 76141a352ed5ff8c9541c0d4b1c99e22e5339add)
Signed-off-by: Martin Renvoize 
(cherry picked from commit bacb859d1c637b7d9d32b2205c97cc00557e9888)
Signed-off-by: Fridolin Somers 

commit 56833de0380c04ed72b8f692535660361fee0cbd
Author: Jonathan Druart 
Date:   Fri Aug 3 14:59:33 2018 -0300

Bug 21150: Search for item types inconsistencies

search_for_data_inconsistencies.pl will now display errors if:
1.item-level_itypes is set to "specific item" and items.itype is not set
or not set to an item type defined in the system (itemtypes.itemtype)
2.item-level_itypes is set to "biblio record" and biblioitems.itemtype is 
not set
or not set to an item type defined in the system (itemtypes.itemtype)

Test plan:
Use the script and the different possible combinations to display the
errors

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6fd1a8c11484e8c1cd771aea0c6ac98a2ab18f40)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 41b06b411c3ad2a5006980507c344c568357c752)
Signed-off-by: Fridolin Somers 

commit d13124a2e28f505a8e894ec92f0826296dbadb23
Author: Katrin Fischer 
Date:   Tue Jul 31 16:23:43 2018 +

Bug 20509: Add to script documentation

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 9b73cc22890aadae0fa6afd9d82d5109cc47fd80)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 7ba665179bb35a3ddf940f506e5dfed06f11b346)
Signed-off-by: Fridolin Somers 

commit a3c88ab41e78023831b54a18d1b82d48c3c53ef4
Author: Jonathan Druart 
Date:   Wed Jun 27 15:35:57 2018 -0300

Bug 20509: Search for not defined authority codes

This patch adds a new check in
misc/maintenance/search_for_data_inconsistencies.pl to search for n

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-77-gd56da69

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  d56da699f625a40421ab0be8f11f02a2bb47c22b (commit)
   via  29891abbf82692f7f13952537ce601f6e6f4ef15 (commit)
   via  69e6348e373a1f54dd6af6e75d306a01d040ab49 (commit)
   via  f31598ff9943cd9a2715e9fc9e14cac4b6ff1121 (commit)
   via  9ab177907cb0b568118770b5e9f7e5ffb0ffe54b (commit)
   via  b610d6c95cec777c72f7c49f6ea281edb5862533 (commit)
   via  72dd35a026c6232b90f9ca1160c5131f8b0b304d (commit)
   via  8b9601ea764839b9f0371ea958da05576ac47f75 (commit)
   via  c8bc46464a045108d1f94ed842e4c5cf647ef228 (commit)
   via  ae819fce4cfc12e2e04f1b449c47466d5b3cefab (commit)
   via  73926ff81d8823f3dace210593feaa995e22d919 (commit)
   via  157bc44132814d9387d76a97b97748e4b29e810c (commit)
   via  f180314f58c57ce0c6c1094fa19da88502085144 (commit)
   via  c0c26af655e5ffb1cb187185fce8c828a119c641 (commit)
   via  b829bde8601b1d5651dc5d4425350a96944ce7a9 (commit)
   via  e28ef43417a0b72887e975ee2f1f92e9a3476bee (commit)
   via  026a7672c7f73f1ae6630e5c10db79a31d0e8190 (commit)
  from  ac7fa5b07a8ee552840ccf76dd868e33c1eb0378 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit d56da699f625a40421ab0be8f11f02a2bb47c22b
Author: Owen Leonard 
Date:   Fri Aug 3 15:13:57 2018 +

Bug 13692: series link is taking you to just 800a instead of whole 800

This patch modifies the OPAC and staff client's XSL template for the
detail page so that series links based on a traced 490 tag use both
author and series title from the 800 tag.

To test you should have multiple titles in the same series with matching
490 and 800 tags in each record. Apply the patch and restart Plack if
necessary.

View the detail page for one of the series' titles. The "Series:" link
should link to a search which uses both series title and author.
Clicking the link should return the correct results.

Test both the OPAC and staff client.

Signed-off-by: John Sterbenz 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit cf5a92461835725fe44bb726c98bcfbf909dfdc8)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 145eef6a9037b93cd8902f0a77582fcadbf517bc)
Signed-off-by: Fridolin Somers 

commit 29891abbf82692f7f13952537ce601f6e6f4ef15
Author: Nick Clemens 
Date:   Thu Aug 23 14:44:31 2018 +

Bug 21262: Do not format numbers for editing if too big

This patch copies the code from bug 15770 to the format_for_editing
sub.

It also corrects schema issue, listing the purpose for two acq columns
instead of claing unused

To test:
1 - Edit a fund
2 - Set warning at amount to: 100
3 - Save budget
4 - Try to edit - internal server error
5 - Apply patch
6 - Should be able to edit budget
7 - Number should appear unformatted

Signed-off-by: Christopher Brannon 

Signed-off-by: Jonathan Druart 
2 quick notes:
1. Code must be moved to a subroutine if reused later
2. It would have prefered to have the comment of the 2 DB columns on a 
separate patch
(even separate bug report). As it's minor and that the patch will certainly 
backported
I will not block it.

Signed-off-by: Nick Clemens 
(cherry picked from commit 7a84297ac4b29f4bdaf1bc4d01def71eb924d4fa)
Signed-off-by: Martin Renvoize 
(cherry picked from commit ad16c9f5b20525303eb631107883cb37e36de8cd)
Signed-off-by: Fridolin Somers 

commit 69e6348e373a1f54dd6af6e75d306a01d040ab49
Author: Jonathan Druart 
Date:   Sun Sep 16 09:49:46 2018 -0700

Bug 21360: Prevent IssueSlip.t to fail when run at 23:59

Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if
launched after 23:00) but we should have tested with 23:59, not 23:50...

koha_1   | # Looks like you planned 3 tests but ran 2.
koha_1   |
koha_1   | #   Failed test 'Issue slip'
koha_1   | #   at t/db_dependent/Members/IssueSlip.t line 294.
koha_1   | Label not found for "last SKIP" at 
/usr/share/perl5/Test/More.pm line 1370.
koha_1   | # Looks like your test exited with 255 just after 1.
koha_1   | [23:59:10] t/db_dependent/Members/IssueSlip.t
koha_1   | Dubious, test returned 255 (wstat 65280, 0xff00)
koha_1   | Failed 3/3 subtests

Test plan:
0/ Don't apply this patch
1/ sudo date -s "2018-09-15 23:59:00";prove 
t/db_dependent/Members/IssueSlip.t
=> You should get the error

[koha-commits] main Koha release repository annotated tag v18.05.04 created. v18.05.04

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The annotated tag, v18.05.04 has been created
at  30906006dabefd89bffc4d1bc2ccefc29f4900f0 (tag)
   tagging  41130848be5098a555d61762d56656dc93f6 (commit)
  replaces  v18.05.03
 tagged by  Martin Renvoize
on  Mon Sep 24 14:16:27 2018 +0100

- Log -
Koha release 18.05.04
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEE8g0J8pGJSlfC6TBmQitGkTBEGg8FAluo46sACgkQQitGkTBE
Gg/GNhAAksXf1afmqlkdlT3AYVfwNPigv1cX/0GDZ8o+zezg24mlZoahni1zt3Mt
zNkDo92IbGRyUUxMtNQobBZNM9eD9u4Xsx5qWoFSHDCyWSMdkmyJLZCMiDwV8T5G
93or7tvKC107LHvk2EZt+w1ZbOON73VYUW+Wsvo5ldu6fxhvgfxwPfT70GjnQbKm
k0HJXRhW52atc7m4y9jJ6rg6ijnilgOaN/dQA1Yb9xmxkdp/DeM4bjfvUNV26qLJ
DDRUvS7i5xO24Os/FeaXTeKmFTylWR4wNa8yMlXYyt73iGWV0wg6Q8lBlpeHCECL
ZwgzHICXBXmQNOqtVgqC8z44Ps6FxGZ1okQDr0Rw1ZZuGdBVZf83y00YNRbXL/0I
0QW5+1/JBZlFwg8Ziu4khBTyJL00e4ziqEPIgDpUYayAbxV2ZfRkadaKufJYCS09
HH99jTkk7eD+CsSvb29aIzTD3Blp8H4jKrs5LD+WIPwSNsAWkruttAuTnB6sNZxt
8POLeh7hK1e9Wm/rxH2G0OCb5Wo74xcfCq2p7974nHaTiKKHSquUk+KeR5E6cVWP
AD/+9upo4I1gOkafLyZn0XS/plvw05lP7KBWJisV9s9irefCJXK3kDRDU6f5noAz
F29i/j8Lw2Lq5VvcWh/LyvEBSI57l2nGsBwm9r4u0T74Vv1CCWs=
=U+6E
-END PGP SIGNATURE-

Caroline Cyr La Rose (1):
  Bug 21356: Add Missing space in parcel.tt

Charlotte Cordwell (2):
  Bug 19991: use Modern::Perl in OPAC perl scripts
  Bug 19179: Email option for SMSSendDriver is not documented

David Cook (1):
  Bug 13779: sessionID declared twice in C4::Auth::checkauth()

Fridolin Somers (1):
  Bug 20765: Fix search for items by acqdate in label batch

Jane Sandberg (2):
  Bug 13406: Add styling classes to authority MARC detail display
  Bug 13406: (follow-up) Add styling classes to authority MARC detail 
display

Jonathan Druart (8):
  Bug 21168: Handle deleted checked-in items on checking in
  Bug 21096: Do not display loggedinusername in template
  Bug 19991: Remove warning from opac-user
  Bug 21139: (follow-up) Floating toolbars - Remove unecessary height
  Bug 21207: Remove unused RM C4::Overdues::GetItems sub
  Bug 21235: Remove table services_throttle
  Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00
  Bug 21360: Prevent IssueSlip.t to fail when run at 23:59

Katrin Fischer (1):
  Bug 20994: Fix capitaization "Save to Lists"

Koha translators (1):
  Translation updates for Koha 18.05.04

Kyle M Hall (2):
  Bug 21231: Add Unit Test
  Bug 21231: BlockReturnofLostItems does not prevent lost items being found

Marcel de Rooy (2):
  Bug 13779: (QA follow-up) Correct checkauth call in 
offline_circ/download.pl
  Bug 19179: (QA follow-up) Replace second E-mail

Martin Renvoize (6):
  Bug 21068: Remove NorwegianPatronDB related code
  Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls
  Bug 21235: (QA follow-up) Remove table services_throttle
  Bug 7143: Update history to reflect recent point releases
  Increment version for 18.05.04 release
  Update release notes for 18.05.04 release

Nick Clemens (7):
  Bug 21235: DBRev 18.05.04.001
  Bug 21288: DBRev 18.05.03.002
  Bug 20777: DBRev 18.05.03.003
  Bug 21262: Do not format numbers for editing if too big
  Bug 13406: (RM follow-up) Add missing filter
  Bug 7143: Update about page for new dev - Jane Sandberg
  Bug 20564: Don't use system to unzip files

Owen Leonard (2):
  Bug 21127: Remove jqTransform jQuery plugin from the OPAC
  Bug 13692: series link is taking you to just 800a instead of whole 800

Pasi Kallinen (2):
  Bug 21248: Fix COinS carp in MARC details page on unknown record
  Bug 21288: Slowness in acquisition caused by GetInvoices

Tomas Cohen Arazi (10):
  Bug 21267: Set X-FORWARDED-PROTO https if required
  Bug 20776: Add Selenium::Remote::Driver to the dependency list
  Bug 21285: Add missing select2x2.png file
  Bug 20777: Remove unused accountlines.dispute field
  Bug 20777: DBIC update
  Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint
  Bug 21116: Unit tests
  Bug 21116: Add API routes through plugins
  Bug 21334: Unit tests
  Bug 21334: Add bibliographic content type definitions

---


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  41130848be5098a555d61762d56656dc93f6 (commit)
   via  f444e82e99f0cb22f91472de427fc8c3df7aed40 (commit)
   via  fb8a522ab4ef88f8008a78b4e5014871f374924f (commit)
  from  2cec62128c8521618c95fbf5e1b542fab395aa32 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 41130848be5098a555d61762d56656dc93f6
Author: Martin Renvoize 
Date:   Mon Sep 24 14:15:17 2018 +0100

Update release notes for 18.05.04 release

Signed-off-by: Martin Renvoize 

commit f444e82e99f0cb22f91472de427fc8c3df7aed40
Author: Martin Renvoize 
Date:   Mon Sep 24 14:08:23 2018 +0100

Increment version for 18.05.04 release

Signed-off-by: Martin Renvoize 

commit fb8a522ab4ef88f8008a78b4e5014871f374924f
Author: Koha translators <>
Date:   Mon Sep 24 09:44:00 2018 -0300

Translation updates for Koha 18.05.04

(cherry picked from commit c507d41d32b8652d51114b3784abd01051304c0d)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha.pm|2 +-
 installer/data/mysql/updatedatabase.pl |7 +
 ...s_18_05_01.html => release_notes_18_05_04.html} |  315 ++--
 misc/release_notes/release_notes_18_05_04.md   |  354 
 misc/translator/po/am-Ethi-marc-MARC21.po  | 1438 
 misc/translator/po/am-Ethi-marc-NORMARC.po |2 +-
 misc/translator/po/am-Ethi-marc-UNIMARC.po |2 +-
 misc/translator/po/am-Ethi-opac-bootstrap.po   |   10 +-
 misc/translator/po/am-Ethi-staff-help.po   |2 +-
 misc/translator/po/am-Ethi-staff-prog.po   |  371 +++--
 misc/translator/po/ar-Arab-marc-MARC21.po  | 1446 -
 misc/translator/po/ar-Arab-marc-NORMARC.po |2 +-
 misc/translator/po/ar-Arab-marc-UNIMARC.po |2 +-
 misc/translator/po/ar-Arab-opac-bootstrap.po   |   19 +-
 misc/translator/po/ar-Arab-staff-help.po   |2 +-
 misc/translator/po/ar-Arab-staff-prog.po   |  386 ++---
 misc/translator/po/as-IN-marc-MARC21.po| 1438 
 misc/translator/po/as-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/as-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/as-IN-opac-bootstrap.po |   10 +-
 misc/translator/po/as-IN-staff-help.po |2 +-
 misc/translator/po/as-IN-staff-prog.po |  371 +++--
 misc/translator/po/az-AZ-marc-MARC21.po| 1438 
 misc/translator/po/az-AZ-marc-NORMARC.po   |2 +-
 misc/translator/po/az-AZ-marc-UNIMARC.po   |2 +-
 misc/translator/po/az-AZ-opac-bootstrap.po |   12 +-
 misc/translator/po/az-AZ-staff-help.po |2 +-
 misc/translator/po/az-AZ-staff-prog.po |  371 +++--
 misc/translator/po/be-BY-marc-MARC21.po| 1438 
 misc/translator/po/be-BY-marc-NORMARC.po   |2 +-
 misc/translator/po/be-BY-marc-UNIMARC.po   |2 +-
 misc/translator/po/be-BY-opac-bootstrap.po |   12 +-
 misc/translator/po/be-BY-staff-help.po |2 +-
 misc/translator/po/be-BY-staff-prog.po |  371 +++--
 misc/translator/po/bg-Cyrl-marc-MARC21.po  | 1438 
 misc/translator/po/bg-Cyrl-marc-NORMARC.po |2 +-
 misc/translator/po/bg-Cyrl-marc-UNIMARC.po |2 +-
 misc/translator/po/bg-Cyrl-opac-bootstrap.po   |   12 +-
 misc/translator/po/bg-Cyrl-staff-help.po   |2 +-
 misc/translator/po/bg-Cyrl-staff-prog.po   |  371 +++--
 misc/translator/po/bn-IN-marc-MARC21.po| 1459 -
 misc/translator/po/bn-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/bn-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/bn-IN-opac-bootstrap.po |   12 +-
 misc/translator/po/bn-IN-staff-help.po |2 +-
 misc/translator/po/bn-IN-staff-prog.po |  371 +++--
 misc/translator/po/ca-ES-marc-MARC21.po| 1438 
 misc/translator/po/ca-ES-marc-NORMARC.po   |2 +-
 misc/translator/po/ca-ES-marc-UNIMARC.po   |2 +-
 misc/translator/po/ca-ES-opac-bootstrap.po |   12 +-
 misc/translator/po/ca-ES-staff-help.po |2 +-
 misc/translator/po/ca-ES-staff-prog.po |  371 +++--
 misc/translator/po/cs-CZ-marc-MARC21.po| 1458 -
 misc/translator/po/cs-CZ-marc-NORMARC.po   |2 +-
 misc/translator/po/cs-CZ-

[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.13-24-g6b96258

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
   via  6b96258b1e04d00296584c628c98e553a08730e2 (commit)
   via  c8a1422d41b71669c2f761174974b6839a797b83 (commit)
   via  90b80e23722508e0c57dd64703b9f61fe3a3257e (commit)
   via  593dcf02e578acb0da9458bd63aba47b2a4f0973 (commit)
   via  4b8f5e5dc6d15549fde7f45f53a9675ee9f0b952 (commit)
   via  d7916f85a8536ff983ec666b6c8cafeeb313a259 (commit)
   via  0403eac5715e7f13f36a0c8724fdbf12db6b46d2 (commit)
   via  54d218d709d7309803caa371f697af434e8650ed (commit)
   via  cbd29edc5ae70d2110bf5c33311850ed667fd1f1 (commit)
   via  09f1806987fc4fef5f4601b042f59986fb66d8de (commit)
   via  992f68ce61229b19acc15c1519ae487676264004 (commit)
   via  c5521e65f78d845083b6e9bcc247aab13d87ed5c (commit)
   via  bf43e2e5d37467807d9b485adbcfbaffa471f196 (commit)
   via  e6c573180680d28d0457efe9b9ce27fd595223de (commit)
   via  b086e37d672d9a7e5d6c2fc51d8507678b1f908c (commit)
   via  e47f9d6b1614cfbacb743fe974ace7eff682c4ba (commit)
   via  d5ebdb75e00180f19d4ef77058e96ea21541bdb3 (commit)
   via  4b7e5108ea3e221998b38a6b7eeab4475f50d4d5 (commit)
   via  b4d9ed346ed193e7a72d48745ad26b55737bfa7d (commit)
   via  967d34815c92308fb74f6ac2965b1be807c17353 (commit)
   via  0c56d4e0f3112557c484954491e990c1d39abbd3 (commit)
   via  b535a0da267c3b1dd4e833a0af3bae48d28879e9 (commit)
   via  549148d74b6368697e216a31c39296016668a8d1 (commit)
   via  8b8b5061b49953e876a145ed22a971858b7842c1 (commit)
  from  a890b4dbf7f6385ff769a68c8179c0fd1fc09e4d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 6b96258b1e04d00296584c628c98e553a08730e2
Author: Martin Renvoize 
Date:   Mon Aug 13 09:54:44 2018 +0100

Bug 21199: (QA follow-up) Add show_attributes to perldoc

Signed-off-by: Martin Renvoize 
(cherry picked from commit d555126d8f8fe8c9a4bdd6563c8fcd82b971fc84)
Signed-off-by: Fridolin Somers 
(cherry picked from commit 7ab3f8ba72e70c67913fee1b53409ba089c7bdd3)
Signed-off-by: Fridolin Somers 

commit c8a1422d41b71669c2f761174974b6839a797b83
Author: Jonathan Druart 
Date:   Thu Aug 9 19:34:58 2018 -0300

Bug 21199: Hide patron's attributes from ILSDI if required

Signed-off-by: Katrin Fischer 
Signed-off-by: Martin Renvoize 
(cherry picked from commit dabd86cf6eab70751cc1a476b47cdf9f1648788f)
Signed-off-by: Fridolin Somers 
(cherry picked from commit 0d588160cf38e0ca5b79955376f18710d0a0ca3e)
Signed-off-by: Fridolin Somers 

commit 90b80e23722508e0c57dd64703b9f61fe3a3257e
Author: Nick Clemens 
Date:   Mon Jul 9 13:24:44 2018 +

Bug 21054: Remove extraneous  tag from sco-main.tt

To test:
1 - Enable sco and setup AutoSelfCheck
2 - Try to use self checkout and print receipt
3 - You shoudl be redirected to the login page
4 - Apply patch and restart all the things
5 - Try to use self checkout and print a receipt
6 - Success!

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 
(cherry picked from commit d9a94cc7e5fbcf924a1368423179c7d05fa49c8b)
Signed-off-by: Fridolin Somers 
(cherry picked from commit fe1f65c6c1dbf0f44234a96735a3fba1bda1009e)
Signed-off-by: Fridolin Somers 

commit 593dcf02e578acb0da9458bd63aba47b2a4f0973
Author: Fridolin Somers 
Date:   Fri Jun 15 12:56:36 2018 +0200

Bug 20951: add missing use Koha::Patron::Debarments in 
Koha::Patron::Discharge

Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in 
discharge() method.

Test plan :
1) Enable pref useDischarge
2) Go to OPAC user page
3) Go to 'ask for a discharge' tab
4) Click on 'Ask for a discharge'
5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
6) Click on Allow
=> Without patch you get software error
=> With patch the discharge is validated

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 
(cherry picked from commit 842abeb423b81c61d2774f8446a5bcbb2d0a258c)
Signed-off-by: Fridolin Somers 
(cherry picked from commit 9ef0e010cca0de135d8a270b2fd70ba155d018b6)
Signed-off-by: Fridolin Somers 

commit 4b8f5e5dc6d15549fde7f45f53a9675ee9f0b952
Author: Josef Moravec 
Date:   Fri Jun 8 09:43:13 2018 +

Bug 20903: Remove unnecessary category code parameters

Test plan:
0) Do no apply the patch
1) Have only one adults patrons category defined
2) Add a fine to child pat

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-78-g021559f

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  021559f25da64ab5e422b638260b306f1b2f3bdf (commit)
  from  d56da699f625a40421ab0be8f11f02a2bb47c22b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 021559f25da64ab5e422b638260b306f1b2f3bdf
Author: Fridolin Somers 
Date:   Mon Sep 24 16:05:35 2018 +0200

Bug 21288: correct DBRev 17.11.09.003

---

Summary of changes:
 Koha.pm|2 +-
 installer/data/mysql/updatedatabase.pl |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository annotated tag v17.11.10 created. v17.11.10

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The annotated tag, v17.11.10 has been created
at  9ee9c47d3ddc05b3246c875dcc1c9f180f9bb12b (tag)
   tagging  3535436e9d066503e45a97adf12ec973f3515150 (commit)
  replaces  v17.11.09
 tagged by  Fridolin Somers
on  Mon Sep 24 16:15:33 2018 +0200

- Log -
Koha release 17.11.10
-BEGIN PGP SIGNATURE-

iQEzBAABCgAdFiEEuXlk3O256QfzYP0rK8k2QoBkBm4FAluo8YUACgkQK8k2QoBk
Bm6MIAf/Two1mG+aBjM4/935Oc+2F3IUNNKtabzdMKcj3dyAtzOM528MnEnsdiub
ghvQ4rXZKkR/miI7HwoMQfGwrFmdd0VB4UQzu1RdgJ12P2em/zXzDuAy6T1WoiO7
ZR0Bp7iKlIBJtNDQzhDahyoKcfx+msfvMTTi2zMHLLCHQDA1wnVO8qTmjUF5o1jj
AWMxr4eB8a5aOr2CpyfZeJwQkfZkCtwmkRbyN3KQUungwORpKxcz+xXAqKprUrTQ
oHgeE/BqFKMf5CBvzKt5wN54uJlQNxBiCKi0PhCou3F70gRgma88G0SdV4UTAHNo
+XelV/Ymg0bpi4FJoHKAbZQwkl6DUQ==
=1wAA
-END PGP SIGNATURE-

Andrew Isherwood (1):
  Bug 20770: ILL loans OPAC form notes field allow arbitrary input

Charlotte Cordwell (1):
  Bug 19179: Email option for SMSSendDriver is not documented

David Cook (4):
  Bug 21097: Missing optgroup closing tag in orderreceive.tt
  Bug 21031: Apache Rewrite rules don't work for API when using anything 
but Debian package Plack configuration
  Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected 
behaviour
  Bug 13779: sessionID declared twice in C4::Auth::checkauth()

Fridolin Somers (5):
  Bug 20765: Fix search for items by acqdate in label batch
  Bug 21288: correct DBRev 17.11.09.003
  Merge remote-tracking branch 'translate/17.11.10-translate-20180924' into 
17.11.x
  Increment version for 17.11.10 release
  Update release notes for 17.11.10 release

Jonathan Druart (24):
  Bug 21226: DB Changes
  Bug 21226: Remove xISBN services
  Bug 21053: Encode URI characters in plugin 008
  Bug 21134: Correctly throw the exception in 
Koha::Patron::Modification->approve
  Bug 21048: Fix display of suggestion's status (SUGGEST_STATUS)
  Bug 21099: Reposition floating toolbars earlier
  Bug 21139: Floating toolbar - Remove dup id
  Bug 21139: Floating toolbars - Remove unecessary height
  Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize
  Bug 21139: Floating toolbar - Resize toolbar on window resize
  Bug 21139: No table in toolbar
  Bug 21139: (follow-up) Floating toolbars - Remove unecessary height
  Bug 21056: Add another flush later
  Bug 21035: Handle new lines when running reports
  Bug 20795: Inform the user about this change, add to pod
  Bug 21230: Prevent Reserves.t to fail randomly
  Bug 21238: Prevent TemplateToolkit.t to fail on slow servers
  Bug 21142: Open uploaded files in utf-8 - batch mod/del
  Bug 21011: Search for items with not defined homebranch and/or 
holdingbranch
  Bug 20509: Search for not defined authority codes
  Bug 21150: Search for item types inconsistencies
  Bug 21150: add the biblionumber to the output
  Bug 21168: Handle deleted checked-in items on checking in
  Bug 21360: Prevent IssueSlip.t to fail when run at 23:59

Josef Moravec (1):
  Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change 
mode to executable

Joy Nelson (2):
  Bug 17625: adding subfields f and g to XSLT display
  Bug 20984: Add 300$f to display

Katrin Fischer (7):
  Bug 21077: Fix database documentation for statistics.type
  Bug 19390: Make jQuery selector more specific, so OPAC view link can open 
in new tab
  Bug 21144: Add ROADTYPE to default authorised values categories
  Bug 7996: (QA follow-up) Remove unnecessary permission check view logs 
template
  Bug 20504: Fix lang attribute in html tag on systempreferences page
  Bug 20631: Remove unused RemoveLostItem from C4::Accounts
  Bug 20509: Add to script documentation

Koha translators (1):
  Translation updates for Koha 17.11.10

Kyle M Hall (3):
  Bug 21056: Changing the logged in library can fail sporadically
  Bug 21231: Add Unit Test
  Bug 21231: BlockReturnofLostItems does not prevent lost items being found

Marcel de Rooy (4):
  Bug 21048: (QA follow-up) Fix authorized value statuses in filter
  Bug 21033: Remove few warns in acqui/basket.pl
  Bug 13779: (QA follow-up) Correct checkauth call in 
offline_circ/download.pl
  Bug 19179: (QA follow-up) Replace second E-mail

Mirko Tietgen (2):
  Bug 20437: Update debian/control
  Bug 20800: Keep Koha on Stretch from using broken libhttp-oai-perl

Nick Clemens (12):
  Bug 21226: DBRev 17.11.09.001
  Bug 20564: Don't use system to unzip files
  Bug 21076: Don't call autocomplete code after patron found
  Bug 21064: Use undefined instead of undef
  Bug 21075: AutoUnsuspendHolds

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-82-g3535436

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  3535436e9d066503e45a97adf12ec973f3515150 (commit)
   via  fd268bb3524c1ee2d72587fe8e48cc25c84bcb48 (commit)
   via  5f4481fead5cc520d0c4bddd5dff5cb86d54d1e7 (commit)
   via  e9c03067bd774adfea97d35f03cb87c40ea050fb (commit)
  from  021559f25da64ab5e422b638260b306f1b2f3bdf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3535436e9d066503e45a97adf12ec973f3515150
Author: Fridolin Somers 
Date:   Mon Sep 24 16:15:04 2018 +0200

Update release notes for 17.11.10 release

Signed-off-by: Fridolin Somers 

commit fd268bb3524c1ee2d72587fe8e48cc25c84bcb48
Author: Fridolin Somers 
Date:   Mon Sep 24 16:10:00 2018 +0200

Increment version for 17.11.10 release

Signed-off-by: Fridolin Somers 

commit 5f4481fead5cc520d0c4bddd5dff5cb86d54d1e7
Merge: 021559f e9c0306
Author: Fridolin Somers 
Date:   Mon Sep 24 16:08:49 2018 +0200

Merge remote-tracking branch 'translate/17.11.10-translate-20180924' into 
17.11.x

commit e9c03067bd774adfea97d35f03cb87c40ea050fb
Author: Koha translators <>
Date:   Mon Sep 24 11:02:25 2018 -0300

Translation updates for Koha 17.11.10

---

Summary of changes:
 Koha.pm|2 +-
 installer/data/mysql/updatedatabase.pl |6 +
 misc/release_notes/release_notes_17_11_10.md   |  392 +++
 misc/translator/po/am-Ethi-marc-MARC21.po  |2 +-
 misc/translator/po/am-Ethi-marc-NORMARC.po |2 +-
 misc/translator/po/am-Ethi-marc-UNIMARC.po |2 +-
 misc/translator/po/am-Ethi-opac-bootstrap.po   |2 +-
 misc/translator/po/am-Ethi-pref.po |   32 --
 misc/translator/po/am-Ethi-staff-help.po   |2 +-
 misc/translator/po/am-Ethi-staff-prog.po   |2 +-
 misc/translator/po/ar-Arab-marc-MARC21.po  |2 +-
 misc/translator/po/ar-Arab-marc-NORMARC.po |2 +-
 misc/translator/po/ar-Arab-marc-UNIMARC.po |2 +-
 misc/translator/po/ar-Arab-opac-bootstrap.po   |2 +-
 misc/translator/po/ar-Arab-pref.po |   32 --
 misc/translator/po/ar-Arab-staff-help.po   |2 +-
 misc/translator/po/ar-Arab-staff-prog.po   |2 +-
 misc/translator/po/as-IN-marc-MARC21.po|2 +-
 misc/translator/po/as-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/as-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/as-IN-opac-bootstrap.po |2 +-
 misc/translator/po/as-IN-pref.po   |   32 --
 misc/translator/po/as-IN-staff-help.po |2 +-
 misc/translator/po/as-IN-staff-prog.po |2 +-
 misc/translator/po/az-AZ-marc-MARC21.po|2 +-
 misc/translator/po/az-AZ-marc-NORMARC.po   |2 +-
 misc/translator/po/az-AZ-marc-UNIMARC.po   |2 +-
 misc/translator/po/az-AZ-opac-bootstrap.po |2 +-
 misc/translator/po/az-AZ-pref.po   |   32 --
 misc/translator/po/az-AZ-staff-help.po |2 +-
 misc/translator/po/az-AZ-staff-prog.po |2 +-
 misc/translator/po/be-BY-marc-MARC21.po|2 +-
 misc/translator/po/be-BY-marc-NORMARC.po   |2 +-
 misc/translator/po/be-BY-marc-UNIMARC.po   |2 +-
 misc/translator/po/be-BY-opac-bootstrap.po |2 +-
 misc/translator/po/be-BY-pref.po   |   32 --
 misc/translator/po/be-BY-staff-help.po |2 +-
 misc/translator/po/be-BY-staff-prog.po |2 +-
 misc/translator/po/bg-Cyrl-marc-MARC21.po  |2 +-
 misc/translator/po/bg-Cyrl-marc-NORMARC.po |2 +-
 misc/translator/po/bg-Cyrl-marc-UNIMARC.po |2 +-
 misc/translator/po/bg-Cyrl-opac-bootstrap.po   |2 +-
 misc/translator/po/bg-Cyrl-pref.po |   32 --
 misc/translator/po/bg-Cyrl-staff-help.po   |2 +-
 misc/translator/po/bg-Cyrl-staff-prog.po   |2 +-
 misc/translator/po/bn-IN-marc-MARC21.po|2 +-
 misc/translator/po/bn-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/bn-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/bn-IN-opac-bootstrap.po |2 +-
 misc/translator/po/bn-IN-pref.po   |   32 --
 misc/translator/po/bn-IN-staff-help.po |2 +-
 misc/translator/po/bn-IN-staff-prog.po |2 +-
 misc/translator/po/ca-ES-marc-MARC21.po|2 +-
 misc/translator/po/ca-ES-marc-NORMARC.po   |   

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-1-ge69ce2d

2018-09-24 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  e69ce2d8a6b5e469ff809dfa8a616e615d096205 (commit)
  from  3535436e9d066503e45a97adf12ec973f3515150 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit e69ce2d8a6b5e469ff809dfa8a616e615d096205
Author: Nick Clemens 
Date:   Thu May 18 21:07:11 2017 -0400

Bug 18635: Unit tests

I also adjust a few tests that assume value of $nb_of_patrons to not
rely on existing datas

To test:
1 - Apply this patch only
2 - Prove t/db_dependent/Koha/Patrons.t
3 - Tests fail
4 - Apply other patch
5 - Tests pass

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit ac0f3b880a4220317ddde107c508c32f75b09aa1)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 2e2d4b26a43e54d7e97a4da03cc294486d7c7922)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 t/db_dependent/Koha/Patrons.t |   52 +++--
 1 file changed, 50 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-4-gff32389

2018-09-25 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ff3238992788344902835742c7ffd02899409e79 (commit)
   via  be132fe428ef0c1dae6e35cb6fd50421f35650e3 (commit)
   via  3199778b5cdfe0d35e5116a9c77ebc105a82b919 (commit)
   via  fd13428bc5fac28bce07590881a491d697452037 (commit)
  from  41130848be5098a555d61762d56656dc93f6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ff3238992788344902835742c7ffd02899409e79
Author: Nick Clemens 
Date:   Thu Sep 20 13:35:29 2018 +

Bug 20656: (RM follow-up) Add missing filter

Signed-off-by: Nick Clemens 
(cherry picked from commit 87dc160555ed106fb09e15d5a0eaf1e7313ff77d)
Signed-off-by: Martin Renvoize 

commit be132fe428ef0c1dae6e35cb6fd50421f35650e3
Author: Nick Clemens 
Date:   Sun Sep 16 03:50:13 2018 +

Bug 20656: (follow-up) Don't display title for F or FU fines (it is in 
description)

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit cdfc1c08c96a06d5fe709777374aded10ff4a7ed)
Signed-off-by: Martin Renvoize 

commit 3199778b5cdfe0d35e5116a9c77ebc105a82b919
Author: Nick Clemens 
Date:   Tue Apr 24 20:58:50 2018 +

Bug 20656: Better formatting for print summary

This patch is a slightly edited c&p from boraccount.tt

1 - Manually add a credit with no notes to patron
2 - Print summary
3 - Inspect the line
4 - Note that td has extra newlines and no words
5 - Apply patch
6 - Print summary again
7 - Note better formatting

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 4df6a3ef796c6e8dd002c0cc1cd4d4b2d501be34)
Signed-off-by: Martin Renvoize 

commit fd13428bc5fac28bce07590881a491d697452037
Author: Nick Clemens 
Date:   Tue Apr 24 20:57:17 2018 +

Bug 20656: Don't print lines that have no balance on print summary

To test:
1 - Add at least two fines to a patron
2 - Pay off one of them
3 - Print summary - all 3 lines show
4 - Apply patch
5 - Print summary - only line with balance shows

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 0fd329724b58c34d850a5b5f162ad0c0f2428eb4)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 .../prog/en/modules/members/moremember-print.tt|   63 ++--
 members/summary-print.pl   |2 +-
 2 files changed, 45 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-803-gde434c2

2018-09-26 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  de434c2398aa0629e6a9119cebb353ba517a20b9 (commit)
   via  4bbbd083cf4cc73442bc8911d7e7e240e01cc039 (commit)
   via  616ed6013f590024a795847eab6cc317d37050ec (commit)
   via  393b2582349b48f67e5693629bb197aa73df31a1 (commit)
   via  172f2e0e05759baa6c60d86acd9981fef499a162 (commit)
   via  90ff0f33430bfc643982c883a8f59150dbeffde2 (commit)
   via  3ef81d996909d8bd1cd290b6a9c67df8e2c8e2ef (commit)
   via  647422883d56d7512053f4d6cdbecc41a3e80586 (commit)
   via  100385196ecadb34669190caa241ed73ea2a5a1c (commit)
   via  8577d55d4ee867282c37c8b4a5b4e847fc9f17a7 (commit)
   via  9037e661b16006181a2661191f25ac09df862b0a (commit)
   via  270a408949e69b97aff87a208a559c4736e20426 (commit)
   via  b5becc84f5f2e8f82b765b5ebf3f87a84d89cfd8 (commit)
   via  c59ef0452ccbae17de3b839da4fa2c9f7f6b2e6f (commit)
   via  eec74a2cd1847a859b4fab37c42882ba192ee560 (commit)
   via  cc3bc2920744e35256b45b784c9788a64fe6dd04 (commit)
   via  a62742f4260425af8e69a88822b7affc9cc93c68 (commit)
   via  d415e51180cac0152c2ab0f95e846b196883f42e (commit)
   via  bf908a5f07ffbd492c42483aace120dae8316048 (commit)
   via  d60b0a2e4d3359c127f1e801db9e35dd217f8790 (commit)
   via  c6a26d2c9e767623c7bc0698297bbc165301e7ed (commit)
   via  fb5b377ffd13d9931e9e159b23ce6f886b06d57f (commit)
   via  db683b285cfb31deb9dbdafbc5a18e0b471ffa65 (commit)
   via  78124100ec6708de99bea3e4e181da3897130d0e (commit)
   via  7de47202f2876892524c8b68de962c0776f32881 (commit)
  from  8fa1bd72debea6e23020a93d5c30dd99d7ed1822 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit de434c2398aa0629e6a9119cebb353ba517a20b9
Author: Owen Leonard 
Date:   Fri Apr 6 12:53:35 2018 +

Bug 20534: Floating toolbar when editing vendors

This patch moves the Save and Cancel controls on the vendor edit form
into a toolbar which sticks to the top of the screen as you scroll.

To test, apply the patch and Acquisitions -> New vendor.

- Confirm that as you scroll down the page, the toolbar with the Save
  and Cancel buttons sticks to the top of the screen.
- Test that the Save and Cancel buttons both work correctly.
- Perform the same tests when editing an existing vendor.

Signed-off-by: Maksim Sen 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 4bbbd083cf4cc73442bc8911d7e7e240e01cc039
Author: Owen Leonard 
Date:   Wed Sep 12 17:43:15 2018 +

Bug 21341: Style button on acquisitions existing record search with 
Bootstrap

This patch adds Bootstrap button styles to two links: View MARC and
Order.

Unrelated: A "modal-wide" class has been added to the View MARC modal to
give more room for the MARC view.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From an existing record.

In the record search results, confirm that the View MARC and Order links
are now Bootstrap buttons. Test the View MARC button and confirm that
the modal preview fills most of the screen.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 616ed6013f590024a795847eab6cc317d37050ec
Author: Nick Clemens 
Date:   Sat Sep 15 22:36:40 2018 +

Bug 21333: (follow-up) Make link a button

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 393b2582349b48f67e5693629bb197aa73df31a1
Author: Nick Clemens 
Date:   Tue Sep 11 16:26:04 2018 +

Bug 21333: Add ability to add to basket from a new file

This patch adds a workflow for adding to a basket from a file. It
removes the need to stage the file before going to the basket and allows
you to stage the file and return to the basket

To test:
1 - Have basket in acquissitions
2 - Click add to basket
3 - Note new option to 'Add from new file'
4 - Click it
5 - You will be sent to the record import tool
6 - Stage your file
7 - There is a link after staging 'Add records to basket'
8 - Click it
9 - Your items should be added

Signed-off-by: Sonia 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 172f2e0e05759baa6c60d86acd9981fef499a162
Author: Kyle M Hall 
Date:   Fri Mar 2 11:10:12 2018 -0500

Bug 19620: Allow skipping of patrons with valid emails for Talking Tech

Some libraries want to be able to skip patrons with valid email addresses 

[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.13-27-g8dfaaae

2018-09-27 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
   via  8dfaaae2b9689cb3fd6825a278c3734206efbb1d (commit)
   via  6aac2277005becb26d5c8fc4890c3aef07493e1b (commit)
   via  f925f4551f500adaa08b71f1af76eee12527d595 (commit)
  from  6b96258b1e04d00296584c628c98e553a08730e2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 8dfaaae2b9689cb3fd6825a278c3734206efbb1d
Author: Nick Clemens 
Date:   Thu Aug 16 14:03:28 2018 +

Bug 21226: DBRev 17.11.09.001

Signed-off-by: Fridolin Somers 
(cherry picked from commit a641c83caba3ec75c7299d3b560404f84c56)
Signed-off-by: Fridolin Somers 

commit 6aac2277005becb26d5c8fc4890c3aef07493e1b
Author: Jonathan Druart 
Date:   Wed Aug 15 11:58:12 2018 -0300

Bug 21226: Remove xISBN services

OCLC has decided to retire all xISBN services:
https://www.oclc.org/developer/news/2018/xid-decommission.en.html

The code for related features has to be removed from Koha.

Test plan:
You need to be familiar with the different sysprefs (I am not):
- FRBRizeEditions
- SyndeticsEnabled
- SyndeticsEditions
- ThingISBN

Make sure there are no regressions introduced by this patchset.

QA Note: C4/XISBN.pm should be renammed

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit bce549bc4c0f9fefddb34fe614f6bf79aef882ea)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 7cacd4ddb90d55238e0446a67ce4d68a54c58e3e)
Signed-off-by: Fridolin Somers 
(cherry picked from commit 42a4c281cde74fad9145c438bd7a97b1521f0a6d)
Signed-off-by: Fridolin Somers 

commit f925f4551f500adaa08b71f1af76eee12527d595
Author: Jonathan Druart 
Date:   Wed Aug 15 11:36:21 2018 -0300

Bug 21226: DB Changes

Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit b19090c4505c0f407a7f3cbfe3c14da5cfecc657)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 8111e0c380c9d2c61a2b6b6665b5a7bad3a3e646)
Signed-off-by: Fridolin Somers 
(cherry picked from commit 28ee71e6849e2be21f24626aad6530b55f514419)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 C4/UsageStats.pm |1 -
 C4/XISBN.pm  |   18 ++
 Koha.pm  |2 +-
 installer/data/mysql/sysprefs.sql|3 ---
 installer/data/mysql/updatedatabase.pl   |9 +
 .../modules/admin/preferences/enhanced_content.pref  |   16 
 t/db_dependent/UsageStats.t  |1 -
 t/db_dependent/XISBN.t   |   17 +
 8 files changed, 13 insertions(+), 54 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-7-g75b0e7a

2018-09-27 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  75b0e7a0787d82caa987afc67206fad2b5811e4c (commit)
   via  a54c1b9a1ca86dcab11e4008727221edc42eb69a (commit)
   via  9f306898886efe1c2a29f2b622885ec1dfa4fe9a (commit)
  from  ff3238992788344902835742c7ffd02899409e79 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 75b0e7a0787d82caa987afc67206fad2b5811e4c
Author: Marcel de Rooy 
Date:   Fri Sep 21 09:15:08 2018 +0200

Bug 21281: (QA follow-up) Introduce _add_backtics

Added a (initially trivial) test in Creators/Lib.t too.
Sometimes you start something, but you end somewhere else ;)

The test seems a bit slower now (regex, lookahead, etc). But this should
not hurt label creators in daily use.
Advantages: code is even more solid, consolidated in one place and can be
tested on its own.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit db683b285cfb31deb9dbdafbc5a18e0b471ffa65)
Signed-off-by: Martin Renvoize 

commit a54c1b9a1ca86dcab11e4008727221edc42eb69a
Author: Mark Tompsett 
Date:   Wed Sep 5 18:41:32 2018 +

Bug 21281: Correct t/db_dependent/Creators/Lib.t failures

TEST PLAN
-
1) apply first patch
2) kshell kohadev
3) prove -r -v t/db_dependent/Creators/
   -- failures
4) apply this patch
5) repeat 2,3
   -- no failures
6) run koha qa test tools

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

(cherry picked from commit 78124100ec6708de99bea3e4e181da3897130d0e)

Signed-off-by: Martin Renvoize 

commit 9f306898886efe1c2a29f2b622885ec1dfa4fe9a
Author: Jonathan Druart 
Date:   Wed Aug 29 17:05:50 2018 -0300

Bug 21281: Surround creator_templates.rows with backquotes

'rows' is a reserved word since MariaDB 10.2.4 and MySQL
https://mariadb.com/kb/en/library/mariadb-1024-release-notes/
https://dev.mysql.com/doc/refman/8.0/en/keywords.html

Test plan:
Do not apply this patch and make sure you recreate the reported issue
Apply this patch and confirm that it is now fixed.

QA will take care for the changes in installer and test files

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 7de47202f2876892524c8b68de962c0776f32881)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Creators/Lib.pm  |   24 +++-
 installer/data/mysql/patroncards_upgrade.pl |2 +-
 t/db_dependent/Creators/Lib.t   |   18 ++
 3 files changed, 34 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-21-g61d8377

2018-09-27 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  61d837751b28c0fa042819981250608ff19fe110 (commit)
   via  385356515d75acbebe740969c57630dae2791ac1 (commit)
   via  b3f2a13a4368d9f8bec74a6da920649d56732b71 (commit)
   via  1d9377b11a509b7e273aa71545a4181b04804ab1 (commit)
   via  d0affd28266fb9e7461521c703dd640e19c82b99 (commit)
   via  892492cbda442564a33b1abdf374d43c024de22c (commit)
   via  c5bb4d6529f9dcd2457639c8b7735dfc7001d244 (commit)
   via  0f019c89c18733c0e0220f41012a06c3b39df595 (commit)
   via  43b671ac858e9ae63b3ce8e74e555a41600bc383 (commit)
   via  fe4c609d3224f3f71e4a000e2f7857efbefb71ff (commit)
   via  28a404bc3124cb45863db8872cb0ee7c839fda5d (commit)
   via  ffbd4d22e134ba9c1af511dcb0a56a4473f1a789 (commit)
   via  c088efd6c959d12dd8c1743e3eeb9f12d41a77e2 (commit)
   via  0a027c846f5592f250b60f196d7bccea8d1f156b (commit)
  from  75b0e7a0787d82caa987afc67206fad2b5811e4c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 61d837751b28c0fa042819981250608ff19fe110
Author: Nick Clemens 
Date:   Wed Sep 26 19:00:16 2018 +

Bug 7143: Update about page for new dev - Alberto Martinez

Signed-off-by: Nick Clemens 
(cherry picked from commit 90ff0f33430bfc643982c883a8f59150dbeffde2)
Signed-off-by: Martin Renvoize 

commit 385356515d75acbebe740969c57630dae2791ac1
Author: Alberto 
Date:   Sun Sep 16 15:34:37 2018 -0700

Bug 21350: Added icon to Pending on-site checkouts and moved

When pending on-site checkouts is enabled, it will display checkout items 
that are being used in the library

test plan:
1. Go to Koha administration
2. Search for "onSiteChekouts"
3. Enable "onSitecheckout"
4. Save all Circulation preferences
5. Go back to home page and click "Circulations"
6. Please confirm there is an icon and the link is below Fast cataloging

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 
Amended patch: replace tabs with 4 spaces

Signed-off-by: Nick Clemens 
(cherry picked from commit 3ef81d996909d8bd1cd290b6a9c67df8e2c8e2ef)
Signed-off-by: Martin Renvoize 

commit b3f2a13a4368d9f8bec74a6da920649d56732b71
Author: Kyle M Hall 
Date:   Thu Apr 26 15:07:07 2018 -0400

Bug 20669: Add upgrade method to plugins

It would be nice if plugins had an upgrade method to handle altering tables 
and such when a new version of a plugin is installed. Right now it must be done 
in a completely bespoke manner.

Test Plan:
1) Apply this patch
2) Download the 2 most recent releases of the Kitchen Sink plugin
   https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases
3) Install the earlier release
4) Look at the configuration page, at the bottom it should say the
   plugin has never been upgraded
5) Install the newer release
6) Reload the configuration page, it should now say that the plugin
   was upgraded and give you the date and time of the upgrade

Signed-off-by: Claire Gravely 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 
(cherry picked from commit 100385196ecadb34669190caa241ed73ea2a5a1c)
Signed-off-by: Martin Renvoize 

commit 1d9377b11a509b7e273aa71545a4181b04804ab1
Author: Jonathan Druart 
Date:   Fri Sep 21 18:35:06 2018 -0300

Bug 21397: Mark "Routing list" tab as active when selected

/members/routing-lists.pl?borrowernumber=5 show the different tab of the
menu but "Routing lists" is not displayed as the selected one (active).

"routinglistview" must be set and passed to the template

Test plan:
Enable the RoutingSerials pref
and hit /members/routing-lists.pl?borrowernumber=42

The "Routing lists" tab must be selected/active

Followed test plan and tab now shows as active.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 270a408949e69b97aff87a208a559c4736e20426)
Signed-off-by: Martin Renvoize 

commit d0affd28266fb9e7461521c703dd640e19c82b99
Author: Nick Clemens 
Date:   Wed Sep 26 16:17:06 2018 +

Bug 5458: DBRev 18.05.04.001

Signed-off-by: Nick Clemens 
(cherry picked from commit b5becc84f5f2e8f82b765b5ebf3f87a84d89cfd8)
Signed-off-by: Martin Renvoize 

commit 892492cbda442564a33b1abdf374d43c024de22c
Author: Fridolin Somers 
Date:   Tue Sep 4 10:40:29 2018 +0200

Bug 5458: increase ccode column to varchar 80

Koha allows you to define an authorised va

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-22-g025aa54

2018-09-27 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  025aa54a58c292631b0ff412fd59c3ee35813c18 (commit)
  from  61d837751b28c0fa042819981250608ff19fe110 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 025aa54a58c292631b0ff412fd59c3ee35813c18
Author: Martin Renvoize 
Date:   Thu Sep 27 16:25:42 2018 +0100

Bug 21353: (rmaint followup) - Fix for missing $raw filter

Signed-off-by: Martin Renvoize 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-824-g705571a

2018-09-28 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  705571a2b870fbb652ca210e32ee3e7ca050e75f (commit)
   via  a6a7516652115ccc49099f045ed8c23a9f29eb26 (commit)
   via  c86485f933a0eabdb8af215c5b74c5416d2cb95a (commit)
   via  184c44ee31bf54ad179f9fb9fd501114902a0176 (commit)
   via  ca839922fd4bf3c455454f6dd9182203b1481831 (commit)
   via  6975a6836a21f42675a9394602246891c19d9522 (commit)
   via  8df47bdde678773f028f312b4cd8000a12425281 (commit)
   via  024643f51c4e0ca1803dd5013bb857e98cd924e5 (commit)
   via  1b56e446ed64cad9d4dd42a8cb3f1953f424e0aa (commit)
   via  121b8105bcb00909b1e8081442148c1939c101a6 (commit)
   via  bf89e4e124fb38982fa8b9708af1fb67fd16f982 (commit)
   via  01470fab9eabd3750746b540389de7a6d85fda05 (commit)
   via  33010595113b5ec279f93b1127d20b466e1ea023 (commit)
   via  e5750b27d4272cb7f001647090773197c495b918 (commit)
   via  35863802eab24bd39a75fcba0d16ac59dca6261e (commit)
   via  2074421ba3a32979d797479cf124ae6bfb333d36 (commit)
   via  b70d2bc281d70aad2dce0c6021b60e4075641e49 (commit)
   via  02a0f3185c4aad3c712346e6bcedd0736725f699 (commit)
   via  72e2d729f290201b48e09192f0dc4b7fdd26db6b (commit)
   via  75b5ce2a317dad5307d2490c2d2f16e3e3bc3e29 (commit)
   via  d52c88a233680412fb44dea9f6b5e9c29fe43841 (commit)
  from  de434c2398aa0629e6a9119cebb353ba517a20b9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 705571a2b870fbb652ca210e32ee3e7ca050e75f
Author: Andreas Roussos 
Date:   Thu Sep 27 07:54:27 2018 +0300

Bug 21416: 'gr' option missing from ZEBRA_LANGUAGE options in 
koha-sites.conf

'gr' (as in 'Greek') is missing from the ZEBRA_LANGUAGE options
in debian/templates/koha-sites.conf. This patch fixes that.

Test plan:
1) view koha-sites.conf and notice how 'gr' is missing from the
   ZEBRA_LANGUAGE options
2) apply the patch
3) observe that koha-sites.conf now includes 'gr' as an option

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit a6a7516652115ccc49099f045ed8c23a9f29eb26
Author: Josef Moravec 
Date:   Wed Sep 19 08:07:57 2018 +

Bug 21167: (QA follow-up) Use accounttype.inc for generating account 
description

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit c86485f933a0eabdb8af215c5b74c5416d2cb95a
Author: Josef Moravec 
Date:   Wed Sep 19 07:53:32 2018 +

Bug 21167: (QA follow-up) Fix amount formatting on invoice receipt

Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 184c44ee31bf54ad179f9fb9fd501114902a0176
Author: Katrin Fischer 
Date:   Wed Aug 8 19:26:47 2018 +

Bug 21167: Fix price formatting on printed fee invoice and receipt

The prices were not formatted correctly on the printed receipts
for fines and payments in the patron account.

This patch introduces the use of the Price TT plugin to those
templates.

Also:
- Fixes a few capitalization errors
- Removes spaces in front of :
- Updates accounttype-to-description list to the one used
  in other templats as a lot of values were missing (Credit etc.)

To test:
- Create several fines, use some .00 and some with other values
- Pay some fines
- Create a manual credit
- Use print button for all of those (credit, fee, payment)
- Verify that:
  - prices ending in .00 are displayed without the decimal part
  - instead of Credit only C is shown in the description
- Apply patch
- Print invoices and receipts again
- Verify that:
  - prices are now formatted according to CurrencyFormat system
preference, decimal part always included
  - verify that correct description for Credit is shown

Signed-off-by: Brendan Gallagher 

Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit ca839922fd4bf3c455454f6dd9182203b1481831
Author: Pasi Kallinen 
Date:   Fri Aug 24 11:05:04 2018 +0300

Bug 20785: Advanced Editor does not honor MarcFieldDocURL

The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL.
Make it do so.

Test plan:

1) Enable EnableAdvancedCatalogingEditor
2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD}
3) Go to Cataloging -> Advanced editor
4) Go to any field and press Ctrl-H
5) Marc field documentation on www.loc.gov or ifla.org should open
6) Apply patch
7) Repeat 3 and 4. The Marc f

[koha-commits] main Koha release repository branch master updated. v18.05.00-882-gccc4097

2018-10-01 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  ccc40975e3cda7966b67be297dd16891aa8dc314 (commit)
   via  c80074077dc7d1ff2652cf810160497e05ec426f (commit)
   via  903cf19f9ca5cc9a8effa776efd51321681dc583 (commit)
   via  28a1a90b3dace9207fd26a753ab222ba298bcb99 (commit)
   via  c90fa4182e6fb78c2c09958d9671c2b61943412f (commit)
   via  a33826454bf01d7de1e5b5a57467cef14f96d419 (commit)
   via  441af54fc629e40157d050aa027c601c10e3f67d (commit)
   via  1dcb6f28ee91fe7661b546150279c7388286ff2f (commit)
   via  fc3bc961095280ba60db72b466762339f9d05905 (commit)
   via  34058bb6d0497079e7957933b364e76ad88ba765 (commit)
   via  82ec758f18ba5b2600c065245fb68a3f177dcba8 (commit)
   via  fa8cda129ef5c71042334083ee13aecb56ed7ab6 (commit)
   via  48c0e8952a46a5a3eef6cae138c88b1ae22b0986 (commit)
   via  7ff2b8d5e22e5333f51426c481bbfe83ae1ddc47 (commit)
   via  8cb8223e12d5e311e59813c1ba03835c0b50670e (commit)
   via  eb4be268d8d66ae0b7ca803ecf270a688fc6aea1 (commit)
   via  7825ff69c2acd2a390b18402e2813fdd9d0b4774 (commit)
   via  2f1cba8b31063ea81862abd37aae009072b1fb15 (commit)
   via  311b9dccbc60f05421416f402627b78e5efb5542 (commit)
   via  36a52382227aecca98f8b57314d4374a60a99227 (commit)
   via  f0988e414edfde2d7155eedb532b32d43c32109f (commit)
   via  c9b0570864ae7e1a510f918e931d8de85d8309a3 (commit)
   via  4c7246d6768178b558678e2bdf7c5174508532c6 (commit)
   via  1814ae1769ead4d16e0fe26e871483339f2715cb (commit)
   via  edb627bcf275c037879622ec07d807d2186c98e0 (commit)
   via  8b1bda9ed8507745b4002199d9aae95c2cbb31fb (commit)
   via  a002d12888c1e56910a32f28514a59d9a1d9363d (commit)
   via  448dd50cf59b96e5abbb84f7717ca43f593c05e5 (commit)
   via  d68d8f4f3672256fbd233310d1d4aa5857c28a8c (commit)
   via  d98ee2ad8bafebd877ccb85180f37e0b54d79e4c (commit)
   via  7d56a5fe00c3804d6f0a7709fd6deef1a6bcf9e3 (commit)
   via  3ad96419a760c4519e38d685b906f013e9932fee (commit)
   via  54e2f2b5b282c6e4a5c2f04107b274fa075b862d (commit)
   via  4bf594c9de4e06d79413459f2146a2d1e448fb11 (commit)
   via  cee35f3a7881d6cde4184ac4045e1c221eb03108 (commit)
   via  142230bdde0b67bfdc7c6bd4ec0c2f224c9ebacd (commit)
   via  0aa69ea795a7e19b19e9124ff99a6be19e77e5dc (commit)
   via  9df099dc114d0101ef1091c30662a537e53e9826 (commit)
   via  0862f7776942ebf64615d57f94982586d00c34ee (commit)
   via  4fe0b3501851a6f5a05645ca76ce9d4287667cc5 (commit)
   via  0bd485947f7554657e61f050cd5204ebb40d04c0 (commit)
   via  2c57361533f21218d326832ca0a2134b358d31b7 (commit)
   via  658638a48f20128ebe8cabae92c33af2a50abb16 (commit)
   via  d1d5c48deb58085b4d4b49997675bab35d5ff44b (commit)
   via  d37da4d24fc07c5caf04960238a77c81fb95eabc (commit)
   via  f6e86dc0cab2bcd4e8477f639fd600d27d387180 (commit)
   via  e81756b317da848a6e6346a7c0db8f3b986f7058 (commit)
   via  623f1db90ac8d0361a879813c66a4bccbf0ea23e (commit)
   via  5edd363a1f2e3b1ea34f3f2aa7ace86cbf467df8 (commit)
   via  77871b408c9a8e120f8415cc0b32683ee8f57e7d (commit)
   via  92a2d74c1c134674b9798981208b9ad5863a6b42 (commit)
   via  39f48130416132063dfb7b44bcb8bf2344f1b9ef (commit)
   via  6d75ae942a7f51cd5ea5191b625df20efadea297 (commit)
   via  de40463a7fa2be0fe090ef64b2bfffe928607adc (commit)
   via  f3c2eae74c69fea3dfc0e453a07f2b2461330c49 (commit)
   via  fca5a1cb3dba5d6561eaf5f30dfd4d996a4042cc (commit)
   via  013c116d59b14681bff1c18c9225ea4e31627a28 (commit)
   via  4a5df8c5ae4b95d17ae2d93f3c35012a483cf836 (commit)
  from  705571a2b870fbb652ca210e32ee3e7ca050e75f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ccc40975e3cda7966b67be297dd16891aa8dc314
Author: Nick Clemens 
Date:   Mon Oct 1 16:29:20 2018 +

Bug 17602: DBRev 18.06.00.034

Signed-off-by: Nick Clemens 

commit c80074077dc7d1ff2652cf810160497e05ec426f
Author: Nick Clemens 
Date:   Mon Oct 1 16:10:06 2018 +

Bug 17602: Compiled CSS

Signed-off-by: Nick Clemens 

commit 903cf19f9ca5cc9a8effa776efd51321681dc583
Author: Nick Clemens 
Date:   Mon Oct 1 14:24:27 2018 +

Bug 17602: (RM follow-up) QA tool issues

Signed-off-by: Nick Clemens 

commit 28a1a90b3dace9207fd26a753ab222ba298bcb99
Author: Nick Clemens 
Date:   Fri Sep 21 19:00:28 2018 +

Bug 17602: Move spinner location to include file

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit c90fa4182e6fb78c2c09958d9671c2b61943412f
Author: Nick Clemens 
Date:   Wed Sep 12 21:

[koha-commits] main Koha release repository branch master updated. v18.05.00-897-g051eef7

2018-10-01 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  051eef767ab3723a63e1bfff50864ab441e05f23 (commit)
   via  4859e49539e37f08689df3ba001739711f1332a4 (commit)
   via  c6e44c9c6bb78bfb3edeacf877c5edb114aab558 (commit)
   via  d1bf2238c49bad5471b467aae4a5f680639cee97 (commit)
   via  15670cd590e4a1efc01bb9bd1648162781486f5b (commit)
   via  8b1c37929509ea880eafdd0f0650f301d314b034 (commit)
   via  7858cae1bf5fbdfa07a2d03fee534d1613553146 (commit)
   via  b3dee0daf29c4593aee2781307853845a6cd3735 (commit)
   via  5e6f4f1f4fb346351dcfc6c580888022641d4b6a (commit)
   via  3f20c8c65172c1a32e7d2b20ed2506199423f103 (commit)
   via  17db3ab05cb25d08f0790cff9eed5f0f75ca8107 (commit)
   via  08386cd3f05c5bc4dc6306e3a1d6c4878cce7c86 (commit)
   via  11885e75c04fa53cd88daae1ec0dc4a2a8ecd1f7 (commit)
   via  fca98de0e8663c4e7049e55ac2cc2600c9b659a5 (commit)
   via  b04df7d606afa7ec7a43c788dcfcd06e595ccabd (commit)
  from  ccc40975e3cda7966b67be297dd16891aa8dc314 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 051eef767ab3723a63e1bfff50864ab441e05f23
Author: Nick Clemens 
Date:   Tue Oct 2 00:09:12 2018 +

Bug 18639: (follow-up) Remove debugging code

Signed-off-by: Nick Clemens 

commit 4859e49539e37f08689df3ba001739711f1332a4
Author: Nick Clemens 
Date:   Tue Oct 2 00:05:22 2018 +

Bug 21403: DBRev 18.06.00.035

Signed-off-by: Nick Clemens 

commit c6e44c9c6bb78bfb3edeacf877c5edb114aab558
Author: Jonathan Druart 
Date:   Mon Oct 1 12:14:17 2018 -0300

Bug 21403: Do not overwrite the options if modified locally

Just in case...

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit d1bf2238c49bad5471b467aae4a5f680639cee97
Author: Owen Leonard 
Date:   Tue Sep 25 13:16:09 2018 +

Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting

This patch adds an "IN" option to the AmazonLocale setting, allowing
Indian libraries to use their Amazon Affiliate ID in Koha's links to
Amazon.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System preferences -> Enhanced content.
- Enable the OPACAmazonCoverImages preference.
- Enter a dummy ID in the AmazonAssocTag preference.
- Confirm that you can select "Indian" for the AmazonLocale preference.
- Select "Indian" and save.
- Open a record in the OPAC and confirm that the cover image links to
  Amazon.in and includes the ID you entered in AmazonAssocTag.
- Do the same with a record in the staff client.

Signed-off-by: Pierre-Marc Thibault 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit 15670cd590e4a1efc01bb9bd1648162781486f5b
Author: Owen Leonard 
Date:   Thu Sep 27 12:59:01 2018 +

Bug 21430: Update two-column templates with Bootstrap grid: Reports part 3

This patch modifies several reports templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-26-g43b6644

2018-10-03 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  43b6644818f71c2d3c4bf09c6c40b36f5c0522c2 (commit)
   via  01588a68aa74c6fe32329178840e9cc542e2829c (commit)
   via  9fbd65ca5228641042975169e8217a0f14ac28c4 (commit)
   via  5d677af3b4b5095145c359f69f6304f24fe2d590 (commit)
  from  025aa54a58c292631b0ff412fd59c3ee35813c18 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 43b6644818f71c2d3c4bf09c6c40b36f5c0522c2
Author: Jon Knight 
Date:   Mon May 14 15:30:55 2018 +

Bug 16739: Show note instead of 500 error for 'Generate EDIFACT' when no 
EDI account is configured

When a book seller (vendor) does not have EDI account information configured
the basketgroup display still shows a button to generate EDIFACT output 
which
results in 500 error when clicked.  This patch fixes two aspects of this:

a) it stops the button being displayed in the first place, replacing it with
a message that explains there is not EDIFACT configuration for the vendor.

b) if, somehow, an edifact print operation is passed to the basketgroup
script it detects the lack of an EAN and redirects back to the basket group
display page with a warning message.

To test:
1) Create a vendor with no EDI details.
2) Create a basket with some items in, then close it and add it to a basket
   group for this vendor.
   3) Go to that vendor's basket groups, click on the "Closed" tab and then
  click on the 'generate edifact order' button. You should get a 500 
error.
   4) Apply this patch.
   5) Repeat 3, except this time you should find that the 'generate edifact
  order' button has been replaced with a note that there is
  "No EDIFACT configuration for ".

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 121b8105bcb00909b1e8081442148c1939c101a6)
Signed-off-by: Martin Renvoize 

commit 01588a68aa74c6fe32329178840e9cc542e2829c
Author: Jonathan Druart 
Date:   Sat Sep 22 11:08:16 2018 -0300

Bug 21398: Make search field mandatory when adding to a basket from an 
existing record

Test plan:
- Create a basket
- Click the "Add to basket" button
- Click "Search" on the first line
=> Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg
=> With this patch applied you will not be able to submit without
filling the input in

QA note: Yes, we could handle that controller side as well, but much
more work.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit bf89e4e124fb38982fa8b9708af1fb67fd16f982)
Signed-off-by: Martin Renvoize 

commit 9fbd65ca5228641042975169e8217a0f14ac28c4
Author: Owen Leonard 
Date:   Tue Sep 25 13:51:02 2018 +

Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor)

This patch upgrades Codemirror to the latest version (5.40.2). Doing so
fixes a problem with the advanced cataloging editor's macro editor which
appears in the latest version of Firefox (62): The first line of the
macro editor is not visible.

To test, apply the patch and clear your browser cache if necessary.
EnableAdvancedCatalogingEditor must be set to "Enable."

- Go to Cataloging -> Advanced editor.
- Click the "Macros" toolbar button.
- In the main part of this modal window you should see a blank line
  marked "1."
- Click "New macro..."
- The editor's line 1 should now be editable. Enter text to confirm that
  it works correctly.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 01470fab9eabd3750746b540389de7a6d85fda05)
Signed-off-by: Martin Renvoize 

commit 5d677af3b4b5095145c359f69f6304f24fe2d590
Author: Jonathan Druart 
Date:   Fri Sep 14 15:56:44 2018 -0700

Bug 21297: Display public lists to existing lists when adding a new item

If there are no private lists the public lists are not displayed.

Test plan:
1) Add 10 public lists (This is when the 'More lists' menu item becomes
view-able)
2) Select an item
3) Click Add to list
4) Select 'More Lists' menu item
5) Note that 'Select an existing list' is an available option

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit 

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-31-g0f2d803

2018-10-03 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  0f2d80328d74c661ecd318f603a18743e3c699bb (commit)
   via  20b0ca1f63c6ad97a05476236036996058b784c2 (commit)
   via  419f889bb0e0220d81b9883d27aeea128a5b (commit)
   via  e74f433418e4494c68e996c6d1061d485d67c49e (commit)
   via  362c9331a241bedb3efcab57c0e1287c5ed1c18a (commit)
  from  43b6644818f71c2d3c4bf09c6c40b36f5c0522c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 0f2d80328d74c661ecd318f603a18743e3c699bb
Author: Pasi Kallinen 
Date:   Fri Aug 24 11:05:04 2018 +0300

Bug 20785: Advanced Editor does not honor MarcFieldDocURL

The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL.
Make it do so.

Test plan:

1) Enable EnableAdvancedCatalogingEditor
2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD}
3) Go to Cataloging -> Advanced editor
4) Go to any field and press Ctrl-H
5) Marc field documentation on www.loc.gov or ifla.org should open
6) Apply patch
7) Repeat 3 and 4. The Marc field docs should open on the URL you set

Signed-off-by: Pasi Kallinen 
Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit ca839922fd4bf3c455454f6dd9182203b1481831)
Signed-off-by: Martin Renvoize 

commit 20b0ca1f63c6ad97a05476236036996058b784c2
Author: Nick Clemens 
Date:   Sat Jul 14 14:29:53 2018 +

Bug 21078: overdrive.js Catch error if window.opener is not accessible

To Test:
0 - Enable overdrive search results on your koha
1 - From a source develop a link to your koha instance that opens a new
window:
http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love";>Test
2 - Click that link
3 - Note Overdrive results do not load
4 - Note error in JS console
5 - Apply patch
6 - Click the link again
7 - Note OD results load
8 - Note no error in console

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6975a6836a21f42675a9394602246891c19d9522)
Signed-off-by: Martin Renvoize 

commit 419f889bb0e0220d81b9883d27aeea128a5b
Author: Katrin Fischer 
Date:   Sat Aug 11 23:55:35 2018 +

Bug 20241: Fix display of publication year in subscription record search 
for MARC21

The old problem: UNIMARC uses biblio.publicationyear, MARC21 uses
biblio.copyrightdate. Patch adds a fallback, if there is nothing
in publicationyear, copyrightdate will be displayed.

To test:
  - In a MARC21 database
  - Add a new subscription
  - Search for records
  - Verify the publication year column remains empty
  - Apply patch
  - Repeat search
  - Verify that the year now shows

https://bugs.koha-community.org/show_bug.cgi?id=20421

Signed-off-by: Michal Denar 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8df47bdde678773f028f312b4cd8000a12425281)
Signed-off-by: Martin Renvoize 

commit e74f433418e4494c68e996c6d1061d485d67c49e
Author: Ere Maijala 
Date:   Fri Oct 13 14:07:21 2017 +0300

Bug 21362: Advanced editor: Fix tab navigation in fixed fields

Also minor tweaks to how the fields look.

Test plan:

1. Try moving from field to field and inside control fields with 
tab/shift-tab.
2. Make sure focus doesn't get stuck in any position.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 024643f51c4e0ca1803dd5013bb857e98cd924e5)
Signed-off-by: Martin Renvoize 

commit 362c9331a241bedb3efcab57c0e1287c5ed1c18a
Author: Jonathan Druart 
Date:   Fri Sep 21 17:55:40 2018 -0300

Bug 21396: Add 2 missing use statements in Koha::Account

1. require C4::Letters must be use C4::Letters (from bug 19191)

2. There is call to C4::Circulation::ReturnLostItem, but no use of
C4::Circulation (from bug 20631)

Test plan:
finger crossed, I ran the tests from t/db_dependent/Koha and they all
passed

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 1b56e446ed64cad9d4dd42a8cb3f1953f424e0aa)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha/Account.pm|1 +
 .../i

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-7-g3ef1e4a

2018-10-03 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  3ef1e4ac01ceadc2721449b668dc0da376b6f3c0 (commit)
   via  63ab79d6e478d42f13ac48f62828a1059dff1aad (commit)
   via  5dad62c0c75063ea6d96a701a3875a72f3a74d86 (commit)
   via  05d73fb69cf5df9675e1eac032eee36472b3cbee (commit)
   via  59b9b4dcf55dba1f29d044e7da6a651f89592089 (commit)
   via  52e4a8635eb48662da6bc48fa83dfe4758598fa2 (commit)
  from  e69ce2d8a6b5e469ff809dfa8a616e615d096205 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3ef1e4ac01ceadc2721449b668dc0da376b6f3c0
Author: Jonathan Druart 
Date:   Sun Sep 16 10:41:49 2018 -0700

Bug 21353: (follow-up) same check for select/clear all links

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit bf908a5f07ffbd492c42483aace120dae8316048)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 28a404bc3124cb45863db8872cb0ee7c839fda5d)
Signed-off-by: Fridolin Somers 

commit 63ab79d6e478d42f13ac48f62828a1059dff1aad
Author: Jonathan Druart 
Date:   Sat Sep 15 11:02:05 2018 -0700

Bug 21353: Display checkboxes to merge patron even if cannot manage lists

When permission 'manage_patron_lists' is off, there is no checkbox on
/cgi-bin/koha/members/member.pl to merge patrons.

Test plan:
Remove permission manage_patron_lists
Add permission edit_borrowers
Search for patrons
=> Without this patch you will not be able to select patrons to merge
(checkboxes are not displayed)

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit d60b0a2e4d3359c127f1e801db9e35dd217f8790)
Signed-off-by: Martin Renvoize 
(cherry picked from commit ffbd4d22e134ba9c1af511dcb0a56a4473f1a789)
Signed-off-by: Fridolin Somers 

commit 5dad62c0c75063ea6d96a701a3875a72f3a74d86
Author: Jonathan Druart 
Date:   Fri Sep 14 16:10:56 2018 -0700

Bug 21323: Handle multi params in redirect after login

Multi params are not handle correctly after login

Test plan:
[0] Use staff interface
[1] Use advance search and tick itemtype more than one checkbox
[2] Copy result url
[3] Logout
[4] Paste url in browser
[5] Type username and password
[6] In search result page, results limit description under breadcrumbs
will show all limits

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit c6a26d2c9e767623c7bc0698297bbc165301e7ed)
Signed-off-by: Martin Renvoize 
(cherry picked from commit c088efd6c959d12dd8c1743e3eeb9f12d41a77e2)
Signed-off-by: Fridolin Somers 

commit 05d73fb69cf5df9675e1eac032eee36472b3cbee
Author: Marcel de Rooy 
Date:   Fri Sep 21 09:15:08 2018 +0200

Bug 21281: (QA follow-up) Introduce _add_backtics

Added a (initially trivial) test in Creators/Lib.t too.
Sometimes you start something, but you end somewhere else ;)

The test seems a bit slower now (regex, lookahead, etc). But this should
not hurt label creators in daily use.
Advantages: code is even more solid, consolidated in one place and can be
tested on its own.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit db683b285cfb31deb9dbdafbc5a18e0b471ffa65)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 75b0e7a0787d82caa987afc67206fad2b5811e4c)
Signed-off-by: Fridolin Somers 

commit 59b9b4dcf55dba1f29d044e7da6a651f89592089
Author: Mark Tompsett 
Date:   Wed Sep 5 18:41:32 2018 +

Bug 21281: Correct t/db_dependent/Creators/Lib.t failures

TEST PLAN
-
1) apply first patch
2) kshell kohadev
3) prove -r -v t/db_dependent/Creators/
   -- failures
4) apply this patch
5) repeat 2,3
   -- no failures
6) run koha qa test tools

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

(cherry picked from commit 78124100ec6708de99bea3e4e181da3897130d0e)

Signed-off-by: Martin Renvoize 

(cherry picked from commit a54c1b9a1ca86dcab11e4008727221edc42eb69a)

Signed-off-by: Fridolin Somers 

commit 52e4a8635eb48662da6bc48fa83dfe4758598fa2
Author: Jonathan Druart 
Date:   Wed Aug 29 17:05:50 2018 -0300

Bug 21281: Surround creator_templates.rows with backquotes

'rows' is a rese

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-15-g77a8b48

2018-10-03 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  77a8b48c039e6814132c69fa0f74902e9e0edab7 (commit)
   via  38e0b12382368211ebce372de5ba21b14f11ef58 (commit)
   via  9efd499bc19d1d87d6214a920cf3f9b214de28c0 (commit)
   via  ba07e93035829f6763a94bb7320d1648db3c7005 (commit)
   via  bfe2a30c8b7aba539be9c9bec5b18062a5d56825 (commit)
   via  905b732989c0dec1336fdbf25b03b8aa1cc0aec4 (commit)
   via  6f3ecfc10bea5597f9114a0bd98a71bd2ca91308 (commit)
   via  7db5f67f66c41377eda247ddd715b588043b46ef (commit)
  from  3ef1e4ac01ceadc2721449b668dc0da376b6f3c0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 77a8b48c039e6814132c69fa0f74902e9e0edab7
Author: Fridolin Somers 
Date:   Wed Oct 3 15:41:59 2018 +0200

Revert "Bug 21353: Display checkboxes to merge patron even if cannot manage 
lists"

This reverts commit 63ab79d6e478d42f13ac48f62828a1059dff1aad.

commit 38e0b12382368211ebce372de5ba21b14f11ef58
Author: Fridolin Somers 
Date:   Wed Oct 3 15:41:49 2018 +0200

Revert "Bug 21353: (follow-up) same check for select/clear all links"

This reverts commit 3ef1e4ac01ceadc2721449b668dc0da376b6f3c0.

commit 9efd499bc19d1d87d6214a920cf3f9b214de28c0
Author: Nick Clemens 
Date:   Wed Sep 26 16:17:06 2018 +

Bug 5458: DBRev 17.11.10.001

Signed-off-by: Nick Clemens 
(cherry picked from commit b5becc84f5f2e8f82b765b5ebf3f87a84d89cfd8)
Signed-off-by: Martin Renvoize 
(cherry picked from commit d0affd28266fb9e7461521c703dd640e19c82b99)
Signed-off-by: Fridolin Somers 

commit ba07e93035829f6763a94bb7320d1648db3c7005
Author: Fridolin Somers 
Date:   Tue Sep 4 10:40:29 2018 +0200

Bug 5458: increase ccode column to varchar 80

Koha allows you to define an authorised value having length 80, but then you
can't use it.

Here is why:
The SQL field items.ccode is a varchar(10).
The SQL field authorised_values.authorised_value is a varchar(80).
Therefore the authorised value is truncated to length 10 in items.ccode and 
the mapping from authorised value to description string fails in Koha.

This patch increases ccode column to varchar 80, like location.

Test plan :
1) Dont apply patches
2) Check there is on item field a subfield with authorised value category 
CCODE
3) Check this subfield is linked with database column items.ccode
4) Create an authorised values in category CCODE with 'DOCUMENTATION'
5) Edit an item on ccode and choose 'DOCUMENTATION'
6) Save item
7) Look at items.ccode in database or export in MARCXML
8) The value is troncated to 'DOCUMENTAT'
9) Apply patches and update database with 
installer/data/mysql/atomicupdate/bug_5458.sql
10) Repeate step 5 to 7
11) The value is not truncated 'DOCUMENTATION'

Signed-off-by: Michal Denar 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit c59ef0452ccbae17de3b839da4fa2c9f7f6b2e6f)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 892492cbda442564a33b1abdf374d43c024de22c)
Signed-off-by: Fridolin Somers 

commit bfe2a30c8b7aba539be9c9bec5b18062a5d56825
Author: Marcel de Rooy 
Date:   Fri Sep 21 11:38:15 2018 +0200

Bug 20023: (QA follow-up) Tiny simplification

Remove empty emails from the list rightaway.
Would be tempted to lc the params->{email} at the start btw..

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit eec74a2cd1847a859b4fab37c42882ba192ee560)
Signed-off-by: Martin Renvoize 
(cherry picked from commit c5bb4d6529f9dcd2457639c8b7735dfc7001d244)
Signed-off-by: Fridolin Somers 

commit 905b732989c0dec1336fdbf25b03b8aa1cc0aec4
Author: Blou 
Date:   Mon Sep 17 16:34:19 2018 -0400

Bug 20023: Password recovery using email should be case insensitive

When entering an email to recover the password, a user should not have to 
know or remember the casing of the given email.

Test
0) enable OpacResetPassword
1) On the OPAC, click "Forgot your password"
2) Enter your email address as in your user account BUT WITH A DIFFERENT 
CASING
3) Submit.  This will fail.
4) Apply the patch, redo with success.

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit cc3bc2920744e35256b45b784c9788a64fe6dd04)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 0f019c89c18733c0e0220f41012a06c3b39df595)
Signed-off-by: Fridoli

[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.13-30-gf036124

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
   via  f036124cbedfe60397765c30a022f095a850f22f (commit)
   via  25b5759f3a9c43bd40eb283544f9af345046226f (commit)
   via  dd5644568f229ce66c8fcff74de084f43ad05ed3 (commit)
  from  8dfaaae2b9689cb3fd6825a278c3734206efbb1d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f036124cbedfe60397765c30a022f095a850f22f
Author: Fridolin Somers 
Date:   Fri Oct 5 09:13:25 2018 +0200

Update release notes for 17.05.14 release

Signed-off-by: Fridolin Somers 

commit 25b5759f3a9c43bd40eb283544f9af345046226f
Author: Fridolin Somers 
Date:   Fri Oct 5 09:08:30 2018 +0200

Increment version for 17.05.14 release

Signed-off-by: Fridolin Somers 

commit dd5644568f229ce66c8fcff74de084f43ad05ed3
Author: Koha translators <>
Date:   Thu Oct 4 11:51:06 2018 -0300

Translation updates for Koha 17.05.14

---

Summary of changes:
 Koha.pm|2 +-
 installer/data/mysql/updatedatabase.pl |6 +
 ...notes_17_05_13.md => release_notes_17_05_14.md} |  130 ++-
 misc/translator/po/am-Ethi-marc-MARC21.po  |2 +-
 misc/translator/po/am-Ethi-marc-NORMARC.po |2 +-
 misc/translator/po/am-Ethi-marc-UNIMARC.po |2 +-
 misc/translator/po/am-Ethi-opac-bootstrap.po   |2 +-
 misc/translator/po/am-Ethi-staff-help.po   |2 +-
 misc/translator/po/am-Ethi-staff-prog.po   |2 +-
 misc/translator/po/ar-Arab-marc-MARC21.po  |2 +-
 misc/translator/po/ar-Arab-marc-NORMARC.po |2 +-
 misc/translator/po/ar-Arab-marc-UNIMARC.po |2 +-
 misc/translator/po/ar-Arab-opac-bootstrap.po   |2 +-
 misc/translator/po/ar-Arab-staff-help.po   |2 +-
 misc/translator/po/ar-Arab-staff-prog.po   |2 +-
 misc/translator/po/as-IN-marc-MARC21.po|2 +-
 misc/translator/po/as-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/as-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/as-IN-opac-bootstrap.po |2 +-
 misc/translator/po/as-IN-staff-help.po |2 +-
 misc/translator/po/as-IN-staff-prog.po |2 +-
 misc/translator/po/az-AZ-marc-MARC21.po|2 +-
 misc/translator/po/az-AZ-marc-NORMARC.po   |2 +-
 misc/translator/po/az-AZ-marc-UNIMARC.po   |2 +-
 misc/translator/po/az-AZ-opac-bootstrap.po |2 +-
 misc/translator/po/az-AZ-staff-help.po |2 +-
 misc/translator/po/az-AZ-staff-prog.po |2 +-
 misc/translator/po/be-BY-marc-MARC21.po|2 +-
 misc/translator/po/be-BY-marc-NORMARC.po   |2 +-
 misc/translator/po/be-BY-marc-UNIMARC.po   |2 +-
 misc/translator/po/be-BY-opac-bootstrap.po |2 +-
 misc/translator/po/be-BY-staff-help.po |2 +-
 misc/translator/po/be-BY-staff-prog.po |2 +-
 misc/translator/po/bg-Cyrl-marc-MARC21.po  |2 +-
 misc/translator/po/bg-Cyrl-marc-NORMARC.po |2 +-
 misc/translator/po/bg-Cyrl-marc-UNIMARC.po |2 +-
 misc/translator/po/bg-Cyrl-opac-bootstrap.po   |2 +-
 misc/translator/po/bg-Cyrl-staff-help.po   |2 +-
 misc/translator/po/bg-Cyrl-staff-prog.po   |2 +-
 misc/translator/po/bn-IN-marc-MARC21.po|2 +-
 misc/translator/po/bn-IN-marc-NORMARC.po   |2 +-
 misc/translator/po/bn-IN-marc-UNIMARC.po   |2 +-
 misc/translator/po/bn-IN-opac-bootstrap.po |2 +-
 misc/translator/po/bn-IN-staff-help.po |2 +-
 misc/translator/po/bn-IN-staff-prog.po |2 +-
 misc/translator/po/ca-ES-marc-MARC21.po|2 +-
 misc/translator/po/ca-ES-marc-NORMARC.po   |2 +-
 misc/translator/po/ca-ES-marc-UNIMARC.po   |2 +-
 misc/translator/po/ca-ES-opac-bootstrap.po |2 +-
 misc/translator/po/ca-ES-staff-help.po |2 +-
 misc/translator/po/ca-ES-staff-prog.po |2 +-
 misc/translator/po/cs-CZ-marc-MARC21.po|2 +-
 misc/translator/po/cs-CZ-marc-NORMARC.po   |2 +-
 misc/translator/po/cs-CZ-marc-UNIMARC.po   |2 +-
 misc/translator/po/cs-CZ-opac-bootstrap.po |2 +-
 misc/translator/po/cs-CZ-staff-help.po |2 +-
 misc/translator/po/cs-CZ-staff-prog.po |   34 +-
 misc/translator/po/cy-GB-marc-MARC21.po|2 +-
 misc/translator/po/cy-GB-marc-NORMARC.po  

[koha-commits] main Koha release repository annotated tag v17.05.14 created. v17.05.14

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The annotated tag, v17.05.14 has been created
at  a6290e4821828b5f9dd869291538975144caf02a (tag)
   tagging  f036124cbedfe60397765c30a022f095a850f22f (commit)
  replaces  v17.05.13
 tagged by  Fridolin Somers
on  Fri Oct 5 09:13:51 2018 +0200

- Log -
Koha release 17.05.14
-BEGIN PGP SIGNATURE-

iQEzBAABCgAdFiEEuXlk3O256QfzYP0rK8k2QoBkBm4FAlu3Dy8ACgkQK8k2QoBk
Bm5LvQgAmtUR/OX5VonmvhUfNSG45yb46yC6WvmgH4RasF2hIsWV7J+4I4R44km+
uaRsw07HOu4IQ865xc/58bJ5MdSYiKxvJJkWBnnAzVQ9xO1zkvSnFVdA1qgl9JzU
ZQ4FERjTcmFRbAaMWWQRb6jORQnJEU8ToG6IyF1L4yRoUUtCc3TN6taP4bfbYx3J
9m9X5LRTrRt2I84CzGURL0Evcjyz3XWpijmaK20IrIRg1uNfTBjME5scoEnl0aUa
aVL4cpqqQkad1w31cTrgucKp4u4eLbnxp1k1BgVxQa60WS4tymcWfJi4X41K9qOz
2LBkXUiy+zg71T4ZRqtvYlZ0ZH3ilg==
=zwaD
-END PGP SIGNATURE-

Colin Campbell (1):
  Bug 20972: Add a testcase for bug 20972

Fridolin Somers (3):
  Bug 20951: add missing use Koha::Patron::Debarments in 
Koha::Patron::Discharge
  Increment version for 17.05.14 release
  Update release notes for 17.05.14 release

Jonathan Druart (8):
  Bug 20811: Fix wrong usage of ModBiblio
  Bug 20724: Move the ReservesNeedReturns logic to AddReserve
  Bug 20724: Add tests for ReservesNeedReturns
  Bug 21018: Fix TrackClicks for 952$u
  Bug 21018: Allow uris defined in the item
  Bug 21199: Hide patron's attributes from ILSDI if required
  Bug 21226: DB Changes
  Bug 21226: Remove xISBN services

Josef Moravec (1):
  Bug 20903: Remove unnecessary category code parameters

Koha translators (1):
  Translation updates for Koha 17.05.14

Kyle M Hall (1):
  Bug 20724: Correctly mark an hold as waiting - ReservesNeedReturns

Marcel de Rooy (4):
  Bug 20811: (QA follow-up) Make the isbn check work
  Bug 20811: (QA follow-up) Prevent calling AddItemBatchFromMarc and 
ModBiblioMarc without biblionumber
  Bug 20724: (QA follow-up) Remove two obsolete comment lines
  Bug 20773: (bug 20724 follow-up) Add a simple db revision

Martin Renvoize (2):
  Bug 20879: Fix regression in shibboleth when ldap enabled
  Bug 21199: (QA follow-up) Add show_attributes to perldoc

Mirko Tietgen (2):
  Bug 20693: Plack fails, because 'libcgi-emulate-psgi-perl' package is not 
installed
  Bug 20693: Update control file

Nick Clemens (6):
  Bug 20014: Preselect item budget based on id not code
  Bug 18947: LDAP - do not assume anonymous bind if no user or password
  Bug 20811: (RM follow-up) fix check for matching
  Bug 20773: DBRev 18.05.02.003
  Bug 21054: Remove extraneous  tag from sco-main.tt
  Bug 21226: DBRev 17.11.09.001

xljoha (1):
  Bug 20972: If ISBN has 10 numbers only the first 9 numbers are used

---


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-32-g6427906

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  6427906fcccea22327db3c1d78847fed5ba9e7fb (commit)
  from  0f2d80328d74c661ecd318f603a18743e3c699bb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 6427906fcccea22327db3c1d78847fed5ba9e7fb
Author: Jonathan Druart 
Date:   Tue Jul 31 15:24:10 2018 -0300

Bug 21133: [18.05.x] Fix use statements order

Basically the idea is:
1. Undefined subroutine &C4::Items::ModZebra called at 
/home/vagrant/kohaclone/C4/Items.pm line 302.

=> Then use C4::Items before C4::Biblio

2. Undefined subroutine &C4::Circulation::GetItem called at 
/home/vagrant/kohaclone/C4/Circulation.pm line 1290

=> Then use C4::Circulation before C4::Items

And sometimes these 2 rules do not work...

Signed-off-by: Martin Renvoize 

---

Summary of changes:
 t/db_dependent/Circulation/Branch.t  |2 +-
 t/db_dependent/Circulation/Chargelostitem.t  |2 +-
 t/db_dependent/Circulation/CheckIfIssuedToPatron.t   |9 +++--
 t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t   |2 +-
 t/db_dependent/Circulation/IsItemIssued.t|2 +-
 .../Circulation/IssuingRules/maxsuspensiondays.t |2 +-
 t/db_dependent/Circulation/Returns.t |4 ++--
 t/db_dependent/Circulation/SwitchOnSiteCheckouts.t   |4 ++--
 t/db_dependent/Circulation/TooMany.t |4 ++--
 t/db_dependent/Circulation/issue.t   |4 ++--
 t/db_dependent/Circulation/transfers.t   |4 ++--
 t/db_dependent/CourseReserves.t  |4 ++--
 t/db_dependent/Holds.t   |9 +
 t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t  |2 +-
 t/db_dependent/Holds/LocalHoldsPriority.t|2 ++
 t/db_dependent/Holds/RevertWaitingStatus.t   |   14 ++
 t/db_dependent/Items.t   |9 +++--
 t/db_dependent/Items/AutomaticItemModificationByAge.t|2 +-
 t/db_dependent/Items/DelItem.t   |7 ++-
 t/db_dependent/Koha/Object.t |3 ++-
 t/db_dependent/Koha/Patrons.t|4 +---
 t/db_dependent/Labels/t_Batch.t  |2 +-
 t/db_dependent/Members/GetAllIssues.t|2 +-
 t/db_dependent/Members/IssueSlip.t   |2 +-
 t/db_dependent/Patron/Borrower_Discharge.t   |4 ++--
 t/db_dependent/Reserves.t|2 +-
 t/db_dependent/RotatingCollections.t |4 ++--
 t/db_dependent/ShelfBrowser.t|2 +-
 t/db_dependent/api/v1/holds.t|2 +-
 29 files changed, 53 insertions(+), 62 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-35-gfe5e750

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  fe5e75057158f0d274d00d987248cf7758ef197c (commit)
   via  8d3b64400b127bf2a417a26a0592586d0660c4d1 (commit)
   via  794e3af801bd38d134bca26395b3ad0b2ac7f1a7 (commit)
  from  6427906fcccea22327db3c1d78847fed5ba9e7fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit fe5e75057158f0d274d00d987248cf7758ef197c
Author: Josef Moravec 
Date:   Wed Sep 19 08:07:57 2018 +

Bug 21167: (QA follow-up) Use accounttype.inc for generating account 
description

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit a6a7516652115ccc49099f045ed8c23a9f29eb26)
Signed-off-by: Martin Renvoize 

commit 8d3b64400b127bf2a417a26a0592586d0660c4d1
Author: Josef Moravec 
Date:   Wed Sep 19 07:53:32 2018 +

Bug 21167: (QA follow-up) Fix amount formatting on invoice receipt

Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit c86485f933a0eabdb8af215c5b74c5416d2cb95a)
Signed-off-by: Martin Renvoize 

commit 794e3af801bd38d134bca26395b3ad0b2ac7f1a7
Author: Katrin Fischer 
Date:   Wed Aug 8 19:26:47 2018 +

Bug 21167: Fix price formatting on printed fee invoice and receipt

The prices were not formatted correctly on the printed receipts
for fines and payments in the patron account.

This patch introduces the use of the Price TT plugin to those
templates.

Also:
- Fixes a few capitalization errors
- Removes spaces in front of :
- Updates accounttype-to-description list to the one used
  in other templats as a lot of values were missing (Credit etc.)

To test:
- Create several fines, use some .00 and some with other values
- Pay some fines
- Create a manual credit
- Use print button for all of those (credit, fee, payment)
- Verify that:
  - prices ending in .00 are displayed without the decimal part
  - instead of Credit only C is shown in the description
- Apply patch
- Print invoices and receipts again
- Verify that:
  - prices are now formatted according to CurrencyFormat system
preference, decimal part always included
  - verify that correct description for Credit is shown

Signed-off-by: Brendan Gallagher 

Signed-off-by: Josef Moravec 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 184c44ee31bf54ad179f9fb9fd501114902a0176)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 .../prog/en/modules/members/printfeercpt.tt|   25 ++--
 .../prog/en/modules/members/printinvoice.tt|   23 +-
 members/printfeercpt.pl|7 +++---
 3 files changed, 16 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-38-g6bf5044

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  6bf50445b151ef94e6100da482e5826458a5136b (commit)
   via  67a491a73f0dea1182c937aa424491210a0d0d8b (commit)
   via  93b7683780ba6c79ce22307c8c8cbd31f3c73a56 (commit)
  from  fe5e75057158f0d274d00d987248cf7758ef197c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 6bf50445b151ef94e6100da482e5826458a5136b
Author: Andrew Isherwood 
Date:   Thu Aug 30 10:52:43 2018 +0100

Bug 21289: Fix "isa" bug during partner request

We cannot call 'handle_commit_maybe' inside a 'try' block.
handle_commit_maybe redirects the client then calls 'exit', this is
interpreted as an error and the 'catch' block is erroneously called.

This patch moves the calling of 'handle_commit_maybe' outside the try
block, it will only be reached if everything inside the try block
suceeds.

To test:
1) Enable ILL and have the FreeForm backend available
2) Create a patron category to hold ILL "partners" to whom requests can
be sent. The category can be called anything, you should note the code
you assign
3) Create a patron that belongs to your new category, the patron must
have a primary email defined.
4) In your  block in koha-conf.xml, ensure you have
a  element, it should contain the code you assigned in
step 2
5) Create an ILL request using the FreeForm backend
6) Once the request is created, select the "Place request with partners"
button
7) Select your "partner" from the "Select partner libraries" box
8) Click "Send email"
9) TEST: Observe no errors are displayed in the UI

Signed-off-by: Barry Cannon 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit fca5a1cb3dba5d6561eaf5f30dfd4d996a4042cc)
Signed-off-by: Martin Renvoize 

commit 67a491a73f0dea1182c937aa424491210a0d0d8b
Author: Mark Tompsett 
Date:   Tue Jun 7 22:48:57 2016 -0400

Bug 16690: Simplify SHOW GRANTS to work when connected

If the DB is on a remote machine, the web server and the
db server are different, but the SHOW GRANTS code in
installer/install.pl is trying to use the SAME machine.
And even if the permissions were allowed accessing from
both the web and db servers, MySQL won't return the
SHOW GRANTS without access to the mysql.user table. To
install *.* permissions became easiest to get working.
Unless the DB is set up with 'user'@'%', which is also a
potential security issue.

MySQL / MariaDB allow the current connected user to
check their own grants with CURRENT_USER.
There is no need for the installer to know the
IP address of the webserver.

This also removes the need to have permissions for
'koha_kohadev'@'%', because the only process to be
accessing the koha DB is from a known host/ip.
This tightens security too.

TEST PLAN
-
Install 2 fresh VMs from a Debian ISO.
Make sure they are on the same network (192.168.50.x) as
the kohadevbox. You will need to remember one as DB_IPADDRESS.

On the DB VM & Third VM:
sudo apt-get install mariadb-server mariadb-client net-tools
-- the third vm just needs to be able to run mysql to access
   the DB VM.

On DB VM:
sudo vi /etc/mysql/mariadb.conf.d/50-server.cnf
-- make sure the bind-address line is commented out with a #
sudo service mariadb restart
-- congratulations, your DB server is listening to remote
   calls now.

sudo mysql -u root
CREATE DATABASE koha_kohadev;
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'localhost' 
IDENTIFIED BY 'password';
FLUSH PRIVILEGES;
-- now you have an empty DB ready to run a web install on.
   However, because only koha_kohadev from localhost is
   allowed, we expect failure when we try to run the web
   installation step when we get there.

Let's confirm that everything is working as expected
before trying.  It will also demonstrate the reason why
this patch is superior to the existing code.

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should be denied

On DB VM:
DROP USER 'koha_kohadev'@'localhost';
GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' IDENTIFIED 
BY 'password';
FLUSH PRIVILEGES;

On a kohadevbox:
mysql -u koha_kohadev -h DB_IPADDRESS -p
-- this should give you a SQL prompt
SHOW GRANTS FOR CURRENT_USER;
-- this should show two lines based on 'koha

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-42-g721cefd

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  721cefdb95ba6d3f8fb59f6b02255cd76d8a3fbf (commit)
   via  73b197df9ed8e038684e1821ab4d9090d7af225a (commit)
   via  49158f3369617b9a4ad8d247308f2a4aea653cde (commit)
   via  5fbbdb915f9a41070ff71aac902622f0a7bb5ef7 (commit)
  from  6bf50445b151ef94e6100da482e5826458a5136b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 721cefdb95ba6d3f8fb59f6b02255cd76d8a3fbf
Author: Mark Tompsett 
Date:   Wed Sep 26 22:57:32 2018 +

Bug 13272: (follow-up) add missing type="text"

This addresses comment #13.
This also applies cleanly.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 623f1db90ac8d0361a879813c66a4bccbf0ea23e)
Signed-off-by: Martin Renvoize 

commit 73b197df9ed8e038684e1821ab4d9090d7af225a
Author: Mark Tompsett 
Date:   Wed Sep 19 18:49:02 2018 +

Bug 13272: (follow-up) Replace tabs with spaces

Cleaned up whitespace issues tab vs. space in template.
After applying all patches:
git diff -w origin/master
For the koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
only the changed type="text" lines will show, but without the
-w, there will be more whitespace changes.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 5edd363a1f2e3b1ea34f3f2aa7ace86cbf467df8)
Signed-off-by: Martin Renvoize 

commit 49158f3369617b9a4ad8d247308f2a4aea653cde
Author: Mark Tompsett 
Date:   Wed Sep 19 16:48:13 2018 +

Bug 13272: (follow-up) fix concerns from comment #5

Correct the two issues I pointed out.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 77871b408c9a8e120f8415cc0b32683ee8f57e7d)
Signed-off-by: Martin Renvoize 

commit 5fbbdb915f9a41070ff71aac902622f0a7bb5ef7
Author: Christopher Brannon 
Date:   Sun Sep 16 22:06:10 2018 +

Bug 13272: Adds type="text" to inputs missing it

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 92a2d74c1c134674b9798981208b9ad5863a6b42)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 .../intranet-tmpl/prog/en/includes/adv-search.inc|4 ++--
 .../prog/en/includes/borrower_debarments.inc |2 +-
 .../intranet-tmpl/prog/en/includes/cat-search.inc|5 +++--
 .../prog/en/includes/cataloging-search.inc   |4 ++--
 .../prog/en/includes/checkin-search.inc  |2 +-
 .../intranet-tmpl/prog/en/includes/circ-search.inc   |4 ++--
 .../intranet-tmpl/prog/en/includes/home-search.inc   |4 ++--
 .../intranet-tmpl/prog/en/includes/patron-search.inc |4 ++--
 .../prog/en/modules/acqui/z3950_search.tt|4 ++--
 .../prog/en/modules/admin/smart-rules.tt |4 ++--
 .../prog/en/modules/cataloguing/z3950_auth_search.tt |4 ++--
 .../prog/en/modules/cataloguing/z3950_search.tt  |4 ++--
 .../prog/en/modules/circ/branchtransfers.tt  |2 +-
 .../intranet-tmpl/prog/en/modules/circ/offline.tt|2 +-
 .../intranet-tmpl/prog/en/modules/circ/renew.tt  |2 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt|   18 +-
 .../prog/en/modules/clubs/templates-add-modify.tt|   18 +-
 .../prog/en/modules/members/memberentrygen.tt|2 +-
 .../prog/en/modules/members/paycollect.tt|6 +++---
 .../intranet-tmpl/prog/en/modules/reserve/request.tt |4 ++--
 .../en/modules/serials/subscription-batchedit.tt |2 +-
 .../prog/en/modules/tools/import_borrowers.tt|8 
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt|2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt   |4 ++--
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt   |2 +-
 .../bootstrap/en/modules/opac-shareshelf.tt  |2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt   |5 +++--
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt  |4 ++--
 28 files changed, 65 insertions(+), 63 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koh

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-43-gf7088ec

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  f7088ecf4b752f3e61e94ff4738fb04b97d574d2 (commit)
  from  721cefdb95ba6d3f8fb59f6b02255cd76d8a3fbf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f7088ecf4b752f3e61e94ff4738fb04b97d574d2
Author: Colin Campbell 
Date:   Thu Sep 27 12:25:28 2018 +0100

Bug 21425: Display basketno correctly in Order error msg

carp will display the hash value instead of the desired basketno
in the error message unless we change its behaviour

Use the simpler but effective option of concatenating
the errormessage with the basketno. Error is shown if no
sender or receipient ean is passed in instantiating
an Koha::Edifact::Order object

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit e81756b317da848a6e6346a7c0db8f3b986f7058)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha/Edifact/Order.pm |8 
 1 file changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-932-ge78af53

2018-10-05 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  e78af533df94b155570116f6f7c4b5a2e5e4e2f2 (commit)
   via  7feca40ba1ce8e57fadd78dc643cb7e3d5da5942 (commit)
   via  6e499dd5672e5b22ecbfe202146041d3715fc584 (commit)
   via  27130dbf9923cbf97f01810ec6dc230f96770170 (commit)
   via  a0de8cf1680caae6545ed8fdf371c6cd8b5d36b2 (commit)
   via  2cb8e9755af0fdfd25bebc465f9a415d485ceea0 (commit)
   via  4e76fa419d699c988eba92767c435dac01fc7c06 (commit)
   via  3fb069f8eca1674a10cb2e502ea76ae9d4a90e2d (commit)
   via  a30b6b893824a8fece31e453e23125101338f84b (commit)
   via  5e41933470849377d0dec2c93a71c9b8d1ddd5d8 (commit)
   via  ac5e04b85d0ac05053e338f400a31dce3b0edb1e (commit)
   via  3b489bc24e2b9c39110ed0ec7dc4f9ff28f12966 (commit)
   via  4f598764064e499fe0fee23b9873c388f41e6692 (commit)
   via  da9bd7521996c464c6488e9914b76847ba51a49e (commit)
   via  f185785b8cb02a5882cb45219b7af39f99025ef0 (commit)
   via  24c5253d8e30e51b4890849fcbee9c17ee67 (commit)
   via  5c31b9c75e3beeeb26ab9f96c568e73ec932874f (commit)
   via  b9727d20582164da578d125db80576e72e050d2a (commit)
   via  5a931e4e93cf706602551423e03b8702166bb41c (commit)
   via  35265c0a9bbdb20f40fa49f592aa9a772d27f253 (commit)
   via  f576fb9c3ea88fad65ad83076e59f4f728e908ce (commit)
   via  9b0902928872d81e97627bee6c7adf9e563614c5 (commit)
   via  9de145077abb76b944f277e80a34a81a8a2a0df8 (commit)
   via  e0ca753a2fb4c0509d727ec1d6b5c47d3bf14df7 (commit)
   via  1e856e7e7316749f59cb4e721e352b0a60237def (commit)
   via  ff1b0ba7cae7ee72d1fc4ab0c2d1a1e1b40ac7fe (commit)
   via  47c7f7c64c723ee2944d4c77a71d2f2d0ab0851c (commit)
   via  a37637e30357258885e9d0c1c7a30366869dcb08 (commit)
   via  d74a05d4fe81a599c030024f7944d2bdcca43d12 (commit)
   via  8aa86cdf2d5e0dbda7d21394e52f37ba17a8064c (commit)
   via  b4d8d13f14a7022e603ac30dd8cee0605e9d269d (commit)
   via  16fe5d7f30ede8147cb946095da9d529d057c789 (commit)
   via  6b053546add6fa9d002d757e5b493e68506e5290 (commit)
   via  b313d7c98f6d753caa18cc572ec355f16c4367b1 (commit)
   via  7fbd50e3aa07e46f0558d4f52231896937c998bc (commit)
  from  051eef767ab3723a63e1bfff50864ab441e05f23 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit e78af533df94b155570116f6f7c4b5a2e5e4e2f2
Author: Julian Maurice 
Date:   Fri Oct 5 14:25:34 2018 +0200

Bug 21481: (QA follow-up) Remove last reference to text-extract2

Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 

commit 7feca40ba1ce8e57fadd78dc643cb7e3d5da5942
Author: Josef Moravec 
Date:   Wed Oct 3 10:42:44 2018 +

Bug 21481: Remove reference of *-staff-help.po from koha-translate

Signed-off-by: Owen Leonard 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 

commit 6e499dd5672e5b22ecbfe202146041d3715fc584
Author: Josef Moravec 
Date:   Wed Oct 3 10:39:58 2018 +

Bug 21481: Remove obsolete files from translation toolkit

Signed-off-by: Owen Leonard 
Signed-off-by: Julian Maurice 

Conflicts:
misc/translator/text-extract.pl
misc/translator/text-extract2.pl

Signed-off-by: Nick Clemens 

commit 27130dbf9923cbf97f01810ec6dc230f96770170
Author: Josef Moravec 
Date:   Wed Oct 3 10:20:29 2018 +

Bug 21481: Remove *-staf-help.po files

Signed-off-by: Owen Leonard 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 

commit a0de8cf1680caae6545ed8fdf371c6cd8b5d36b2
Author: Josef Moravec 
Date:   Wed Oct 3 10:19:40 2018 +

Bug 21481: Remove references to help from LangInstaller

Test plan:
1) Aply the patches
2) cd misc/translator
3) Run these command one by one:
./translate install 
./translate update 
./translate create 
4) All should not end with error and must do what is documented (see
./translate --help)

Signed-off-by: Owen Leonard 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 

commit 2cb8e9755af0fdfd25bebc465f9a415d485ceea0
Author: Nick Clemens 
Date:   Fri Oct 5 14:49:13 2018 +

Bug 18887: DBRev 18.06.00.036

Signed-off-by: Nick Clemens 

commit 4e76fa419d699c988eba92767c435dac01fc7c06
Author: Jonathan Druart 
Date:   Wed Oct 3 11:04:45 2018 -0300

Bug 18887: Make DB update idempotent

Signed-off-by: Nick Clemens 

commit 3fb069f8eca1674a10cb2e502ea76ae9d4a90e2d
Author: Josef Moravec 
Date:   Mon Oct 1 19:14:41 2018 +

Bug 18887: (QA follow-up) Remove last occurence

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-21-gb25b8ae

2018-10-07 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  b25b8ae76abd6a4fb97130a2b210603a08ab462c (commit)
   via  98a34a88a0a6f91cdd65a5b61559a85e01418f71 (commit)
   via  8f3e4ff55ceb6c23b375cdd00d2cd571c9bcb116 (commit)
   via  6de8b43bb35b9b922d8011401892973e8600588a (commit)
   via  7836fe4ef2bd462203c71400e630ba6278df995e (commit)
   via  2d7209b81937d7665fc6ee20c8286889a70748c0 (commit)
  from  77a8b48c039e6814132c69fa0f74902e9e0edab7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b25b8ae76abd6a4fb97130a2b210603a08ab462c
Author: Owen Leonard 
Date:   Mon Jul 16 18:41:13 2018 +

Bug 21038: Reserves should be holds

This patch corrects the text of the warning about discharges cancelling
holds.

To test, apply the patch and view the discharge for a patron who has
holds:

 - "Borrower" is changed to "patron"
 - "reserves" is changed to "holds"
 - "canceled" (18 instances in the templates) is changed to "cancelled"
   (51 instances).

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8202f95ad7001a5046f9f40e6322406b253ba3ed)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 585a10e070136b231d88b8ff4099b4085a2b656c)
Signed-off-by: Fridolin Somers 

commit 98a34a88a0a6f91cdd65a5b61559a85e01418f71
Author: Jonathan Druart 
Date:   Mon Aug 6 15:26:49 2018 -0300

Bug 21141: Handle non-existent itemnumbers in batch item 
modification/deletion

The itemnumber list passed from a file in the batch item
modification/deletion tools is not tested.
Like barcodes we should make sure they refer to a valid items in the DB.

Test plan:
- Create a file with barcodes, itemnumbers and random lines
- Use the batch item modification and deletion tools with this file
You should see a table with a list of invalid barcodes and itemnumbers.

Without this patch you got the following error:
Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/tools/batchMod.pl line 580

Signed-off-by: Owen Leonard 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit e8e29d3140007b9b92d97ed2f1df7445c6eeb4f9)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 54d960cb86b91bb21cc7c92e1feef9970faaf8a1)
Signed-off-by: Fridolin Somers 

commit 8f3e4ff55ceb6c23b375cdd00d2cd571c9bcb116
Author: Jonathan Druart 
Date:   Fri Aug 17 13:20:04 2018 -0300

Bug 19500: Add missing span for 'other'

To stay consistent in the DOM structure it would make sense to have it
there as well

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 717cb3f893e33a1f54299abbd81a5f9bc339a225)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 9520e771374d5416595b182608209639f23b6b1b)
Signed-off-by: Fridolin Somers 

commit 6de8b43bb35b9b922d8011401892973e8600588a
Author: Katrin Fischer 
Date:   Sun Aug 12 19:42:30 2018 +

Bug 19500: (QA follow-up) Add spans to ease translation

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit a0d775b9cce90b6a029bd92eb3971383a05f55e2)
Signed-off-by: Martin Renvoize 
(cherry picked from commit f024667a0e32e8fc754c1bebfbaed6df82548e12)
Signed-off-by: Fridolin Somers 

commit 7836fe4ef2bd462203c71400e630ba6278df995e
Author: Katrin Fischer 
Date:   Fri Aug 10 22:54:11 2018 +

Bug 19500: Make module names on letters overview page translatable

While the module pull down on adding and editing a letter is
written out and fully translatable, the overview page showed
the internal 'module code'.

Patch also renames the "Members" module into the "Patrons" module
to match Koha's terminology.

To test:
- Before applying the patch:
  - Add or edit a notice, look at the pull down for module
  - Go back to the overview page
  - Verify the module names don't match
- Apply the patch:
  - Check again, pull downs should now match
  - Verify that Members is now Patrons everywhere

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 5e9480937ae0a4bb901330138e1760d690d5f548)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 1015a6e416ce99ca6060583085a25ea183d99017)
Signed-off-by: Fridolin Somers 

commit 2d7209b81937d7665fc6ee20c8286889a707

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-25-gcc22607

2018-10-07 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  cc22607d83961f0a07ec2596aa96131632f68363 (commit)
   via  49797f77cb82dbba5748fde3138ea61d7ac97dd5 (commit)
   via  a6f035e1887833f00ba058c45b815bb25240040b (commit)
   via  57c049ed81e5a1e7a3c5738f50dda705a2164bfa (commit)
  from  b25b8ae76abd6a4fb97130a2b210603a08ab462c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit cc22607d83961f0a07ec2596aa96131632f68363
Author: Owen Leonard 
Date:   Tue Sep 25 13:51:02 2018 +

Bug 21407: Can't enter new macros in the advanced cataloging editor (rancor)

This patch upgrades Codemirror to the latest version (5.40.2). Doing so
fixes a problem with the advanced cataloging editor's macro editor which
appears in the latest version of Firefox (62): The first line of the
macro editor is not visible.

To test, apply the patch and clear your browser cache if necessary.
EnableAdvancedCatalogingEditor must be set to "Enable."

- Go to Cataloging -> Advanced editor.
- Click the "Macros" toolbar button.
- In the main part of this modal window you should see a blank line
  marked "1."
- Click "New macro..."
- The editor's line 1 should now be editable. Enter text to confirm that
  it works correctly.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 01470fab9eabd3750746b540389de7a6d85fda05)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 9fbd65ca5228641042975169e8217a0f14ac28c4)
Signed-off-by: Fridolin Somers 

commit 49797f77cb82dbba5748fde3138ea61d7ac97dd5
Author: Jonathan Druart 
Date:   Fri Sep 14 15:56:44 2018 -0700

Bug 21297: Display public lists to existing lists when adding a new item

If there are no private lists the public lists are not displayed.

Test plan:
1) Add 10 public lists (This is when the 'More lists' menu item becomes
view-able)
2) Select an item
3) Click Add to list
4) Select 'More Lists' menu item
5) Note that 'Select an existing list' is an available option

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit 33010595113b5ec279f93b1127d20b466e1ea023)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 5d677af3b4b5095145c359f69f6304f24fe2d590)
Signed-off-by: Fridolin Somers 

commit a6f035e1887833f00ba058c45b815bb25240040b
Author: Kyle M Hall 
Date:   Thu Apr 26 15:07:07 2018 -0400

Bug 20669: Add upgrade method to plugins

It would be nice if plugins had an upgrade method to handle altering tables 
and such when a new version of a plugin is installed. Right now it must be done 
in a completely bespoke manner.

Test Plan:
1) Apply this patch
2) Download the 2 most recent releases of the Kitchen Sink plugin
   https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases
3) Install the earlier release
4) Look at the configuration page, at the bottom it should say the
   plugin has never been upgraded
5) Install the newer release
6) Reload the configuration page, it should now say that the plugin
   was upgraded and give you the date and time of the upgrade

Signed-off-by: Claire Gravely 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 
(cherry picked from commit 100385196ecadb34669190caa241ed73ea2a5a1c)
Signed-off-by: Martin Renvoize 
(cherry picked from commit b3f2a13a4368d9f8bec74a6da920649d56732b71)
Signed-off-by: Fridolin Somers 

commit 57c049ed81e5a1e7a3c5738f50dda705a2164bfa
Author: Jonathan Druart 
Date:   Fri Sep 21 18:35:06 2018 -0300

Bug 21397: Mark "Routing list" tab as active when selected

/members/routing-lists.pl?borrowernumber=5 show the different tab of the
menu but "Routing lists" is not displayed as the selected one (active).

"routinglistview" must be set and passed to the template

Test plan:
Enable the RoutingSerials pref
and hit /members/routing-lists.pl?borrowernumber=42

The "Routing lists" tab must be selected/active

Followed test plan and tab now shows as active.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 270a408949e69b97aff87a208a559c4736e20426)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 1d9377b11a509b7e273aa71545a4181b04804ab1)
Signed-off-by:

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-44-g748b2b3

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  748b2b332533132749878e505cd9b480c98426fa (commit)
  from  f7088ecf4b752f3e61e94ff4738fb04b97d574d2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 748b2b332533132749878e505cd9b480c98426fa
Author: Martin Renvoize 
Date:   Mon Oct 8 08:02:21 2018 +0100

Bug 19500: (rmaint followup) - Add back html filters

I managed to inadvertantly loose the html filters when backporting bug
19500, this just adds them back in.
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-46-g3e77e7a

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  3e77e7a4d6c90e6a14d152af19c46cda6486e7ac (commit)
   via  00422bf33f48c95aac0dc639e42fe958d0de133b (commit)
  from  748b2b332533132749878e505cd9b480c98426fa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3e77e7a4d6c90e6a14d152af19c46cda6486e7ac
Author: Katrin Fischer 
Date:   Thu Sep 27 12:29:08 2018 +0100

Bug 19271: Show vendor name on ordered/spent lists

 Improvements to the display of lists of ordered and received orders:
 - Show the vendor's name instead of the internal number

 To test:
 - Make sure you have some pending and received orders
 - Access the Spent and Ordered pages by clicking on the
   amount ordered or spent on the acq start page
   - Verify that
 - Vendor name shows

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8b1bda9ed8507745b4002199d9aae95c2cbb31fb)
Signed-off-by: Martin Renvoize 

commit 00422bf33f48c95aac0dc639e42fe958d0de133b
Author: Katrin Fischer 
Date:   Fri Aug 10 05:21:56 2018 +0200

Bug 15971: Add biblioitems to available fields for serial claim notices and 
fix notices editor display

This fixes 2 related problems:

1) The editor only offered 3 entries from biblio for adding to the notice:
title, author, serial
It was not clear that actually all fields from biblio can be used.

2) It was not possible to use fields from biblioitems in the notices
which left out important fields like the ISSN.

The patch adds the biblioitems table and changes the editor to show
all entries from biblio and biblioitems table are shown on the left.

To test:
- Create a subscription
- Generate next issue a few times to get late issues
- Create a new notice in the "Claim serial issue" module
  - Use fields from different/all tables
- Make sure an email address is set for
  - the vendor (also check for 'receives claims for late issues')
  - your staff user
- Go to serials > claims
- Claim multiple issues
- Verify the email is generated and contains the correct information

Example notice:

Title: <>
Author: <>
ISSN: <>
ISBN: <>
Issue: <>
--

Signed-off-by: Owen Leonard 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit a002d12888c1e56910a32f28514a59d9a1d9363d)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Letters.pm  |9 +-
 acqui/ordered.pl   |3 +
 acqui/spent.pl |5 +-
 .../intranet-tmpl/prog/en/modules/acqui/ordered.tt |2 +-
 .../intranet-tmpl/prog/en/modules/acqui/spent.tt   |2 +-
 t/db_dependent/Letters.t   |   96 +++-
 tools/letter.pl|   10 +-
 7 files changed, 110 insertions(+), 17 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-47-g1d8a66a

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  1d8a66ad010247c90a8930f4d2b48f96bbfe3b7e (commit)
  from  3e77e7a4d6c90e6a14d152af19c46cda6486e7ac (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 1d8a66ad010247c90a8930f4d2b48f96bbfe3b7e
Author: Jonathan Druart 
Date:   Mon Aug 13 13:23:00 2018 -0300

Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr

What we were doing was wrong and is still wrong. The output_pref should not 
be done
in modules or script, only template side.
Much more work would be needed to clean the situation. This patch provides 
less changes
as possible to, hopefully, not introduce side-effects.

To recreate:
1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds
2 - Set TimeFormat to 12 hour
3 - Find or create a record with two items
4 - Place a hold on one of them
5 - Checkout the other to a different patron
6 - Note the warning message display correct time
7 - Confirm the checkout
8 - Note the item is due at 11:59AM

Signed-off-by: Martin Renvoize 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 11885e75c04fa53cd88daae1ec0dc4a2a8ecd1f7)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Circulation.pm   |4 ++--
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt |4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-53-g2b37db0

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  2b37db0d7dfd6375621edcdbc83e740d3f2f8407 (commit)
   via  78ffca5f32d82b72edb07a6d058a623c41b712dd (commit)
   via  261e30f3e484fe3d49848fb60ea2cc7fbee5 (commit)
   via  b2cf26de21db3055df7d9426dff9860c2bdad8bf (commit)
   via  b3ab0a723a23cb59c241339fa122dae75689c7b0 (commit)
   via  23542b6d310695aa7f0f967cdb4c6bd6273be40b (commit)
  from  1d8a66ad010247c90a8930f4d2b48f96bbfe3b7e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 2b37db0d7dfd6375621edcdbc83e740d3f2f8407
Author: Jonathan Druart 
Date:   Mon Oct 1 18:05:44 2018 -0300

Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted 
patrons

Template process failed: undef error - DBIC result _type  isn't of the
_type Borrower at

/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
line 54.

Koha::Old::Checkout->patron should return undef if the patron record has
been removed.

Test plan:
- Check 2 items out on the same bibliographic record
- Check them in
- Delete the patron's record of one of the issuer (Is this word really
exist?)
- View the checkout history for this bib record (Home › Catalog ›
Checkout history)
=> Without this patch you get the error
=> With this patch applied one of the "Patron" cells will be empty

Signed-off-by: Claudio 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit 7fbd50e3aa07e46f0558d4f52231896937c998bc)
Signed-off-by: Martin Renvoize 

commit 78ffca5f32d82b72edb07a6d058a623c41b712dd
Author: Jonathan Druart 
Date:   Mon Oct 1 11:38:04 2018 -0300

Bug 21385: Define the Koha object class for orders

It fixes the following issue:
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. 1/40 Can't
locate object method "_new_from_dbic" via package "Koha::Aqorder"
(perhaps you forgot to load "Koha::Aqorder"?) at
/home/vagrant/kohaclone/Koha/Object.pm line 230.

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit b3dee0daf29c4593aee2781307853845a6cd3735)
Signed-off-by: Martin Renvoize 

commit 261e30f3e484fe3d49848fb60ea2cc7fbee5
Author: Martin Renvoize 
Date:   Mon Sep 24 13:33:59 2018 +0100

Bug 21385: (follow-up) make query consistent

The expected items query wasn't consistent with other queries in this
module with regards to identifying cancelled orders

Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 5e6f4f1f4fb346351dcfc6c580888022641d4b6a)
Signed-off-by: Martin Renvoize 

commit b2cf26de21db3055df7d9426dff9860c2bdad8bf
Author: Martin Renvoize 
Date:   Mon Sep 24 13:23:25 2018 +0100

Bug 21385: Add Unit Tests

Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 3f20c8c65172c1a32e7d2b20ed2506199423f103)
Signed-off-by: Martin Renvoize 

commit b3ab0a723a23cb59c241339fa122dae75689c7b0
Author: Martin Renvoize 
Date:   Fri Sep 21 15:10:15 2018 +0100

Bug 21385: Correctly count all items in basket for booksellers list

To reproduce:

1) Create a basket with 2 biblios, one with 2 items and one with 1 item
2) Search for vendors and note the basket above should contain 'Item
count 3', 'Biblio count 2', 'Items expected 3'
3) Receive shipment, and only receive 1 of the items on the biblio with
2 items above.
4) Search for vendors and note that the 'Item count' for the basket
above is now '2'.

The item count for a closed basket should remain the same and should
differ from the 'items expected' count some items have been recieved.

Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Jonathan Druart 
Amended patch:
FAIL   C4/Acquisition.pm
   FAIL   spelling
 RECIEVED  ==> RECEIVED

Signed-off-by: Nick Clemens 
(cherry picked from commit 17db3ab05cb25d08f0790cff9eed5f0f75ca8107)
Signed-off-by: Martin Renvoize 

commit 23542b6d310695aa7f0f967cdb4c6bd6273be40b
Author: Jonathan Druart 
Date:   Sat Sep 29 16:04:56 2018 -0300

Bug 21448: Fix copy repeated subfields when linking an authority with 6xx

The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"

Error i

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-59-gce34d88

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ce34d88099c72821bd9033130aa09fc0c3d7302a (commit)
   via  291c250dcfe23c046f3b5df419b8819fb92cbcf3 (commit)
   via  c6f2599b974e5c168da4f551021543e2e46dda29 (commit)
   via  ee19e31ce05c927cff3505171eb9d7e68bfdd7bb (commit)
   via  a3f097958cae68e4f3f16c8eb5aa5411d2488bc2 (commit)
   via  24e2d2d9c46772804ee1904ec7ab3e80a8bf9d28 (commit)
  from  2b37db0d7dfd6375621edcdbc83e740d3f2f8407 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ce34d88099c72821bd9033130aa09fc0c3d7302a
Author: Jonathan Druart 
Date:   Thu Feb 22 11:19:50 2018 -0300

Bug 20287: Koha::Object->get_from_storage

May be part of a separate bug report if needed

TODO - add POD + tests

Signed-off-by: Josef Moravec 

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 1144ee4b819e01ebad890f562d2754cda8d4e3ad)
(rmaint comment - backported get_from_storage as it's required by new
tests added to bug 21385 - Correctly count all items in basket for
booksellers list)
Signed-off-by: Martin Renvoize 

commit 291c250dcfe23c046f3b5df419b8819fb92cbcf3
Author: Mark Tompsett 
Date:   Wed Apr 25 16:44:03 2018 +

Bug 17237: Remove CREATE USER 'user'@'%' line

Having a 'user'@'%' line decreases database security.
Bug 16690 closes the need for such a line, and this
bug removes the use of it.

TEST PLAN
-
While this depends on 16690, it is not required for testing.

On a kohadev box:
sudo koha-create --create-db test_17237_a
git bz apply 17237
sudo perl ~/misc4dev/cp_debian_files.pl
restart_all
sudo systemctl daemon-reload
sudo koha-create --create_db test_17237_b
sudo mysql -u root
SELECT user,host from mysql.user;
-- test_17237_a will have two entries, one being '%'
-- test_17237_b will only have one entry, not '%'

Signed-off-by: Martin Renvoize 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

(cherry picked from commit 1e856e7e7316749f59cb4e721e352b0a60237def)

Signed-off-by: Martin Renvoize 

commit c6f2599b974e5c168da4f551021543e2e46dda29
Author: Kyle M Hall 
Date:   Mon Oct 1 14:05:40 2018 -0400

Bug 21352: Add missing USE statements

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 
(cherry picked from commit ff1b0ba7cae7ee72d1fc4ab0c2d1a1e1b40ac7fe)
Signed-off-by: Martin Renvoize 

commit ee19e31ce05c927cff3505171eb9d7e68bfdd7bb
Author: Kyle M Hall 
Date:   Sat Sep 15 09:48:49 2018 -0700

Bug 21352: Allow plugins to add CSS and Javascript to Staff interface

We should have plugin hooks for the staff interface just like we have for 
the OPAC as detailed on bug 20181.

Test Plan:
1) Apply this patch
2) Download and install the Kitchen Sink plugin ( v2.1.19 or later )
   
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.19/koha-plugin-kitchen-sink-v2.1.19.kpz
3) Install the plugin
4) Restart all the things if you can ( restart_all if you are using 
kohadevbox )
   This will ensure the plugin takes effect right away, it should be
   necessary but it won't hurt anything!
5) Load the staff intranet, notice you get an console error log message and 
the background
   for your staff intranet is now orange ( assuming you've not customized 
the
   staff intranet in any way )

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 
(cherry picked from commit a37637e30357258885e9d0c1c7a30366869dcb08)
Signed-off-by: Martin Renvoize 

commit a3f097958cae68e4f3f16c8eb5aa5411d2488bc2
Author: Magnus Enger 
Date:   Thu Sep 6 13:23:17 2018 +

Bug 21322: process_message_queue.pl --type should take an argument

The help for this script says:
-t --type: If supplied, only processes this type of message ( email, sms )

Currently, the type argument is set up wrong, so it does not look
for an argument. This patch fixes that.

To test, run this command (should work in kohadevbox) or something
similar:

$ sudo koha-shell -c "perl \
/home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \
--type=sms" kohadev

This should give the following error: "Option type does not take an 
argument".
Apply the patch and run the same command again. This should not give an

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-60-gb34946b

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  b34946b01740ed584571a1acbd3b9de7c0ada7ac (commit)
  from  ce34d88099c72821bd9033130aa09fc0c3d7302a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b34946b01740ed584571a1acbd3b9de7c0ada7ac
Author: Martin Renvoize 
Date:   Mon Oct 8 13:46:15 2018 +0100

Bug 21352: (qa followup) - correction to testplan

Signed-off-by: Martin Renvoize 

---

Summary of changes:
 t/db_dependent/Plugins.t |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-933-gcc52094

2018-10-08 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  cc52094f208d78fd06d888975f4710de0886c7a7 (commit)
  from  e78af533df94b155570116f6f7c4b5a2e5e4e2f2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit cc52094f208d78fd06d888975f4710de0886c7a7
Author: Martin Renvoize 
Date:   Mon Oct 8 13:46:15 2018 +0100

Bug 21352: (QA follow-up) - correction to testplan

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 t/db_dependent/Plugins.t |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-27-gb8ee0a2

2018-10-09 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  b8ee0a2cf5e9e35c948b46365c969e20434d1f36 (commit)
   via  1ad94323f73fda8b6998955b0779fdde752be2a8 (commit)
  from  cc22607d83961f0a07ec2596aa96131632f68363 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b8ee0a2cf5e9e35c948b46365c969e20434d1f36
Author: Katrin Fischer 
Date:   Mon Apr 23 04:15:56 2018 +

Bug 20616: (QA follow-up) Make alert translatable

Signed-off-by: Jonathan Druart 
(cherry picked from commit 582d566aac5af0dbb065b9f057e43eb5ccb19a1a)
Signed-off-by: Fridolin Somers 

commit 1ad94323f73fda8b6998955b0779fdde752be2a8
Author: Jonathan Druart 
Date:   Mon Apr 23 16:19:50 2018 -0300

Bug 20616: Prevent "edit serials" form submission if no serial is selected

In order to prevent the form to submit and gives an ugly error if no
issues are selected we will make sure at least one is checked otherwise
an alert will be displayed.

Test plan:
- create a subscrpition
- go to the serials collection page
- don't check any checkboxes for serials
- click 'Edit serials'

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 
(cherry picked from commit e14ee4ad0a033354052726ff401f8ee4f64dd2b9)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 .../prog/en/modules/serials/serials-collection.tt |9 +
 1 file changed, 9 insertions(+)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-987-g01646f9

2018-10-09 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  01646f974355f48a97ca61936cf3a787f6077af2 (commit)
   via  06e4af6ba8baf412e6adca5ef386255e31f2ead3 (commit)
   via  d87bffa0911e21def994018977e667e028e0c4aa (commit)
   via  2f2e40ca4674449c598799b1a47d156e50b91fa0 (commit)
   via  97acf28fef5f95f0e32c4319f7d9781c5522b79b (commit)
   via  7ce34d94caf3a0e64eafe0aedbedd5baaa255124 (commit)
   via  f72002d9979771fd9913e5f3c0f89ecb2a4311f4 (commit)
   via  fac27bc029245aaf08b377ab86c9d23227135014 (commit)
   via  513aa79a5bf1f3db49288ebaafe372fc8ff7b7ab (commit)
   via  b2ff7223b795f138d74606becc8ccb6b7c1e305d (commit)
   via  732ff4b1c6c46dfcd9c71943f62f33a1e6484608 (commit)
   via  2bcaa4004c2a1e06dc02a342d2950ad7df75ada3 (commit)
   via  a9248f237d9de916e504d59e6490c7f84e9eb763 (commit)
   via  b8d425ac35eca05a5a3217b1678dfccc25aa3c26 (commit)
   via  a21025b7d9c7b2aa09ad6e4851f10c7c41d8d8bd (commit)
   via  85be5a81883b9b8d7d071ec39e63021d504a75de (commit)
   via  5088e3084dad6c66cb3f3a2e6127e98974dc81b6 (commit)
   via  58314233f70fd9fd2f2830250ff0362e369b6ff1 (commit)
   via  8a2c5344d7910d60e0f04ca531e17250753755a7 (commit)
   via  63fdde7a9fd627c4692080e5bccd0cfe6d905c29 (commit)
   via  7e6a24b98a8775543df0f59d3e128ec22be2ac81 (commit)
   via  82db1e1589f2d3f3f92dcab2fba7fce1fc26f2d9 (commit)
   via  b3d0bef13650d830b2a3d832a404c2847e727166 (commit)
   via  4febf0656c202affa6aecba0241bfd13f89f19fd (commit)
   via  7ce770ddc5d4caed4abd7c3026ea18a1dfdfbbdd (commit)
   via  897711bd473a2949cea3456d04f7c8d5302d9ad4 (commit)
   via  ea74ed57660219caeb3fb5512b03fc2109b292de (commit)
   via  ffca9decadf539018e447237e56bce76c81bdd64 (commit)
   via  967e20570026f4208bbc2894cf770ec3fa94287f (commit)
   via  dc2d6ed056405deb444559d2071ff1e2637caee7 (commit)
   via  78a692dee4523d04986ec394442c3a6d80ea0771 (commit)
   via  b27db0fbfc0b715df1b63c57228a9945d4834f29 (commit)
   via  e6bf76b9c712913e549f43a30830ea612c73befa (commit)
   via  ad35c9702eb1da9bec331312701e71ce6ab5cf91 (commit)
   via  96c2df5804ce3ac84e5963d6b9764553a97a6978 (commit)
   via  40803d30359f347417999429b612fcece9fc96f9 (commit)
   via  074c329774adb7b23f85293a7f6d146c0d989f99 (commit)
   via  cf8890465d32d780e4177438d9b6ae807b1df36d (commit)
   via  d70daacebae50fde8449f4cec2bb4578747610fc (commit)
   via  18674cfde322c52fafb3114b397bb1ebe7941b97 (commit)
   via  6cee98c04fce2129de21c65c9e0c407a508df9bd (commit)
   via  6152bad79504f28bc1eaffdffa549c4633c922ff (commit)
   via  4915fc68b754fb7beb52a0bf740a838237e6b9ff (commit)
   via  fb6fb4ad53702e51b678e43c9bcf695041845610 (commit)
   via  f161d4e823aa84d7c602089eacacbdf2bfc502ce (commit)
   via  88c29de46558f974ae10a6d25096cf531f7ee0a0 (commit)
   via  09a7d37d53a87e35f2151e00200995ab3dfa3896 (commit)
   via  d83d5ec5a4edfc4927a5f8e5ca3d1cde2942f5fe (commit)
   via  91790fdd90c8dc59b70f6defd63b088febf5b39d (commit)
   via  e762bdb9b2243070fd33e9aeb1bdfb88f2af2193 (commit)
   via  df339d0372c633635bc63d87d7caa7807a540aed (commit)
   via  67d13dc5867e813efad430c6352657e459259bab (commit)
   via  f27787d364ae080ce6a815ba07e8813fce48b2da (commit)
   via  f12dabe6ccd9400a4ae744a5d74bbddcd9f7ac95 (commit)
  from  cc52094f208d78fd06d888975f4710de0886c7a7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 01646f974355f48a97ca61936cf3a787f6077af2
Author: Nick Clemens 
Date:   Tue Oct 9 16:12:59 2018 +

Bug 7143: (follow-up) remove trailing apostrophe

Signed-off-by: Nick Clemens 

commit 06e4af6ba8baf412e6adca5ef386255e31f2ead3
Author: Martin Renvoize 
Date:   Tue Sep 4 14:34:14 2018 +0100

Bug 11897: Add Boolean handling to dbic classes.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

commit d87bffa0911e21def994018977e667e028e0c4aa
Author: Alex Sassmannshausen 
Date:   Fri Dec 9 09:47:02 2016 +0100

Bug 11897: DBIX::Class::Ordered in Stockrotationstage.

* Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add
  grouping_column.

Signed-off-by: Kathleen Milne 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

commit 2f2e40ca4674449c598799b1a47d156e50b91fa0
Author: Nick Clemens 
Date:   Tue Oct 9 15:51:34 2018 +

Bug 11897: DBRev 18.06.00.040

Signed-off-by: Nick Clemens 

commit 97acf28fef5f95f0e32c4319f7d9781c5522b79b
Author: Martin Renvoize 
Date:   Tue Oct 9 15:03:23 2018 +0100

   

[koha-commits] main Koha release repository branch master updated. v18.05.00-989-gf11cb49

2018-10-09 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  f11cb49a3682221b5e72de03a8627e14d879d1c0 (commit)
   via  216a8f1d0301093d7bd90c1a13d10ebd03d23d6b (commit)
  from  01646f974355f48a97ca61936cf3a787f6077af2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f11cb49a3682221b5e72de03a8627e14d879d1c0
Author: Jonathan Druart 
Date:   Tue Oct 9 14:11:28 2018 -0300

Bug 11897: Add mising semi-colon to user*.sql

Signed-off-by: Nick Clemens 

commit 216a8f1d0301093d7bd90c1a13d10ebd03d23d6b
Author: Jonathan Druart 
Date:   Tue Oct 9 14:08:33 2018 -0300

Bug 11897: (follow-up) Add Stock Rotation atomic update schema

Remove the duplicate entry for RoutingListAddReserves
I guess it has been caused by a bad merge resolution conflict

Signed-off-by: Nick Clemens 

---

Summary of changes:
 installer/data/mysql/sysprefs.sql|1 -
 installer/data/mysql/userflags.sql   |2 +-
 installer/data/mysql/userpermissions.sql |2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-34-gf5eb412

2018-10-10 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  f5eb412f34816cb251f621852c9ef843856f298e (commit)
   via  cf12d9ba72be3c4f41d3eb7d640e968fca129ffa (commit)
   via  8f13b25a177fdd46453fecb38511809792469364 (commit)
   via  bde08fa3661b895fc7881bd1523c36761c4667d9 (commit)
   via  2905a9e16850a089339943a65fcfadadceabe0f0 (commit)
   via  f13910a1f7307ea2851cab5e3f1cfa444aba3beb (commit)
   via  10eb6cb65ebd917bf34872fb3efe98e7a37648fe (commit)
  from  b8ee0a2cf5e9e35c948b46365c969e20434d1f36 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f5eb412f34816cb251f621852c9ef843856f298e
Author: Jonathan Druart 
Date:   Tue Jul 31 15:24:10 2018 -0300

Bug 21133: [18.05.x] Fix use statements order

Basically the idea is:
1. Undefined subroutine &C4::Items::ModZebra called at 
/home/vagrant/kohaclone/C4/Items.pm line 302.

=> Then use C4::Items before C4::Biblio

2. Undefined subroutine &C4::Circulation::GetItem called at 
/home/vagrant/kohaclone/C4/Circulation.pm line 1290

=> Then use C4::Circulation before C4::Items

And sometimes these 2 rules do not work...

Signed-off-by: Martin Renvoize 
(cherry picked from commit 6427906fcccea22327db3c1d78847fed5ba9e7fb)
Signed-off-by: Fridolin Somers 

commit cf12d9ba72be3c4f41d3eb7d640e968fca129ffa
Author: Pasi Kallinen 
Date:   Fri Aug 24 11:05:04 2018 +0300

Bug 20785: Advanced Editor does not honor MarcFieldDocURL

The advanced MARC editor, Rancor, doesn't obey MarcFieldDocURL.
Make it do so.

Test plan:

1) Enable EnableAdvancedCatalogingEditor
2) Set MarcFieldDocURL to eg. http://{MARC}.example.com/{LANG}/{FIELD}
3) Go to Cataloging -> Advanced editor
4) Go to any field and press Ctrl-H
5) Marc field documentation on www.loc.gov or ifla.org should open
6) Apply patch
7) Repeat 3 and 4. The Marc field docs should open on the URL you set

Signed-off-by: Pasi Kallinen 
Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit ca839922fd4bf3c455454f6dd9182203b1481831)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 0f2d80328d74c661ecd318f603a18743e3c699bb)
Signed-off-by: Fridolin Somers 

commit 8f13b25a177fdd46453fecb38511809792469364
Author: Nick Clemens 
Date:   Sat Jul 14 14:29:53 2018 +

Bug 21078: overdrive.js Catch error if window.opener is not accessible

To Test:
0 - Enable overdrive search results on your koha
1 - From a source develop a link to your koha instance that opens a new
window:
http://localhost:8080/cgi-bin/koha/opac-search.pl?q=love";>Test
2 - Click that link
3 - Note Overdrive results do not load
4 - Note error in JS console
5 - Apply patch
6 - Click the link again
7 - Note OD results load
8 - Note no error in console

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6975a6836a21f42675a9394602246891c19d9522)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 20b0ca1f63c6ad97a05476236036996058b784c2)
Signed-off-by: Fridolin Somers 

commit bde08fa3661b895fc7881bd1523c36761c4667d9
Author: Katrin Fischer 
Date:   Sat Aug 11 23:55:35 2018 +

Bug 20241: Fix display of publication year in subscription record search 
for MARC21

The old problem: UNIMARC uses biblio.publicationyear, MARC21 uses
biblio.copyrightdate. Patch adds a fallback, if there is nothing
in publicationyear, copyrightdate will be displayed.

To test:
  - In a MARC21 database
  - Add a new subscription
  - Search for records
  - Verify the publication year column remains empty
  - Apply patch
  - Repeat search
  - Verify that the year now shows

https://bugs.koha-community.org/show_bug.cgi?id=20421

Signed-off-by: Michal Denar 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8df47bdde678773f028f312b4cd8000a12425281)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 419f889bb0e0220d81b9883d27aeea128a5b)
Signed-off-by: Fridolin Somers 

commit 2905a9e16850a089339943a65fcfadadceabe0f0
Author: Ere Maijala 
Date:   Fri Oct 13 14:07:21 2017 +0300

Bug 21362: Advanced editor: Fix tab navigation in fixed fields

Also minor tweaks to how the fields look.

Test plan:

1. Try moving from field to field an

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-35-g42046e9

2018-10-10 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  42046e95ab8b9b33311c29c3611054343e0d0e68 (commit)
  from  f5eb412f34816cb251f621852c9ef843856f298e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 42046e95ab8b9b33311c29c3611054343e0d0e68
Author: Fridolin Somers 
Date:   Wed Oct 10 14:22:01 2018 +0200

Bug 21133: [17.11] RMaint fixup

---

Summary of changes:
 t/db_dependent/Items.t |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-61-gb56e354

2018-10-10 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  b56e354bf0ef37461916c9cdcea9d63cbca99959 (commit)
  from  b34946b01740ed584571a1acbd3b9de7c0ada7ac (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit b56e354bf0ef37461916c9cdcea9d63cbca99959
Author: Martin Renvoize 
Date:   Wed Oct 10 14:21:23 2018 +0100

Bug 5458: (rmaint follow-up) Fix for typo in DBRev

Signed-off-by: Martin Renvoize 

---

Summary of changes:
 installer/data/mysql/updatedatabase.pl |1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-44-gd9d868b

2018-10-11 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  d9d868b911d1ba18c2bac1993e407168164df168 (commit)
   via  6c45261cb4b9453e5ec189340da0e6495a4d2663 (commit)
   via  181e84814771dff45d523de73e8972d7c0150987 (commit)
   via  4c9711e16686476b65d7ee56e850da45bc2c2807 (commit)
   via  17aef6ad28229ec68176246a06a3d8291d1618ef (commit)
   via  232a7a30666cc3082ae4e7b6b4828aef3e9c0039 (commit)
   via  d951f0906b4edf0543be89b657e9f7bf24b9fa90 (commit)
   via  b60e0ca2885817446d6649e4250bbf6af7fa75d4 (commit)
   via  f2f10001fc3487b003b90e7d8ba00bbfe3ec0a89 (commit)
  from  42046e95ab8b9b33311c29c3611054343e0d0e68 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit d9d868b911d1ba18c2bac1993e407168164df168
Author: Katrin Fischer 
Date:   Fri Aug 10 05:21:56 2018 +0200

Bug 15971: Add biblioitems to available fields for serial claim notices and 
fix notices editor display

This fixes 2 related problems:

1) The editor only offered 3 entries from biblio for adding to the notice:
title, author, serial
It was not clear that actually all fields from biblio can be used.

2) It was not possible to use fields from biblioitems in the notices
which left out important fields like the ISSN.

The patch adds the biblioitems table and changes the editor to show
all entries from biblio and biblioitems table are shown on the left.

To test:
- Create a subscription
- Generate next issue a few times to get late issues
- Create a new notice in the "Claim serial issue" module
  - Use fields from different/all tables
- Make sure an email address is set for
  - the vendor (also check for 'receives claims for late issues')
  - your staff user
- Go to serials > claims
- Claim multiple issues
- Verify the email is generated and contains the correct information

Example notice:

Title: <>
Author: <>
ISSN: <>
ISBN: <>
Issue: <>
--

Signed-off-by: Owen Leonard 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit a002d12888c1e56910a32f28514a59d9a1d9363d)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 00422bf33f48c95aac0dc639e42fe958d0de133b)
Signed-off-by: Fridolin Somers 

commit 6c45261cb4b9453e5ec189340da0e6495a4d2663
Author: Colin Campbell 
Date:   Thu Sep 27 12:25:28 2018 +0100

Bug 21425: Display basketno correctly in Order error msg

carp will display the hash value instead of the desired basketno
in the error message unless we change its behaviour

Use the simpler but effective option of concatenating
the errormessage with the basketno. Error is shown if no
sender or receipient ean is passed in instantiating
an Koha::Edifact::Order object

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit e81756b317da848a6e6346a7c0db8f3b986f7058)
Signed-off-by: Martin Renvoize 
(cherry picked from commit f7088ecf4b752f3e61e94ff4738fb04b97d574d2)
Signed-off-by: Fridolin Somers 

commit 181e84814771dff45d523de73e8972d7c0150987
Author: Mark Tompsett 
Date:   Wed Sep 26 22:57:32 2018 +

Bug 13272: (follow-up) add missing type="text"

This addresses comment #13.
This also applies cleanly.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 623f1db90ac8d0361a879813c66a4bccbf0ea23e)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 721cefdb95ba6d3f8fb59f6b02255cd76d8a3fbf)
Signed-off-by: Fridolin Somers 

commit 4c9711e16686476b65d7ee56e850da45bc2c2807
Author: Mark Tompsett 
Date:   Wed Sep 19 18:49:02 2018 +

Bug 13272: (follow-up) Replace tabs with spaces

Cleaned up whitespace issues tab vs. space in template.
After applying all patches:
git diff -w origin/master
For the koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
only the changed type="text" lines will show, but without the
-w, there will be more whitespace changes.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 5edd363a1f2e3b1ea34f3f2aa7ace86cbf467df8)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 73b197df9ed8e038684e1821ab4d9090d7af225a)
Signed-off-by: Fridolin Somers 

commit 17aef6ad28229ec68176246a06a3d8291d1618ef
Author: Mark 

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-46-g9444691

2018-10-11 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  94446917946de314302345f0b28503fcbea38c70 (commit)
   via  13c7f876c0935f048eba41b852722342f3c520b8 (commit)
  from  d9d868b911d1ba18c2bac1993e407168164df168 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 94446917946de314302345f0b28503fcbea38c70
Author: Jonathan Druart 
Date:   Mon Aug 13 13:23:00 2018 -0300

Bug 21176: Fix due date calculation when high holds and TimeFormat is 12hr

What we were doing was wrong and is still wrong. The output_pref should not 
be done
in modules or script, only template side.
Much more work would be needed to clean the situation. This patch provides 
less changes
as possible to, hopefully, not introduce side-effects.

To recreate:
1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds
2 - Set TimeFormat to 12 hour
3 - Find or create a record with two items
4 - Place a hold on one of them
5 - Checkout the other to a different patron
6 - Note the warning message display correct time
7 - Confirm the checkout
8 - Note the item is due at 11:59AM

Signed-off-by: Martin Renvoize 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 11885e75c04fa53cd88daae1ec0dc4a2a8ecd1f7)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 1d8a66ad010247c90a8930f4d2b48f96bbfe3b7e)
Signed-off-by: Fridolin Somers 

commit 13c7f876c0935f048eba41b852722342f3c520b8
Author: Katrin Fischer 
Date:   Thu Sep 27 12:29:08 2018 +0100

Bug 19271: Show vendor name on ordered/spent lists

 Improvements to the display of lists of ordered and received orders:
 - Show the vendor's name instead of the internal number

 To test:
 - Make sure you have some pending and received orders
 - Access the Spent and Ordered pages by clicking on the
   amount ordered or spent on the acq start page
   - Verify that
 - Vendor name shows

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8b1bda9ed8507745b4002199d9aae95c2cbb31fb)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 3e77e7a4d6c90e6a14d152af19c46cda6486e7ac)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 C4/Circulation.pm   |4 ++--
 acqui/ordered.pl|3 +++
 acqui/spent.pl  |5 -
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt|2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt  |2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt |4 ++--
 6 files changed, 13 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-991-g3c21058

2018-10-12 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  3c210589f8e72bcd2241e348226e8d608061e1f3 (commit)
   via  ef769ea33276313a47d5b343edc748f538927671 (commit)
  from  f11cb49a3682221b5e72de03a8627e14d879d1c0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3c210589f8e72bcd2241e348226e8d608061e1f3
Author: Jonathan Druart 
Date:   Fri Oct 12 11:18:17 2018 -0300

Bug 21553: Remove JS error on the Rota view

JS error was:
 ReferenceError: _ is not defined

The strings after staff-global.js (for the function _)

Test plan:
Turn on StockRotation system preference

1) Go to a staff detail page
2) Switch to rota page
3) Check web developer tools

Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

commit ef769ea33276313a47d5b343edc748f538927671
Author: Mirko Tietgen 
Date:   Wed Oct 10 16:17:17 2018 +0200

Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than 
scheduled

t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
if WebService::ILS is not available.

Test plan:
- have a system without Webservice::ILS available
- in koha-shell, do
  prove t/Koha_ExternalContent_RecordedBooks.t
- tests should be skipped and tests count as "passed"

Signed-off-by: Jonathan Druart 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt |2 +-
 t/Koha_ExternalContent_RecordedBooks.t |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-994-gbe4f22f

2018-10-12 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  be4f22f5a0745ef64c6bf20b89bd9f4fcbe40403 (commit)
   via  45fbd36e1f2e1aa622eec1ba588424cc50243fb3 (commit)
   via  2cd49034c43a16c7497f05e94c18396532fceddc (commit)
  from  3c210589f8e72bcd2241e348226e8d608061e1f3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit be4f22f5a0745ef64c6bf20b89bd9f4fcbe40403
Author: Jonathan Druart 
Date:   Fri Oct 12 15:37:44 2018 -0300

Bug 21479: Remove the trace if the node does not exist

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

commit 45fbd36e1f2e1aa622eec1ba588424cc50243fb3
Author: Jonathan Druart 
Date:   Tue Oct 9 13:30:54 2018 -0300

Bug 21479: Add regression tests

Signed-off-by: Jonathan Druart 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

commit 2cd49034c43a16c7497f05e94c18396532fceddc
Author: Owen Leonard 
Date:   Wed Oct 3 14:13:49 2018 +

Bug 21479: Fix remove from cart links at the OPAC (should remove only 1)

This patch changes the way biblionumbers are passed to the cart script
for adding and removing single items. The title's biblionumber is now
stored in a data-attribute on the links for adding and removing. This
should be a more robust, unified way to handle these single-item
operations.

To test, apply the patch and enable the opacbookbag system preference.

Test adding and removing items from the cart from various pages using
various methods:

 - By clicking an "Add to your cart" / "Remove" link in search results
 - By clicking an "Add to your cart" / "Remove" link on a detail page
 - By checking boxes in search results and adding via the dropdown

Each operation should work correctly.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 

---

Summary of changes:
 .../bootstrap/en/includes/opac-bottom.inc  |   17 ++-
 .../bootstrap/en/includes/opac-detail-sidebar.inc  |4 +--
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |4 +--
 koha-tmpl/opac-tmpl/bootstrap/js/basket.js |5 +++-
 t/db_dependent/selenium/regressions.t  |   31 ++--
 5 files changed, 47 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-995-g56ab537

2018-10-12 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  56ab53702013f36c7f174e1a219b7b450098412a (commit)
  from  be4f22f5a0745ef64c6bf20b89bd9f4fcbe40403 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 56ab53702013f36c7f174e1a219b7b450098412a
Author: Owen Leonard 
Date:   Wed Oct 10 16:44:10 2018 +

Bug 20260: Use CodeMirror for the SQL reports editor

This patch adds CodeMirror syntax highlighting to the SQL reports
editor. Newly added is a file containing the sql-specific syntax
highlighting code, in both compressed and uncompressed versions.

Unrelated changes:

 - Some JavaScript has been moved from inside the body of the page to
   the footer.
 - Paths to some assets have been corrected to no use relative paths.

To test, apply the patch and go to Reports -> Saved SQL reports

- Edit an existing report and confirm that the SQL is correctly
  highlighted and that there are no display problems when editing.
- Confirm that changes are saved successfully.
- Perform the same test when creating a new SQL report.
- View an existing report and confirm that the SQL is syntax-highlighted
  but is read-only.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/lib/codemirror/sql.js  |  501 
 koha-tmpl/intranet-tmpl/lib/codemirror/sql.min.js  |2 +
 .../en/modules/reports/guided_reports_start.tt |   40 +-
 3 files changed, 535 insertions(+), 8 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/sql.js
 create mode 100644 koha-tmpl/intranet-tmpl/lib/codemirror/sql.min.js


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-1014-g511ffe4

2018-10-13 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  511ffe470066a34b8d24ee9f1c6b8238306c2bf0 (commit)
   via  3516e9a9f85e394e1ed683064823acf473ea2088 (commit)
   via  64740898aa346feda1363c9c4b5cb52be0bba7f1 (commit)
   via  b097c695221da429b377f780f5a4619ab528ed88 (commit)
   via  925f4ca1da780255163231a9d90cfe2e5424b943 (commit)
   via  e24099cbbce1c41d5d696f6b215ca6286f0fce68 (commit)
   via  a1b4941ab85431c75d916c1cd4d9c6200e25e6f4 (commit)
   via  00178268cabfc18647a1af3704a451ac7000731d (commit)
   via  300b12a37d7f392b0307952f9e355baadab47d7d (commit)
   via  731f83a85e0687c4a11fe38b629990bc4639ae3f (commit)
   via  ecc5acf653e160fdda14c1a53877f4015d6aaa6e (commit)
   via  feefbb504f93393855c63be855ec47974744a0a6 (commit)
   via  ec49e7d83bcbfa16dca9f05c36e600ba5c02a2ee (commit)
   via  c7299bc773cdd51950348a32eabeb42930c3c2f5 (commit)
   via  4a7c6fa10ce19414f2157ca6a1fe4d06a2a14c4c (commit)
   via  c28d62ce91f3cfdf4384529d11bd896faa6ddbcd (commit)
   via  0e81b387ca987ee439ca1387df535b2eace6cbcb (commit)
   via  07fa37abbe325e136cd84f2dd5e1971d64c20d65 (commit)
   via  8a8c0ae51e2b1128942f6dff5ca022433355314e (commit)
  from  56ab53702013f36c7f174e1a219b7b450098412a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 511ffe470066a34b8d24ee9f1c6b8238306c2bf0
Author: Tomas Cohen Arazi 
Date:   Sat Oct 13 08:05:34 2018 -0300

Bug 20772: (QA follow-up) 'readonly' is a boolean

Signed-off-by: Tomas Cohen Arazi 

commit 3516e9a9f85e394e1ed683064823acf473ea2088
Author: Tomas Cohen Arazi 
Date:   Sat Oct 13 07:47:12 2018 -0300

Bug 20772: DBRev 18.06.00.041

Signed-off-by: Tomas Cohen Arazi 

commit 64740898aa346feda1363c9c4b5cb52be0bba7f1
Author: Andrew Isherwood 
Date:   Mon Oct 8 17:48:39 2018 +0100

Bug 20772: (follow-up) Add unit test

Add unit test for price_paid

Signed-off-by: Tomas Cohen Arazi 

commit b097c695221da429b377f780f5a4619ab528ed88
Author: Katrin Fischer 
Date:   Fri Oct 5 13:38:26 2018 +0200

Bug 20772: (QA follow-up) Add a missing html filter

Signed-off-by: Tomas Cohen Arazi 

commit 925f4ca1da780255163231a9d90cfe2e5424b943
Author: Andrew Isherwood 
Date:   Fri Oct 5 11:56:31 2018 +0100

Bug 20772: (follow-up) Fix DB updates and templates

Carry out changes requested in commenbt #27

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit e24099cbbce1c41d5d696f6b215ca6286f0fce68
Author: Barry Cannon 
Date:   Tue Jul 24 15:56:30 2018 +0100

Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit a1b4941ab85431c75d916c1cd4d9c6200e25e6f4
Author: Andrew Isherwood 
Date:   Mon May 21 10:40:59 2018 +0100

Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit 00178268cabfc18647a1af3704a451ac7000731d
Author: Andrew Isherwood 
Date:   Thu May 17 11:36:50 2018 +0100

Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit 300b12a37d7f392b0307952f9e355baadab47d7d
Author: Andrew Isherwood 
Date:   Thu May 17 11:29:49 2018 +0100

Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit 731f83a85e0687c4a11fe38b629990bc4639ae3f
Author: Andrew Isherwood 
Date:   Thu May 17 10:58:02 2018 +0100

Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit ecc5acf653e160fdda14c1a53877f4015d6aaa6e
Author: Andrew Isherwood 
Date:   Thu May 17 10:47:52 2018 +0100

Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit feefbb

[koha-commits] main Koha release repository branch master updated. v18.05.00-1018-g3950dd4

2018-10-13 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  3950dd4f6c42a865a584bad3fea2d81e0282dcc1 (commit)
   via  7da41e430d2322b99d61ab0c26a720eeea1a4985 (commit)
   via  dd91fa17124b4432321ac4f64099a225623521bb (commit)
   via  8bacf1935d5100c3616109d11fd03c8025a998a2 (commit)
  from  511ffe470066a34b8d24ee9f1c6b8238306c2bf0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3950dd4f6c42a865a584bad3fea2d81e0282dcc1
Author: Katrin Fischer 
Date:   Fri Oct 5 12:18:11 2018 +

Bug 20797: (QA follow-up) Fix ill requests table

... by adding a missing comma.

Signed-off-by: Tomas Cohen Arazi 

commit 7da41e430d2322b99d61ab0c26a720eeea1a4985
Author: Andrew Isherwood 
Date:   Thu Jun 7 11:14:50 2018 +0100

Bug 20797: (follow-up) Conditionally link

We don't want to display the link to the biblio if the biblio_id is null

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit dd91fa17124b4432321ac4f64099a225623521bb
Author: Andrew Isherwood 
Date:   Wed May 23 12:26:25 2018 +0100

Bug 20797: Add link to biblio detail view from ILL detail view

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

commit 8bacf1935d5100c3616109d11fd03c8025a998a2
Author: Mirko Tietgen 
Date:   Thu Oct 11 16:21:41 2018 +0200

Bug 17084: Automatic debian/control updates (unstable/master)

I added libwebservice-ils-perl 0.17 to the repository, so it
goes into debian/control too.

Signed-off-by: Mirko Tietgen 
Signed-off-by: Tomas Cohen Arazi 

---

Summary of changes:
 debian/control  |2 ++
 .../prog/en/modules/ill/ill-requests.tt |   19 +--
 2 files changed, 19 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-66-g8a7b508

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  8a7b508cf4bfb9ed03259139c8819a7011995bf5 (commit)
   via  f15cff7d8815b40c6cdeff8def58799b0a497490 (commit)
   via  d341326362656853d0f8d371bd7d685b9c4266d7 (commit)
   via  b98336a09d00bcb970173c535c8f51de5dd64ce4 (commit)
   via  89f0452ba17c54045656ee2654a162fd4a96a744 (commit)
  from  b56e354bf0ef37461916c9cdcea9d63cbca99959 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 8a7b508cf4bfb9ed03259139c8819a7011995bf5
Author: Tomas Cohen Arazi 
Date:   Mon Jun 11 11:34:22 2018 -0300

Bug 20910: Display 773$g when $0 is present too

This patch makes the XSLT logic add the $g subfield in the 773 display
in both the OPAC and staff interface MARC21 record detail pages.

The XSLT chooses between different ways to create the link for the
related content, but then it only adds the $g in two of the cases.
There's no obvious reason for a different display.

To test:
- Have  a record with:

=773   $tHost title $gp4.

=> SUCCESS: Notice the Detail view shows:
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $w100
- Enable UseControlNumber (only to cover the case):
=> SUCCESS: Notice the detail view shows
  In: Host title p4.

- Have another record with:

=773   $tHost title $gp4. $0456

=> FAIL: The Detail view doesn't show p4.
- Apply this patch
- Reload
=> SUCCESS: The Detail view displays p4.!
- Sign off :-D

Sponsored-by: Escuela de Orientacion Lacaniana
Signed-off-by: Jesse Maseto 
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit f161d4e823aa84d7c602089eacacbdf2bfc502ce)
Signed-off-by: Martin Renvoize 

commit f15cff7d8815b40c6cdeff8def58799b0a497490
Author: Jonathan Druart 
Date:   Mon Feb 5 18:13:06 2018 -0300

Bug 20177: [sql_modes] Fix GROUP BY clause in GetCourses

Fix for:
'koha_kohadev.courses.department' isn't in GROUP BY

t/db_dependent/CourseReserves.t

A better fix would be to remove the joins and only return values from
the courses table. But more work is needed to acchieve that goal.

Signed-off-by: Owen Leonard 
Test passes and the behavior of Course reserves appears to be unchanged
Signed-off-by: Julian Maurice 

Signed-off-by: Nick Clemens 
(cherry picked from commit 88c29de46558f974ae10a6d25096cf531f7ee0a0)
Signed-off-by: Martin Renvoize 

commit d341326362656853d0f8d371bd7d685b9c4266d7
Author: Katrin Fischer 
Date:   Wed May 16 01:05:07 2018 +

Bug 9968: Fix wrong index for Standard number in advanced and label search

'Standard number' indicates that you can search ISBN, ISSN and other
standard numbers, but we are using the wrong index and only get a
very limited search for biblionumber instead.

This patch changes the index from sn to ident.

To test:
- Check both staff and OPAC advanced search:
  - Search for Standard number = ISBN
  - Search for Standard number = ISSN
  Both should work.
  Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences
- Check the label creator
  - Add a new batch
  - Use 'add items' option and search for Standard number

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 09a7d37d53a87e35f2151e00200995ab3dfa3896)
Signed-off-by: Martin Renvoize 

commit b98336a09d00bcb970173c535c8f51de5dd64ce4
Author: Jonathan Druart 
Date:   Mon Oct 1 13:42:07 2018 -0300

Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list 
view

branchcode is no longer retrieved from the SQL query, we should use the
Koha::Patron object instead.

Test plan:
Create some overdues and list them on Home › Circulation › Overdues
=> With this patch applied you should see that the "Library" column is
correctly filled with the patron's library name

Signed-off-by: Pierre-Marc Thibault 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit f27787d364ae080ce6a815ba07e8813fce48b2da)
Signed-off-by: Martin Renvoize 

commit 89f0452ba17c54045656ee2654a162fd4a96a744
Author: Andreas Roussos 
Date:   Thu Sep 27 19:05:48 2018 +0300

Bug 21440: koha-create expects the file passed by $DEFAULTSQL to be in gzip 
format

koha-create contains a call to `zcat` which fails if the

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-70-g18d0488

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  18d04888b2264ab85a24290c51eed01c051418ce (commit)
   via  f0937049f376d829d6baad81c66c298e93587acf (commit)
   via  c2537558e0ed79cc00a71d7405b7e738835372a8 (commit)
   via  d0db6f69bbc38b943dd723eca05f181de1a60cf8 (commit)
  from  8a7b508cf4bfb9ed03259139c8819a7011995bf5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 18d04888b2264ab85a24290c51eed01c051418ce
Author: Nick Clemens 
Date:   Tue Oct 9 11:30:23 2018 +

Bug 21417: DBRev 18.05.04.002

Signed-off-by: Nick Clemens 
(cherry picked from commit cf8890465d32d780e4177438d9b6ae807b1df36d)
Signed-off-by: Martin Renvoize 

commit f0937049f376d829d6baad81c66c298e93587acf
Author: Colin Campbell 
Date:   Thu Sep 27 16:07:37 2018 +0100

Bug 21417: (QA follow-up) Display default EAN as such in admin display

A branch value of null is interpreted as the default
Add text 'All libraries' to this case in the display
rather than blank so that its function is clear to the
user

Signed-off-by: Pierre-Marc Thibault 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit d70daacebae50fde8449f4cec2bb4578747610fc)
Signed-off-by: Martin Renvoize 

commit c2537558e0ed79cc00a71d7405b7e738835372a8
Author: Kyle M Hall 
Date:   Thu Sep 27 06:51:27 2018 -0400

Bug 21417: EDI ordering fails when basket and EAN libraries do not match

When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message 
will not be generated if aqbasket.branch does not match edifact_ean.branchcode. 
This failure does not generate any sort of error message, it just fails to 
produce a message.

We should allow ean's to not require a branch to be set, then if we don't 
find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a 
branchcode set

Signed-off-by: Colin Campbell 
Signed-off-by: Pierre-Marc Thibault 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 18674cfde322c52fafb3114b397bb1ebe7941b97)
Signed-off-by: Martin Renvoize 

commit d0db6f69bbc38b943dd723eca05f181de1a60cf8
Author: Andreas Roussos 
Date:   Sat Sep 29 19:51:45 2018 +0300

Bug 21455: Authority search options get shuffled around when you click on 
'Search'

In the staff client, when you perform an authority search the
selected values for the 'Search all headings:' and 'Search
entire record:' options get shuffled around when you click on
the 'Search' button.

This patch fixes that.

Test plan:
1) Perform an authority search and set the 'Search all headings:'
   option to 'starts with'.
2) Click on the 'Search' button.
3) Notice how the 'Search all headings:' option is now 'contains',
   and 'starts with' has moved down to the 'Search entire record:'
   option.
4) Apply the patch.
5) Hit 'Search' again. This time the selected search options do
   not move around.

Signed-off-by: Pierre-Marc Thibault 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 6cee98c04fce2129de21c65c9e0c407a508df9bd)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha.pm |2 +-
 Koha/EDI.pm |   10 ++
 Koha/Schema/Result/EdifactEan.pm|   15 ++-
 admin/edi_ean_accounts.pl   |4 ++--
 authorities/auth_finder.pl  |   14 ++
 installer/data/mysql/kohastructure.sql  |2 +-
 installer/data/mysql/updatedatabase.pl  |7 +++
 .../prog/en/modules/admin/edi_ean_accounts.tt   |   11 ---
 8 files changed, 45 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-71-g8802d32

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  8802d32b7f4e9f4642d3b0f7f7f8a871b85662ed (commit)
  from  18d04888b2264ab85a24290c51eed01c051418ce (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 8802d32b7f4e9f4642d3b0f7f7f8a871b85662ed
Author: Andreas Roussos 
Date:   Sat Oct 6 10:15:26 2018 +0300

Bug 21506: DataTables four button pagination uses the wrong icon for First 
and Last buttons

Pages with DataTables' four button pagination use the wrong
icon for 'First' and 'Last'. Also, the icons for all four
buttons are truncated at the bottom.

This patch fixes that.

Test plan:
1) Go to a page that uses four button pagination (e.g. Home >
   Administration > MARC frameworks) and notice how the
   pagination icons for First/Previous and Next/Last are the
   same. Also notice all four icons are clipped at the bottom.
2) Apply the patch.
3) Refresh the page; the First and Last buttons' icons now
   include a vertical bar, and there is no clipping visible.
4) For completeness, check other affected pages as well.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 074c329774adb7b23f85293a7f6d146c0d989f99)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/css/datatables.css |4 +++-
 koha-tmpl/intranet-tmpl/prog/js/datatables.js   |8 
 2 files changed, 7 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-75-gef93ed6

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  ef93ed60acf10d47a92669490eff1acda3abc135 (commit)
   via  c3591642dc0f11af916723a08930dca10f0c0b4c (commit)
   via  ee4fbd587f97768106367aab9b9746f9b09dffbf (commit)
   via  4b139ba1954b5c1451f842996ae42511c9369c05 (commit)
  from  8802d32b7f4e9f4642d3b0f7f7f8a871b85662ed (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit ef93ed60acf10d47a92669490eff1acda3abc135
Author: Andrew Isherwood 
Date:   Wed Sep 26 14:04:00 2018 +0100

Bug 20548: (follow-up) Fix unit tests

Removed the "Backend create: copyright clearance" unit test since we no
longer have a "copyrightclearance" stage, hence we don't have a block in
the template handling it, hence the test failure!

Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit e6bf76b9c712913e549f43a30830ea612c73befa)
Signed-off-by: Martin Renvoize 

commit c3591642dc0f11af916723a08930dca10f0c0b4c
Author: Andrew Isherwood 
Date:   Mon Apr 9 15:04:35 2018 +0100

Bug 20548: Remove copyright clearance for staff

This patch removes the erroneously added workflow that requires staff
users to agree to the copyright clearance declaration defined in the
ILLModuleCopyrightClearance preference. Only OPAC users should be
required to accept the declaration.

To test:
1) Ensure you have at least one ILL backend available:
  https://wiki.koha-community.org/wiki/ILL_backends
2) Ensure you have the "ILLModule" preference enabled
3) Add some text to the "ILLModuleCopyrightClearance" preference
4) As an OPAC user make an ILL request:
  a) Navigate to a search results page in the catalog
  b) Click the "Make an Interlibrary Loan request" link at the bottom
  c) Choose "Create a new request", then select a backend
  d) Observe the text you added earlier is displayed with buttons for
  agreeing or disagreeing
5) As a staff user, select the "ILL requests" button on the front page of
the intranet site
  a) Choose "Create a new request", then select a backend
  b) Observe that you are NOT prompted to agree to the text you added
  earlier

Assigned-to: Andrew Isherwood 
Signed-off-by: Barry Cannon 

Signed-off-by: Jonathan Druart 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit ad35c9702eb1da9bec331312701e71ce6ab5cf91)
Signed-off-by: Martin Renvoize 

commit ee4fbd587f97768106367aab9b9746f9b09dffbf
Author: Owen Leonard 
Date:   Fri Oct 5 17:05:19 2018 +

Bug 16420: Buttons inconsistent between "Hold found" and "Hold found 
(waiting)" dialogs in checkin

This patch makes minor changes to the text of hold confirmation buttons
in the checkin process in order to make them more consistent.

Also changed: Removed the "danger" class from the "Ignore" button for
readability and consistency's sake.

To test, apply the patch and check in an item which is on hold for a
patron at your logged-in library. The hold confirmation dialog's buttons
should read "Confirm hold," "Print slip and confirm," and "Ignore."

Confirm the hold, then check in the same item again.

In the dialog, the buttons should read "Confirm hold," "Print slip and
confirm," and "Cancel hold."

Signed-off-by: Michal Denar 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 96c2df5804ce3ac84e5963d6b9764553a97a6978)
Signed-off-by: Martin Renvoize 

commit 4b139ba1954b5c1451f842996ae42511c9369c05
Author: Tomas Cohen Arazi 
Date:   Thu Oct 4 14:08:32 2018 -0300

Bug 21500: Remove warnings in rotating collections

To test:
- Go to Tools > Rotating collections
=> FAIL: Some warinings on the logs
- Apply this patch
- Reload page
=> SUCCESS: No warinings
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit 40803d30359f347417999429b612fcece9fc96f9)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 Koha/Illrequest.pm |   33 ++--
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |6 ++--
 .../prog/en/modules/ill/ill-requests.tt|   14 +
 opac/opac-illrequests.pl   |1 +
 rotating_c

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-79-g22acd34

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  22acd346c07604006f188aef5f8af0a147f37880 (commit)
   via  c5236f1d66e1baeb4d365288b1a78908ed48fc10 (commit)
   via  2170698ab9da24d306286991b55257c4c3317e65 (commit)
   via  b0f3bc8c134c195e3d943a0f7f9d5ff6a064da79 (commit)
  from  ef93ed60acf10d47a92669490eff1acda3abc135 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 22acd346c07604006f188aef5f8af0a147f37880
Author: Martin Renvoize 
Date:   Mon Oct 15 14:34:21 2018 +0100

Bug 21493: Compiled CSS

Signed-off-by: Martin Renvoize 

commit c5236f1d66e1baeb4d365288b1a78908ed48fc10
Author: Owen Leonard 
Date:   Mon Oct 15 13:18:33 2018 +

Bug 21493: (18.05.x) Remove incomplete icon style from serial issues tabs

This patch adds CSS to exclude serial issues history links from having
an icon background. There is no part of the icon sprite which is
designed for that purpose.

This patch also tweaks the positioning of a couple of icons.

To test, apply the patch and regenerate the OPAC CSS

(https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files).

- Open the detail page for a bibliographic record in the OPAC which has
  subscriptions.
- Click the "More details" link.
- Confirm that the "Brief history" and "Full history" links have no
  icon.
- Click the "Full history" link and do the same.
- On the normal, MARC, and ISBD views, confirm that the icons for those
  links look correct.

Signed-off-by: Martin Renvoize 

commit 2170698ab9da24d306286991b55257c4c3317e65
Author: Fridolin Somers 
Date:   Wed Feb 7 15:06:56 2018 +0100

Bug 20151: always use current language for stemming

When stemming is enabled, in catalog searching 
"C4::Search::_build_stemmed_operand" will transform query operand into stemmed 
operand using stemmer Lingua::Stem::Snowball with a specified language.
This stemmer returns undef stemmed operand if no language is defined.

In main catalog search (catalogue/search.pl) current language is used.
But in other pages "acqui/neworderbiblio.pl" and "cataloguing/addbooks.pl" 
no language is defined so stemmed operand is empty and so stemming is not 
applied.

This patch corrects by returning in "C4::Search::_build_stemmed_operand" 
operand without change if no langage is defined.
And uses current langage in pages "acqui/neworderbiblio.pl" and 
"cataloguing/addbooks.pl" so all catalog search uses stemming.

Test plan :
1) Enable system preferences QueryStemming and QueryWeightFields
2) Disable system preferences QueryAutoTruncate, QueryFuzzy and 
UseQueryParser
3) Go to intranet main page and click on "Search the catalog" tab
4) Perform a search (without index) that uses the stemming, for example 
searching for "years" will also match "year"
5) Note how many results you get, for example "year" gets 24 results and 
"years" gets 24 results
6) Go to "Cataloging" module
7) Perform a search on same word in "Cataloging search" tab
8) Note how many results you get
9) Without patch you get fewer results than first search (step 5) because 
stemming is not applied, for example "year" gets 11 results and "years" gets 15 
results
10) With patch you get the same results as first search (step 5) because 
stemming is applied, for example "year" and "years" gets 24 results
11) Same tests in aquisition module
12) On a basket, click "Add to basket" and perform a search in "From an 
existing record"

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 78a692dee4523d04986ec394442c3a6d80ea0771)
Signed-off-by: Martin Renvoize 

commit b0f3bc8c134c195e3d943a0f7f9d5ff6a064da79
Author: Fridolin Somers 
Date:   Fri Sep 21 11:17:25 2018 +0200

Bug 21389: Correct Javascript error on article requests page

Bug 21076 fixed a Javascript error on article requests page when patron is 
found.

There is also an error when patron is not found, with message :
  Patron not found
  No patron with this name, please, try another

This patch fixes by replacing TT condition by a JS condition testing the 
existance of the patron input.

Test plan:
1 - Do not apply patch
2 - Enable article requests
3 - Search on staff client and click 'Request article'
4 - Search for a patron that does not exist
5 - You get a yellow message "Patron not found"
6 - View error in console
7 - Apply pat

[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-81-ge635b63

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  e635b63e94c0dd09f20c936039d518c3e494252c (commit)
   via  c4ce2d433bb182a7169ea8ef614637629b7e (commit)
  from  22acd346c07604006f188aef5f8af0a147f37880 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit e635b63e94c0dd09f20c936039d518c3e494252c
Author: Jonathan Druart 
Date:   Tue Oct 9 10:47:11 2018 -0300

Bug 15734: Use To.json to filter audio alerts

Test Plan:
1) Enable audio alerts
2) Note audio alerts don't work
3) Apply this patch
4) Note audio alerts now work

Use complex selectors to test:
  #circ_returns p.problem:contains('Not checked out.')
  #doc3 > #bd

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 
(cherry picked from commit 58314233f70fd9fd2f2830250ff0362e369b6ff1)
Signed-off-by: Martin Renvoize 

commit c4ce2d433bb182a7169ea8ef614637629b7e
Author: Jonathan Druart 
Date:   Sat Sep 29 15:16:46 2018 -0300

Bug 21426: Handle USE_MEMCACHED=no in koha-create

Signed-off-by: Andreas Roussos 

Works as intended. I've set USE_MEMCACHED to "no" and created a new
Koha instance. Home > About now reports this information: Memcached:
Servers: undefined | Namespace: undefined | Status: unknown | Config
read from: Nowhere [...] | Effective caching method: Cache::Memory

Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit ffca9decadf539018e447237e56bce76c81bdd64)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 debian/scripts/koha-create   |8 +++-
 koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc |5 +++--
 2 files changed, 10 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-48-g6830a61

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  6830a61918a8ece7a3254cfe3473c48a6630f284 (commit)
   via  25e62577902fe7b426d545d5f17e74452980f7cf (commit)
  from  94446917946de314302345f0b28503fcbea38c70 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 6830a61918a8ece7a3254cfe3473c48a6630f284
Author: Fridolin Somers 
Date:   Wed Feb 7 15:06:56 2018 +0100

Bug 20151: always use current language for stemming

When stemming is enabled, in catalog searching 
"C4::Search::_build_stemmed_operand" will transform query operand into stemmed 
operand using stemmer Lingua::Stem::Snowball with a specified language.
This stemmer returns undef stemmed operand if no language is defined.

In main catalog search (catalogue/search.pl) current language is used.
But in other pages "acqui/neworderbiblio.pl" and "cataloguing/addbooks.pl" 
no language is defined so stemmed operand is empty and so stemming is not 
applied.

This patch corrects by returning in "C4::Search::_build_stemmed_operand" 
operand without change if no langage is defined.
And uses current langage in pages "acqui/neworderbiblio.pl" and 
"cataloguing/addbooks.pl" so all catalog search uses stemming.

Test plan :
1) Enable system preferences QueryStemming and QueryWeightFields
2) Disable system preferences QueryAutoTruncate, QueryFuzzy and 
UseQueryParser
3) Go to intranet main page and click on "Search the catalog" tab
4) Perform a search (without index) that uses the stemming, for example 
searching for "years" will also match "year"
5) Note how many results you get, for example "year" gets 24 results and 
"years" gets 24 results
6) Go to "Cataloging" module
7) Perform a search on same word in "Cataloging search" tab
8) Note how many results you get
9) Without patch you get fewer results than first search (step 5) because 
stemming is not applied, for example "year" gets 11 results and "years" gets 15 
results
10) With patch you get the same results as first search (step 5) because 
stemming is applied, for example "year" and "years" gets 24 results
11) Same tests in aquisition module
12) On a basket, click "Add to basket" and perform a search in "From an 
existing record"

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit 78a692dee4523d04986ec394442c3a6d80ea0771)
Signed-off-by: Martin Renvoize 
(cherry picked from commit 2170698ab9da24d306286991b55257c4c3317e65)
Signed-off-by: Fridolin Somers 

commit 25e62577902fe7b426d545d5f17e74452980f7cf
Author: Magnus Enger 
Date:   Thu Sep 6 13:23:17 2018 +

Bug 21322: process_message_queue.pl --type should take an argument

The help for this script says:
-t --type: If supplied, only processes this type of message ( email, sms )

Currently, the type argument is set up wrong, so it does not look
for an argument. This patch fixes that.

To test, run this command (should work in kohadevbox) or something
similar:

$ sudo koha-shell -c "perl \
/home/vagrant/kohaclone/misc/cronjobs/process_message_queue.pl -v \
--type=sms" kohadev

This should give the following error: "Option type does not take an 
argument".
Apply the patch and run the same command again. This should not give an
error.

Signed-off-by: Mark Tompsett 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 
(cherry picked from commit d74a05d4fe81a599c030024f7944d2bdcca43d12)
Signed-off-by: Martin Renvoize 
(cherry picked from commit a3f097958cae68e4f3f16c8eb5aa5411d2488bc2)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 C4/Search.pm   |3 +++
 acqui/neworderbiblio.pl|5 -
 cataloguing/addbooks.pl|5 -
 misc/cronjobs/process_message_queue.pl |2 +-
 4 files changed, 12 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-1043-ge757448

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  e7574481b19addd2747baf5917e772d28cd38bc5 (commit)
   via  ed7f9a45453fa88dd2a6d17f07566931b6149678 (commit)
   via  5e2862c6b8eb102f623ccc4d667b4e38895703e4 (commit)
   via  936198ba6aebaace6d0bfab4f0d4667274872555 (commit)
   via  720d6360a0038a943b4554c4180cc0ebb61c2b4d (commit)
   via  e652f47cedfdf069b054b4f623ec5674640555ec (commit)
   via  cea8a72708e68b82eeeaaec2d985ec0a69dd4a11 (commit)
   via  a32c92c6013b199cc26efd15d0442e3f3a2eed6b (commit)
   via  d9b922f46f8d551949f337f29edef6985130c8ba (commit)
   via  bfbbe52ff7ff0ec93825684e4728db705b4100d1 (commit)
   via  c6c4d82325eb7d11b34a113c69acbff18e283542 (commit)
   via  ab13b53854e0aa726c8112d8f31cc553484637bd (commit)
   via  8d9284668c6de2d5fbfc4079a8b0516ba1645876 (commit)
   via  9965aa43e15aaa63fd8999daa98618d20698e89b (commit)
   via  c6198717c4be56ba99deb57aa6d117d23a032eea (commit)
   via  fd0df2ad55f9a5ff180dc0dfa22fede5f0ad37cd (commit)
   via  959162b2f3c9689bb56433ee08c300b40822d700 (commit)
   via  1a8e1165ca7abf9e2b7e5c7de0cdf26cbd4e30ac (commit)
   via  1fddd295b8e83b60f2b838f09f3175c5acfeec28 (commit)
   via  dab70daa55a90f7b50f8c2dc9fefdef0762e5daf (commit)
   via  3f09e1d73338c86762412546e1a0617df698f422 (commit)
   via  b23fe0b0b8d468fe80d40aef1a12296421cc1d37 (commit)
   via  9c6025ccbfd0c57d45fec444ee57e72c3aad512b (commit)
   via  3e6f9b8a1d5b293cfe5a00732e2b6f1371046855 (commit)
   via  b1bb9f9e6b028dce0109755180100e4033424227 (commit)
  from  3950dd4f6c42a865a584bad3fea2d81e0282dcc1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit e7574481b19addd2747baf5917e772d28cd38bc5
Author: Jonathan Druart 
Date:   Mon Oct 15 11:42:34 2018 -0300

Bug 21479: Zebra index can return different result

If the zebra index has been rebuilt by previous tests, the order/results
will be different, and we will not have biblionumber 1, 3, 5

Let make this more flexible

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

commit ed7f9a45453fa88dd2a6d17f07566931b6149678
Author: Owen Leonard 
Date:   Mon Aug 13 13:55:31 2018 +

Bug 18480: Get rid of unwanted / distracting link in patron search for fund 
owner

This patch modifies templates where a pop-up window is used to display
patron search results. A link has been added to the patron name which
triggers a modal window displaying more details about that patron. With
each page in the test plan, check that clicking linked names in search
results triggers a modal with the correct data.

 - Acquisitions -> Vendor -> View basket -> Add user
 - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
   -> Add user
 - Acquisitions -> Funds -> Edit fund -> Select owner
 - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
   patrons
 - Serials -> Subscription -> Edit routing list -> Add recipients

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 5e2862c6b8eb102f623ccc4d667b4e38895703e4
Author: Nick Clemens 
Date:   Mon Oct 15 14:14:37 2018 +

Bug 21337: (RM follow-up) Adjust number of tests

Signed-off-by: Nick Clemens 

commit 936198ba6aebaace6d0bfab4f0d4667274872555
Author: Marcel de Rooy 
Date:   Mon Oct 1 09:52:21 2018 +0200

Bug 21337: (QA follow-up) Rollback for partial delete

Puts delete loop in a txn_do.
Raises Koha::Exceptions::Patron::Delete when Patron->delete does not return
true (like 0 or -1).
Unit test adjusted accordingly.

Note: A follow-up report for raising exceptions in Object->delete could well
be considered. Not here please.

Test plan:
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit 720d6360a0038a943b4554c4180cc0ebb61c2b4d
Author: Marcel de Rooy 
Date:   Thu Sep 13 12:26:57 2018 +0200

Bug 21337: (follow-up) Add parameter for move_to_deleted action

For consistency, it would be better to make the move optional.

Test plan:
Run again t/db_dependent/Koha/Patrons.t.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

commit e652f47cedfdf069b054b4f623ec5674640555ec
Author: Marcel de Rooy 
Date:   Wed Sep 12 15:

[koha-commits] main Koha release repository branch master updated. v18.05.00-1044-g82ff813

2018-10-15 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  82ff8138b4bb5bb4fba16a979c75a4673a15e348 (commit)
  from  e7574481b19addd2747baf5917e772d28cd38bc5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 82ff8138b4bb5bb4fba16a979c75a4673a15e348
Author: Jonathan Druart 
Date:   Mon Oct 15 14:38:14 2018 -0300

Bug 21337: Koha::Objects->delete must return the number of deleted rows

To follow DBIC behaviour

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 Koha/Patrons.pm   |4 +++-
 t/db_dependent/Koha/Patrons.t |2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-83-g8b809db

2018-10-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  8b809db3e4a47b39b42b637d01aad81970c8ba0e (commit)
   via  3972a6fc5fa6e27d84008ab073f78af9c960e43a (commit)
  from  e635b63e94c0dd09f20c936039d518c3e494252c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 8b809db3e4a47b39b42b637d01aad81970c8ba0e
Author: Jonathan Druart 
Date:   Tue Oct 9 14:01:07 2018 -0300

Bug 21464: Hide patron's title not biblio's title

Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit 07fa37abbe325e136cd84f2dd5e1971d64c20d65)
Signed-off-by: Martin Renvoize 

commit 3972a6fc5fa6e27d84008ab073f78af9c960e43a
Author: Jonathan Druart 
Date:   Mon Oct 1 17:18:18 2018 -0300

Bug 21464: Fix overdue list export

  commit e09ed656af5f75a82ccfa29318081e217618c32d
  Bug 18403: Only display libraries from group in dropdown lists
and
  commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d
  Bug 18789: Send Koha::Patron object to the templates

broke the overdue list export.

Test plan:
Create some overdues
Export them: "Home › Circulation › Overdues" then click the link on top
of the table.
All the different columns of the generated CSV file must be filled
correctly

Signed-off-by: Martin Renvoize 
Signed-off-by: Chris Cormack 
Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit 8a8c0ae51e2b1128942f6dff5ca022433355314e)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 circ/overdue.pl |   23 +++
 1 file changed, 19 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-1045-gdc6bea7

2018-10-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  dc6bea7860aba7933f7e979cbe7c53e9cb15ba05 (commit)
  from  82ff8138b4bb5bb4fba16a979c75a4673a15e348 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit dc6bea7860aba7933f7e979cbe7c53e9cb15ba05
Author: Jonathan Druart 
Date:   Mon Oct 15 14:53:35 2018 -0300

Bug 21479: "Mock" SearchEngine to use Zebra

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 t/db_dependent/selenium/regressions.t |6 ++
 1 file changed, 6 insertions(+)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-87-g42e8d66

2018-10-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  42e8d66369c6b38caeab85ddd5a1021623ca4628 (commit)
   via  e9c0c2263057d7e72013d8a62438803733d2a67f (commit)
   via  84bf7c9468a1be39de54a488f41e5c579be86072 (commit)
   via  9b428ec7ed43c3926483aa692315efdebb545f7b (commit)
  from  8b809db3e4a47b39b42b637d01aad81970c8ba0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 42e8d66369c6b38caeab85ddd5a1021623ca4628
Author: Dobrica Pavlinusic 
Date:   Thu Sep 6 13:21:53 2018 +0200

Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems

Test plan:

1. Set syspref AllowHoldsOnDamagedItems to Allow
2. Create a hold on record with item which is damaged
3. Verify that it doesn't appear in report
4. Apply patch and verify that it's now visible

Signed-off-by: Caroline Cyr La Rose 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 
(cherry picked from commit b23fe0b0b8d468fe80d40aef1a12296421cc1d37)
Signed-off-by: Martin Renvoize 

commit e9c0c2263057d7e72013d8a62438803733d2a67f
Author: Alex Arnaud 
Date:   Wed Feb 21 13:10:50 2018 +

Bug 10382: Course reserves: handle empty values

Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 9c6025ccbfd0c57d45fec444ee57e72c3aad512b)
Signed-off-by: Martin Renvoize 

commit 84bf7c9468a1be39de54a488f41e5c579be86072
Author: Alex Arnaud 
Date:   Thu Mar 9 13:42:04 2017 +

Bug 10382: Add unit tests for course items

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit 3e6f9b8a1d5b293cfe5a00732e2b6f1371046855)
Signed-off-by: Martin Renvoize 

commit 9b428ec7ed43c3926483aa692315efdebb545f7b
Author: Kyle M Hall 
Date:   Wed Jun 5 10:01:17 2013 -0400

Bug 10382: collection not returning to null when removed from course 
reserves

Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 
(cherry picked from commit b1bb9f9e6b028dce0109755180100e4033424227)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/CourseReserves.pm   |   89 ++-
 circ/pendingreserves.pl|7 +-
 .../en/modules/course_reserves/add_items-step2.tt  |   16 +-
 .../en/modules/course_reserves/course-details.tt   |8 +-
 t/db_dependent/CourseReserves/CourseItems.t|  268 
 5 files changed, 301 insertions(+), 87 deletions(-)
 create mode 100644 t/db_dependent/CourseReserves/CourseItems.t


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-89-g3587f80

2018-10-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  3587f80f410d80bd14543fb28b465825a1575bdc (commit)
   via  68cca5c430c78338bf9243e525cb8fba5b9c7e13 (commit)
  from  42e8d66369c6b38caeab85ddd5a1021623ca4628 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 3587f80f410d80bd14543fb28b465825a1575bdc
Author: Nick Clemens 
Date:   Mon Oct 15 13:07:11 2018 +

Bug 19687: (RM follow-up) Export correct function name

Signed-off-by: Nick Clemens 
(cherry picked from commit dab70daa55a90f7b50f8c2dc9fefdef0762e5daf)
Signed-off-by: Martin Renvoize 

commit 68cca5c430c78338bf9243e525cb8fba5b9c7e13
Author: David Gustafsson 
Date:   Wed Sep 26 17:25:44 2018 +0200

Bug 19687: Undefined subroutine in bulkmarcimport

Bulkmarcimport produces undefined subroutine error for
C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure
probably caused by mutually recursive modules. Put exports in
BEGIN clause before all the other imports.

To test:
1) Run bulkmarcimport.pl before applying patch and verify
that undefined subroutine error occurs
2) Apply patch
3) Run bulkmarcimport.pl again and verify that no errors are
produced

Sponsored-by: Gothenburg University Library

Signed-off-by: George Veranis 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 3f09e1d73338c86762412546e1a0617df698f422)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 C4/Biblio.pm |  147 --
 C4/Items.pm  |   90 ---
 2 files changed, 100 insertions(+), 137 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-94-g517bf77

2018-10-16 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  517bf773553ef941198898d5489b04c8859ded63 (commit)
   via  351dfa737bc0f4b46f4aab47dfa635943065df48 (commit)
   via  ccb364a667745eadf52e76f894ec9dff2a15a060 (commit)
   via  bbf6d87d56e63a7c17ce91b7ea4b599fae95a881 (commit)
   via  2d078a18e5e090bcafa64262bb5f8dceed796169 (commit)
  from  3587f80f410d80bd14543fb28b465825a1575bdc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 517bf773553ef941198898d5489b04c8859ded63
Author: Jonathan Druart 
Date:   Mon Oct 15 14:53:35 2018 -0300

Bug 21479: "Mock" SearchEngine to use Zebra

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit dc6bea7860aba7933f7e979cbe7c53e9cb15ba05)
Signed-off-by: Martin Renvoize 

commit 351dfa737bc0f4b46f4aab47dfa635943065df48
Author: Jonathan Druart 
Date:   Mon Oct 15 11:42:34 2018 -0300

Bug 21479: Zebra index can return different result

If the zebra index has been rebuilt by previous tests, the order/results
will be different, and we will not have biblionumber 1, 3, 5

Let make this more flexible

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 
(cherry picked from commit e7574481b19addd2747baf5917e772d28cd38bc5)
Signed-off-by: Martin Renvoize 

commit ccb364a667745eadf52e76f894ec9dff2a15a060
Author: Jonathan Druart 
Date:   Fri Oct 12 15:37:44 2018 -0300

Bug 21479: Remove the trace if the node does not exist

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit be4f22f5a0745ef64c6bf20b89bd9f4fcbe40403)
Signed-off-by: Martin Renvoize 

commit bbf6d87d56e63a7c17ce91b7ea4b599fae95a881
Author: Jonathan Druart 
Date:   Tue Oct 9 13:30:54 2018 -0300

Bug 21479: Add regression tests

Signed-off-by: Jonathan Druart 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit 45fbd36e1f2e1aa622eec1ba588424cc50243fb3)
Signed-off-by: Martin Renvoize 

commit 2d078a18e5e090bcafa64262bb5f8dceed796169
Author: Owen Leonard 
Date:   Wed Oct 3 14:13:49 2018 +

Bug 21479: Fix remove from cart links at the OPAC (should remove only 1)

This patch changes the way biblionumbers are passed to the cart script
for adding and removing single items. The title's biblionumber is now
stored in a data-attribute on the links for adding and removing. This
should be a more robust, unified way to handle these single-item
operations.

To test, apply the patch and enable the opacbookbag system preference.

Test adding and removing items from the cart from various pages using
various methods:

 - By clicking an "Add to your cart" / "Remove" link in search results
 - By clicking an "Add to your cart" / "Remove" link on a detail page
 - By checking boxes in search results and adding via the dropdown

Each operation should work correctly.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 
Signed-off-by: Tomas Cohen Arazi 
(cherry picked from commit 2cd49034c43a16c7497f05e94c18396532fceddc)
Signed-off-by: Martin Renvoize 

---

Summary of changes:
 .../bootstrap/en/includes/opac-bottom.inc  |   17 +++--
 .../bootstrap/en/includes/opac-detail-sidebar.inc  |4 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |4 +-
 koha-tmpl/opac-tmpl/bootstrap/js/basket.js |5 +-
 t/db_dependent/selenium/regressions.t  |   74 
 5 files changed, 92 insertions(+), 12 deletions(-)
 create mode 100644 t/db_dependent/selenium/regressions.t


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.04-104-g417e28f

2018-10-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
   via  417e28f14ebccdef073491b94bbbad8a80a0630d (commit)
   via  2ea99b19988a3fed348d574cb06a50c8f6206f34 (commit)
   via  55aebb21146978764a0062a8288abba0e56d4d8b (commit)
   via  607a602ea4bc47b9beb1be2dab1f19a4eaef36a3 (commit)
   via  a9aa1bd1e43a871a813de1e2e97005567afa589c (commit)
   via  b8ad6a6532c236e473d548ad910d920ef1516ecf (commit)
   via  2031603f68e2fec6097d7608d8efab7018563032 (commit)
   via  0eb7160a3fc39d7860a5ed883615f12b1731d458 (commit)
   via  395d0965cc115ace3daab7cc6ec8ad4832a50411 (commit)
   via  4092461ec990882f204d1431e69fd6d6a70d0d1e (commit)
  from  517bf773553ef941198898d5489b04c8859ded63 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 417e28f14ebccdef073491b94bbbad8a80a0630d
Author: Owen Leonard 
Date:   Thu Oct 11 15:59:13 2018 +

Bug 21550: DataTables four button pagination uses the wrong icon for 
disabled buttons

This patch modifies the DataTables CSS which styles "full_nubmers"
controls which are disabled: First and Previous buttons on the first
page of results, Next and Last buttons on the last page of results.
These buttons should have gray icons instead of blue.

To test, apply the patch and clear your browser cache if necessary. View
a page which uses a "full_numbers" DataTables configuration, e.g.

- Administration -> Cities
- ILL requests -> List requests
- Circulation -> Holds to pull

Confirm that buttons in their disabled state have a gray icon and text
instead of blue.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit d9b922f46f8d551949f337f29edef6985130c8ba)
Signed-off-by: Martin Renvoize 

commit 2ea99b19988a3fed348d574cb06a50c8f6206f34
Author: Marcel de Rooy 
Date:   Wed Jul 25 14:37:59 2018 +0200

Bug 21115: Add multi_param call and add divider in cache key in svc/report 
and opac counterpart

Resolve things like:
CGI::param called in list context from package 
CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can 
lead to vulnerabilities. See the warning in "Fetching the value or values of a 
single named parameter" at /usr/share/perl5/CGI.pm line 436.

The cache key in both script looks like:
opac:report:id:602018
but should for consistency be:
opac:report:id:60:2018
Note: The 2018 here is part of the sql_params and should not be
concatenated to the report id.

Test plan:
Do not yet apply this patch.
Make a report public, set cache to 300 secs.
Check its output with opac/svc/report.
Check for the warn in your log.
Apply the patch, restart Plack and flush cache.
Check opac/svc/report.
Modify your report; e.g. add a simple string to the SELECT.
Check opac/svc/report. You should still see cached output.
Flush the cache.
Check opac/svc/report. You should now see the added text.

Signed-off-by: Marcel de Rooy 
Tested also by clearing individual keys with $cache->clear_from_cache.

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit bfbbe52ff7ff0ec93825684e4728db705b4100d1)
Signed-off-by: Martin Renvoize 

commit 55aebb21146978764a0062a8288abba0e56d4d8b
Author: Blou 
Date:   Thu Oct 4 13:00:08 2018 -0400

Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff 
detail's sidebar

The subscriptionsnumber is required in biblio-view-menu.inc to display
the Subscription(s) tab. In detail.pl, if you click any of

Labeled MARC  (you need to set the syspref viewLabeledMARC)
Hold(s)
Article requests
Checkout history
Modification log
Rota  (you need to set the syspref StockRotation)

you lose the Subscription(s) tab.

This patch fixes the display by having each feature script generate that
value to be passed to the UI. I keep this separated from the first patch
since it's not exactly the same issue, and the solution might not
please.

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 
(cherry picked from commit c6c4d82325eb7d11b34a113c69acbff18e283542)
Signed-off-by: Martin Renvoize 

commit 607a602ea4bc47b9beb1be2dab1f19a4eaef36a3
Author: Blou 
Date:   Thu Aug 30 10:33:44 2018 -0400

Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and

[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.10-50-g5febaef

2018-10-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
   via  5febaef09f56059875a7bb4b0518903e41333d3a (commit)
   via  2755a664707b2111589aa0726f56eb7bb14a2fde (commit)
  from  6830a61918a8ece7a3254cfe3473c48a6630f284 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 5febaef09f56059875a7bb4b0518903e41333d3a
Author: Fridolin Somers 
Date:   Fri Feb 2 14:34:34 2018 +0100

Bug 20131: Inventory optional filters correct "For loan" addition

In inventory, optional filters are build from authorize values categories 
used for items.notforloan, items.itemlost, items.withdrawn and items.damaged.

The bug is that description of value 0 is always "For loan".
This seems to be only for "notforloan".

Second bug is that if a description exists for "notforloan" value 0, it is 
not used.

This patch corrects by adding "For loan" only for "notforloan" authorized 
values and if there is no 0 value.
It changes the description added by code from "ignore" to a more unlikly 
user defined "__IGNORE__".

Test plan:
1) Make sure you have authorized values defined on items.notforloan, say 
"NFL" category, with at least a value and description but no 0 value
2) Make sure you have authorized values defined on items.itemlost, say 
"LOST" category, with 0 = "Not lost" and 1 = "Lost"
3) Go to inventory /cgi-bin/koha/tools/inventory.pl
4) Without patch you see "For loan" on both items.notforloan and 
items.itemlost
5) With patch you see "For loan" only in items.notforloan, you see for 
items.itemlost : "Not lost" and "Lost"
6) Create in authorized values category "NFL" a value 0 with description 
"Available"
7) Go to inventory /cgi-bin/koha/tools/inventory.pl
8) Without patch you see "For loan" in items.notforloan for value 0
9) With patch you see "Available" in items.notforloan for value 0

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 8d9284668c6de2d5fbfc4079a8b0516ba1645876)
Signed-off-by: Martin Renvoize 
(cherry picked from commit a9aa1bd1e43a871a813de1e2e97005567afa589c)
Signed-off-by: Fridolin Somers 

commit 2755a664707b2111589aa0726f56eb7bb14a2fde
Author: Baptiste Wojtkowski 
Date:   Tue May 23 08:54:00 2017 +

Bug 18655: Correct the choose link in unimarc_field_210c value builder

- Link 'choose' is now a button.
- It doesn't call directly javascript anymore (use of listener).
- field to load stored in html on the page (less escaping needed).

Test plan :
1) Use UNIMARC catalog
2) Define unimarc_field_210c value builder on 210$c
3) Define an autority type EDITORS with heading on 200$b
4) Create an autority of this type with a single quote in heading, ie : 
l'avenir
5) Index this new autority
6) Edit a biblio record and launch 210$c value builder
7) Search for new autority
8) Click on 'Choose'
=> Heading should be pasted in 210$c

Signed-off-by: David Nind 
Signed-off-by: Chris Cormack 

Signed-off-by: Nick Clemens 
(cherry picked from commit 9965aa43e15aaa63fd8999daa98618d20698e89b)
Signed-off-by: Martin Renvoize 
(cherry picked from commit b8ad6a6532c236e473d548ad910d920ef1516ecf)
Signed-off-by: Fridolin Somers 

---

Summary of changes:
 .../cataloguing/value_builder/unimarc_field_210c.tt   |   13 ++---
 .../intranet-tmpl/prog/en/modules/tools/inventory.tt  |4 ++--
 tools/inventory.pl|2 +-
 3 files changed, 13 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-1064-gefd2b75

2018-10-17 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  efd2b75b6741f95a79a88e0765bcb0802a7cf1fd (commit)
   via  5151b27c5d4fc74ef678eab8b45be7388c310923 (commit)
   via  5bd71cc789275572b0fc10be0a8f85ca46b19f8c (commit)
   via  da604a9006e86bf569f60ac3cd5b60d7e70447c2 (commit)
   via  62285d2de463811380262e4cc65c82937145d477 (commit)
   via  aafd0476342ca9691fd8a7c2c754c425ae1cf61f (commit)
   via  2cffe3a574e14d5f35ce7b1d9ffe28a153dcb37e (commit)
   via  81875ab282c1daa98dec2e0f5f20ba74f411ac32 (commit)
   via  796e4e5d2be5ec87970f8b586f940e4abddb687d (commit)
   via  bf7c8303ca7f9e4955f25fc4d1f30d65d8c52dc9 (commit)
   via  074cb8d5b9a2f78fec56df9069253d22c9678084 (commit)
   via  706d21ee53dd5072eec2234415fc5c8ff4b1ea17 (commit)
   via  5ca776d6e171de1b093163ab83ba589d5ae4d7cc (commit)
   via  23265158fcab25f8f5188cea6f07af46812d41cc (commit)
   via  55225ba10b824f7e881738a20c751200843d3ec9 (commit)
   via  7f0207d2ad162a86cf5e09e437565b66b91c5004 (commit)
   via  4e6d9defc180204461f80477be287ade7fcfc11b (commit)
   via  f902041e244cc35ecc99e3ca256ff24c843a8b04 (commit)
   via  32dc4a7bfaeebcff2be739fdf5f15e0f8bad4faa (commit)
  from  dc6bea7860aba7933f7e979cbe7c53e9cb15ba05 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit efd2b75b6741f95a79a88e0765bcb0802a7cf1fd
Author: Andrew Isherwood 
Date:   Tue Jun 26 11:36:33 2018 +0100

Bug 20995: Add Request ID to table and request view

This patch adds the display of Request ID to the OPAC views of all a
user's requests and the individual request.

To test:

1) Ensure you have ILL enabled
2) Log into the OPAC as a user with at least one request
3) Go to the "your interlibrary loan requests" page
4) TEST: Ensure that Request ID is displayed as the first column in the
table
5) Click the "View" button on a request
6) TEST: Ensure that Request ID is displayed along with all the other
request information

Signed-off-by: m...@interleaf.ie

Signed-off-by: Katrin Fischer 

Bug 20995: (QA follow-up) Add html filters and fix doubled up columns from 
merge

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 5151b27c5d4fc74ef678eab8b45be7388c310923
Author: Jonathan Druart 
Date:   Tue Oct 9 13:38:34 2018 -0300

Bug 21174: (follow-up) Removed MSG_IN_YOUR_CART and its usage in OPAC JS

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit 5bd71cc789275572b0fc10be0a8f85ca46b19f8c
Author: Alex Buckley 
Date:   Sun Sep 30 16:22:10 2018 +

Bug 21174: Removed MSG_IN_YOUR_CART and its usage in OPAC JS

The 'Items in your cart' message is obsolete with the cart dropdown
box being removed.

Therefore the assignment of this text into the
MSG_IN_YOUR_CART variable (which is done in the opac-bottom.inc), and
the use of the MSG_IN_YOUR_CART variable in the updateBasket() function
(in the OPAC's basket.js) has been removed.

Sponsored-By: Toi Ohomai Institute of Technology, New Zealand

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

commit da604a9006e86bf569f60ac3cd5b60d7e70447c2
Author: Alex Buckley 
Date:   Sat Sep 29 05:24:22 2018 +

Bug 21174: Open the OPAC cart with one click by default

Feedback from the Koha mailing list in Aug 2018 showed there was
widespread concensus for making the default behaviour of the OPAC cart
to be to open with one click, rather than clicking on the cart icon then
on the dropdown box to load the cart popup.

This commit is a combination of Owen Leonard's alternative patch
(slightly changing the markup in masthead.inc) and my
work to remove the dropdown elements from the template and basket.js

Test plan:
1. In Koha OPAC click on the cart icon (making sure to have items in the
   cart and the dropdown box 'Items in your cart:..' appears.

2. Click this dropdown and the cart popup appears.

3. Confirm you can successfully remove items from and empty the
   cart

4. Apply patch

5. Restart memcached, and plack

6. Click on the cart icon (making sure to have items in the cart) and
   notice no 'Items in your: ..' dropdown appears
   instead the cart popup loads straight away.

7. Confirm the items in your cart are displayed by the cart popup

8. Confirm you can remove items fr

[koha-commits] main Koha release repository branch master updated. v18.05.00-1065-g87c7e53

2018-10-18 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7 (commit)
  from  efd2b75b6741f95a79a88e0765bcb0802a7cf1fd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7
Author: Nick Clemens 
Date:   Thu Oct 18 10:05:38 2018 +

Bug 21593: Remove GROUP BY from GetAuthValueDropbox

With new MYSQL modes we are permitted only full group by.

In this case I don't think we need a GROUP BY at all

To test:
1 - Try to pay a fine or create a borrower
2 - Internal server error
3 - Apply patch
4 - Page should load
5 - Test various authorised values ot ensure they work
   e.g. Set bsort1 and bsort2 to have some authorised values with and
   without branch limits
   set PAYMENT_TYPE to have some values with and without branch limits

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

---

Summary of changes:
 Koha/Template/Plugin/AuthorisedValues.pm |1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits


[koha-commits] main Koha release repository branch master updated. v18.05.00-1078-g17e5691

2018-10-18 Thread Git repo owner
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
   via  17e5691daaa0f6b73623198eded648c78e40056a (commit)
   via  b7da4f890b9d9a7b2a919ce8529198ab443115cd (commit)
   via  573d9dafc10cb82e0f80f6fbbd8214ec88cfa3b6 (commit)
   via  489c636316209d4f4e7d8648cc5832347e792076 (commit)
   via  f19a99209528e85003cd56104640effe75e4f126 (commit)
   via  82884b0bd81a79c9a0c700463f1fcc632314863c (commit)
   via  a40b8ebde788ac4082670e30b03fcbade2cc5544 (commit)
   via  33c142ba3b7cfd37dd90569de2a5802849b09ef5 (commit)
   via  60e00a332e2a500746f12908042dd61250d1f79a (commit)
   via  7eb4d3f8a1537e1c9eea478f0802b30fae7690db (commit)
   via  5024cb3acffdfb9f67dce5587eb062ea3130bdbb (commit)
   via  f8e7a175575649ab1303c65ae259501dda90f3ff (commit)
   via  9e253d7bced1d10d7e3975871db985debba5a497 (commit)
  from  87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 17e5691daaa0f6b73623198eded648c78e40056a
Author: Jonathan Druart 
Date:   Thu Oct 18 11:07:02 2018 -0300

Bug 20521: Use a specific config for strict sql modes

To avoid disrupting testers and new developers it will be turned off by 
default.

We will turn it on for Jenkins so devs will have to take care of the
regressions they introduce (!)

Signed-off-by: Nick Clemens 

commit b7da4f890b9d9a7b2a919ce8529198ab443115cd
Author: Jonathan Druart 
Date:   Wed Oct 17 20:24:09 2018 -0300

Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price'

Fix t/db_dependent/selenium/basic_workflow.t

We want to send specific values depending on the data type in DB
For instance integer, or varchar(10)

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 573d9dafc10cb82e0f80f6fbbd8214ec88cfa3b6
Author: Jonathan Druart 
Date:   Wed Oct 17 19:26:32 2018 -0300

Bug 21597: Field 'description' doesn't have a default value

Nick proposed another fix, see bug 21594.
The interface does not explode so I do not think we should make a DB
update in a rush.

Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t

api_keys.description and api_keys.secret:
  `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL,
  `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,

#   Failed test 'Exception is thrown correctly'
#   at t/db_dependent/Koha/Object.t line 262.
# expecting: Koha::Exceptions::Object::FKConstraint
# found: DBIx::Class::Exception 
(DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a 
default value at /home/vagrant/kohaclone/Koha/Object.pm line 125
# )
# Looks like you planned 7 tests but ran 1.
# Looks like you failed 1 test of 1 run.

and later, but not related:
Can't locate object method "message" via package
"DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264.

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 489c636316209d4f4e7d8648cc5832347e792076
Author: Jonathan Druart 
Date:   Wed Oct 17 19:21:56 2018 -0300

Bug 21597: Incorrect date value: '0' for column 'onloan'

Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

items.onloan
  `onloan` date DEFAULT NULL,

DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for
column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm
line 288

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit f19a99209528e85003cd56104640effe75e4f126
Author: Jonathan Druart 
Date:   Wed Oct 17 19:18:58 2018 -0300

Bug 21597: Data too long for column 'invitekey'

Fix t/db_dependent/Virtualshelves.t

virtualshelfshares.invitekey
  `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,

We should not insert a longer string!

DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column
'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125

Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

commit 82884b0bd81a79c9a0c700463f1fcc632314863c
Author: Jonathan Druart 
Date:   Wed Oct 17 19:11:29 2018 -0300

Bug 21597: Field 'amount' doesn't have a default value

Fix t/db_dependent/Accounts.t

Default value could be 0, 

  1   2   3   4   5   6   7   8   9   10   >