[koha-commits] main Koha release repository annotated tag v19.11.12 created. v19.11.12
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.11.12 has been created at 7dca1a4b7be8f063f884c26f35e5460d270eda3e (tag) tagging d1fcec21015cf4f725e0632b2aeb2cb7280dea5d (commit) replaces v19.11.11 tagged by Aleisha Amohia on Tue Nov 24 13:52:31 2020 +1300 - Log - Koha release 19.11.12 -BEGIN PGP SIGNATURE- iQIzBAABCgAdFiEEsrg4Ma6lEmRo36iNRUuHZJtbty8FAl+8WU8ACgkQRUuHZJtb ty87zw//dTpbjtQIgH4MtzCOzMBMObcofFhxjNd+Xxng7zuvgxyn8p1ytda2HBxt 4+1Ri+USlI/NkwteqsysQ3SWgrrz6sODESF4d2G4NH7TqhXhLGV8mzQw4ueHEwOV ib5EtjyTGI5zt1s1mfpc27x1Cx4p+uztSAWk/G1O4DYaPzgG/31BYBneQ40grTb0 drF4ixwgsvXiLpXBc/nnVsLWGmlrcvhgogzye983/rkIaBmvrB3o2j3sV2MiICnh tCcXu6Ri2cIjmfFqildnAftPQr5XsKgWbJndTQ786h//4oeh70UW7c6AjyURlQj+ gtzKSIVl9v7zmPXymzOhQBsvY3QIojjZUZ1KTwLnZfZjnwiqLYSPCTE4zrwrFdz2 3i9GvKEFzugmGHPMnypf5/ji0Z7WuM90EocchUdoJSDUQ/3XpRywAf85OheDv5QP hMopK+lN/+Ego8cFx9OtD++Nn4FxeQAfpn9X00/+NLLPYH7iPbyH5rFUhuhfvl8D 8K+Pr+VIlfg5W/hYWbNM6vKf92lSFWAfMh58q3WJ+rrVCGN9LjmDH9G7d9dKvCJD jIlX/FqrDpEZDnqp1vpzld0pcPOb7lr2IWBUulB8bMpn07k8eOms550csd3HTfXY lIF/NF4BFsPZj6Q3SJ0jxPFHtGmutqAzKX5SSs8wKS/NeJyKQ1U= =uhKB -END PGP SIGNATURE- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Aleisha Amohia (7): Bug 25242: Compile CSS Bug 26569: DBRev 19.11.11.001 Bug 18050: DBIC Bug 18050: DBRev 19.11.11.002 Fixing po files for 19.11.12 Increment version for 19.11.12 release Update release notes for 19.11.12 release Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations David Cook (1): Bug 26496: Add op field to Budget Planning Emmi Takkinen (1): Bug 26429: Show correct expiration date at the request.pl Fridolin Somers (1): Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (4): Bug 20804: Add tests Bug 20804: Add support for "days" to the timeout syspref Bug 26639: Add auto_savepoint to DBIC connection Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration Katrin Fischer (5): Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Bug 26190: Allow to close a basket with only cancelled order lines Bug 26727: Fix appearing in the templates Koha translators (1): Translation updates for Koha 19.11.12 Kyle M Hall (1): Bug 26604: "Generate next" button gives error on serials-collection.pl Marcel de Rooy (1): Bug 26191: Relocate track_login call in Auth.pm Mark Hofstetter (1): Bug 26601: Add utf8 encoding to text output of overdue_notices.pl Martin Renvoize (2): Bug 25242: Improve column wrapping for holdingst Bug 25549: Add error reporting to plugins-home Mason James (1): Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error Nick Clemens (4): Bug 25549: Remove plugin methods for broken plugins Bug 8437: Exclude export.pl from plack Bug 18051: Set UTF8 Flag for record searches/imports from rancor Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Owen Leonard (2): Bug 26497: "Hide all columns" throws Javascript error on aqplan.pl Bug 26727: (follow-up) More markup corrections Phil Ringnalda (2): Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record Bug 26605: Correctly URI-encode query string in call number browse plugin --- hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-39-gd1fcec2101
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via d1fcec21015cf4f725e0632b2aeb2cb7280dea5d (commit)
from fd6ccb4a54281a3799f3646280233f8871aeab3b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit d1fcec21015cf4f725e0632b2aeb2cb7280dea5d
Author: Aleisha Amohia
Date: Tue Nov 24 13:51:36 2020 +1300
Update release notes for 19.11.12 release
Signed-off-by: Aleisha Amohia
---
Summary of changes:
...s_19_11_11.html => release_notes_19_11_12.html} | 225 +++-
misc/release_notes/release_notes_19_11_12.md | 381 +
2 files changed, 529 insertions(+), 77 deletions(-)
copy misc/release_notes/{release_notes_19_11_11.html =>
release_notes_19_11_12.html} (57%)
create mode 100644 misc/release_notes/release_notes_19_11_12.md
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-38-gfd6ccb4a54
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fd6ccb4a54281a3799f3646280233f8871aeab3b (commit) via 66170d0b530d56716739eaada912fbd9d3148c68 (commit) via 0e9bbcb6072960b7784107732c08d47dc9ab9aa1 (commit) from f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit fd6ccb4a54281a3799f3646280233f8871aeab3b Author: Aleisha Amohia Date: Tue Nov 24 13:45:39 2020 +1300 Increment version for 19.11.12 release Signed-off-by: Aleisha Amohia commit 66170d0b530d56716739eaada912fbd9d3148c68 Author: Aleisha Amohia Date: Tue Nov 24 13:42:58 2020 +1300 Fixing po files for 19.11.12 Signed-off-by: Aleisha Amohia commit 0e9bbcb6072960b7784107732c08d47dc9ab9aa1 Author: Koha translators <> Date: Mon Nov 23 21:32:06 2020 -0300 Translation updates for Koha 19.11.12 Signed-off-by: Aleisha Amohia --- Summary of changes: Koha.pm |2 +- installer/data/mysql/updatedatabase.pl |6 + misc/translator/po/am-Ethi-marc-MARC21.po |2 +- misc/translator/po/am-Ethi-marc-NORMARC.po |2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po |2 +- misc/translator/po/am-Ethi-opac-bootstrap.po|2 +- misc/translator/po/am-Ethi-staff-prog.po| 334 ++--- misc/translator/po/ar-Arab-marc-MARC21.po |2 +- misc/translator/po/ar-Arab-marc-NORMARC.po |2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po |2 +- misc/translator/po/ar-Arab-opac-bootstrap.po|2 +- misc/translator/po/ar-Arab-staff-prog.po| 334 ++--- misc/translator/po/as-IN-marc-MARC21.po |2 +- misc/translator/po/as-IN-marc-NORMARC.po|2 +- misc/translator/po/as-IN-marc-UNIMARC.po|2 +- misc/translator/po/as-IN-opac-bootstrap.po |2 +- misc/translator/po/as-IN-staff-prog.po | 334 ++--- misc/translator/po/az-AZ-marc-MARC21.po |2 +- misc/translator/po/az-AZ-marc-NORMARC.po|2 +- misc/translator/po/az-AZ-marc-UNIMARC.po|2 +- misc/translator/po/az-AZ-opac-bootstrap.po |2 +- misc/translator/po/az-AZ-staff-prog.po | 334 ++--- misc/translator/po/be-BY-marc-MARC21.po |2 +- misc/translator/po/be-BY-marc-NORMARC.po|2 +- misc/translator/po/be-BY-marc-UNIMARC.po|2 +- misc/translator/po/be-BY-opac-bootstrap.po |2 +- misc/translator/po/be-BY-staff-prog.po | 334 ++--- misc/translator/po/bg-Cyrl-marc-MARC21.po |2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po |2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po |2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po|2 +- misc/translator/po/bg-Cyrl-staff-prog.po| 334 ++--- misc/translator/po/bn-IN-marc-MARC21.po |2 +- misc/translator/po/bn-IN-marc-NORMARC.po|2 +- misc/translator/po/bn-IN-marc-UNIMARC.po|2 +- misc/translator/po/bn-IN-opac-bootstrap.po |2 +- misc/translator/po/bn-IN-staff-prog.po | 334 ++--- misc/translator/po/ca-ES-marc-MARC21.po |2 +- misc/translator/po/ca-ES-marc-NORMARC.po|2 +- misc/translator/po/ca-ES-marc-UNIMARC.po|2 +- misc/translator/po/ca-ES-opac-bootstrap.po |2 +- misc/translator/po/ca-ES-staff-prog.po | 342 ++--- misc/translator/po/cs-CZ-marc-MARC21.po |2 +- misc/translator/po/cs-CZ-marc-NORMARC.po|2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po|2 +- misc/translator/po/cs-CZ-opac-bootstrap.po |6 +- misc/translator/po/cs-CZ-staff-prog.po | 338 ++--- misc/translator/po/cy-GB-marc-MARC21.po |2 +- misc/translator/po/cy-GB-marc-NORMARC.po|2 +- misc/translator/po/cy-GB-marc-UNIMARC.po|2 +- misc/translator/po/cy-GB-opac-bootstrap.po |2 +- misc/translator/po/cy-GB-staff-prog.po | 334 ++--- misc/translator/po/da-DK-marc-MARC21.po |2 +- misc/translator/po/da-DK-marc-NORMARC.po|2 +- misc/translator/po/da-DK-marc-UNIMARC.po|2 +- misc/translator/po/da-DK-opac-bootstrap.po |2 +- misc/translator/po/da-DK-staff-prog.po | 334 ++--- misc/translator/po/de-CH-marc-MARC21.po |2 +- misc/translator/po/de-CH-marc-NORMARC.po|2 +- misc/translator/po/de-CH-marc-UNIMARC.po|2 +- misc/translator/po/de-CH-opac-bootstrap.po
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-35-gf287fdfd81
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3 (commit)
from 321afcfe745e1423f106bfa435e452191c4a7fd7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit f287fdfd81a2b0c1868c7d089b99ffee4d2e62b3
Author: Fridolin Somers
Date: Tue Nov 3 09:19:34 2020 +0100
Bug 26904: OPAC password recovery allows regexp in email
When using OPAC password recovery form, opac/opac-password-recovery.pl :
if one provides correct login and an email, there is a check that this
email is one of patron's.
This check uses RegExp with case insensitive :
if ( $email && !( any { /^$email$/i } @emails ) )
This is a security issue since one can simply enter '.*'.
Severity is normal because the login must be a correct.
I propose to use simple string compare with lowercase to be case
insensitive.
Test plan :
1) Don't apply patch
2) Enable system preference 'OpacResetPassword'
3) Go to 'OPAC > Log in to your account > Forgot your password?'
4) Enter an existing userid or cardnumber and '.*' in 'Email'
5) The password recovery is created ! (check table
'borrower_password_recovery')
6) Apply patch
7) Enter an existing userid or cardnumber and '.*' in 'Email'
8) You get the message 'No account was found with the provided information.'
9) Enter an existing userid or cardnumber and in 'Email' the corresponding
email but with different case
10) The password recovery is created (check table
'borrower_password_recovery')
Signed-off-by: Nick Clemens
Signed-off-by: Julian Maurice
Signed-off-by: Jonathan Druart
(cherry picked from commit 904e926ba0f407b24aa3d94be5afe37b5e3ec075)
Signed-off-by: Lucas Gass
(cherry picked from commit 57a9bf3ef2e4f25227a10f16cec7fb34e162199e)
Signed-off-by: Aleisha Amohia
---
Summary of changes:
opac/opac-password-recovery.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-34-g321afcfe74
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 321afcfe745e1423f106bfa435e452191c4a7fd7 (commit) from 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 321afcfe745e1423f106bfa435e452191c4a7fd7 Author: Nick Clemens Date: Fri Sep 4 12:47:58 2020 + Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve For cron purposes this is the correct behaviour. For display purposes we wish to see on_reserve over too_soon This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses To test: 1 - set NoRenewalBeforePrecision to date only 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days 3 - check item out 4 - confirm item shows Scheduled For Automatic Renewal in issues table 5 - place a hold on the item for another patron 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold" 7 - change No Renewal Before value to 7 8 - reload issues table for patron 1, confirm checkout now shows "on hold" 9 - Apply patch 10 - restart_all 11 - Reload the issues table - confirm 'on_hold' still shows 12 - Change No Renewal Before to 0 13 - Refresh issues table, still shows 'On hold' 14 - perl misc/cronjobs/automatic_renewals.pl -v 15 - Result shows 'auto_too_soon' 16 - prove -v t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Aleisha Amohia --- Summary of changes: C4/Circulation.pm | 26 -- misc/cronjobs/automatic_renewals.pl | 2 +- t/db_dependent/Circulation.t| 10 -- 3 files changed, 25 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository annotated tag v20.05.06 created. v20.05.06
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v20.05.06 has been created at d7cd4b33df36e3b3e65bd057d52461c0cb9979bf (tag) tagging bf38a864d493fc246d51ff6711b362a359d48617 (commit) replaces v20.05.05 tagged by Lucas Gass on Mon Nov 23 16:34:14 2020 -0700 - Log - Koha release 20.05.06 -BEGIN PGP SIGNATURE- iQEzBAABCAAdFiEEiuLrhIFCDD7BMEVj+cc4/xIeRdoFAl+8RvYACgkQ+cc4/xIe RdqqMQgAiL1P0sOjSYoPFVLep5AFWwmuY0ur7WyDbhSS/Ir7S/jXqP8euHHRkc3i ewemsPyVX4LTz30BzLiErDOzOnDXdP5bc/O6Nd+gWhFbAnPFIr3DkK0MCXnp4BW3 NRpN7AKPs1P0r++Sy/1h279GXucYNKWG0AYFP56JZs/hxO5Pvalzf6rsqKDMQmk6 2S1cv2exFPs71tMq9QdlO9Dbxv0nNz9wx064i7ILT0RIObWkmzOdH6RPvUGTiDCk pxlCBJISuhN/e0E/XQa9kpjICm+jJ4eHuj3g3EGnXN7a4myZ/20C7VGVZQgQCPI0 BcF3dKWWH8dQgZxSfCzNLXSiefVHMw== =j20G -END PGP SIGNATURE- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andreas Roussos (2): Bug 26449: fix web installer typo Bug 26450: fix typo in plugin template Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations Björn Nylén (1): Bug 26750: Deleted items not indexed Blou (1): Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm David Cook (4): Bug 26496: Add op field to Budget Planning Bug 26673: Remove #!/usr/bin/env perl from .pm modules too Bug 26853: Harmonize import_biblios with biblio and biblioitems Bug 26853: Throw a fatal error if import_biblios insert fails Didier Gautheron (3): Bug 26232: Test for empty smart rule fine grace period Bug 26232: Empty smart rule fine grace period Bug 25167: Fix to a fix wrong inventory results Emmi Takkinen (2): Bug 26429: Show correct expiration date at the request.pl Bug 9118: Do not show option to create exception on range for unique holiday Fridolin Somers (6): Bug 26538: Display cities list before input text Bug 26487: Add all MARC flavours for not-onloan-count search field Bug 26832: Make Elasticsearch mappings export use UTF-8 Bug 26594: add Unit Test Bug 26594: Fix patrons merge problem with restrictions Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (15): Bug 26137: Remove warnings from viewlog.pl Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan Bug 20804: Add tests Bug 20804: Add support for "days" to the timeout syspref Bug 26445: Fix "back to result" link of the search result browser Bug 26673: Remove shebangs from Perl modules Bug 26673: Fix perlcritic complains Bug 26639: Add auto_savepoint to DBIC connection Bug 26915: Fix FinePaymentAutoPopup behaviour Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records contain itemnumber Katrin Fischer (11): Bug 9118: (QA follow-up) Fix spelling on "To Date :" Bug 26018: Fix frameworks errors with subfields in wrong tab Bug 26686: Fix sorting of "updated on" and "time created" on notices tab Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Bug 26526: Relabel checkout note column in OPAC Bug 26696: Fix colspan in payment table when credit exists Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference Bug 26190: Allow to close a basket with only cancelled order lines Bug 26727: Fix appearing in the templates Koha translators (1): Translation updates for Koha 20.05.06 Kyle M Hall (5): Bug 26604: "Generate next" button gives error on serials-collection.pl Bug 26627: Print and confirming a hold can cause an infinite loop Bug 26627: (QA follow-up) Remove barcode input by id Bug 26908: Restore ability to view and select EDI plugins for a vendor account Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method Lisette Scheer (1): Bug 26723:
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-114-gbf38a864d4
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via bf38a864d493fc246d51ff6711b362a359d48617 (commit) from 604b0c5b75a78196f394298781fb881204da25a5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit bf38a864d493fc246d51ff6711b362a359d48617 Author: Lucas Gass Date: Mon Nov 23 23:31:13 2020 + Update release notes for 20.05.06 release Signed-off-by: Lucas Gass --- Summary of changes: misc/release_notes/release_notes_20_05_06.html | 619 + misc/release_notes/release_notes_20_05_06.md | 498 2 files changed, 1117 insertions(+) create mode 100644 misc/release_notes/release_notes_20_05_06.html create mode 100644 misc/release_notes/release_notes_20_05_06.md hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-113-g604b0c5b75
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 604b0c5b75a78196f394298781fb881204da25a5 (commit) via 63191a724e6970f3a683f29d56f32442bd59a908 (commit) from 57a9bf3ef2e4f25227a10f16cec7fb34e162199e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 604b0c5b75a78196f394298781fb881204da25a5 Author: Lucas Gass Date: Mon Nov 23 23:24:28 2020 + Increment version for 20.05.06 release Signed-off-by: Lucas Gass commit 63191a724e6970f3a683f29d56f32442bd59a908 Author: Koha translators <> Date: Mon Nov 23 20:13:16 2020 -0300 Translation updates for Koha 20.05.06 Signed-off-by: Lucas Gass --- Summary of changes: Koha.pm |2 +- installer/data/mysql/updatedatabase.pl |6 + misc/translator/po/am-Ethi-marc-MARC21.po |2 +- misc/translator/po/am-Ethi-marc-NORMARC.po |2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po |4 +- misc/translator/po/am-Ethi-messages-js.po |8 +- misc/translator/po/am-Ethi-messages.po |7 +- misc/translator/po/am-Ethi-opac-bootstrap.po| 449 +- misc/translator/po/am-Ethi-pref.po | 12 +- misc/translator/po/am-Ethi-staff-prog.po| 972 ++-- misc/translator/po/ar-Arab-marc-MARC21.po |2 +- misc/translator/po/ar-Arab-marc-NORMARC.po |2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 14 +- misc/translator/po/ar-Arab-messages-js.po | 30 +- misc/translator/po/ar-Arab-messages.po | 11 +- misc/translator/po/ar-Arab-opac-bootstrap.po| 451 +- misc/translator/po/ar-Arab-pref.po | 28 +- misc/translator/po/ar-Arab-staff-prog.po| 998 ++-- misc/translator/po/as-IN-marc-MARC21.po |2 +- misc/translator/po/as-IN-marc-NORMARC.po|2 +- misc/translator/po/as-IN-marc-UNIMARC.po|4 +- misc/translator/po/as-IN-messages-js.po |8 +- misc/translator/po/as-IN-messages.po|7 +- misc/translator/po/as-IN-opac-bootstrap.po | 449 +- misc/translator/po/as-IN-pref.po| 12 +- misc/translator/po/as-IN-staff-prog.po | 972 ++-- misc/translator/po/az-AZ-marc-MARC21.po |2 +- misc/translator/po/az-AZ-marc-NORMARC.po|2 +- misc/translator/po/az-AZ-marc-UNIMARC.po|8 +- misc/translator/po/az-AZ-messages-js.po |8 +- misc/translator/po/az-AZ-messages.po|7 +- misc/translator/po/az-AZ-opac-bootstrap.po | 449 +- misc/translator/po/az-AZ-pref.po| 12 +- misc/translator/po/az-AZ-staff-prog.po | 972 ++-- misc/translator/po/be-BY-marc-MARC21.po |2 +- misc/translator/po/be-BY-marc-NORMARC.po|2 +- misc/translator/po/be-BY-marc-UNIMARC.po|6 +- misc/translator/po/be-BY-messages-js.po |8 +- misc/translator/po/be-BY-messages.po|7 +- misc/translator/po/be-BY-opac-bootstrap.po | 449 +- misc/translator/po/be-BY-pref.po| 12 +- misc/translator/po/be-BY-staff-prog.po | 972 ++-- misc/translator/po/bg-Cyrl-marc-MARC21.po |2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po |2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po |4 +- misc/translator/po/bg-Cyrl-messages-js.po |8 +- misc/translator/po/bg-Cyrl-messages.po |7 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po| 449 +- misc/translator/po/bg-Cyrl-pref.po | 12 +- misc/translator/po/bg-Cyrl-staff-prog.po| 972 ++-- misc/translator/po/bn-IN-marc-MARC21.po |2 +- misc/translator/po/bn-IN-marc-NORMARC.po|2 +- misc/translator/po/bn-IN-marc-UNIMARC.po|4 +- misc/translator/po/bn-IN-messages-js.po | 31 +- misc/translator/po/bn-IN-messages.po| 64 +- misc/translator/po/bn-IN-opac-bootstrap.po | 478 +- misc/translator/po/bn-IN-pref.po| 12 +- misc/translator/po/bn-IN-staff-prog.po | 996 ++-- misc/translator/po/ca-ES-marc-MARC21.po |2 +- misc/translator/po/ca-ES-marc-NORMARC.po|2 +- misc/translator/po/ca-ES-marc-UNIMARC.po|4 +- misc/translator/po/ca-ES-messages-js.po |8 +- misc/translator/po/ca-ES-messages.po|7 +- misc/translator/po/ca-ES-opac-bootstrap.po | 450 +- misc/translator/po/ca-ES-pref.po| 12 +-
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-111-g57a9bf3ef2
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via 57a9bf3ef2e4f25227a10f16cec7fb34e162199e (commit)
from 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 57a9bf3ef2e4f25227a10f16cec7fb34e162199e
Author: Fridolin Somers
Date: Tue Nov 3 09:19:34 2020 +0100
Bug 26904: OPAC password recovery allows regexp in email
When using OPAC password recovery form, opac/opac-password-recovery.pl :
if one provides correct login and an email, there is a check that this
email is one of patron's.
This check uses RegExp with case insensitive :
if ( $email && !( any { /^$email$/i } @emails ) )
This is a security issue since one can simply enter '.*'.
Severity is normal because the login must be a correct.
I propose to use simple string compare with lowercase to be case
insensitive.
Test plan :
1) Don't apply patch
2) Enable system preference 'OpacResetPassword'
3) Go to 'OPAC > Log in to your account > Forgot your password?'
4) Enter an existing userid or cardnumber and '.*' in 'Email'
5) The password recovery is created ! (check table
'borrower_password_recovery')
6) Apply patch
7) Enter an existing userid or cardnumber and '.*' in 'Email'
8) You get the message 'No account was found with the provided information.'
9) Enter an existing userid or cardnumber and in 'Email' the corresponding
email but with different case
10) The password recovery is created (check table
'borrower_password_recovery')
Signed-off-by: Nick Clemens
Signed-off-by: Julian Maurice
Signed-off-by: Jonathan Druart
(cherry picked from commit 904e926ba0f407b24aa3d94be5afe37b5e3ec075)
Signed-off-by: Lucas Gass
---
Summary of changes:
opac/opac-password-recovery.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.17
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via cd251c73174f269a9da3ba4bc119f94dcf98c566 (commit)
via a8a868935f63063e71a77f56b0f1fe0fba472691 (commit)
via c3e648207c82784dc3d469cae035a199ebf94a0c (commit)
via c016454fa6aefdce4e70ce5d76542173395409e4 (commit)
via e9b9e1510641c8385d2a7b8d53fc799f9224464e (commit)
from a5c2090ff5853f839a8021d52494cfcba9a2c1be (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit cd251c73174f269a9da3ba4bc119f94dcf98c566
Author: Victor Grousset/tuxayo
Date: Mon Nov 23 16:22:33 2020 +0100
Update release notes for 19.05.17 release
Signed-off-by: Victor Grousset/tuxayo
commit a8a868935f63063e71a77f56b0f1fe0fba472691
Author: Victor Grousset/tuxayo
Date: Mon Nov 23 15:14:12 2020 +0100
Increment version for 19.05.17 release
Signed-off-by: Victor Grousset/tuxayo
commit c3e648207c82784dc3d469cae035a199ebf94a0c
Author: Victor Grousset/tuxayo
Date: Mon Nov 23 15:06:58 2020 +0100
Fix translations for Koha 19.05.17
Signed-off-by: Victor Grousset/tuxayo
commit c016454fa6aefdce4e70ce5d76542173395409e4
Author: Koha translators <>
Date: Mon Nov 23 10:23:10 2020 -0300
Translation updates for Koha 19.05.17
Signed-off-by: Victor Grousset/tuxayo
commit e9b9e1510641c8385d2a7b8d53fc799f9224464e
Author: Fridolin Somers
Date: Tue Nov 3 09:19:34 2020 +0100
Bug 26904: OPAC password recovery allows regexp in email
When using OPAC password recovery form, opac/opac-password-recovery.pl :
if one provides correct login and an email, there is a check that this
email is one of patron's.
This check uses RegExp with case insensitive :
if ( $email && !( any { /^$email$/i } @emails ) )
This is a security issue since one can simply enter '.*'.
Severity is normal because the login must be a correct.
I propose to use simple string compare with lowercase to be case
insensitive.
Test plan :
1) Don't apply patch
2) Enable system preference 'OpacResetPassword'
3) Go to 'OPAC > Log in to your account > Forgot your password?'
4) Enter an existing userid or cardnumber and '.*' in 'Email'
5) The password recovery is created ! (check table
'borrower_password_recovery')
6) Apply patch
7) Enter an existing userid or cardnumber and '.*' in 'Email'
8) You get the message 'No account was found with the provided information.'
9) Enter an existing userid or cardnumber and in 'Email' the corresponding
email but with different case
10) The password recovery is created (check table
'borrower_password_recovery')
Signed-off-by: Nick Clemens
Signed-off-by: Julian Maurice
Backport to 19.05.x:
Signed-off-by: Victor Grousset/tuxayo
---
Summary of changes:
Koha.pm| 2 +-
installer/data/mysql/updatedatabase.pl | 7 +
...s_19_05_16.html => release_notes_19_05_17.html} | 164 +
...notes_19_05_16.md => release_notes_19_05_17.md} | 153 +++
misc/translator/po/am-Ethi-marc-MARC21.po | 2 +-
misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +-
misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +-
misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +-
misc/translator/po/am-Ethi-staff-prog.po | 40 ++---
misc/translator/po/ar-Arab-marc-MARC21.po | 2 +-
misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +-
misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +-
misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +-
misc/translator/po/ar-Arab-staff-prog.po | 40 ++---
misc/translator/po/as-IN-marc-MARC21.po| 2 +-
misc/translator/po/as-IN-marc-NORMARC.po | 2 +-
misc/translator/po/as-IN-marc-UNIMARC.po | 2 +-
misc/translator/po/as-IN-opac-bootstrap.po | 2 +-
misc/translator/po/as-IN-staff-prog.po | 40 ++---
misc/translator/po/az-AZ-marc-MARC21.po| 2 +-
misc/translator/po/az-AZ-marc-NORMARC.po | 2 +-
misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +-
misc/translator/po/az-AZ-opac-bootstrap.po | 2 +-
misc/translator/po/az-AZ-staff-prog.po | 40 ++---
misc/translator/po/be-BY-marc-MARC21.po| 2 +-
misc/translator/po/be-BY-marc-NORMARC.po | 2 +-
misc/translator/po/be-BY-marc-UNIMARC.po | 2 +-
[koha-commits] main Koha release repository annotated tag v19.05.17 created. v19.05.17
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v19.05.17 has been created at 5c1a54bc0741f88bb02b905f7482382bddd6947d (tag) tagging cd251c73174f269a9da3ba4bc119f94dcf98c566 (commit) replaces v19.05.16 tagged by Victor Grousset/tuxayo on Mon Nov 23 16:36:12 2020 +0100 - Log - Koha release 19.05.17 -BEGIN PGP SIGNATURE- iHUEABYIAB0WIQRT86JTIbcYFBCjtfABQKyjt9hwuwUCX7vW7QAKCRABQKyjt9hw uwACAP0YzkOn+Xi/vHON4paqG+gy6/09anvGmFU0F+TWVCzirQD9EQoTwMEp7Y3R B5BC0w4NGAgJAYuZ3NZfzOjPqE0RLQ0= =10nS -END PGP SIGNATURE- Agustín Moyano (1): Bug 18050: (follow-up) Force adding FK constraint Aleisha Amohia (2): Bug 26569: DBRev 19.05.16.001 Bug 18050: DBRev 19.05.16.002 Alex Buckley (1): Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Andrew Fuerste-Henry (1): Bug 26569: Use gender neutral pronouns in system prefernece explanations David Cook (1): Bug 26496: Add op field to Budget Planning Fridolin Somers (1): Bug 26904: OPAC password recovery allows regexp in email John Fawcett (2): Bug 26612: Error during web install for it-IT translation Bug 26613: Fix it-IT unimarc_framework.sql installer file Jonathan Druart (2): Bug 26260: Add missing elastic>cnx_pool to koha-conf-site.xml.in Bug 26639: Add auto_savepoint to DBIC connection Katrin Fischer (4): Bug 24780: Make items.stocknumber show up in batch item modification Bug 18050: Add FK constraint on aqbudgets.budget_period_id Bug 18050: Add relation alias to schema Bug 18050: (QA follow-up) Adjust conditions and make use of message text Koha translators (1): Translation updates for Koha 19.05.17 Kyle M Hall (1): Bug 26604: "Generate next" button gives error on serials-collection.pl Mark Hofstetter (1): Bug 26601: Add utf8 encoding to text output of overdue_notices.pl Martin Renvoize (2): Bug 25665: (Bug 23382: (RM follow-up) Revert "hours_between should match...") Bug 25665: (Bug 23382: (RM follow-up) Ensure tests pass on Wednesdays) Mason James (1): Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error Nick Clemens (2): Bug 26224: Prevent double submit of header check in form Bug 18051: Set UTF8 Flag for record searches/imports from rancor Phil Ringnalda (1): Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record Victor Grousset (4): Bug 18050: DBIC Fix translations for Koha 19.05.17 Increment version for 19.05.17 release Update release notes for 19.05.17 release --- hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-110-g4c10f83dc0
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 (commit) from b0eeddf4bc159e0a638f9e79acf21e98d6230048 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4c10f83dc00ff1b94810a56cf4e7f3a5f97b3c95 Author: Nick Clemens Date: Fri Sep 4 12:47:58 2020 + Bug 25758: Return on_reserve over too_soon when not calling from automatic_renewals cron Bug 19014 altered CanBookBeRenewed to return (auto_)too_soon over on_reserve For cron purposes this is the correct behaviour. For display purposes we wish to see on_reserve over too_soon This patchset adds a switch to 'CanBookBeRenewed' to alter the priority of these statuses To test: 1 - set NoRenewalBeforePrecision to date only 2 - set a circ rule to auto-renewal=yes, no renewal before=0, checkout period to 7 days 3 - check item out 4 - confirm item shows Scheduled For Automatic Renewal in issues table 5 - place a hold on the item for another patron 6 - reload issues table for patron 1, confirm checkout still shows "scheduled for automatic renewal" rather than "on hold" 7 - change No Renewal Before value to 7 8 - reload issues table for patron 1, confirm checkout now shows "on hold" 9 - Apply patch 10 - restart_all 11 - Reload the issues table - confirm 'on_hold' still shows 12 - Change No Renewal Before to 0 13 - Refresh issues table, still shows 'On hold' 14 - perl misc/cronjobs/automatic_renewals.pl -v 15 - Result shows 'auto_too_soon' 16 - prove -v t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit ff08e99965ccb60092b5bdd5181fd517e1fab161) Signed-off-by: Lucas Gass --- Summary of changes: C4/Circulation.pm | 26 -- misc/cronjobs/automatic_renewals.pl | 2 +- t/db_dependent/Circulation.t| 10 -- 3 files changed, 25 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-109-gb0eeddf4bc
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via b0eeddf4bc159e0a638f9e79acf21e98d6230048 (commit)
from 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit b0eeddf4bc159e0a638f9e79acf21e98d6230048
Author: Jonathan Druart
Date: Thu Nov 19 15:16:36 2020 +0100
Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records
contain itemnumber
Prior to ug 23463 AddItemFromMarc where calling AddItem, that did not
take into account the itemnumber field.
Now that we are using Koha::Item, we need to remove the items.itemnumber
field from the MARC record
Test plan:
1 - find an existing bib in your system with just one item
2 - export that bib with the item attached
3 - delete the barcode from your item in Koha
4 - stage your exported marc file for reimport, match on biblionumber, set
it to Always Add Items
5 - confirm that the bib matches and the incoming 952 is parsed
6 - click "Import this batch into the catalog"
=> Without this patch you get (in the logs, or hidden)
manage-marc-import.pl: DBD::mysql::st execute failed: Duplicate entry '23'
for key 'PRIMARY' [for Statement "INSERT INTO `items` ( `barcode`,
`biblioitemnumber`, `biblionumber`, `ccode`, `cn_sort`, `cn_source`,
`damaged_on`, `dateaccessioned`, `datelastborrowed`, `datelastseen`,
`holdingbranch`, `homebranch`, `itemcallnumber`, `itemlost_on`, `itemnumber`,
`itype`, `location`, `more_subfields_xml`, `onloan`, `permanent_location`,
`replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with
ParamValues: 0="BC_23", 1=8, 2=8, 3="REF", 4='CN__23', 5=undef, 6=undef,
7="2014-09-04", 8=undef, 9="2014-09-04", 10="FPL", 11="FPL", 12="CN_23",
13=undef, 14="23", 15="BK", 16="GEN", 17=undef, 18=undef, 19="GEN",
20="2014-09-04", 21=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
manage-marc-import.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate
entry '23' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 169
manage-marc-import.pl: {UNKNOWN}: Transaction aborted: Duplicate ID.
Rollback failed: DBIx::Class::Storage::txn_rollback(): Refusing to roll back
without a started transaction at /kohadevbox/koha/tools/manage-marc-import.pl
line 253 at /kohadevbox/koha/tools/manage-marc-import.pl line 253
=> With this patch applied, the new item must be added to the existing
bibliographic record
Signed-off-by: David Nind
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
Signed-off-by: Lucas Gass
---
Summary of changes:
C4/ImportBatch.pm | 4
1 file changed, 4 insertions(+)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v20.05.00-1913-g9d8523ed2b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 9d8523ed2b88c8fbf18fc61835967ff555a5dc55 (commit)
via a9e3db201e1863b30ac0e2654d82a15f0f8e44c0 (commit)
via 279ce72e4ced3ca191a8ee4e109c28df169dfc20 (commit)
via 6267eb7cba91ad8177cc60c4c7cba0b26b473cee (commit)
via 181125242c33d439fb6bdbddccb6a86a03fa8c15 (commit)
via 36a6ce301f961b0cefdca70ed9a903a1216e071f (commit)
via a508d3fcbec2c1d64b94fe66b288b28cc6998e37 (commit)
via cc970464ec7c881aaa9d8a33931a29a5951e6103 (commit)
from 926ad3c1a69074b2905d9ef03e639db6ba8d6865 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 9d8523ed2b88c8fbf18fc61835967ff555a5dc55
Author: Tomas Cohen Arazi
Date: Fri Nov 20 11:04:04 2020 -0300
Bug 26922: Regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
commit a9e3db201e1863b30ac0e2654d82a15f0f8e44c0
Author: Tomas Cohen Arazi
Date: Thu Nov 19 13:09:47 2020 -0300
Bug 26922: Better error handling in SendAlerts
This patch makes SendAlerts display a better error message when sending
fails.
To test:
1. Set KohaAdminEmailAddress to ad...@example.org
2. Edit a vendor, set a valid email address
3. Create a new basket, a new order. Send the basket
=> FAIL: As you did not configure a valid SMTP server, the email is not
sent and logs displayed "unable to establish SMTP connection to (localhost)
port 25", with the stracktrace.
4. Apply this patch and reload all
5. Repeat 3
=> SUCCESS: A simpler message is displayed, the stacktrace remains in
the logs
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
commit 279ce72e4ced3ca191a8ee4e109c28df169dfc20
Author: Jonathan Druart
Date: Thu Nov 19 15:16:36 2020 +0100
Bug 26557: (bug 23463 follow-up) Fix Batch import when incoming records
contain itemnumber
Prior to ug 23463 AddItemFromMarc where calling AddItem, that did not
take into account the itemnumber field.
Now that we are using Koha::Item, we need to remove the items.itemnumber
field from the MARC record
Test plan:
1 - find an existing bib in your system with just one item
2 - export that bib with the item attached
3 - delete the barcode from your item in Koha
4 - stage your exported marc file for reimport, match on biblionumber, set
it to Always Add Items
5 - confirm that the bib matches and the incoming 952 is parsed
6 - click "Import this batch into the catalog"
=> Without this patch you get (in the logs, or hidden)
manage-marc-import.pl: DBD::mysql::st execute failed: Duplicate entry '23'
for key 'PRIMARY' [for Statement "INSERT INTO `items` ( `barcode`,
`biblioitemnumber`, `biblionumber`, `ccode`, `cn_sort`, `cn_source`,
`damaged_on`, `dateaccessioned`, `datelastborrowed`, `datelastseen`,
`holdingbranch`, `homebranch`, `itemcallnumber`, `itemlost_on`, `itemnumber`,
`itype`, `location`, `more_subfields_xml`, `onloan`, `permanent_location`,
`replacementpricedate`, `timestamp`, `withdrawn_on`) VALUES ( ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with
ParamValues: 0="BC_23", 1=8, 2=8, 3="REF", 4='CN__23', 5=undef, 6=undef,
7="2014-09-04", 8=undef, 9="2014-09-04", 10="FPL", 11="FPL", 12="CN_23",
13=undef, 14="23", 15="BK", 16="GEN", 17=undef, 18=undef, 19="GEN",
20="2014-09-04", 21=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1836.
manage-marc-import.pl: DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate
entry '23' for key 'PRIMARY' at /kohadevbox/koha/Koha/Object.pm line 169
manage-marc-import.pl: {UNKNOWN}: Transaction aborted: Duplicate ID.
Rollback failed: DBIx::Class::Storage::txn_rollback(): Refusing to roll back
without a started transaction at /kohadevbox/koha/tools/manage-marc-import.pl
line 253 at /kohadevbox/koha/tools/manage-marc-import.pl line 253
=> With this patch applied, the new item must be added to the existing
bibliographic record
Signed-off-by: David Nind
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
commit 6267eb7cba91ad8177cc60c4c7cba0b26b473cee
Author: Fridolin Somers
Date: Wed Sep 30 14:54:57 2020 +0200
Bug 25548: (follow-up) Remove those rewrite redirects in koha-httpd.conf
In etc/koha-httpd.conf for dev install, those rewrite
[koha-commits] main Koha release repository branch master updated. v20.05.00-1905-g926ad3c1a6
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 926ad3c1a69074b2905d9ef03e639db6ba8d6865 (commit)
via 05085ddc61332bfb82401a7d5b8d5b0fa24cdea6 (commit)
via 3376a9440050d795ce0738e20b0616b782143f4b (commit)
from 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 926ad3c1a69074b2905d9ef03e639db6ba8d6865
Author: Jonathan Druart
Date: Tue Nov 10 11:56:31 2020 +0100
Bug 25514: Try to fix random failure from REST/Plugin/Objects.t
It's causing a "Premature connection close" error
https://docs.mojolicious.org/Mojolicious/Guides/FAQ#What-does-Premature-connection-close-mean
This is just a guess but maybe it would help to have the Test::Mojo
object initiated just before the get?
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Jonathan Druart
commit 05085ddc61332bfb82401a7d5b8d5b0fa24cdea6
Author: Jonathan Druart
Date: Fri Nov 20 10:31:33 2020 +0100
Bug 27062: Fix pickup_location tests when existing libraries exist
If there are existing libraries in the DB, the tests will fail.
There were several changes related to those tests recently, this bug report
is a follow-up for them.
bug 26984, bug 27002 and bug 26963.
Signed-off-by: Jonathan Druart
commit 3376a9440050d795ce0738e20b0616b782143f4b
Author: Jonathan Druart
Date: Fri Nov 13 09:32:50 2020 +0100
Bug 27007: Don't call GetMarcSubfieldStructure with unsafe in tests
It does not feel correct to call GetMarcSubfieldStructure with the unsafe
flag set in tests:
my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
Some tests are failing is run twice
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
[x~10]
Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314.
# Failed test 'Value is mapped correctly for column biblionumber'
# at t/db_dependent/Koha/Item.t line 115.
# got: undef
# expected: '483'
[etc.]
Test plan:
Run the tests twice, without the patch it fails, with the patch it
passes
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
---
Summary of changes:
t/db_dependent/Koha/Biblio.t | 17 +++
t/db_dependent/Koha/Item.t| 77 +++
t/db_dependent/Koha/REST/Plugin/Objects.t | 12 -
3 files changed, 63 insertions(+), 43 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v20.05.00-1902-g1aeeaf4c2b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 (commit) via 43b66ccfae07d8a72e7fe5433dafa69f4c870602 (commit) via 59e4b03d73cb4a103acdf25f858af4efaf6c491f (commit) via a25b651cf257f41fd0a8c601e70acad74b479724 (commit) via dff16710ae53ebfab8596f27b35a7c8e35f81edf (commit) via c056385669cefa02e2a94f96d8edea570f3c887e (commit) via f3cacc62cda58798e8f2de6cfdd636772d2158f0 (commit) via ba04deb9c36feedd1e0659d2d78b9327ce54ff4c (commit) via b4ffaeaec1fdc9ee7c33ee419139def9d62c586e (commit) via 9dcb51a8387f65fa2d9ff47afa9c7bb91be95e90 (commit) from 9f8ae9498d45b248189c804a7c3626803abbacf3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 1aeeaf4c2b6f4c8f79e2472b7c66a832d0daf802 Author: Jonathan Druart Date: Thu Nov 19 17:15:32 2020 +0100 Bug 22343: (follow-up) Correctly handle password on editing Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 43b66ccfae07d8a72e7fe5433dafa69f4c870602 Author: Jonathan Druart Date: Thu Nov 19 17:25:14 2020 +0100 Bug 26938: Compiled CSS Signed-off-by: Jonathan Druart commit 59e4b03d73cb4a103acdf25f858af4efaf6c491f Author: Nick Clemens Date: Tue Nov 17 12:11:21 2020 + Bug 26984: (follow-up) Don't delete patrons and checkouts in Objects.t Rather than counting all and assuriing we get 10, we can count all, add 10, and ensure the numbers still match Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit a25b651cf257f41fd0a8c601e70acad74b479724 Author: Jonathan Druart Date: Thu Nov 12 13:11:13 2020 +0100 Bug 26984: Make tests pass if AnonymousPatron is set There is only 1 place where it can be tricky to not remove them as we want exactly 10 patrons to be present in the DB Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit dff16710ae53ebfab8596f27b35a7c8e35f81edf Author: Frédéric Demians Date: Tue Nov 10 17:00:09 2020 +0100 Bug 26992: Fix serial issue and related items deletion on serial collection page serial-collection.pl uses C4::Items::DelItemCheck() function which is obsolete. Test plan: 1. Create a subscription with items created when receiving. 2. Receive several issues, and create corresponding items. 3. On Serial collection page (serial-collection.pl), select several issues. 4. Click on button Delete selected issues 5. A confirmation page is displayed. Enable "Delete associated items?". Then click on "Yes, delete" button. You get this error: Undefined subroutine ::Items::DelItemCheck 6. Apply the patch an repeat steps 3-5. Check that issues and related items are deleted. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c056385669cefa02e2a94f96d8edea570f3c887e Author: Jonathan Druart Date: Thu Nov 19 11:13:34 2020 +0100 Bug 26854: Remove log of STDERR See discussion on comments 12-20 Signed-off-by: Jonathan Druart commit f3cacc62cda58798e8f2de6cfdd636772d2158f0 Author: David Cook Date: Thu Oct 29 04:24:31 2020 + Bug 26854: Close STDERR when forking stage-marc-import.pl We need to close STDERR when forking stage-marc-import.pl, or else the CGI session with Apache httpd does not properly finish. This leads to unexpected behaviour across different httpd versions, operating systems, etc. This patch closes the STDERR file handle when forking a child process to do MARC imports, and it re-opens STDERR to a log file in the logdir directory to catch any import errors. Test plan: 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 3. Upload a MARC file with a large number of records (e.g. 30,000 records) 4. Open F12 dev tools 5. Click on "Network" tab 6. Clear all existing network logs 7. Click "Stage for import" 8. After ~30 seconds, the request to stage-marc-import.pl should return a 200 code 9. Immediately, calls to background-job-progress.pl should start, and the "Job progress" bar should update at a maximum rate of every .5 seconds (or more realistically 1-2 seconds) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit ba04deb9c36feedd1e0659d2d78b9327ce54ff4c Author: Jonathan
[koha-commits] main Koha release repository branch master updated. v20.05.00-1892-g9f8ae9498d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9f8ae9498d45b248189c804a7c3626803abbacf3 (commit) from d4a15b27b8359a13fa80952ed7e920b7388527fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 9f8ae9498d45b248189c804a7c3626803abbacf3 Author: Jonathan Druart Date: Wed Nov 18 15:09:14 2020 +0100 Bug 26939: Add missing filters Signed-off-by: Jonathan Druart --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v20.05.00-1891-gd4a15b27b8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d4a15b27b8359a13fa80952ed7e920b7388527fb (commit) via 517dcabdf73acfaf01cde461beb8bac84f86c82e (commit) via 7abee7fd6913c178baffafe2ea8cfc33f38c87f6 (commit) via e8f39a001c979fb0ef7ac342dd07062285d0264d (commit) via 308b03a31b95a8808751b98d3b285adcb370f47f (commit) via bf8ab094705163f50f46451b0dffa00cdd1d4ab9 (commit) via 49658d43c3e3bb4064afdad824153325d2216083 (commit) via 258d475d5f4bb306496dc90b9c602fd776a6c545 (commit) from 836d9a38727859f06902a7be6790592431fe812e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit d4a15b27b8359a13fa80952ed7e920b7388527fb Author: Tomas Cohen Arazi Date: Tue Aug 11 09:32:10 2020 -0300 Bug 25313: (QA follow-up) DelAuthority tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 517dcabdf73acfaf01cde461beb8bac84f86c82e Author: Marcel de Rooy Date: Wed Apr 29 16:19:00 2020 +0200 Bug 25313: Add skip_merge to ModAuthority Sometimes you know that the merge is useless, since the reporting tag did not change. Might be handy in batch processing of authority records. Test plan: Pick an authority with a few linked biblio recs (so that it will immediately merge; lower than MergeLimit). Open authority record and save it. Verify that a linked biblio record was merged. Check time in 005. You proved that this patch does not break the regular process. Signed-off-by: Marcel de Rooy Signed-off-by: Phil Ringnalda Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 7abee7fd6913c178baffafe2ea8cfc33f38c87f6 Author: Tomas Cohen Arazi Date: Tue Aug 11 09:26:50 2020 -0300 Bug 25313: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit e8f39a001c979fb0ef7ac342dd07062285d0264d Author: Nick Clemens Date: Tue Sep 1 13:32:46 2020 + Bug 26337: Pass skip_merge to DelAuthority when removing unsused authorities This script checks that an authority is not being used before deleting it. We do not need to check biblios for the authority id as we have already verified it is unused. TO test: 1 - Reset db to koha test database 2 - perl misc/migration_tools/remove_unused_authorities.pl -t 3 - Note a number of unsued authorities 4 - perl misc/migration_tools/remove_unused_authorities.pl -c 5 - Note authorities are removed 6 - Reset db 7 - Apply patch 8 - perl misc/migration_tools/remove_unused_authorities.pl -t 9 - Note results are the same 10 - perl misc/migration_tools/remove_unused_authorities.pl -c 11 - Note results are the same Signed-off-by: David Nind Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 308b03a31b95a8808751b98d3b285adcb370f47f Author: Andrew Fuerste-Henry Date: Thu Nov 5 20:28:11 2020 + Bug 26944: Point help link to automatic item mod in manual To test: 1 - go to automatic item mod, click help, end up at manual homepage 2 - apply patch, restart, reload page 3 - click link again, go to auto item mod in manual Signed-off-by: Sally Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit bf8ab094705163f50f46451b0dffa00cdd1d4ab9 Author: Jonathan Druart Date: Tue Nov 10 12:32:04 2020 +0100 Bug 26846: Fix regressions - Preselect expected and late serials This is a follow-up for bug 17674. Expected and late serials must be checked by default. Test plan: Have some serial collection and notice that the checkboxes are checked for expected and late serials /serials/serials-collection.pl?subscriptionid=42 Signed-off-by: Timothy Alexis Vass Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 49658d43c3e3bb4064afdad824153325d2216083 Author: Martin Renvoize Date: Tue Nov 3 09:57:32 2020 + Bug 26939: Use AV description in sales table display Content should use the description rather than the code Test plan 1/ Enable 'UseCashRegisters' 2/ Make some payments against a cash register 3/ Navigate to the cash register summary page via tools > cashup registers > register name 4/ Note that the payment type you selected at payment time appears as the code of the authorized value as aposed to the description. 5/ Apply patch 6/ Refresh page 7/ The payment type
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-33-g4a2fcd6604
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb (commit) from f7a46d6d80abee30ffd1ff3919d70d278faae61a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4a2fcd6604ec4f7490334ba98b038d46bf3a8cfb Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Lucas Gass (cherry picked from commit ac5a9f2694cc6c1ac2929268024eff520602d20d) Signed-off-by: Aleisha Amohia --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-108-g7045235a8d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 (commit) from ac5a9f2694cc6c1ac2929268024eff520602d20d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7045235a8d039ccbe5ba1c89f2b616c8c9ba3738 Author: Jonathan Druart Date: Mon Nov 2 15:01:32 2020 +0100 Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi Bug 26738: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass --- Summary of changes: .../prog/en/modules/common/patron_search.tt| 6 ++- .../prog/en/modules/suggestion/suggestion.tt | 30 ++-- .../modules/suggestion/tables/suggester_search.tt | 36 -- koha-tmpl/intranet-tmpl/prog/js/suggestions.js | 17 --- suggestion/add_user_search.pl | 7 +-- suggestion/suggester_search.pl | 57 -- suggestion/suggestion.pl | 14 +- 7 files changed, 48 insertions(+), 119 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt delete mode 100644 koha-tmpl/intranet-tmpl/prog/js/suggestions.js delete mode 100755 suggestion/suggester_search.pl hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-107-gac5a9f2694
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ac5a9f2694cc6c1ac2929268024eff520602d20d (commit) from e7bfecc25c07252c1558cf828d4a7fddb2ad1720 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit ac5a9f2694cc6c1ac2929268024eff520602d20d Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-106-ge7bfecc25c
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via e7bfecc25c07252c1558cf828d4a7fddb2ad1720 (commit)
from e0ec375ee31270a8ee123e116355086ad58fa36d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit e7bfecc25c07252c1558cf828d4a7fddb2ad1720
Author: Nick Clemens
Date: Wed Nov 11 01:24:15 2020 +
Bug 26963: [20.05.x]
Bug 26963: Unit tests
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: Don't call 'can_be_transferred' for each possible library for
each item
Currently When calling Koha::Template::Plugin::Branches::pickup_locations
we call pickup_location for each item of the bib, and for each item we get
a list of possible
branches, we then check those branches against the transfer limits, this is
inefficent
Given a system with 100 branches, and each branch having an item attached
to one bib (100 items)
we will call can_be_transferred ~1 times - and that will happen for
each hold placed on the bib
For me this patch reduced load time from 77 seconds to 18 seconds
To test:
1 - Find a bib
2 - Place 4 title level holds
3 - Add some branches and items for this bib to your system:
INSERT INTO branches (branchcode,branchname,pickup_location) SELECT
CONCAT(branchcode,"D"),CONCAT(branchname,"A"),pickup_location FROM branches;
INSERT INTO branches (branchcode,branchname,pickup_location) SELECT
CONCAT(branchcode,"D"),CONCAT(branchname,"B"),pickup_location FROM branches;
INSERT INTO branches (branchcode,branchname,pickup_location) SELECT
CONCAT(branchcode,"D"),CONCAT(branchname,"C"),pickup_location FROM branches;
INSERT INTO branches (branchcode,branchname,pickup_location) SELECT
CONCAT(branchcode,"D"),CONCAT(branchname,"D"),pickup_location FROM branches;
INSERT INTO items
(biblionumber,biblioitemnumber,barcode,itype,homebranch,holdingbranch) SELECT
1,1,CONCAT("test-",branchcode),'BKS',branchcode,branchcode FROM branches;
4 - Set systempreferences:
UseBranchTransferLimits = 'enforce'
BranchTransferLimitsType = 'item type'
5 - Find the bib and click the holds tab
6 - Wait for a long time, it shoudl eventually load
7 - Apply patch and restart al the things
8 - Load the page again, it should be much faster
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Bob Bennhoff
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (follow-up) Change subroutine name for QA tools
It didn't like the ending _at
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Convert to ResultSets
This patch removes the previously introduced private method by
converting the arrayref returns to ResultSets appropriately and inlining
the filter search queries.
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Migrate unit tests into pickup_location
We wrote unit tests for _can_pickup_locations as part of this patchset,
but then I inlined the method whilst golfing. This patch moves those
tests into the existing pickup_locations test so we more thoroughly
cover the case where branch transfer limits are in play.
NOTE: The tests all assume that all items have an effective_itemtype and
ccode. I'm pretty sure items all have a type at this point, but I'm less
sure we enforce collection codes?
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Don't delete existing data before tests
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Update mocked return of pickup_locations
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Fix cases where we expected a list
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Bug 26963: (QA follow-up) Fix up tests and cover case of undefined ccode
While this technically shouldn't happen, if a library creates itemtype
limits, then flips the pref, those rules are still in the db until a ccode rule
is saved.
To be extra safe, when checking for rules of one type, we should make sure
the other type is undef - i.e. if looking for ccode rules, we should confirm
the itype is undef for those rules
Additionally, we shouldn't set the barcode now that we are
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-23-ga5c2090ff5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via a5c2090ff5853f839a8021d52494cfcba9a2c1be (commit) via 5f59c30c9f3c50229c85fd34bbedbe5b75c07310 (commit) from 53b7843ee9d507e2dff85d45e0f14ae5122c7abd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit a5c2090ff5853f839a8021d52494cfcba9a2c1be Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass (cherry picked from commit 493e62aad82931304bdcf2c63152451aed781b16) Signed-off-by: Aleisha Amohia (cherry picked from commit 81be2e66f63ce49730c822173ceddf857b0eb845) Signed-off-by: Victor Grousset/tuxayo commit 5f59c30c9f3c50229c85fd34bbedbe5b75c07310 Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 + Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass (cherry picked from commit 5b5c58e08b04fa6c329d30d834329194ffd422bf) Signed-off-by: Aleisha Amohia (cherry picked from commit b5121e77fe703df81942cdac89829bf6848829db) Signed-off-by: Victor Grousset/tuxayo --- Summary of changes: Koha/Database.pm | 1 + Koha/MetaSearcher.pm | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-21-g53b7843ee9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 53b7843ee9d507e2dff85d45e0f14ae5122c7abd (commit) from 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 53b7843ee9d507e2dff85d45e0f14ae5122c7abd Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass (cherry picked from commit 54362935908bd9c2061598a9a150c721e620456d) Signed-off-by: Aleisha Amohia (cherry picked from commit 3447a782c2c3f95eee8dafb8bb5f450c044c4c17) Signed-off-by: Victor Grousset/tuxayo --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-20-g7d6fc1ec20
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4 (commit)
from 23970975e358ea93624ca5c8559475e3a01bb1d6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 7d6fc1ec20f4f01497226bc6ee72849005c4d9e4
Author: Mason James
Date: Tue Oct 27 07:41:03 2020 +1300
Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error
00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create
table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is
incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}>
line 1.
00:02:16.310 koha_1 | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `aqbudgets` ( -- information related to Funds
Signed-off-by: Tomas Cohen Arazi
(cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f)
Signed-off-by: Lucas Gass
(cherry picked from commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0)
Signed-off-by: Aleisha Amohia
(cherry picked from commit 3c488266373ab3be3c96e0966bd0c29f6d41d9f4)
Signed-off-by: Victor Grousset/tuxayo
---
Summary of changes:
installer/data/mysql/kohastructure.sql | 37 +-
1 file changed, 18 insertions(+), 19 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-19-g23970975e3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 23970975e358ea93624ca5c8559475e3a01bb1d6 (commit) via 74a7504ad126c6edef39371240a8524fab0fc2ea (commit) via ad2b4c88545ea1343a7820d53ed0acb510724671 (commit) via 82c553ca9021853b0d63d02782e31bd68730339c (commit) via 385e11f950a1f91aecc109e0a057036409f1ed07 (commit) via 9d3b7e470e8db9d8c27fc858a620408e547c0198 (commit) from 6fe294e731dd76eb3f37e6df570be0398dae2519 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 23970975e358ea93624ca5c8559475e3a01bb1d6 Author: Aleisha Amohia Date: Tue Nov 17 17:56:18 2020 +1300 Bug 18050: DBRev 19.05.16.002 Signed-off-by: Aleisha Amohia (cherry picked from commit 026316d5515621aa3a096850754d2fae5b6f01dc) Signed-off-by: Victor Grousset/tuxayo commit 74a7504ad126c6edef39371240a8524fab0fc2ea Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 + Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass (cherry picked from commit a88f367c63a2d649625fe367fa64ce3c888638ab) Signed-off-by: Aleisha Amohia (cherry picked from commit b70d602694ae45ec059f7b1d2763534c3f0a66c4) Signed-off-by: Victor Grousset/tuxayo commit ad2b4c88545ea1343a7820d53ed0acb510724671 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 11938beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass (cherry picked from commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00) Signed-off-by: Aleisha Amohia (cherry picked from commit 7c8e7bd18004e17a854433a0a1fcacabaf18d248) Signed-off-by: Victor Grousset/tuxayo commit 82c553ca9021853b0d63d02782e31bd68730339c Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 + Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass (cherry picked from commit d88169db3bd51d30b489d762a615c1872f7f) Signed-off-by: Aleisha Amohia (cherry picked from commit 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3) Signed-off-by: Victor Grousset/tuxayo commit 385e11f950a1f91aecc109e0a057036409f1ed07 Author: Victor Grousset/tuxayo Date: Tue Nov 17 13:37:48 2020 +0100 Bug 18050: DBIC Signed-off-by: Victor Grousset/tuxayo commit 9d3b7e470e8db9d8c27fc858a620408e547c0198 Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 + Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-13-g6fe294e731
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 6fe294e731dd76eb3f37e6df570be0398dae2519 (commit) via a25696fb12a117a4bd357e5189104dc11fe8546a (commit) via fb36dfd6fa08265e6d5baae83737f6eb740920c6 (commit) via cd71f5ba7228858926edf220f74eff9b4e1bd114 (commit) via 4be96d4f9e9bfd1e5a6b4a7d72cf347463fa03b6 (commit) via 87664a5ea7296186627a8ae277be69b1bd9a2037 (commit) from 4efb21d5f862f748f4b33750794275eaf2051921 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 6fe294e731dd76eb3f37e6df570be0398dae2519 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 + Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form=circulation=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass (cherry picked from commit 61362fd0431c6bc439507cc4e49c0810a704f925) Signed-off-by: Aleisha Amohia (cherry picked from commit 8cd87230b188d6677b58d222049919dcd9467401) Signed-off-by: Victor Grousset/tuxayo commit a25696fb12a117a4bd357e5189104dc11fe8546a Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass (cherry picked from commit acc93b31cef93765f09b6585dbaad69d190b8fa2) Signed-off-by: Aleisha Amohia (cherry picked from commit db2e177ac1327497868e3457899745c6d9ff4e83) Signed-off-by: Victor Grousset/tuxayo commit fb36dfd6fa08265e6d5baae83737f6eb740920c6 Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass (cherry picked from commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1) Signed-off-by: Aleisha Amohia (cherry picked from commit ec86fa6ea75264058cc137e103adc25a8dae3b6c) Signed-off-by: Victor Grousset/tuxayo commit cd71f5ba7228858926edf220f74eff9b4e1bd114 Author: Aleisha Amohia Date: Tue Nov 17 17:32:14 2020 +1300 Bug 26569: DBRev 19.05.16.001 Signed-off-by: Aleisha Amohia (cherry picked from commit 70348d8d4da5d777a08cb3ad6908ad0719c4b544) Signed-off-by: Victor Grousset/tuxayo commit
[koha-commits] main Koha release repository branch master updated. v20.05.00-1883-g836d9a3872
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 836d9a38727859f06902a7be6790592431fe812e (commit) via 5c70587c088241e30e6fe0e5f9bb858a0a165293 (commit) via 853a56cc7ae6c089f0f113943b77530d8c3a15c8 (commit) via 8a955f9a0ac6586654e6242f2b57e4465ce5 (commit) via 6bbd13ba031cf4ba592b989e869cba3a95405d4b (commit) via 9935c0bdbfc22096640b79e998cf39118deb969e (commit) via 7db88b60441e69d3d2478276d13977bbf21a8ae5 (commit) via e1400890ec8040ced8e3550eddbfd0d4e8af2347 (commit) from 55835ccfaffef48b924857e18bfd964aebda3a0a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 836d9a38727859f06902a7be6790592431fe812e Author: Jonathan Druart Date: Tue Nov 10 11:37:55 2020 +0100 Bug 26986: Prevent Selenium's StaleElementReferenceException This is a follow-up bug for bug 26162 By finding the element before the click I hope to get the good element, even if the page changed in the meanwhile. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 5c70587c088241e30e6fe0e5f9bb858a0a165293 Author: Jonathan Druart Date: Tue Nov 10 12:55:17 2020 +0100 Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Sally Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 853a56cc7ae6c089f0f113943b77530d8c3a15c8 Author: Nick Clemens Date: Fri Nov 13 16:33:40 2020 + Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 8a955f9a0ac6586654e6242f2b57e4465ce5 Author: Nick Clemens Date: Fri Nov 13 16:33:12 2020 + Bug 26903: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 6bbd13ba031cf4ba592b989e869cba3a95405d4b Author: Tomas Cohen Arazi Date: Mon Nov 16 12:54:13 2020 -0300 Bug 26988: (QA follow-up) Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 9935c0bdbfc22096640b79e998cf39118deb969e Author: Martin Renvoize Date: Fri Nov 13 13:53:15 2020 + Bug 27002: Update callers for changed return Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 7db88b60441e69d3d2478276d13977bbf21a8ae5 Author: Martin Renvoize Date: Thu Nov 12 08:09:56 2020 + Bug 27002: Update Koha::Biblio->pickup_locations to return a resultset Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit e1400890ec8040ced8e3550eddbfd0d4e8af2347 Author: Nick Clemens Date: Wed Sep 23 14:42:40 2020 + Bug 26516: Don't accept incorrect values for copyrightdate/publicationyear The previous patch rejects incorrect values when saving to the db specifically for copyrightdate An error is thrown for the int conversion when it fails Rather than
[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.16-7-g4efb21d5f8
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via 4efb21d5f862f748f4b33750794275eaf2051921 (commit)
via e49596dbca7ed54dcb8f107bead6899a300b65b7 (commit)
from f9dbb4b1e97d5456ba742bcee3284c33b0fdc501 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 4efb21d5f862f748f4b33750794275eaf2051921
Author: Alex Buckley
Date: Tue Sep 29 05:53:34 2020 +
Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when
OAI-PMH:AutoUpdateSets is enabled
Test plan:
1. Check the OAI-PMH:AutoUpdateSets syspref is disabled
2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass
successfully
3. Enabled the OAI-PMH:AutoUpdateSets syspref
4. Repeat step 2 and confirm the tests fail
5. Apply this patch and restart plack: sudo koha-plack --restart
6. Repeat step 2 and confirm the tests now pass
7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and
confirm tests still pass
Sponsored-By: Catalyst IT
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
(cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575)
Signed-off-by: Lucas Gass
(cherry picked from commit d3254f7e5726cdfb3572ae42eec057e90c25407d)
Signed-off-by: Aleisha Amohia
(cherry picked from commit 4e55967da50418ab5f58b96171e7dc1b7ac01c85)
Signed-off-by: Victor Grousset/tuxayo
commit e49596dbca7ed54dcb8f107bead6899a300b65b7
Author: Kyle M Hall
Date: Fri Oct 2 12:11:48 2020 -0400
Bug 26604: "Generate next" button gives error on serials-collection.pl
In serials-collection.pl, the line
$frequency =
C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});
causes the error
Can't use string ("13") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Serials.pm line 2198.
This function call makes no sense, that subroutine always returns a list
and doesn't take any parameters. I think it was meant to be
GetSubscriptionFrequency which is in fact already called a few lines down.
Signed-off-by: kelly mcelligott
Signed-off-by: Martin Renvoize
JD
Test plan:
1. Create a new subscription
* When there is an irregular issue: Skip issue number
* Select a frequency (not irregular)
* Test prediction pattern and mark some "not published" (to fill the
subscription.irregular DB field
2. Receive a first serial (mark it arrived, an "expected" one is created)
3. Claim the expected one
=> You have 1 arrived and 1 claimed.
It's the only way to not have an expected one and hit the else block in
serials/serials-collection.pl
4. Generate next => boom
Signed-off-by: Jonathan Druart
(cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e)
Signed-off-by: Lucas Gass
(cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018)
Signed-off-by: Aleisha Amohia
(cherry picked from commit 35cafa56f424a81ae98113d4f1db376987787849)
Signed-off-by: Victor Grousset/tuxayo
---
Summary of changes:
serials/serials-collection.pl | 3 +--
t/db_dependent/OAI/Sets.t | 30 --
2 files changed, 29 insertions(+), 4 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-32-gf7a46d6d80
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f7a46d6d80abee30ffd1ff3919d70d278faae61a (commit) via b7653e20a8d93ce9b47590df24b5d1cc9cca7731 (commit) from f402c9366f2f1e192ac054aab34fa5e2cadde6d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit f7a46d6d80abee30ffd1ff3919d70d278faae61a Author: Owen Leonard Date: Tue Nov 3 18:00:57 2020 + Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary is removed. - In the merge patrons template the submit button is now in a as is consistent with other forms. - In the MARC modifications template I've added s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d5d736909ccd24b38e90e89b1484da73972d8645) Signed-off-by: Lucas Gass (cherry picked from commit 45c29bbccf624a210f79ab6294df97038fb2bd29) Signed-off-by: Aleisha Amohia commit b7653e20a8d93ce9b47590df24b5d1cc9cca7731 Author: Katrin Fischer Date: Sun Oct 18 16:30:24 2020 + Bug 26727: Fix appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit bbf0d21284924d6b7529017fc78178b98242aaee) Signed-off-by: Lucas Gass (cherry picked from commit 5643d5432906776d34ea5a13296b0f607fcae306) Signed-off-by: Aleisha Amohia --- Summary of changes: .../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +- .../prog/en/modules/circ/request-article.tt| 1 - .../prog/en/modules/members/merge-patrons.tt | 14 +- .../modules/tools/marc_modification_templates.tt | 142 +++-- koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- 5 files changed, 87 insertions(+), 78 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-30-gf402c9366f
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via f402c9366f2f1e192ac054aab34fa5e2cadde6d1 (commit) from 81be2e66f63ce49730c822173ceddf857b0eb845 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit f402c9366f2f1e192ac054aab34fa5e2cadde6d1 Author: Katrin Fischer Date: Sat Oct 17 22:47:49 2020 + Bug 26190: Allow to close a basket with only cancelled order lines At the moment there are several cases, when closing a basket is not possible: - when there are no order lines in it - when there are order lines with uncertain prices - when the basket is marked as a standing order The first case wasn't checked correctly as only pending/received orders would be counted, but not cancelled orders. To test: - Create a basket - Create an order line - Verify the "close this basket" button shows - Cancel the order line - the button disappears - Apply the patch - Verify the button appears and works now - Create another basket - make sure you cannot close it without order lines - Create an order line with uncertain price checked - you cannot close it - Resolve the uncertain price - you can now close the basket. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa) Signed-off-by: Lucas Gass (cherry picked from commit 87cbd07be836291f860ecbd5cea5538863317164) Signed-off-by: Aleisha Amohia --- Summary of changes: acqui/basket.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-29-g81be2e66f6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 81be2e66f63ce49730c822173ceddf857b0eb845 (commit) from 5321c20a8f99bd1e63b85f46a27c87280a607de2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 81be2e66f63ce49730c822173ceddf857b0eb845 Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass (cherry picked from commit 493e62aad82931304bdcf2c63152451aed781b16) Signed-off-by: Aleisha Amohia --- Summary of changes: Koha/Database.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-28-g5321c20a8f
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5321c20a8f99bd1e63b85f46a27c87280a607de2 (commit) from b5121e77fe703df81942cdac89829bf6848829db (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5321c20a8f99bd1e63b85f46a27c87280a607de2 Author: Phil Ringnalda Date: Fri Oct 2 14:52:57 2020 -0700 Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c52a9e4cf362949192d3d58adab287cd82effbf1) Signed-off-by: Lucas Gass (cherry picked from commit 7ac243c96fef9fcf728d647f1e9d301506ccf08a) Signed-off-by: Aleisha Amohia --- Summary of changes: cataloguing/value_builder/cn_browser.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-27-gb5121e77fe
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via b5121e77fe703df81942cdac89829bf6848829db (commit) from 3c488266373ab3be3c96e0966bd0c29f6d41d9f4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b5121e77fe703df81942cdac89829bf6848829db Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 + Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass (cherry picked from commit 5b5c58e08b04fa6c329d30d834329194ffd422bf) Signed-off-by: Aleisha Amohia --- Summary of changes: Koha/MetaSearcher.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-26-g3c48826637
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 3c488266373ab3be3c96e0966bd0c29f6d41d9f4 (commit)
from 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 3c488266373ab3be3c96e0966bd0c29f6d41d9f4
Author: Mason James
Date: Tue Oct 27 07:41:03 2020 +1300
Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error
00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create
table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is
incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}>
line 1.
00:02:16.310 koha_1 | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `aqbudgets` ( -- information related to Funds
Signed-off-by: Tomas Cohen Arazi
(cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f)
Signed-off-by: Lucas Gass
(cherry picked from commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0)
Signed-off-by: Aleisha Amohia
---
Summary of changes:
installer/data/mysql/kohastructure.sql | 37 +-
1 file changed, 18 insertions(+), 19 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-25-g3447a782c2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 (commit) from 026316d5515621aa3a096850754d2fae5b6f01dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3447a782c2c3f95eee8dafb8bb5f450c044c4c17 Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass (cherry picked from commit 54362935908bd9c2061598a9a150c721e620456d) Signed-off-by: Aleisha Amohia --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-24-g026316d551
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 026316d5515621aa3a096850754d2fae5b6f01dc (commit) via b70d602694ae45ec059f7b1d2763534c3f0a66c4 (commit) via 7c8e7bd18004e17a854433a0a1fcacabaf18d248 (commit) via 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3 (commit) via 3ff1ddc4b926b7c0dce6a66833ac7b85cf36ac41 (commit) via af2146e565d5eb7c2ad95b744706f9a0c147af50 (commit) from 8cd87230b188d6677b58d222049919dcd9467401 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 026316d5515621aa3a096850754d2fae5b6f01dc Author: Aleisha Amohia Date: Tue Nov 17 17:56:18 2020 +1300 Bug 18050: DBRev 19.11.11.002 Signed-off-by: Aleisha Amohia commit b70d602694ae45ec059f7b1d2763534c3f0a66c4 Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 + Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass (cherry picked from commit a88f367c63a2d649625fe367fa64ce3c888638ab) Signed-off-by: Aleisha Amohia commit 7c8e7bd18004e17a854433a0a1fcacabaf18d248 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 11938beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass (cherry picked from commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00) Signed-off-by: Aleisha Amohia commit 6a9cc05a0a046ba7535e7258e563fb8ec16d9ee3 Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 + Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass (cherry picked from commit d88169db3bd51d30b489d762a615c1872f7f) Signed-off-by: Aleisha Amohia commit 3ff1ddc4b926b7c0dce6a66833ac7b85cf36ac41 Author: Aleisha Amohia Date: Tue Nov 17 17:51:14 2020 +1300 Bug 18050: DBIC Signed-off-by: Aleisha Amohia commit af2146e565d5eb7c2ad95b744706f9a0c147af50 Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 + Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0ce62b29bf5ebe30125eb4c631de11391134f109) Signed-off-by: Lucas Gass (cherry picked from commit fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de) Signed-off-by: Aleisha Amohia --- Summary of changes: Koha.pm| 2 +- Koha/Schema/Result/Aqbudget.pm | 33
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-18-g8cd87230b1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8cd87230b188d6677b58d222049919dcd9467401 (commit) from db2e177ac1327497868e3457899745c6d9ff4e83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 8cd87230b188d6677b58d222049919dcd9467401 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 + Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form=circulation=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass (cherry picked from commit 61362fd0431c6bc439507cc4e49c0810a704f925) Signed-off-by: Aleisha Amohia --- Summary of changes: misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-17-gdb2e177ac1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via db2e177ac1327497868e3457899745c6d9ff4e83 (commit) from ec86fa6ea75264058cc137e103adc25a8dae3b6c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit db2e177ac1327497868e3457899745c6d9ff4e83 Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass (cherry picked from commit acc93b31cef93765f09b6585dbaad69d190b8fa2) Signed-off-by: Aleisha Amohia --- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-16-gec86fa6ea7
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via ec86fa6ea75264058cc137e103adc25a8dae3b6c (commit) from 70348d8d4da5d777a08cb3ad6908ad0719c4b544 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit ec86fa6ea75264058cc137e103adc25a8dae3b6c Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass (cherry picked from commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1) Signed-off-by: Aleisha Amohia --- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-15-g70348d8d4d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 70348d8d4da5d777a08cb3ad6908ad0719c4b544 (commit) via f48c2578e87641aaab2826c84ba396ae83bf64ad (commit) from 7d5d0a488596e6594d934ca60e1ad79902c1368d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 70348d8d4da5d777a08cb3ad6908ad0719c4b544 Author: Aleisha Amohia Date: Tue Nov 17 17:32:14 2020 +1300 Bug 26569: DBRev 19.11.11.001 Signed-off-by: Aleisha Amohia commit f48c2578e87641aaab2826c84ba396ae83bf64ad Author: Andrew Fuerste-Henry Date: Wed Sep 30 13:14:12 2020 + Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a96f5deef04bb74fbd826449b4d82f651a67512c) Signed-off-by: Lucas Gass (cherry picked from commit 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90) Signed-off-by: Aleisha Amohia --- Summary of changes: Koha.pm | 2 +- installer/data/mysql/.updatedatabase.pl.swp | Bin 0 -> 28672 bytes installer/data/mysql/sysprefs.sql | 12 ++-- installer/data/mysql/updatedatabase.pl | 13 + 4 files changed, 20 insertions(+), 7 deletions(-) create mode 100644 installer/data/mysql/.updatedatabase.pl.swp hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-13-g7d5d0a4885
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 7d5d0a488596e6594d934ca60e1ad79902c1368d (commit) from 1fee97d513294322e08d43d3c2089756ffd8fb8d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7d5d0a488596e6594d934ca60e1ad79902c1368d Author: Nick Clemens Date: Thu Sep 3 16:23:04 2020 + Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 564ade93cce9231b01db1c4ebfc8f4e5b31e1acd) Signed-off-by: Lucas Gass (cherry picked from commit ae2bce1312b63d732ec07df21ef16740a8d179d2) Signed-off-by: Aleisha Amohia --- Summary of changes: debian/templates/apache-shared-intranet-plack.conf | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-12-g1fee97d513
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 1fee97d513294322e08d43d3c2089756ffd8fb8d (commit) via 7ce97d4b17482b865f51a2e6fb0db0c1821cadff (commit) from fc31bc6cee24e07d254155bc5f30a3ad022fa523 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 1fee97d513294322e08d43d3c2089756ffd8fb8d Author: Martin Renvoize Date: Wed Oct 7 16:37:06 2020 +0100 Bug 25549: Add error reporting to plugins-home This patch adds handling for the newly introduced 'errors' option in GetPlugins and reports erroroneos plugins to the user. To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - The plugin should display as installed in the table at tools/plugins. 5 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 6 - Add a line to break compilation, like: this won't compile 7 - Restart all 8 - Your Koha is not broken, but is no longer orange (The plugin is not loading). 9 - The plugin should display as unable to load in the table at tools/plugins. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 759ff4519961d0c256eb05a4797fb21c3b2c22d9) Signed-off-by: Lucas Gass (cherry picked from commit acd96409ea869862506233cee3404e14254e5725) Signed-off-by: Aleisha Amohia commit 7ce97d4b17482b865f51a2e6fb0db0c1821cadff Author: Nick Clemens Date: Wed May 20 11:12:12 2020 + Bug 25549: Remove plugin methods for broken plugins To test: 1 - Enable plugins in the koha-conf 2 - Install the kitchen sink plugin 3 - Your staff client should be orange now :-) 4 - edit the plugin module /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm 5 - Add a line to break compilation, like: this won't compile 6 - Restart all 7 - Your koha is now broken 8 - kshell 9 - perl misc/devel/install_plugins.pl 10 - Restart all 11 - Koha remains broken 12 - Apply patch 13 - kshell 14 - perl misc/devel/install_plugins.pl 15 - Koha now works! 16 - Koha is not orange because the plugin methods are removed Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0eae966d257fa2ecc6a6506e2515691e092a701c) Signed-off-by: Lucas Gass (cherry picked from commit bd2347fbf85083fe6204dcaaf1cc98826219eaed) Signed-off-by: Aleisha Amohia --- Summary of changes: Koha/Plugins.pm| 39 -- .../prog/en/modules/plugins/plugins-home.tt| 15 + misc/devel/install_plugins.pl | 10 -- plugins/plugins-home.pl| 11 +++--- 4 files changed, 50 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-10-gfc31bc6cee
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via fc31bc6cee24e07d254155bc5f30a3ad022fa523 (commit) from 775f958575e462372517286e38cbf093da5bd53f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit fc31bc6cee24e07d254155bc5f30a3ad022fa523 Author: David Cook Date: Mon Sep 21 02:02:27 2020 + Bug 26496: Add op field to Budget Planning Without this patch, it's impossible to save a budget plan. With this patch, it is possible to save a budget plan. Test: 1. Apply patch 2. Modify a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form_period_id=1) 3. Unlock the budget if necessary by unticking "Lock budget" and click "Save" 4. Go to a budget (e.g. http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1) 5. Click "Planning" and "Plan by libraries" 6. Click "Auto-fill row" on the first line 7. Click "Save" 8. Note that results are saved and shown on the newly loaded page To verify this patch is necessary, do the test plan without applying the patch. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit fd35df346f73a00b643e675853ba2c8ef321cf66) Signed-off-by: Lucas Gass (cherry picked from commit 7f4b2f20991fd04da0703fafb7b643a03fcc7e14) Signed-off-by: Aleisha Amohia --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-9-g775f958575
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 775f958575e462372517286e38cbf093da5bd53f (commit)
via a57d0fe74597680ff24968e1596857c9a7133072 (commit)
from 5ffa2a41f177f247e76b181e047496839c050836 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 775f958575e462372517286e38cbf093da5bd53f
Author: Jonathan Druart
Date: Thu Jul 30 15:15:46 2020 +0200
Bug 20804: Add support for "days" to the timeout syspref
If the timeout syspref did not contain an integer, or was not matching
integer.'d|D', then it "fallback" to 0
We can easily add support for hours and fallback to 600 if the value is
not correct.
It will prevent the session to timeout immediately
Test plan:
0. Do not apply the patches
1. Fill the timeout syspref with "5h"
2. Login
3. Click somewhere
=> Notice that the session timed out
4. Apply the patches, restart_all
5. Login
6. Click somewhere
=> You have 5 hours to enjoy Koha
7. Fill the pref with an incorrect value ("5x" for instance)
8. Logout, login
9. There is a warning in the log, and you have 10 minutes (600 secondes) to
enjoy Koha
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
(cherry picked from commit 97b9eab178f0b45b38662747a4e009e71d8b73ff)
Signed-off-by: Lucas Gass
(cherry picked from commit 78e8c65bf5fa8db6b9a8e8f3313359a4f295c00d)
Signed-off-by: Aleisha Amohia
commit a57d0fe74597680ff24968e1596857c9a7133072
Author: Jonathan Druart
Date: Thu Jul 30 15:15:36 2020 +0200
Bug 20804: Add tests
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
(cherry picked from commit 3c9c7f4543a06553c6cbf04ff58a82eb6a40fc9c)
Signed-off-by: Lucas Gass
(cherry picked from commit 356d1ca888b3591bde960f30c43e6afcd93b66dc)
Signed-off-by: Aleisha Amohia
---
Summary of changes:
C4/Auth.pm| 14 --
t/db_dependent/Auth.t | 21 -
2 files changed, 32 insertions(+), 3 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-7-g5ffa2a41f1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 5ffa2a41f177f247e76b181e047496839c050836 (commit) from 4e55967da50418ab5f58b96171e7dc1b7ac01c85 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5ffa2a41f177f247e76b181e047496839c050836 Author: Emmi Takkinen Date: Fri Sep 25 13:52:06 2020 +0300 Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24.9 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 1b40ee8d18b7fee42193cfb2bac5e44146a1afd9) Signed-off-by: Lucas Gass (cherry picked from commit 497435fa842ca6ac8c80942283c5c3663563b4fa) Signed-off-by: Aleisha Amohia --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-6-g4e55967da5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4e55967da50418ab5f58b96171e7dc1b7ac01c85 (commit) from 35cafa56f424a81ae98113d4f1db376987787849 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4e55967da50418ab5f58b96171e7dc1b7ac01c85 Author: Alex Buckley Date: Tue Sep 29 05:53:34 2020 + Bug 26589: Fix t/db_dependent/OAI/Sets.t failing when OAI-PMH:AutoUpdateSets is enabled Test plan: 1. Check the OAI-PMH:AutoUpdateSets syspref is disabled 2. Run t/db_dependent/OAI/Sets.t tests and confirm tests pass successfully 3. Enabled the OAI-PMH:AutoUpdateSets syspref 4. Repeat step 2 and confirm the tests fail 5. Apply this patch and restart plack: sudo koha-plack --restart 6. Repeat step 2 and confirm the tests now pass 7. Disable the OAI-PMH:AutoUpdateSets syspref and repeat step 2 and confirm tests still pass Sponsored-By: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 913897f3a484ea31a2373de7aac2cc8298319575) Signed-off-by: Lucas Gass (cherry picked from commit d3254f7e5726cdfb3572ae42eec057e90c25407d) Signed-off-by: Aleisha Amohia --- Summary of changes: t/db_dependent/OAI/Sets.t | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-5-g35cafa56f4
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.11.x has been updated
via 35cafa56f424a81ae98113d4f1db376987787849 (commit)
from 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 35cafa56f424a81ae98113d4f1db376987787849
Author: Kyle M Hall
Date: Fri Oct 2 12:11:48 2020 -0400
Bug 26604: "Generate next" button gives error on serials-collection.pl
In serials-collection.pl, the line
$frequency =
C4::Serials::Frequency::GetSubscriptionFrequency($subscription->{periodicity});
causes the error
Can't use string ("13") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Serials.pm line 2198.
This function call makes no sense, that subroutine always returns a list
and doesn't take any parameters. I think it was meant to be
GetSubscriptionFrequency which is in fact already called a few lines down.
Signed-off-by: kelly mcelligott
Signed-off-by: Martin Renvoize
JD
Test plan:
1. Create a new subscription
* When there is an irregular issue: Skip issue number
* Select a frequency (not irregular)
* Test prediction pattern and mark some "not published" (to fill the
subscription.irregular DB field
2. Receive a first serial (mark it arrived, an "expected" one is created)
3. Claim the expected one
=> You have 1 arrived and 1 claimed.
It's the only way to not have an expected one and hit the else block in
serials/serials-collection.pl
4. Generate next => boom
Signed-off-by: Jonathan Druart
(cherry picked from commit 9f4b54a6d74b9635195bb9ea0b9c11fe5570cf6e)
Signed-off-by: Lucas Gass
(cherry picked from commit 8c527522ec02c4b07c57c5a211d846856c936018)
Signed-off-by: Aleisha Amohia
---
Summary of changes:
serials/serials-collection.pl | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.11-4-g3d1d81014d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 (commit) from 5add311155c577ace9d3990430b63f9b19af8733 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3d1d81014db886e35a18ee546c9a9e2dfb011ce9 Author: Marcel de Rooy Date: Tue Aug 11 11:22:22 2020 + Bug 26191: Relocate track_login call in Auth.pm This is a leftover from bug 22543. Trivial move. Test plan: Do not apply this patch. Pick a user that has not yet logged in today. Only login via the opac and immediately check if borrowers.datelastseen did not change. Apply this patch, restart, flush etc. Only login via the opac and verify again rightaway (no further opac actions). Now datelastseen should have been changed already. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit b827acf53ffde71d787123095b8524ea6bd08fd6) Signed-off-by: Lucas Gass (cherry picked from commit f095fc1aeffaabd9d54f7df0378f226b0d2e0729) Signed-off-by: Aleisha Amohia --- Summary of changes: C4/Auth.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-105-ge0ec375ee3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e0ec375ee31270a8ee123e116355086ad58fa36d (commit) from 8ea97143a53baf145fe2bb707760a4631a18096a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e0ec375ee31270a8ee123e116355086ad58fa36d Author: Jonathan Druart Date: Wed Nov 11 14:55:27 2020 +0100 Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred There is a missing parameter to CanItemBeReserved, we need to know if the hold can be placed at a given pickup library. Test plan: 1 - Set preferences: UseBranchTransferLimits: enforce BranchTransferLimitsType: itype AllowHoldPolicyOverride: Don't allow 2 - Set Centerville 'Book' items to not be allowed to transfer to any other library 3 - Make sure Hold policy is set to 'any library' 4 - Find a record with a Centerville item and other items 5 - Attempt to place an item level hold on the Centerville item (with a pickup library different than Centerville) => Without this patch you are taken to the holds list, but your hold is not placed Nothing indicates why hold has failed => With this patch you cannot select the item from Centerville "Cannot be transferred to pickup library" Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit fbd0bbf98f574a7eb804673978a198eea6fdd798) Signed-off-by: Lucas Gass --- Summary of changes: reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-104-g8ea97143a5
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via 8ea97143a53baf145fe2bb707760a4631a18096a (commit)
from cebd342a49bf4218c6f937278b7d90641a88ca47 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 8ea97143a53baf145fe2bb707760a4631a18096a
Author: Jonathan Druart
Date: Tue Nov 10 14:11:10 2020 +0100
Bug 26987: (bug 23463 follow-up) Fix serial receipt if
makePreviousSerialAvailable
$serialitem is not a Koha::Item there, we need to fetch the item before.
Test plan:
Turn makePreviousSerialAvailable on
Create a subscription
Receive an serial item, mark it "arrived"
Without this patch Koha explodes with
No property notforloan for Koha::Serial::Item at
/usr/share/perl5/Exception/Class/Base.pm line 88
Koha::Object::set('Koha::Serial::Item=HASH(0x55dd67c75700)',
'HASH(0x55dd672cec30)') called at /kohadevbox/koha/serials/serials-edit.pl line
273
With this patch applied the notforloan and itype values are correctly
set for the new serial item.
Signed-off-by: Magnus Enger
Signed-off-by: Martin Renvoize
Signed-off-by: Jonathan Druart
(cherry picked from commit dc465736cd14a860ffbda1571012fe94fb1e65fa)
Signed-off-by: Lucas Gass
---
Summary of changes:
serials/serials-edit.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-103-gcebd342a49
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cebd342a49bf4218c6f937278b7d90641a88ca47 (commit) via bafef273577c4513a6929265d7408fe567afa6f1 (commit) via 03562822ec2f774fb0a659809ef3e3b3587befd6 (commit) from 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit cebd342a49bf4218c6f937278b7d90641a88ca47 Author: Kyle M Hall Date: Thu Nov 5 06:48:04 2020 -0500 Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method Signed-off-by: Jonathan Druart (cherry picked from commit f8206ca60cb1bbd32a90b7898a6877166026b8bb) Signed-off-by: Lucas Gass commit bafef273577c4513a6929265d7408fe567afa6f1 Author: Fridolin Somers Date: Thu Oct 1 14:19:05 2020 +0200 Bug 26594: Fix patrons merge problem with restrictions When merging a patron A with restriction(s) into an other patron B, the entries of borrower_debarments are OK but the value of borrowers.debarred for patron B need to be updated. An effect of this strange storage of restrictions in both places. Test plan : 1) Create a patron A with a manual restriction with some date and comment 2) Create a patron B with no restriction 3) Merge patron A and B, keeping patron B 4) Look at patron B details page => Without patch you see no restriction => With patch you see the restriction from patron A Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit bd66a2e175e062b662652f81efcafb48b6d230d7) commit 03562822ec2f774fb0a659809ef3e3b3587befd6 Author: Fridolin Somers Date: Fri Oct 2 09:22:36 2020 +0200 Bug 26594: add Unit Test Run prove t/db_dependent/Patron/Borrower_Debarments.t Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit e5ba5f406899c554ccc71212cbee5531b91c3f41) --- Summary of changes: Koha/Patron.pm | 4 Koha/Patron/Debarments.pm | 14 ++-- t/db_dependent/Patron/Borrower_Debarments.t | 35 - 3 files changed, 45 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-100-g97dac5e513
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 (commit) via a230dda60451b3443575941fc50478034538a43c (commit) from 45c29bbccf624a210f79ab6294df97038fb2bd29 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 97dac5e5136f2a2a3d0e49c862c0b058bedafac8 Author: Tomas Cohen Arazi Date: Tue Oct 20 14:36:22 2020 -0300 Bug 24633: (follow-up) Tweak sample plugin targets Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 017036f695df46df1fe3c2106b96b6285b0b9e83) Signed-off-by: Lucas Gass commit a230dda60451b3443575941fc50478034538a43c Author: Tomas Cohen Arazi Date: Tue Oct 20 14:29:38 2020 -0300 Bug 24633: Add support for gitlab searching of plugins This patch adds the option to add Gitlab repositories to look for Koha plugins. As with Github, plugin projects need to be named koha-plugin-* and the release file needs to be named with the .kpz extension. To test: 1. Apply this patchset 2. Check either koha-conf.xml or koha-conf.site.xml.in for sample configurations of gitlab targets. 3. Tweak your koha-conf.xml accordingly. You could have: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 4. Flush memcached and restart plack: $ flush_memcached $ koha-plack --restart kohadev 5. Open the plugins page, search for anything, like 'gobi' or 'a' => SUCCESS: You get Theke results! 6. Pick a gitlab plugin for install => SUCCESS: It is installed! 7. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit df2a7e4aa200ea9648d993241e75ef27e12fa103) Signed-off-by: Lucas Gass --- Summary of changes: debian/templates/koha-conf-site.xml.in | 2 +- etc/koha-conf.xml | 2 +- plugins/plugins-home.pl| 32 3 files changed, 34 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-98-g45c29bbccf
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 45c29bbccf624a210f79ab6294df97038fb2bd29 (commit) via 5643d5432906776d34ea5a13296b0f607fcae306 (commit) from 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 45c29bbccf624a210f79ab6294df97038fb2bd29 Author: Owen Leonard Date: Tue Nov 3 18:00:57 2020 + Bug 26727: (follow-up) More markup corrections This patch makes more markup changes to the templates previously modified in order to try to arrive at some agreeable solutions. - In the value_builder EXAMPLE template, the is unnecessary and is removed. Also removed is the script "type" attribute and obsolete CDATA markers. - In the article request template an unnecessary is removed. - In the merge patrons template the submit button is now in a as is consistent with other forms. - In the MARC modifications template I've added s around each "line" in the form to add the line break, along with some CSS to add margins. - The submit button is now inside a and the "Cancel" link now has the "cancel" class. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d5d736909ccd24b38e90e89b1484da73972d8645) Signed-off-by: Lucas Gass commit 5643d5432906776d34ea5a13296b0f607fcae306 Author: Katrin Fischer Date: Sun Oct 18 16:30:24 2020 + Bug 26727: Fix appearing in the templates The self-closing p is not valid in HTML5: Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag. To test: 1) - Activate Article requests - Search for a record to place an article request on in staff - Look up the patron - Verify the article request form looks ok 2) - Search for a list of patrons - Check 2 patrons and merge them using the button above the list - Verify the distance between the button and the table looks ok 3) - Create a new MARC modification template - Create a new action - Verify the distances between the first and second line of form elements looks ok 4) - Place a hold in staff - Click on the Suspend link in the holds table (not below) - Verify the modal looks ok Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit bbf0d21284924d6b7529017fc78178b98242aaee) Signed-off-by: Lucas Gass --- Summary of changes: .../modules/cataloguing/value_builder/EXAMPLE.tt | 6 +- .../prog/en/modules/circ/request-article.tt| 1 - .../prog/en/modules/members/merge-patrons.tt | 14 +- .../modules/tools/marc_modification_templates.tt | 142 +++-- koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- 5 files changed, 87 insertions(+), 78 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-96-g2db5e8beb2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 (commit) via dd60ec0813ac3c68b032c08a674a166dea0eee78 (commit) from 5cba820797f8cc83dfd271efb208da676da12eec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 2db5e8beb29e7ba2e438f0363a53f72c4cc49b80 Author: Martin Renvoize Date: Thu Nov 5 12:42:47 2020 + Bug 26908: (follow-up) Alter template check This alters the template check to use the presence of the plugins arrayref rather than requiring a second call to check for plugins_enabled. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit a10db1347dfbe5a444e669e363aab9b635d74069) Signed-off-by: Lucas Gass commit dd60ec0813ac3c68b032c08a674a166dea0eee78 Author: Kyle M Hall Date: Tue Nov 3 08:31:39 2020 -0500 Bug 26908: Restore ability to view and select EDI plugins for a vendor account Test Plan: 1) Install an EDI plugin 2) Browse to edi_accounts.pl, create or edit an account 3) Note the plugins pulldown is missing 4) Apply this patch 5) Restart all the things! 6) Reload the page 7) Note the pulldown is back! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0d438de0186fb08d2a1f8eb82b0df0204efff5ef) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-94-g5cba820797
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5cba820797f8cc83dfd271efb208da676da12eec (commit) from aeef2fadc39ce019e4f665621d282b088f9a2704 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5cba820797f8cc83dfd271efb208da676da12eec Author: Jonathan Druart Date: Tue Nov 3 16:45:33 2020 +0100 Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules UPDATE: changed queries to not touch * values To test: 1 - Checkout 19.11.x and reset_all 2 - Add a new patron category, itemtype, and branch to your system 3 - Create issuing rules using thise 3 values, and others 4 - Delete the new category, itemtype and branch 5 - Checkout master 6 - Restart_all 7 - updatedatabase 8 - you get errors 9 - repeat 1-5 10 - apply patch 11 - restart_all 12 - updatedatabase 13 - no errors! Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 31e38bc371943d1e76f49aacd1dd159a254f71e7) Signed-off-by: Lucas Gass --- Summary of changes: installer/data/mysql/updatedatabase.pl | 15 +++ 1 file changed, 15 insertions(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-93-gaeef2fadc3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via aeef2fadc39ce019e4f665621d282b088f9a2704 (commit) from 87cbd07be836291f860ecbd5cea5538863317164 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit aeef2fadc39ce019e4f665621d282b088f9a2704 Author: Jonathan Druart Date: Wed Nov 4 09:04:19 2020 +0100 Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 42c0475a948577442e44b11dbb12b45b25171418) Signed-off-by: Lucas Gass --- Summary of changes: members/pay.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-92-g87cbd07be8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 87cbd07be836291f860ecbd5cea5538863317164 (commit) from 7c505acfe4b7031a428ee95afaf3cacd6ccabdec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 87cbd07be836291f860ecbd5cea5538863317164 Author: Katrin Fischer Date: Sat Oct 17 22:47:49 2020 + Bug 26190: Allow to close a basket with only cancelled order lines At the moment there are several cases, when closing a basket is not possible: - when there are no order lines in it - when there are order lines with uncertain prices - when the basket is marked as a standing order The first case wasn't checked correctly as only pending/received orders would be counted, but not cancelled orders. To test: - Create a basket - Create an order line - Verify the "close this basket" button shows - Cancel the order line - the button disappears - Apply the patch - Verify the button appears and works now - Create another basket - make sure you cannot close it without order lines - Create an order line with uncertain price checked - you cannot close it - Resolve the uncertain price - you can now close the basket. Signed-off-by: Séverine QUEUNE Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa) Signed-off-by: Lucas Gass --- Summary of changes: acqui/basket.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-91-g7c505acfe4
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7c505acfe4b7031a428ee95afaf3cacd6ccabdec (commit) from 45f356ad97a84af3f28b298ac6d5f9ce17a6075e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7c505acfe4b7031a428ee95afaf3cacd6ccabdec Author: Katrin Fischer Date: Mon Oct 26 22:40:50 2020 + Bug 11460: Remove MARC21 default mapping from itemcallnumber system preference The mapping in the itemcallnumber system preference is only valid for MARC21 libraries using DDC classification, but not for libraries using UNIMARC or other classification. This patch suggests to remove the default mapping and start new installations with an empty value. To test: - On an emtpy database - Apply patch - Run the web installer, selecting either MARC21 or UNIMARC - Verify that the itemcallnumber system preference is empty - Verify the description now also include examples for UNIMARC Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit d80421ce855fd9069dbe1e7cd6b1ea42a665899b) Signed-off-by: Lucas Gass --- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- .../intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-90-g45f356ad97
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 45f356ad97a84af3f28b298ac6d5f9ce17a6075e (commit) from c5d3b86019c475dad701167e519b2feec45becdb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 45f356ad97a84af3f28b298ac6d5f9ce17a6075e Author: Fridolin Somers Date: Tue Oct 27 09:03:16 2020 +0100 Bug 26832: Make Elasticsearch mappings export use UTF-8 Script misc/search_tools/export_elasticsearch_mappings.pl allows to export current search engine configuration into a YAML file. This export should use UTF-8 encoding, like other exports. Test plan : 1) Go to Administration > Search engine configuration (Elasticsearch) 2) Edit a field label to use a diacrtic, for example local-number => Numéro 3) Save 4) Edit file etc/koha-conf.xml to enable 'elasticsearch_index_mappings' 5) Export mappings to file via misc/search_tools/export_elasticsearch_mappings.pl -t $MARCFLAVOUR 6) Reset memcached and plack 7) Back to Administration > Search engine configuration (Elasticsearch) 8) Click on 'Reset Mappings' and accept 9) Look at field 'local-number' => Without patch diacritic 'é' is broken 10) You may try with an emoji B-) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 9441537e5436b43805d578108ebee0c8394eb5aa) Signed-off-by: Lucas Gass --- Summary of changes: misc/search_tools/export_elasticsearch_mappings.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-89-gc5d3b86019
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c5d3b86019c475dad701167e519b2feec45becdb (commit) from 949abc20748c696cbe8a60addff5f91970e199ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit c5d3b86019c475dad701167e519b2feec45becdb Author: Katrin Fischer Date: Fri Oct 16 01:23:41 2020 +0200 Bug 26696: Fix colspan in payment table when credit exists The colspan was adjusted for the total due when a new column was added to the table, but the 2 lines for credits were missed. To test: - Go to any patron account - Create a manual invoice - Create a credit - Go to the 'Make a payment' tab - Veriy that the total lines at the bottom of the table are slightly off - Apply the patch - Verify that the total lines in the table now display correctly Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit adfed0a945eb00ff0fe501ff1c90e25076777a34) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-88-g949abc2074
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 949abc20748c696cbe8a60addff5f91970e199ab (commit) via c724a3db1d83447459b488ee7911a821720a5da1 (commit) from abff9a9cd8fb82bafe5bc38f44a030950fb6e86e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 949abc20748c696cbe8a60addff5f91970e199ab Author: Nick Clemens Date: Sat Oct 24 01:51:55 2020 + Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7a87cc310b5836b6808c8836ee9e38b3dd725160) Signed-off-by: Lucas Gass commit c724a3db1d83447459b488ee7911a821720a5da1 Author: Didier Gautheron Date: Wed Apr 8 09:33:44 2020 +0200 Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 1181402eee9392fddf0e3a64de5941880485c074) Signed-off-by: Lucas Gass --- Summary of changes: tools/inventory.pl | 4 1 file changed, 4 insertions(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-86-gabff9a9cd8
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via abff9a9cd8fb82bafe5bc38f44a030950fb6e86e (commit)
from 6add1365f6ed5827f684b8328852c54e2ab13690 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit abff9a9cd8fb82bafe5bc38f44a030950fb6e86e
Author: Blou
Date: Mon Nov 2 14:24:50 2020 -0500
Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm
Plain simple:
my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch}
);
This patch replaces 'Koka' by 'Koha'.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
(cherry picked from commit 3dee550e346d8a998335eb7ce77b4a064a1d129a)
Signed-off-by: Lucas Gass
---
Summary of changes:
C4/Reserves.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-85-g6add1365f6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 6add1365f6ed5827f684b8328852c54e2ab13690 (commit) via 3006eb144ce2af13c5317bcc835b8874e0b44216 (commit) via e65776a6d208667058918ab03fa36c8da243c082 (commit) via 3d554f7ff6b0c76ae674893fcbf0273c80885815 (commit) from 493e62aad82931304bdcf2c63152451aed781b16 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 6add1365f6ed5827f684b8328852c54e2ab13690 Author: Lucas Gass Date: Mon Nov 16 19:13:14 2020 + Bug 26853: DBIC changes Signed-off-by: Lucas Gass commit 3006eb144ce2af13c5317bcc835b8874e0b44216 Author: Lucas Gass Date: Mon Nov 16 19:10:46 2020 + Bug 26853: DBRev 20.05.05.003 Signed-off-by: Lucas Gass commit e65776a6d208667058918ab03fa36c8da243c082 Author: David Cook Date: Thu Oct 29 05:23:10 2020 + Bug 26853: Throw a fatal error if import_biblios insert fails Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 8b70bd03f7371deb8dd7ef25e2036c0bbc9b1698) Signed-off-by: Lucas Gass commit 3d554f7ff6b0c76ae674893fcbf0273c80885815 Author: David Cook Date: Thu Oct 29 05:20:53 2020 + Bug 26853: Harmonize import_biblios with biblio and biblioitems This patch harmonizes the column datatypes of import_biblios with biblio and biblioitems to prevent database errors which cause staged MARC uploads to sometimes fail to update 100% correctly. To test: 1. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 2. Upload a file with MARC records with titles longer than 128 characters long 3. Click "Stage for import" 4. Monitor /var/log/koha/kohadev/intranet-error.log for database errors 5. Note that there are no database errors Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit e39b9684d5cd0ce15a3d1f07d7691b832309287b) Signed-off-by: Lucas Gass --- Summary of changes: C4/ImportBatch.pm | 2 +- Koha.pm| 2 +- Koha/Schema/Result/ImportBiblio.pm | 24 ++-- installer/data/mysql/kohastructure.sql | 12 ++-- installer/data/mysql/updatedatabase.pl | 16 5 files changed, 34 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-81-g493e62aad8
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 493e62aad82931304bdcf2c63152451aed781b16 (commit) from 7ac243c96fef9fcf728d647f1e9d301506ccf08a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 493e62aad82931304bdcf2c63152451aed781b16 Author: Jonathan Druart Date: Fri Oct 26 11:17:40 2018 -0300 Bug 26639: Add auto_savepoint to DBIC connection See comment 0. https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#Nested-transactions-and-auto-savepoints Otherwise: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/db_dependent/Koha/Objects.t line 274 Possible side-effects? Slowness? We need to push it to master ASAP and see how our test suite behave. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bd63fb2bb941294371a072fea9fc2f930ff5bf3f) Signed-off-by: Lucas Gass --- Summary of changes: Koha/Database.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-80-g7ac243c96f
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7ac243c96fef9fcf728d647f1e9d301506ccf08a (commit) from 940fdc447a0312a10903a7ae49e1a4b7d88c4521 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7ac243c96fef9fcf728d647f1e9d301506ccf08a Author: Phil Ringnalda Date: Fri Oct 2 14:52:57 2020 -0700 Bug 26605: Correctly URI-encode query string in call number browse plugin If you search for a call number like "M KRUEGER CO #11" in the cn_browser.pl plugin, your query is cut off at "M KRUEGER CO " because the hash isn't escaped, so the browser thinks you are opening a window and trying to navigate to the element with the id 11 rather than passing the #11 to the server. To test: 1) Find the record you will use to test, determing the MARC framework it uses by going to Edit > Edit record > Settings 2) In Administration > MARC bibliographic framework, click MARC structure in the Actions menu for that framework 3) Navigate to the 952 tag, in the Actions menu click Edit subfields 4) In the tab for o, choose the Plugin cn_browser.pl and click Save Changes 5) Click the Edit button next to one of the items on your record 6) In the Full call number field, add " CO #11" to the call number 7) Click the ... next to the field to open the Tag editor 8) In the popup window, verify that the search field includes the " CO #11" you added to the call number Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c52a9e4cf362949192d3d58adab287cd82effbf1) Signed-off-by: Lucas Gass --- Summary of changes: cataloguing/value_builder/cn_browser.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-79-g940fdc447a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 940fdc447a0312a10903a7ae49e1a4b7d88c4521 (commit) from 2fa997f9a947aced8ae7ab7337a27e127909d5d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 940fdc447a0312a10903a7ae49e1a4b7d88c4521 Author: Lisette Scheer Date: Sat Oct 24 18:18:54 2020 + Bug 26723: Improve link text on OverDriveAuthName system preference The OverDriveAuthName system preference contains a link labeled "here" to a seperate administration page that should be labeled better. This patch renames the link. To test: 1. Go to administration 2. Search the system preferences for OverDriveAuthName 3. Obeserve the "here" link in the preference. 4. Apply the patch. 5. Repeat steps 1-2. 6. Observe the new link text. 7. Sign off. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit daca3478f48ece4f92957eb4b4638d5aa18844a5) Signed-off-by: Lucas Gass --- Summary of changes: .../prog/en/modules/admin/preferences/enhanced_content.pref | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-78-g2fa997f9a9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 2fa997f9a947aced8ae7ab7337a27e127909d5d3 (commit) from 17571f824d391989247465c7ae18c92c744464c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 2fa997f9a947aced8ae7ab7337a27e127909d5d3 Author: Owen Leonard Date: Mon Oct 26 11:55:57 2020 + Bug 26816: Chomp whitespace around i18n strings This patch adds the chomp shorthand [%- -%] to the output of i18n.inc to prevent extra spaces from being inserted. To test, apply the patch and perform a catalog search in the staff interface which will return results with multiple items. In the items column, the availability information should not have unwanted spaces: 3 items, 3 available: ...instead of 3 items , 3 available: Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 190f7155f1e9b3100a0dfb91279228033fc28546) --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/i18n.inc | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-77-g17571f824d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 17571f824d391989247465c7ae18c92c744464c2 (commit) from eb4533babb0ba78f2a50a7c1fc60864e17b3f27d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 17571f824d391989247465c7ae18c92c744464c2 Author: Nick Clemens Date: Tue Oct 27 15:59:46 2020 + Bug 17515: Order Z3950 server by rank and preserve ordering Previously we put all the servers into an object with keys of the server id This patch converts it to an array of objects to preserve order, and adjusts code to use the array index where necessary and store the server id within the array To test: 1 - Add some new Z3950 servers, they don't need to be valid FIRST SECOND THIRD FOURTH 2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4 3 - Enable and launch the advanced editor 4 - Click 'Advanced' under search on the left 5 - Note the list displays in the order you entered the servers 6 - Apply patch 7 - Reload 8 - Order is correct 9 - With valid servers, confirm that searching still works and servers can be checked or unchecked to include/remove from results https://bugs.koha-community.org/show_bug.cgi?id=17515 Signed-off-by: B Johnson Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 7bbf4f7b5fe54a46d2c54a4dc445a0400dfbef23) Signed-off-by: Lucas Gass --- Summary of changes: Koha/MetaSearcher.pm | 2 +- cataloguing/editor.pl | 2 +- .../intranet-tmpl/lib/koha/cateditor/search.js | 4 +-- .../prog/en/includes/cateditor-ui.inc | 33 -- svc/cataloguing/metasearch | 1 + 5 files changed, 23 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-76-geb4533babb
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via eb4533babb0ba78f2a50a7c1fc60864e17b3f27d (commit) from 5b5c58e08b04fa6c329d30d834329194ffd422bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit eb4533babb0ba78f2a50a7c1fc60864e17b3f27d Author: Fridolin Somers Date: Fri Sep 18 15:09:10 2020 +0200 Bug 26487: Add all MARC flavours for not-onloan-count search field In admin/searchengine/elasticsearch/mappings.yaml the search field not-onloan-count is defined for MARC21 on 999x. This should be for all the MARC flavours, like in Zebra config. Test plan: 1) On a UNIMARC database 2) Reset Elasticsearch mappings 3) Check search engine config to see field 'not-onloan-count' on 999$x 4) Same on a NORMARC database Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 0ee41b53168c3a5275533a731160b643909cd110) Signed-off-by: Lucas Gass --- Summary of changes: admin/searchengine/elasticsearch/mappings.yaml | 10 ++ 1 file changed, 10 insertions(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-75-g5b5c58e08b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5b5c58e08b04fa6c329d30d834329194ffd422bf (commit) from cc36475cff550beed85c646dd4ed0d45ac8918b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5b5c58e08b04fa6c329d30d834329194ffd422bf Author: Nick Clemens Date: Thu Oct 29 12:18:56 2020 + Bug 18051: Set UTF8 Flag for record searches/imports from rancor The advanced cataloging editor uses Koha::MetaSearcher to find and import records from Z3950. The records are correctly converted to UTF8, however, we need to set the flag in the record to ensure they are parsed correctly later To test: 1 - Add OHIOLINK as a z39 source as described in earlier comments 2 - Browse to Cataloging->Advanced editor 3 - Click Search->Advanced 4 - Select OHIOLINK 5 - Search for author 'capek karel' 6 - Note records look bad 7 - Apply patch 8 - Restart all the things 9 - Repeat 10 - Success! Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 4d92e3d284e392ad681b095c02965fe57a85a5a1) Signed-off-by: Lucas Gass --- Summary of changes: Koha/MetaSearcher.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-74-gcc36475cff
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via cc36475cff550beed85c646dd4ed0d45ac8918b3 (commit) via 0cca3766be6e1bc13fbb0c33e02d708ac70fc946 (commit) via e5367af11159b33f43c0cef0968f204366dbad99 (commit) from 694f5ee9d8b21532c04598498e10f9f6c7e542c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit cc36475cff550beed85c646dd4ed0d45ac8918b3 Author: Nick Clemens Date: Mon Nov 2 12:46:59 2020 + Bug 26581: (follow-up) Skip merge when deleting authority Tests failing, seems to be because the indexes haven't been created yet. When deleting authority we perform a 'merge' where we search for biblios containing the authority. Since these are simply tets we can skip this step, avoid the search, and avoid a crash Signed-off-by: Lucas Gass commit 0cca3766be6e1bc13fbb0c33e02d708ac70fc946 Author: Nick Clemens Date: Tue Oct 27 14:36:24 2020 + Bug 26581: (follow-up) Restore unsetting of doreturn Signed-off-by: Lucas Gass commit e5367af11159b33f43c0cef0968f204366dbad99 Author: Martin Renvoize Date: Fri Oct 16 15:04:31 2020 +0100 Bug 26581: [20.05.x] Only reindex records once per checkin This patch simply passes skip_record_index calls to Koha:Item:store for all the changes done in AddReturn. Testing is really verifiying that items are still correctly indexed at the end For both search engines To test: 1 - Find or create a record with multipel items 2 - Populate both: UpdateItemLocationOnCheckin UpdateNotForLoanStatusOnCheckin 3 - Confirm that checking in an item correctly updates the item status in search results 4 - Test with items issued, and items not issued 5 - Test when generating a transfer (checkin at different branch) 6 - Test when item was marked lost 7 - Test when filling transfer Signed-off-by: Séverine Queune Signed-off-by: Christoper Brannon Signed-off-by: Martin Renvoize Bug 26581: Unit tests These tests cover the changes to ensure the AddReturn calls index_records once per call and that other calls pass the skip_record_index parameter correctly Signed-off-by: Séverine Queune Signed-off-by: Christoper Brannon Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass --- Summary of changes: C4/Circulation.pm | 39 +++-- C4/Items.pm| 18 +--- t/db_dependent/Koha/SearchEngine/Indexer.t | 68 +++--- 3 files changed, 99 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-71-g694f5ee9d8
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 20.05.x has been updated
via 694f5ee9d8b21532c04598498e10f9f6c7e542c0 (commit)
from e564d2e63b631edcfa7a7b9ae81b5aa8562de31b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
commit 694f5ee9d8b21532c04598498e10f9f6c7e542c0
Author: Mason James
Date: Tue Oct 27 07:41:03 2020 +1300
Bug 18050: move aqbudgetperiods table before aqbudgets, to fix sql error
00:02:16.310 koha_1 | DBD::mysql::st execute failed: Can't create
table `koha_kohadev`.`aqbudgets` (errno: 150 "Foreign key constraint is
incorrectly formed") at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}>
line 1.
00:02:16.310 koha_1 | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `aqbudgets` ( -- information related to Funds
Signed-off-by: Tomas Cohen Arazi
(cherry picked from commit 3df7a02d8198e7a0a0af5459c4c3d2192177b27f)
Signed-off-by: Lucas Gass
---
Summary of changes:
installer/data/mysql/kohastructure.sql | 37 +-
1 file changed, 18 insertions(+), 19 deletions(-)
hooks/post-receive
--
main Koha release repository
___
koha-commits mailing list
koha-commits@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v20.05.00-1875-g55835ccfaf
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 55835ccfaffef48b924857e18bfd964aebda3a0a (commit) via a386954b8b17925ed213a56878e1d453ba8c7635 (commit) via 36d46c6510ee93ffc52f6b914389c66351b16f33 (commit) via ea725f472426caab9bcdbef128fd5693f795fe17 (commit) via f6323ee5351a6801321c0938690344f04aef6c54 (commit) via 8b21682c332b63afd3be74073e5eeaf531dadeac (commit) via a408fcc0b662c31a8911728ab3d6816ada4c3491 (commit) from 91e21d3a95520f19fa3632d87f2c8f32b11ea1eb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 55835ccfaffef48b924857e18bfd964aebda3a0a Author: Tomas Cohen Arazi Date: Fri Nov 13 15:54:32 2020 -0300 Bug 27021: Make chaining ->empty always return an empty resultset This patch borrows the implementation Martin did on bug 27002, to woraround this issue, and implements it properly on the Koha::Objects->empty method. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => FAIL: Tests fail! The resultset should be empty and it isn't! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off! Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit a386954b8b17925ed213a56878e1d453ba8c7635 Author: Tomas Cohen Arazi Date: Fri Nov 13 15:47:39 2020 -0300 Bug 27021: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart commit 36d46c6510ee93ffc52f6b914389c66351b16f33 Author: Colin Campbell Date: Thu Nov 12 11:42:05 2020 + Bug 18267: Refactored Edifact Price Calculations Refactored the price calculations for Quotes and Invoices This takes in to account various combinations used by different vendors. Makes the extraction of basic price, quantity and tax information more reliable. Tests are in Edifact.t and EdiInvoice.t Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ea725f472426caab9bcdbef128fd5693f795fe17 Author: Martin Renvoize Date: Fri Nov 13 12:12:20 2020 + Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart commit f6323ee5351a6801321c0938690344f04aef6c54 Author: Kyle M Hall Date: Mon Jun 15 12:26:14 2020 -0400 Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Jonathan Druart commit 8b21682c332b63afd3be74073e5eeaf531dadeac Author: Joonas Kylmälä Date: Fri Nov 13 12:07:22 2020 +0200 Bug 27012: Fix incorrect SQL syntax in hold merging If you merge two records with holds in them following error happens without this patch: [WARN] DBD::mysql::st execute failed: called with 4 bind variables when 3 are needed [for Statement "SELECT * FROM reserves WHERE biblionumber = ? AND (found <> ? AND found <> ? OR found is NULL) ORDER BY reservedate ASC" with ParamValues: 0=Null!, 1=Null!, 2=Null!] at /kohadevbox/koha/C4/Reserves.pm line 2002. To test: 1) Notice prove t/db_dependent/Reserves.t fails with above error 2) Apply patch 3) Notice prove t/db_dependent/Reserves.t passes Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-70-ge564d2e63b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e564d2e63b631edcfa7a7b9ae81b5aa8562de31b (commit) via 885791f964e8bcc359d5af70cf5309ee5dabeeb9 (commit) via 2b3e477be3690d4e718bc683e87e73065aaf0d6b (commit) from deaa657362567308aa9837004376d3275e78bedf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e564d2e63b631edcfa7a7b9ae81b5aa8562de31b Author: Nick Clemens Date: Thu Oct 1 10:50:17 2020 + Bug 26583: Remove unneccessary code in AddIssue The lines to calc due date are doubled ModDateLastSeen is not needed as we set the item not lost and we can set the date as we do for date last borrowed and save a DB store Largely this is reading the code and confirming the changes make sense To test: 1 - Apply patch 2 - Check out items, confirm it works as before 3 - prove -v t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 6e37dcafee872cdea378ba845ef49d702a3fbfc5) Signed-off-by: Lucas Gass commit 885791f964e8bcc359d5af70cf5309ee5dabeeb9 Author: Nick Clemens Date: Sat Oct 24 00:21:55 2020 + Bug 26726: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 6da94551f122373e9ec418d3c80035c599c18fb5) Signed-off-by: Lucas Gass commit 2b3e477be3690d4e718bc683e87e73065aaf0d6b Author: Tal Rogoff Date: Fri Oct 23 23:02:29 2020 + Bug 26726: changed the text of the "here" link on the transport cost matrix administration page test plan: 1.Set the UseTransportCostMatrix system to disabled 2.Go to Administration>Transport cost matrix 3.Blue box at top of the page contains link labelled "here" 4.Apply patch 5.Refresh page 6.Link should now be labelled "UseTransportCostMatrix" Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit c85b3ee07f551644891c86a74d6d2f87bfc9bdeb) Signed-off-by: Lucas Gass --- Summary of changes: C4/Circulation.pm| 12 +++- .../prog/en/modules/admin/transport-cost-matrix.tt | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-67-gdeaa657362
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via deaa657362567308aa9837004376d3275e78bedf (commit) via 160f871856975f1a87ea23137267012086328877 (commit) from 27e540206b7d175d665e4e4c95588b931970d27e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit deaa657362567308aa9837004376d3275e78bedf Author: Nick Clemens Date: Sat Oct 24 02:07:51 2020 + Bug 26450: (QA follow-up) Replace tabs with spaces Signed-off-by: Jonathan Druart (cherry picked from commit cf12049ca1b71a5c5ef12092499fb39aea8f36e9) Signed-off-by: Lucas Gass commit 160f871856975f1a87ea23137267012086328877 Author: Andreas Roussos Date: Mon Sep 14 09:59:34 2020 +0200 Bug 26450: fix typo in plugin template The UNIMARC field 105 plugin template contains some dropdown menu options with unnecessary capitalisation: "w - Religious text". This patch fixes that. Test plan: apply the patch, and confirm that the dropdown menu options appear in all lowercase. Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 17f307285f5d877806ac95fe64ce154be03948b6) Signed-off-by: Lucas Gass --- Summary of changes: .../cataloguing/value_builder/unimarc_field_105.tt | 16 1 file changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-65-g27e540206b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 27e540206b7d175d665e4e4c95588b931970d27e (commit) via 8505b729a62250c7e7734efedf47a939bf6a258e (commit) via dbeb06986be273c53846333dd5e17e5acd04b44c (commit) from 54362935908bd9c2061598a9a150c721e620456d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 27e540206b7d175d665e4e4c95588b931970d27e Author: Nick Clemens Date: Sat Oct 24 00:42:31 2020 + Bug 26725: (QA follow-up) Add line break and 'the' for readability Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 17723b5423fcf644026130d8cc75e58986c55efb) Signed-off-by: Lucas Gass commit 8505b729a62250c7e7734efedf47a939bf6a258e Author: Tal Rogoff Date: Fri Oct 23 22:45:58 2020 + Bug 26725: link text changed to just system preference name. "system preference" put in sentence case. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 46b371a057e619264ad1c8d39abbcce7745ae734) Signed-off-by: Lucas Gass commit dbeb06986be273c53846333dd5e17e5acd04b44c Author: Tal Rogoff Date: Fri Oct 23 22:10:59 2020 + Bug 26725: changed the text of the "here" link on the patron attributes administration page test plan: 1. set ExtendedPatronAttributes system preferences to "Don't enable" 2. go to Administration > Patron attribute types 3. the link text of "here" is displayed in the blue box at the top of the page 4. apply the patch 5. refresh the page 6. notice the link text has changed to "ExtendedPatronAttributes System Preference" Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit b3a51fbc552ad89d7ee4604ac502cd2e7a7a8667) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-62-g5436293590
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 54362935908bd9c2061598a9a150c721e620456d (commit) from 3b8ca43be9aeed02982170a58a62388bed220d80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 54362935908bd9c2061598a9a150c721e620456d Author: Phil Ringnalda Date: Fri Oct 2 15:35:04 2020 -0700 Bug 26606: Correctly URI-encode query string in URL loaded after deleting an authority record If you search for "this & that" and delete one of the results, after it is deleted the search in the reloaded page is for "this " rather than for "this & that". The template uses the url filter, which is for filtering an entire URI where :, &, #, etc. should be left alone, rather than the uri filter which is for filtering a URI component where they should be encoded. To test: 1) Go to Authorities > New authority > New from Z39.50/SRU 2) Search for the Author (corporate) this & that collective 3) Actions > Import, Save 4) From the detail for that authority, Edit > Edit as new (duplicate) 5) Edit the 110 field, add 2 at the end and Save 6) Search authorities for this & that 7) For one of the ones you created, Actions > Delete, confirm 8) The page that reloads should have a search for this & that, not just for this Signed-off-by: Didier Gautheron Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 16e5a9d8dcf7ab332a455ff74e23115fde27a10f) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-61-g3b8ca43be9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3b8ca43be9aeed02982170a58a62388bed220d80 (commit) from 79a8302b6531a1be10f16003808cf7bb97e24575 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3b8ca43be9aeed02982170a58a62388bed220d80 Author: Owen Leonard Date: Wed Oct 21 17:15:30 2020 + Bug 26766: Correct selection of title during OPAC note confirmation This patch modifies the JavaScript in opac-user.tt which executes when the user submits a checkout note. The script tries to grab the checkout's title from an earlier cell in the table row so that it can display it in the confirmation message. Before start ratings were enabled on this page, the title of each checked-out item was the only HTML inside this table cell, so it was necessary only to grab the HTML contents of the . Now that star ratings might be displayed as well we must make the selection more specific. To test, apply the patch and enable both the OpacStarRatings and AllowCheckoutNotes preferences. - Log in to the OPAC as a user with checkouts. - On the "Your summary" page, fill out and submit the "Note" field for one of your checkouts. - In the confirmation message, confirm that the correct title information is displayed as a link to the bibliographic detail page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 54dcce14139bf5c60e98603a667629141296580e) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-60-g79a8302b65
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 79a8302b6531a1be10f16003808cf7bb97e24575 (commit) from 468ede88c555c0192a940fc2bb214a26cad85920 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 79a8302b6531a1be10f16003808cf7bb97e24575 Author: Owen Leonard Date: Wed Oct 21 11:57:26 2020 + Bug 26762: Modify template logic in opac-reserves.tt to avoid error This patch makes a change to the OPAC hold template to prevent certain cases where the output is invalid. To reproduce, perform a search in the OPAC which will return some titles which can be placed on hold and some which cannot. - Select all results (some holdable, some not) - Click the "Place hold" link - On the "Confirm holds" page the layout will be broken after the first instance of the message "There are no items that can be placed on hold." To test, apply the patch and repeat the process above. After the patch has been applied the "confirm holds" page should look correct. Validating the HTML source should return no errors. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit d10d24e42aaaf4b2e23b52b94aa14ab8745b396f) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-59-g468ede88c5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 468ede88c555c0192a940fc2bb214a26cad85920 (commit) from c854580e90f934bab6361bc3d8f72101f578dbfb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 468ede88c555c0192a940fc2bb214a26cad85920 Author: Owen Leonard Date: Tue Oct 20 16:04:11 2020 + Bug 26756: Fix quotes showing behind some system preference descriptions This patch adds matching quotes to two OPAC preference descriptions which were missing them. To test, apply the patch and go to Administration -> System preferences. - Open the "OPAC" tab. - Check the descriptions of these preferences: - AllowPatronToSetCheckoutsVisibilityForGuarantor - AllowPatronToSetFinesVisibilityForGuarantor There should be no trailing quotation mark. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2dab6ab31626970e3c9be841b610575060f8f344) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-58-gc854580e90
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via c854580e90f934bab6361bc3d8f72101f578dbfb (commit) from e47f2132add2b132806caeeff1631059b0f1cba8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit c854580e90f934bab6361bc3d8f72101f578dbfb Author: Lucas Gass Date: Fri Nov 13 21:36:34 2020 + Revert "Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode" This reverts commit e47f2132add2b132806caeeff1631059b0f1cba8. Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-57-ge47f2132ad
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e47f2132add2b132806caeeff1631059b0f1cba8 (commit) from 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e47f2132add2b132806caeeff1631059b0f1cba8 Author: Owen Leonard Date: Tue Oct 20 11:22:07 2020 + Bug 26619: Cart - The "Print" button is only translated when you are in "More details" mode This patch adds the "Print" string to datatables.js so that it can be picked up for translation. To test, apply the patch and add some items to the cart in the OPAC. - Open the cart. You should see a button labeled "Print." - The print button should work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/opac-tmpl/bootstrap/js/datatables.js for translation: msgid "Print" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the OPAC and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 599a6cb92e26e37857b344484d6c8b233555f0dc) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/js/datatables.js | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-56-g8232e315ad
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d (commit) from e7c500439c323fb2bee3d5f1a4ec848bdf600cbf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 8232e315ad9b08a33e0f7b0a5a5c06a5a00f823d Author: Owen Leonard Date: Mon Oct 19 18:32:18 2020 + Bug 25353: Correct eslint errors in additems.js This patch makes minor changes to additem.js to correct errors highlighted by eslint: - Consistent indentation - Notation of global and exported variables and functions - Consistent use of the "var" declaration for all new variables - Remove variables from function calls which aren't used To test, apply the patch and use your preferred eslint-enabled tool to check for errors. There should be none. If you don't have eslint integrated in your development environment you could use the online ESLint demo at https://eslint.org/demo. The demo isn't configured to assume a browser environment with jQuery present, so you'll have to modify the top line after pasting the contents of additem.js: /* global $ alert window __ */ Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit ebe08fb745b04899404bed5ceb00c891a518e89c) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/additem.js | 52 +++--- 1 file changed, 26 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-55-ge7c500439c
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e7c500439c323fb2bee3d5f1a4ec848bdf600cbf (commit) from 076fcca891258e9f9800066f4f6a33889247a5c3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e7c500439c323fb2bee3d5f1a4ec848bdf600cbf Author: Katrin Fischer Date: Sat Oct 17 15:08:59 2020 + Bug 26526: Relabel checkout note column in OPAC When checkout notes are active, there is currently a new column labelled 'Note' in the checkouts table in OPAC. When a note is added, this is sent to the library. For the user it's not clear from the label, that these notes are not personal, but for reporting to the library. The new label "Report a problem" aims to make this clearer. To test: - Turn on AllowCheckoutNotes system preference - Check out some items to your account - Go to the OPAC - Look at the list of checkouts - Apply patch - Reload the page and check the checkouts table again - Verify the heading has changed from "Notes" to "Report a problem" - Hover over the heading with your cursor to see some more info Bonus: Patch adds an id "checkout-notes" to the header cell, that will make it easier for libraries to change text or style if needed. Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 70c64fad46a91f910a00d59149000b982705fd24) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-54-g076fcca891
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 076fcca891258e9f9800066f4f6a33889247a5c3 (commit) via a88f367c63a2d649625fe367fa64ce3c888638ab (commit) via 5fc0d24ca8c58407e4461142054cb67a4aec5a00 (commit) via d88169db3bd51d30b489d762a615c1872f7f (commit) via 610fab83e0c8d0304f695e95174ae5804cb2ed72 (commit) via fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de (commit) from 7485f479fafb1b04d7681432c5cc421ab3f2afae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 076fcca891258e9f9800066f4f6a33889247a5c3 Author: Lucas Gass Date: Fri Nov 13 21:20:24 2020 + Bug 18050: DBRev 20.05.05.002 Signed-off-by: Lucas Gass commit a88f367c63a2d649625fe367fa64ce3c888638ab Author: Katrin Fischer Date: Mon Oct 5 06:17:34 2020 + Bug 18050: (QA follow-up) Adjust conditions and make use of message text - When we run into invalid data, we use Augustin's suggested solution and copy the data into a separate table, setting the budget_period_id to NULL. - We amend the output using the new $message. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 3c8bef50a223e70fe3023222f5f940a2b1771b5d) Signed-off-by: Lucas Gass commit 5fc0d24ca8c58407e4461142054cb67a4aec5a00 Author: Agustin Moyano Date: Fri Oct 9 15:14:26 2020 -0300 Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 11938beb4a10a78e385b221c0f908d92dcf6) Signed-off-by: Lucas Gass commit d88169db3bd51d30b489d762a615c1872f7f Author: Katrin Fischer Date: Sun Sep 13 23:31:52 2020 + Bug 18050: Add relation alias to schema Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 2800b53bdd6df1e87f72673bc79ed4896f4e4e35) Signed-off-by: Lucas Gass commit 610fab83e0c8d0304f695e95174ae5804cb2ed72 Author: Lucas Gass Date: Fri Nov 13 21:15:16 2020 + Bug 18050: DBIC Signed-off-by: Lucas Gass commit fee8aa2b1cf4c90c37e55d7286bafe8a8b0307de Author: Katrin Fischer Date: Sun Sep 13 22:42:27 2020 + Bug 18050: Add FK constraint on aqbudgets.budget_period_id This adds a FK constraint on aqbudgets.budget_period_id so that a fund cannot be added with an invalid aqbudget.budget_period_id. We should not have funds that belong to no budget. In case we have, the update will be skipped and a note displayed. Part1: - Before applying the patch - Make sure you have a budget with some funds linked to it - You will have to change one of the funds to link to an invalid budget with SQL: UPDATE aqbudgets SET budget_period_id = 999 WHERE budget_id = max(budget_id); - Apply patch - Run updatedatabase - verify that you see the hint about 1 existing fund with invalid budget. - Repair your fund with SQL UPDATE aqbudgets SET budget_period_id = ... WHERE budget_id = max(budget_id); (... needs to be your existing budget_period_id) - Run updatedatabase again - verify it runs successfully now. - If you try to change the budget_period_id to a non-existing now with SQL, you will get a database error. The new FK doesn't permit it. Part 2: - Start fresh with the web installer, verify there are no errors on creating the database tables Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 0ce62b29bf5ebe30125eb4c631de11391134f109) Signed-off-by: Lucas Gass --- Summary of changes: Koha.pm| 2 +- Koha/Schema/Result/Aqbudget.pm | 33 +--- Koha/Schema/Result/Aqbudgetperiod.pm | 21 -- installer/data/mysql/kohastructure.sql | 3 ++- installer/data/mysql/updatedatabase.pl | 39 ++ 5 files changed, 91 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-48-g7485f479fa
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 7485f479fafb1b04d7681432c5cc421ab3f2afae (commit) via 7a1fe44a376d594d2b7c7ce26d0bae421bf109b4 (commit) via 3890be5ba9f8f082c8ea8bf227411e97f624f251 (commit) from 5b8544989846db705747ec0738ad24cddd012ad4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 7485f479fafb1b04d7681432c5cc421ab3f2afae Author: Jonathan Druart Date: Mon Nov 2 08:42:20 2020 +0100 Bug 26673: Fix perlcritic complains This patch fixes the following perlcritic complain: Package declaration must match filename at line 19, column 1. Correct the filename or package statement. Signed-off-by: Jonathan Druart (cherry picked from commit 59588c3a3e3390c2796ac417696829fd26fcb4f0) Signed-off-by: Lucas Gass commit 7a1fe44a376d594d2b7c7ce26d0bae421bf109b4 Author: David Cook Date: Wed Oct 14 22:53:24 2020 + Bug 26673: Remove #!/usr/bin/env perl from .pm modules too Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit e692b40523839bda45a20e4cf1cac7cdfbf53a13) Signed-off-by: Lucas Gass commit 3890be5ba9f8f082c8ea8bf227411e97f624f251 Author: Jonathan Druart Date: Wed Oct 14 11:24:33 2020 +0200 Bug 26673: Remove shebangs from Perl modules It's not needed. Signed-off-by: David Cook Signed-off-by: Joonas Kylmälä Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9f47b4ffd72211a216df67ef912b5eddb2b954db) Signed-off-by: Lucas Gass --- Summary of changes: C4/Barcodes/ValueBuilder.pm | 5 ++--- C4/SIP/Logger.pm | 1 - C4/SIP/SIPServer.pm | 1 - C4/ShelfBrowser.pm| 2 -- C4/TTParser.pm| 2 -- Koha/Z3950Responder.pm| 2 -- Koha/Z3950Responder/GenericSession.pm | 2 -- Koha/Z3950Responder/RPN.pm| 5 +++-- Koha/Z3950Responder/Session.pm| 2 -- Koha/Z3950Responder/ZebraSession.pm | 2 -- 10 files changed, 5 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-45-g5b85449898
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 5b8544989846db705747ec0738ad24cddd012ad4 (commit) from 3a671b0ca6b414d62cd652dafa83d2828b7020a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5b8544989846db705747ec0738ad24cddd012ad4 Author: Nick Clemens Date: Thu Oct 22 12:36:13 2020 + Bug 26784: Silence warns about comparing undefined values for MARC modification templates This patch simply checks if conditionals are defined before comparing We don't need to check actions because you cannot save an action without an action :-) To test: 1 - Define several actions for a MARC modification template 2 - Ensure you have actions with no conditionals 3 - Tail the intranet logs 4 - Browse to Tools->MARC modification templates 5 - Click 'Edit actions' for the template you setup above 6 - Note warns like: [2020/10/22 12:30:18] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/tools/marc_modification_templates.pl line 127. 7 - Apply patch 8 - Restart all the things 9 - Edit actions again and note no more warns Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 2dd19840449beadd1f1752bd8cc18f0163f7f8a4) Signed-off-by: Lucas Gass --- Summary of changes: tools/marc_modification_templates.pl | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-44-g3a671b0ca6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3a671b0ca6b414d62cd652dafa83d2828b7020a2 (commit) via 06150351b431064bbc9cf343b459276820d649fc (commit) from 50b6f91094b11df73021be162c7c49dd6ca1c615 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3a671b0ca6b414d62cd652dafa83d2828b7020a2 Author: Nick Clemens Date: Mon Nov 2 11:24:02 2020 + Bug 26781: (follow-up) Adjust tests as fields are no longer completely removed Signed-off-by: Jonathan Druart (cherry picked from commit 03742a1e246e68fa62c2f2fff963beba28f35c80) Signed-off-by: Lucas Gass commit 06150351b431064bbc9cf343b459276820d649fc Author: Nick Clemens Date: Thu Oct 22 10:59:17 2020 + Bug 26781: Check for subfield defined rather than truth To recreate: 1 - Have a record with 100$0 defined 2 - Define a Marc Modification template: Delete field 100$0 3 - Perform Batch record modification, enter the record above in the list of records 4 - Preview the MARC 5 - Note the entire 100 field has been deleted, don't modify the record 6 - Apply patch 7 - Restart all the things 8 - Test the modification again 9 - This time the preview confirms only the subfield 0 deleted 10 - Modify the record 11 - Confirm the record is correctly updated Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer JD amended patch: Fix typo ony vs only Signed-off-by: Jonathan Druart (cherry picked from commit be4f0c7639a679b1ec808e6e9cf9af0fc9576e79) Signed-off-by: Lucas Gass --- Summary of changes: Koha/SimpleMARC.pm | 2 +- t/SimpleMARC.t | 14 +- t/db_dependent/MarcModificationTemplates.t | 12 3 files changed, 26 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-42-g50b6f91094
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 50b6f91094b11df73021be162c7c49dd6ca1c615 (commit) via 8c1c56d94c9221c67025c10c580e0f84cbe3074e (commit) from 61362fd0431c6bc439507cc4e49c0810a704f925 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 50b6f91094b11df73021be162c7c49dd6ca1c615 Author: Kyle M Hall Date: Thu Nov 5 06:40:42 2020 -0500 Bug 26627: (QA follow-up) Remove barcode input by id Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart (cherry picked from commit ebb437349ebbadf90599c23a46126e5d8eda72da) Signed-off-by: Lucas Gass commit 8c1c56d94c9221c67025c10c580e0f84cbe3074e Author: Kyle M Hall Date: Wed Oct 7 11:01:02 2020 -0400 Bug 26627: Print and confirming a hold can cause an infinite loop Test plan: 1) Place a hold for pickup at library A 2) Confirm the hold and print slip 3) Checkin the item again 4) Confirm the hold and print slip 5) The modal returns, do it again 6) Apply this patch 7) Reload the page 8) Repeat steps 1-3 9) No loop! Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a71596fb395d449a62f5a6417780ed23948755c4) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-40-g61362fd043
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 61362fd0431c6bc439507cc4e49c0810a704f925 (commit) from d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 61362fd0431c6bc439507cc4e49c0810a704f925 Author: Mark Hofstetter Date: Mon Oct 19 17:28:19 2020 + Bug 26601: Add utf8 encoding to text output of overdue_notices.pl This patch sets the UTF8 encoding for output of overdue_notices.pl when outputting to txt. To test: 0/ Check out an item with due date yesterday (use specify due date) 1/ Create ODUE text with utf8 encoded characters, chinese characters, umlauts etc /cgi-bin/koha/tools/letter.pl?op=add_form=circulation=ODUE 2/ Run perl overdue_notices.pl -text ./ 3/ Verify encoding in the generated text file is incorrect 4/ Apply patch and repeat 2/ 3/ Confirm text now inludes properly encoded characters Sponsored-by: Styrian State Library Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer With German umlauts on my system the editor still showed the characters correctly (probably guessing the right encoding). Using Chinese made the problem visible. Signed-off-by: Jonathan Druart (cherry picked from commit 28d20b92be91ae509a7f71586ada2535d3c2007d) Signed-off-by: Lucas Gass --- Summary of changes: misc/cronjobs/overdue_notices.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-39-gd3466bf7a3
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff (commit) from b1d76c5d08af71c06cc03cfa06d46b46959dcbcf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit d3466bf7a3ba554d0ecd0fe0143628a468b4b7ff Author: Katrin Fischer Date: Tue Oct 20 16:55:37 2020 + Bug 26686: Fix sorting of "updated on" and "time created" on notices tab In the patron's account in the staff interface there is a tab 'Notices' that shows all notices sent out to a patron. The updated on column would not sort at all, but there was also some markup missing for the time created column. To test: - Make sure you have a patron account with some notices, ideally with different times and dates - Verify that the updated on column doesn't sort at all - Apply patch - Verify both date columns now sort correctly for different DateFormat settings Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit b3be51d4ef2145b7db7b48c9ee32f86ddd34a964) Signed-off-by: Lucas Gass --- Summary of changes: .../intranet-tmpl/prog/en/modules/members/notices.tt | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-38-gb1d76c5d08
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via b1d76c5d08af71c06cc03cfa06d46b46959dcbcf (commit) from acc93b31cef93765f09b6585dbaad69d190b8fa2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b1d76c5d08af71c06cc03cfa06d46b46959dcbcf Author: Jonathan Druart Date: Thu Oct 15 10:47:55 2020 +0200 Bug 26445: Fix "back to result" link of the search result browser Not sure what was the expected behaviour, I am suggesting the following one: If you are browsing and you click "back to result", you will be redirected to the page where the record appear on the search result list. Say you search for "something" that returns 10 page (20 results per page) Click on first result first page Click back to result => You see the first page with the first result at the top Click on second page, 3rd result Click back to result => You see the second page with the biblio you clicked at the 3rd position Click on second page, 3rd result Click next/previous Click back to result => You see the page where you last result were. I think the existing expected behaviour was to have the result you clicked at the first position of the result page, but I am not sure it really makes sense. Hope this makes sense however! Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 3edbe7d7dc9358e55b4ecc9da5b292a32cadcce9) Signed-off-by: Lucas Gass --- Summary of changes: koha-tmpl/intranet-tmpl/js/browser.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-37-gacc93b31ce
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via acc93b31cef93765f09b6585dbaad69d190b8fa2 (commit) from 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit acc93b31cef93765f09b6585dbaad69d190b8fa2 Author: John Fawcett Date: Mon Oct 12 11:18:30 2020 +0200 Bug 26613: Fix it-IT unimarc_framework.sql installer file This is really an installation issue, though at the time of installation it did not result in any error. During cataloguing in the items menu the "Type of item or material" is not constrained by the itemtypes authorised_values (as it is for 942c records). I have added the itemtypes to the installer sql in unimarc_framework.sql as well as adding the description of this field for OPAC, which had been left empty. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3bd23a3287345167de50d994d737351174c04936) Signed-off-by: Lucas Gass --- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-36-g3973ef10b6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 (commit) from 86f801f350520910f78b78bfdaaa2783d7364929 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3973ef10b6b68eb4550dacf2c5a99475040dfdd1 Author: John Fawcett Date: Mon Oct 12 13:06:40 2020 +0200 Bug 26612: Error during web install for it-IT translation Patch changes some of the values in the sql statement that inserts 307a unimarc row into the marc_subfield_structure which created an SQL error on installation. The fields changed are: - isurl now 0 instead of NULL, - hidden now -5 instead of NULL, - seealso empty string instead of NULL, - link empty string instead of NULL. These field values are now similar to the ones inserted for 306a or 308a. The value that caused the SQL error was using NULL for hidden (due to the NOT NULL constraint in the table definition). I have tested the install with this change and found no issues. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 7c74c6636f779bbbaceee74f8704df9ec625815d) Signed-off-by: Lucas Gass --- Summary of changes: .../mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-35-g86f801f350
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via 86f801f350520910f78b78bfdaaa2783d7364929 (commit) via 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90 (commit) from ae2bce1312b63d732ec07df21ef16740a8d179d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 86f801f350520910f78b78bfdaaa2783d7364929 Author: Lucas Gass Date: Fri Nov 13 18:43:14 2020 + Bug 26569: DBRev 20.05.05.001 Signed-off-by: Lucas Gass commit 9de5ceeaec33f6f26fb2dfefbfd1fb6414ed9b90 Author: Andrew Fuerste-Henry Date: Wed Sep 30 13:14:12 2020 + Bug 26569: Use gender neutral pronouns in system prefernece explanations To test: 1 - perform query "select variable,explanation from systempreferences where explanation like '% his %';" 2 - find 6 sysprefs with gendered pronouns used in explanations 3 - apply patch, reset_all 4 - repeat query 5 - no more gendered pronouns! Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a96f5deef04bb74fbd826449b4d82f651a67512c) Signed-off-by: Lucas Gass --- Summary of changes: Koha.pm| 2 +- installer/data/mysql/sysprefs.sql | 12 ++-- installer/data/mysql/updatedatabase.pl | 13 + 3 files changed, 20 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-33-gae2bce1312
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via ae2bce1312b63d732ec07df21ef16740a8d179d2 (commit) from bd163aa5999e32e6f92b50f4b29d3ee4b22de94c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit ae2bce1312b63d732ec07df21ef16740a8d179d2 Author: Nick Clemens Date: Thu Sep 3 16:23:04 2020 + Bug 8437: Exclude export.pl from plack When attempting to download large files from Koha plack can timeout Excluding the script from plack is a simple fix until we have a more permanent fix for this issue. To test: 1 - Try to export your entire DB from Tools->Export 2 - If big enough, it fails 3 - Apply patch, copy changes to /etc/koha/apache-shared-intranet-plack.conf 4 - Restart all the things 5 - Repeat export, it succeeds Signed-off-by: David Cook Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 564ade93cce9231b01db1c4ebfc8f4e5b31e1acd) Signed-off-by: Lucas Gass --- Summary of changes: debian/templates/apache-shared-intranet-plack.conf | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-32-gbd163aa599
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via bd163aa5999e32e6f92b50f4b29d3ee4b22de94c (commit) via 67197c359eab0fb92c5df49edbb16008b3b33e92 (commit) from e3c24d9549d04a90a24d08f463f19e7a933b5ff7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit bd163aa5999e32e6f92b50f4b29d3ee4b22de94c Author: Nick Clemens Date: Sat Oct 24 23:53:21 2020 + Bug 23432: (QA follow-up) Add a unit test prove -v t/db_dependent/StockRotationItems.t Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 23292b53a8bc672f66ae95b1cfb7db5994d1eea5) Signed-off-by: Lucas Gass commit 67197c359eab0fb92c5df49edbb16008b3b33e92 Author: Martin Renvoize Date: Wed Sep 23 12:28:22 2020 +0100 Bug 23432: Replace 'die' with 'warn' This patch simply replaced the die statement with a warn such that the cron script may continue to rotate other items even if this item cannot be properly rotated due to corrupt data. Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 6adb1891d2bf602b0434eb87508568e73faa763e) Signed-off-by: Lucas Gass --- Summary of changes: Koha/StockRotationItem.pm | 2 +- t/db_dependent/StockRotationItems.t | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-30-ge3c24d9549
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via e3c24d9549d04a90a24d08f463f19e7a933b5ff7 (commit) via aec2d4a8f62fb4be19bddd3fe69663c3df93f1be (commit) from aeb33f91a500c9b022777e858df9c916932f50e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e3c24d9549d04a90a24d08f463f19e7a933b5ff7 Author: Didier Gautheron Date: Tue Aug 18 07:40:50 2020 +0200 Bug 26232: Empty smart rule fine grace period Staff can create smart rules with empty (undefined) fine grace period. In Overdues.pm undefined firstremind means 0, do the same in Circulation.pm. To test: 1. Apply these patches 2. Run: kshell prove t/db_dependent/Circulation.t Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7e66d6d190af4bd27739bdfe88049899f927c123) Signed-off-by: Lucas Gass commit aec2d4a8f62fb4be19bddd3fe69663c3df93f1be Author: Didier Gautheron Date: Tue Aug 18 07:39:53 2020 +0200 Bug 26232: Test for empty smart rule fine grace period Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit f6d614d4596728a3a2808eac2539754023e42262) --- Summary of changes: C4/Circulation.pm| 2 +- t/db_dependent/Circulation.t | 34 +- 2 files changed, 34 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 20.05.x updated. v20.05.05-28-gaeb33f91a5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 20.05.x has been updated via aeb33f91a500c9b022777e858df9c916932f50e0 (commit) from 710c9039ee6a1f465d1615f56ceafd3cb26fb184 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit aeb33f91a500c9b022777e858df9c916932f50e0 Author: Björn Nylén Date: Tue Oct 20 14:11:16 2020 +0200 Bug 26750: Deleted items not indexed After deleting an item it is still searchable in the index. Similar to bug 26507 where record is reindexed before the database is changed. To test: 1. Delete an item 2. Search the barcode in the main search box. You'll find the original record but wiht hte deleted item missing. 3. Apply patch. 4. Repeat steps 1-2 (with another item). No record should be found. Note to test you have to have the indexer running, not the cron job, and it needs to be running fast so that the index is updated before the delete takes place Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 395bb760394e6947303de7e342882148944e9026) Signed-off-by: Lucas Gass --- Summary of changes: Koha/Item.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
